commit | c210ef79d72e3701ec6a9c7a14b7770876056619 | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Mon Mar 11 10:21:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 11 10:21:23 2019 |
tree | f39ba13a3313f8c67fd4a0b0c094ac03d2c2dce8 | |
parent | 867da4174449c60d18718e6816e7f8f15e0d8ec6 [diff] |
Eliminate IdentityManagerFactory::BuildAuthenticatedInstanceForTesting() There are multiple layers of infrastructure to support building IdentityManager within the ProfileKeyedService infrastructure with a primary account from creation. This infrastructure is needed for only one unittest, of SigninProfileAttributesUpdater. It turns out that this unittest can easily be updated to explicitly construct the dependencies of SigninProfileAttributesUpdater rather than using the ProfileKeyedService infrastructure. This both makes the test itself simpler and enables ripping out all of the aforementioned layers of infrastructure. Bug: 939828 Change-Id: Ibc2c8cb6e5668d9f12917b0b081ba5f9471b55df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511973 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#639435}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .