commit c21cc33f5d86b8dd0004920ee41fee9b567bee52
author Fumitoshi Ukai <ukai@google.com> Fri Oct 25 03:34:37 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 25 03:34:37 2024
tree 4705a0f11eb4683d9a77c308734c37f43c486f13
parent e7a934a5fc70d384874267a3ddf2ce73d554f1ee

siso: handle --path_mappings in ts_library.py

fix for https://ci.chromium.org/ui/p/chromium/builders/build/linux-build-perf-siso/2879/overview

[23046/99899] ACTION //chrome/browser/resources/discards:build_ts(//build/toolchain/linux:clang_x64)
python3 ../../tools/typescript/ts_library.py --root_gen_dir ../../../.. --root_src_dir ../../../../../../../ --root_dir gen/chrome/browser/resources/discards/preprocessed --gen_dir gen/chrome/browser/resources/discards --out_dir gen/chrome/browser/resources/discards/tsc --output_suffix build_ts --in_files database_tab.ts discards_main.ts discards_tab.ts graph_tab.ts discards.ts graph.ts sorted_table_mixin.ts database_tab.html.ts discards_main.html.ts discards_tab.html.ts graph_tab.html.ts lifecycle_unit_state.mojom-webui.ts discards.mojom-webui.ts site_data.mojom-webui.ts --path_mappings_file path_mappings_build_path_map.json --definitions ../../../../../../../tools/typescript/definitions/strings.d.ts --deps ../../../../third_party/polymer/v3_0/tsconfig_library.json ../../../../ui/webui/resources/cr_elements/tsconfig_build_ts.json ../../../../ui/webui/resources/js/tsconfig_build_ts.json ../../../../ui/webui/resources/mojo/tsconfig_build_ts.json --tsconfig_base ../../../../../../../chrome/browser/resources/discards/tsconfig_base.json --composite --path_mappings /tools/typescript/definitions/*|../../../../../../../tools/typescript/definitions/* /strings.m.js|../../../../../../../tools/typescript/definitions/strings.d.ts chrome://resources/d3/d3.min.js|../../../../../../../third_party/d3/src/d3.min.js
Traceback (most recent call last):
  File "/b/s/w/ir/cache/builder/src/out/Release/../../tools/typescript/ts_library.py", line 281, in <module>
    main(sys.argv[1:])
  File "/b/s/w/ir/cache/builder/src/out/Release/../../tools/typescript/ts_library.py", line 227, in main
    node.RunNode([
  File "/b/s/w/ir/cache/builder/src/third_party/node/node.py", line 55, in RunNode
    raise RuntimeError('Command \'%s\' failed\n%s' % (' '.join(cmd), err))
RuntimeError: Command '/b/s/w/ir/cache/builder/src/third_party/node/linux/node-linux-x64/bin/node /b/s/w/ir/cache/builder/src/third_party/node/node_modules/typescript/bin/tsc --project gen/chrome/browser/resources/discards/tsconfig_build_ts.json' failed
gen/chrome/browser/resources/discards/preprocessed/graph.ts:5:8 - error TS2792: Cannot find module 'chrome://resources/d3/d3.min.js'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?

5 import 'chrome://resources/d3/d3.min.js';
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in gen/chrome/browser/resources/discards/preprocessed/graph.ts:5

Change-Id: I827ca82187e97d6444dd462e44bb55d8ffc019e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5964076
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1373717}