commit c224bca66cf1e749c1026bd181b53c649cb5649c
author Luciano Pacheco <lucmult@chromium.org> Mon Jul 05 02:34:53 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 05 02:34:53 2021
tree 9aebe04eb83e5a31bf0230bc939efbd415805f6d
parent 82bf1768c275cb05248064731ade5ff11d0b6015

Reland "Files SWA: Fix missing translations"

This is a reland of 2ef25a4b4addb5e33e734838ec6276c86667fc66

Test FileManagerJsTest.FilesDisplayPanel was failing because the
implementation changed the translation from "$i18n{FILE_ERROR_GENERIC}"
to just "FILE_ERROR_GENERIC", so the unittest had to be updated
accordingly.

Fix:
https://chromium-review.googlesource.com/c/chromium/src/+/3004121/1..2

Original change's description:
> Files SWA: Fix missing translations
>
> The SWA uses source->EnableReplaceI18nInJS() which only replaces
> translation strings within the template markup:
> <!--_html_template_start_--> and <!--_html_template_end_-->.
>
> To fix the translation this CL move all HTML from the JS file to a
> HTML file and use html_to_js() build rule to merge the content in the
> JS.  This build rule already appends the required markup around the
> template.  This makes all JS files consistently using html_to_js().
>
> Some translations are updated to use the runtime translation function
> str().
>
> Bug: b/187783576 1225571
> Change-Id: I1ee9f5d91baa167c508c0bfa62f0121db51538ee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999922
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Reviewed-by: Bo Majewski <majewski@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#898039}

Bug: b/187783576 1225571
Change-Id: Ieb96930f36ec96eeba3a6f8aadbc8e5c2e296ab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004121
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Bo Majewski <majewski@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898495}