Fix: Restore download drag icon rendering

This is a follow-up CL to the previous CL [1], which moved the icon
painting logic back to `LabelButton`. The move was necessary as the
earlier fix CL [2] for this bug introduced visual regressions in other
`LabelButton`s, including some Ring 0 buttons.

However, bringing the logic back to `LabelButton` caused this previously
resolved bug to reappear — the icon stopped rendering when dragging an
item from the downloads bubble.

Fix: This CL disables icon layer painting logic specifically for the
drag contents button. This restores the expected drag icon behavior
without impacting other `LabelButton` instances.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/6576165
[2] https://chromium-review.googlesource.com/c/chromium/src/+/6279834

Please find the attached screencast below after the fix:
https://drive.google.com/file/d/148X6lPYtpTQkhT-rtnmfR9wsYKbHKO4R/view?usp=sharing

Bug: 394380766, 414783688
Change-Id: I6584e1328072e7bb28bb47cfce76219f568d4ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580519
Reviewed-by: David Yeung <dayeung@chromium.org>
Commit-Queue: Vansh Parikh <vanshparikh@microsoft.com>
Reviewed-by: Ahmed Moussa <ahmedmoussa@google.com>
Cr-Commit-Position: refs/heads/main@{#1464503}
1 file changed
tree: 058abd004253c38348a3441f9eef52dba0e2d058
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. SECURITY_OWNERS
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.