Google Git
Sign in
chromium / chromium / src / c23f99b74b4f738fe1f5a3e04cca8c9d2f17aaed
commitc23f99b74b4f738fe1f5a3e04cca8c9d2f17aaed[log] [tgz]
authorChangSeok Oh <changseok.oh@bytedance.com>Wed Oct 18 18:45:40 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 18 18:45:40 2023
tree6f5b8cdbdec5b77cb525dbf2862fe3aed7ab3953
parentaf07921fab7fe0b3efd22fffd8e1582ed5d78235 [diff]
Make document.fonts.check() in conformance with the updated spec.

The document.fonts.check() neither behaves as the current spec document
describes [1] nor other rendering engines behave. First, the
FontFaceSet::check() should return true for non-existent fonts [2].
Second, the check method should not reveal any platform fallback font
existence. Third, the existing implementation does not follow the
updated checking steps (e.g., checking the range intersection with the
given text is inefficient and erroneous, where all found font faces
support the same character set). So, this CL re-implements
document.fonts.check(), conforming to the standard and other engines'
behaviors.

[1] https://www.w3.org/TR/css-font-loading/#font-face-set-check
[2] https://github.com/w3c/csswg-drafts/issues/5744

Test: external/wpt/css/css-fonts/fallback-url-to-local.html
      fast/css/fontfaceset-check-platform-fonts.html

Bug: 1416842
Change-Id: I246792ec99190db5a8b59f653bc19cfbb7850d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4913179
Commit-Queue: ChangSeok Oh <changseok.oh@bytedance.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1211649}
4 files changed
tree: 6f5b8cdbdec5b77cb525dbf2862fe3aed7ab3953
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.