Reland "[ios] Use macro to define base::ThreadChecker member fields"

This is a reland of commit bd9f2392d1e6c921957b46c6e39d176e2fca3c2d

The original CL forgot to replace a call to DetachFromThread() method
by the corresponding macro version DETACH_FROM_THREAD(...). This was
not found on the CQ because this is only visible when building without
DCHECK_IS_ON().

Original change's description:
> [ios] Use macro to define base::ThreadChecker member fields
>
> Use THREAD_CHECKER(...) macro and DCHECK_CALLED_ON_VALID_THREAD(...)
> when using a base::ThreadChecker as this allow to remove the empty
> object when building with CHECK disabled.
>
> Not converting to SEQUENCE_CHECKER(...) since it is unclear whether
> those objects are thread-affine or just sequence-affine.
>
> Bug: none
> Low-Coverage-Reason: Cleanup of untested code.
> Change-Id: I44b10f370e299df419a24b99812d73a3ee558544
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776743
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Mark Cogan <marq@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1340298}

Bug: none
Change-Id: Ia2aced103a6f8dde37e9f88fe9ee1cc16537a1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782754
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1340385}
3 files changed
tree: 3703e5f1549eadfd1eb3aa1ee0c5a3a8b8829aa3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.