Google Git
Sign in
chromium / chromium / src / c2fec79eb8637ab848548e1662fe36703dcad028
commitc2fec79eb8637ab848548e1662fe36703dcad028[log] [tgz]
authorKuan Huang <kuanhuang@chromium.org>Tue Sep 03 21:57:38 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Sep 03 21:57:38 2024
treeac95d34f76a78eb95680b5032fe20fb0bc1cff3f
parent4e69ce7b312afe20069c12040b9c71cc13a25c7c [diff]
Refactoring Bisect method in bisect-builds.py

This CL simplified the prefetch handling and conditions like

```
    if ((answer == 'g' and good_rev < bad_rev)
        or (answer == 'b' and bad_rev < good_rev)):
```

The new implementation reversed the rev_list to ensure rev_list[0] is
good and rev_list[-1] is bad and simply re-orders the return value. This
also fixed the issue that unknown was not working properly. Tests were
added to cover more cases.

This CL also improved the error report during run_revision. When an
error happens during run_revision, the zip_file and the tempdir will
remain on the disk while evaluating (normally AskIsGoodBuild), so that
users can debug the failure with the downloaded and unzipped archive.

Bug: 331962393
Change-Id: Ie4c19b86c0214ddabef159e44d8fe19cbb573baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5825029
Commit-Queue: Kuan Huang <kuanhuang@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350427}
2 files changed
tree: ac95d34f76a78eb95680b5032fe20fb0bc1cff3f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.