Google GitGoogle Git
Sign in
chromium/chromium/src/c35c9d1368423b1c94bb396e7fe589fbc84d15e8
commit
c35c9d1368423b1c94bb396e7fe589fbc84d15e8
[log]
author
Emircan Uysaler <emircan@chromium.org>
Sat Nov 14 03:44:51 2020
committer
Commit Bot <commit-bot@chromium.org>
Sat Nov 14 03:44:51 2020
tree
b8c20a75dc281833b8fd6033a6eea94f41c22094
parent
8f60186caac1450314698d57b9cb859ecd748fd6 [diff]
[Fuchsia] Don't hold ptr to ScenicSurface from ScenicOverlayView

This CL addresses the crash that occurs when ScenicSurface is
destructed before ScenicOverlayView. When that occurs raw pointer
held by ScenicOverlayView is invalid, so we should check
ScenicSurfaceFactory for a reference instead.

Bug: 1148797
Change-Id: I7972a09227e72c212254044f8e6800d50cbe470f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536775
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827559}
5 files changed
tree: b8c20a75dc281833b8fd6033a6eea94f41c22094
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.