Google Git
Sign in
chromium / chromium / src / c3b03219e154734ed6f38a09e86fc55079c45f8b
commitc3b03219e154734ed6f38a09e86fc55079c45f8b[log] [tgz]
authorMilena Krawczyk <mikr@google.com>Mon Feb 10 17:31:47 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 10 17:31:47 2025
tree20477edf0d31c6588fd675d685899113e3724722
parentaf679a80532665255789450f87aeb963fa7e0343 [diff]
split_variations_cmd: Decode trial group names properly

Field trial group names should be decoded with urllib.parse.unquote_plus, not unquote. This fixes a bug where encoding in split_variations_cmd.py disagrees with the encoding of Chromium (https://source.chromium.org/chromium/chromium/src/+/main:components/variations/field_trial_config/field_trial_util.cc;l=209-212) which is %-encoded (URL encoded).

unquote_plus is a function that performs the same operation as unquote but also replaces plus signs with spaces. This results in strings being equally decoded.

This CL contains a unit test that is run against two values: one with +:Scale+120%  and one with space: Scale 120%.

Change-Id: I9393bd30fea4daf86e538d77dcb585bee794c628

Bug: 40218235
Change-Id: I9393bd30fea4daf86e538d77dcb585bee794c628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179892
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Milena Krawczyk <mikr@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/main@{#1418213}
2 files changed
tree: 20477edf0d31c6588fd675d685899113e3724722
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.