commit c3e61fd7dfce1340da901e4fccfb34eae4e20c07
author Timothy Loh <timloh@chromium.org> Thu Oct 07 06:03:29 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 07 06:03:29 2021
tree fc8dbbe046a181331eaa1fc7ac7bf4c1eec3284d
parent 0e7a62cd0ed446b313a94a6a34b64a6ecba9e9e4

Revert "Reland "Add region search support for non-Google default search providers."."

This reverts commit 23f829c698968c11a75e96bdcd3d7735d97179af.

Reason for revert: Breaks TranslateManagerRenderViewHostTest.BubbleUnknownLanguage on linux-chromeos-chrome

[ RUN      ] TranslateManagerRenderViewHostTest.BubbleUnknownLanguage
Received signal 11 SEGV_MAPERR 000000000108
#0 0x56400916c589 base::debug::CollectStackTrace()
#1 0x5640090da7c3 base::debug::StackTrace::StackTrace()
#2 0x56400916c0df base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fc34d615980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f)
#4 0x56400acc1794 TemplateURLService::GetDefaultSearchProvider()
#5 0x564009765d6a RenderViewContextMenu::IsRegionSearchEnabled()
#6 0x564009762d17 RenderViewContextMenu::AppendPageItems()
#7 0x564009762838 RenderViewContextMenu::InitMenu()
#8 0x56400886430c RenderViewContextMenuBase::Init()
#9 0x5640034ae263 translate::(anonymous namespace)::TranslateManagerRenderViewHostTest_BubbleUnknownLanguage_Test::TestBody()
...

Original change's description:
> Reland "Add region search support for non-Google default search providers.".
>
> This an attempted reland of the following reverted change:
> https://chromium-review.googlesource.com/c/chromium/src/+/3199698
>
> PS1 is identical to the original change with a few minor modifications to resolve merge conflicts.
>
> The changes from the original is the adding of an instance variable to LensRegionSearchController representing whether the default search engine is Google. This could not be used in the controller directly due to an include rule. This is now instead passed as part of the Start() function through render_view_context_menu.
>
>
> Bug: 1255702,1255897, b/198833501
> Change-Id: I83c4b0a5728ab3ba122d248c05c2f27b76a05a4b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203970
> Commit-Queue: Juan Mojica <juanmojica@google.com>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Ben Goldberger <benwgold@google.com>
> Cr-Commit-Position: refs/heads/main@{#928974}

Bug: 1255702,1255897, b/198833501
Change-Id: I1bf2e732ac781a5708f4a319ecf5df960239a860
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210916
Auto-Submit: Timothy Loh <timloh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Owners-Override: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929066}