| commit | c3e787ece0de528f6b5a44a9c7460729380b35a9 | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@chromium.org> | Thu Jan 23 16:30:27 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 23 16:30:27 2025 |
| tree | 1ae63d481d62ea24788eca57d4bbf21033d67cc0 | |
| parent | 474a48d8ada3c1bb6b3c85752d546dd86a463dd6 [diff] |
Stop passing `-Coverflow-checks=on` to the Rust compiler. We are unifying Chromium behavior with Rust defaults based on what we learned about 1) utility of the checks, 2) higher than expected performance impact, and 3) the practical aspects of maintaining exemptions. Note that this change has no impact on undefined behavior or memory safety in Rust - it's still well defined what happens if integer overflow checks happen at runtime: after this CL it produces a defined overflowed/wrapped-around value instead of crashing. For more details, please see https://docs.google.com/document/d/1sXZnr7pfUY9qe18NuqaBwMI7kdXjqLVCyJ-nyCAnejs/edit?usp=sharing Bug: None Change-Id: I46b041f207fe37ae40e42f4112d560b5b5f1217e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176309 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/main@{#1410373}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.