Google Git
Sign in
chromium / chromium / src / a108daa6caa4205a6ff0671f467945042b453097
commita108daa6caa4205a6ff0671f467945042b453097[log] [tgz]
authorClaudio DeSouza <cdesouza@igalia.com>Thu Aug 18 09:29:43 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 18 09:29:43 2022
treeeab155af03127749379efd0ee345af771047a6ea
parent6ffeaabf70cea1d169712faa762247bce9a14b5f [diff]
Reland "[CodeHealth] Settings WebUI base::Value refactoring - Part 1"

In this CL OnStartupHandler::GetNtpExtension now returns a base::Value,
as `null` is a valid response to be sent by the handler.

This is a partial reland to a partial revert of the original commit. For
reference: https://crrev.com/c/3833396

This is a reland of commit f0e6d42f5906d8cac94c74f0c03070f984d8bfe0

Original change's description:
> [CodeHealth] Settings WebUI base::Value refactoring - Part 1
>
> This CL corrects the use of base value for the webui handlers of a
> couple of files under webui/settings.
>
> Bug: 1187001
> Change-Id: I4dc51df9ae48773d6e1fee292f7e7ba1dd9e83ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810934
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Commit-Queue: Claudio DeSouza <cdesouza@igalia.com>
> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1033140}

Bug: 1187001
Change-Id: I52d8f77159474fa39e8a5e663e46fdc709104f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828620
Commit-Queue: Claudio DeSouza <cdesouza@igalia.com>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1036525}
1 file changed
tree: eab155af03127749379efd0ee345af771047a6ea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.