commit | c4a0e1bb71c919a617e04a854b51ee5efe31b102 | [log] [tgz] |
---|---|---|
author | Ernesto Izquierdo Clua <eic@google.com> | Mon Sep 12 16:59:08 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 12 16:59:08 2022 |
tree | 0bed0b77835b1b3b8b60f88ebc9289bad2f96c0a | |
parent | a42fa9893812fb86de0b06b096a5072844fb870d [diff] |
[CVC] Handle form submissions and errors. This patch completes the implementation of the new autofill CVC prompt. It handles the submission of the CVC and expiration date forms, loading state and error alerts. New iOS-specific strings were added for verification errors. The patch also adds unit tests for the new CVC prompt given that manual testing is limited by some payment backend restrictions. Mocks: https://www.figma.com/file/Gm9VJiRuLng7byxfAFOUeB/Passwords?node-id=3491%3A346973 Implemented UX: Light: - Loading: https://screenshot.googleplex.com/wHqi5ErD6dfQYt9 - Error: https://screenshot.googleplex.com/AKYcxs8FBWVXaoJ Dark: - Loading: https://screenshot.googleplex.com/9wLoxhWWM4Pwfqc - Error: https://screenshot.googleplex.com/7ftWb33cwpryCjP LOW_COVERAGE_REASON=Non covered code in card_unmask_prompt_controller_impl.cc are lines fetching string messages. In the case of card_unmask_prompt_view_bridge.mm, manual testing is used for verifying the bridge presents and dismisses the cvc prompt as expected. Change-Id: I9d8cf00dbb5b3e294a2a32a10b3fad90bd020d96 Fixed: 1347184 Bug: 1351481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834783 Auto-Submit: Ernesto Izquierdo Clua <eic@google.com> Commit-Queue: Ernesto Izquierdo Clua <eic@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/main@{#1045878}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.