commit c4ab4a716a8077759b5eb0a5760b45cbd11704cc
author dljames <dljames@google.com> Wed Oct 12 16:05:19 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 12 16:05:19 2022
tree 2faa4e5db27bc03161444c41c1fd5da2aae72193
parent 015376180a829114cc3d819568883d2bab5a1d6b

[ Bug Fix ] Combobox does not run callback on index change

Changing the selection index of the combobox in the side panel via
arrow keys or letter keys on the keyboard ('r', 'b', etc.) would not
update contents of the side panel.

This fix solves this issue by running the callback when a new selection
index is registered / selected.

Bug: 1355882
Change-Id: Iea92d4f565233627d14d6ce42fade2ddfc038cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3946284
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1058081}

ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index 8ece700..1be7478 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -432,6 +432,9 @@
   }
 
   if (new_index.has_value()) {
+    if (menu_selection_at_callback_)
+      menu_selection_at_callback_.Run(new_index.value());
+
     SetSelectedIndex(new_index);
     OnPerformAction();
   }