| commit | c4ad628b965d077f2f3c1d35506beead744d5f85 | [log] [tgz] |
|---|---|---|
| author | arthursonzogni <arthursonzogni@chromium.org> | Thu Mar 04 14:05:26 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 04 14:05:26 2021 |
| tree | 52ffeef131fde874e381293a111bf227ca25090a | |
| parent | 29adfe06b3634f8bc09b4c42eecef7966f797d7b [diff] |
[COOP access reporting] Fix crash, invalid cast.
This is meant to be merged into M90.
COOP accesses from a sub documents is reported, only when it is
same-origin with its top-level document.
There was an obvious mistake in the code. We checked:
accessing_frame->IsCrossOriginToParentFrame()
instead of:
accessing_frame->IsCrossOriginToMainFrame()
Then the cast toward a LocalFrame was invalid:
```
LocalFrame& accessing_main_frame =
To<LocalFrame>(accessing_frame->Tree().Top());
```
The fix is more than trivial and a regression test is provided. Here are the
results without the fix:
https://chromium-review.googlesource.com/c/chromium/src/+/2731993
Bug: 1183571
Change-Id: I30a213eb3cdd729e918398af1382752d86f1ba3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2732471
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859750}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.