Google Git
Sign in
chromium / chromium / src / c4e5fde75069ea43e69e26ddca6290f67f7adc5c
commitc4e5fde75069ea43e69e26ddca6290f67f7adc5c[log] [tgz]
authorElly Fong-Jones <ellyjones@google.com>Thu Aug 24 21:05:26 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 24 21:05:26 2023
tree7ca217747049d75a8219a465a22c158659b43f8b
parent2887a0a67cb41519077275da42efc993126f1281 [diff]
views: triage raw_ptr in ViewMacTest

This change refactors the offending raw_ptr out of existence by
replacing the test fixture with a single free function and a few lines
of inline code in the test body.

This change also simplifies some confusing (imo) test code, which was
working with coordinate pairs in different coordinate systems within
expressions, by being more explicit about what is being tested for.

Bug: 1469136
Change-Id: Idbc81df608633d52a1d6d6bb934ab784173fb13c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4810899
Reviewed-by: Dana Fried <dfried@chromium.org>
Auto-Submit: Elly FJ <ellyjones@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188021}
1 file changed
tree: 7ca217747049d75a8219a465a22c158659b43f8b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. weblayer/
  52. clank
  53. internal
  54. ios_internal
  55. native_client
  56. signing_keys
  57. v8
  58. .clang-format
  59. .clang-tidy
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.