Google Git
Sign in
chromium / chromium / src / c4f9209861aec694312eed7e31f5290cfee17408
commitc4f9209861aec694312eed7e31f5290cfee17408[log] [tgz]
authorStefano Duo <stefanoduo@google.com>Thu May 04 11:18:01 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 04 11:18:01 2023
tree5bfe11c92f32a2d602b98518702be3034090ffb4
parent2f41f3d9e87f49ade8b38a9e393d1d2839d59bed [diff]
Refactor TestFilesInstaller calls inside startHttp2TestServer

Similarly to QuicTestServer and NativeTestServer, let Http2TestServer
handle calls to TestFilesInstaller.installIfNeeded.

Right now Http2TestServer expects that to be called prior to
Http2TestServer.startHttp2TestServer calls. Leading to some tests
calling it and some others not, which is error prone.

Bug: b:279585863
Cq-Include-Trybots: luci.chromium.try:android-cronet-arm-dbg,android-cronet-arm64-dbg,android-cronet-arm64-rel,android-cronet-x86-dbg,android-cronet-x86-dbg-10-tests,android-cronet-x86-dbg-11-tests,android-cronet-x86-dbg-pie-tests,android-cronet-x86-rel,android-cronet-x86-rel-kitkat-tests,ios-simulator-cronet,ios-m1-simulator-cronet,android_cronet
Change-Id: Ic995038b027729957d3bb265945d20d1365765b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501229
Reviewed-by: Dan Stahr <danstahr@google.com>
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Cr-Commit-Position: refs/heads/main@{#1139437}
9 files changed
tree: 5bfe11c92f32a2d602b98518702be3034090ffb4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.