[Android] Prepare TabRedirectHandler.java for componentization

We had initially thought that it would make sense to fork //chrome's
TabRedirectHandler.java for usage in //weblayer. However, on
investigation its //chrome dependencies are essentially layered on top
of its core logic, the latter of which can be shared directly with
WebLayer. This CL thus prepares TabRedirectHandler for componentization
by moving its association with Tab to a RedirectHandlerTabHelper thin
wrapper object. Future CLs will componentize TabRedirectHandler as
RedirectHandlerImpl and then merge it back into the RedirectHandler
interface (eliminating the latter as an interface).

A side benefit of this change is that it removes the remaining
//chrome dependencies from ExternalNavigationHandlerTest.java, as this
test now explicitly passes in the values for the flows that it wants
to test to TabRedirectHandler#updateIntent() rather than needing to
configure the latter's behavior via mutating //chrome-level state.

Finally, as part of this change various CustomTab-related unittests now
need to mock out an access to ChromeFeatureList. This is because with
this refactoring that access now happens before an early return in
TabRedirectHandler#updateIntent(), whereas before the access was after
that early return.

Bug: 1031465
Change-Id: Idabfe225fb77cf3bfe454d7ff1d63c9e801b8fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127090
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757012}
14 files changed
tree: c07537df6689e2b37ea0f739dce498abeec6a816
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.