Google Git
Sign in
chromium / chromium / src / c62ea81a60687c637f007fa1d54cbbf3a8be89b5
commitc62ea81a60687c637f007fa1d54cbbf3a8be89b5[log] [tgz]
authorByungwoo Lee <blee@igalia.com>Fri May 26 12:33:30 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 26 12:33:30 2023
tree75d1636fd2115650d880cc036f2e0860023db246
parent696f10b488c54f779129aa5099fe0600e610745e [diff]
Fix waitForDebuggerOnStart bug on auto-attached ServiceWorker Target

When we stop a ServiceWorker and start it again while using selenium,
the ServiceWorker stays in 'starting' state and does not go to
'running'.

This behavior is related to how the Devtools protocol currently
handles waitForDebuggerOnStart flag for auto-attached ServiceWorker
Target.

Currently, ServiceWorkerDevtoolsManager always sets 'pause_on_start'
for the stopped ServiceWorker's agent-host, even if the ServiceWorker
should not pause on start if a Target is attached to the ServiceWorker
(e.g. Target attached with 'waitForDebuggerOnStart:false' option)

This CL adds a conditional check (agent_host->should_pause_on_start())
when setting 'pause_on_start' for a stopped ServiceWorker to avoid
unnecessary pausing.

Bug: 1325792
Change-Id: I0a1f1054fe6f006419c130090eaf5147ec65ba22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4554604
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Byungwoo Lee <blee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1149676}
3 files changed
tree: 75d1636fd2115650d880cc036f2e0860023db246
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.