removing to-do comment for b/234892353 After long consideration, 2 solutions were found to solve this bug, the first one would be to define the constructor of the AccessCodeCastSinkService class as public, this solution, however, would leave the access to this constructor very open, which would not be advisable, since our objective is that the instances of this class are supposed to be created from the Factory, on the other hand, we understand that, because it is a factory class, it might make sense to leave it as a Friend class, to grant it access over the constructor of the aforementioned class, without release its access to other classes. Change-Id: I27d5c21714ccc54b447dc7f55a2b83a79cfb6196 Bug: b/234892353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824141 Reviewed-by: George Benz <gbj@google.com> Commit-Queue: Felipe Araújo <felipebma@google.com> Cr-Commit-Position: refs/heads/main@{#1033794}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.