commit c66b948ed9c059c173f94282cb1ee2a64ee8545c
author Justin Cohen <justincohen@google.com> Wed Nov 16 01:53:22 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 16 01:53:22 2022
tree eaf0bfdd5982a0b37c8215dcc49f873b730c87c4
parent 959dd213dbc02be23f5f1771ed51ef52970645a6

ios: Clean up some failed startup count uses.

This makes 2 small tweaks to the failed startup counter.

1) Clear the startup counter when the app is resigned. If the app is
able to make it to background, then it didn't crash.

2) Remove the WebStateObserver for a non-NTP load. Historically, the
startup attempt counter supposed to be cleared after any user interaction
(such as a non-NTP page load). However, this logic broke many milestone ago
and is now clearing the counter on any page load. This means any
insta-crashes caused by the NTP won't trigger safe mode. Even if this
worked, the original intent was to include any crashes triggered by a
user-action (loading a page). While WKWebView now crashes out-of-process,
it's still possible for any app-side hooks from page loading to trigger
a crash -- both during and immediately after a page load. That means
clearing at this point is counter productive.

Note that scheduleStartupAttemptReset will still be triggered as a low
priority task after startup, which happens approximately 5 seconds after
launch.

Bug: 1384608
Change-Id: I696d7d499dd62f65feb76f0ae9d8a5f33abb1a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027424
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1071984}