[Bedrock] Refactor some controllers

The following types of refactoring were done:
1. raw_ptr members were converted to raw_ref if the pointer was not
   null and its lifetime exceeded that of the class.
2. All the objects that a class depended on were explicitly passed as
   parameters, instead of querying them from the single parameter
   BrowserWindowInterface.

Converting raw_ref to pointer is a little tedious. So in case where
&member_.get() pattern was being used "multiple" times in .cc file,
helper functions were created for ease of use - e.g., GetProfile().

In DeletionDialogController, the TabStripModel::RemoveObserver call was
removed from the destructor because TabStripModelObserver already does
that job in its destructor.

For BrowserExtensionWindowController, based on offline discussions, we
decided not to apply refactoring 2.

Bug: 430452847

Change-Id: I11569a72090de4bc780784340930105625807047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6732097
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Commit-Queue: Chandranath Bhattacharyya <chbhatt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1487215}
26 files changed
tree: 9313cb64cbc5dd0f4fc067551ed304d42b05d5fa
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. SECURITY_OWNERS
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.