Merge <use> instance association and removal of disallowed elements If we remove an element because it's disallowed during <use> shadow tree construction, we won't clear the corresponding element reference that we set up just before. This can cause the DCHECK in CorrespondingElement() to trigger, because the element will have a corresponding element, but not be part of a shadow root. Merge the AssociateCorrespondingElements() and RemoveDisallowedElementsFromSubtree() actions into a single subtree walk that performs both of the actions at the same time. This is marginally more complex and prevents a disallowed element from being associated with its corresponding element. Fixed: 1371700 Change-Id: I21c963d898716b1ddf1486baf07b383c74a24dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3936288 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1055940}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.