commit | c6f8c74252ee068aab950b22030c83f7df12034c | [log] [tgz] |
---|---|---|
author | Mason Freed <masonf@chromium.org> | Thu Dec 08 01:19:08 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 08 01:19:08 2022 |
tree | 10790306c9d03abb3fec231a43351dbd8594ecd0 | |
parent | 3bd1466823062239efe65cce776aa2ffc7ac7a49 [diff] |
Combine the popoverhide/popovershow events into one beforetoggle event See [1] and [2] for context. This eliminates the "popoverhide" and "popovershow" events, and replaces them with the "beforetoggle" event, for both of these transitions. The event is a BeforeToggleEvent, which has attributes `currentState` and `newState`, both of which are either "open" or "closed" (and opposite of each other). [1] https://github.com/openui/open-ui/issues/607#issuecomment-1319114654 [2] https://github.com/whatwg/html/pull/8221#issuecomment-1335672783 Bug: 1307772 Change-Id: I404861a10579365b56e6e8eae7c29f88a5aac166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035832 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1080695}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.