Walk back overzealous banning of <random>.
We intended to ban engines and generators, but not distributions, from
<random>. I recently changed the guide and PRESUBMIT scripts to ban it
wholesale because I didn't read the email threads closely enough. Oops.
Also shortens the regex (that already existed) that was detecting
engines and generators.
Bug: none
Change-Id: Iac6b0fa136fbd980ed7a11778ef78f9496df9d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4337769
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117202}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 813efd81..fd9de82 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -800,16 +800,14 @@
),
BanRule(
(
- r'/\b(?:'
- r'std::linear_congruential_engine|std::mersenne_twister_engine|'
- r'std::subtract_with_carry_engine|std::discard_block_engine|'
- r'std::independent_bits_engine|std::shuffle_order_engine|'
- r'std::minstd_rand0|std::minstd_rand|'
- r'std::mt19937|std::mt19937_64|'
- r'std::ranlux24_base|std::ranlux48_base|std::ranlux24|std::ranlux48|'
- r'std::knuth_b|'
- r'std::default_random_engine|'
- r'std::random_device'
+ r'/\bstd::(?:'
+ r'linear_congruential_engine|mersenne_twister_engine|'
+ r'subtract_with_carry_engine|discard_block_engine|'
+ r'independent_bits_engine|shuffle_order_engine|'
+ r'minstd_rand0?|mt19937(_64)?|ranlux(24|48)(_base)?|knuth_b|'
+ r'default_random_engine|'
+ r'random_device|'
+ r'seed_seq'
r')\b'
),
(
@@ -1103,14 +1101,6 @@
],
),
BanRule(
- r'/#include <random>',
- (
- '<random> is banned. Use base::RandomBitGenerator instead.',
- ),
- True,
- [_THIRD_PARTY_EXCEPT_BLINK], # Not an error in third_party folders.
- ),
- BanRule(
r'/#include <X11/',
(
'Do not use Xlib. Use xproto (from //ui/gfx/x:xproto) instead.',
