commit | c74e0b18adf66521ab5dfa7bd724eaaa02374640 | [log] [tgz] |
---|---|---|
author | Daniel Cheng <dcheng@chromium.org> | Thu Dec 13 06:28:59 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 13 06:28:59 2018 |
tree | 00613cc0c0eff9acc9281536cd7339b6c3cac3ed | |
parent | 8d579fc15d93d5fd9677bbfda8c5144569d27240 [diff] |
Don't send FrameMsg_Delete from ~RenderFrameHostImpl Instead, actively notify the renderer when events that delete frames, to ensure the renderer-side state is in sync. The problem with deleting in the destructor is: - it can send double-deletes: safe, but somewhat wasteful - it can send deletes for frames it's not supposed to: bad, because many things randomly break if the main frame is detached before the view is shut down. Eventually, this entire logic needs to be overhauled to work at a subtree level, rather than node by node, like it does today. Bug: 838348 Change-Id: I8926a99a68aaefac598777132c40c60948c3b49c Reviewed-on: https://chromium-review.googlesource.com/c/1366020 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#616229}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .