commit c75ea66aee4318da5325c99d08d23e764185c555
author manukh <manukh@chromium.org> Thu Dec 22 19:04:58 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Dec 22 19:04:58 2022
tree 731066a9eeab10b19c58323dcd8a4fb27e6ee199
parent cebd90539533d8eed447a5d654fbfc1a71d72b15

[omnibox] Replace `#if BUILDFLAG(IS_ANDROID)` with `is_android`.

Currently, we have `#if`s sprinkled throughout autocomplete_result.cc.
Some of these guard code blocks that aren't defined on android/ios, so
they're necessary. But some of these blocks are well defined; we simply
don't want to invoke them. In these cases, it's not necessary to prune
them from the build files.

So this CL creates a bool constexprs `is_android` and `is_ios`; and uses
these bools to replace the `#if`s when the guarded code is well defined.

The motive is readability, especially in preparation for using the
grouping framework. It's
easier to read

    if (is_android && enabled_on_android ||
        is_ios && enabled_on_ios ||
        !is_android && !is_ios && enabled_on_desktop) {
      ...
    }

than to read

    #if BUILDFLAG(IS_ANDROID)
    if (enabled_on_android) {
    #elif BUILDFLAG(IS_IOS)
    if (enabled_on_ios) {
    #else
    if (enabled_on_desktop) {
      ...
    }

Did likewise for `is_ios`. Did not do iPad as that's only used once and
is done slightly differently, so it seemed like a net loss in
readability.

Only done in autocomplete_result.cc.

Bug: 1343512
Change-Id: I7f6fbb49c6d37b1995a29d948563f7c2925dde16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121695
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1086462}