Google Git
Sign in
chromium / chromium / src / c77a1a0fe12fb2d7aaf9704ab5f9b1ca9f69b69d
commitc77a1a0fe12fb2d7aaf9704ab5f9b1ca9f69b69d[log] [tgz]
authorDavid Bokan <bokan@chromium.org>Tue Jan 14 17:45:59 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 14 17:45:59 2025
treef45094f3908f7c2d3ff81acb1d215525ad18ed55
parent9835aa3bccafbd73170015001abe4f47d3a8ebeb [diff]
Handle changes to Glic enterprise policy at runtime

This CL makes Chrome respond to changes of the Glic policy at runtime,
removing or adding the tab strip button as needed. A big part of this is
clearing up (and documenting) the various notions of "Glic-enabled".

This CL makes sure Glic-related objects and widgets (tab notifier icons,
border, etc.) are created for all browser windows/profiles where Glic
could eventually be enabled; that is, those where the profile is a
regular (non-incognito, non-system, non-login, etc) user profile,
regardless of whether Glic is enabled in this profile _at this time_. We
call such profiles "eligible".

A profile is "Glic-enabled" if it is eligible and also runtime enabled
by the enterprise policy. This can change at runtime so the
GlicProfileConfiguration listens for changes in all eligible profiles
and adds/removes the tabstrip button in existing windows as needed.

Bug: 382722218
Change-Id: I5ad396086a53c84ec17a6dfb48f38acfaf3299d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165743
Reviewed-by: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1406173}
15 files changed
tree: f45094f3908f7c2d3ff81acb1d215525ad18ed55
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.