[iOS][SigninPromo] Remove impression lookup with FET
This CL removes the promo impression count lookup with the FET and
restores the previous behavior of looking up a user default that tracks
the promo impression count. There is a race condition on cold start
where we try to look up the FET event while the FET model has not been
loaded yet.
Bug: 416634744
Change-Id: Ia6fe51df2a88c1f2410a56f3366d5fa2db3aa753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6530121
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Cheick Cisse <cheickcisse@google.com>
Cr-Commit-Position: refs/heads/main@{#1458380}
diff --git a/ios/chrome/browser/authentication/ui_bundled/signin/signin_utils.mm b/ios/chrome/browser/authentication/ui_bundled/signin/signin_utils.mm
index 3c7777cf..d37a2df 100644
--- a/ios/chrome/browser/authentication/ui_bundled/signin/signin_utils.mm
+++ b/ios/chrome/browser/authentication/ui_bundled/signin/signin_utils.mm
@@ -284,33 +284,13 @@
return false;
}
- if (IsFullscreenSigninPromoManagerMigrationEnabled()) {
- feature_engagement::Tracker* tracker =
- feature_engagement::TrackerFactory::GetForProfile(profile);
- unsigned int interactions = 0;
- std::vector<std::pair<feature_engagement::EventConfig, int>> events =
- tracker->ListEvents(
- feature_engagement::kIPHiOSPromoSigninFullscreenFeature);
- for (const auto& event : events) {
- if (event.first.name ==
- feature_engagement::events::kIOSSigninFullscreenPromoTrigger) {
- interactions = event.second;
- break;
- }
- }
-
- if (interactions <= 1) {
- return true;
- }
-
- } else {
- // The sign-in promo should be shown twice, even if no account has been
- // added.
- NSInteger display_count =
- [defaults integerForKey:kSigninPromoViewDisplayCountKey];
- if (display_count <= 1) {
- return true;
- }
+ // TODO(crbug.com/416634715): Replace user defaults interaction count with FET
+ // event count. The sign-in promo should be shown twice, even if no account
+ // has been added.
+ NSInteger display_count =
+ [defaults integerForKey:kSigninPromoViewDisplayCountKey];
+ if (display_count <= 1) {
+ return true;
}
// Otherwise, it can be shown only if a new account has been added.
