| commit | c7a01cbb3764a77bdba62772cd928a3148d93c06 | [log] [tgz] |
|---|---|---|
| author | Noah Rose Ledesma <noahrose@google.com> | Wed Aug 06 19:12:14 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 06 19:12:14 2025 |
| tree | c70e19fccf67fde787f32d6a494dbbcade2ab803 | |
| parent | e80b6fb0815024e9a0ba3de6c53e6de0095fe08c [diff] |
Revert "Remove unnecessary layers for ResizeToggleMenu bubble" This reverts commit cc4ec44edaa1a1a66cc02b0aa2441202c6d21ae7. Reason for revert: Consistent ash_components_unittests failures on ChromeOS ASan LSan Tests (https://crbug.com/436709208) Bug: b:436348660 Original change's description: > Remove unnecessary layers for ResizeToggleMenu bubble > > First of all, instead of painting a transparent bubble (and use a > TEXTURE layer), use NOT_DRAWN_LAYER instead of the bubble widget. > > By correctly structuring the layers/views, we can get rid of additional > layers used on delegate view and container view. > > This CL also migrates bubble to use BubbleDialogDelegate interface > instead of BubbleDialogDelegateView. > > Bug: b:436348660 > Change-Id: I0157807098c314548b0339aebeb020055c658093 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6820120 > Reviewed-by: Elly FJ <ellyjones@chromium.org> > Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1497223} Bug: b:436348660 Change-Id: I468abf11bd68046d05f1228e3cf6dd995cdf3dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824812 Owners-Override: Noah Rose Ledesma <noahrose@google.com> Reviewed-by: Elly FJ <ellyjones@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/main@{#1497764}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.