Google GitGoogle Git
Sign in
chromium/chromium/src/c7a0905c1a1d6550ad8cbbccb79fd6c847d2bcc6
commit
c7a0905c1a1d6550ad8cbbccb79fd6c847d2bcc6
[log]
author
Chuong Ho <hdchuong@google.com>
Mon Jun 24 00:51:36 2024
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Jun 24 00:51:36 2024
tree
ba803d59346d9cce74fe574f7278b1b376dbbb57
parent
b15c15f1795ec1432418c089beecff741aed582c [diff]
editor: fix incorrect write/rewrite issue for editor triggered from picker in arc

There is an issue with picker not showing preset chips on arc when some
text is selected.

It turns out that on ARC, TextInputClient->GetTextFromRange returns
empty strings (comment https://source.chromium.org/chromium/chromium/src/+/main:ash/components/arc/ime/arc_ime_service.cc;l=497-502;drc=90cac1911508d3d682a67c97aa62483eb712f69a;bpv=1;bpt=1
indicates why it happens).

This CL changes PickerModel::GetMode to depend on
GetEditableSelectionRange which returns the correct selection range.

Bug: b:345628611
Change-Id: If79d6d49fcae12fdba654716150181e2ddef5592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647467
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chuong Ho <hdchuong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318395}
2 files changed
tree: ba803d59346d9cce74fe574f7278b1b376dbbb57
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.