commit c7d2c165957f5af4341582a648e6e14c7efee6ab
author Jihad Hanna <jihadghanna@google.com> Tue Dec 05 23:50:58 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 05 23:50:58 2023
tree ffd9a8068c44b142fdc692efdec8a762b599027a
parent 1d6699313b873dfda81a6625cedfac714584069e

Do not send FormData objects from the browser to the renderer

Undo removes fields to be sent to the renderer if it does not change
them. Another attribute of FormData is FormData::child_frames which
stores indices of fields in FormData::fields and so removing fields
from the list corrupts this particular data, resulting in mojo parsing
errors.

FormData::child_frames is only needed in
FormForest::UpdateTreeOfRendereForms which is only called in
renderer-to-browser communications.

Other filling functions could also in the future remove fields that are
not to-be filled by the renderer which could be problematic and on a
much larger scale.

This CL fixes the problem by only sending fields and the form renderer
id to the renderer instead of the whole form. This allows us to modify
FormData attributes freely in the browser.

Note that ApplyFormAction was the only mojo function sending a FormData
object from the browser to the renderer.

This CL is a no-op.

Bug: 1502814, 1441410
Change-Id: I479f953b6f5a75c5878313dfe6b3cd95a7b35f96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5033302
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Christoph Schwering <schwering@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1233646}