Google Git
Sign in
chromium / chromium / src / c7eb021ee8ef6c97ada6d34bbb90121357dc224c
commitc7eb021ee8ef6c97ada6d34bbb90121357dc224c[log] [tgz]
authorLouis Romero <lpromero@google.com>Tue Sep 12 16:12:09 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Sep 12 16:12:09 2023
treea0ab15ab7382044da63f5a53517d13aab82fed8b
parent452ad5a7e2bbd2ecd3ce2c0645e76162cdc9c9bb [diff]
Remove UIKit selection in TabGridModeSelection

When in TabGridModeSelection, we don't use the UICollectionView
selectioon/selected API. We use a custom array. This means that the
selected cell from TabGridModeNormal is still considered by UIKit as
selected when in TabGridModeSelection.
This is fine as it was ignored when displaying cells, but not when
interacting through VoiceOver, where the UIKit selection status was read
aloud before our custom selection status, leading to:
- "Selected, New Tab, Unselected".

This CL clears the UIKit selection when entering TabGridModeSelection.
The UIKit selection is reset already when leaving TabGridModeSelection.

Fixed: 1469864
Change-Id: I9306525eba5508194250cec05571702f98ecec0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859719
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Louis Romero <lpromero@google.com>
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1195433}
1 file changed
tree: a0ab15ab7382044da63f5a53517d13aab82fed8b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. weblayer/
  52. clank
  53. internal
  54. ios_internal
  55. native_client
  56. signing_keys
  57. v8
  58. .clang-format
  59. .clang-tidy
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.