| commit | c7fb12ce19fd6b51cdff1f51515e5bbae2f5d7be | [log] [tgz] |
|---|---|---|
| author | Brian Malcolm <bmalcolm@chromium.org> | Mon Apr 25 22:47:31 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 25 22:47:31 2022 |
| tree | 895b47266b48cdb854fd79d1d0f7df6f698ab897 | |
| parent | ce9c0080a4eb32241e3818a4ce461aeb4da0f607 [diff] |
Ensure no ordering dependencies in ACCH c'tor The bug here is a subtle one - the order in which members are initialized differs from compiler-to-compiler, so assuming that a unique_ptr has a value based on whether the object that takes ownership has been initialized before or after another member that depends on that pointer is fraught with peril. BUG=b:230096893 Change-Id: Icabf1abeb1034afa24ce6dfc128f2570ebd24f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606710 Reviewed-by: Benjamin Zielinski <bzielinski@google.com> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/main@{#995833}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.