commit c8054488225ac90ec17f2fe179cac36cc55db308
author Bruce Dawson <brucedawson@chromium.org> Mon Mar 28 15:33:37 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 28 15:33:37 2022
tree 8c124abb9cb029980efe6a29575985689e467eee
parent b0df1ac413ec9913be16d5aef1fc951ebcf9dac9

Fix CheckDirMetadataFormat for Windows

The CheckDirMetadataFormat presubmit on Windows should run dirmd.bat
rather than dirmd. While Windows seems to handle 'dirmd' as a valid
executable name it may be better to specify the actual file to be run,
at least for consistency with other places where we do this translation.

Bug: 1309977
Change-Id: Icac7cd10f3021aef6a47cfdafb7670ed9cfe8980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554262
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#985985}

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index ed7fc6f8..8bd4392 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -4479,8 +4479,9 @@
         input_api.RunTests(
             input_api.canned_checks.CheckVPythonSpec(input_api, output_api)))
 
+    dirmd = 'dirmd.bat' if input_api.is_windows else 'dirmd'
     dirmd_bin = input_api.os_path.join(input_api.PresubmitLocalPath(),
-                                       'third_party', 'depot_tools', 'dirmd')
+                                       'third_party', 'depot_tools', dirmd)
     results.extend(
         input_api.RunTests(
             input_api.canned_checks.CheckDirMetadataFormat(