| commit | c81a290fb3035675d0a595447ec8d9364e48ef5c | [log] [tgz] |
|---|---|---|
| author | Yunke Zhou <yunkez@google.com> | Wed Jul 28 12:12:11 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 28 12:12:11 2021 |
| tree | 99261044b6bd3f7f6e77e871fb77ba609437b1c4 | |
| parent | baec28e3a0e5dedbe61f936bd2f14fdfa321dea3 [diff] |
Oobe Assistant: fix issue with animation loading order In https://crrev.com/863296, we start loading the animation when all other data are fetched in order to prevent the animation and animation text out of sync issue (caused by animation and animation text behave differently when animation is hidden). This caused another issue where it now takes longer time to finish loading Assistant screens, and sometimes it might timeout. This CL reverts the previous CL and changes back to the previous behavior where we load the animation and fetch data together. In order to fix the text and animation out of sync issue, I added a v4 animation which only starts playing when it is focused. We call `focus()` to start playing the animation explicitly after page is loaded, to avoid out of sync issue which happens when animation playing while it is hidden. Bug: 1226535 Change-Id: I7296eb4bccadfe498d2e2d9c6f87b5373f888e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3056910 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#906151}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.