Reland "[base] Populate crash keys in TaskQueueImpl::RemoveCancelledTasks." This is a reland of commit ca96936f65fea93f992ca9b9e3242fb0198382e2 Change since initial patch: Shorter key names, to fit in the limits enforced here https://source.chromium.org/chromium/chromium/src/+/main:base/debug/crash_logging.cc;l=33-38;drc=91dee85dd1c0247c1bd3462ecd5d96fce916e28c Diff: https://chromium-review.googlesource.com/c/chromium/src/+/6479372/2..3/base/task/sequence_manager/task_queue_impl.cc Original change's description: > [base] Populate crash keys in TaskQueueImpl::RemoveCancelledTasks. > > Today, TaskQueueImpl::RemoveCancelledTasks is only called by > blink::ScriptedIdleTaskController, when it knows that there are at > least 1000 canceled tasks in the queue (in other words, it's called > infrequently). Unfortunately, a check in > blink::ScriptedIdleTaskController reveals that there are sometimes less > tasks than expected which get cleaned up. This CL adds temporary crash > keys in TaskQueueImpl::RemoveCancelledTasks to verify whether > blink::ScriptedIdleTaskController's accounting of the number of tasks > in the idle queue is accurate (depending on the answer, we'll focus > on finding issues with the accounting or finding issues in the > clean up logic). > > Bug: 394266102 > Change-Id: Ic9343887feead39b1feb839a6e6db0330024d4a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357373 > Auto-Submit: Francois Pierre Doray <fdoray@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1447129} Bug: 394266102 Change-Id: I43849ede482df93f62997ff41b47e7a0e4c0cb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6479372 Auto-Submit: Francois Pierre Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#1450498}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.