Add basic access controls to cc::PropertyTrees

This makes all member fields of PropertyTrees private, and adds basic
getter/setter methods and const correctness. The motivation for this
change is to make property trees safe for non-blocking commit, so some
of the design choices reflect that priority.

The non-const accessors from PropertyTrees to the individual trees are
given _mutable suffixes to force callers to be explicit about whether
they are modifying data, rather than relying on the compiler to pick
the const or non-const version of a method.

This also moves tree indexing out of PropertyTrees and into the
individual trees as PropertyTree<T>::element_id_to_node_index_.

The reserved node id numbers (PropertyTree<T>::kInvalidNodeId, etc.)
are moved out of PropertyTree<T> to a stand-alone non-templated enum;
the templated definitions are redundant. They are also renamed by
inserting 'Property', to avoid collision with cc::kInvalidNodeId
(defined in cc/paint/node_id.h).

Bug: chromium:1255972
Change-Id: Ifd718795a0bc26773c6d64efbed95e05197f1e31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3426308
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966064}
74 files changed
tree: 9b88aa8c420d2b91c8ec6ec17f478dd8ac4c1e54
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.