Reland "Convert std::stoi() usage to base::StringToInt() in //chrome/browser/rlz."

This is a reland of commit 365c706dd2080c556afd267904ce7b5471e8c8a1. The
original CL didn't compile, but this was not caught by the default CQ
builders (nor by a local build, which was not configured with
is_chrome_branded=true). The reland has been specifically tested by:

- verifying an is_chrome_branded=true build fails with PS1
- verifying an is_chrome_branded=true build succeeds with PS2

Original change's description:
> Convert std::stoi() usage to base::StringToInt() in //chrome/browser/rlz.
>
> This is already banned by the PRESUBMIT.py, but existing uses were not
> fixed at the time.
>
> This CL was uploaded by git cl split.
>
> R=rogerta@chromium.org
>
> Bug: 1361117
> Change-Id: I7099b9288ec956e4d8f4956d265db5c9ae4a0212
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3880967
> Commit-Queue: Roger Tawa <rogerta@chromium.org>
> Auto-Submit: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1044699}

Bug: 1361117
Change-Id: Icdffed1f0376d2e75e5378615ea9ccea126a61c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3885336
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1045286}
1 file changed
tree: d2a192873bbedb511169dceba43cdeb4658b2921
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.