commit | c861a20165a75cbb150a7aa10fe0b7dde8cbb14c | [log] [tgz] |
---|---|---|
author | Daniel Cheng <dcheng@chromium.org> | Fri Sep 09 19:34:30 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 09 19:34:30 2022 |
tree | d2a192873bbedb511169dceba43cdeb4658b2921 | |
parent | 6f9605bee3a8efd90d66c7b3fabf922c63f3b4da [diff] |
Reland "Convert std::stoi() usage to base::StringToInt() in //chrome/browser/rlz." This is a reland of commit 365c706dd2080c556afd267904ce7b5471e8c8a1. The original CL didn't compile, but this was not caught by the default CQ builders (nor by a local build, which was not configured with is_chrome_branded=true). The reland has been specifically tested by: - verifying an is_chrome_branded=true build fails with PS1 - verifying an is_chrome_branded=true build succeeds with PS2 Original change's description: > Convert std::stoi() usage to base::StringToInt() in //chrome/browser/rlz. > > This is already banned by the PRESUBMIT.py, but existing uses were not > fixed at the time. > > This CL was uploaded by git cl split. > > R=rogerta@chromium.org > > Bug: 1361117 > Change-Id: I7099b9288ec956e4d8f4956d265db5c9ae4a0212 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3880967 > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1044699} Bug: 1361117 Change-Id: Icdffed1f0376d2e75e5378615ea9ccea126a61c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3885336 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1045286}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.