Revert "Forward the return key to the omniboxKeyboardDelegate"

This reverts commit 93bb62f6533c59aad8545d2d986a3d1c65cfa0ef.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6282128460349440

Sample build with failed test: https://ci.chromium.org/b/8708486844634219489
Affected test(s):
[ninja://ios/chrome/test/earl_grey2:ios_chrome_ui_eg2tests_module/QRScannerViewControllerTestCase/testReceivingQRScannerSearchQueryResultAndEditingTheQuery](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest%2Fearl_grey2:ios_chrome_ui_eg2tests_module%2FQRScannerViewControllerTestCase%2FtestReceivingQRScannerSearchQueryResultAndEditingTheQuery?q=VHash%3Ae65a2513aae56189)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6282128460349440&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6773725&type=BUG

Original change's description:
> Forward the return key to the omniboxKeyboardDelegate
>
> This CL fixes a bug where the copied-link suggestion was not navigated
> to when hitting the return key.
> Prior to this CL, the return key was not triggering any call to
> OmniboxTextFieldIOS nor its delegate. This CL adds the same explicit
> handling as for arrow keys.
>
> Fixed: 40836724
> Change-Id: I1f444e9e7ec6c14468064102c02a9047b15f4c99
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6773725
> Reviewed-by: Christian Xu <christianxu@chromium.org>
> Auto-Submit: Louis Romero <lpromero@google.com>
> Commit-Queue: Louis Romero <lpromero@google.com>
> Cr-Commit-Position: refs/heads/main@{#1491240}
>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I04296bfe0e53a480853528b5a0aff92c8af125e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782769
Reviewed-by: Christian Xu <christianxu@chromium.org>
Reviewed-by: Filipa Senra <fsenra@google.com>
Reviewed-by: Louis Romero <lpromero@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Filipa Senra <fsenra@google.com>
Cr-Commit-Position: refs/heads/main@{#1491327}
2 files changed
tree: ad8bd2821e46087d3ea2a6324104ff93dad29ffd
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .cursorignore
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. SECURITY_OWNERS
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.