Google Git
Sign in
chromium / chromium / src / c87f5674bd862c813470fd3b1ff0668264805e0d
commitc87f5674bd862c813470fd3b1ff0668264805e0d[log] [tgz]
authorHirthanan Subenderan <hirthanan@google.com>Thu Feb 09 22:39:29 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 09 22:39:29 2023
tree619c1c517fcc3d9bf12c25fbca8edae757d4f626
parentf7c51e73680550191958c50fee10ecf54fd5621b [diff]
Safeguard for unknown channel devices that may execute device reporting

A potential reason for the high check membership QPS may be from test
images that get powerwashed with a clobber state option to avoid
preserved file preservation.
See https://crsrc.org/o/src/platform2/init/clobber_state.h;l=25-48?q=safe_wipe

Unknown channel may be due to CQ dry run for chrome/chromeOS builds
or leased DUTs. Depending on how they are built, the test images can be
branded. After doing some analysis for reported devices, I see some HWID
i.e XIVU-YAZN B3B-B4C-B3B-O7Q-A27, and TOMATO-LYVN B4B-E2F-C4C-F5O-44R
which are executing the code path but are actually testimages.

This can also explain why the UMA histogram count for check membership
requests were significantly lower than what is seen on the server side.
Testimages may not be counted by UMA.

BUG=chromium:1414462

Change-Id: Ic24fa930daf4e10490bff13ecc3a95052baaec05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4236900
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Hirthanan Subenderan <hirthanan@google.com>
Cr-Commit-Position: refs/heads/main@{#1103532}
1 file changed
tree: 619c1c517fcc3d9bf12c25fbca8edae757d4f626
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.