Google Git
Sign in
chromium / chromium / src / c94a5a48347365172a7dffa9169679e1c8f96447
commitc94a5a48347365172a7dffa9169679e1c8f96447[log] [tgz]
authorXiyuan Xia <xiyuan@google.com>Fri May 13 18:33:44 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 13 18:33:44 2022
tree6e9f8c188f99139a9e5b37a58ef4567fca81f977
parent9c202badbe1683d947d773587b3386bd754d2609 [diff]
[M102] Fix IconWithBadgeImageSource UAF after NativeTheme update

IconWithBadgeImageSource holds a reference to ui::ColorProvider and
NativeTheme::NotifyOnNativeThemeUpdated calls ColorProviderManager
to reset all ColorProvider instances. When this happens, the
ColorProvider reference in IconWithBadgeImageSource becomes stale
and would cause crash when accessed. The CL works around the problem
by replacing the ColorProvider reference with a callback to get a
reference on the fly.

(cherry picked from commit 842007542cd32a6262bac6fd67497c9a70e542e8)

Bug: 1315967
Change-Id: I5bc58cdb96815a14e78f9306ae6ea25293172a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3642858
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1002327}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646564
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/branch-heads/5005@{#742}
Cr-Branched-From: 5b4d9450fee01f821b6400e947b3839727643a71-refs/heads/main@{#992738}
4 files changed
tree: 6e9f8c188f99139a9e5b37a58ef4567fca81f977
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.