Google Git
Sign in
chromium / chromium / src / c960dc01ae62728fa4f8e614c1ca9dc71b83dec2
commitc960dc01ae62728fa4f8e614c1ca9dc71b83dec2[log] [tgz]
authorEthan Cheng <yycheng@google.com>Sat May 18 02:56:23 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat May 18 02:56:23 2024
tree94b69c7530ce5734adb8a64297c41a2b8b81f302
parent8e9d221de0d92fb03c38ee5474671522d3532786 [diff]
Revert "shimless_rma: Allow fullscreen requests"

This reverts commit 1bae1b88ab438ec81ea84050be9e8fc6fa67d9b7.

Reason for revert: b/339235051

Triage crash before relanding this CL.

Original change's description:
> shimless_rma: Allow fullscreen requests
>
> Allow requests from webpages to enter fullscreen mode.
>
> Add the related fullscreen function definitions to `WebDialogDelegate`
> and `WebDiaglogView`.
>
> BUG: b:317466280
> TEST: test on local device
> Change-Id: I06fdf6911c6c7fe5e8fba98b16c5e0dfe7fcdf37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239832
> Reviewed-by: Chung-sheng Wu <chungsheng@google.com>
> Commit-Queue: Ethan Cheng <yycheng@google.com>
> Reviewed-by: Gavin Williams <gavinwill@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1291109}

Bug: b:317466280
Change-Id: I335afa866c6080f00055b7bb684d646e0827f6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5547179
Reviewed-by: Cassy Chun-Crogan <cassycc@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Commit-Queue: Ethan Cheng <yycheng@google.com>
Reviewed-by: Chung-sheng Wu <chungsheng@google.com>
Cr-Commit-Position: refs/heads/main@{#1302968}
6 files changed
tree: 94b69c7530ce5734adb8a64297c41a2b8b81f302
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.