Google Git
Sign in
chromium / chromium / src / c97a473f9767365afaedb643bb2a95d827f52c98
commitc97a473f9767365afaedb643bb2a95d827f52c98[log] [tgz]
authorThomas Guilbert <tguilbert@chromium.org>Thu Apr 24 00:01:41 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 24 00:01:41 2025
treed8ee730d7761fc649c1564cab17f20fda831e990
parentcdd06226b2da1332167648be61f7630b4a6fc95b [diff]
Fix infinite duration regression

The M137 FFmpeg roll (commit fe18bb140331c71687631e874c9d0020557bbc60)
updated duration calculations to exclude discard padding.

New logic was added to prevent duration from being re-increased as a
file plays, and the timestamps of packets meant for discard exceed the
duration of the file.

This new logic introduced a regression, where a file with a finite
duration was being updated to have infinite duration. This disables
seeking in said files, since we use infinite duration as a special case
for unseekable live-streams.

This CL fixes the issue by ignoring packets marked for full discard when
determining the first valid timestamp (from which we calculate a running
duration).

Bug: 411037945
Change-Id: Iead67a8ded342f1baf0a5ac8cee5fb1a0fcde804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481566
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1450876}
7 files changed
tree: d8ee730d7761fc649c1564cab17f20fda831e990
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.