Google Git
Sign in
chromium / chromium / src / c989cc840db0abef578fb5f84b2c51a9d209d53b
commitc989cc840db0abef578fb5f84b2c51a9d209d53b[log] [tgz]
authorAndrew Rayskiy <greengrape@google.com>Wed Oct 16 15:40:39 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 16 15:40:39 2024
treeace1a0ecc86d7b0421094bd32dc51392157ef3c2
parent5776f830c0fbbf9f000a7cf29547c9b1eca84dba [diff]
iwa: Correctly display favicons for Isolated Web Apps

Currently the FaviconClient doesn't treat isolated-app:// URLs as
belonging to native apps and attempts to fetch favicons from the history
service (without much success). This CL attempts to bridge this gap
by marking these URLs as supported and routing them through the
WebAppIconManager.

A generic globe icon will be shown as a fallback if the icon manager is unable to return icons for any reason -- this is usually handled on the
requesting side.

Bug: 370990855
Change-Id: Ie9ae0fb6a490b0900be4f8766fed296f799d9404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5928988
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Cr-Commit-Position: refs/heads/main@{#1369423}
2 files changed
tree: ace1a0ecc86d7b0421094bd32dc51392157ef3c2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.