IDB: delete some low value tests.

These tests are very tightly coupled to implementation details specific
to LevelDB. The coverage they provide is extremely limited as they only
verify a single very specific behavior, i.e. how the system deals with
schema or data encoding versions that are less than zero, but don't
verify behavior of any other unexpected value.

Ultimately it's not even very important how IDB behaves in these
situations, in that if the production code that returns errors when
these values are under 0 were removed for some reason, the failure
modes would still be entirely reasonable:

. For very low schema versions (from before 2014), IDB will already
throw an error, so additionally verifying >= 0 doesn't catch any more
bugs.

. The only reason to track data encoding versions is to catch databases
that used encodings which are too *new*, i.e. a newer version of
Chromium created this file. Checking for values less than 0 doesn't
accomplish that. This number doesn't actually describe the encoding
scheme used for the SerializedScriptValues in the database, as those are
encoded in each serialized byte stream. Rather this number describes the
newest version of data serialization that *might* be found in the
database. If the actual serialized data is corrupted that would be
handled in due course when trying to deserialize the data.

Since the tests provide so little value, they are not ported to a SQLite
world or to unit tests, but rather deleted.

Bug: 40273263
Change-Id: I1733a92cbac1f0b024d6a945a5993c0b8fad54b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6460622
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Abhishek Shanthkumar <abhishek.shanthkumar@microsoft.com>
Commit-Queue: Evan Stade <evanstade@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1447792}
8 files changed
tree: 93d2f99f6c849fc1bb51b3a6ef29774a7fb95b49
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.