commit c990531cbbabeccf128e7b46629ab4ef60481f1d
author Piotr Kotynia <piotrkotynia@google.com> Fri Jan 10 09:04:53 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 10 09:04:53 2025
tree 403eadeb97f705c8f23d4eb2fa0b7c70ba07b3d6
parent eb2e258e5dac7f059e05f39d36d50e1d93841e15

Use autofill heuristic negative patterns for all attributes

This change introduces the
`AutofillUseNegativePatternForAllAttributes` flag, which makes
negative patterns in autofill heuristics apply to all attributes
within a field.

Previously, a negative pattern only prevented matching for the
specific attribute it was defined for. For example, if
`id_attr="nickname"` and `label_attr="name"` with
`negative_pattern="nick"`, the `label_attr` would still be parsed
with the positive pattern, potentially leading to incorrect
autofill suggestions.

This new behavior is more intuitive because it ensures consistency
in how negative patterns are applied, preventing unexpected matches
based on related attributes. This also simplifies the process of
defining heuristics by avoiding the need to repeat negative
patterns for each attribute.

This change is essential for upcoming work on implementing
last name prefixes.

Unit test added.

Bug: 386916943
Change-Id: I44c654adb59c6118f8cb83e211fc8201f75302c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158584
Commit-Queue: Piotr Kotynia <piotrkotynia@google.com>
Reviewed-by: Norge Vizcay <vizcay@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Karol Sygiet <sygiet@google.com>
Cr-Commit-Position: refs/heads/main@{#1404650}