diff --git a/DEPS b/DEPS index 816f86b..086d1cb 100644 --- a/DEPS +++ b/DEPS
@@ -105,11 +105,11 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling Skia # and whatever else without interference from each other. - 'skia_revision': '4c6514490e966198af427ec4df050470e55653a8', + 'skia_revision': '2a53275c38fbf73b4dbbe04f4289ab4f75088641', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling V8 # and whatever else without interference from each other. - 'v8_revision': 'b44922e76ed7f82598052e777de0da40bfe302b2', + 'v8_revision': '8f582e9841a9c945626029806b2ffe60b50ce9fd', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling swarming_client # and whatever else without interference from each other. @@ -117,7 +117,7 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling ANGLE # and whatever else without interference from each other. - 'angle_revision': 'c40974417610afb020c0b99a6b038f81257435cd', + 'angle_revision': 'd6781dce3d251dfdbaa8d2e3f54be2740c4202b1', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling build tools # and whatever else without interference from each other. @@ -165,7 +165,7 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling catapult # and whatever else without interference from each other. - 'catapult_revision': '7a1ed44d248aa00191dbe8682b47bb5171c73e6a', + 'catapult_revision': 'a9a4168ab6e9514493c87e3d301bfa27c60477f9', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling libFuzzer # and whatever else without interference from each other. @@ -954,7 +954,7 @@ }, 'src/third_party/perfetto': - Var('android_git') + '/platform/external/perfetto.git' + '@' + 'de2476bcaacf85f60bb6d8f13fadbe871dd1e3ce', + Var('android_git') + '/platform/external/perfetto.git' + '@' + '12949bd7d3d6f4697426cba31df1aa32ef8a1f9e', 'src/third_party/perl': { 'url': Var('chromium_git') + '/chromium/deps/perl.git' + '@' + 'ac0d98b5cee6c024b0cffeb4f8f45b6fc5ccdb78',
diff --git a/ash/BUILD.gn b/ash/BUILD.gn index 8aae70bf..88e6abc3 100644 --- a/ash/BUILD.gn +++ b/ash/BUILD.gn
@@ -156,6 +156,8 @@ "app_list/app_list_controller_impl.cc", "app_list/app_list_presenter_delegate_impl.cc", "app_list/app_list_presenter_delegate_impl.h", + "app_list/home_launcher_gesture_handler.cc", + "app_list/home_launcher_gesture_handler.h", "ash_export.h", "ash_service.cc", "assistant/assistant_cache_controller.cc", @@ -1695,6 +1697,7 @@ "accessibility/touch_exploration_manager_unittest.cc", "app_launch_unittest.cc", "app_list/app_list_presenter_delegate_unittest.cc", + "app_list/home_launcher_gesture_handler_unittest.cc", "app_list/model/app_list_item_list_unittest.cc", "app_list/model/app_list_model_unittest.cc", "app_list/presenter/app_list_presenter_impl_unittest.cc",
diff --git a/ash/app_list/app_list_controller_impl.cc b/ash/app_list/app_list_controller_impl.cc index 980f54f0..4fc3493 100644 --- a/ash/app_list/app_list_controller_impl.cc +++ b/ash/app_list/app_list_controller_impl.cc
@@ -8,6 +8,7 @@ #include <vector> #include "ash/app_list/app_list_presenter_delegate_impl.h" +#include "ash/app_list/home_launcher_gesture_handler.h" #include "ash/app_list/model/app_list_folder_item.h" #include "ash/app_list/model/app_list_item.h" #include "ash/app_list/views/app_list_main_view.h" @@ -72,6 +73,11 @@ Shell::Get()->AddShellObserver(this); keyboard::KeyboardController::Get()->AddObserver(this); + if (IsHomeLauncherEnabledInTabletMode()) { + home_launcher_gesture_handler_ = + std::make_unique<HomeLauncherGestureHandler>(); + } + mojom::VoiceInteractionObserverPtr ptr; voice_interaction_binding_.Bind(mojo::MakeRequest(&ptr)); Shell::Get()->voice_interaction_controller()->AddObserver(std::move(ptr)); @@ -517,6 +523,13 @@ } void AppListControllerImpl::OnTabletModeStarted() { + // TODO(sammiequon): Find a better way to handle events that are not in tablet + // mode than controlling the lifetime fo this object. + if (is_home_launcher_enabled_) { + home_launcher_gesture_handler_ = + std::make_unique<HomeLauncherGestureHandler>(); + } + if (presenter_.GetTargetVisibility()) { DCHECK(IsVisible()); presenter_.GetView()->OnTabletModeChanged(true); @@ -537,6 +550,8 @@ } void AppListControllerImpl::OnTabletModeEnded() { + home_launcher_gesture_handler_.reset(); + if (IsVisible()) presenter_.GetView()->OnTabletModeChanged(false);
diff --git a/ash/app_list/app_list_controller_impl.h b/ash/app_list/app_list_controller_impl.h index 6ed86d1..8a569c9b 100644 --- a/ash/app_list/app_list_controller_impl.h +++ b/ash/app_list/app_list_controller_impl.h
@@ -42,6 +42,8 @@ namespace ash { +class HomeLauncherGestureHandler; + // Ash's AppListController owns the AppListModel and implements interface // functions that allow Chrome to modify and observe the Shelf and AppListModel // state. @@ -140,6 +142,9 @@ app_list::AppListShowSource show_source, base::TimeTicks event_time_stamp); app_list::AppListViewState GetAppListViewState(); + HomeLauncherGestureHandler* home_launcher_gesture_handler() { + return home_launcher_gesture_handler_.get(); + } // app_list::AppListViewDelegate: app_list::AppListModel* GetModel() override; @@ -247,6 +252,10 @@ std::unique_ptr<app_list::AnswerCardContentsRegistry> answer_card_contents_registry_; + // Owned pointer to the object which handles gestures related to the home + // launcher. + std::unique_ptr<HomeLauncherGestureHandler> home_launcher_gesture_handler_; + // Whether the on-screen keyboard is shown. bool onscreen_keyboard_shown_ = false;
diff --git a/ash/app_list/home_launcher_gesture_handler.cc b/ash/app_list/home_launcher_gesture_handler.cc new file mode 100644 index 0000000..85a6cd64 --- /dev/null +++ b/ash/app_list/home_launcher_gesture_handler.cc
@@ -0,0 +1,197 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "ash/app_list/home_launcher_gesture_handler.h" + +#include "ash/app_list/app_list_controller_impl.h" +#include "ash/screen_util.h" +#include "ash/shell.h" +#include "ash/wm/mru_window_tracker.h" +#include "ash/wm/overview/window_selector_controller.h" +#include "ash/wm/splitview/split_view_controller.h" +#include "ash/wm/window_state.h" +#include "base/numerics/ranges.h" +#include "ui/aura/client/aura_constants.h" +#include "ui/aura/client/window_types.h" +#include "ui/gfx/animation/tween.h" +#include "ui/gfx/geometry/rect_f.h" +#include "ui/wm/core/transient_window_manager.h" + +namespace ash { + +namespace { + +constexpr float kWidthInsetRatio = 0.1f; + +// Given a |window|, find the transform which will move its bounds to a region +// offscreen to the top. Its destination width will be inset by a percentage, +// and its width-height ratio will remain the same. +gfx::Transform CalculateOffscreenTransform(aura::Window* window) { + gfx::RectF bounds = gfx::RectF(window->GetTargetBounds()); + gfx::RectF work_area = + gfx::RectF(screen_util::GetDisplayWorkAreaBoundsInParent(window)); + float inverse_aspect_ratio = work_area.height() / work_area.width(); + work_area.Inset(kWidthInsetRatio * work_area.width(), 0); + work_area.set_height(work_area.width() * inverse_aspect_ratio); + work_area.set_y(-work_area.height()); + gfx::Transform transform(work_area.width() / bounds.width(), 0, 0, + work_area.height() / bounds.height(), + work_area.x() - bounds.x(), + work_area.y() - bounds.y()); + return transform; +} + +// Given a y screen coordinate |y|, find out where it lies as a ratio in the +// work area, where the top of the work area is 0.f and the bottom is 1.f. +double GetHeightInWorkAreaAsRatio(int y, aura::Window* window) { + gfx::Rect work_area = screen_util::GetDisplayWorkAreaBoundsInParent(window); + int clamped_y = base::ClampToRange(y, work_area.y(), work_area.bottom()); + double ratio = + static_cast<double>(clamped_y) / static_cast<double>(work_area.height()); + return 1.0 - ratio; +} + +// Helper class to perform window state changes without animations. Used to hide +// and minimize windows without having their animation interfere with the ones +// this class is in charge of. +class ScopedAnimationDisabler { + public: + explicit ScopedAnimationDisabler(aura::Window* window) : window_(window) { + needs_disable_ = + !window_->GetProperty(aura::client::kAnimationsDisabledKey); + if (needs_disable_) + window_->SetProperty(aura::client::kAnimationsDisabledKey, true); + } + ~ScopedAnimationDisabler() { + if (needs_disable_) + window_->SetProperty(aura::client::kAnimationsDisabledKey, false); + } + + private: + aura::Window* window_; + bool needs_disable_ = false; + + DISALLOW_COPY_AND_ASSIGN(ScopedAnimationDisabler); +}; + +} // namespace + +HomeLauncherGestureHandler::HomeLauncherGestureHandler() = default; + +HomeLauncherGestureHandler::~HomeLauncherGestureHandler() = default; + +void HomeLauncherGestureHandler::OnPressEvent() { + // We want the first window in the mru list, if it exists and is usable. + auto windows = Shell::Get()->mru_window_tracker()->BuildMruWindowList(); + if (windows.empty() || !CanHideWindow(windows[0])) { + window_ = nullptr; + return; + } + + window_ = windows[0]; + window_->AddObserver(this); + windows.erase(windows.begin()); + // Hide all visible windows which are behind our window so that when we + // scroll, the home launcher will be visible. + hidden_windows_.clear(); + for (auto* window : windows) { + if (window->IsVisible()) { + hidden_windows_.push_back(window); + window->AddObserver(this); + ScopedAnimationDisabler disable(window); + window->Hide(); + } + } + + original_opacity_ = window_->layer()->opacity(); + original_transform_ = window_->transform(); + target_transform_ = CalculateOffscreenTransform(window_); +} + +void HomeLauncherGestureHandler::OnScrollEvent(const gfx::Point& location) { + double value = GetHeightInWorkAreaAsRatio(location.y(), window_); + float opacity = gfx::Tween::FloatValueBetween(value, original_opacity_, 0.f); + window_->layer()->SetOpacity(opacity); + gfx::Transform transform = gfx::Tween::TransformValueBetween( + value, original_transform_, target_transform_); + window_->SetTransform(transform); +} + +void HomeLauncherGestureHandler::OnReleaseEvent(const gfx::Point& location) { + // TODO(sammiequon): Animate the window to its final destination. + if (GetHeightInWorkAreaAsRatio(location.y(), window_) > 0.5) { + window_->layer()->SetOpacity(1.f); + window_->SetTransform(target_transform_); + + // Minimize |window_| without animation. Windows in |hidden_windows_| will + // rename hidden so we can see the home launcher. + // TODO(sammiequon): Investigate if we should minimize the windows in + // |hidden_windows_|. + ScopedAnimationDisabler disable(window_); + wm::GetWindowState(window_)->Minimize(); + } else { + // Reshow all windows previously hidden. + for (auto* window : hidden_windows_) { + ScopedAnimationDisabler disable(window); + window->Show(); + } + + window_->layer()->SetOpacity(original_opacity_); + window_->SetTransform(original_transform_); + } + + for (auto* window : hidden_windows_) + window->RemoveObserver(this); + hidden_windows_.clear(); + + window_->RemoveObserver(this); + window_ = nullptr; +} + +void HomeLauncherGestureHandler::OnWindowDestroying(aura::Window* window) { + window->RemoveObserver(this); + if (window == window_) { + for (auto* hidden_window : hidden_windows_) + hidden_window->Show(); + hidden_windows_.clear(); + window_ = nullptr; + return; + } + + DCHECK(base::ContainsValue(hidden_windows_, window)); + hidden_windows_.erase( + std::find(hidden_windows_.begin(), hidden_windows_.end(), window)); +} + +bool HomeLauncherGestureHandler::CanHideWindow(aura::Window* window) { + DCHECK(window); + + if (!window->IsVisible()) + return false; + + if (!Shell::Get()->app_list_controller()->IsHomeLauncherEnabledInTabletMode()) + return false; + + if (Shell::Get()->split_view_controller()->IsSplitViewModeActive()) + return false; + + if (Shell::Get()->window_selector_controller()->IsSelecting()) + return false; + + if (window->type() == aura::client::WINDOW_TYPE_POPUP) + return false; + + // TODO(sammiequon): Handle transient windows. + const ::wm::TransientWindowManager* manager = + ::wm::TransientWindowManager::GetIfExists(window); + if (manager && + (manager->transient_parent() || !manager->transient_children().empty())) { + return false; + } + + wm::WindowState* state = wm::GetWindowState(window); + return state->CanMaximize() && state->CanResize(); +} + +} // namespace ash
diff --git a/ash/app_list/home_launcher_gesture_handler.h b/ash/app_list/home_launcher_gesture_handler.h new file mode 100644 index 0000000..a4f826a4 --- /dev/null +++ b/ash/app_list/home_launcher_gesture_handler.h
@@ -0,0 +1,59 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef ASH_APP_LIST_HOME_LAUNCHER_GESTURE_HANDLER_H_ +#define ASH_APP_LIST_HOME_LAUNCHER_GESTURE_HANDLER_H_ + +#include "ash/ash_export.h" +#include "base/macros.h" +#include "ui/aura/window.h" +#include "ui/aura/window_observer.h" +#include "ui/gfx/geometry/point.h" +#include "ui/gfx/transform.h" + +namespace ash { + +// HomeLauncherGestureHandler makes modifications to a window's transform and +// opacity when gesture drag events are received and forwarded to it. +// Additionally hides windows which may block the home launcher. All +// modifications are either transitioned to their final state, or back to their +// initial state on release event. +class ASH_EXPORT HomeLauncherGestureHandler : aura::WindowObserver { + public: + HomeLauncherGestureHandler(); + ~HomeLauncherGestureHandler() override; + + // Called by owner of this object when a gesture event is received. |location| + // should be in screen coordinates. + void OnPressEvent(); + void OnScrollEvent(const gfx::Point& location); + void OnReleaseEvent(const gfx::Point& location); + + // TODO(sammiequon): Investigate if it is needed to observe potential window + // visibility changes, if they can happen. + // aura::WindowObserver: + void OnWindowDestroying(aura::Window* window) override; + + aura::Window* window() { return window_; } + + private: + // Checks if |window| can be hidden or shown with a gesture. + bool CanHideWindow(aura::Window* window); + + aura::Window* window_ = nullptr; + + float original_opacity_; + gfx::Transform original_transform_; + gfx::Transform target_transform_; + + // Stores windows which were shown behind the mru window. They need to be + // hidden so the home launcher is visible when swiping up. + std::vector<aura::Window*> hidden_windows_; + + DISALLOW_COPY_AND_ASSIGN(HomeLauncherGestureHandler); +}; + +} // namespace ash + +#endif // ASH_APP_LIST_HOME_LAUNCHER_GESTURE_HANDLER_H_
diff --git a/ash/app_list/home_launcher_gesture_handler_unittest.cc b/ash/app_list/home_launcher_gesture_handler_unittest.cc new file mode 100644 index 0000000..b858884d --- /dev/null +++ b/ash/app_list/home_launcher_gesture_handler_unittest.cc
@@ -0,0 +1,173 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "ash/app_list/home_launcher_gesture_handler.h" + +#include "ash/app_list/app_list_controller_impl.h" +#include "ash/shell.h" +#include "ash/test/ash_test_base.h" +#include "ash/wm/tablet_mode/tablet_mode_controller.h" +#include "ash/wm/window_state.h" +#include "ui/aura/window.h" +#include "ui/gfx/geometry/point.h" +#include "ui/gfx/transform.h" +#include "ui/wm/core/transient_window_manager.h" +#include "ui/wm/core/window_util.h" + +namespace ash { + +class HomeLauncherGestureHandlerTest : public AshTestBase { + public: + HomeLauncherGestureHandlerTest() = default; + ~HomeLauncherGestureHandlerTest() override = default; + + // testing::Test: + void SetUp() override { + AshTestBase::SetUp(); + + Shell::Get()->tablet_mode_controller()->EnableTabletModeWindowManager(true); + } + + // Create a test window and strip it of transient relatives since this does + // not work with transient windows yet. Set the base transform to identity and + // the base opacity to opaque for easier testing. + std::unique_ptr<aura::Window> CreateNonTransientTestWindow() { + std::unique_ptr<aura::Window> window = CreateTestWindow(); + ::wm::TransientWindowManager* manager = + ::wm::TransientWindowManager::GetOrCreate(window.get()); + if (manager->transient_parent()) { + ::wm::TransientWindowManager::GetOrCreate(manager->transient_parent()) + ->RemoveTransientChild(window.get()); + } + for (auto* window : manager->transient_children()) + manager->RemoveTransientChild(window); + + window->SetTransform(gfx::Transform()); + window->layer()->SetOpacity(1.f); + return window; + } + + HomeLauncherGestureHandler* GetGestureHandler() { + return Shell::Get()->app_list_controller()->home_launcher_gesture_handler(); + } + + private: + DISALLOW_COPY_AND_ASSIGN(HomeLauncherGestureHandlerTest); +}; + +// Tests that the gesture handler is available when in tablet mode. +TEST_F(HomeLauncherGestureHandlerTest, Setup) { + EXPECT_TRUE(GetGestureHandler()); + + Shell::Get()->tablet_mode_controller()->EnableTabletModeWindowManager(false); + EXPECT_FALSE(GetGestureHandler()); +} + +// Tests that the gesture handler will not have a window to act on if there are +// none in the mru list. +TEST_F(HomeLauncherGestureHandlerTest, NeedsOneWindow) { + GetGestureHandler()->OnPressEvent(); + EXPECT_FALSE(GetGestureHandler()->window()); + + auto window = CreateNonTransientTestWindow(); + GetGestureHandler()->OnPressEvent(); + EXPECT_TRUE(GetGestureHandler()->window()); +} + +// Tests that if there are other visible windows behind the most recent one, +// they get hidden on press event so that the home launcher is visible. +TEST_F(HomeLauncherGestureHandlerTest, ShowWindowsAreHidden) { + auto window1 = CreateNonTransientTestWindow(); + auto window2 = CreateNonTransientTestWindow(); + auto window3 = CreateNonTransientTestWindow(); + ASSERT_TRUE(window1->IsVisible()); + ASSERT_TRUE(window2->IsVisible()); + ASSERT_TRUE(window3->IsVisible()); + + // Test that the most recently activated window is visible, but the others are + // not. + ::wm::ActivateWindow(window1.get()); + GetGestureHandler()->OnPressEvent(); + EXPECT_TRUE(window1->IsVisible()); + EXPECT_FALSE(window2->IsVisible()); + EXPECT_FALSE(window3->IsVisible()); +} + +// Tests that the window transform and opacity changes as we scroll. +TEST_F(HomeLauncherGestureHandlerTest, TransformAndOpacityChangesOnScroll) { + auto window = CreateNonTransientTestWindow(); + + GetGestureHandler()->OnPressEvent(); + ASSERT_TRUE(GetGestureHandler()->window()); + + // Test that on scrolling to a point on the top half of the work area, the + // window's opacity is between 0 and 0.5 and its transform has changed. + GetGestureHandler()->OnScrollEvent(gfx::Point(0, 100)); + const gfx::Transform top_half_transform = window->transform(); + EXPECT_NE(gfx::Transform(), top_half_transform); + EXPECT_GT(window->layer()->opacity(), 0.f); + EXPECT_LT(window->layer()->opacity(), 0.5f); + + // Test that on scrolling to a point on the bottom half of the work area, the + // window's opacity is between 0.5 and 1 and its transform has changed. + GetGestureHandler()->OnScrollEvent(gfx::Point(0, 300)); + EXPECT_NE(gfx::Transform(), window->transform()); + EXPECT_NE(gfx::Transform(), top_half_transform); + EXPECT_GT(window->layer()->opacity(), 0.5f); + EXPECT_LT(window->layer()->opacity(), 1.f); +} + +// Tests that releasing a drag at the bottom of the work area will return the +// window to its original transform and opacity. +TEST_F(HomeLauncherGestureHandlerTest, BelowHalfReleaseReturnsToOriginalState) { + UpdateDisplay("400x400"); + auto window1 = CreateNonTransientTestWindow(); + auto window2 = CreateNonTransientTestWindow(); + auto window3 = CreateNonTransientTestWindow(); + + ::wm::ActivateWindow(window1.get()); + GetGestureHandler()->OnPressEvent(); + ASSERT_TRUE(GetGestureHandler()->window()); + ASSERT_FALSE(window2->IsVisible()); + ASSERT_FALSE(window3->IsVisible()); + + // After a scroll the transform and opacity are no longer the identity and 1. + GetGestureHandler()->OnScrollEvent(gfx::Point(0, 300)); + EXPECT_NE(gfx::Transform(), window1->transform()); + EXPECT_NE(1.f, window1->layer()->opacity()); + + // Tests the transform and opacity have returned to the identity and 1. + GetGestureHandler()->OnReleaseEvent(gfx::Point(0, 300)); + EXPECT_EQ(gfx::Transform(), window1->transform()); + EXPECT_EQ(1.f, window1->layer()->opacity()); + + // The other windows return to their original visibility. + EXPECT_TRUE(window2->IsVisible()); + EXPECT_TRUE(window3->IsVisible()); +} + +// Tests that a drag released at the top half of the work area will minimize the +// window under action. +TEST_F(HomeLauncherGestureHandlerTest, AboveHalfReleaseMinimizesWindow) { + UpdateDisplay("400x400"); + auto window1 = CreateNonTransientTestWindow(); + auto window2 = CreateNonTransientTestWindow(); + auto window3 = CreateNonTransientTestWindow(); + + ::wm::ActivateWindow(window1.get()); + GetGestureHandler()->OnPressEvent(); + ASSERT_TRUE(GetGestureHandler()->window()); + ASSERT_FALSE(window2->IsVisible()); + ASSERT_FALSE(window3->IsVisible()); + + // Test that |window1| is minimized on release. + GetGestureHandler()->OnReleaseEvent(gfx::Point(0, 100)); + EXPECT_TRUE(wm::GetWindowState(window1.get())->IsMinimized()); + + // The rest of the windows remain invisible, to show the home launcher. + EXPECT_FALSE(window2->IsVisible()); + EXPECT_FALSE(window3->IsVisible()); +} + +} // namespace ash
diff --git a/ash/resources/vector_icons/BUILD.gn b/ash/resources/vector_icons/BUILD.gn index 9897204..e3de383 100644 --- a/ash/resources/vector_icons/BUILD.gn +++ b/ash/resources/vector_icons/BUILD.gn
@@ -216,6 +216,9 @@ "unified_menu_volume_mute.icon", "unified_menu_vpn.icon", "unified_menu_wifi_off.icon", + "unified_network_badge_captive_portal.icon", + "unified_network_badge_secure.icon", + "unified_network_badge_vpn.icon", "wallpaper.icon", "window_control_back.icon", "window_control_dezoom.icon",
diff --git a/ash/resources/vector_icons/unified_network_badge_captive_portal.icon b/ash/resources/vector_icons/unified_network_badge_captive_portal.icon new file mode 100644 index 0000000..2a7488f9 --- /dev/null +++ b/ash/resources/vector_icons/unified_network_badge_captive_portal.icon
@@ -0,0 +1,23 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +CANVAS_DIMENSIONS, 7, +MOVE_TO, 0, 0, +R_H_LINE_TO, 7, +R_V_LINE_TO, 7, +H_LINE_TO, 0, +V_LINE_TO, 0, +CLOSE, +R_MOVE_TO, 3, 1, +R_V_LINE_TO, 3, +R_H_LINE_TO, 1, +V_LINE_TO, 1, +H_LINE_TO, 3, +CLOSE, +R_MOVE_TO, 0, 4, +R_V_LINE_TO, 1, +R_H_LINE_TO, 1, +V_LINE_TO, 5, +H_LINE_TO, 3, +CLOSE
diff --git a/ash/resources/vector_icons/unified_network_badge_secure.icon b/ash/resources/vector_icons/unified_network_badge_secure.icon new file mode 100644 index 0000000..cbcd14d --- /dev/null +++ b/ash/resources/vector_icons/unified_network_badge_secure.icon
@@ -0,0 +1,27 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +CANVAS_DIMENSIONS, 7, +MOVE_TO, 1, 2, +V_LINE_TO, 0, +R_H_LINE_TO, 4, +R_V_LINE_TO, 2, +R_H_LINE_TO, 1, +R_V_LINE_TO, 5, +H_LINE_TO, 0, +V_LINE_TO, 2, +R_H_LINE_TO, 1, +CLOSE, +R_MOVE_TO, 1, 2, +R_V_LINE_TO, 1, +R_H_LINE_TO, 2, +V_LINE_TO, 4, +H_LINE_TO, 2, +CLOSE, +R_MOVE_TO, 0, -3, +R_V_LINE_TO, 1, +R_H_LINE_TO, 2, +V_LINE_TO, 1, +H_LINE_TO, 2, +CLOSE
diff --git a/ash/resources/vector_icons/unified_network_badge_vpn.icon b/ash/resources/vector_icons/unified_network_badge_vpn.icon new file mode 100644 index 0000000..efa8cf7 --- /dev/null +++ b/ash/resources/vector_icons/unified_network_badge_vpn.icon
@@ -0,0 +1,25 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +CANVAS_DIMENSIONS, 7, +MOVE_TO, 4, 4, +H_LINE_TO, 3, +R_V_LINE_TO, 1, +H_LINE_TO, 0, +V_LINE_TO, 2, +R_H_LINE_TO, 3, +R_V_LINE_TO, 1, +R_H_LINE_TO, 3, +R_V_LINE_TO, 1, +H_LINE_TO, 5, +R_V_LINE_TO, 1, +H_LINE_TO, 4, +V_LINE_TO, 4, +CLOSE, +MOVE_TO, 2, 3, +H_LINE_TO, 1, +R_V_LINE_TO, 1, +R_H_LINE_TO, 1, +V_LINE_TO, 3, +CLOSE
diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc index acc242c..e6268b55 100644 --- a/ash/shelf/shelf_layout_manager.cc +++ b/ash/shelf/shelf_layout_manager.cc
@@ -10,6 +10,7 @@ #include "ash/animation/animation_change_type.h" #include "ash/app_list/app_list_controller_impl.h" +#include "ash/app_list/home_launcher_gesture_handler.h" #include "ash/app_list/model/app_list_view_state.h" #include "ash/app_list/views/app_list_view.h" #include "ash/public/cpp/app_list/app_list_constants.h" @@ -95,6 +96,14 @@ ->IsTabletModeWindowManagerEnabled(); } +// TODO(sammiequon): This should be the same as IsTabletModeEnabled once home +// launcher flag is removed. +bool IsHomeLauncherEnabled() { + return Shell::Get() + ->app_list_controller() + ->IsHomeLauncherEnabledInTabletMode(); +} + } // namespace // ShelfLayoutManager::UpdateShelfObserver ------------------------------------- @@ -530,11 +539,8 @@ // If the app list is active and the home launcher is not shown, hide the // shelf background to prevent overlap. - if (is_app_list_visible_ && !Shell::Get() - ->app_list_controller() - ->IsHomeLauncherEnabledInTabletMode()) { + if (is_app_list_visible_ && !IsHomeLauncherEnabled()) return SHELF_BACKGROUND_APP_LIST; - } if (state_.visibility_state != SHELF_AUTO_HIDE && state_.window_state == wm::WORKSPACE_WINDOW_STATE_MAXIMIZED) { @@ -980,12 +986,8 @@ if (visibility_state != SHELF_AUTO_HIDE) return SHELF_AUTO_HIDE_HIDDEN; - if (shelf_widget_->IsShowingAppList() && - !Shell::Get() - ->app_list_controller() - ->IsHomeLauncherEnabledInTabletMode()) { + if (shelf_widget_->IsShowingAppList() && !IsHomeLauncherEnabled()) return SHELF_AUTO_HIDE_SHOWN; - } if (shelf_widget_->status_area_widget() && shelf_widget_->status_area_widget()->ShouldShowShelf()) @@ -1172,6 +1174,16 @@ launcher_above_shelf_bottom_amount_ = shelf_bounds.bottom() - gesture_in_screen.location().y(); } else { + HomeLauncherGestureHandler* home_launcher_handler = + Shell::Get()->app_list_controller()->home_launcher_gesture_handler(); + if (home_launcher_handler) { + home_launcher_handler->OnPressEvent(); + if (home_launcher_handler->window()) { + gesture_drag_status_ = GESTURE_DRAG_APPLIST_IN_PROGRESS; + return; + } + } + // Disable the shelf dragging if the fullscreen app list is opened. if (is_app_list_visible_) { return; @@ -1187,6 +1199,17 @@ void ShelfLayoutManager::UpdateGestureDrag( const ui::GestureEvent& gesture_in_screen) { + HomeLauncherGestureHandler* home_launcher_handler = + Shell::Get()->app_list_controller()->home_launcher_gesture_handler(); + if (home_launcher_handler) { + if (home_launcher_handler->window()) { + home_launcher_handler->OnScrollEvent(gesture_in_screen.location()); + } else { + gesture_drag_status_ = GESTURE_DRAG_NONE; + } + return; + } + if (gesture_drag_status_ == GESTURE_DRAG_APPLIST_IN_PROGRESS) { // Dismiss the app list if the shelf changed to vertical alignment during // dragging. @@ -1270,6 +1293,16 @@ if (gesture_drag_status_ == GESTURE_DRAG_NONE) return; + HomeLauncherGestureHandler* home_launcher_handler = + Shell::Get()->app_list_controller()->home_launcher_gesture_handler(); + if (home_launcher_handler) { + if (home_launcher_handler->window()) { + home_launcher_handler->OnReleaseEvent(gesture_in_screen.location()); + } + gesture_drag_status_ = GESTURE_DRAG_NONE; + return; + } + using app_list::AppListViewState; AppListViewState app_list_state = AppListViewState::PEEKING; if (gesture_in_screen.type() == ui::ET_SCROLL_FLING_START && @@ -1338,11 +1371,8 @@ // In overview mode, app list for tablet mode is hidden temporarily and will // be shown automatically after overview mode ends. So prevent opening it // here. - if (Shell::Get() - ->app_list_controller() - ->IsHomeLauncherEnabledInTabletMode()) { + if (IsHomeLauncherEnabled()) return false; - } return true; }
diff --git a/ash/system/network/network_icon.cc b/ash/system/network/network_icon.cc index c688fe2..34f51b3 100644 --- a/ash/system/network/network_icon.cc +++ b/ash/system/network/network_icon.cc
@@ -304,7 +304,8 @@ } Badge ConnectingVpnBadge(double animation, IconType icon_type) { - return {&kNetworkBadgeVpnIcon, + return {features::IsSystemTrayUnifiedEnabled() ? &kUnifiedNetworkBadgeVpnIcon + : &kNetworkBadgeVpnIcon, SkColorSetA(GetDefaultColorForIconType(icon_type), 0xFF * animation)}; } @@ -499,7 +500,10 @@ NetworkTypePattern::VPN()); Badge vpn_badge = {}; if (vpn) - vpn_badge = {&kNetworkBadgeVpnIcon, GetDefaultColorForIconType(icon_type_)}; + vpn_badge = {features::IsSystemTrayUnifiedEnabled() + ? &kUnifiedNetworkBadgeVpnIcon + : &kNetworkBadgeVpnIcon, + GetDefaultColorForIconType(icon_type_)}; if (vpn_badge != vpn_badge_) { vpn_badge_ = vpn_badge; return true; @@ -515,7 +519,10 @@ if (type == shill::kTypeWifi) { if (network->security_class() != shill::kSecurityNone && !IsTrayIcon(icon_type_)) { - badges->bottom_right = {&kNetworkBadgeSecureIcon, icon_color}; + badges->bottom_right = {features::IsSystemTrayUnifiedEnabled() + ? &kUnifiedNetworkBadgeSecureIcon + : &kNetworkBadgeSecureIcon, + icon_color}; } } else if (type == shill::kTypeWimax) { technology_badge_ = {&kNetworkBadgeTechnology4gIcon, icon_color}; @@ -539,7 +546,10 @@ badges->top_left = technology_badge_; badges->bottom_left = vpn_badge_; if (behind_captive_portal_) - badges->bottom_right = {&kNetworkBadgeCaptivePortalIcon, icon_color}; + badges->bottom_right = {features::IsSystemTrayUnifiedEnabled() + ? &kUnifiedNetworkBadgeCaptivePortalIcon + : &kNetworkBadgeCaptivePortalIcon, + icon_color}; } }
diff --git a/cc/paint/oop_pixeltest.cc b/cc/paint/oop_pixeltest.cc index d0a3ee3..4bb4b049 100644 --- a/cc/paint/oop_pixeltest.cc +++ b/cc/paint/oop_pixeltest.cc
@@ -72,7 +72,8 @@ raster_context_provider_->ContextCapabilities().max_texture_size; gpu_image_cache_.reset(new GpuImageDecodeCache( gles2_context_provider_.get(), false, kRGBA_8888_SkColorType, - kWorkingSetSize, gles2_max_texture_size)); + kWorkingSetSize, gles2_max_texture_size, + PaintImage::kDefaultGeneratorClientId)); ASSERT_EQ(raster_max_texture_size, gles2_max_texture_size); } @@ -93,7 +94,8 @@ raster_context_provider_->ContextCapabilities().max_texture_size; oop_image_cache_.reset(new GpuImageDecodeCache( raster_context_provider_.get(), true, kRGBA_8888_SkColorType, - kWorkingSetSize, raster_max_texture_size)); + kWorkingSetSize, raster_max_texture_size, + PaintImage::kDefaultGeneratorClientId)); } class RasterOptions {
diff --git a/cc/paint/paint_image.cc b/cc/paint/paint_image.cc index a760ad4..66b14ec 100644 --- a/cc/paint/paint_image.cc +++ b/cc/paint/paint_image.cc
@@ -18,12 +18,14 @@ namespace { base::AtomicSequenceNumber g_next_image_id; base::AtomicSequenceNumber g_next_image_content_id; +base::AtomicSequenceNumber g_next_generator_client_id; } // namespace const PaintImage::Id PaintImage::kNonLazyStableId = -1; const size_t PaintImage::kDefaultFrameIndex = 0u; const PaintImage::Id PaintImage::kInvalidId = -2; const PaintImage::ContentId PaintImage::kInvalidContentId = -1; +const PaintImage::GeneratorClientId PaintImage::kDefaultGeneratorClientId = 0; PaintImage::PaintImage() = default; PaintImage::PaintImage(const PaintImage& other) = default; @@ -82,6 +84,12 @@ } // static +PaintImage::GeneratorClientId PaintImage::GetNextGeneratorClientId() { + // These IDs must start from 1, since 0 is the kDefaultGeneratorClientId. + return g_next_generator_client_id.GetNext() + 1; +} + +// static PaintImage PaintImage::CreateFromBitmap(SkBitmap bitmap) { if (bitmap.drawsNothing()) return PaintImage(); @@ -134,7 +142,8 @@ } else if (paint_image_generator_) { cached_sk_image_ = SkImage::MakeFromGenerator(std::make_unique<SkiaPaintImageGenerator>( - paint_image_generator_, kDefaultFrameIndex)); + paint_image_generator_, kDefaultFrameIndex, + kDefaultGeneratorClientId)); } if (!subset_rect_.IsEmpty() && cached_sk_image_) { @@ -156,7 +165,8 @@ bool PaintImage::Decode(void* memory, SkImageInfo* info, sk_sp<SkColorSpace> color_space, - size_t frame_index) const { + size_t frame_index, + GeneratorClientId client_id) const { // We only support decode to supported decode size. DCHECK(info->dimensions() == GetSupportedDecodeSize(info->dimensions())); @@ -172,14 +182,16 @@ // DecodeFromSkImage(). if (paint_image_generator_ && subset_rect_.IsEmpty()) return DecodeFromGenerator(memory, info, std::move(color_space), - frame_index); - return DecodeFromSkImage(memory, info, std::move(color_space), frame_index); + frame_index, client_id); + return DecodeFromSkImage(memory, info, std::move(color_space), frame_index, + client_id); } bool PaintImage::DecodeFromGenerator(void* memory, SkImageInfo* info, sk_sp<SkColorSpace> color_space, - size_t frame_index) const { + size_t frame_index, + GeneratorClientId client_id) const { DCHECK(subset_rect_.IsEmpty()); // First convert the info to have the requested color space, since the decoder @@ -193,9 +205,9 @@ std::unique_ptr<char[]> n32memory( new char[n32info.minRowBytes() * n32info.height()]); - bool result = paint_image_generator_->GetPixels(n32info, n32memory.get(), - n32info.minRowBytes(), - frame_index, unique_id()); + bool result = paint_image_generator_->GetPixels( + n32info, n32memory.get(), n32info.minRowBytes(), frame_index, client_id, + unique_id()); if (!result) return false; @@ -216,14 +228,15 @@ } return paint_image_generator_->GetPixels(*info, memory, info->minRowBytes(), - frame_index, unique_id()); + frame_index, client_id, unique_id()); } bool PaintImage::DecodeFromSkImage(void* memory, SkImageInfo* info, sk_sp<SkColorSpace> color_space, - size_t frame_index) const { - auto image = GetSkImageForFrame(frame_index); + size_t frame_index, + GeneratorClientId client_id) const { + auto image = GetSkImageForFrame(frame_index, client_id); DCHECK(image); if (color_space) { image = image->makeColorSpace(color_space); @@ -273,14 +286,26 @@ : 1u; } -sk_sp<SkImage> PaintImage::GetSkImageForFrame(size_t index) const { +sk_sp<SkImage> PaintImage::GetSkImageForFrame( + size_t index, + GeneratorClientId client_id) const { DCHECK_LT(index, FrameCount()); - if (index == kDefaultFrameIndex) + // |client_id| and |index| are only relevant for generator backed images which + // perform lazy decoding and can be multi-frame. + if (!paint_image_generator_) { + DCHECK_EQ(index, kDefaultFrameIndex); + return GetSkImage(); + } + + // The internally cached SkImage is constructed using the default frame index + // and GeneratorClientId. Avoid creating a new SkImage. + if (index == kDefaultFrameIndex && client_id == kDefaultGeneratorClientId) return GetSkImage(); - sk_sp<SkImage> image = SkImage::MakeFromGenerator( - std::make_unique<SkiaPaintImageGenerator>(paint_image_generator_, index)); + sk_sp<SkImage> image = + SkImage::MakeFromGenerator(std::make_unique<SkiaPaintImageGenerator>( + paint_image_generator_, index, client_id)); if (!subset_rect_.IsEmpty()) image = image->makeSubset(gfx::RectToSkIRect(subset_rect_)); return image;
diff --git a/cc/paint/paint_image.h b/cc/paint/paint_image.h index f63b6d8f..1c7fc39 100644 --- a/cc/paint/paint_image.h +++ b/cc/paint/paint_image.h
@@ -12,7 +12,6 @@ #include "cc/paint/frame_metadata.h" #include "cc/paint/image_animation_count.h" #include "cc/paint/paint_export.h" -#include "cc/paint/skia_paint_image_generator.h" #include "third_party/skia/include/core/SkImage.h" #include "ui/gfx/geometry/rect.h" @@ -37,6 +36,19 @@ // images which can be progressively updated as more encoded data is received. using ContentId = int; + // A GeneratorClientId can be used to namespace different clients that are + // using the output of a PaintImageGenerator. + // + // This is used to allow multiple compositors to simultaneously decode the + // same image. Each compositor is assigned a unique GeneratorClientId which is + // passed through to the decoder from PaintImage::Decode. Internally the + // decoder ensures that requestes from different clients are executed in + // parallel. This is particularly important for animated images, where + // compositors displaying the same image can request decodes for different + // frames from this image. + using GeneratorClientId = int; + static const GeneratorClientId kDefaultGeneratorClientId; + // The default frame index to use if no index is provided. For multi-frame // images, this would imply the first frame of the animation. static const size_t kDefaultFrameIndex; @@ -93,6 +105,7 @@ static Id GetNextId(); static ContentId GetNextContentId(); + static GeneratorClientId GetNextGeneratorClientId(); // Creates a PaintImage wrapping |bitmap|. Note that the pixels will be copied // unless the bitmap is marked immutable. @@ -128,7 +141,8 @@ bool Decode(void* memory, SkImageInfo* info, sk_sp<SkColorSpace> color_space, - size_t frame_index) const; + size_t frame_index, + GeneratorClientId client_id) const; Id stable_id() const { return id_; } const sk_sp<SkImage>& GetSkImage() const; @@ -162,7 +176,8 @@ size_t FrameCount() const; // Returns an SkImage for the frame at |index|. - sk_sp<SkImage> GetSkImageForFrame(size_t index) const; + sk_sp<SkImage> GetSkImageForFrame(size_t index, + GeneratorClientId client_id) const; std::string ToString() const; @@ -178,11 +193,13 @@ bool DecodeFromGenerator(void* memory, SkImageInfo* info, sk_sp<SkColorSpace> color_space, - size_t frame_index) const; + size_t frame_index, + GeneratorClientId client_id) const; bool DecodeFromSkImage(void* memory, SkImageInfo* info, sk_sp<SkColorSpace> color_space, - size_t frame_index) const; + size_t frame_index, + GeneratorClientId client_id) const; void CreateSkImage(); PaintImage MakeSubset(const gfx::Rect& subset) const;
diff --git a/cc/paint/paint_image_generator.h b/cc/paint/paint_image_generator.h index 88e6368a..95189c7 100644 --- a/cc/paint/paint_image_generator.h +++ b/cc/paint/paint_image_generator.h
@@ -39,6 +39,7 @@ void* pixels, size_t row_bytes, size_t frame_index, + PaintImage::GeneratorClientId client_id, uint32_t lazy_pixel_ref) = 0; // Returns true if the generator supports YUV decoding, providing the output
diff --git a/cc/paint/paint_image_unittest.cc b/cc/paint/paint_image_unittest.cc index 014b05f..b0b71c2e 100644 --- a/cc/paint/paint_image_unittest.cc +++ b/cc/paint/paint_image_unittest.cc
@@ -57,7 +57,8 @@ // The recorded index is 0u but ask for 1u frame. SkImageInfo info = SkImageInfo::MakeN32Premul(10, 10); std::vector<size_t> memory(info.computeMinByteSize()); - image.Decode(memory.data(), &info, nullptr, 1u); + image.Decode(memory.data(), &info, nullptr, 1u, + PaintImage::kDefaultGeneratorClientId); ASSERT_EQ(generator->frames_decoded().size(), 1u); EXPECT_EQ(generator->frames_decoded().count(1u), 1u); generator->reset_frames_decoded(); @@ -67,7 +68,8 @@ .make_subset(gfx::Rect(0, 0, 5, 5)) .TakePaintImage(); SkImageInfo subset_info = info.makeWH(5, 5); - subset_image.Decode(memory.data(), &subset_info, nullptr, 1u); + subset_image.Decode(memory.data(), &subset_info, nullptr, 1u, + PaintImage::kDefaultGeneratorClientId); ASSERT_EQ(generator->frames_decoded().size(), 1u); EXPECT_EQ(generator->frames_decoded().count(1u), 1u); generator->reset_frames_decoded(); @@ -75,7 +77,8 @@ // Not N32 color type. info.makeColorType(kRGB_565_SkColorType); memory = std::vector<size_t>(info.computeMinByteSize()); - image.Decode(memory.data(), &info, nullptr, 1u); + image.Decode(memory.data(), &info, nullptr, 1u, + PaintImage::kDefaultGeneratorClientId); ASSERT_EQ(generator->frames_decoded().size(), 1u); EXPECT_EQ(generator->frames_decoded().count(1u), 1u); generator->reset_frames_decoded(); @@ -103,4 +106,11 @@ SkISize::Make(8, 8)); } +TEST(PaintImageTest, GetSkImageForFrameNotGeneratorBacked) { + PaintImage image = CreateBitmapImage(gfx::Size(10, 10)); + EXPECT_EQ(image.GetSkImage(), + image.GetSkImageForFrame(PaintImage::kDefaultFrameIndex, + PaintImage::GetNextGeneratorClientId())); +} + } // namespace cc
diff --git a/cc/paint/paint_shader_unittest.cc b/cc/paint/paint_shader_unittest.cc index ac6f9e0..e097e43 100644 --- a/cc/paint/paint_shader_unittest.cc +++ b/cc/paint/paint_shader_unittest.cc
@@ -23,8 +23,13 @@ : FakePaintImageGenerator( SkImageInfo::MakeN32Premul(size.width(), size.height())) {} - MOCK_METHOD5(GetPixels, - bool(const SkImageInfo&, void*, size_t, size_t, uint32_t)); + MOCK_METHOD6(GetPixels, + bool(const SkImageInfo&, + void*, + size_t, + size_t, + PaintImage::GeneratorClientId, + uint32_t)); }; class MockImageProvider : public ImageProvider {
diff --git a/cc/paint/skia_paint_image_generator.cc b/cc/paint/skia_paint_image_generator.cc index d7b6c1a..fc42d24 100644 --- a/cc/paint/skia_paint_image_generator.cc +++ b/cc/paint/skia_paint_image_generator.cc
@@ -10,10 +10,12 @@ SkiaPaintImageGenerator::SkiaPaintImageGenerator( sk_sp<PaintImageGenerator> paint_image_generator, - size_t frame_index) + size_t frame_index, + PaintImage::GeneratorClientId client_id) : SkImageGenerator(paint_image_generator->GetSkImageInfo()), paint_image_generator_(std::move(paint_image_generator)), - frame_index_(frame_index) {} + frame_index_(frame_index), + client_id_(client_id) {} SkiaPaintImageGenerator::~SkiaPaintImageGenerator() = default; @@ -25,8 +27,8 @@ void* pixels, size_t row_bytes, const Options& options) { - return paint_image_generator_->GetPixels(info, pixels, row_bytes, - frame_index_, uniqueID()); + return paint_image_generator_->GetPixels( + info, pixels, row_bytes, frame_index_, client_id_, uniqueID()); } bool SkiaPaintImageGenerator::onQueryYUV8(SkYUVSizeInfo* size_info,
diff --git a/cc/paint/skia_paint_image_generator.h b/cc/paint/skia_paint_image_generator.h index 859faf5..c93e03b 100644 --- a/cc/paint/skia_paint_image_generator.h +++ b/cc/paint/skia_paint_image_generator.h
@@ -7,6 +7,7 @@ #include "base/macros.h" #include "cc/paint/paint_export.h" +#include "cc/paint/paint_image.h" #include "third_party/skia/include/core/SkImageGenerator.h" namespace cc { @@ -15,7 +16,8 @@ class CC_PAINT_EXPORT SkiaPaintImageGenerator final : public SkImageGenerator { public: SkiaPaintImageGenerator(sk_sp<PaintImageGenerator> paint_image_generator, - size_t frame_index); + size_t frame_index, + PaintImage::GeneratorClientId client_id); ~SkiaPaintImageGenerator() override; sk_sp<SkData> onRefEncodedData() override; @@ -31,6 +33,7 @@ private: sk_sp<PaintImageGenerator> paint_image_generator_; const size_t frame_index_; + const PaintImage::GeneratorClientId client_id_; DISALLOW_COPY_AND_ASSIGN(SkiaPaintImageGenerator); };
diff --git a/cc/test/fake_paint_image_generator.cc b/cc/test/fake_paint_image_generator.cc index 99f6319..0c03f4f 100644 --- a/cc/test/fake_paint_image_generator.cc +++ b/cc/test/fake_paint_image_generator.cc
@@ -28,6 +28,7 @@ void* pixels, size_t row_bytes, size_t frame_index, + PaintImage::GeneratorClientId client_id, uint32_t lazy_pixel_ref) { if (image_backing_memory_.empty()) return false;
diff --git a/cc/test/fake_paint_image_generator.h b/cc/test/fake_paint_image_generator.h index 923ebd01..0881fe13 100644 --- a/cc/test/fake_paint_image_generator.h +++ b/cc/test/fake_paint_image_generator.h
@@ -24,6 +24,7 @@ void* pixels, size_t row_bytes, size_t frame_index, + PaintImage::GeneratorClientId client_id, uint32_t lazy_pixel_ref) override; bool QueryYUV8(SkYUVSizeInfo* info, SkYUVColorSpace* color_space) const override;
diff --git a/cc/test/fake_tile_manager.cc b/cc/test/fake_tile_manager.cc index f5540d0c..9532c7f 100644 --- a/cc/test/fake_tile_manager.cc +++ b/cc/test/fake_tile_manager.cc
@@ -42,7 +42,8 @@ TileManagerSettings()), image_decode_cache_( kN32_SkColorType, - LayerTreeSettings().decoded_image_working_set_budget_bytes) { + LayerTreeSettings().decoded_image_working_set_budget_bytes, + PaintImage::kDefaultGeneratorClientId) { SetResources(resource_pool, &image_decode_cache_, GetGlobalTaskGraphRunner(), GetGlobalRasterBufferProvider(), false /* use_gpu_rasterization */);
diff --git a/cc/tiles/gpu_image_decode_cache.cc b/cc/tiles/gpu_image_decode_cache.cc index baca22e..3f306493 100644 --- a/cc/tiles/gpu_image_decode_cache.cc +++ b/cc/tiles/gpu_image_decode_cache.cc
@@ -164,7 +164,9 @@ // draw/scale can be done directly, calls directly into PaintImage::Decode. // if not, decodes to a compatible temporary pixmap and then converts that into // the |target_pixmap|. -bool DrawAndScaleImage(const DrawImage& draw_image, SkPixmap* target_pixmap) { +bool DrawAndScaleImage(const DrawImage& draw_image, + SkPixmap* target_pixmap, + PaintImage::GeneratorClientId client_id) { // We will pass color_space explicitly to PaintImage::Decode, so pull it out // of the pixmap and populate a stand-alone value. // note: To pull colorspace out of the pixmap, we create a new pixmap with @@ -188,7 +190,7 @@ if (supported_size == pixmap.bounds().size() && can_directly_decode) { SkImageInfo info = pixmap.info(); return paint_image.Decode(pixmap.writable_addr(), &info, color_space, - draw_image.frame_index()); + draw_image.frame_index(), client_id); } // If we can't decode/scale directly, we will handle this in up to 3 steps. @@ -206,7 +208,7 @@ SkPixmap decode_pixmap(decode_bitmap.info(), decode_bitmap.getPixels(), decode_bitmap.rowBytes()); if (!paint_image.Decode(decode_pixmap.writable_addr(), &decode_info, - color_space, draw_image.frame_index())) { + color_space, draw_image.frame_index(), client_id)) { return false; } @@ -670,15 +672,18 @@ return info.fID; } -GpuImageDecodeCache::GpuImageDecodeCache(viz::RasterContextProvider* context, - bool use_transfer_cache, - SkColorType color_type, - size_t max_working_set_bytes, - int max_texture_size) +GpuImageDecodeCache::GpuImageDecodeCache( + viz::RasterContextProvider* context, + bool use_transfer_cache, + SkColorType color_type, + size_t max_working_set_bytes, + int max_texture_size, + PaintImage::GeneratorClientId generator_client_id) : color_type_(color_type), use_transfer_cache_(use_transfer_cache), context_(context), max_texture_size_(max_texture_size), + generator_client_id_(generator_client_id), persistent_cache_(PersistentCache::NO_AUTO_EVICT), max_working_set_bytes_(max_working_set_bytes), max_working_set_items_(kMaxItemsInWorkingSet) { @@ -1480,7 +1485,7 @@ // Set |pixmap| to the desired colorspace to decode into. pixmap.setColorSpace( ColorSpaceForImageDecode(draw_image, image_data->mode)); - if (!DrawAndScaleImage(draw_image, &pixmap)) { + if (!DrawAndScaleImage(draw_image, &pixmap, generator_client_id_)) { DLOG(ERROR) << "DrawAndScaleImage failed."; backing_memory->Unlock(); backing_memory.reset();
diff --git a/cc/tiles/gpu_image_decode_cache.h b/cc/tiles/gpu_image_decode_cache.h index 138ad5ad..634f826 100644 --- a/cc/tiles/gpu_image_decode_cache.h +++ b/cc/tiles/gpu_image_decode_cache.h
@@ -107,7 +107,8 @@ bool use_transfer_cache, SkColorType color_type, size_t max_working_set_bytes, - int max_texture_size); + int max_texture_size, + PaintImage::GeneratorClientId client_id); ~GpuImageDecodeCache() override; // Returns the GL texture ID backing the given SkImage. @@ -479,6 +480,7 @@ const bool use_transfer_cache_ = false; viz::RasterContextProvider* context_; int max_texture_size_ = 0; + const PaintImage::GeneratorClientId generator_client_id_; // All members below this point must only be accessed while holding |lock_|. // The exception are const members like |normal_max_cache_bytes_| that can
diff --git a/cc/tiles/gpu_image_decode_cache_perftest.cc b/cc/tiles/gpu_image_decode_cache_perftest.cc index fc4d932..a3a9ef40 100644 --- a/cc/tiles/gpu_image_decode_cache_perftest.cc +++ b/cc/tiles/gpu_image_decode_cache_perftest.cc
@@ -52,7 +52,8 @@ UseTransferCache(), kRGBA_8888_SkColorType, kCacheSize, - MaxTextureSize()) {} + MaxTextureSize(), + PaintImage::kDefaultGeneratorClientId) {} protected: size_t MaxTextureSize() const {
diff --git a/cc/tiles/gpu_image_decode_cache_unittest.cc b/cc/tiles/gpu_image_decode_cache_unittest.cc index ba91319..1e59e96 100644 --- a/cc/tiles/gpu_image_decode_cache_unittest.cc +++ b/cc/tiles/gpu_image_decode_cache_unittest.cc
@@ -275,7 +275,8 @@ std::unique_ptr<GpuImageDecodeCache> CreateCache() { return std::make_unique<GpuImageDecodeCache>( context_provider_.get(), use_transfer_cache_, color_type_, - kGpuMemoryLimitBytes, max_texture_size_); + kGpuMemoryLimitBytes, max_texture_size_, + PaintImage::kDefaultGeneratorClientId); } GPUImageDecodeTestMockContextProvider* context_provider() {
diff --git a/cc/tiles/software_image_decode_cache.cc b/cc/tiles/software_image_decode_cache.cc index 0503874..8fbb0bae 100644 --- a/cc/tiles/software_image_decode_cache.cc +++ b/cc/tiles/software_image_decode_cache.cc
@@ -141,10 +141,12 @@ SoftwareImageDecodeCache::SoftwareImageDecodeCache( SkColorType color_type, - size_t locked_memory_limit_bytes) + size_t locked_memory_limit_bytes, + PaintImage::GeneratorClientId generator_client_id) : decoded_images_(ImageMRUCache::NO_AUTO_EVICT), locked_images_budget_(locked_memory_limit_bytes), color_type_(color_type), + generator_client_id_(generator_client_id), max_items_in_cache_(kNormalMaxItemsInCacheForSoftware) { // In certain cases, ThreadTaskRunnerHandle isn't set (Android Webview). // Don't register a dump provider in these cases. @@ -367,7 +369,8 @@ // If we can use the original decode, we'll definitely need a decode. if (key.type() == CacheKey::kOriginal) { base::AutoUnlock release(lock_); - local_cache_entry = Utils::DoDecodeImage(key, paint_image, color_type_); + local_cache_entry = Utils::DoDecodeImage(key, paint_image, color_type_, + generator_client_id_); } else { // Attempt to find a cached decode to generate a scaled/subrected decode // from. @@ -394,7 +397,8 @@ DCHECK(!should_decode_to_scale || !key.is_nearest_neighbor()); if (should_decode_to_scale) { base::AutoUnlock release(lock_); - local_cache_entry = Utils::DoDecodeImage(key, paint_image, color_type_); + local_cache_entry = Utils::DoDecodeImage(key, paint_image, color_type_, + generator_client_id_); } // Couldn't decode to scale or find a cached candidate. Create the
diff --git a/cc/tiles/software_image_decode_cache.h b/cc/tiles/software_image_decode_cache.h index e3e6b74f..84e6c69 100644 --- a/cc/tiles/software_image_decode_cache.h +++ b/cc/tiles/software_image_decode_cache.h
@@ -35,7 +35,8 @@ enum class DecodeTaskType { USE_IN_RASTER_TASKS, USE_OUT_OF_RASTER_TASKS }; SoftwareImageDecodeCache(SkColorType color_type, - size_t locked_memory_limit_bytes); + size_t locked_memory_limit_bytes, + PaintImage::GeneratorClientId generator_client_id); ~SoftwareImageDecodeCache() override; // ImageDecodeCache overrides. @@ -159,7 +160,9 @@ MemoryBudget locked_images_budget_; - SkColorType color_type_; + const SkColorType color_type_; + const PaintImage::GeneratorClientId generator_client_id_; + size_t max_items_in_cache_; // Records the maximum number of items in the cache over the lifetime of the // cache. This is updated anytime we are requested to reduce cache usage.
diff --git a/cc/tiles/software_image_decode_cache_unittest.cc b/cc/tiles/software_image_decode_cache_unittest.cc index 09dca3f..abae6c6 100644 --- a/cc/tiles/software_image_decode_cache_unittest.cc +++ b/cc/tiles/software_image_decode_cache_unittest.cc
@@ -23,7 +23,9 @@ class TestSoftwareImageDecodeCache : public SoftwareImageDecodeCache { public: TestSoftwareImageDecodeCache() - : SoftwareImageDecodeCache(kN32_SkColorType, kLockedMemoryLimitBytes) {} + : SoftwareImageDecodeCache(kN32_SkColorType, + kLockedMemoryLimitBytes, + PaintImage::kDefaultGeneratorClientId) {} }; SkMatrix CreateMatrix(const SkSize& scale, bool is_decomposable) {
diff --git a/cc/tiles/software_image_decode_cache_unittest_combinations.cc b/cc/tiles/software_image_decode_cache_unittest_combinations.cc index 29443de5..9a308bd 100644 --- a/cc/tiles/software_image_decode_cache_unittest_combinations.cc +++ b/cc/tiles/software_image_decode_cache_unittest_combinations.cc
@@ -78,16 +78,18 @@ class N32Cache : public virtual BaseTest { protected: std::unique_ptr<SoftwareImageDecodeCache> CreateCache() override { - return std::make_unique<SoftwareImageDecodeCache>(kN32_SkColorType, - kLockedMemoryLimitBytes); + return std::make_unique<SoftwareImageDecodeCache>( + kN32_SkColorType, kLockedMemoryLimitBytes, + PaintImage::kDefaultGeneratorClientId); } }; class RGBA4444Cache : public virtual BaseTest { protected: std::unique_ptr<SoftwareImageDecodeCache> CreateCache() override { - return std::make_unique<SoftwareImageDecodeCache>(kARGB_4444_SkColorType, - kLockedMemoryLimitBytes); + return std::make_unique<SoftwareImageDecodeCache>( + kARGB_4444_SkColorType, kLockedMemoryLimitBytes, + PaintImage::kDefaultGeneratorClientId); } };
diff --git a/cc/tiles/software_image_decode_cache_utils.cc b/cc/tiles/software_image_decode_cache_utils.cc index 565a0ffb..6e4c4eb2 100644 --- a/cc/tiles/software_image_decode_cache_utils.cc +++ b/cc/tiles/software_image_decode_cache_utils.cc
@@ -55,9 +55,11 @@ // static std::unique_ptr<SoftwareImageDecodeCacheUtils::CacheEntry> -SoftwareImageDecodeCacheUtils::DoDecodeImage(const CacheKey& key, - const PaintImage& paint_image, - SkColorType color_type) { +SoftwareImageDecodeCacheUtils::DoDecodeImage( + const CacheKey& key, + const PaintImage& paint_image, + SkColorType color_type, + PaintImage::GeneratorClientId client_id) { SkISize target_size = SkISize::Make(key.target_size().width(), key.target_size().height()); DCHECK(target_size == paint_image.GetSupportedDecodeSize(target_size)); @@ -73,7 +75,7 @@ "decode"); bool result = paint_image.Decode(target_pixels->data(), &target_info, key.target_color_space().ToSkColorSpace(), - key.frame_key().frame_index()); + key.frame_key().frame_index(), client_id); if (!result) { target_pixels->Unlock(); return nullptr;
diff --git a/cc/tiles/software_image_decode_cache_utils.h b/cc/tiles/software_image_decode_cache_utils.h index 7be7315..686f9ed 100644 --- a/cc/tiles/software_image_decode_cache_utils.h +++ b/cc/tiles/software_image_decode_cache_utils.h
@@ -181,9 +181,11 @@ bool cached_ = false; }; - static std::unique_ptr<CacheEntry> DoDecodeImage(const CacheKey& key, - const PaintImage& image, - SkColorType color_type); + static std::unique_ptr<CacheEntry> DoDecodeImage( + const CacheKey& key, + const PaintImage& image, + SkColorType color_type, + PaintImage::GeneratorClientId client_id); static std::unique_ptr<CacheEntry> GenerateCacheEntryFromCandidate( const CacheKey& key, const DecodedDrawImage& candidate,
diff --git a/cc/tiles/tile_manager_unittest.cc b/cc/tiles/tile_manager_unittest.cc index 3884be2..5599cc5 100644 --- a/cc/tiles/tile_manager_unittest.cc +++ b/cc/tiles/tile_manager_unittest.cc
@@ -2604,8 +2604,13 @@ : FakePaintImageGenerator( SkImageInfo::MakeN32Premul(size.width(), size.height())) {} - MOCK_METHOD5(GetPixels, - bool(const SkImageInfo&, void*, size_t, size_t, uint32_t)); + MOCK_METHOD6(GetPixels, + bool(const SkImageInfo&, + void*, + size_t, + size_t, + PaintImage::GeneratorClientId, + uint32_t)); }; void TearDown() override {
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc index 92305120..413a51b 100644 --- a/cc/trees/layer_tree_host_impl.cc +++ b/cc/trees/layer_tree_host_impl.cc
@@ -335,7 +335,8 @@ settings_.enable_image_animation_resync), frame_metrics_(LTHI_FrameMetricsSettings(settings_)), skipped_frame_tracker_(&frame_metrics_), - is_animating_for_snap_(false) { + is_animating_for_snap_(false), + paint_image_generator_client_id_(PaintImage::GetNextGeneratorClientId()) { DCHECK(mutator_host_); mutator_host_->SetMutatorHostClient(this); @@ -2996,12 +2997,14 @@ use_oop_rasterization_, viz::ResourceFormatToClosestSkColorType(/*gpu_compositing=*/true, tile_format), - settings_.decoded_image_working_set_budget_bytes, max_texture_size_); + settings_.decoded_image_working_set_budget_bytes, max_texture_size_, + paint_image_generator_client_id_); } else { bool gpu_compositing = !!layer_tree_frame_sink_->context_provider(); image_decode_cache_ = std::make_unique<SoftwareImageDecodeCache>( viz::ResourceFormatToClosestSkColorType(gpu_compositing, tile_format), - settings_.decoded_image_working_set_budget_bytes); + settings_.decoded_image_working_set_budget_bytes, + paint_image_generator_client_id_); } // Pass the single-threaded synchronous task graph runner to the worker pool
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h index 42583361..f429b9f 100644 --- a/cc/trees/layer_tree_host_impl.h +++ b/cc/trees/layer_tree_host_impl.h
@@ -1109,6 +1109,8 @@ // metrics. int scroll_events_after_reporting_ = 0; + const PaintImage::GeneratorClientId paint_image_generator_client_id_; + DISALLOW_COPY_AND_ASSIGN(LayerTreeHostImpl); };
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn index 933a8fe..4865a69fe 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn
@@ -1539,19 +1539,11 @@ if (is_chrome_branded) { sources += [ "//chrome/app/theme/$branding_path_component/win/tiles/LogoBeta.png", - "//chrome/app/theme/$branding_path_component/win/tiles/LogoBetaLight.png", "//chrome/app/theme/$branding_path_component/win/tiles/LogoCanary.png", - "//chrome/app/theme/$branding_path_component/win/tiles/LogoCanaryLight.png", "//chrome/app/theme/$branding_path_component/win/tiles/LogoDev.png", - "//chrome/app/theme/$branding_path_component/win/tiles/LogoDevLight.png", - "//chrome/app/theme/$branding_path_component/win/tiles/LogoLight.png", "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoBeta.png", - "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoBetaLight.png", "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoCanary.png", - "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoCanaryLight.png", "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoDev.png", - "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoDevLight.png", - "//chrome/app/theme/$branding_path_component/win/tiles/SmallLogoLight.png", ] }
diff --git a/chrome/android/java/res/layout/password_accessory_sheet_label.xml b/chrome/android/java/res/layout/password_accessory_sheet_label.xml index e922c3df..6fa2a924 100644 --- a/chrome/android/java/res/layout/password_accessory_sheet_label.xml +++ b/chrome/android/java/res/layout/password_accessory_sheet_label.xml
@@ -10,7 +10,8 @@ android:paddingStart="16dp" android:paddingEnd="16dp" android:fillViewport="true" - android:layout_height="48dp" android:gravity="center_vertical" android:textAppearance="@style/BlackHint1" + android:minHeight="48dp" + android:layout_height="wrap_content" android:layout_width="match_parent"/>
diff --git a/chrome/android/java/res/xml/account_management_preferences.xml b/chrome/android/java/res/xml/account_management_preferences.xml index 2f38746..72bb3cf 100644 --- a/chrome/android/java/res/xml/account_management_preferences.xml +++ b/chrome/android/java/res/xml/account_management_preferences.xml
@@ -5,8 +5,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - xmlns:app="http://schemas.android.com/apk/res-auto" - xmlns:aapt="http://schemas.android.com/aapt"> + xmlns:tools="http://schemas.android.com/tools"> <PreferenceCategory android:key="accounts_category" @@ -19,37 +18,13 @@ android:key="parental_settings" android:title="@string/account_management_parental_settings"/> - <Preference - android:key="parent_accounts"> - <aapt:attr name="android:layout"> - <LinearLayout - android:layout_width="match_parent" - android:layout_height="wrap_content" - android:paddingStart="16dp" - android:paddingEnd="16dp" - android:paddingTop="8dp" - android:paddingBottom="8dp"> - - <TextView android:id="@android:id/title" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:visibility="gone"/> - - <TextView android:id="@android:id/summary" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:textAppearance="@style/BlackBody"/> - - <LinearLayout android:id="@android:id/widget_frame" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:visibility="gone"/> - </LinearLayout> - </aapt:attr> - </Preference> + <org.chromium.chrome.browser.preferences.TextMessagePreference + android:key="parent_accounts" + tools:summary="@string/account_management_two_parent_names"/> <Preference android:key="child_content" + android:selectable="false" android:title="@string/account_management_child_content_title"/> <Preference
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java index 7261710..d26539d5 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -1438,8 +1438,9 @@ @Override public boolean onOptionsItemSelected(MenuItem item) { - if (item != null && onMenuOrKeyboardAction(item.getItemId(), true)) { - return true; + if (item != null) { + if (mManualFillingController != null) mManualFillingController.dismiss(); + if (onMenuOrKeyboardAction(item.getItemId(), true)) return true; } return super.onOptionsItemSelected(item); }
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java b/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java new file mode 100644 index 0000000..1d7721e --- /dev/null +++ b/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
@@ -0,0 +1,33 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +package org.chromium.chrome.browser.browserservices; + +import android.os.SystemClock; + +import java.util.concurrent.TimeUnit; + +/** + * Records how long Trusted Web Activities are used for. + * + * Lifecycle: There should be a 1-1 relationship between this class and + * {@link TrustedWebActivityUi} (and transitively {@link CustomTabActivity}). + * Thread safety: All methods on this class should be called on the UI thread. + */ +class TrustedWebActivityOpenTimeRecorder { + private long mOnResumeTimestampMs; + + /** Notify that the TWA has been resumed. */ + public void onResume() { + mOnResumeTimestampMs = SystemClock.elapsedRealtime(); + } + + /** Notify that the TWA has been paused. */ + public void onPause() { + assert mOnResumeTimestampMs != 0; + BrowserServicesMetrics.recordTwaOpenTime( + SystemClock.elapsedRealtime() - mOnResumeTimestampMs, TimeUnit.MILLISECONDS); + mOnResumeTimestampMs = 0; + } +}
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java b/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java index d11f0fb..cb40f2b4 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
@@ -27,6 +27,8 @@ private final TrustedWebActivityUiDelegate mDelegate; private final TrustedWebActivityDisclosure mDisclosure; + private final TrustedWebActivityOpenTimeRecorder mOpenTimeRecorder = + new TrustedWebActivityOpenTimeRecorder(); private boolean mInTrustedWebActivity = true; @@ -141,10 +143,23 @@ new OriginVerifier((packageName2, origin2, verified, online) -> { if (!origin.equals(new Origin(tab.getUrl()))) return; + BrowserServicesMetrics.recordTwaOpened(); setTrustedWebActivityMode(verified, tab); }, packageName, RELATIONSHIP).start(origin); } + /** Notify (for metrics purposes) that the TWA has been resumed. */ + public void onResume() { + // TODO(peconn): Move this over to LifecycleObserver or something similar once available. + mOpenTimeRecorder.onResume(); + } + + /** Notify (for metrics purposes) that the TWA has been paused. */ + public void onPause() { + // TODO(peconn): Move this over to LifecycleObserver or something similar once available. + mOpenTimeRecorder.onPause(); + } + /** * Updates the UI appropriately for whether or not Trusted Web Activity mode is enabled. */
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java index b37be52..2dbc6e3 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -861,6 +861,8 @@ } else if (isModuleLoading()) { mModuleOnResumePending = true; } + + if (mTrustedWebActivityUi != null) mTrustedWebActivityUi.onResume(); } @Override @@ -871,6 +873,8 @@ } if (mModuleActivityDelegate != null) mModuleActivityDelegate.onPause(); mModuleOnResumePending = false; + + if (mTrustedWebActivityUi != null) mTrustedWebActivityUi.onPause(); } @Override
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java index 589bccf..9c9027a 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
@@ -326,7 +326,6 @@ parentText = res.getString(R.string.account_management_no_parental_data); } parentAccounts.setSummary(parentText); - parentAccounts.setSelectable(false); final int childContentSummary; int defaultBehavior = prefService.getDefaultSupervisedUserFilteringBehavior(); @@ -338,7 +337,6 @@ childContentSummary = R.string.account_management_child_content_all; } childContent.setSummary(childContentSummary); - childContent.setSelectable(false); Drawable newIcon = ApiCompatibilityUtils.getDrawable( getResources(), R.drawable.ic_drive_site_white_24dp);
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java index c0e53ca..243a271 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -41,7 +41,6 @@ import org.chromium.chrome.browser.TabState; import org.chromium.chrome.browser.WarmupManager; import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate; -import org.chromium.chrome.browser.browserservices.BrowserServicesMetrics; import org.chromium.chrome.browser.browserservices.BrowserSessionContentHandler; import org.chromium.chrome.browser.browserservices.BrowserSessionContentUtils; import org.chromium.chrome.browser.browserservices.BrowserSessionDataProvider; @@ -119,7 +118,6 @@ private WebappDisclosureSnackbarController mDisclosureSnackbarController; private boolean mIsInitialized; - private long mOnResumeTimestampMs; private Integer mBrandColor; private Bitmap mLargestFavicon; @@ -494,8 +492,6 @@ updateTaskDescription(); } super.onResume(); - - mOnResumeTimestampMs = SystemClock.elapsedRealtime(); } @Override @@ -513,11 +509,6 @@ public void onPauseWithNative() { mNotificationManager.cancelNotification(); super.onPauseWithNative(); - - if (getBrowserSession() != null && !didVerificationFail()) { - BrowserServicesMetrics.recordTwaOpenTime( - SystemClock.elapsedRealtime() - mOnResumeTimestampMs, TimeUnit.MILLISECONDS); - } } @Override @@ -603,8 +594,6 @@ return; } - BrowserServicesMetrics.recordTwaOpened(); - // When verification occurs instantly (eg the result is cached) then it returns // before there is an active tab. if (areTabModelsInitialized() && getActivityTab() != null) {
diff --git a/chrome/android/java_sources.gni b/chrome/android/java_sources.gni index c515180d..fcaaf498 100644 --- a/chrome/android/java_sources.gni +++ b/chrome/android/java_sources.gni
@@ -164,6 +164,7 @@ "java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityClient.java", "java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java", "java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java", + "java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java", "java/src/org/chromium/chrome/browser/browserservices/UkmRecorder.java", "java/src/org/chromium/chrome/browser/browserservices/VerificationState.java", "java/src/org/chromium/chrome/browser/browsing_data/UrlFilters.java",
diff --git a/chrome/browser/chrome_security_exploit_browsertest.cc b/chrome/browser/chrome_security_exploit_browsertest.cc index a6440a0..93d148f 100644 --- a/chrome/browser/chrome_security_exploit_browsertest.cc +++ b/chrome/browser/chrome_security_exploit_browsertest.cc
@@ -353,9 +353,9 @@ EXPECT_TRUE(content::ExecuteScriptAndExtractString(rfh, script, &body)); EXPECT_EQ( - "\nYour file was not found\n" + "Your file was not found\n" "It may have been moved or deleted.\n" - "ERR_FILE_NOT_FOUND\n", + "ERR_FILE_NOT_FOUND", body); } @@ -473,9 +473,9 @@ EXPECT_TRUE(content::ExecuteScriptAndExtractString(rfh, script, &body)); EXPECT_EQ( - "\nYour file was not found\n" + "Your file was not found\n" "It may have been moved or deleted.\n" - "ERR_FILE_NOT_FOUND\n", + "ERR_FILE_NOT_FOUND", body); }
diff --git a/chrome/browser/chromeos/login/saml/saml_browsertest.cc b/chrome/browser/chromeos/login/saml/saml_browsertest.cc index 437cfbe..a4d08064 100644 --- a/chrome/browser/chromeos/login/saml/saml_browsertest.cc +++ b/chrome/browser/chromeos/login/saml/saml_browsertest.cc
@@ -1078,9 +1078,10 @@ // Initialize device policy. std::set<std::string> device_affiliation_ids; device_affiliation_ids.insert(kAffiliationID); - policy::affiliation_test_helper::SetDeviceAffiliationIDs( - &test_helper_, fake_session_manager_client_, - nullptr /* fake_auth_policy_client */, device_affiliation_ids); + auto affiliation_helper = policy::AffiliationTestHelper::CreateForCloud( + fake_session_manager_client_); + ASSERT_NO_FATAL_FAILURE((affiliation_helper.SetDeviceAffiliationIDs( + &test_helper_, device_affiliation_ids))); // Initialize user policy. EXPECT_CALL(provider_, IsInitializationComplete(_))
diff --git a/chrome/browser/chromeos/policy/affiliation_test_helper.cc b/chrome/browser/chromeos/policy/affiliation_test_helper.cc index ed1832ea..50fee6f 100644 --- a/chrome/browser/chromeos/policy/affiliation_test_helper.cc +++ b/chrome/browser/chromeos/policy/affiliation_test_helper.cc
@@ -44,15 +44,12 @@ namespace policy { -namespace affiliation_test_helper { +namespace { -constexpr char kFakeRefreshToken[] = "fake-refresh-token"; -constexpr char kEnterpriseUserEmail[] = "testuser@example.com"; -constexpr char kEnterpriseUserGaiaId[] = "01234567890"; - -void SetUserKeys(policy::UserPolicyBuilder* user_policy) { +// Creates policy key file for the user specified in |user_policy|. +void SetUserKeys(const policy::UserPolicyBuilder& user_policy) { const AccountId account_id = - AccountId::FromUserEmail(user_policy->policy_data().username()); + AccountId::FromUserEmail(user_policy.policy_data().username()); base::FilePath user_keys_dir; ASSERT_TRUE( base::PathService::Get(chromeos::DIR_USER_POLICY_KEYS, &user_keys_dir)); @@ -61,7 +58,7 @@ cryptohome::CreateAccountIdentifierFromAccountId(account_id)); const base::FilePath user_key_file = user_keys_dir.AppendASCII(sanitized_username).AppendASCII("policy.pub"); - std::string user_key_bits = user_policy->GetPublicSigningKeyAsString(); + std::string user_key_bits = user_policy.GetPublicSigningKeyAsString(); ASSERT_FALSE(user_key_bits.empty()); ASSERT_TRUE(base::CreateDirectory(user_key_file.DirName())); ASSERT_EQ(base::WriteFile(user_key_file, user_key_bits.data(), @@ -69,73 +66,105 @@ base::checked_cast<int>(user_key_bits.length())); } -void SetDeviceAffiliationIDs( - policy::DevicePolicyCrosTestHelper* test_helper, +} // namespace + +constexpr char AffiliationTestHelper::kFakeRefreshToken[] = + "fake-refresh-token"; +constexpr char AffiliationTestHelper::kEnterpriseUserEmail[] = + "testuser@example.com"; +constexpr char AffiliationTestHelper::kEnterpriseUserGaiaId[] = "01234567890"; + +// static +AffiliationTestHelper AffiliationTestHelper::CreateForCloud( + chromeos::FakeSessionManagerClient* fake_session_manager_client) { + return AffiliationTestHelper(ManagementType::kCloud, + fake_session_manager_client, + nullptr /* fake_auth_policy_client */); +} + +// static +AffiliationTestHelper AffiliationTestHelper::CreateForActiveDirectory( chromeos::FakeSessionManagerClient* fake_session_manager_client, - chromeos::FakeAuthPolicyClient* fake_auth_policy_client, + chromeos::FakeAuthPolicyClient* fake_auth_policy_client) { + return AffiliationTestHelper(ManagementType::kActiveDirectory, + fake_session_manager_client, + fake_auth_policy_client); +} + +AffiliationTestHelper::AffiliationTestHelper(AffiliationTestHelper&& other) = + default; + +AffiliationTestHelper::AffiliationTestHelper( + ManagementType management_type, + chromeos::FakeSessionManagerClient* fake_session_manager_client, + chromeos::FakeAuthPolicyClient* fake_auth_policy_client) + : management_type_(management_type), + fake_session_manager_client_(fake_session_manager_client), + fake_auth_policy_client_(fake_auth_policy_client) {} + +void AffiliationTestHelper::CheckPreconditions() { + ASSERT_TRUE(fake_session_manager_client_); + ASSERT_TRUE(management_type_ != ManagementType::kActiveDirectory || + fake_auth_policy_client_); +} + +void AffiliationTestHelper::SetDeviceAffiliationIDs( + policy::DevicePolicyCrosTestHelper* test_helper, const std::set<std::string>& device_affiliation_ids) { - // Assume it's Active Directory when the AuthPolicyClient is started. - // Make sure we don't overwrite the install attributes in that case. - const bool is_active_directory = - fake_auth_policy_client && fake_auth_policy_client->started(); - if (!is_active_directory) { - test_helper->InstallOwnerKey(); - test_helper->MarkAsEnterpriseOwned(); - } + ASSERT_NO_FATAL_FAILURE(CheckPreconditions()); + policy::DevicePolicyBuilder* device_policy = test_helper->device_policy(); for (const auto& device_affiliation_id : device_affiliation_ids) { device_policy->policy_data().add_device_affiliation_ids( device_affiliation_id); } - if (!is_active_directory) + if (management_type_ != ManagementType::kActiveDirectory) { + // Create keys and sign policy. Note that Active Directory policy is + // unsigned. + test_helper->InstallOwnerKey(); + test_helper->MarkAsEnterpriseOwned(); device_policy->SetDefaultSigningKey(); + } device_policy->Build(); - fake_session_manager_client->set_device_policy(device_policy->GetBlob()); - fake_session_manager_client->OnPropertyChangeComplete(true); + fake_session_manager_client_->set_device_policy(device_policy->GetBlob()); + fake_session_manager_client_->OnPropertyChangeComplete(true); - // Need fake_auth_policy_client for Active Directory accounts. - if (fake_auth_policy_client) - fake_auth_policy_client->set_device_affiliation_ids(device_affiliation_ids); + if (management_type_ == ManagementType::kActiveDirectory) { + fake_auth_policy_client_->set_device_affiliation_ids( + device_affiliation_ids); + } } -void SetUserAffiliationIDs( +void AffiliationTestHelper::SetUserAffiliationIDs( policy::UserPolicyBuilder* user_policy, - chromeos::FakeSessionManagerClient* fake_session_manager_client, - chromeos::FakeAuthPolicyClient* fake_auth_policy_client, const AccountId& user_account_id, const std::set<std::string>& user_affiliation_ids) { - const bool is_active_directory = - user_account_id.GetAccountType() == AccountType::ACTIVE_DIRECTORY; + ASSERT_NO_FATAL_FAILURE(CheckPreconditions()); + ASSERT_TRUE(management_type_ != ManagementType::kActiveDirectory || + user_account_id.GetAccountType() == + AccountType::ACTIVE_DIRECTORY); + user_policy->policy_data().set_username(user_account_id.GetUserEmail()); - if (!is_active_directory) { + if (management_type_ != ManagementType::kActiveDirectory) { user_policy->policy_data().set_gaia_id(user_account_id.GetGaiaId()); - SetUserKeys(user_policy); + ASSERT_NO_FATAL_FAILURE(SetUserKeys(*user_policy)); } for (const auto& user_affiliation_id : user_affiliation_ids) { user_policy->policy_data().add_user_affiliation_ids(user_affiliation_id); } user_policy->Build(); - // Make sure AD policy is stored using the proper cryptohome key. This code - // runs before the AD account is migrated, so it would use the email address. - // TODO(ljusten): Clean this up as soon as CL:1055509 lands. - cryptohome::Identification cryptohome_id = - is_active_directory ? cryptohome::Identification::FromString( - user_account_id.GetAccountIdKey()) - : cryptohome::Identification(user_account_id); - - fake_session_manager_client->set_user_policy( - cryptohome::CreateAccountIdentifierFromIdentification(cryptohome_id), + fake_session_manager_client_->set_user_policy( + cryptohome::CreateAccountIdentifierFromAccountId(user_account_id), user_policy->GetBlob()); - // Need fake_auth_policy_client for Active Directory accounts. - DCHECK(!is_active_directory || fake_auth_policy_client); - if (fake_auth_policy_client) - fake_auth_policy_client->set_user_affiliation_ids(user_affiliation_ids); + if (management_type_ == ManagementType::kActiveDirectory) + fake_auth_policy_client_->set_user_affiliation_ids(user_affiliation_ids); } -void PreLoginUser(const AccountId& account_id) { +// static +void AffiliationTestHelper::PreLoginUser(const AccountId& account_id) { ListPrefUpdate users_pref(g_browser_process->local_state(), "LoggedInUsers"); users_pref->AppendIfNotPresent( std::make_unique<base::Value>(account_id.GetUserEmail())); @@ -145,7 +174,8 @@ chromeos::StartupUtils::MarkOobeCompleted(); } -void LoginUser(const AccountId& account_id) { +// static +void AffiliationTestHelper::LoginUser(const AccountId& account_id) { chromeos::test::UserSessionManagerTestApi session_manager_test_api( chromeos::UserSessionManager::GetInstance()); session_manager_test_api.SetShouldObtainTokenHandleInTests(false); @@ -180,7 +210,9 @@ << " was not added via PreLoginUser()"; } -void AppendCommandLineSwitchesForLoginManager(base::CommandLine* command_line) { +// static +void AffiliationTestHelper::AppendCommandLineSwitchesForLoginManager( + base::CommandLine* command_line) { command_line->AppendSwitch(chromeos::switches::kLoginManager); command_line->AppendSwitch(chromeos::switches::kForceLoginManagerInTests); // LoginManager tests typically don't stand up a policy test server but @@ -190,6 +222,4 @@ chromeos::switches::kAllowFailedPolicyFetchForTest); } -} // namespace affiliation_test_helper - } // namespace policy
diff --git a/chrome/browser/chromeos/policy/affiliation_test_helper.h b/chrome/browser/chromeos/policy/affiliation_test_helper.h index 1a957c15..270bdc2 100644 --- a/chrome/browser/chromeos/policy/affiliation_test_helper.h +++ b/chrome/browser/chromeos/policy/affiliation_test_helper.h
@@ -7,6 +7,8 @@ #include <set> #include <string> + +#include "base/macros.h" #include "components/policy/core/common/cloud/policy_builder.h" class AccountId; @@ -24,102 +26,77 @@ class DevicePolicyCrosTestHelper; -namespace affiliation_test_helper { +class AffiliationTestHelper { + public: + // Creates an |AffiliationTestHelper| for Cloud management (regular Google + // accounts). The |fake_session_manager_client| pointer must outlive this + // object. + static AffiliationTestHelper CreateForCloud( + chromeos::FakeSessionManagerClient* fake_session_manager_client); -// Creates policy key file for the user specified in |user_policy|. -// TODO(peletskyi): Replace pointer with const reference and replace this -// boilerplate in other places (http://crbug.com/549111). -void SetUserKeys(policy::UserPolicyBuilder* user_policy); + // Creates an |AffiliationTestHelper| for Active Directory management (Active + // Directory accounts). The pointers must outlive this object. + static AffiliationTestHelper CreateForActiveDirectory( + chromeos::FakeSessionManagerClient* fake_session_manager_client, + chromeos::FakeAuthPolicyClient* fake_auth_policy_client); -// Sets device affiliation ID to |fake_session_manager_client| from -// |device_affiliation_ids| and modifies |test_helper| so that it contains -// correct values of device affiliation IDs for future use. To add some device -// policies and have device affiliation ID valid please use |test_helper| -// modified by this function. Example: -// -// FakeSessionManagerClient* fake_session_manager_client = -// new chromeos::FakeSessionManagerClient; -// DBusThreadManager::GetSetterForTesting()->SetSessionManagerClient( -// std::unique_ptr<SessionManagerClient>(fake_session_manager_client)); -// -// policy::DevicePolicyCrosTestHelper test_helper; -// std::set<std::string> device_affiliation_ids; -// device_affiliation_ids.insert(some-affiliation-id); -// -// affiliation_test_helper::SetDeviceAffiliationIDs( -// &test_helper, -// fake_session_manager_client, -// nullptr /* fake_auth_policy_client */ -// device_affiliation_ids); -// -// If it is used together with SetUserAffiliationIDs() (which is the most common -// case) |fake_session_manager_client| must point to the same object as in -// SetUserAffiliationIDs() call. -// In browser tests one can call this function from -// SetUpInProcessBrowserTestFixture(). -// -// |fake_auth_policy_client| is only needed if the test supports Active -// Directory user accounts. If not, it may be nullptr. -void SetDeviceAffiliationIDs( - policy::DevicePolicyCrosTestHelper* test_helper, - chromeos::FakeSessionManagerClient* fake_session_manager_client, - chromeos::FakeAuthPolicyClient* fake_auth_policy_client, - const std::set<std::string>& device_affiliation_ids); + // Allow move construction, so the static constructors can be used despite + // DISALLOW_COPY_AND_ASSIGN. + AffiliationTestHelper(AffiliationTestHelper&& other); -// Sets user affiliation ID for |user_account_id| to -// |fake_session_manager_client| from |user_affiliation_ids| and modifies -// |user_policy| so that it contains correct values of user affiliation IDs for -// future use. To add user policies and have user affiliation IDs valid please -// use |user_policy| modified by this function. Example: -// -// FakeSessionManagerClient* fake_session_manager_client = -// new chromeos::FakeSessionManagerClient; -// DBusThreadManager::GetSetterForTesting()->SetSessionManagerClient( -// std::unique_ptr<SessionManagerClient>(fake_session_manager_client)); -// -// policy::UserPolicyBuilder user_policy; -// std::set<std::string> user_affiliation_ids; -// user_affiliation_ids.insert("some-affiliation-id"); -// -// affiliation_test_helper::SetUserAffiliationIDs( -// &user_policy, -// fake_session_manager_client, -// nullptr /* fake_auth_policy_client */, -// account_id, -// user_affiliation_ids); -// -// If it is used together SetDeviceAffiliationIDs() (which is the most common -// case) |fake_session_manager_client| must point to the same object as in -// SetDeviceAffiliationIDs() call. -// In browser tests one can call this function from -// SetUpInProcessBrowserTestFixture(). -// -// |fake_auth_policy_client| is only needed if the test supports Active -// Directory user accounts. If not, it may be nullptr. -void SetUserAffiliationIDs( - policy::UserPolicyBuilder* user_policy, - chromeos::FakeSessionManagerClient* fake_session_manager_client, - chromeos::FakeAuthPolicyClient* fake_auth_policy_client, - const AccountId& user_account_id, - const std::set<std::string>& user_affiliation_ids); + // Sets device affiliation IDs to |device_affiliation_ids| in + // |fake_session_manager_client_| and modifies |test_helper| so that it + // contains correct values of device affiliation IDs for future use. To add + // some device policies and have device affiliation ID valid use |test_helper| + // modified by this function. + void SetDeviceAffiliationIDs( + policy::DevicePolicyCrosTestHelper* test_helper, + const std::set<std::string>& device_affiliation_ids); -// Registers the user with the given |account_id| on the device and marks OOBE -// as completed. This method should be called in PRE_* test. -void PreLoginUser(const AccountId& account_id); + // Sets user affiliation IDs to |user_affiliation_ids| in + // |fake_session_manager_client| and modifies |user_policy| so that it + // contains correct values of user affiliation IDs for future use. To add user + // policies and have user affiliation IDs valid please use |user_policy| + // modified by this function. + void SetUserAffiliationIDs(policy::UserPolicyBuilder* user_policy, + const AccountId& user_account_id, + const std::set<std::string>& user_affiliation_ids); -// Log in user with |account_id|. User should be registered using -// PreLoginUser(). -void LoginUser(const AccountId& user_id); + // Registers the user with the given |account_id| on the device and marks OOBE + // as completed. This method should be called in PRE_* test. + static void PreLoginUser(const AccountId& account_id); -// Set necessary for login command line switches. Execute it in -// SetUpCommandLine(). -void AppendCommandLineSwitchesForLoginManager(base::CommandLine* command_line); + // Log in user with |account_id|. User should be registered using + // PreLoginUser(). + static void LoginUser(const AccountId& user_id); -extern const char kFakeRefreshToken[]; -extern const char kEnterpriseUserEmail[]; -extern const char kEnterpriseUserGaiaId[]; + // Set necessary for login command line switches. Execute it in + // SetUpCommandLine(). + static void AppendCommandLineSwitchesForLoginManager( + base::CommandLine* command_line); -} // namespace affiliation_test_helper + static const char kFakeRefreshToken[]; + static const char kEnterpriseUserEmail[]; + static const char kEnterpriseUserGaiaId[]; + + private: + enum class ManagementType { kCloud, kActiveDirectory }; + + AffiliationTestHelper( + ManagementType management_type, + chromeos::FakeSessionManagerClient* fake_session_manager_client, + chromeos::FakeAuthPolicyClient* fake_auth_policy_client); + + // ASSERTs on pointer validity. + void CheckPreconditions(); + + ManagementType management_type_; + chromeos::FakeSessionManagerClient* + fake_session_manager_client_; // Not owned. + chromeos::FakeAuthPolicyClient* fake_auth_policy_client_; // Not owned. + + DISALLOW_COPY_AND_ASSIGN(AffiliationTestHelper); +}; } // namespace policy
diff --git a/chrome/browser/chromeos/policy/unaffiliated_arc_allowed_browsertest.cc b/chrome/browser/chromeos/policy/unaffiliated_arc_allowed_browsertest.cc index 0584f3a9..ef19f8e 100644 --- a/chrome/browser/chromeos/policy/unaffiliated_arc_allowed_browsertest.cc +++ b/chrome/browser/chromeos/policy/unaffiliated_arc_allowed_browsertest.cc
@@ -56,7 +56,7 @@ void SetUpCommandLine(base::CommandLine* command_line) override { DevicePolicyCrosBrowserTest::SetUpCommandLine(command_line); arc::SetArcAvailableCommandLineForTesting(command_line); - affiliation_test_helper::AppendCommandLineSwitchesForLoginManager( + AffiliationTestHelper::AppendCommandLineSwitchesForLoginManager( command_line); } @@ -70,14 +70,12 @@ const std::set<std::string> user_affiliation_ids = { GetParam().affiliated ? kAffiliationID : kAnotherAffiliationID}; - affiliation_test_helper::SetDeviceAffiliationIDs( - &test_helper, session_manager_client(), - nullptr /* fake_auth_policy_client */, device_affiliation_ids); - - affiliation_test_helper::SetUserAffiliationIDs( - &user_policy, session_manager_client(), - nullptr /* fake_auth_policy_client */, affiliated_account_id_, - user_affiliation_ids); + AffiliationTestHelper affiliation_helper = + AffiliationTestHelper::CreateForCloud(session_manager_client()); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetDeviceAffiliationIDs( + &test_helper, device_affiliation_ids)); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetUserAffiliationIDs( + &user_policy, affiliated_account_id_, user_affiliation_ids)); } void TearDownOnMainThread() override { @@ -115,11 +113,11 @@ }; IN_PROC_BROWSER_TEST_P(UnaffiliatedArcAllowedTest, PRE_ProfileTest) { - affiliation_test_helper::PreLoginUser(affiliated_account_id_); + AffiliationTestHelper::PreLoginUser(affiliated_account_id_); } IN_PROC_BROWSER_TEST_P(UnaffiliatedArcAllowedTest, ProfileTest) { - affiliation_test_helper::LoginUser(affiliated_account_id_); + AffiliationTestHelper::LoginUser(affiliated_account_id_); const user_manager::User* user = user_manager::UserManager::Get()->FindUser(affiliated_account_id_); const Profile* profile =
diff --git a/chrome/browser/chromeos/policy/user_affiliation_browsertest.cc b/chrome/browser/chromeos/policy/user_affiliation_browsertest.cc index a153550..c9b6ae4 100644 --- a/chrome/browser/chromeos/policy/user_affiliation_browsertest.cc +++ b/chrome/browser/chromeos/policy/user_affiliation_browsertest.cc
@@ -136,7 +136,7 @@ void SetUpCommandLine(base::CommandLine* command_line) override { InProcessBrowserTest::SetUpCommandLine(command_line); if (content::IsPreTest()) { - affiliation_test_helper::AppendCommandLineSwitchesForLoginManager( + AffiliationTestHelper::AppendCommandLineSwitchesForLoginManager( command_line); } else { const cryptohome::AccountIdentifier cryptohome_id = @@ -182,13 +182,18 @@ const std::set<std::string> user_affiliation_ids = { GetParam().affiliated ? kAffiliationID : kAnotherAffiliationID}; - affiliation_test_helper::SetDeviceAffiliationIDs( - &test_helper, fake_session_manager_client, fake_auth_policy_client, - device_affiliation_ids); + AffiliationTestHelper affiliation_helper = + GetParam().active_directory + ? AffiliationTestHelper::CreateForActiveDirectory( + fake_session_manager_client, fake_auth_policy_client) + : AffiliationTestHelper::CreateForCloud( + fake_session_manager_client); - affiliation_test_helper::SetUserAffiliationIDs( - &user_policy, fake_session_manager_client, fake_auth_policy_client, - account_id_, user_affiliation_ids); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetDeviceAffiliationIDs( + &test_helper, device_affiliation_ids)); + + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetUserAffiliationIDs( + &user_policy, account_id_, user_affiliation_ids)); // Set retry delay to prevent timeouts. policy::DeviceManagementService::SetRetryDelayForTesting(0); @@ -274,12 +279,12 @@ }; IN_PROC_BROWSER_TEST_P(UserAffiliationBrowserTest, PRE_PRE_TestAffiliation) { - affiliation_test_helper::PreLoginUser(account_id_); + AffiliationTestHelper::PreLoginUser(account_id_); } // This part of the test performs a regular sign-in through the login manager. IN_PROC_BROWSER_TEST_P(UserAffiliationBrowserTest, PRE_TestAffiliation) { - affiliation_test_helper::LoginUser(account_id_); + AffiliationTestHelper::LoginUser(account_id_); ASSERT_NO_FATAL_FAILURE(VerifyAffiliationExpectations()); }
diff --git a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc index 20b08efdfd..07767f0 100644 --- a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc +++ b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
@@ -100,7 +100,7 @@ // ExtensionApiTest void SetUpCommandLine(base::CommandLine* command_line) override { ExtensionApiTest::SetUpCommandLine(command_line); - policy::affiliation_test_helper::AppendCommandLineSwitchesForLoginManager( + policy::AffiliationTestHelper::AppendCommandLineSwitchesForLoginManager( command_line); } @@ -113,11 +113,14 @@ std::unique_ptr<chromeos::SessionManagerClient>( fake_session_manager_client)); + policy::AffiliationTestHelper affiliation_helper = + policy::AffiliationTestHelper::CreateForCloud( + fake_session_manager_client); + std::set<std::string> device_affiliation_ids; device_affiliation_ids.insert(kAffiliationID); - policy::affiliation_test_helper::SetDeviceAffiliationIDs( - &test_helper_, fake_session_manager_client, - nullptr /* fake_auth_policy_client */, device_affiliation_ids); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetDeviceAffiliationIDs( + &test_helper_, device_affiliation_ids)); std::set<std::string> user_affiliation_ids; if (GetParam().affiliated) { @@ -126,10 +129,8 @@ user_affiliation_ids.insert(kAnotherAffiliationID); } policy::UserPolicyBuilder user_policy; - policy::affiliation_test_helper::SetUserAffiliationIDs( - &user_policy, fake_session_manager_client, - nullptr /* fake_auth_policy_client */, affiliated_account_id_, - user_affiliation_ids); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetUserAffiliationIDs( + &user_policy, affiliated_account_id_, user_affiliation_ids)); test_helper_.InstallOwnerKey(); // Init the device policy. @@ -158,7 +159,7 @@ const base::ListValue* users = g_browser_process->local_state()->GetList("LoggedInUsers"); if (!users->empty()) - policy::affiliation_test_helper::LoginUser(affiliated_account_id_); + policy::AffiliationTestHelper::LoginUser(affiliated_account_id_); ExtensionApiTest::SetUpOnMainThread(); } @@ -231,7 +232,7 @@ }; IN_PROC_BROWSER_TEST_P(EnterpriseDeviceAttributesTest, PRE_Success) { - policy::affiliation_test_helper::PreLoginUser(affiliated_account_id_); + policy::AffiliationTestHelper::PreLoginUser(affiliated_account_id_); } IN_PROC_BROWSER_TEST_P(EnterpriseDeviceAttributesTest, Success) {
diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_test_base.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_test_base.cc index 8ba53b9..c64afa47 100644 --- a/chrome/browser/extensions/api/platform_keys/platform_keys_test_base.cc +++ b/chrome/browser/extensions/api/platform_keys/platform_keys_test_base.cc
@@ -34,9 +34,6 @@ const char kAffiliationID[] = "some-affiliation-id"; const char kTestUserinfoToken[] = "fake-userinfo-token"; -using policy::affiliation_test_helper::kEnterpriseUserEmail; -using policy::affiliation_test_helper::kEnterpriseUserGaiaId; - PlatformKeysTestBase::PlatformKeysTestBase( SystemTokenStatus system_token_status, EnrollmentStatus enrollment_status, @@ -44,8 +41,9 @@ : system_token_status_(system_token_status), enrollment_status_(enrollment_status), user_status_(user_status), - account_id_(AccountId::FromUserEmailGaiaId(kEnterpriseUserEmail, - kEnterpriseUserGaiaId)) { + account_id_(AccountId::FromUserEmailGaiaId( + policy::AffiliationTestHelper::kEnterpriseUserEmail, + policy::AffiliationTestHelper::kEnterpriseUserGaiaId)) { // Command line should not be tweaked as if user is already logged in. set_chromeos_user_ = false; // We log in without running browser. @@ -78,7 +76,7 @@ void PlatformKeysTestBase::SetUpCommandLine(base::CommandLine* command_line) { extensions::ExtensionApiTest::SetUpCommandLine(command_line); - policy::affiliation_test_helper::AppendCommandLineSwitchesForLoginManager( + policy::AffiliationTestHelper::AppendCommandLineSwitchesForLoginManager( command_line); const GURL gaia_url = gaia_https_forwarder_.GetURLForSSLHost(std::string()); @@ -99,22 +97,23 @@ std::unique_ptr<chromeos::SessionManagerClient>( fake_session_manager_client)); + policy::AffiliationTestHelper affiliation_helper = + policy::AffiliationTestHelper::CreateForCloud( + fake_session_manager_client); + if (enrollment_status() == EnrollmentStatus::ENROLLED) { std::set<std::string> device_affiliation_ids; device_affiliation_ids.insert(kAffiliationID); - policy::affiliation_test_helper::SetDeviceAffiliationIDs( - &device_policy_test_helper_, fake_session_manager_client, - nullptr /* fake_auth_policy_client */, device_affiliation_ids); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetDeviceAffiliationIDs( + &device_policy_test_helper_, device_affiliation_ids)); } if (user_status() == UserStatus::MANAGED_AFFILIATED_DOMAIN) { std::set<std::string> user_affiliation_ids; user_affiliation_ids.insert(kAffiliationID); policy::UserPolicyBuilder user_policy; - policy::affiliation_test_helper::SetUserAffiliationIDs( - &user_policy, fake_session_manager_client, - nullptr /* fake_auth_policy_client */, account_id_, - user_affiliation_ids); + ASSERT_NO_FATAL_FAILURE(affiliation_helper.SetUserAffiliationIDs( + &user_policy, account_id_, user_affiliation_ids)); } EXPECT_CALL(mock_policy_provider_, IsInitializationComplete(testing::_)) @@ -136,7 +135,7 @@ token_info.audience = GaiaUrls::GetInstance()->oauth2_chrome_client_id(); token_info.token = kTestUserinfoToken; token_info.email = account_id_.GetUserEmail(); - fake_gaia_.IssueOAuthToken(policy::affiliation_test_helper::kFakeRefreshToken, + fake_gaia_.IssueOAuthToken(policy::AffiliationTestHelper::kFakeRefreshToken, token_info); // On PRE_ test stage list of users is empty at this point. Then in the body @@ -144,7 +143,7 @@ // after PRE_ test the list of user contains one kEnterpriseUser user. // This user logs in. if (!IsPreTest()) { - policy::affiliation_test_helper::LoginUser(account_id_); + policy::AffiliationTestHelper::LoginUser(account_id_); if (user_status() != UserStatus::UNMANAGED) { policy::ProfilePolicyConnector* const connector = @@ -184,7 +183,7 @@ crypto::ScopedTestSystemNSSKeySlot* system_slot) {} void PlatformKeysTestBase::RunPreTest() { - policy::affiliation_test_helper::PreLoginUser(account_id_); + policy::AffiliationTestHelper::PreLoginUser(account_id_); } bool PlatformKeysTestBase::TestExtension(const std::string& page_url) {
diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc index 0077c27..d1930fe 100644 --- a/chrome/browser/extensions/bookmark_app_helper.cc +++ b/chrome/browser/extensions/bookmark_app_helper.cc
@@ -55,7 +55,6 @@ #include "extensions/browser/extension_system.h" #include "extensions/browser/notification_types.h" #include "extensions/browser/pref_names.h" -#include "extensions/common/constants.h" #include "extensions/common/extension.h" #include "extensions/common/url_pattern.h" #include "net/base/load_flags.h" @@ -564,6 +563,9 @@ profile_->GetPrefs()->SetInteger(pref_names::kBookmarkAppCreationLaunchType, launch_type); + if (forced_launch_type_) + launch_type = forced_launch_type_.value(); + // Set the launcher type for the app. SetLaunchType(profile_, extension->id(), launch_type); @@ -603,25 +605,28 @@ // On Mac, shortcuts are automatically created for hosted apps when they are // installed, so there is no need to create them again. #if !defined(OS_MACOSX) + if (create_shortcuts_) { #if !defined(OS_CHROMEOS) - web_app::ShortcutLocations creation_locations; + web_app::ShortcutLocations creation_locations; #if defined(OS_LINUX) || defined(OS_WIN) - creation_locations.on_desktop = true; + creation_locations.on_desktop = true; #else - creation_locations.on_desktop = false; + creation_locations.on_desktop = false; #endif - creation_locations.applications_menu_location = - web_app::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS; - creation_locations.in_quick_launch_bar = false; - web_app::CreateShortcuts(web_app::SHORTCUT_CREATION_BY_USER, - creation_locations, current_profile, extension); + creation_locations.applications_menu_location = + web_app::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS; + creation_locations.in_quick_launch_bar = false; + + web_app::CreateShortcuts(web_app::SHORTCUT_CREATION_BY_USER, + creation_locations, current_profile, extension); #else - // ChromeLauncherController does not exist in unit tests. - if (ChromeLauncherController::instance()) { - ChromeLauncherController::instance()->shelf_model()->PinAppWithID( - extension->id()); - } + // ChromeLauncherController does not exist in unit tests. + if (ChromeLauncherController::instance()) { + ChromeLauncherController::instance()->shelf_model()->PinAppWithID( + extension->id()); + } #endif // !defined(OS_CHROMEOS) + } // Reparent the tab into an app window immediately when opening as a window. if (!silent_install &&
diff --git a/chrome/browser/extensions/bookmark_app_helper.h b/chrome/browser/extensions/bookmark_app_helper.h index f264150..35757f3a 100644 --- a/chrome/browser/extensions/bookmark_app_helper.h +++ b/chrome/browser/extensions/bookmark_app_helper.h
@@ -19,6 +19,7 @@ #include "chrome/common/web_application_info.h" #include "content/public/browser/notification_observer.h" #include "content/public/browser/notification_registrar.h" +#include "extensions/common/constants.h" #include "extensions/common/extension.h" #include "third_party/blink/public/common/manifest/manifest.h" @@ -96,6 +97,21 @@ // If called, the installed extension will be considered default installed. void set_is_default_app() { is_default_app_ = true; } + // If called, desktop shortcuts will not be created. + void set_skip_shortcut_creation() { create_shortcuts_ = false; } + + bool create_shortcuts() const { return create_shortcuts_; } + + // If called, the installed app will launch in |launch_type|. User might still + // be able to change the launch type depending on the type of app. + void set_forced_launch_type(LaunchType launch_type) { + forced_launch_type_ = launch_type; + } + + const base::Optional<LaunchType>& forced_launch_type() const { + return forced_launch_type_; + } + protected: // Protected methods for testing. @@ -151,10 +167,14 @@ ForInstallableSite for_installable_site_ = ForInstallableSite::kUnknown; + base::Optional<LaunchType> forced_launch_type_; + bool is_policy_installed_app_ = false; bool is_default_app_ = false; + bool create_shortcuts_ = true; + // The mechanism via which the app creation was triggered. WebappInstallSource install_source_;
diff --git a/chrome/browser/extensions/bookmark_app_helper_unittest.cc b/chrome/browser/extensions/bookmark_app_helper_unittest.cc index 848df98..b41ca6b 100644 --- a/chrome/browser/extensions/bookmark_app_helper_unittest.cc +++ b/chrome/browser/extensions/bookmark_app_helper_unittest.cc
@@ -30,6 +30,7 @@ #include "extensions/common/extension_icon_set.h" #include "extensions/common/manifest_handlers/icons_handler.h" #include "testing/gtest/include/gtest/gtest.h" +#include "third_party/blink/public/common/manifest/manifest.h" #include "third_party/skia/include/core/SkBitmap.h" #include "ui/gfx/skia_util.h" @@ -439,6 +440,52 @@ } TEST_F(BookmarkAppHelperExtensionServiceTest, + CreateBookmarkAppForcedLauncherContainers) { + auto scoped_feature_list = std::make_unique<base::test::ScopedFeatureList>(); + scoped_feature_list->InitAndEnableFeature(features::kDesktopPWAWindowing); + + WebApplicationInfo web_app_info; + std::map<GURL, std::vector<SkBitmap>> icon_map; + + blink::Manifest manifest; + manifest.start_url = GURL(kAppUrl); + manifest.name = base::NullableString16(base::UTF8ToUTF16(kAppTitle), false); + manifest.scope = GURL(kAppScope); + { + TestBookmarkAppHelper helper(service_, web_app_info, web_contents()); + helper.set_forced_launch_type(LAUNCH_TYPE_REGULAR); + helper.Create(base::Bind(&TestBookmarkAppHelper::CreationComplete, + base::Unretained(&helper))); + + helper.CompleteInstallableCheck(kManifestUrl, manifest, + ForInstallableSite::kYes); + helper.CompleteIconDownload(true, icon_map); + + content::RunAllTasksUntilIdle(); + ASSERT_TRUE(helper.extension()); + EXPECT_EQ( + LAUNCH_CONTAINER_TAB, + GetLaunchContainer(ExtensionPrefs::Get(profile()), helper.extension())); + } + { + TestBookmarkAppHelper helper(service_, web_app_info, web_contents()); + helper.set_forced_launch_type(LAUNCH_TYPE_WINDOW); + helper.Create(base::Bind(&TestBookmarkAppHelper::CreationComplete, + base::Unretained(&helper))); + + helper.CompleteInstallableCheck(kManifestUrl, manifest, + ForInstallableSite::kNo); + helper.CompleteIconDownload(true, icon_map); + + content::RunAllTasksUntilIdle(); + ASSERT_TRUE(helper.extension()); + EXPECT_EQ( + LAUNCH_CONTAINER_WINDOW, + GetLaunchContainer(ExtensionPrefs::Get(profile()), helper.extension())); + } +} + +TEST_F(BookmarkAppHelperExtensionServiceTest, CreateBookmarkAppWithoutManifest) { WebApplicationInfo web_app_info; web_app_info.title = base::UTF8ToUTF16(kAppTitle);
diff --git a/chrome/browser/prefs/pref_service_incognito_whitelist.cc b/chrome/browser/prefs/pref_service_incognito_whitelist.cc index 4c896a97a..21551e6 100644 --- a/chrome/browser/prefs/pref_service_incognito_whitelist.cc +++ b/chrome/browser/prefs/pref_service_incognito_whitelist.cc
@@ -181,16 +181,7 @@ #endif // !defined(OS_ANDROID) // chrome/common/pref_names.h - prefs::kAbusiveExperienceInterventionEnforce, - prefs::kChildAccountStatusKnown, prefs::kDefaultApps, - prefs::kSafeBrowsingForTrustedSourcesEnabled, prefs::kDisableScreenshots, - prefs::kDownloadRestrictions, prefs::kForceEphemeralProfiles, - prefs::kHomePageIsNewTabPage, prefs::kHomePage, - prefs::kImportantSitesDialogHistory, -#if defined(OS_WIN) - prefs::kLastProfileResetTimestamp, prefs::kChromeCleanerResetPending, -#endif - prefs::kNewTabPageLocationOverride, prefs::kRestoreOnStartup, + prefs::kImportantSitesDialogHistory, prefs::kNewTabPageLocationOverride, prefs::kSessionExitedCleanly, prefs::kSessionExitType, prefs::kObservedSessionTime, prefs::kRecurrentSSLInterstitial, prefs::kSiteEngagementLastUpdateTime, prefs::kURLsToRestoreOnStartup, @@ -205,7 +196,6 @@ #endif prefs::kDataSaverEnabled, prefs::kSSLErrorOverrideAllowed, - prefs::kIncognitoModeAvailability, prefs::kSearchSuggestEnabled, #if defined(OS_ANDROID) prefs::kContextualSearchEnabled, #endif // defined(OS_ANDROID) @@ -216,11 +206,9 @@ #if defined(OS_MACOSX) prefs::kShowFullscreenToolbar, prefs::kAllowJavascriptAppleEvents, #endif - prefs::kPromptForDownload, prefs::kAlternateErrorPagesEnabled, - prefs::kDnsPrefetchingStartupList, prefs::kDnsPrefetchingHostReferralList, - prefs::kQuicAllowed, prefs::kNetworkQualities, - prefs::kNetworkPredictionOptions, prefs::kDefaultAppsInstallState, - prefs::kHideWebStoreIcon, + prefs::kAlternateErrorPagesEnabled, prefs::kDnsPrefetchingStartupList, + prefs::kDnsPrefetchingHostReferralList, prefs::kNetworkQualities, + prefs::kNetworkPredictionOptions, #if defined(OS_CHROMEOS) prefs::kEnableTouchpadThreeFingerClick, prefs::kNaturalScroll, prefs::kPrimaryMouseButtonRight, prefs::kMouseReverseScroll, @@ -257,13 +245,10 @@ prefs::kUsageTimeLimit, prefs::kScreenTimeLastState, prefs::kEnableSyncConsent, #endif // defined(OS_CHROMEOS) - prefs::kShowHomeButton, prefs::kSpeechRecognitionFilterProfanities, - prefs::kSavingBrowserHistoryDisabled, prefs::kAllowDeletingBrowserHistory, + prefs::kSpeechRecognitionFilterProfanities, #if !defined(OS_ANDROID) prefs::kMdHistoryMenuPromoShown, #endif - prefs::kForceGoogleSafeSearch, prefs::kForceYouTubeRestrict, - prefs::kForceSessionSync, prefs::kAllowedDomainsForApps, #if defined(OS_LINUX) && !defined(OS_CHROMEOS) prefs::kUsesSystemTheme, #endif @@ -310,8 +295,6 @@ prefs::kMessageCenterDisabledExtensionIds, prefs::kMessageCenterDisabledSystemComponentIds, - prefs::kFullscreenAllowed, - prefs::kLocalDiscoveryNotificationsEnabled, #if defined(OS_ANDROID)
diff --git a/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.js b/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.js index ec8cb20..7201107 100644 --- a/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.js +++ b/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.js
@@ -38,7 +38,7 @@ defaultUrl: { type: String, value: - 'https://www.gstatic.com/opa-android/oobe/a02187e41eed9e42/v1_omni_en_us.html', + 'https://www.gstatic.com/opa-android/oobe/a02187e41eed9e42/v2_omni_en_us.html', }, }, @@ -153,7 +153,7 @@ this.loadingError_ = false; this.headerReceived_ = false; this.valuePropView_.src = - 'https://www.gstatic.com/opa-android/oobe/a02187e41eed9e42/v1_omni_' + + 'https://www.gstatic.com/opa-android/oobe/a02187e41eed9e42/v2_omni_' + this.locale + '.html'; this.buttonsDisabled = true;
diff --git a/chrome/browser/resources/chromeos/chromevox/BUILD.gn b/chrome/browser/resources/chromeos/chromevox/BUILD.gn index bb56b7f..bd65b19 100644 --- a/chrome/browser/resources/chromeos/chromevox/BUILD.gn +++ b/chrome/browser/resources/chromeos/chromevox/BUILD.gn
@@ -139,6 +139,7 @@ "cvox2/background/i_search.js", "cvox2/background/keyboard_handler.js", "cvox2/background/live_regions.js", + "cvox2/background/log.js", "cvox2/background/math_handler.js", "cvox2/background/media_automation_handler.js", "cvox2/background/next_earcons.js", @@ -229,6 +230,7 @@ ":chromevox_background_script", ":chromevox_content_script", ":chromevox_kbexplorer_script", + ":chromevox_log_script", ":chromevox_min_content_script", ":chromevox_options_script", ":chromevox_panel_script", @@ -241,6 +243,7 @@ chromevox_background_script_loader_file = "cvox2/background/loader.js" chromevox_content_script_loader_file = "chromevox/injected/loader.js" chromevox_kbexplorer_loader_file = "chromevox/background/kbexplorer_loader.js" +chromevox_log_loader_file = "cvox2/background/log_loader.js" chromevox_min_content_script_loader_file = "cvox2/injected/loader.js" chromevox_options_script_loader_file = "chromevox/background/options_loader.js" chromevox_panel_script_loader_file = "cvox2/background/panel_loader.js" @@ -294,6 +297,8 @@ "cvox2/background/earcons/skim.wav", "cvox2/background/earcons/small_room_2.wav", "cvox2/background/earcons/static.wav", + "cvox2/background/log.css", + "cvox2/background/log.html", "cvox2/background/panel.css", "cvox2/background/panel.html", "images/chromevox-128.png", @@ -314,6 +319,7 @@ chromevox_background_script_loader_file, chromevox_content_script_loader_file, chromevox_kbexplorer_loader_file, + chromevox_log_loader_file, chromevox_min_content_script_loader_file, chromevox_options_script_loader_file, chromevox_panel_script_loader_file, @@ -430,6 +436,13 @@ output_file = "$chromevox_out_dir/chromeVoxKbExplorerScript.js" } + compress_js("chromevox_log_script") { + sources = [ + chromevox_log_loader_file, + ] + output_file = "$chromevox_out_dir/chromeVoxLogScript.js" + } + compress_js("chromevox_options_script") { sources = [ chromevox_options_script_loader_file,
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json b/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json index c51f8ba..d9f77a8 100644 --- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json +++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
@@ -586,6 +586,15 @@ } }, { + "command": "showLogPage", + "sequence": { + "cvoxModifier": true, + "keys": { + "keyCode": [79, 87] + } + } + }, + { "command": "help", "sequence": { "cvoxModifier": true,
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options_loader.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options_loader.js index ec7999a..b8733f27 100644 --- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options_loader.js +++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options_loader.js
@@ -4,7 +4,6 @@ /** * @fileoverview Loads the options script. - * */ goog.require('cvox.OptionsPage');
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js index 406001e..c1c10701 100644 --- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
@@ -105,6 +105,15 @@ }; chrome.windows.create(explorerPage); break; + case 'showLogPage': + chrome.commandLinePrivate.hasSwitch( + 'enable-chromevox-developer-option', function(enable) { + if (enable) { + var logPage = {url: 'cvox2/background/log.html', type: 'panel'}; + chrome.windows.create(logPage); + } + }); + break; case 'decreaseTtsRate': CommandHandler.increaseOrDecreaseSpeechProperty_( cvox.AbstractTts.RATE, false);
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js index 9fdb01d..a2dfbaf 100644 --- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js
@@ -96,63 +96,9 @@ * @param {boolean} checked */ notifyEventStreamFilterChangedAll: function(checked) { - var EventTypeList = [ - EventType.ACTIVEDESCENDANTCHANGED, - EventType.ALERT, - EventType.ARIA_ATTRIBUTE_CHANGED, - EventType.AUTOCORRECTION_OCCURED, - EventType.BLUR, - EventType.CHECKED_STATE_CHANGED, - EventType.CHILDREN_CHANGED, - EventType.CLICKED, - EventType.DOCUMENT_SELECTION_CHANGED, - EventType.DOCUMENT_TITLE_CHANGED, - EventType.EXPANDED_CHANGED, - EventType.FOCUS, - EventType.FOCUS_CONTEXT, - EventType.IMAGE_FRAME_UPDATED, - EventType.HIDE, - EventType.HIT_TEST_RESULT, - EventType.HOVER, - EventType.INVALID_STATUS_CHANGED, - EventType.LAYOUT_COMPLETE, - EventType.LIVE_REGION_CREATED, - EventType.LIVE_REGION_CHANGED, - EventType.LOAD_COMPLETE, - EventType.LOCATION_CHANGED, - EventType.MEDIA_STARTED_PLAYING, - EventType.MEDIA_STOPPED_PLAYING, - EventType.MENU_END, - EventType.MENU_LIST_ITEM_SELECTED, - EventType.MENU_LIST_VALUE_CHANGED, - EventType.MENU_POPUP_END, - EventType.MENU_POPUP_START, - EventType.MENU_START, - EventType.MOUSE_CANCELED, - EventType.MOUSE_DRAGGED, - EventType.MOUSE_MOVED, - EventType.MOUSE_PRESSED, - EventType.MOUSE_RELEASED, - EventType.ROW_COLLAPSED, - EventType.ROW_COUNT_CHANGED, - EventType.ROW_EXPANDED, - EventType.SCROLL_POSITION_CHANGED, - EventType.SCROLLED_TO_ANCHOR, - EventType.SELECTED_CHILDREN_CHANGED, - EventType.SELECTION, - EventType.SELECTION_ADD, - EventType.SELECTION_REMOVE, - EventType.SHOW, - EventType.STATE_CHANGED, - EventType.TEXT_CHANGED, - EventType.TEXT_SELECTION_CHANGED, - EventType.TREE_CHANGED, - EventType.VALUE_CHANGED - ]; - - for (var evtType of EventTypeList) { - if (localStorage[evtType] == 'true') - this.notifyEventStreamFilterChanged(evtType, checked); + for (var type in EventType) { + if (localStorage[EventType[type]] == 'true') + this.notifyEventStreamFilterChanged(EventType[type], checked); } }, };
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.css b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.css new file mode 100644 index 0000000..fb5abb1 --- /dev/null +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.css
@@ -0,0 +1,3 @@ +/* Copyright 2018 The Chromium Authors. All rights reserved. + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. */
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html new file mode 100644 index 0000000..cd4161d --- /dev/null +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html
@@ -0,0 +1,15 @@ +<!-- Copyright 2018 The Chromium Authors. All rights reserved. + Use of this source code is governed by a BSD-style license that can be + found in the LICENSE file. --> +<html> +<head> +<title class="i18n" msg="log_title">chromevox-log</title> +<meta charset="utf-8"> +<link rel="stylesheet" type="text/css" href="log.css"> +<script type="text/javascript" src="../../chromeVoxLogScript.js"></script> +</head> + +<body> +<h1>ChromeVox Log</h1> +</body> +</html>
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js new file mode 100644 index 0000000..e5852b14 --- /dev/null +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js
@@ -0,0 +1,16 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** + * @fileoverview ChromeVox log page. + * + */ + +goog.provide('cvox.LogPage'); + +/** + * Class to manage the log page. + * @constructor + */ +cvox.LogPage = function() {};
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_loader.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_loader.js new file mode 100644 index 0000000..bd3c617 --- /dev/null +++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_loader.js
@@ -0,0 +1,9 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** + * @fileoverview Loads the log script. + */ + +goog.require('cvox.LogPage');
diff --git a/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd b/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd index 7fce4fa3..ca7916e 100644 --- a/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd +++ b/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
@@ -589,6 +589,9 @@ <message desc="The title of ChromeVox Learn Mode page. The keyboard explorer voices the name of each key when the user presses it." name="IDS_CHROMEVOX_KBEXPLORER_TITLE"> ChromeVox Learn Mode </message> + <message desc="The title of ChromeVox Log page." name="IDS_CHROMEVOX_LOG_TITLE"> + ChromeVox Log + </message> <message desc="The instructions for ChromeVox Learn Mode. The keyboard explorer voices the name of each key when the user presses it. * These instructions describe how to use the keyboard explorer." name="IDS_CHROMEVOX_KBEXPLORER_INSTRUCTIONS"> Press any key to learn its name. Ctrl+W will close learn mode. </message>
diff --git a/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py b/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py index e31dff46..0dab9310 100755 --- a/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py +++ b/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py
@@ -70,6 +70,11 @@ _CHROME_EXTENSIONS_EXTERNS = ( ChromeRootPath('third_party/closure_compiler/externs/chrome_extensions.js')) +# CommandLinePrivate externs file. +_COMMANDLINE_PRIVATE_EXTERNS = ( + ChromeRootPath( + 'third_party/closure_compiler/externs/command_line_private.js')) + # Externs common to many ChromeVox scripts. _COMMON_EXTERNS = [ @@ -82,6 +87,7 @@ _AUTOMATION_EXTERNS, _CHROME_EXTERNS, _CHROME_EXTENSIONS_EXTERNS, + _COMMANDLINE_PRIVATE_EXTERNS, _METRICS_PRIVATE_EXTERNS, _SETTINGS_PRIVATE_EXTERNS,] @@ -89,6 +95,7 @@ _TOP_LEVEL_SCRIPTS = [ [[CVoxPath('chromevox/background/kbexplorer_loader.js')], _COMMON_EXTERNS], [[CVoxPath('chromevox/background/options_loader.js')], _COMMON_EXTERNS], + [[CVoxPath('cvox2/background/log_loader.js')], _COMMON_EXTERNS], [[CVoxPath('chromevox/injected/loader.js')], _COMMON_EXTERNS], [[CVoxPath('cvox2/background/loader.js')], _COMMON_EXTERNS], [[CVoxPath('cvox2/background/panel_loader.js')], _COMMON_EXTERNS],
diff --git a/chrome/browser/resources/settings/people_page/sync_page.html b/chrome/browser/resources/settings/people_page/sync_page.html index 5bc202e..3c4f62de 100644 --- a/chrome/browser/resources/settings/people_page/sync_page.html +++ b/chrome/browser/resources/settings/people_page/sync_page.html
@@ -34,6 +34,10 @@ margin-inline-start: var(--settings-indent-width); } + #create-password-box { + margin-bottom: 1em; + } + #create-password-box .list-item { margin-bottom: var(--cr-form-field-bottom-spacing); }
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc index 516b2d1..b738d06 100644 --- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc +++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
@@ -1165,15 +1165,17 @@ EXPECT_EQ(0u, items); EXPECT_EQ(0u, running_browser); - LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_WINDOW, - WindowOpenDisposition::NEW_WINDOW); + const Extension* extension = + LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_WINDOW, + WindowOpenDisposition::NEW_WINDOW); // No new browser should get detected, even though one more is running. EXPECT_EQ(0u, NumberOfDetectedLauncherBrowsers(false)); EXPECT_EQ(++running_browser, chrome::GetTotalBrowserCount()); - LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_TAB, - WindowOpenDisposition::NEW_WINDOW); + OpenApplication(AppLaunchParams( + profile(), extension, extensions::LAUNCH_CONTAINER_TAB, + WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST)); // A new browser should get detected and one more should be running. EXPECT_EQ(NumberOfDetectedLauncherBrowsers(false), 1u);
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc index 1627ad27..a6737b7 100644 --- a/chrome/browser/ui/browser_browsertest.cc +++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1393,10 +1393,10 @@ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST)); ASSERT_TRUE(app_window); - // Apps launched in a window from the NTP have an extensions tab helper but - // do not have extension_app set in it. + // Apps launched in a window from the NTP have an extensions tab helper with + // extension_app set. ASSERT_TRUE(extensions::TabHelper::FromWebContents(app_window)); - EXPECT_FALSE( + EXPECT_TRUE( extensions::TabHelper::FromWebContents(app_window)->extension_app()); EXPECT_EQ(extensions::AppLaunchInfo::GetFullLaunchURL(extension_app), app_window->GetURL());
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc index f892198..4c05fd6b 100644 --- a/chrome/browser/ui/browser_commands.cc +++ b/chrome/browser/ui/browser_commands.cc
@@ -1226,21 +1226,23 @@ .spec())); } -void OpenInChrome(Browser* browser) { +Browser* OpenInChrome(Browser* hosted_app_browser) { + DCHECK(hosted_app_browser->hosted_app_controller()); // Find a non-incognito browser. Browser* target_browser = - chrome::FindTabbedBrowser(browser->profile(), false); + chrome::FindTabbedBrowser(hosted_app_browser->profile(), false); if (!target_browser) { target_browser = - new Browser(Browser::CreateParams(browser->profile(), true)); + new Browser(Browser::CreateParams(hosted_app_browser->profile(), true)); } - TabStripModel* source_tabstrip = browser->tab_strip_model(); + TabStripModel* source_tabstrip = hosted_app_browser->tab_strip_model(); target_browser->tab_strip_model()->AppendWebContents( source_tabstrip->DetachWebContentsAt(source_tabstrip->active_index()), true); target_browser->window()->Show(); + return target_browser; } bool CanViewSource(const Browser* browser) {
diff --git a/chrome/browser/ui/browser_commands.h b/chrome/browser/ui/browser_commands.h index e7d65dc..50d04be 100644 --- a/chrome/browser/ui/browser_commands.h +++ b/chrome/browser/ui/browser_commands.h
@@ -146,7 +146,9 @@ void ClearCache(Browser* browser); bool IsDebuggerAttachedToCurrentTab(Browser* browser); void CopyURL(Browser* browser); -void OpenInChrome(Browser* browser); +// Moves the WebContents of a hosted app Browser to a tabbed Browser. Returns +// the tabbed Browser. +Browser* OpenInChrome(Browser* hosted_app_browser); bool CanViewSource(const Browser* browser); #if defined(OS_WIN) || (defined(OS_LINUX) && !defined(OS_CHROMEOS)) void ToggleConfirmToQuitOption(Browser* browser);
diff --git a/chrome/browser/ui/extensions/hosted_app_browser_controller.cc b/chrome/browser/ui/extensions/hosted_app_browser_controller.cc index ad6d623..323e3c5 100644 --- a/chrome/browser/ui/extensions/hosted_app_browser_controller.cc +++ b/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
@@ -126,6 +126,9 @@ if (!controller) return; + extensions::TabHelper::FromWebContents(web_contents) + ->SetExtensionApp(controller->GetExtension()); + web_contents->NotifyPreferencesChanged(); } @@ -300,6 +303,8 @@ contents->GetMutableRendererPrefs()->can_accept_load_drops = true; rvh->SyncRendererPrefs(); + extensions::TabHelper::FromWebContents(contents)->SetExtensionApp(nullptr); + contents->NotifyPreferencesChanged(); }
diff --git a/chrome/browser/ui/extensions/hosted_app_browsertest.cc b/chrome/browser/ui/extensions/hosted_app_browsertest.cc index aa447481..9dde77b 100644 --- a/chrome/browser/ui/extensions/hosted_app_browsertest.cc +++ b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
@@ -207,6 +207,14 @@ return image_loaded; } +bool IsBrowserOpen(const Browser* test_browser) { + for (Browser* browser : *BrowserList::GetInstance()) { + if (browser == test_browser) + return true; + } + return false; +} + } // namespace class TestAppBannerManagerDesktop : public banners::AppBannerManagerDesktop { @@ -1145,8 +1153,40 @@ IN_PROC_BROWSER_TEST_P(HostedAppPWAOnlyTest, UninstallPwaWithWindowOpened) { ASSERT_TRUE(https_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start()); - InstallMixedContentPWA(); + InstallSecurePWA(); + + EXPECT_TRUE(IsBrowserOpen(app_browser_)); + UninstallExtension(app_->id()); + base::RunLoop().RunUntilIdle(); + + EXPECT_FALSE(IsBrowserOpen(app_browser_)); +} + +// PWAs moved to tabbed browsers should not get closed when uninstalled. +IN_PROC_BROWSER_TEST_P(HostedAppPWAOnlyTest, UninstallPwaWithWindowMovedToTab) { + ASSERT_TRUE(https_server()->Start()); + ASSERT_TRUE(embedded_test_server()->Start()); + + InstallSecurePWA(); + + EXPECT_TRUE(IsBrowserOpen(app_browser_)); + + Browser* tabbed_browser = chrome::OpenInChrome(app_browser_); + base::RunLoop().RunUntilIdle(); + + EXPECT_TRUE(IsBrowserOpen(tabbed_browser)); + EXPECT_EQ(tabbed_browser, browser()); + EXPECT_FALSE(IsBrowserOpen(app_browser_)); + + UninstallExtension(app_->id()); + base::RunLoop().RunUntilIdle(); + + EXPECT_TRUE(IsBrowserOpen(tabbed_browser)); + EXPECT_EQ(tabbed_browser->tab_strip_model() + ->GetActiveWebContents() + ->GetLastCommittedURL(), + GetSecureAppURL()); } IN_PROC_BROWSER_TEST_P(HostedAppTest,
diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc index bfcbc8b..aeb2507 100644 --- a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc +++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
@@ -111,9 +111,16 @@ init_params.delegate = this; init_params.remove_standard_frame = ShouldRemoveStandardFrame(); init_params.use_system_default_icon = true; - if (create_params.alpha_enabled) + if (create_params.alpha_enabled) { init_params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW; + // The given window is most likely not rectangular since it uses + // transparency and has no standard frame, don't show a shadow for it. + // TODO(skuhne): If we run into an application which should have a shadow + // but does not have, a new attribute has to be added. + if (IsFrameless()) + init_params.shadow_type = views::Widget::InitParams::SHADOW_TYPE_NONE; + } init_params.keep_on_top = create_params.always_on_top; init_params.visible_on_all_workspaces = create_params.visible_on_all_workspaces;
diff --git a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc index 9a7f310..9839b520 100644 --- a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc +++ b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
@@ -530,7 +530,8 @@ layout->StartRowWithPadding(views::GridLayout::kFixedSize, kColumnId, views::GridLayout::kFixedSize, 0); - layout->AddView(CreateSiteSettingsLink(side_margin, this).release()); + if (!profile->IsGuestSession()) + layout->AddView(CreateSiteSettingsLink(side_margin, this).release()); views::BubbleDialogDelegateView::CreateBubble(this); presenter_.reset(new PageInfo(
diff --git a/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc b/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc index 9d01827..7f06f9d0 100644 --- a/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc +++ b/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc
@@ -72,17 +72,16 @@ launch_container->GetString() == kLaunchContainerTabValue); PendingAppManager::LaunchContainer container; - - // TODO(crbug.com/864904): Remove this default once PendingAppManager - // supports not setting the launch container. if (!launch_container) - container = PendingAppManager::LaunchContainer::kTab; + container = PendingAppManager::LaunchContainer::kDefault; else if (launch_container->GetString() == kLaunchContainerWindowValue) container = PendingAppManager::LaunchContainer::kWindow; else container = PendingAppManager::LaunchContainer::kTab; - apps_to_install.emplace_back(GURL(url.GetString()), container); + // There is a separate policy to create shortcuts/pin apps to shelf. + apps_to_install.emplace_back(GURL(url.GetString()), container, + false /* create_shortcuts */); } pending_app_manager_->InstallApps(std::move(apps_to_install), base::DoNothing());
diff --git a/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc b/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc index bc36a6d..cf3e68f 100644 --- a/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc +++ b/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc
@@ -102,9 +102,40 @@ std::vector<PendingAppManager::AppInfo> expected_apps_to_install; expected_apps_to_install.emplace_back( - GURL(kUrl1), PendingAppManager::LaunchContainer::kWindow); + GURL(kUrl1), PendingAppManager::LaunchContainer::kWindow, + false /* create_shortcuts */); expected_apps_to_install.emplace_back( - GURL(kUrl2), PendingAppManager::LaunchContainer::kTab); + GURL(kUrl2), PendingAppManager::LaunchContainer::kTab, + false /* create_shortcuts */); + + EXPECT_EQ(apps_to_install, expected_apps_to_install); +} + +TEST_F(WebAppPolicyManagerTest, ForceInstallAppWithNoForcedLaunchContainer) { + auto prefs = std::make_unique<TestingPrefServiceSyncable>(); + RegisterUserProfilePrefs(prefs->registry()); + + base::Value list(base::Value::Type::LIST); + { + base::Value item1(base::Value::Type::DICTIONARY); + item1.SetKey(kUrlKey, base::Value(kUrl1)); + + list.GetList().push_back(std::move(item1)); + + prefs->Set(prefs::kWebAppInstallForceList, std::move(list)); + } + + auto pending_app_manager = std::make_unique<TestPendingAppManager>(); + WebAppPolicyManager web_app_policy_manager(prefs.get(), + pending_app_manager.get()); + base::RunLoop().RunUntilIdle(); + + const auto& apps_to_install = pending_app_manager->installed_apps(); + + std::vector<PendingAppManager::AppInfo> expected_apps_to_install; + expected_apps_to_install.emplace_back( + GURL(kUrl1), PendingAppManager::LaunchContainer::kDefault, + false /* create_shortcuts */); EXPECT_EQ(apps_to_install, expected_apps_to_install); }
diff --git a/chrome/browser/web_applications/components/pending_app_manager.cc b/chrome/browser/web_applications/components/pending_app_manager.cc index f1e97801..9dbee20d 100644 --- a/chrome/browser/web_applications/components/pending_app_manager.cc +++ b/chrome/browser/web_applications/components/pending_app_manager.cc
@@ -4,24 +4,46 @@ #include "chrome/browser/web_applications/components/pending_app_manager.h" +#include <memory> +#include <utility> + namespace web_app { -PendingAppManager::AppInfo::AppInfo(GURL url, LaunchContainer launch_container) - : url(std::move(url)), launch_container(launch_container) {} +PendingAppManager::AppInfo::AppInfo(GURL url, + LaunchContainer launch_container, + bool create_shortcuts) + : url(std::move(url)), + launch_container(launch_container), + create_shortcuts(create_shortcuts) {} PendingAppManager::AppInfo::AppInfo(PendingAppManager::AppInfo&& other) = default; PendingAppManager::AppInfo::~AppInfo() = default; +std::unique_ptr<PendingAppManager::AppInfo> PendingAppManager::AppInfo::Clone() + const { + auto other = + std::make_unique<AppInfo>(url, launch_container, create_shortcuts); + DCHECK_EQ(*this, *other); + return other; +} + bool PendingAppManager::AppInfo::operator==( const PendingAppManager::AppInfo& other) const { - return std::tie(url, launch_container) == - std::tie(other.url, other.launch_container); + return std::tie(url, launch_container, create_shortcuts) == + std::tie(other.url, other.launch_container, other.create_shortcuts); } PendingAppManager::PendingAppManager() = default; PendingAppManager::~PendingAppManager() = default; +std::ostream& operator<<(std::ostream& out, + const PendingAppManager::AppInfo& app_info) { + return out << "url: " << app_info.url << "\n launch_container: " + << static_cast<int32_t>(app_info.launch_container) + << "\n create_shortcuts: " << app_info.create_shortcuts; +} + } // namespace web_app
diff --git a/chrome/browser/web_applications/components/pending_app_manager.h b/chrome/browser/web_applications/components/pending_app_manager.h index 08f5a47a..5924b75 100644 --- a/chrome/browser/web_applications/components/pending_app_manager.h +++ b/chrome/browser/web_applications/components/pending_app_manager.h
@@ -5,6 +5,8 @@ #ifndef CHROME_BROWSER_WEB_APPLICATIONS_COMPONENTS_PENDING_APP_MANAGER_H_ #define CHROME_BROWSER_WEB_APPLICATIONS_COMPONENTS_PENDING_APP_MANAGER_H_ +#include <memory> +#include <ostream> #include <string> #include <vector> @@ -29,19 +31,28 @@ // How the app will be launched after installation. enum class LaunchContainer { + // When `kDefault` is used, the app will launch in a window if the site is + // "installable" (also referred to as Progressive Web App) and in a tab if + // the site is not "installable". + kDefault, kTab, kWindow, }; struct AppInfo { - AppInfo(GURL url, LaunchContainer launch_container); + AppInfo(GURL url, + LaunchContainer launch_container, + bool create_shortcuts = true); AppInfo(AppInfo&& other); ~AppInfo(); + std::unique_ptr<AppInfo> Clone() const; + bool operator==(const AppInfo& other) const; - GURL url; - LaunchContainer launch_container; + const GURL url; + const LaunchContainer launch_container; + const bool create_shortcuts; DISALLOW_COPY_AND_ASSIGN(AppInfo); }; @@ -71,6 +82,9 @@ DISALLOW_COPY_AND_ASSIGN(PendingAppManager); }; +std::ostream& operator<<(std::ostream& out, + const PendingAppManager::AppInfo& app_info); + } // namespace web_app #endif // CHROME_BROWSER_WEB_APPLICATIONS_COMPONENTS_PENDING_APP_MANAGER_H_
diff --git a/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc b/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc index fa4f87bd..d383f611 100644 --- a/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc +++ b/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
@@ -17,6 +17,7 @@ #include "chrome/browser/web_applications/extensions/bookmark_app_installer.h" #include "chrome/common/web_application_info.h" #include "content/public/browser/browser_thread.h" +#include "extensions/common/constants.h" #include "extensions/common/extension.h" namespace extensions { @@ -104,6 +105,21 @@ // is plumbed through this class. helper_ = helper_factory_.Run(profile_, *web_app_info, web_contents, WebappInstallSource::MENU_BROWSER_TAB); + + switch (app_info_.launch_container) { + case web_app::PendingAppManager::LaunchContainer::kDefault: + break; + case web_app::PendingAppManager::LaunchContainer::kTab: + helper_->set_forced_launch_type(LAUNCH_TYPE_REGULAR); + break; + case web_app::PendingAppManager::LaunchContainer::kWindow: + helper_->set_forced_launch_type(LAUNCH_TYPE_WINDOW); + break; + } + + if (!app_info_.create_shortcuts) + helper_->set_skip_shortcut_creation(); + helper_->Create(base::Bind(&BookmarkAppInstallationTask::OnInstalled, weak_ptr_factory_.GetWeakPtr(), base::Passed(&result_callback)));
diff --git a/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc b/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc index dc6eb1bd..0fbc265 100644 --- a/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc +++ b/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc
@@ -29,6 +29,7 @@ #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_utils.h" #include "content/public/test/web_contents_tester.h" +#include "extensions/common/constants.h" #include "extensions/common/extension_id.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/blink/public/common/manifest/manifest.h" @@ -55,6 +56,13 @@ : BookmarkAppHelper(profile, web_app_info, contents, install_source) {} ~TestBookmarkAppHelper() override {} + void CompleteInstallation() { + CompleteInstallableCheck(); + content::RunAllTasksUntilIdle(); + CompleteIconDownload(); + content::RunAllTasksUntilIdle(); + } + void CompleteInstallableCheck() { blink::Manifest manifest; InstallableData data = { @@ -78,6 +86,37 @@ DISALLOW_COPY_AND_ASSIGN(TestBookmarkAppHelper); }; +// All BookmarkAppDataRetriever operations are async, so this class posts tasks +// when running callbacks to simulate async behavior in tests as well. +class TestDataRetriever : public BookmarkAppDataRetriever { + public: + explicit TestDataRetriever(std::unique_ptr<WebApplicationInfo> web_app_info) + : web_app_info_(std::move(web_app_info)) {} + + ~TestDataRetriever() override = default; + + void GetWebApplicationInfo(content::WebContents* web_contents, + GetWebApplicationInfoCallback callback) override { + DCHECK(web_contents); + base::ThreadTaskRunnerHandle::Get()->PostTask( + FROM_HERE, + base::BindOnce(std::move(callback), std::move(web_app_info_))); + } + + void GetIcons(const GURL& app_url, + const std::vector<GURL>& icon_urls, + GetIconsCallback callback) override { + base::ThreadTaskRunnerHandle::Get()->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), + std::vector<WebApplicationInfo::IconInfo>())); + } + + private: + std::unique_ptr<WebApplicationInfo> web_app_info_; + + DISALLOW_COPY_AND_ASSIGN(TestDataRetriever); +}; + class BookmarkAppInstallationTaskTest : public ChromeRenderViewHostTestHarness { public: BookmarkAppInstallationTaskTest() = default; @@ -100,6 +139,16 @@ } protected: + void SetTestingFactories(BookmarkAppInstallationTask* task, + const GURL& app_url) { + WebApplicationInfo info; + info.app_url = app_url; + info.title = base::UTF8ToUTF16(kWebAppTitle); + task->SetDataRetrieverForTesting(std::make_unique<TestDataRetriever>( + std::make_unique<WebApplicationInfo>(std::move(info)))); + task->SetBookmarkAppHelperFactoryForTesting(helper_factory()); + } + BookmarkAppInstallationTask::BookmarkAppHelperFactory helper_factory() { return base::BindRepeating( &BookmarkAppInstallationTaskTest::CreateTestBookmarkAppHelper, @@ -135,37 +184,6 @@ DISALLOW_COPY_AND_ASSIGN(BookmarkAppInstallationTaskTest); }; -// All BookmarkAppDataRetriever operations are async, so this class posts tasks -// when running callbacks to simulate async behavior in tests as well. -class TestDataRetriever : public BookmarkAppDataRetriever { - public: - explicit TestDataRetriever(std::unique_ptr<WebApplicationInfo> web_app_info) - : web_app_info_(std::move(web_app_info)) {} - - ~TestDataRetriever() override = default; - - void GetWebApplicationInfo(content::WebContents* web_contents, - GetWebApplicationInfoCallback callback) override { - DCHECK(web_contents); - base::ThreadTaskRunnerHandle::Get()->PostTask( - FROM_HERE, - base::BindOnce(std::move(callback), std::move(web_app_info_))); - } - - void GetIcons(const GURL& app_url, - const std::vector<GURL>& icon_urls, - GetIconsCallback callback) override { - base::ThreadTaskRunnerHandle::Get()->PostTask( - FROM_HERE, base::BindOnce(std::move(callback), - std::vector<WebApplicationInfo::IconInfo>())); - } - - private: - std::unique_ptr<WebApplicationInfo> web_app_info_; - - DISALLOW_COPY_AND_ASSIGN(TestDataRetriever); -}; - class TestInstaller : public BookmarkAppInstaller { public: explicit TestInstaller(Profile* profile, bool succeeds) @@ -285,12 +303,7 @@ web_app::PendingAppManager::AppInfo( app_url, web_app::PendingAppManager::LaunchContainer::kWindow)); - WebApplicationInfo info; - info.app_url = app_url; - info.title = base::UTF8ToUTF16(kWebAppTitle); - task->SetDataRetrieverForTesting(std::make_unique<TestDataRetriever>( - std::make_unique<WebApplicationInfo>(std::move(info)))); - task->SetBookmarkAppHelperFactoryForTesting(helper_factory()); + SetTestingFactories(task.get(), app_url); task->InstallWebAppOrShortcutFromWebContents( web_contents(), @@ -316,12 +329,7 @@ web_app::PendingAppManager::AppInfo( app_url, web_app::PendingAppManager::LaunchContainer::kWindow)); - WebApplicationInfo info; - info.app_url = app_url; - info.title = base::UTF8ToUTF16(kWebAppTitle); - task->SetDataRetrieverForTesting(std::make_unique<TestDataRetriever>( - std::make_unique<WebApplicationInfo>(std::move(info)))); - task->SetBookmarkAppHelperFactoryForTesting(helper_factory()); + SetTestingFactories(task.get(), app_url); task->InstallWebAppOrShortcutFromWebContents( web_contents(), @@ -338,4 +346,95 @@ EXPECT_FALSE(app_installed()); } +TEST_F(BookmarkAppInstallationTaskTest, + WebAppOrShortcutFromContents_NoShortcuts) { + const GURL app_url(kWebAppUrl); + + web_app::PendingAppManager::AppInfo app_info( + app_url, web_app::PendingAppManager::LaunchContainer::kWindow, + false /* create_shortcuts */); + auto task = std::make_unique<BookmarkAppInstallationTask>( + profile(), std::move(app_info)); + + SetTestingFactories(task.get(), app_url); + + task->InstallWebAppOrShortcutFromWebContents( + web_contents(), + base::BindOnce(&BookmarkAppInstallationTaskTest::OnInstallationTaskResult, + base::Unretained(this), base::DoNothing().Once())); + content::RunAllTasksUntilIdle(); + + test_helper().CompleteInstallation(); + + EXPECT_TRUE(app_installed()); + + EXPECT_FALSE(test_helper().create_shortcuts()); +} + +TEST_F(BookmarkAppInstallationTaskTest, + WebAppOrShortcutFromContents_ForcedContainerWindow) { + const GURL app_url(kWebAppUrl); + + web_app::PendingAppManager::AppInfo app_info( + app_url, web_app::PendingAppManager::LaunchContainer::kWindow); + auto task = std::make_unique<BookmarkAppInstallationTask>( + profile(), std::move(app_info)); + SetTestingFactories(task.get(), app_url); + + task->InstallWebAppOrShortcutFromWebContents( + web_contents(), + base::BindOnce(&BookmarkAppInstallationTaskTest::OnInstallationTaskResult, + base::Unretained(this), base::DoNothing().Once())); + content::RunAllTasksUntilIdle(); + + test_helper().CompleteInstallation(); + + EXPECT_TRUE(app_installed()); + EXPECT_EQ(LAUNCH_TYPE_WINDOW, test_helper().forced_launch_type().value()); +} + +TEST_F(BookmarkAppInstallationTaskTest, + WebAppOrShortcutFromContents_ForcedContainerTab) { + const GURL app_url(kWebAppUrl); + + web_app::PendingAppManager::AppInfo app_info( + app_url, web_app::PendingAppManager::LaunchContainer::kTab); + auto task = std::make_unique<BookmarkAppInstallationTask>( + profile(), std::move(app_info)); + SetTestingFactories(task.get(), app_url); + + task->InstallWebAppOrShortcutFromWebContents( + web_contents(), + base::BindOnce(&BookmarkAppInstallationTaskTest::OnInstallationTaskResult, + base::Unretained(this), base::DoNothing().Once())); + content::RunAllTasksUntilIdle(); + + test_helper().CompleteInstallation(); + + EXPECT_TRUE(app_installed()); + EXPECT_EQ(LAUNCH_TYPE_REGULAR, test_helper().forced_launch_type().value()); +} + +TEST_F(BookmarkAppInstallationTaskTest, + WebAppOrShortcutFromContents_NoForcedContainer) { + const GURL app_url(kWebAppUrl); + + web_app::PendingAppManager::AppInfo app_info( + app_url, web_app::PendingAppManager::LaunchContainer::kDefault); + auto task = std::make_unique<BookmarkAppInstallationTask>( + profile(), std::move(app_info)); + SetTestingFactories(task.get(), app_url); + + task->InstallWebAppOrShortcutFromWebContents( + web_contents(), + base::BindOnce(&BookmarkAppInstallationTaskTest::OnInstallationTaskResult, + base::Unretained(this), base::DoNothing().Once())); + content::RunAllTasksUntilIdle(); + + test_helper().CompleteInstallation(); + + EXPECT_TRUE(app_installed()); + EXPECT_FALSE(test_helper().forced_launch_type().has_value()); +} + } // namespace extensions
diff --git a/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc b/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc index 90f7a0b..6d974c0 100644 --- a/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc +++ b/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc
@@ -26,13 +26,18 @@ ASSERT_TRUE(embedded_test_server()->Start()); base::RunLoop run_loop; std::string app_id; + web_app::PendingAppManager::AppInfo app_info( + embedded_test_server()->GetURL("/banners/manifest_test_page.html"), + web_app::PendingAppManager::LaunchContainer::kWindow); web_app::WebAppProvider::Get(browser()->profile()) ->pending_app_manager() .Install(web_app::PendingAppManager::AppInfo( embedded_test_server()->GetURL( "/banners/manifest_test_page.html"), - web_app::PendingAppManager::LaunchContainer::kWindow), + web_app::PendingAppManager::LaunchContainer::kWindow, + false /* create_shortcuts */), // Avoid creating real + // shortcuts in tests. base::BindLambdaForTesting( [&run_loop, &app_id](const GURL& provided_url, const std::string& id) {
diff --git a/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc b/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc index 97caa30..ba69c29 100644 --- a/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc +++ b/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
@@ -70,13 +70,21 @@ result_code = BookmarkAppInstallationTask::ResultCode::kSuccess; app_id = "fake_app_id_for:" + app_info().url.spec(); } + + std::move(on_install_called_).Run(); std::move(callback).Run( BookmarkAppInstallationTask::Result(result_code, app_id)); } + void SetOnInstallCalled(base::OnceClosure on_install_called) { + on_install_called_ = std::move(on_install_called); + } + private: bool succeeds_; + base::OnceClosure on_install_called_; + DISALLOW_COPY_AND_ASSIGN(TestBookmarkAppInstallationTask); }; @@ -114,18 +122,30 @@ return web_contents; } + std::unique_ptr<BookmarkAppInstallationTask> CreateInstallationTask( + Profile* profile, + web_app::PendingAppManager::AppInfo app_info, + bool succeeds) { + auto task = std::make_unique<TestBookmarkAppInstallationTask>( + profile, std::move(app_info), succeeds); + auto* task_ptr = task.get(); + task->SetOnInstallCalled(base::BindLambdaForTesting( + [task_ptr, this]() { last_app_info_ = task_ptr->app_info().Clone(); })); + return task; + } + std::unique_ptr<BookmarkAppInstallationTask> CreateSuccessfulInstallationTask( Profile* profile, web_app::PendingAppManager::AppInfo app_info) { - return std::make_unique<TestBookmarkAppInstallationTask>( - profile, std::move(app_info), true); + return CreateInstallationTask(profile, std::move(app_info), + true /* succeeds */); } std::unique_ptr<BookmarkAppInstallationTask> CreateFailingInstallationTask( Profile* profile, web_app::PendingAppManager::AppInfo app_info) { - return std::make_unique<TestBookmarkAppInstallationTask>( - profile, std::move(app_info), false); + return CreateInstallationTask(profile, std::move(app_info), + false /* succeeds */); } void InstallCallback(const GURL& url, const std::string& app_id) { @@ -137,6 +157,7 @@ void ResetResults() { install_succeeded_.reset(); install_callback_url_.reset(); + last_app_info_.reset(); } const PendingBookmarkAppManager::WebContentsFactory& @@ -175,10 +196,16 @@ const GURL& install_callback_url() { return install_callback_url_.value(); } + const web_app::PendingAppManager::AppInfo& last_app_info() { + CHECK(last_app_info_.get()); + return *last_app_info_; + } + private: content::WebContentsTester* web_contents_tester_ = nullptr; base::Optional<bool> install_succeeded_; base::Optional<GURL> install_callback_url_; + std::unique_ptr<web_app::PendingAppManager::AppInfo> last_app_info_; PendingBookmarkAppManager::WebContentsFactory test_web_contents_creator_; PendingBookmarkAppManager::TaskFactory successful_installation_task_creator_; @@ -198,6 +225,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); } @@ -212,6 +240,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); ResetResults(); @@ -224,6 +253,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -243,6 +273,8 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); + EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); ResetResults(); // Then the first call to Install gets processed. @@ -250,6 +282,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); } @@ -272,6 +305,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); ResetResults(); @@ -280,6 +314,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -310,6 +345,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -332,6 +368,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); ResetResults(); @@ -339,6 +376,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -364,6 +402,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); } @@ -394,6 +433,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); } @@ -431,6 +471,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); ResetResults(); @@ -439,6 +480,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -470,6 +512,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); ResetResults(); @@ -478,6 +521,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -505,6 +549,7 @@ SuccessfullyLoad(GURL(kQuxWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetQuxAppInfo(), last_app_info()); EXPECT_EQ(GURL(kQuxWebAppUrl), install_callback_url()); ResetResults(); @@ -513,6 +558,7 @@ SuccessfullyLoad(GURL(kFooWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); ResetResults(); @@ -520,6 +566,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -546,6 +593,7 @@ SuccessfullyLoad(GURL(kQuxWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetQuxAppInfo(), last_app_info()); EXPECT_EQ(GURL(kQuxWebAppUrl), install_callback_url()); ResetResults(); @@ -555,12 +603,14 @@ EXPECT_TRUE(install_succeeded()); EXPECT_EQ(GURL(kFooWebAppUrl), install_callback_url()); + EXPECT_EQ(GetFooAppInfo(), last_app_info()); ResetResults(); base::RunLoop().RunUntilIdle(); SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); } @@ -640,6 +690,7 @@ SuccessfullyLoad(GURL(kBarWebAppUrl)); EXPECT_FALSE(timer->IsRunning()); EXPECT_TRUE(install_succeeded()); + EXPECT_EQ(GetBarAppInfo(), last_app_info()); EXPECT_EQ(GURL(kBarWebAppUrl), install_callback_url()); }
diff --git a/chrome/installer/mini_installer/chrome.release b/chrome/installer/mini_installer/chrome.release index 419d98c..29da5235 100644 --- a/chrome/installer/mini_installer/chrome.release +++ b/chrome/installer/mini_installer/chrome.release
@@ -53,20 +53,12 @@ # %(VersionDir)\VisualElements. Logo.png: %(VersionDir)s\VisualElements\ LogoBeta.png: %(VersionDir)s\VisualElements\ -LogoBetaLight.png: %(VersionDir)s\VisualElements\ LogoCanary.png: %(VersionDir)s\VisualElements\ -LogoCanaryLight.png: %(VersionDir)s\VisualElements\ LogoDev.png: %(VersionDir)s\VisualElements\ -LogoDevLight.png: %(VersionDir)s\VisualElements\ -LogoLight.png: %(VersionDir)s\VisualElements\ SmallLogo.png: %(VersionDir)s\VisualElements\ SmallLogoBeta.png: %(VersionDir)s\VisualElements\ -SmallLogoBetaLight.png: %(VersionDir)s\VisualElements\ SmallLogoCanary.png: %(VersionDir)s\VisualElements\ -SmallLogoCanaryLight.png: %(VersionDir)s\VisualElements\ SmallLogoDev.png: %(VersionDir)s\VisualElements\ -SmallLogoDevLight.png: %(VersionDir)s\VisualElements\ -SmallLogoLight.png: %(VersionDir)s\VisualElements\ # # SwiftShader sub-dir
diff --git a/chrome/test/data/webui/settings/site_details_permission_tests.js b/chrome/test/data/webui/settings/site_details_permission_tests.js index 62cbaa1..8549b26 100644 --- a/chrome/test/data/webui/settings/site_details_permission_tests.js +++ b/chrome/test/data/webui/settings/site_details_permission_tests.js
@@ -167,7 +167,10 @@ source: testSource, }; assertEquals( - permissionSourcesNoSetting[testSource], + permissionSourcesNoSetting[testSource] + + (permissionSourcesNoSetting[testSource].length === 0 ? + 'Block (default)\nAllow\nBlock\nAsk' : + '\nBlock (default)\nAllow\nBlock\nAsk'), testElement.$.permissionItem.innerText.trim()); assertEquals( permissionSourcesNoSetting[testSource] != '', @@ -199,7 +202,8 @@ source: settings.SiteSettingSource.EXTENSION, }; assertEquals( - extensionSourceStrings[testSetting], + extensionSourceStrings[testSetting] + + '\nBlock (default)\nAllow\nBlock\nAsk', testElement.$.permissionItem.innerText.trim()); assertTrue(testElement.$.permissionItem.classList.contains('two-line')); assertTrue(testElement.$.permission.disabled); @@ -223,7 +227,8 @@ source: settings.SiteSettingSource.POLICY, }; assertEquals( - policySourceStrings[testSetting], + policySourceStrings[testSetting] + + '\nBlock (default)\nAllow\nBlock\nAsk', testElement.$.permissionItem.innerText.trim()); assertTrue(testElement.$.permissionItem.classList.contains('two-line')); assertTrue(testElement.$.permission.disabled); @@ -238,7 +243,9 @@ setting: settings.ContentSetting.ASK, source: settings.SiteSettingSource.DEFAULT, }; - assertEquals('', testElement.$.permissionItem.innerText.trim()); + assertEquals( + 'Ask (default)\nAllow\nBlock\nAsk', + testElement.$.permissionItem.innerText.trim()); assertFalse(testElement.$.permissionItem.classList.contains('two-line')); assertFalse(testElement.$.permission.disabled); }); @@ -254,7 +261,8 @@ source: settings.SiteSettingSource.DRM_DISABLED, }; assertEquals( - 'To change this setting, first turn on identifiers', + 'To change this setting, first turn on identifiers' + + '\nAllow\nBlock\nAsk', testElement.$.permissionItem.innerText.trim()); assertTrue(testElement.$.permissionItem.classList.contains('two-line')); assertTrue(testElement.$.permission.disabled); @@ -270,7 +278,8 @@ source: settings.SiteSettingSource.ADS_FILTER_BLACKLIST, }; assertEquals( - 'Site tends to show intrusive ads', + 'Site tends to show intrusive ads' + + '\nAllow\nBlock\nAsk', testElement.$.permissionItem.innerText.trim()); assertTrue(testElement.$.permissionItem.classList.contains('two-line')); assertFalse(testElement.$.permission.disabled); @@ -283,7 +292,8 @@ source: settings.SiteSettingSource.PREFERENCE, }; assertEquals( - 'Block if site tends to show intrusive ads', + 'Block if site tends to show intrusive ads' + + '\nAllow\nBlock\nAsk', testElement.$.permissionItem.innerText.trim()); assertTrue(testElement.$.permissionItem.classList.contains('two-line')); assertFalse(testElement.$.permission.disabled); @@ -296,7 +306,8 @@ source: settings.SiteSettingSource.DEFAULT, }; assertEquals( - 'Block if site tends to show intrusive ads', + 'Block if site tends to show intrusive ads' + + '\nBlock (default)\nAllow\nBlock\nAsk', testElement.$.permissionItem.innerText.trim()); assertTrue(testElement.$.permissionItem.classList.contains('two-line')); assertFalse(testElement.$.permission.disabled); @@ -308,7 +319,9 @@ setting: settings.ContentSetting.ALLOW, source: settings.SiteSettingSource.PREFERENCE, }; - assertEquals('', testElement.$.permissionItem.innerText.trim()); + assertEquals( + 'Block (default)\nAllow\nBlock\nAsk', + testElement.$.permissionItem.innerText.trim()); assertFalse(testElement.$.permissionItem.classList.contains('two-line')); assertFalse(testElement.$.permission.disabled); });
diff --git a/components/feature_engagement/public/event_constants.cc b/components/feature_engagement/public/event_constants.cc index b0e351a4..3700e12 100644 --- a/components/feature_engagement/public/event_constants.cc +++ b/components/feature_engagement/public/event_constants.cc
@@ -33,6 +33,7 @@ const char kIncognitoTabOpened[] = "incognito_tab_opened"; const char kClearedBrowsingData[] = "cleared_browsing_data"; const char kViewedReadingList[] = "viewed_reading_list"; +const char kBottomToolbarOpened[] = "bottom_toolbar_opened"; #endif // defined(OS_IOS) } // namespace events
diff --git a/components/feature_engagement/public/event_constants.h b/components/feature_engagement/public/event_constants.h index 1b95ad1..d45d76a 100644 --- a/components/feature_engagement/public/event_constants.h +++ b/components/feature_engagement/public/event_constants.h
@@ -64,6 +64,9 @@ // The user has viewed their reading list. extern const char kViewedReadingList[]; + +// The user has viewed the the BottomToolbar tip. +extern const char kBottomToolbarOpened[]; #endif // defined(OS_IOS) } // namespace events
diff --git a/components/invalidation/impl/fcm_network_handler.cc b/components/invalidation/impl/fcm_network_handler.cc index 53445d8..32e6eb3 100644 --- a/components/invalidation/impl/fcm_network_handler.cc +++ b/components/invalidation/impl/fcm_network_handler.cc
@@ -29,6 +29,9 @@ // Must match Java GoogleCloudMessaging.INSTANCE_ID_SCOPE. const char kGCMScope[] = "GCM"; +// Lower bound time between two token validations when listening. +const int kTokenValidationPeriodMinutesDefault = 60 * 24; + } // namespace FCMNetworkHandler::FCMNetworkHandler( @@ -36,6 +39,7 @@ instance_id::InstanceIDDriver* instance_id_driver) : gcm_driver_(gcm_driver), instance_id_driver_(instance_id_driver), + token_validation_timer_(std::make_unique<base::OneShotTimer>()), weak_ptr_factory_(this) {} FCMNetworkHandler::~FCMNetworkHandler() { @@ -43,26 +47,35 @@ } void FCMNetworkHandler::StartListening() { + // Adding ourselves as Handler means start listening. + // Being the listener is pre-requirement for token operations. + gcm_driver_->AddAppHandler(kInvalidationsAppId, this); + instance_id_driver_->GetInstanceID(kInvalidationsAppId) ->GetToken(kInvalidationGCMSenderId, kGCMScope, /*options=*/std::map<std::string, std::string>(), base::BindRepeating(&FCMNetworkHandler::DidRetrieveToken, weak_ptr_factory_.GetWeakPtr())); - - gcm_driver_->AddAppHandler(kInvalidationsAppId, this); } void FCMNetworkHandler::StopListening() { - if (gcm_driver_->GetAppHandler(kInvalidationsAppId)) + if (IsListening()) gcm_driver_->RemoveAppHandler(kInvalidationsAppId); } +bool FCMNetworkHandler::IsListening() const { + return gcm_driver_->GetAppHandler(kInvalidationsAppId); +} + void FCMNetworkHandler::DidRetrieveToken(const std::string& subscription_token, InstanceID::Result result) { switch (result) { case InstanceID::SUCCESS: + // The received token is assumed to be valid, therefore, we reschedule + // validation. DeliverToken(subscription_token); - return; + token_ = subscription_token; + break; case InstanceID::INVALID_PARAMETER: case InstanceID::DISABLED: case InstanceID::ASYNC_OPERATION_PENDING: @@ -74,6 +87,46 @@ UpdateGcmChannelState(false); break; } + ScheduleNextTokenValidation(); +} + +void FCMNetworkHandler::ScheduleNextTokenValidation() { + DCHECK(IsListening()); + + token_validation_timer_->Start( + FROM_HERE, + base::TimeDelta::FromMinutes(kTokenValidationPeriodMinutesDefault), + base::BindOnce(&FCMNetworkHandler::StartTokenValidation, + weak_ptr_factory_.GetWeakPtr())); +} + +void FCMNetworkHandler::StartTokenValidation() { + DCHECK(IsListening()); + + instance_id_driver_->GetInstanceID(kInvalidationsAppId) + ->GetToken(kInvalidationGCMSenderId, kGCMScope, + std::map<std::string, std::string>(), + base::Bind(&FCMNetworkHandler::DidReceiveTokenForValidation, + weak_ptr_factory_.GetWeakPtr())); +} + +void FCMNetworkHandler::DidReceiveTokenForValidation( + const std::string& new_token, + InstanceID::Result result) { + if (!IsListening()) { + // After we requested the token, |StopListening| has been called. Thus, + // ignore the token. + return; + } + + if (result == InstanceID::SUCCESS) { + if (token_ != new_token) { + token_ = new_token; + DeliverToken(new_token); + } + } + + ScheduleNextTokenValidation(); } void FCMNetworkHandler::UpdateGcmChannelState(bool online) { @@ -129,4 +182,9 @@ NOTREACHED() << "FCMNetworkHandler doesn't send GCM messages."; } +void FCMNetworkHandler::SetTokenValidationTimerForTesting( + std::unique_ptr<base::OneShotTimer> token_validation_timer) { + token_validation_timer_ = std::move(token_validation_timer); +} + } // namespace syncer
diff --git a/components/invalidation/impl/fcm_network_handler.h b/components/invalidation/impl/fcm_network_handler.h index 227a5485..ff2149f2 100644 --- a/components/invalidation/impl/fcm_network_handler.h +++ b/components/invalidation/impl/fcm_network_handler.h
@@ -6,9 +6,13 @@ #define COMPONENTS_INVALIDATION_IMPL_FCM_NETWORK_HANDLER_H_ #include "base/memory/weak_ptr.h" +#include "base/time/clock.h" +#include "base/timer/timer.h" #include "components/gcm_driver/gcm_app_handler.h" #include "components/gcm_driver/instance_id/instance_id.h" #include "components/invalidation/impl/fcm_sync_network_channel.h" +#include "components/prefs/pref_registry_simple.h" +#include "components/prefs/pref_service.h" namespace gcm { class GCMDriver; @@ -38,6 +42,7 @@ void StartListening(); void StopListening(); + bool IsListening() const; void UpdateGcmChannelState(bool); // GCMAppHandler overrides. @@ -51,16 +56,25 @@ void OnSendAcknowledged(const std::string& app_id, const std::string& message_id) override; + void SetTokenValidationTimerForTesting( + std::unique_ptr<base::OneShotTimer> token_validation_timer); + private: // Called when a subscription token is obtained from the GCM server. void DidRetrieveToken(const std::string& subscription_token, instance_id::InstanceID::Result result); + void ScheduleNextTokenValidation(); + void StartTokenValidation(); + void DidReceiveTokenForValidation(const std::string& new_token, + instance_id::InstanceID::Result result); gcm::GCMDriver* const gcm_driver_; instance_id::InstanceIDDriver* const instance_id_driver_; bool gcm_channel_online_ = false; + std::string token_; + std::unique_ptr<base::OneShotTimer> token_validation_timer_; base::WeakPtrFactory<FCMNetworkHandler> weak_ptr_factory_; DISALLOW_COPY_AND_ASSIGN(FCMNetworkHandler);
diff --git a/components/invalidation/impl/fcm_network_handler_unittests.cc b/components/invalidation/impl/fcm_network_handler_unittests.cc index 7a5f6917..84d80fa 100644 --- a/components/invalidation/impl/fcm_network_handler_unittests.cc +++ b/components/invalidation/impl/fcm_network_handler_unittests.cc
@@ -11,6 +11,7 @@ #include "base/files/file_path.h" #include "base/message_loop/message_loop.h" #include "base/test/mock_callback.h" +#include "base/test/test_mock_time_task_runner.h" #include "build/build_config.h" #include "components/gcm_driver/gcm_driver.h" #include "components/gcm_driver/instance_id/instance_id.h" @@ -18,6 +19,7 @@ #include "google_apis/gcm/engine/account_mapping.h" #include "testing/gmock/include/gmock/gmock.h" +using base::TestMockTimeTaskRunner; using gcm::InstanceIDHandler; using instance_id::InstanceID; using instance_id::InstanceIDDriver; @@ -31,6 +33,12 @@ const char kInvalidationsAppId[] = "com.google.chrome.fcm.invalidations"; using DataCallback = base::RepeatingCallback<void(const std::string& message)>; +base::Time GetDummyNow() { + base::Time out_time; + EXPECT_TRUE(base::Time::FromUTCString("2017-01-02T00:00:01Z", &out_time)); + return out_time; +} + class MockInstanceID : public InstanceID { public: MockInstanceID() : InstanceID("app_id", /*gcm_driver=*/nullptr) {} @@ -185,6 +193,19 @@ return mock_instance_id_.get(); } + scoped_refptr<TestMockTimeTaskRunner> CreateFakeTaskRunnerAndInjectToHandler( + std::unique_ptr<FCMNetworkHandler>& handler) { + scoped_refptr<TestMockTimeTaskRunner> task_runner( + new TestMockTimeTaskRunner(GetDummyNow(), base::TimeTicks::Now())); + + auto token_validation_timer = + std::make_unique<base::OneShotTimer>(task_runner->GetMockTickClock()); + token_validation_timer->SetTaskRunner(task_runner); + handler->SetTokenValidationTimerForTesting( + std::move(token_validation_timer)); + return task_runner; + } + private: base::MessageLoop message_loop_; std::unique_ptr<StrictMock<MockGCMDriver>> mock_gcm_driver_; @@ -251,4 +272,97 @@ handler->OnMessage(kInvalidationsAppId, gcm::IncomingMessage()); } +TEST_F(FCMNetworkHandlerTest, ShouldRequestTokenImmediatellyEvenIfSaved) { + // Setting up network handler. + MockOnDataCallback mock_on_token_callback; + auto handler = MakeHandler(); + auto task_runner = CreateFakeTaskRunnerAndInjectToHandler(handler); + handler->SetTokenReceiver(mock_on_token_callback.Get()); + + // Check that after StartListening we receive the token and store it. + EXPECT_CALL(*mock_instance_id(), GetToken(_, _, _, _)) + .WillOnce( + InvokeCallbackArgument<3>("token", InstanceID::Result::SUCCESS)); + EXPECT_CALL(mock_on_token_callback, Run("token")).Times(1); + handler->StartListening(); + handler->StopListening(); + task_runner->RunUntilIdle(); + + // Setting up another network handler. + auto handler2 = MakeHandler(); + auto task_runner2 = CreateFakeTaskRunnerAndInjectToHandler(handler2); + handler2->SetTokenReceiver(mock_on_token_callback.Get()); + + // Check that after StartListening the token will be requested, depite we have + // saved token. + EXPECT_CALL(*mock_instance_id(), GetToken(_, _, _, _)) + .WillOnce( + InvokeCallbackArgument<3>("token_new", InstanceID::Result::SUCCESS)); + EXPECT_CALL(mock_on_token_callback, Run("token_new")).Times(1); + handler->StartListening(); + task_runner->RunUntilIdle(); +} + +TEST_F(FCMNetworkHandlerTest, ShouldScheduleTokenValidationAndActOnNewToken) { + // Setting up network handler. + MockOnDataCallback mock_on_token_callback; + auto handler = MakeHandler(); + auto task_runner = CreateFakeTaskRunnerAndInjectToHandler(handler); + handler->SetTokenReceiver(mock_on_token_callback.Get()); + + // Checking that after start listening the token will be requested + // and passed to the appropriate token receiver. + EXPECT_CALL(*mock_instance_id(), GetToken(_, _, _, _)) + .WillOnce( + InvokeCallbackArgument<3>("token", InstanceID::Result::SUCCESS)); + EXPECT_CALL(*mock_instance_id(), ValidateToken(_, _, _, _)).Times(0); + EXPECT_CALL(mock_on_token_callback, Run("token")).Times(1); + handler->StartListening(); + testing::Mock::VerifyAndClearExpectations(mock_instance_id()); + + // Adjust timers and check that validation will happen in time. + // The old token was invalid, so token listener shold be informed. + const base::TimeDelta time_to_validation = base::TimeDelta::FromHours(24); + task_runner->FastForwardBy(time_to_validation - + base::TimeDelta::FromSeconds(1)); + // But when it is time, validation happens. + EXPECT_CALL(*mock_instance_id(), GetToken(_, _, _, _)) + .WillOnce( + InvokeCallbackArgument<3>("token_new", InstanceID::Result::SUCCESS)); + EXPECT_CALL(mock_on_token_callback, Run("token_new")).Times(1); + task_runner->FastForwardBy(base::TimeDelta::FromSeconds(1)); +} + +TEST_F(FCMNetworkHandlerTest, + ShouldScheduleTokenValidationAndDoNotActOnSameToken) { + // Setting up network handler. + MockOnDataCallback mock_on_token_callback; + std::unique_ptr<FCMNetworkHandler> handler = MakeHandler(); + auto task_runner = CreateFakeTaskRunnerAndInjectToHandler(handler); + handler->SetTokenReceiver(mock_on_token_callback.Get()); + + // Checking that after start listening the token will be requested + // and passed to the appropriate token receiver + EXPECT_CALL(*mock_instance_id(), GetToken(_, _, _, _)) + .WillOnce( + InvokeCallbackArgument<3>("token", InstanceID::Result::SUCCESS)); + EXPECT_CALL(*mock_instance_id(), ValidateToken(_, _, _, _)).Times(0); + EXPECT_CALL(mock_on_token_callback, Run("token")).Times(1); + handler->StartListening(); + testing::Mock::VerifyAndClearExpectations(mock_instance_id()); + + // Adjust timers and check that validation will happen in time. + // The old token is valid, so no token listener shold be informed. + const base::TimeDelta time_to_validation = base::TimeDelta::FromHours(24); + task_runner->FastForwardBy(time_to_validation - + base::TimeDelta::FromSeconds(1)); + + // But when it is time, validation happens. + EXPECT_CALL(*mock_instance_id(), GetToken(_, _, _, _)) + .WillOnce( + InvokeCallbackArgument<3>("token", InstanceID::Result::SUCCESS)); + EXPECT_CALL(mock_on_token_callback, Run(_)).Times(0); + task_runner->FastForwardBy(base::TimeDelta::FromSeconds(1)); +} + } // namespace syncer
diff --git a/components/os_crypt/BUILD.gn b/components/os_crypt/BUILD.gn index 1445076..cc335a1 100644 --- a/components/os_crypt/BUILD.gn +++ b/components/os_crypt/BUILD.gn
@@ -34,10 +34,14 @@ sources = [ "ie7_password_win.cc", "ie7_password_win.h", + "key_creation_util_mac.cc", + "key_creation_util_mac.h", "keychain_password_mac.h", "keychain_password_mac.mm", "os_crypt.h", "os_crypt_mac.mm", + "os_crypt_pref_names_mac.cc", + "os_crypt_pref_names_mac.h", "os_crypt_switches.cc", "os_crypt_switches.h", "os_crypt_win.cc", @@ -45,6 +49,7 @@ deps = [ "//base", + "//components/prefs", "//crypto", # TODO(tfarina): Remove this dep when http://crbug.com/363749 is fixed.
diff --git a/components/os_crypt/DEPS b/components/os_crypt/DEPS index db9f1644..30eb83d 100644 --- a/components/os_crypt/DEPS +++ b/components/os_crypt/DEPS
@@ -1,4 +1,5 @@ include_rules = [ + "+components/prefs", "+crypto", "+dbus", ]
diff --git a/components/os_crypt/key_creation_util_mac.cc b/components/os_crypt/key_creation_util_mac.cc new file mode 100644 index 0000000..7c6afbe --- /dev/null +++ b/components/os_crypt/key_creation_util_mac.cc
@@ -0,0 +1,35 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "components/os_crypt/key_creation_util_mac.h" + +#include "base/bind.h" +#include "base/single_thread_task_runner.h" +#include "components/os_crypt/os_crypt_pref_names_mac.h" +#include "components/prefs/pref_service.h" + +namespace os_crypt { + +KeyCreationUtilMac::KeyCreationUtilMac( + PrefService* local_state, + scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner) + : local_state_(local_state), + main_thread_task_runner_(main_thread_task_runner), + key_already_created_(local_state_->GetBoolean(prefs::kKeyCreated)) {} + +KeyCreationUtilMac::~KeyCreationUtilMac() = default; + +void KeyCreationUtilMac::OnKeyWasStored() { + if (key_already_created_) + return; + key_already_created_ = true; + main_thread_task_runner_->PostTask( + FROM_HERE, base::BindOnce( + [](PrefService* local_state) { + local_state->SetBoolean(prefs::kKeyCreated, true); + }, + local_state_)); +} + +} // namespace os_crypt
diff --git a/components/os_crypt/key_creation_util_mac.h b/components/os_crypt/key_creation_util_mac.h new file mode 100644 index 0000000..2b482895 --- /dev/null +++ b/components/os_crypt/key_creation_util_mac.h
@@ -0,0 +1,47 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef COMPONENTS_OS_CRYPT_KEY_CREATION_UTIL_MAC_H_ +#define COMPONENTS_OS_CRYPT_KEY_CREATION_UTIL_MAC_H_ + +#include "base/memory/scoped_refptr.h" + +class PrefService; + +namespace base { +class SingleThreadTaskRunner; +} // namespace base + +namespace os_crypt { + +// A utility class which provides a method to check whether the encryption key +// should be available in the Keychain (meaning it was created in the past). +class KeyCreationUtilMac { + public: + // This class has to be initialized on the main UI thread since it uses + // the local state. + KeyCreationUtilMac( + PrefService* local_state, + scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner); + ~KeyCreationUtilMac(); + + // This method doesn't need to be called on the main thread. + bool key_already_created() { return key_already_created_; } + + // This asynchronously updates the preference on the main thread that the key + // was created. This method is called when key is added to the Keychain, or + // the first time the key is successfully retrieved from the Keychain and the + // preference hasn't been set yet. This method doesn't need to be called on + // the main thread. + void OnKeyWasStored(); + + private: + PrefService* local_state_; + scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_; + volatile bool key_already_created_; +}; + +} // namespace os_crypt + +#endif // COMPONENTS_OS_CRYPT_KEY_CREATION_UTIL_MAC_H_
diff --git a/components/os_crypt/os_crypt_pref_names_mac.cc b/components/os_crypt/os_crypt_pref_names_mac.cc new file mode 100644 index 0000000..13f247d --- /dev/null +++ b/components/os_crypt/os_crypt_pref_names_mac.cc
@@ -0,0 +1,13 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "components/os_crypt/os_crypt_pref_names_mac.h" + +namespace os_crypt { +namespace prefs { + +const char kKeyCreated[] = "os_crypt.key_created"; + +} // namespace prefs +} // namespace os_crypt
diff --git a/components/os_crypt/os_crypt_pref_names_mac.h b/components/os_crypt/os_crypt_pref_names_mac.h new file mode 100644 index 0000000..e74fd985 --- /dev/null +++ b/components/os_crypt/os_crypt_pref_names_mac.h
@@ -0,0 +1,28 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef COMPONENTS_OS_CRYPT_OS_CRYPT_PREF_NAMES_MAC_H_ +#define COMPONENTS_OS_CRYPT_OS_CRYPT_PREF_NAMES_MAC_H_ + +#include "build/build_config.h" + +namespace os_crypt { +namespace prefs { + +// The boolean which indicates the existence of the encryption key in the +// Keychain. +// Sometimes when the Keychain seems to be available, it may happen that Chrome +// fails to retrieve the key from the Keychain, which causes Chrome to overwrite +// the old key with a newly generated key. Overwriting the encryption key can +// cause various problems, so there should be another mechanism to make sure +// that the key is not overwritten. This flag should be set to true once the +// encryption key is generated or successfully retrieved. If this flag is set to +// true and Chrome couldn't get the encryption key from the Keychain, encryption +// should be temporarily unavailable instead of generating a new key. +extern const char kKeyCreated[]; + +} // namespace prefs +} // namespace os_crypt + +#endif // COMPONENTS_OS_CRYPT_OS_CRYPT_PREF_NAMES_MAC_H_
diff --git a/components/policy/proto/device_management_backend.proto b/components/policy/proto/device_management_backend.proto index 0938f18..a17c701 100644 --- a/components/policy/proto/device_management_backend.proto +++ b/components/policy/proto/device_management_backend.proto
@@ -1740,6 +1740,17 @@ // push-installs. message AppInstallReportResponse {} +// Request from device to stop using a previously issued service account. +// The identity of a freshly-issued service account will be returned by a +// subsequent device policy fetch (see the |service_account_identity| field in +// |PolicyData| and auth codes tied to the new service account can be retrived +// by subsequent |DeviceServiceApiAccessRequest| requests. +message RefreshAccountRequest {} + +// Response from server after receiving a request to refresh the service +// account. +message RefreshAccountResponse {} + // Request from the DMAgent on the device to the DMServer. This is // container for all requests from device to server. The overall HTTP // request MUST be in the following format: @@ -1774,6 +1785,7 @@ // * register_browser // * policy_validation_report // * device_initial_enrollment_state +// * refresh_account // * devicetype: MUST BE "1" for Android, "2" for Chrome OS or "3" for Chrome // browser. // * apptype: MUST BE Android or Chrome. @@ -1790,7 +1802,8 @@ // * For unregister, policy, status, cert_upload, remote_commands, // gcm_id_update, active_directory_enroll_play_user, // active_directory_play_activity, active_directory_user_signin, -// policy_validation_report and chrome_desktop_report requests +// policy_validation_report, chrome_desktop_report +// and refresh_account requests // Authorization: GoogleDMToken token=<dm token from register> // // * The Authorization header isn't used for enterprise_check, @@ -1827,6 +1840,7 @@ // app_install_report: app_install_report_request // policy_validation_report: policy_validation_report_request // device_initial_enrollment_state: device_initial_enrollment_state_request +// refresh_account: refresh_account_request // message DeviceManagementRequest { reserved 24; // unused previous version of chrome_desktop_report_request. @@ -1916,6 +1930,9 @@ // Query for initial enrollment details. optional DeviceInitialEnrollmentStateRequest device_initial_enrollment_state_request = 28; + + // Request from device to wipe an old account and get a new account. + optional RefreshAccountRequest refresh_account_request = 29; } // Response from server to device. @@ -2052,4 +2069,7 @@ // Response to initial enrollment details query. optional DeviceInitialEnrollmentStateResponse device_initial_enrollment_state_response = 27; + + // Response to refresh account request. + optional RefreshAccountResponse refresh_account_response = 28; }
diff --git a/components/viz/service/display/software_renderer.cc b/components/viz/service/display/software_renderer.cc index 5476b52..5c41958 100644 --- a/components/viz/service/display/software_renderer.cc +++ b/components/viz/service/display/software_renderer.cc
@@ -54,8 +54,9 @@ ? cc::PaintImage::kDefaultFrameIndex : it->second; return ScopedDecodedDrawImage(cc::DecodedDrawImage( - paint_image.GetSkImageForFrame(frame_index), SkSize::Make(0, 0), - SkSize::Make(1.f, 1.f), draw_image.filter_quality(), + paint_image.GetSkImageForFrame( + frame_index, cc::PaintImage::kDefaultGeneratorClientId), + SkSize::Make(0, 0), SkSize::Make(1.f, 1.f), draw_image.filter_quality(), true /* is_budgeted */)); }
diff --git a/content/browser/background_fetch/background_fetch_service_unittest.cc b/content/browser/background_fetch/background_fetch_service_unittest.cc index a0ef218..7b26649 100644 --- a/content/browser/background_fetch/background_fetch_service_unittest.cc +++ b/content/browser/background_fetch/background_fetch_service_unittest.cc
@@ -54,8 +54,8 @@ return headers.cend() != std::find_if(headers.cbegin(), headers.cend(), [target](const auto& pair) -> bool { - return base::CompareCaseInsensitiveASCII(pair.first, - target) == 0; + return base::EqualsCaseInsensitiveASCII(pair.first, + target); }); }
diff --git a/content/browser/loader/prefetch_browsertest.cc b/content/browser/loader/prefetch_browsertest.cc index 0b6a19f8..9585653 100644 --- a/content/browser/loader/prefetch_browsertest.cc +++ b/content/browser/loader/prefetch_browsertest.cc
@@ -351,9 +351,9 @@ RegisterResponse( target_sxg, // We mock the SignedExchangeHandler, so just return a HTML content - // as "application/signed-exchange;v=b1". + // as "application/signed-exchange;v=b2". ResponseEntry("<head><title>Prefetch Target (SXG)</title></head>", - "application/signed-exchange;v=b1")); + "application/signed-exchange;v=b2")); RegisterResponse(preload_url_in_sxg, ResponseEntry("function foo() {}", "text/javascript")); @@ -388,7 +388,7 @@ EXPECT_TRUE(CheckPrefetchURLLoaderCountIfSupported(1)); if (base::FeatureList::IsEnabled(features::kSignedHTTPExchange)) EXPECT_EQ(prefetch_headers["Accept"], - "application/signed-exchange;v=b1;q=0.9,*/*;q=0.8"); + "application/signed-exchange;v=b2;q=0.9,*/*;q=0.8"); else EXPECT_EQ(prefetch_headers["Accept"], "*/*");
diff --git a/content/browser/service_worker/service_worker_new_script_loader.cc b/content/browser/service_worker/service_worker_new_script_loader.cc index 369f735..87cbc3d3 100644 --- a/content/browser/service_worker/service_worker_new_script_loader.cc +++ b/content/browser/service_worker/service_worker_new_script_loader.cc
@@ -316,8 +316,6 @@ void ServiceWorkerNewScriptLoader::OnComplete( const network::URLLoaderCompletionStatus& status) { - DCHECK(network_loader_state_ == NetworkLoaderState::kWaitingForBody || - network_loader_state_ == NetworkLoaderState::kLoadingBody); NetworkLoaderState previous_state = network_loader_state_; network_loader_state_ = NetworkLoaderState::kCompleted; if (status.error_code != net::OK) { @@ -325,6 +323,9 @@ return; } + DCHECK(previous_state == NetworkLoaderState::kWaitingForBody || + previous_state == NetworkLoaderState::kLoadingBody); + // Response body is empty. if (previous_state == NetworkLoaderState::kWaitingForBody) { DCHECK_EQ(WriterState::kNotStarted, body_writer_state_);
diff --git a/content/browser/service_worker/service_worker_script_cache_map.cc b/content/browser/service_worker/service_worker_script_cache_map.cc index c843ab3..09f44ad 100644 --- a/content/browser/service_worker/service_worker_script_cache_map.cc +++ b/content/browser/service_worker/service_worker_script_cache_map.cc
@@ -92,12 +92,18 @@ const GURL& url, const std::vector<uint8_t>& data, const net::CompletionCallback& callback) { + if (!context_) { + callback.Run(net::ERR_ABORTED); + return; + } + ResourceMap::iterator found = resource_map_.find(url); if (found == resource_map_.end() || found->second.resource_id == kInvalidServiceWorkerResourceId) { callback.Run(net::ERR_FILE_NOT_FOUND); return; } + scoped_refptr<net::IOBuffer> buffer(new net::IOBuffer(data.size())); if (data.size()) memmove(buffer->data(), &data[0], data.size());
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc index 9141797..5d82134 100644 --- a/content/browser/service_worker/service_worker_version.cc +++ b/content/browser/service_worker/service_worker_version.cc
@@ -520,25 +520,29 @@ << "Event of type " << static_cast<int>(event_type) << " can only be dispatched to an active worker: " << status(); - if (context_ && - event_type == ServiceWorkerMetrics::EventType::LONG_RUNNING_MESSAGE) { - context_->embedded_worker_registry()->AbortLifetimeTracking( - embedded_worker_->embedded_worker_id()); - } + // |context_| is needed for some bookkeeping. If there's no context, the + // request will be aborted soon, so don't bother aborting the request directly + // here, and just skip this bookkeeping. + if (context_) { + if (event_type == ServiceWorkerMetrics::EventType::LONG_RUNNING_MESSAGE) { + context_->embedded_worker_registry()->AbortLifetimeTracking( + embedded_worker_->embedded_worker_id()); + } - if (event_type != ServiceWorkerMetrics::EventType::INSTALL && - event_type != ServiceWorkerMetrics::EventType::ACTIVATE && - event_type != ServiceWorkerMetrics::EventType::MESSAGE) { - // Reset the self-update delay iff this is not an event that can triggered - // by a service worker itself. Otherwise, service workers can use update() - // to keep running forever via install and activate events, or postMessage() - // between themselves to reset the delay via message event. - // postMessage() resets the delay in ServiceWorkerObjectHost, iff it didn't - // come from a service worker. - ServiceWorkerRegistration* registration = - context_->GetLiveRegistration(registration_id_); - DCHECK(registration) << "running workers should have a live registration"; - registration->set_self_update_delay(base::TimeDelta()); + if (event_type != ServiceWorkerMetrics::EventType::INSTALL && + event_type != ServiceWorkerMetrics::EventType::ACTIVATE && + event_type != ServiceWorkerMetrics::EventType::MESSAGE) { + // Reset the self-update delay iff this is not an event that can triggered + // by a service worker itself. Otherwise, service workers can use update() + // to keep running forever via install and activate events, or + // postMessage() between themselves to reset the delay via message event. + // postMessage() resets the delay in ServiceWorkerObjectHost, iff it + // didn't come from a service worker. + ServiceWorkerRegistration* registration = + context_->GetLiveRegistration(registration_id_); + DCHECK(registration) << "running workers should have a live registration"; + registration->set_self_update_delay(base::TimeDelta()); + } } auto request = std::make_unique<InflightRequest>(
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h index 6b346dd..166f9093 100644 --- a/content/browser/service_worker/service_worker_version.h +++ b/content/browser/service_worker/service_worker_version.h
@@ -94,6 +94,7 @@ FORWARD_DECLARE_TEST(ServiceWorkerVersionTest, StaleUpdate_NonActiveWorker); FORWARD_DECLARE_TEST(ServiceWorkerVersionTest, StaleUpdate_RunningWorker); FORWARD_DECLARE_TEST(ServiceWorkerVersionTest, StaleUpdate_StartWorker); +FORWARD_DECLARE_TEST(ServiceWorkerVersionTest, StartRequestWithNullContext); } // namespace service_worker_version_unittest namespace service_worker_registration_unittest { @@ -552,6 +553,9 @@ service_worker_version_unittest::ServiceWorkerVersionTest, StaleUpdate_DoNotDeferTimer); FRIEND_TEST_ALL_PREFIXES( + service_worker_version_unittest::ServiceWorkerVersionTest, + StartRequestWithNullContext); + FRIEND_TEST_ALL_PREFIXES( service_worker_version_unittest::ServiceWorkerRequestTimeoutTest, RequestTimeout); FRIEND_TEST_ALL_PREFIXES(
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc index 5219078..fddd9d4 100644 --- a/content/browser/service_worker/service_worker_version_unittest.cc +++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -773,6 +773,15 @@ EXPECT_EQ(run_time, version_->update_timer_.desired_run_time()); } +TEST_F(ServiceWorkerVersionTest, StartRequestWithNullContext) { + StartWorker(version_.get(), ServiceWorkerMetrics::EventType::UNKNOWN); + version_->SetStatus(ServiceWorkerVersion::ACTIVATED); + version_->context_ = nullptr; + version_->StartRequest(ServiceWorkerMetrics::EventType::PUSH, + base::DoNothing()); + // Test passes if it doesn't crash. +} + // Tests the delay mechanism for self-updating service workers, to prevent // them from running forever (see https://crbug.com/805496). TEST_F(ServiceWorkerVersionTest, ResetUpdateDelay) {
diff --git a/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc b/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc index 286bfd9..104dbe14 100644 --- a/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc +++ b/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
@@ -212,7 +212,7 @@ base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>( &mock_loader_factory_), std::move(throttles_), url, request_initiator_, force_fetch, - SignedExchangeVersion::kB1, std::move(callback), + SignedExchangeVersion::kB2, std::move(callback), nullptr /* devtools_proxy */, base::nullopt /* throttling_profile_id */); }
diff --git a/content/browser/web_package/signed_exchange_certificate_chain.cc b/content/browser/web_package/signed_exchange_certificate_chain.cc index cb57be3f..c8e35ff3 100644 --- a/content/browser/web_package/signed_exchange_certificate_chain.cc +++ b/content/browser/web_package/signed_exchange_certificate_chain.cc
@@ -18,11 +18,11 @@ namespace { // https://wicg.github.io/webpackage/draft-yasskin-httpbis-origin-signed-exchanges-impl.html#cert-chain-format -std::unique_ptr<SignedExchangeCertificateChain> ParseB1( +std::unique_ptr<SignedExchangeCertificateChain> ParseB2( base::span<const uint8_t> message, SignedExchangeDevToolsProxy* devtools_proxy) { TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("loading"), - "SignedExchangeCertificateChain::ParseB1"); + "SignedExchangeCertificateChain::ParseB2"); cbor::CBORReader::DecoderError error; base::Optional<cbor::CBORValue> value = @@ -160,8 +160,8 @@ SignedExchangeVersion version, base::span<const uint8_t> cert_response_body, SignedExchangeDevToolsProxy* devtools_proxy) { - DCHECK_EQ(version, SignedExchangeVersion::kB1); - return ParseB1(cert_response_body, devtools_proxy); + DCHECK_EQ(version, SignedExchangeVersion::kB2); + return ParseB2(cert_response_body, devtools_proxy); } SignedExchangeCertificateChain::SignedExchangeCertificateChain(
diff --git a/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc b/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc index 8d718db..e6dc410 100644 --- a/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc +++ b/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc
@@ -9,7 +9,7 @@ namespace content { extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { - SignedExchangeCertificateChain::Parse(SignedExchangeVersion::kB1, + SignedExchangeCertificateChain::Parse(SignedExchangeVersion::kB2, base::make_span(data, size), nullptr); return 0; }
diff --git a/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc b/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc index 6389105..9914948 100644 --- a/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc +++ b/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
@@ -27,13 +27,13 @@ } // namespace -TEST(SignedExchangeCertificateParseB1Test, Empty) { +TEST(SignedExchangeCertificateParseB2Test, Empty) { auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::span<const uint8_t>(), nullptr); + SignedExchangeVersion::kB2, base::span<const uint8_t>(), nullptr); EXPECT_FALSE(parsed); } -TEST(SignedExchangeCertificateParseB1Test, EmptyChain) { +TEST(SignedExchangeCertificateParseB2Test, EmptyChain) { cbor::CBORValue::ArrayValue cbor_array; cbor_array.push_back(cbor::CBORValue(u8"\U0001F4DC\u26D3")); @@ -42,11 +42,11 @@ ASSERT_TRUE(serialized.has_value()); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::make_span(*serialized), nullptr); + SignedExchangeVersion::kB2, base::make_span(*serialized), nullptr); EXPECT_FALSE(parsed); } -TEST(SignedExchangeCertificateParseB1Test, MissingCert) { +TEST(SignedExchangeCertificateParseB2Test, MissingCert) { cbor::CBORValue::MapValue cbor_map; cbor_map[cbor::CBORValue("sct")] = CBORByteString("SCT"); cbor_map[cbor::CBORValue("ocsp")] = CBORByteString("OCSP"); @@ -60,11 +60,11 @@ ASSERT_TRUE(serialized.has_value()); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::make_span(*serialized), nullptr); + SignedExchangeVersion::kB2, base::make_span(*serialized), nullptr); EXPECT_FALSE(parsed); } -TEST(SignedExchangeCertificateParseB1Test, OneCert) { +TEST(SignedExchangeCertificateParseB2Test, OneCert) { net::CertificateList certs; ASSERT_TRUE( net::LoadCertificateFiles({"subjectAltName_sanity_check.pem"}, &certs)); @@ -86,7 +86,7 @@ ASSERT_TRUE(serialized.has_value()); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::make_span(*serialized), nullptr); + SignedExchangeVersion::kB2, base::make_span(*serialized), nullptr); ASSERT_TRUE(parsed); EXPECT_EQ(cert_der, net::x509_util::CryptoBufferAsStringPiece( parsed->cert()->cert_buffer())); @@ -95,7 +95,7 @@ EXPECT_EQ(parsed->sct(), base::make_optional<std::string>("SCT")); } -TEST(SignedExchangeCertificateParseB1Test, MissingOCSPInFirstCert) { +TEST(SignedExchangeCertificateParseB2Test, MissingOCSPInFirstCert) { net::CertificateList certs; ASSERT_TRUE( net::LoadCertificateFiles({"subjectAltName_sanity_check.pem"}, &certs)); @@ -116,11 +116,11 @@ ASSERT_TRUE(serialized.has_value()); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::make_span(*serialized), nullptr); + SignedExchangeVersion::kB2, base::make_span(*serialized), nullptr); EXPECT_FALSE(parsed); } -TEST(SignedExchangeCertificateParseB1Test, TwoCerts) { +TEST(SignedExchangeCertificateParseB2Test, TwoCerts) { net::CertificateList certs; ASSERT_TRUE(net::LoadCertificateFiles( {"subjectAltName_sanity_check.pem", "root_ca_cert.pem"}, &certs)); @@ -148,7 +148,7 @@ ASSERT_TRUE(serialized.has_value()); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::make_span(*serialized), nullptr); + SignedExchangeVersion::kB2, base::make_span(*serialized), nullptr); ASSERT_TRUE(parsed); EXPECT_EQ(cert1_der, net::x509_util::CryptoBufferAsStringPiece( parsed->cert()->cert_buffer())); @@ -159,7 +159,7 @@ EXPECT_EQ(parsed->sct(), base::make_optional<std::string>("SCT")); } -TEST(SignedExchangeCertificateParseB1Test, HavingOCSPInSecondCert) { +TEST(SignedExchangeCertificateParseB2Test, HavingOCSPInSecondCert) { net::CertificateList certs; ASSERT_TRUE(net::LoadCertificateFiles( {"subjectAltName_sanity_check.pem", "root_ca_cert.pem"}, &certs)); @@ -188,11 +188,11 @@ ASSERT_TRUE(serialized.has_value()); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::make_span(*serialized), nullptr); + SignedExchangeVersion::kB2, base::make_span(*serialized), nullptr); EXPECT_FALSE(parsed); } -TEST(SignedExchangeCertificateParseB1Test, ParseGoldenFile) { +TEST(SignedExchangeCertificateParseB2Test, ParseGoldenFile) { base::FilePath path; base::PathService::Get(content::DIR_TEST_DATA, &path); path = @@ -201,7 +201,7 @@ ASSERT_TRUE(base::ReadFileToString(path, &contents)); auto parsed = SignedExchangeCertificateChain::Parse( - SignedExchangeVersion::kB1, base::as_bytes(base::make_span(contents)), + SignedExchangeVersion::kB2, base::as_bytes(base::make_span(contents)), nullptr); ASSERT_TRUE(parsed); }
diff --git a/content/browser/web_package/signed_exchange_consts.h b/content/browser/web_package/signed_exchange_consts.h index 6e8bd521..4f18d33 100644 --- a/content/browser/web_package/signed_exchange_consts.h +++ b/content/browser/web_package/signed_exchange_consts.h
@@ -8,9 +8,9 @@ namespace content { constexpr char kAcceptHeaderSignedExchangeSuffix[] = - ",application/signed-exchange;v=b1"; + ",application/signed-exchange;v=b2"; -enum class SignedExchangeVersion { kB1 }; +enum class SignedExchangeVersion { kB2 }; // Field names defined in the application/signed-exchange content type: // https://wicg.github.io/webpackage/draft-yasskin-httpbis-origin-signed-exchanges-impl.html#application-signed-exchange
diff --git a/content/browser/web_package/signed_exchange_envelope.cc b/content/browser/web_package/signed_exchange_envelope.cc index b42ccc0..0325bba 100644 --- a/content/browser/web_package/signed_exchange_envelope.cc +++ b/content/browser/web_package/signed_exchange_envelope.cc
@@ -83,30 +83,6 @@ const cbor::CBORValue::MapValue& request_map = value.GetMap(); - auto url_iter = request_map.find( - cbor::CBORValue(kUrlKey, cbor::CBORValue::Type::BYTE_STRING)); - if (url_iter == request_map.end() || !url_iter->second.is_bytestring()) { - signed_exchange_utils::ReportErrorAndTraceEvent( - devtools_proxy, ":url is not found or not a bytestring."); - return false; - } - out->set_request_url(GURL(url_iter->second.GetBytestringAsString())); - if (!out->request_url().is_valid()) { - signed_exchange_utils::ReportErrorAndTraceEvent(devtools_proxy, - ":url is not a valid URL."); - return false; - } - if (out->request_url().has_ref()) { - signed_exchange_utils::ReportErrorAndTraceEvent( - devtools_proxy, ":url can't have a fragment."); - return false; - } - if (!out->request_url().SchemeIs("https")) { - signed_exchange_utils::ReportErrorAndTraceEvent( - devtools_proxy, ":url scheme must be 'https'."); - return false; - } - auto method_iter = request_map.find( cbor::CBORValue(kMethodKey, cbor::CBORValue::Type::BYTE_STRING)); if (method_iter == request_map.end() || @@ -137,7 +113,15 @@ return false; } base::StringPiece name_str = it.first.GetBytestringAsString(); - if (name_str == kUrlKey || name_str == kMethodKey) + + if (name_str == kUrlKey) { + signed_exchange_utils::ReportErrorAndTraceEvent( + devtools_proxy, + ":url key in request map is obsolete in this version of the format."); + return false; + } + + if (name_str == kMethodKey) continue; // TODO(kouhei): Add spec ref here once @@ -257,11 +241,15 @@ // static base::Optional<SignedExchangeEnvelope> SignedExchangeEnvelope::Parse( + const GURL& fallback_url, base::StringPiece signature_header_field, base::span<const uint8_t> cbor_header, SignedExchangeDevToolsProxy* devtools_proxy) { TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("loading"), "SignedExchangeEnvelope::Parse"); + + const GURL& request_url = fallback_url; + cbor::CBORReader::DecoderError error; base::Optional<cbor::CBORValue> value = cbor::CBORReader::Read(cbor_header, &error); @@ -293,6 +281,8 @@ } SignedExchangeEnvelope ret; + ret.set_cbor_header(cbor_header); + ret.set_request_url(request_url); if (!ParseRequestMap(top_level_array[0], &ret, devtools_proxy)) { signed_exchange_utils::ReportErrorAndTraceEvent( @@ -321,7 +311,6 @@ // If the signature’s “validity-url” parameter is not same-origin with // exchange’s effective request URI (Section 5.5 of [RFC7230]), return // “invalid” [spec text] - const GURL request_url = ret.request_url(); const GURL validity_url = ret.signature().validity_url; if (!url::IsSameOriginWith(request_url, validity_url)) { signed_exchange_utils::ReportErrorAndTraceEvent( @@ -371,4 +360,8 @@ net::HttpUtil::AssembleRawHeaders(header_str.c_str(), header_str.size())); } +void SignedExchangeEnvelope::set_cbor_header(base::span<const uint8_t> data) { + cbor_header_ = std::vector<uint8_t>(data.begin(), data.end()); +} + } // namespace content
diff --git a/content/browser/web_package/signed_exchange_envelope.h b/content/browser/web_package/signed_exchange_envelope.h index 7d86530..6903b8e 100644 --- a/content/browser/web_package/signed_exchange_envelope.h +++ b/content/browser/web_package/signed_exchange_envelope.h
@@ -30,12 +30,13 @@ public: using HeaderMap = std::map<std::string, std::string>; - // Parse headers from the application/signed-exchange;v=b0 format. + // Parse headers from the application/signed-exchange;v=b2 format. // https://wicg.github.io/webpackage/draft-yasskin-httpbis-origin-signed-exchanges-impl.html#application-signed-exchange // // This also performs the step 1, 3 and 4 of "Cross-origin trust" validation. // https://wicg.github.io/webpackage/draft-yasskin-httpbis-origin-signed-exchanges-impl.html#cross-origin-trust static base::Optional<SignedExchangeEnvelope> Parse( + const GURL& fallback_url, base::StringPiece signature_header_field, base::span<const uint8_t> cbor_header, SignedExchangeDevToolsProxy* devtools_proxy); @@ -50,6 +51,11 @@ bool AddResponseHeader(base::StringPiece name, base::StringPiece value); scoped_refptr<net::HttpResponseHeaders> BuildHttpResponseHeaders() const; + const base::span<const uint8_t> cbor_header() const { + return base::make_span(cbor_header_); + } + void set_cbor_header(base::span<const uint8_t> data); + const GURL& request_url() const { return request_url_; }; void set_request_url(GURL url) { request_url_ = std::move(url); } @@ -72,6 +78,8 @@ } private: + std::vector<uint8_t> cbor_header_; + GURL request_url_; std::string request_method_;
diff --git a/content/browser/web_package/signed_exchange_envelope_unittest.cc b/content/browser/web_package/signed_exchange_envelope_unittest.cc index 3b7dbe2..384efe7 100644 --- a/content/browser/web_package/signed_exchange_envelope_unittest.cc +++ b/content/browser/web_package/signed_exchange_envelope_unittest.cc
@@ -34,6 +34,7 @@ } base::Optional<SignedExchangeEnvelope> GenerateHeaderAndParse( + const GURL& fallback_url, base::StringPiece signature, const std::map<const char*, const char*>& request_map, const std::map<const char*, const char*>& response_map) { @@ -50,7 +51,8 @@ auto serialized = cbor::CBORWriter::Write(cbor::CBORValue(std::move(array))); return SignedExchangeEnvelope::Parse( - signature, base::make_span(serialized->data(), serialized->size()), + fallback_url, signature, + base::make_span(serialized->data(), serialized->size()), nullptr /* devtools_proxy */); } @@ -66,25 +68,38 @@ ASSERT_TRUE(base::ReadFileToString(test_sxg_path, &contents)); auto* contents_bytes = reinterpret_cast<const uint8_t*>(contents.data()); - ASSERT_GT(contents.size(), SignedExchangePrologue::kEncodedPrologueInBytes); - base::Optional<SignedExchangePrologue> prologue = - SignedExchangePrologue::Parse( - base::make_span(contents_bytes, - SignedExchangePrologue::kEncodedPrologueInBytes), + ASSERT_GT(contents.size(), + signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes); + signed_exchange_prologue::BeforeFallbackUrl prologue_a = + signed_exchange_prologue::BeforeFallbackUrl::Parse( + base::make_span( + contents_bytes, + signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes), nullptr /* devtools_proxy */); - ASSERT_TRUE(prologue.has_value()); - ASSERT_GT(contents.size(), SignedExchangePrologue::kEncodedPrologueInBytes + - prologue->ComputeFollowingSectionsLength()); + ASSERT_GT(contents.size(), + signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes + + prologue_a.ComputeFallbackUrlAndAfterLength()); + signed_exchange_prologue::FallbackUrlAndAfter prologue_b = + signed_exchange_prologue::FallbackUrlAndAfter::Parse( + base::make_span(contents_bytes + + signed_exchange_prologue::BeforeFallbackUrl:: + kEncodedSizeInBytes, + prologue_a.ComputeFallbackUrlAndAfterLength()), + prologue_a, nullptr /* devtools_proxy */); + size_t signature_header_field_offset = + signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes + + prologue_a.ComputeFallbackUrlAndAfterLength(); base::StringPiece signature_header_field( - contents.data() + SignedExchangePrologue::kEncodedPrologueInBytes, - prologue->signature_header_field_length()); + contents.data() + signature_header_field_offset, + prologue_b.signature_header_field_length()); const auto cbor_bytes = base::make_span<const uint8_t>( - contents_bytes + SignedExchangePrologue::kEncodedPrologueInBytes + - prologue->signature_header_field_length(), - prologue->cbor_header_length()); + contents_bytes + signature_header_field_offset + + prologue_b.signature_header_field_length(), + prologue_b.cbor_header_length()); const base::Optional<SignedExchangeEnvelope> envelope = - SignedExchangeEnvelope::Parse(signature_header_field, cbor_bytes, + SignedExchangeEnvelope::Parse(prologue_b.fallback_url(), + signature_header_field, cbor_bytes, nullptr /* devtools_proxy */); ASSERT_TRUE(envelope.has_value()); EXPECT_EQ(envelope->request_url(), GURL("https://test.example.org/test/")); @@ -97,9 +112,9 @@ TEST(SignedExchangeEnvelopeTest, ValidHeader) { auto header = GenerateHeaderAndParse( - kSignatureString, + GURL("https://test.example.org/test/"), kSignatureString, { - {kUrlKey, "https://test.example.org/test/"}, {kMethodKey, "GET"}, + {kMethodKey, "GET"}, }, {{kStatusKey, "200"}, {"content-type", "text/html"}}); ASSERT_TRUE(header.has_value()); @@ -110,84 +125,57 @@ } TEST(SignedExchangeEnvelopeTest, UnsafeMethod) { - auto header = GenerateHeaderAndParse( - kSignatureString, - { - {kUrlKey, "https://test.example.org/test/"}, {kMethodKey, "POST"}, - }, - { - {kStatusKey, "200"}, - }); - ASSERT_FALSE(header.has_value()); -} - -TEST(SignedExchangeEnvelopeTest, InvalidURL) { - auto header = GenerateHeaderAndParse( - kSignatureString, - { - {kUrlKey, "https:://test.example.org/test/"}, {kMethodKey, "GET"}, - }, - { - {kStatusKey, "200"}, - }); - ASSERT_FALSE(header.has_value()); -} - -TEST(SignedExchangeEnvelopeTest, URLWithFragment) { - auto header = GenerateHeaderAndParse( - kSignatureString, - { - {kUrlKey, "https://test.example.org/test/#foo"}, {kMethodKey, "GET"}, - }, - { - {kStatusKey, "200"}, - }); + auto header = GenerateHeaderAndParse(GURL("https://test.example.org/test/"), + kSignatureString, + { + {kMethodKey, "POST"}, + }, + { + {kStatusKey, "200"}, + }); ASSERT_FALSE(header.has_value()); } TEST(SignedExchangeEnvelopeTest, RelativeURL) { - auto header = - GenerateHeaderAndParse(kSignatureString, - { - {kUrlKey, "test/"}, {kMethodKey, "GET"}, - }, - { - {kStatusKey, "200"}, - }); + auto header = GenerateHeaderAndParse(GURL("test/"), kSignatureString, + { + {kMethodKey, "GET"}, + }, + { + {kStatusKey, "200"}, + }); ASSERT_FALSE(header.has_value()); } TEST(SignedExchangeEnvelopeTest, HttpURLShouldFail) { - auto header = GenerateHeaderAndParse( - kSignatureString, - { - {kUrlKey, "http://test.example.org/test/"}, {kMethodKey, "GET"}, - }, - { - {kStatusKey, "200"}, - }); + auto header = GenerateHeaderAndParse(GURL("http://test.example.org/test/"), + kSignatureString, + { + {kMethodKey, "GET"}, + }, + { + {kStatusKey, "200"}, + }); ASSERT_FALSE(header.has_value()); } TEST(SignedExchangeEnvelopeTest, StatefulRequestHeader) { - auto header = - GenerateHeaderAndParse(kSignatureString, - { - {kUrlKey, "https://test.example.org/test/"}, - {kMethodKey, "GET"}, - {"authorization", "Basic Zm9vOmJhcg=="}, - }, - { - {kStatusKey, "200"}, - }); + auto header = GenerateHeaderAndParse( + GURL("https://test.example.org/test/"), kSignatureString, + { + {kMethodKey, "GET"}, {"authorization", "Basic Zm9vOmJhcg=="}, + }, + { + {kStatusKey, "200"}, + }); ASSERT_FALSE(header.has_value()); } TEST(SignedExchangeEnvelopeTest, StatefulResponseHeader) { auto header = GenerateHeaderAndParse( - kSignatureString, + GURL("https://test.example.org/test/"), kSignatureString, { - {kUrlKey, "https://test.example.org/test/"}, {kMethodKey, "GET"}, + {kMethodKey, "GET"}, }, { {kStatusKey, "200"}, {"set-cookie", "foo=bar"}, @@ -196,22 +184,20 @@ } TEST(SignedExchangeEnvelopeTest, UppercaseRequestMap) { - auto header = - GenerateHeaderAndParse(kSignatureString, - {{kUrlKey, "https://test.example.org/test/"}, - {kMethodKey, "GET"}, - {"Accept-Language", "en-us"}}, - { - {kStatusKey, "200"}, - }); + auto header = GenerateHeaderAndParse( + GURL("https://test.example.org/test/"), kSignatureString, + {{kMethodKey, "GET"}, {"Accept-Language", "en-us"}}, + { + {kStatusKey, "200"}, + }); ASSERT_FALSE(header.has_value()); } TEST(SignedExchangeEnvelopeTest, UppercaseResponseMap) { auto header = GenerateHeaderAndParse( - kSignatureString, + GURL("https://test.example.org/test/"), kSignatureString, { - {kUrlKey, "https://test.example.org/test/"}, {kMethodKey, "GET"}, + {kMethodKey, "GET"}, }, {{kStatusKey, "200"}, {"Content-Length", "123"}}); ASSERT_FALSE(header.has_value()); @@ -219,9 +205,9 @@ TEST(SignedExchangeEnvelopeTest, InvalidValidityURLHeader) { auto header = GenerateHeaderAndParse( - kSignatureString, + GURL("https://test2.example.org/test/"), kSignatureString, { - {kUrlKey, "https://test2.example.org/test/"}, {kMethodKey, "GET"}, + {kMethodKey, "GET"}, }, {{kStatusKey, "200"}, {"content-type", "text/html"}}); ASSERT_FALSE(header.has_value());
diff --git a/content/browser/web_package/signed_exchange_handler.cc b/content/browser/web_package/signed_exchange_handler.cc index 4ea01c23..dc8ad2c9 100644 --- a/content/browser/web_package/signed_exchange_handler.cc +++ b/content/browser/web_package/signed_exchange_handler.cc
@@ -97,7 +97,7 @@ if (!SignedExchangeSignatureHeaderField::GetVersionParamFromContentType( content_type, &version_) || - version_ != SignedExchangeVersion::kB1) { + version_ != SignedExchangeVersion::kB2) { // TODO(https://crbug.com/874323): Extract and redirect to the fallback URL. base::SequencedTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::BindOnce(&SignedExchangeHandler::RunErrorCallback, @@ -107,14 +107,15 @@ devtools_proxy_.get(), base::StringPrintf("Unsupported version of the content type. Currentry " "content type must be " - "\"application/signed-exchange;v=b1\". But the " + "\"application/signed-exchange;v=b2\". But the " "response content type was \"%s\"", content_type.c_str())); return; } // Triggering the read (asynchronously) for the prologue bytes. - SetupBuffers(SignedExchangePrologue::kEncodedPrologueInBytes); + SetupBuffers( + signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes); base::SequencedTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::BindOnce(&SignedExchangeHandler::DoHeaderLoop, weak_factory_.GetWeakPtr())); @@ -132,7 +133,9 @@ } void SignedExchangeHandler::DoHeaderLoop() { - DCHECK(state_ == State::kReadingPrologue || state_ == State::kReadingHeaders); + DCHECK(state_ == State::kReadingPrologueBeforeFallbackUrl || + state_ == State::kReadingPrologueFallbackUrlAndAfter || + state_ == State::kReadingHeaders); int rv = source_->Read( header_read_buf_.get(), header_read_buf_->BytesRemaining(), base::BindRepeating(&SignedExchangeHandler::DidReadHeader, @@ -142,7 +145,9 @@ } void SignedExchangeHandler::DidReadHeader(bool completed_syncly, int result) { - DCHECK(state_ == State::kReadingPrologue || state_ == State::kReadingHeaders); + DCHECK(state_ == State::kReadingPrologueBeforeFallbackUrl || + state_ == State::kReadingPrologueFallbackUrlAndAfter || + state_ == State::kReadingHeaders); TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("loading"), "SignedExchangeHandler::DidReadHeader"); @@ -165,8 +170,14 @@ header_read_buf_->DidConsume(result); if (header_read_buf_->BytesRemaining() == 0) { switch (state_) { - case State::kReadingPrologue: - if (!ParsePrologue()) { + case State::kReadingPrologueBeforeFallbackUrl: + if (!ParsePrologueBeforeFallbackUrl()) { + RunErrorCallback(net::ERR_INVALID_SIGNED_EXCHANGE); + return; + } + break; + case State::kReadingPrologueFallbackUrlAndAfter: + if (!ParsePrologueFallbackUrlAndAfter()) { RunErrorCallback(net::ERR_INVALID_SIGNED_EXCHANGE); return; } @@ -187,7 +198,9 @@ return; // Trigger the next read. - DCHECK(state_ == State::kReadingPrologue || state_ == State::kReadingHeaders); + DCHECK(state_ == State::kReadingPrologueBeforeFallbackUrl || + state_ == State::kReadingPrologueFallbackUrlAndAfter || + state_ == State::kReadingHeaders); if (completed_syncly) { base::SequencedTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::BindOnce(&SignedExchangeHandler::DoHeaderLoop, @@ -197,18 +210,48 @@ } } -bool SignedExchangeHandler::ParsePrologue() { - DCHECK_EQ(state_, State::kReadingPrologue); +bool SignedExchangeHandler::ParsePrologueBeforeFallbackUrl() { + DCHECK_EQ(state_, State::kReadingPrologueBeforeFallbackUrl); - prologue_ = SignedExchangePrologue::Parse( - base::make_span(reinterpret_cast<uint8_t*>(header_buf_->data()), - SignedExchangePrologue::kEncodedPrologueInBytes), - devtools_proxy_.get()); - if (!prologue_) + prologue_before_fallback_url_ = + signed_exchange_prologue::BeforeFallbackUrl::Parse( + base::make_span( + reinterpret_cast<uint8_t*>(header_buf_->data()), + signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes), + devtools_proxy_.get()); + if (!prologue_before_fallback_url_.is_valid()) { + // TODO(crbug.com/874323): We should proceed anyway to extract fallback + // url for redirect. return false; + } - // Set up a new buffer for Signature + CBOR-encoded header reading. - SetupBuffers(prologue_->ComputeFollowingSectionsLength()); + // Set up a new buffer for reading + // |signed_exchange_prologue::FallbackUrlAndAfter|. + SetupBuffers( + prologue_before_fallback_url_.ComputeFallbackUrlAndAfterLength()); + state_ = State::kReadingPrologueFallbackUrlAndAfter; + return true; +} + +bool SignedExchangeHandler::ParsePrologueFallbackUrlAndAfter() { + DCHECK_EQ(state_, State::kReadingPrologueFallbackUrlAndAfter); + + prologue_fallback_url_and_after_ = + signed_exchange_prologue::FallbackUrlAndAfter::Parse( + base::make_span( + reinterpret_cast<uint8_t*>(header_buf_->data()), + prologue_before_fallback_url_.ComputeFallbackUrlAndAfterLength()), + prologue_before_fallback_url_, devtools_proxy_.get()); + if (!prologue_fallback_url_and_after_.is_valid()) { + // TODO(crbug.com/874323): Trigger fallback redirect if + // |prologue_fallback_url_and_after_.fallback_url().is_valid()|. + return false; + } + + // Set up a new buffer for reading the Signature header field and CBOR-encoded + // headers. + SetupBuffers( + prologue_fallback_url_and_after_.ComputeFollowingSectionsLength()); state_ = State::kReadingHeaders; return true; } @@ -218,14 +261,17 @@ "SignedExchangeHandler::ParseHeadersAndFetchCertificate"); DCHECK_EQ(state_, State::kReadingHeaders); + const GURL& fallback_url = prologue_fallback_url_and_after_.fallback_url(); + base::StringPiece data(header_buf_->data(), header_read_buf_->size()); - base::StringPiece signature_header_field = - data.substr(0, prologue_->signature_header_field_length()); - base::span<const uint8_t> cbor_header = base::as_bytes( - base::make_span(data.substr(prologue_->signature_header_field_length(), - prologue_->cbor_header_length()))); - envelope_ = SignedExchangeEnvelope::Parse(signature_header_field, cbor_header, - devtools_proxy_.get()); + base::StringPiece signature_header_field = data.substr( + 0, prologue_fallback_url_and_after_.signature_header_field_length()); + base::span<const uint8_t> cbor_header = + base::as_bytes(base::make_span(data.substr( + prologue_fallback_url_and_after_.signature_header_field_length(), + prologue_fallback_url_and_after_.cbor_header_length()))); + envelope_ = SignedExchangeEnvelope::Parse( + fallback_url, signature_header_field, cbor_header, devtools_proxy_.get()); header_read_buf_ = nullptr; header_buf_ = nullptr; if (!envelope_) {
diff --git a/content/browser/web_package/signed_exchange_handler.h b/content/browser/web_package/signed_exchange_handler.h index b2ded77..cb55297 100644 --- a/content/browser/web_package/signed_exchange_handler.h +++ b/content/browser/web_package/signed_exchange_handler.h
@@ -43,12 +43,16 @@ class SignedExchangeCertificateChain; class SignedExchangeDevToolsProxy; -// IMPORTANT: Currenly SignedExchangeHandler partially implements the verifying -// logic. -// TODO(https://crbug.com/803774): Implement verifying logic. +// SignedExchangeHandler reads "application/signed-exchange" format from a +// net::SourceStream, parse and verify the signed exchange, and report +// the result asynchronously via SignedExchangeHandler::ExchangeHeadersCallback. +// +// Note that verifying a signed exchange requires an associated certificate +// chain. SignedExchangeHandler creates a SignedExchangeCertFetcher to +// fetch the certificate chain over network, and verify it with the +// net::CertVerifier. class CONTENT_EXPORT SignedExchangeHandler { public: - // TODO(https://crbug.com/803774): Add verification status here. using ExchangeHeadersCallback = base::OnceCallback<void( net::Error error, const GURL& request_url, @@ -82,7 +86,8 @@ private: enum class State { - kReadingPrologue, + kReadingPrologueBeforeFallbackUrl, + kReadingPrologueFallbackUrlAndAfter, kReadingHeaders, kFetchingCertificate, kHeadersCallbackCalled, @@ -91,7 +96,8 @@ void SetupBuffers(size_t size); void DoHeaderLoop(); void DidReadHeader(bool completed_syncly, int result); - bool ParsePrologue(); + bool ParsePrologueBeforeFallbackUrl(); + bool ParsePrologueFallbackUrlAndAfter(); bool ParseHeadersAndFetchCertificate(); void RunErrorCallback(net::Error); @@ -106,12 +112,15 @@ base::Optional<SignedExchangeVersion> version_; std::unique_ptr<net::SourceStream> source_; - State state_ = State::kReadingPrologue; + State state_ = State::kReadingPrologueBeforeFallbackUrl; // Buffer used for prologue and envelope reading. scoped_refptr<net::IOBuffer> header_buf_; // Wrapper around |header_buf_| to progressively read fixed-size data. scoped_refptr<net::DrainableIOBuffer> header_read_buf_; - base::Optional<SignedExchangePrologue> prologue_; + + signed_exchange_prologue::BeforeFallbackUrl prologue_before_fallback_url_; + signed_exchange_prologue::FallbackUrlAndAfter + prologue_fallback_url_and_after_; base::Optional<SignedExchangeEnvelope> envelope_; std::unique_ptr<SignedExchangeCertFetcherFactory> cert_fetcher_factory_;
diff --git a/content/browser/web_package/signed_exchange_handler_unittest.cc b/content/browser/web_package/signed_exchange_handler_unittest.cc index 30d8e49..69dac75 100644 --- a/content/browser/web_package/signed_exchange_handler_unittest.cc +++ b/content/browser/web_package/signed_exchange_handler_unittest.cc
@@ -164,7 +164,7 @@ url::Origin::Create(GURL("https://sxg.example.com/test.sxg"))) {} virtual std::string ContentType() { - return "application/signed-exchange;v=b1"; + return "application/signed-exchange;v=b2"; } void SetUp() override { @@ -405,7 +405,7 @@ } TEST_P(SignedExchangeHandlerTest, HeaderParseError) { - const uint8_t data[] = {'s', 'x', 'g', '1', '-', 'b', '1', '\0', + const uint8_t data[] = {'s', 'x', 'g', '1', '-', 'b', '2', '\0', 0x00, 0x00, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00}; source_->AddReadResult(reinterpret_cast<const char*>(data), sizeof(data), net::OK, GetParam());
diff --git a/content/browser/web_package/signed_exchange_prologue.cc b/content/browser/web_package/signed_exchange_prologue.cc index 8f45dc93..c298b0b 100644 --- a/content/browser/web_package/signed_exchange_prologue.cc +++ b/content/browser/web_package/signed_exchange_prologue.cc
@@ -4,6 +4,7 @@ #include "content/browser/web_package/signed_exchange_prologue.h" +#include "base/strings/string_piece.h" #include "base/strings/stringprintf.h" #include "base/trace_event/trace_event.h" #include "content/browser/web_package/signed_exchange_utils.h" @@ -12,72 +13,170 @@ namespace { -constexpr char kSignedExchangeMagic[] = "sxg1-b1"; +constexpr char kSignedExchangeMagic[] = "sxg1-b2"; + +// size of `fallbackUrlLength` field in number of bytes. +constexpr size_t kFallbackUrlLengthFieldSizeInBytes = 2; +// size of `sigLength` field in number of bytes. +constexpr size_t kSigLengthFieldLengthInBytes = 3; +// size of `headerLength` field in number of bytes. +constexpr size_t kHeaderLengthFieldLengthInBytes = 3; + constexpr size_t kMaximumSignatureHeaderFieldLength = 16 * 1024; constexpr size_t kMaximumCBORHeaderLength = 512 * 1024; } // namespace -constexpr size_t SignedExchangePrologue::kEncodedLengthInBytes; -size_t SignedExchangePrologue::kEncodedPrologueInBytes = - sizeof(kSignedExchangeMagic) + - SignedExchangePrologue::kEncodedLengthInBytes * 2; +namespace signed_exchange_prologue { -// static -size_t SignedExchangePrologue::ParseEncodedLength( - base::span<const uint8_t> input) { - DCHECK_EQ(input.size(), SignedExchangePrologue::kEncodedLengthInBytes); +constexpr size_t BeforeFallbackUrl::kEncodedSizeInBytes = + sizeof(kSignedExchangeMagic) + kFallbackUrlLengthFieldSizeInBytes; + +size_t Parse2BytesEncodedLength(base::span<const uint8_t> input) { + DCHECK_EQ(input.size(), 2u); + return static_cast<size_t>(input[0]) << 8 | static_cast<size_t>(input[1]); +} + +size_t Parse3BytesEncodedLength(base::span<const uint8_t> input) { + DCHECK_EQ(input.size(), 3u); return static_cast<size_t>(input[0]) << 16 | static_cast<size_t>(input[1]) << 8 | static_cast<size_t>(input[2]); } // static -base::Optional<SignedExchangePrologue> SignedExchangePrologue::Parse( +BeforeFallbackUrl BeforeFallbackUrl::Parse( base::span<const uint8_t> input, SignedExchangeDevToolsProxy* devtools_proxy) { TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("loading"), - "SignedExchangePrologue::Parse"); + "signed_exchange_prologue::BeforeFallbackUrl::Parse"); - CHECK_EQ(input.size(), kEncodedPrologueInBytes); + CHECK_EQ(input.size(), kEncodedSizeInBytes); const auto magic_string = input.subspan(0, sizeof(kSignedExchangeMagic)); - const auto encoded_signature_header_field_length = - input.subspan(sizeof(kSignedExchangeMagic), kEncodedLengthInBytes); - const auto encoded_cbor_header_length = - input.subspan(sizeof(kSignedExchangeMagic) + kEncodedLengthInBytes, - kEncodedLengthInBytes); + const auto encoded_fallback_url_length_field = input.subspan( + sizeof(kSignedExchangeMagic), kFallbackUrlLengthFieldSizeInBytes); + bool is_valid = true; if (memcmp(magic_string.data(), kSignedExchangeMagic, sizeof(kSignedExchangeMagic)) != 0) { signed_exchange_utils::ReportErrorAndTraceEvent(devtools_proxy, "Wrong magic string"); - return base::nullopt; + is_valid = false; } + size_t fallback_url_length = + Parse2BytesEncodedLength(encoded_fallback_url_length_field); + return BeforeFallbackUrl(is_valid, fallback_url_length); +} + +size_t BeforeFallbackUrl::ComputeFallbackUrlAndAfterLength() const { + return fallback_url_length_ + kSigLengthFieldLengthInBytes + + kHeaderLengthFieldLengthInBytes; +} + +// static +FallbackUrlAndAfter FallbackUrlAndAfter::ParseFailedButFallbackUrlAvailable( + GURL fallback_url) { + return FallbackUrlAndAfter(/*is_valid=*/false, std::move(fallback_url), + /*signature_header_field_length=*/0, + /*cbor_header_length=*/0); +} + +// static +FallbackUrlAndAfter FallbackUrlAndAfter::Parse( + base::span<const uint8_t> input, + const BeforeFallbackUrl& before_fallback_url, + SignedExchangeDevToolsProxy* devtools_proxy) { + TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("loading"), + "signed_exchange_prologue::FallbackUrlAndAfter::Parse"); + + if (input.size() < before_fallback_url.fallback_url_length()) { + signed_exchange_utils::ReportErrorAndTraceEvent( + devtools_proxy, + "End of stream reached before reading the entire `fallbackUrl`."); + return FallbackUrlAndAfter(); + } + + base::StringPiece fallback_url_str( + reinterpret_cast<const char*>(input.data()), + before_fallback_url.fallback_url_length()); + GURL fallback_url(fallback_url_str); + + if (!fallback_url.is_valid()) { + signed_exchange_utils::ReportErrorAndTraceEvent( + devtools_proxy, "Failed to parse `fallbackUrl`."); + return FallbackUrlAndAfter(); + } + if (!fallback_url.SchemeIs(url::kHttpsScheme)) { + signed_exchange_utils::ReportErrorAndTraceEvent( + devtools_proxy, "`fallbackUrl` in non-https scheme."); + return FallbackUrlAndAfter(); + } + if (fallback_url.has_ref()) { + signed_exchange_utils::ReportErrorAndTraceEvent( + devtools_proxy, ":url can't have a fragment."); + return FallbackUrlAndAfter(); + } + + // Note: For the code path after this comment, if parsing failed but + // the `fallbackUrl` parse had succeed, the return value can still be + // used for fallback redirect. + + if (!before_fallback_url.is_valid()) + return ParseFailedButFallbackUrlAvailable(fallback_url); + + if (input.size() < before_fallback_url.ComputeFallbackUrlAndAfterLength()) { + signed_exchange_utils::ReportErrorAndTraceEvent( + devtools_proxy, + "End of stream reached before reading `sigLength` and `headerLength` " + "fields."); + return ParseFailedButFallbackUrlAvailable(fallback_url); + } + + const auto encoded_signature_header_field_length = input.subspan( + before_fallback_url.fallback_url_length(), kSigLengthFieldLengthInBytes); + const auto encoded_cbor_header_length = input.subspan( + before_fallback_url.fallback_url_length() + kSigLengthFieldLengthInBytes, + kHeaderLengthFieldLengthInBytes); + size_t signature_header_field_length = - ParseEncodedLength(encoded_signature_header_field_length); - size_t cbor_header_length = ParseEncodedLength(encoded_cbor_header_length); + Parse3BytesEncodedLength(encoded_signature_header_field_length); + size_t cbor_header_length = + Parse3BytesEncodedLength(encoded_cbor_header_length); if (signature_header_field_length > kMaximumSignatureHeaderFieldLength) { signed_exchange_utils::ReportErrorAndTraceEvent( devtools_proxy, base::StringPrintf("Signature header field too long: %zu", signature_header_field_length)); - return base::nullopt; + return ParseFailedButFallbackUrlAvailable(fallback_url); } if (cbor_header_length > kMaximumCBORHeaderLength) { signed_exchange_utils::ReportErrorAndTraceEvent( devtools_proxy, base::StringPrintf("CBOR header too long: %zu", cbor_header_length)); - return base::nullopt; + return ParseFailedButFallbackUrlAvailable(fallback_url); } - return SignedExchangePrologue(signature_header_field_length, - cbor_header_length); + return FallbackUrlAndAfter(true, fallback_url, signature_header_field_length, + cbor_header_length); } -size_t SignedExchangePrologue::ComputeFollowingSectionsLength() const { +size_t FallbackUrlAndAfter::signature_header_field_length() const { + DCHECK(is_valid()); + return signature_header_field_length_; +} + +size_t FallbackUrlAndAfter::cbor_header_length() const { + DCHECK(is_valid()); + return cbor_header_length_; +} + +size_t FallbackUrlAndAfter::ComputeFollowingSectionsLength() const { + DCHECK(is_valid()); return signature_header_field_length_ + cbor_header_length_; } +} // namespace signed_exchange_prologue + } // namespace content
diff --git a/content/browser/web_package/signed_exchange_prologue.h b/content/browser/web_package/signed_exchange_prologue.h index 2106d41..1414e71 100644 --- a/content/browser/web_package/signed_exchange_prologue.h +++ b/content/browser/web_package/signed_exchange_prologue.h
@@ -11,64 +11,129 @@ #include "base/gtest_prod_util.h" #include "base/optional.h" #include "content/common/content_export.h" +#include "url/gurl.h" namespace content { class SignedExchangeDevToolsProxy; -// SignedExchangePrologue maps to the first bytes of -// the "application/signed-exchange" format. -// SignedExchangePrologue derives the lengths of the variable-length sections -// following the prologue bytes. -class CONTENT_EXPORT SignedExchangePrologue { +// signed_exchange_prologue namespace contains parsers for the first bytes of +// the "application/signed-exchange" format, preceding the cbor-encoded +// response header. +namespace signed_exchange_prologue { + +// Parse 2-byte encoded length of the variable-length field in the signed +// exchange. Note: |input| must be pointing to a valid memory address that has +// at least 2 bytes. +CONTENT_EXPORT size_t Parse2BytesEncodedLength(base::span<const uint8_t> input); + +// Parse 3-byte encoded length of the variable-length field in the signed +// exchange. Note: |input| must be pointing to a valid memory address that has +// at least 3 bytes. +CONTENT_EXPORT size_t Parse3BytesEncodedLength(base::span<const uint8_t> input); + +// BeforeFallbackUrl holds the decoded data from the first +// |BeforeFallbackUrl::kEncodedSizeInBytes| bytes of the +// "application/signed-exchange" format. +class CONTENT_EXPORT BeforeFallbackUrl { public: - // Parse encoded length of the variable-length field in the signed exchange. - // Note: |input| must be pointing to a valid memory address that has at least - // |kEncodedLengthInBytes|. - static size_t ParseEncodedLength(base::span<const uint8_t> input); + // Size of the BeforeFallbackUrl part of "application/signed-exchange" + // prologue. + static const size_t kEncodedSizeInBytes; - // Size of the prologue bytes of the "application/signed-exchange" format - // which maps to this class. - static size_t kEncodedPrologueInBytes; + BeforeFallbackUrl() = default; + BeforeFallbackUrl(bool is_valid, size_t fallback_url_length) + : is_valid_(is_valid), fallback_url_length_(fallback_url_length) {} + BeforeFallbackUrl(const BeforeFallbackUrl&) = default; + ~BeforeFallbackUrl() = default; - // Parses the first bytes of the "application/signed-exchange" format. - // |input| must be a valid span with length of kEncodedPrologueInBytes. - // If success, returns the result. Otherwise, returns nullopt and - // reports the error to |devtools_proxy|. - static base::Optional<SignedExchangePrologue> Parse( - base::span<const uint8_t> input, - SignedExchangeDevToolsProxy* devtools_proxy); + // Parses the first |kEncodedSizeInBytes| bytes of the + // "application/signed-exchange" format. + // |input| must be a valid span with length of |kEncodedSizeInBytes|. + // If success, returns a |is_valid()| result. + // Otherwise, returns a |!is_valid()| result and report the error to + // |devtools_proxy|. + static BeforeFallbackUrl Parse(base::span<const uint8_t> input, + SignedExchangeDevToolsProxy* devtools_proxy); - SignedExchangePrologue(size_t signature_header_field_length, - size_t cbor_header_length) - : signature_header_field_length_(signature_header_field_length), - cbor_header_length_(cbor_header_length) {} - SignedExchangePrologue(const SignedExchangePrologue&) = default; - ~SignedExchangePrologue() = default; + size_t ComputeFallbackUrlAndAfterLength() const; - size_t signature_header_field_length() const { - return signature_header_field_length_; - } - size_t cbor_header_length() const { return cbor_header_length_; } + // |is_valid()| returns false if magic string was invalid. + bool is_valid() const { return is_valid_; } + + size_t fallback_url_length() const { return fallback_url_length_; } + + private: + bool is_valid_ = false; + + // Corresponds to `fallbackUrlLength` in the spec text. + // Encoded length of the Signature header field's value. + // https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#application-signed-exchange + size_t fallback_url_length_ = 0; +}; + +class CONTENT_EXPORT FallbackUrlAndAfter { + public: + FallbackUrlAndAfter() = default; + FallbackUrlAndAfter(const FallbackUrlAndAfter&) = default; + ~FallbackUrlAndAfter() = default; + + // Parses the bytes of the "application/signed-exchange" format, + // proceeding the BeforeFallbackUrl bytes. + // |input| must be a valid span with length of + // |before_fallback_url.ComputeFallbackUrlAndAfterLength()|. + // If success, returns a |is_valid()| result. + // Otherwise, returns a |!is_valid()| result and report the error to + // |devtools_proxy|. + static FallbackUrlAndAfter Parse(base::span<const uint8_t> input, + const BeforeFallbackUrl& before_fallback_url, + SignedExchangeDevToolsProxy* devtools_proxy); + + bool is_valid() const { return is_valid_; } + + // Note: fallback_url() may still be called even if |!is_valid()|, + // for trigering fallback redirect. + const GURL& fallback_url() const { return fallback_url_; } + + size_t signature_header_field_length() const; + size_t cbor_header_length() const; size_t ComputeFollowingSectionsLength() const; private: - FRIEND_TEST_ALL_PREFIXES(SignedExchangePrologueTest, ParseEncodedLength); + static FallbackUrlAndAfter ParseFailedButFallbackUrlAvailable( + GURL fallback_url); - static constexpr size_t kEncodedLengthInBytes = 3; + FallbackUrlAndAfter(bool is_valid, + GURL fallback_url, + size_t signature_header_field_length, + size_t cbor_header_length) + : is_valid_(is_valid), + fallback_url_(std::move(fallback_url)), + signature_header_field_length_(signature_header_field_length), + cbor_header_length_(cbor_header_length) {} + + bool is_valid_ = false; + + // Corresponds to `fallbackUrl` in the spec text. + // The URL to redirect navigation to when the signed exchange processing steps + // has failed. + // https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#application-signed-exchange + GURL fallback_url_; // Corresponds to `sigLength` in the spec text. // Encoded length of the Signature header field's value. // https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#application-signed-exchange - size_t signature_header_field_length_; + size_t signature_header_field_length_ = 0; // Corresponds to `headerLength` in the spec text. // Length of the CBOR representation of the request and response headers. // https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#application-signed-exchange - size_t cbor_header_length_; + size_t cbor_header_length_ = 0; }; +} // namespace signed_exchange_prologue + } // namespace content #endif // CONTENT_BROWSER_WEB_PACKAGE_SIGNED_EXCHANGE_PROLOGUE_H_
diff --git a/content/browser/web_package/signed_exchange_prologue_unittest.cc b/content/browser/web_package/signed_exchange_prologue_unittest.cc index befb942e0..03febae 100644 --- a/content/browser/web_package/signed_exchange_prologue_unittest.cc +++ b/content/browser/web_package/signed_exchange_prologue_unittest.cc
@@ -7,10 +7,26 @@ #include "testing/gtest/include/gtest/gtest.h" namespace content { +namespace signed_exchange_prologue { -TEST(SignedExchangePrologueTest, ParseEncodedLength) { +TEST(SignedExchangePrologueTest, Parse2BytesEncodedLength) { constexpr struct { - uint8_t bytes[SignedExchangePrologue::kEncodedLengthInBytes]; + uint8_t bytes[2]; + size_t expected; + } kTestCases[] = { + {{0x00, 0x01}, 1u}, {{0xab, 0xcd}, 43981u}, + }; + + int test_element_index = 0; + for (const auto& test_case : kTestCases) { + SCOPED_TRACE(testing::Message() << "testing case " << test_element_index++); + EXPECT_EQ(Parse2BytesEncodedLength(test_case.bytes), test_case.expected); + } +} + +TEST(SignedExchangePrologueTest, Parse3BytesEncodedLength) { + constexpr struct { + uint8_t bytes[3]; size_t expected; } kTestCases[] = { {{0x00, 0x00, 0x01}, 1u}, {{0x01, 0xe2, 0x40}, 123456u}, @@ -19,45 +35,109 @@ int test_element_index = 0; for (const auto& test_case : kTestCases) { SCOPED_TRACE(testing::Message() << "testing case " << test_element_index++); - EXPECT_EQ(SignedExchangePrologue::ParseEncodedLength(test_case.bytes), - test_case.expected); + EXPECT_EQ(Parse3BytesEncodedLength(test_case.bytes), test_case.expected); } } -TEST(SignedExchangePrologueTest, Simple) { - uint8_t bytes[] = {'s', 'x', 'g', '1', '-', 'b', '1', - '\0', 0x00, 0x12, 0x34, 0x00, 0x23, 0x45}; +TEST(SignedExchangePrologueTest, BeforeFallbackUrl_Success) { + uint8_t bytes[] = {'s', 'x', 'g', '1', '-', 'b', '2', '\0', 0x12, 0x34}; - auto prologue = SignedExchangePrologue::Parse(base::make_span(bytes), - nullptr /* devtools_proxy */); - EXPECT_TRUE(prologue); - EXPECT_EQ(0x1234u, prologue->signature_header_field_length()); - EXPECT_EQ(0x2345u, prologue->cbor_header_length()); - EXPECT_EQ(0x3579u, prologue->ComputeFollowingSectionsLength()); + BeforeFallbackUrl before_fallback_url = BeforeFallbackUrl::Parse( + base::make_span(bytes), nullptr /* devtools_proxy */); + EXPECT_TRUE(before_fallback_url.is_valid()); + EXPECT_EQ(0x1234u, before_fallback_url.fallback_url_length()); } -TEST(SignedExchangePrologueTest, WrongMagic) { - uint8_t bytes[] = {'s', 'x', 'g', '!', '-', 'b', '1', - '\0', 0x00, 0x12, 0x34, 0x00, 0x23, 0x45}; +TEST(SignedExchangePrologueTest, BeforeFallbackUrl_WrongMagic) { + uint8_t bytes[] = {'s', 'x', 'g', '!', '-', 'b', '2', '\0', 0x12, 0x34}; - EXPECT_FALSE(SignedExchangePrologue::Parse(base::make_span(bytes), - nullptr /* devtools_proxy */)); + BeforeFallbackUrl before_fallback_url = BeforeFallbackUrl::Parse( + base::make_span(bytes), nullptr /* devtools_proxy */); + EXPECT_FALSE(before_fallback_url.is_valid()); + EXPECT_EQ(0x1234u, before_fallback_url.fallback_url_length()); } -TEST(SignedExchangePrologueTest, LongSignatureHeaderField) { - uint8_t bytes[] = {'s', 'x', 'g', '1', '-', 'b', '1', - '\0', 0xff, 0x12, 0x34, 0x00, 0x23, 0x45}; +TEST(SignedExchangePrologueTest, FallbackUrlAndAfter_Success) { + uint8_t bytes[] = {'h', 't', 't', 'p', 's', ':', '/', '/', 'e', + 'x', 'a', 'm', 'p', 'l', 'e', '.', 'c', 'o', + 'm', '/', 0x00, 0x12, 0x34, 0x00, 0x23, 0x45}; - EXPECT_FALSE(SignedExchangePrologue::Parse(base::make_span(bytes), - nullptr /* devtools_proxy */)); + BeforeFallbackUrl before_fallback_url(true, + sizeof("https://example.com/") - 1); + EXPECT_TRUE(before_fallback_url.is_valid()); + + FallbackUrlAndAfter fallback_url_and_after = + FallbackUrlAndAfter::Parse(base::make_span(bytes), before_fallback_url, + nullptr /* devtools_proxy */); + + EXPECT_TRUE(fallback_url_and_after.is_valid()); + EXPECT_EQ("https://example.com/", + fallback_url_and_after.fallback_url().spec()); + EXPECT_EQ(0x1234u, fallback_url_and_after.signature_header_field_length()); + EXPECT_EQ(0x2345u, fallback_url_and_after.cbor_header_length()); } -TEST(SignedExchangePrologueTest, LongCBORHeader) { - uint8_t bytes[] = {'s', 'x', 'g', '1', '-', 'b', '1', - '\0', 0x00, 0x12, 0x34, 0xff, 0x23, 0x45}; +TEST(SignedExchangePrologueTest, FallbackUrlAndAfter_NonHttpsUrl) { + uint8_t bytes[] = {'h', 't', 't', 'p', ':', '/', '/', 'e', 'x', + 'a', 'm', 'p', 'l', 'e', '.', 'c', 'o', 'm', + '/', 0x00, 0x12, 0x34, 0x00, 0x23, 0x45}; - EXPECT_FALSE(SignedExchangePrologue::Parse(base::make_span(bytes), - nullptr /* devtools_proxy */)); + BeforeFallbackUrl before_fallback_url(true, + sizeof("http://example.com/") - 1); + FallbackUrlAndAfter fallback_url_and_after = + FallbackUrlAndAfter::Parse(base::make_span(bytes), before_fallback_url, + nullptr /* devtools_proxy */); + + EXPECT_FALSE(fallback_url_and_after.is_valid()); + EXPECT_FALSE(fallback_url_and_after.fallback_url().is_valid()); } +TEST(SignedExchangePrologueTest, FallbackUrlAndAfter_UrlWithFragment) { + uint8_t bytes[] = {'h', 't', 't', 'p', 's', ':', '/', '/', 'e', 'x', + 'a', 'm', 'p', 'l', 'e', '.', 'c', 'o', 'm', '/', + '#', 'f', 'o', 'o', 0x00, 0x12, 0x34, 0x00, 0x23, 0x45}; + + BeforeFallbackUrl before_fallback_url(true, + sizeof("https://example.com/#foo") - 1); + FallbackUrlAndAfter fallback_url_and_after = + FallbackUrlAndAfter::Parse(base::make_span(bytes), before_fallback_url, + nullptr /* devtools_proxy */); + + EXPECT_FALSE(fallback_url_and_after.is_valid()); + EXPECT_FALSE(fallback_url_and_after.fallback_url().is_valid()); +} + +TEST(SignedExchangePrologueTest, FallbackUrlAndAfter_LongSignatureHeader) { + uint8_t bytes[] = {'h', 't', 't', 'p', 's', ':', '/', '/', 'e', + 'x', 'a', 'm', 'p', 'l', 'e', '.', 'c', 'o', + 'm', '/', 0xff, 0x12, 0x34, 0x00, 0x23, 0x45}; + + BeforeFallbackUrl before_fallback_url(true, + sizeof("https://example.com/") - 1); + FallbackUrlAndAfter fallback_url_and_after = + FallbackUrlAndAfter::Parse(base::make_span(bytes), before_fallback_url, + nullptr /* devtools_proxy */); + + EXPECT_FALSE(fallback_url_and_after.is_valid()); + EXPECT_EQ("https://example.com/", + fallback_url_and_after.fallback_url().spec()); +} + +TEST(SignedExchangePrologueTest, FallbackUrlAndAfter_LongCBORHeader) { + uint8_t bytes[] = {'h', 't', 't', 'p', 's', ':', '/', '/', 'e', + 'x', 'a', 'm', 'p', 'l', 'e', '.', 'c', 'o', + 'm', '/', 0x00, 0x12, 0x34, 0xff, 0x23, 0x45}; + + BeforeFallbackUrl before_fallback_url(true, + sizeof("https://example.com/") - 1); + FallbackUrlAndAfter fallback_url_and_after = + FallbackUrlAndAfter::Parse(base::make_span(bytes), before_fallback_url, + nullptr /* devtools_proxy */); + + EXPECT_FALSE(fallback_url_and_after.is_valid()); + EXPECT_EQ("https://example.com/", + fallback_url_and_after.fallback_url().spec()); +} + +} // namespace signed_exchange_prologue } // namespace content
diff --git a/content/browser/web_package/signed_exchange_request_handler_browsertest.cc b/content/browser/web_package/signed_exchange_request_handler_browsertest.cc index ae29bbd..09734e5 100644 --- a/content/browser/web_package/signed_exchange_request_handler_browsertest.cc +++ b/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
@@ -191,7 +191,7 @@ if (request.relative_url == "/sxg/test.example.org_test.sxg") { const auto& accept_value = request.headers.find("accept")->second; EXPECT_THAT(accept_value, - ::testing::HasSubstr("application/signed-exchange;v=b1")); + ::testing::HasSubstr("application/signed-exchange;v=b2")); } })); embedded_test_server()->ServeFilesFromSourceDirectory("content/test/data"); @@ -315,7 +315,7 @@ if (request.relative_url == "/sxg/test.example.org_test.sxg") { const auto& accept_value = request.headers.find("accept")->second; EXPECT_THAT(accept_value, - ::testing::HasSubstr("application/signed-exchange;v=b1")); + ::testing::HasSubstr("application/signed-exchange;v=b2")); } })); embedded_test_server()->ServeFilesFromSourceDirectory("content/test/data");
diff --git a/content/browser/web_package/signed_exchange_signature_header_field.cc b/content/browser/web_package/signed_exchange_signature_header_field.cc index b7bcef2..f6e3cfd 100644 --- a/content/browser/web_package/signed_exchange_signature_header_field.cc +++ b/content/browser/web_package/signed_exchange_signature_header_field.cc
@@ -294,8 +294,8 @@ if (it == parameterised_identifier.params.end()) { *version_param = base::nullopt; } else { - if (it->second == "b1") - *version_param = SignedExchangeVersion::kB1; + if (it->second == "b2") + *version_param = SignedExchangeVersion::kB2; else return false; }
diff --git a/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc b/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc index d476551..e34fd13 100644 --- a/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc +++ b/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
@@ -300,34 +300,34 @@ } TEST_F(SignedExchangeSignatureHeaderFieldTest, VersionParam_Simple) { - const char content_type[] = "application/signed-exchange;v=b1"; + const char content_type[] = "application/signed-exchange;v=b2"; base::Optional<SignedExchangeVersion> version; EXPECT_TRUE( SignedExchangeSignatureHeaderField::GetVersionParamFromContentType( content_type, &version)); ASSERT_TRUE(version); - EXPECT_EQ(*version, SignedExchangeVersion::kB1); + EXPECT_EQ(*version, SignedExchangeVersion::kB2); } TEST_F(SignedExchangeSignatureHeaderFieldTest, VersionParam_SimpleWithSpace) { - const char content_type[] = "application/signed-exchange; v=b1"; + const char content_type[] = "application/signed-exchange; v=b2"; base::Optional<SignedExchangeVersion> version; EXPECT_TRUE( SignedExchangeSignatureHeaderField::GetVersionParamFromContentType( content_type, &version)); ASSERT_TRUE(version); - EXPECT_EQ(*version, SignedExchangeVersion::kB1); + EXPECT_EQ(*version, SignedExchangeVersion::kB2); } TEST_F(SignedExchangeSignatureHeaderFieldTest, VersionParam_SimpleWithDoublequotes) { - const char content_type[] = "application/signed-exchange;v=\"b1\""; + const char content_type[] = "application/signed-exchange;v=\"b2\""; base::Optional<SignedExchangeVersion> version; EXPECT_TRUE( SignedExchangeSignatureHeaderField::GetVersionParamFromContentType( content_type, &version)); ASSERT_TRUE(version); - EXPECT_EQ(*version, SignedExchangeVersion::kB1); + EXPECT_EQ(*version, SignedExchangeVersion::kB2); } } // namespace content
diff --git a/content/browser/web_package/signed_exchange_signature_verifier.cc b/content/browser/web_package/signed_exchange_signature_verifier.cc index 3a7cdf72..f19306b 100644 --- a/content/browser/web_package/signed_exchange_signature_verifier.cc +++ b/content/browser/web_package/signed_exchange_signature_verifier.cc
@@ -4,6 +4,7 @@ #include "content/browser/web_package/signed_exchange_signature_verifier.h" +#include "base/big_endian.h" #include "base/containers/span.h" #include "base/format_macros.h" #include "base/strings/string_number_conversions.h" @@ -30,20 +31,20 @@ namespace { // https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#signature-validity -// Step 7. "Let message be the concatenation of the following byte strings." +// Step 5. "Let message be the concatenation of the following byte strings." constexpr uint8_t kMessageHeader[] = - // 7.1. "A string that consists of octet 32 (0x20) repeated 64 times." + // 5.1. "A string that consists of octet 32 (0x20) repeated 64 times." // [spec text] "\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20" "\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20" "\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20" "\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20" - // 7.2. "A context string: the ASCII encoding of "HTTP Exchange 1"." ... + // 5.2. "A context string: the ASCII encoding of "HTTP Exchange 1"." ... // "but implementations of drafts MUST NOT use it and MUST use another // draft-specific string beginning with "HTTP Exchange 1 " instead." // [spec text] - // 7.3. "A single 0 byte which serves as a separator." [spec text] - "HTTP Exchange 1 b1"; + // 5.3. "A single 0 byte which serves as a separator." [spec text] + "HTTP Exchange 1 b2"; base::Optional<cbor::CBORValue> GenerateCanonicalRequestCBOR( const SignedExchangeEnvelope& envelope) { @@ -94,56 +95,6 @@ return cbor::CBORValue(array); } -// Generate a CBOR map value as specified in -// https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#signature-validity -// Step 7.4. -base::Optional<cbor::CBORValue> GenerateSignedMessageCBOR( - const SignedExchangeEnvelope& envelope) { - auto headers_val = GenerateCanonicalExchangeHeadersCBOR(envelope); - if (!headers_val) - return base::nullopt; - - // 7.4. "The bytes of the canonical CBOR serialization (Section 3.4) of - // a CBOR map mapping:" [spec text] - cbor::CBORValue::MapValue map; - // 7.4.1. "If cert-sha256 is set: The text string "cert-sha256" to the byte - // string value of cert-sha256." [spec text] - if (envelope.signature().cert_sha256.has_value()) { - map.insert_or_assign( - cbor::CBORValue(kCertSha256Key), - cbor::CBORValue( - base::StringPiece(reinterpret_cast<const char*>( - envelope.signature().cert_sha256->data), - sizeof(envelope.signature().cert_sha256->data)), - cbor::CBORValue::Type::BYTE_STRING)); - } - // 7.4.2. "The text string "validity-url" to the byte string value of - // validity-url." [spec text] - map.insert_or_assign(cbor::CBORValue(kValidityUrlKey), - cbor::CBORValue(envelope.signature().validity_url.spec(), - cbor::CBORValue::Type::BYTE_STRING)); - // 7.4.3. "The text string "date" to the integer value of date." [spec text] - if (!base::IsValueInRangeForNumericType<int64_t>(envelope.signature().date)) - return base::nullopt; - - map.insert_or_assign( - cbor::CBORValue(kDateKey), - cbor::CBORValue(base::checked_cast<int64_t>(envelope.signature().date))); - // 7.4.4. "The text string "expires" to the integer value of expires." - // [spec text] - if (!base::IsValueInRangeForNumericType<int64_t>( - envelope.signature().expires)) - return base::nullopt; - - map.insert_or_assign(cbor::CBORValue(kExpiresKey), - cbor::CBORValue(base::checked_cast<int64_t>( - envelope.signature().expires))); - // 7.4.5. "The text string "headers" to the CBOR representation - // (Section 3.2) of exchange's headers." [spec text] - map.insert_or_assign(cbor::CBORValue(kHeadersKey), std::move(*headers_val)); - return cbor::CBORValue(map); -} - base::Optional<crypto::SignatureVerifier::SignatureAlgorithm> GetSignatureAlgorithm(scoped_refptr<net::X509Certificate> cert, SignedExchangeDevToolsProxy* devtools_proxy) { @@ -217,40 +168,62 @@ return output; } +void AppendToBuf8BytesBigEndian(std::vector<uint8_t>* buf, uint64_t n) { + char encoded[8]; + base::WriteBigEndian(encoded, n); + buf->insert(buf->end(), std::begin(encoded), std::end(encoded)); +} + base::Optional<std::vector<uint8_t>> GenerateSignedMessage( const SignedExchangeEnvelope& envelope) { TRACE_EVENT_BEGIN0(TRACE_DISABLED_BY_DEFAULT("loading"), "GenerateSignedMessage"); - // GenerateSignedMessageCBOR corresponds to Step 7.4. - base::Optional<cbor::CBORValue> cbor_val = - GenerateSignedMessageCBOR(envelope); - if (!cbor_val) { - TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("loading"), - "GenerateSignedMessage", "error", - "GenerateSignedMessageCBOR failed."); - return base::nullopt; - } - - base::Optional<std::vector<uint8_t>> cbor_message = - cbor::CBORWriter::Write(*cbor_val); - if (!cbor_message) { - TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("loading"), - "GenerateSignedMessage", "error", - "CBORWriter::Write failed."); - return base::nullopt; - } + const auto signature = envelope.signature(); // https://wicg.github.io/webpackage/draft-yasskin-httpbis-origin-signed-exchanges-impl.html#signature-validity - // Step 7. "Let message be the concatenation of the following byte strings." + // Step 5. "Let message be the concatenation of the following byte strings." std::vector<uint8_t> message; - // see kMessageHeader for Steps 7.1 to 7.3. - message.reserve(arraysize(kMessageHeader) + cbor_message->size()); + // see kMessageHeader for Steps 5.1 to 5.3. message.insert(message.end(), std::begin(kMessageHeader), std::end(kMessageHeader)); - // 7.4. "The bytes of the canonical CBOR serialization (Section 3.4) of - // a CBOR map mapping:" [spec text] - message.insert(message.end(), cbor_message->begin(), cbor_message->end()); + + // Step 5.4. "If cert-sha256 is set, a byte holding the value 32 followed by + // the 32 bytes of the value of cert-sha256. Otherwise a 0 byte." [spec text] + // Note: cert-sha256 must be set for application/signed-exchange envelope + // format. + message.push_back(32); + const auto& cert_sha256 = envelope.signature().cert_sha256.value(); + message.insert(message.end(), std::begin(cert_sha256.data), + std::end(cert_sha256.data)); + + // Step 5.5. "The 8-byte big-endian encoding of the length in bytes of + // validity-url, followed by the bytes of validity-url." [spec text] + const auto& validity_url_spec = signature.validity_url.spec(); + AppendToBuf8BytesBigEndian(&message, validity_url_spec.size()); + message.insert(message.end(), std::begin(validity_url_spec), + std::end(validity_url_spec)); + + // Step 5.6. "The 8-byte big-endian encoding of date." [spec text] + AppendToBuf8BytesBigEndian(&message, signature.date); + + // Step 5.7. "The 8-byte big-endian encoding of expires." [spec text] + AppendToBuf8BytesBigEndian(&message, signature.expires); + + // Step 5.8. "The 8-byte big-endian encoding of the length in bytes of + // requestUrl, followed by the bytes of requestUrl." [spec text] + const auto& request_url_spec = envelope.request_url().spec(); + + AppendToBuf8BytesBigEndian(&message, request_url_spec.size()); + message.insert(message.end(), std::begin(request_url_spec), + std::end(request_url_spec)); + + // Step 5.9. "The 8-byte big-endian encoding of the length in bytes of + // headers, followed by the bytes of headers." [spec text] + AppendToBuf8BytesBigEndian(&message, envelope.cbor_header().size()); + message.insert(message.end(), envelope.cbor_header().begin(), + envelope.cbor_header().end()); + TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("loading"), "GenerateSignedMessage", "dump", HexDump(message)); return message; @@ -260,7 +233,7 @@ return base::Time::UnixEpoch() + base::TimeDelta::FromSeconds(t); } -// Implements steps 5-6 of +// Implements steps 3-4 of // https://wicg.github.io/webpackage/draft-yasskin-httpbis-origin-signed-exchanges-impl.html#signature-validity bool VerifyTimestamps(const SignedExchangeEnvelope& envelope, const base::Time& verification_time) { @@ -269,12 +242,12 @@ base::Time creation_time = TimeFromSignedExchangeUnixTime(envelope.signature().date); - // 5. "If expires is more than 7 days (604800 seconds) after date, return + // 3. "If expires is more than 7 days (604800 seconds) after date, return // "invalid"." [spec text] if ((expires_time - creation_time).InSeconds() > 604800) return false; - // 6. "If the current time is before date or after expires, return + // 4. "If the current time is before date or after expires, return // "invalid"." if (verification_time < creation_time || expires_time < verification_time) return false;
diff --git a/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc b/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc index 5c8722d..25a6ab70 100644 --- a/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc +++ b/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
@@ -65,9 +65,25 @@ // See content/testdata/sxg/README on how to generate these data. // clang-format off -constexpr char kSignatureHeaderRSA[] = R"(label; sig=*HrNLDfn6oHUmfx3YvP7dTseyZdmnQQB7jR8yea0FezZmy7IwJVtcZ/tGpXJ6fe8druTsGeFArdCeeLBapmPLq8BP6k6Uk2ClKUWNbM3is/HHaWWsfpLBF2fETKEBXvvUI9G8nJqDLJ9RS3AAZMEG+OrCybR1kEFDhc+Cp34isj8aUn7OG1ugq8ADt1DkP8xwSLn4MA2E6tHdG1dNNs+GpWE5pUbqe49DdQaQp/DcvOpixeDi3iID2VHDeASfyCVQvxNfEPRLKQ5fOELlGerTVY5XTXeegUfUuzTRHDsOBTPQ4iihCK2+/8vRwx92sExXnMH163ZL/YIM55FoU2KuRQ==*; validity-url="https://example.com/resource.validity.msg"; integrity="digest/mi-sha256-03"; cert-url="https://example.com/cert.msg"; cert-sha256=*tJGJP8ej7KCEW8VnVK3bKwpBza/oLrtWA75z5ZPptuc=*; date=1517892341; expires=1517895941)"; -constexpr char kSignatureHeaderECDSAP256[] = R"(label; sig=*MEYCIQD0rF/pJqqYa9WEE6eZcGzrVKv8yx+78tLAATxfLlyoWgIhAPJoiWcYAC+vDrZ1m5qE++y1TLdYUenwV84vpAaV3wTG*; validity-url="https://example.com/resource.validity.msg"; integrity="digest/mi-sha256-03"; cert-url="https://example.com/cert.msg"; cert-sha256=*KX+BYLSMgDOON8Ju65RoId39Qvajxa12HO+WnD4HpS0=*; date=1517892341; expires=1517895941)"; -constexpr char kSignatureHeaderECDSAP384[] = R"(label; sig=*MGUCMDkTn0MhRiG0OfbAbnyXRgM8XSV8vjm5w0olX5qoL94LEiJ7zS4ZmdxvSNHp5luK5QIxAPlQRvcIBq8vvKgkzQCjsbZ/jEAKh1Gx2JKSyj4HRfLWRar4KbGbMm+GbyU7N/SZYQ==*; validity-url="https://example.com/resource.validity.msg"; integrity="digest/mi-sha256-03"; cert-url="https://example.com/cert.msg"; cert-sha256=*8X8y8nj8vDJHSSa0cxn+TCu+8zGpIJfbdzAnd5cW+jA=*; date=1517892341; expires=1517895941)"; +constexpr char kSignatureHeaderRSA[] = R"(label; sig=*DDeXzJshGnPT+ei1rS1KmZx+QLwwLTbNKDVSmTb2HjGfgPngv+C+uMbjZiliOmGe0b514JcAlYAM57t0kZY2FPd9JdqwYPIiAWEwxByfV2iXBbsGZNWGtS/AAq1SaPwIMfrzdLXAFbKbtTRhS7B5LHCo/6hEIXu0TJJFbv5fKaLgTTLF0AK5dV0/En0uz+bnVARuBIH/ez2gPEFc6KbGnTTp8LYcCe/YjlHQy/Oac28ACBtn70rP1TerWEaYBwMMDckJ2gfsVyLqMcFtJqV0uGLT6Atb2wBSUZlZDTEZf228362r+EHLrADAuhz4bdSMKFsFgWyceOriDyHhc0PSwQ==*; validity-url="https://example.com/resource.validity.msg"; integrity="digest/mi-sha256-03"; cert-url="https://example.com/cert.msg"; cert-sha256=*tJGJP8ej7KCEW8VnVK3bKwpBza/oLrtWA75z5ZPptuc=*; date=1517892341; expires=1517895941)"; +constexpr char kSignatureHeaderECDSAP256[] = R"(label; sig=*MEUCIQC7tM/B6YxVgrJmgfFawtwBKPev2vFCh7amR+JTDBMgTQIga9LkS51vteYr8NWPTCSZRy10lcLaFNN9m1G3OBS9lBs=*; validity-url="https://example.com/resource.validity.msg"; integrity="digest/mi-sha256-03"; cert-url="https://example.com/cert.msg"; cert-sha256=*KX+BYLSMgDOON8Ju65RoId39Qvajxa12HO+WnD4HpS0=*; date=1517892341; expires=1517895941)"; +constexpr uint8_t kCborHeadersECDSAP256[] = { + 0x82, 0xa1, 0x47, 0x3a, 0x6d, 0x65, 0x74, 0x68, 0x6f, 0x64, 0x43, 0x47, + 0x45, 0x54, 0xa4, 0x46, 0x64, 0x69, 0x67, 0x65, 0x73, 0x74, 0x58, 0x39, + 0x6d, 0x69, 0x2d, 0x73, 0x68, 0x61, 0x32, 0x35, 0x36, 0x2d, 0x30, 0x33, + 0x3d, 0x77, 0x6d, 0x70, 0x34, 0x64, 0x52, 0x4d, 0x59, 0x67, 0x78, 0x50, + 0x33, 0x74, 0x53, 0x4d, 0x43, 0x77, 0x56, 0x2f, 0x49, 0x30, 0x43, 0x57, + 0x4f, 0x43, 0x69, 0x48, 0x5a, 0x70, 0x41, 0x69, 0x68, 0x4b, 0x5a, 0x6b, + 0x31, 0x39, 0x62, 0x73, 0x4e, 0x39, 0x52, 0x49, 0x3d, 0x47, 0x3a, 0x73, + 0x74, 0x61, 0x74, 0x75, 0x73, 0x43, 0x32, 0x30, 0x30, 0x4c, 0x63, 0x6f, + 0x6e, 0x74, 0x65, 0x6e, 0x74, 0x2d, 0x74, 0x79, 0x70, 0x65, 0x58, 0x18, + 0x74, 0x65, 0x78, 0x74, 0x2f, 0x68, 0x74, 0x6d, 0x6c, 0x3b, 0x20, 0x63, + 0x68, 0x61, 0x72, 0x73, 0x65, 0x74, 0x3d, 0x75, 0x74, 0x66, 0x2d, 0x38, + 0x50, 0x63, 0x6f, 0x6e, 0x74, 0x65, 0x6e, 0x74, 0x2d, 0x65, 0x6e, 0x63, + 0x6f, 0x64, 0x69, 0x6e, 0x67, 0x4c, 0x6d, 0x69, 0x2d, 0x73, 0x68, 0x61, + 0x32, 0x35, 0x36, 0x2d, 0x30, 0x33 +}; +constexpr char kSignatureHeaderECDSAP384[] = R"(label; sig=*MGUCMQDm3+Mf3ymTQOF2EUFk+NDIpOIqbFCboYsPD9YOV9rpayKTmAXzUD7Hxtp+XP/8mQECMEfTRcJmvL9QMAMKuDIzQqy/ib8MPeJHap9kQVQT1OdROaYj4EISngkJeT5om9/YlA==*; validity-url="https://example.com/resource.validity.msg"; integrity="digest/mi-sha256-03"; cert-url="https://example.com/cert.msg"; cert-sha256=*8X8y8nj8vDJHSSa0cxn+TCu+8zGpIJfbdzAnd5cW+jA=*; date=1517892341; expires=1517895941)"; // clang-format on // |expires| (1518497142) is more than 7 days (604800 seconds) after |date| @@ -286,6 +302,7 @@ envelope.AddResponseHeader("content-encoding", "mi-sha256-03"); envelope.AddResponseHeader( "digest", "mi-sha256-03=wmp4dRMYgxP3tSMCwV/I0CWOCiHZpAihKZk19bsN9RI="); + envelope.set_cbor_header(base::make_span(kCborHeadersECDSAP256)); envelope.SetSignatureForTesting((*signature)[0]);
diff --git a/content/common/background_fetch/background_fetch_struct_traits.h b/content/common/background_fetch/background_fetch_struct_traits.h index 3a3a6e1e..5f0c04a 100644 --- a/content/common/background_fetch/background_fetch_struct_traits.h +++ b/content/common/background_fetch/background_fetch_struct_traits.h
@@ -83,8 +83,7 @@ } static blink::mojom::FetchAPIResponsePtr response( const content::BackgroundFetchSettledFetch& fetch) { - return content::BackgroundFetchSettledFetch::MakeCloneResponse( - fetch.response); + return content::BackgroundFetchSettledFetch::CloneResponse(fetch.response); } static bool Read(blink::mojom::BackgroundFetchSettledFetchDataView data,
diff --git a/content/common/background_fetch/background_fetch_types.cc b/content/common/background_fetch/background_fetch_types.cc index e57a1a38..343363ec 100644 --- a/content/common/background_fetch/background_fetch_types.cc +++ b/content/common/background_fetch/background_fetch_types.cc
@@ -7,7 +7,7 @@ namespace { -blink::mojom::SerializedBlobPtr MakeCloneSerializedBlob( +blink::mojom::SerializedBlobPtr CloneSerializedBlob( const blink::mojom::SerializedBlobPtr& blob) { if (!blob) return nullptr; @@ -53,18 +53,19 @@ BackgroundFetchRegistration::~BackgroundFetchRegistration() = default; // static -blink::mojom::FetchAPIResponsePtr -BackgroundFetchSettledFetch::MakeCloneResponse( +blink::mojom::FetchAPIResponsePtr BackgroundFetchSettledFetch::CloneResponse( const blink::mojom::FetchAPIResponsePtr& response) { + // TODO(https://crbug.com/876546): Replace this method with response.Clone() + // if the associated bug is fixed. if (!response) return nullptr; return blink::mojom::FetchAPIResponse::New( response->url_list, response->status_code, response->status_text, response->response_type, response->headers, - MakeCloneSerializedBlob(response->blob), response->error, + CloneSerializedBlob(response->blob), response->error, response->response_time, response->cache_storage_cache_name, response->cors_exposed_header_names, response->is_in_cache_storage, - MakeCloneSerializedBlob(response->side_data_blob)); + CloneSerializedBlob(response->side_data_blob)); } BackgroundFetchSettledFetch::BackgroundFetchSettledFetch() = default; @@ -76,7 +77,7 @@ BackgroundFetchSettledFetch& BackgroundFetchSettledFetch::operator=( const BackgroundFetchSettledFetch& other) { request = other.request; - response = MakeCloneResponse(other.response); + response = CloneResponse(other.response); return *this; }
diff --git a/content/common/background_fetch/background_fetch_types.h b/content/common/background_fetch/background_fetch_types.h index 7fd22c1b..c9bcda2 100644 --- a/content/common/background_fetch/background_fetch_types.h +++ b/content/common/background_fetch/background_fetch_types.h
@@ -69,7 +69,7 @@ // Analogous to the following structure in the spec: // http://wicg.github.io/background-fetch/#backgroundfetchsettledfetch struct CONTENT_EXPORT BackgroundFetchSettledFetch { - static blink::mojom::FetchAPIResponsePtr MakeCloneResponse( + static blink::mojom::FetchAPIResponsePtr CloneResponse( const blink::mojom::FetchAPIResponsePtr& response); BackgroundFetchSettledFetch(); BackgroundFetchSettledFetch(const BackgroundFetchSettledFetch& other);
diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn index b383c5f..0c82009 100644 --- a/content/renderer/BUILD.gn +++ b/content/renderer/BUILD.gn
@@ -684,6 +684,7 @@ "//gpu", "//gpu/command_buffer/client:gles2_interface", "//gpu/command_buffer/client:raster_interface", + "//gpu/command_buffer/client:webgpu_interface", "//jingle:jingle_glue", "//media", "//media:media_buildflags",
diff --git a/content/renderer/dom_serializer_browsertest.cc b/content/renderer/dom_serializer_browsertest.cc index fd70774..0fbb5a04 100644 --- a/content/renderer/dom_serializer_browsertest.cc +++ b/content/renderer/dom_serializer_browsertest.cc
@@ -142,9 +142,8 @@ data, "text/html", encoding_info, base_url, WebURL(), false /* replace */, blink::WebFrameLoadType::kStandard, blink::WebHistoryItem(), false /* is_client_redirect */, - nullptr /* navigation_data */, - nullptr /* original_request_to_replace */, - blink::WebNavigationTimings()); + nullptr /* navigation_params */, nullptr /* navigation_data */, + nullptr /* original_request_to_replace */); } base::MessageLoopCurrent::ScopedNestableTaskAllower allow; waiter.Wait();
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc index 1ec7b236..30f2c81 100644 --- a/content/renderer/render_frame_impl.cc +++ b/content/renderer/render_frame_impl.cc
@@ -952,6 +952,34 @@ return renderer_navigation_timings; } +// Packs all loading data sent by the browser to a blink understandable +// format, blink::WebNavigationParams. +std::unique_ptr<blink::WebNavigationParams> BuildNavigationParams( + const CommonNavigationParams& common_params, + const RequestNavigationParams& request_params, + std::unique_ptr<blink::WebServiceWorkerNetworkProvider> + service_worker_network_provider) { + std::unique_ptr<blink::WebNavigationParams> navigation_params = + std::make_unique<blink::WebNavigationParams>(); + navigation_params->navigation_timings = BuildNavigationTimings( + common_params.navigation_start, request_params.navigation_timing, + common_params.input_start); + + if (common_params.source_location.has_value()) { + navigation_params->source_location.url = + WebString::FromLatin1(common_params.source_location->url); + navigation_params->source_location.line_number = + common_params.source_location->line_number; + navigation_params->source_location.column_number = + common_params.source_location->column_number; + } + + navigation_params->is_user_activated = request_params.was_activated; + navigation_params->service_worker_network_provider = + std::move(service_worker_network_provider); + return navigation_params; +} + } // namespace class RenderFrameImpl::FrameURLLoaderFactory @@ -2616,20 +2644,34 @@ CommitNavigationCallback())); } + // The |pending_navigation_params_| are reset in DidCreateDocumentLoader. + // We might not have |pending_navigation_params_| here, if failing after + // creating the DocumentLoader. This can happen if there's no byte in the + // response and the network connection gets closed. In that case, the + // provisional load does not commit and we get a DidFailProvisionalLoad. std::unique_ptr<DocumentState> document_state; - // If we sent a successful navigation to commit but for whatever reason the - // commit was interrupted we might end up with empty - // |pending_navigation_params_| here. For example, if - // there's no byte in the response and the network connection gets closed. In - // that case, the provisional load does not commit and we get a - // DidFailProvisionalLoad. + std::unique_ptr<blink::WebNavigationParams> navigation_params; if (pending_navigation_params_) { document_state = BuildDocumentStateFromPending( pending_navigation_params_.get(), nullptr); + // We might come here after we've already created + // ServiceWorkerNetworkProvider in CommitNavigation, and if that's the case + // we shouldn't reuse the same request_params (which confuses the + // ServiceWorker backend due to double-creation for the same provider_id). + // Code below will result in creating a SWNetworkProvider with an invalid + // ID but it should be fine as it's only used for showing an error page. + // TODO(ahemery): We should probably move the existing one down + // into the failed page instead of recreating a new one. + navigation_params = BuildNavigationParams( + pending_navigation_params_->common_params, + pending_navigation_params_->request_params, + BuildServiceWorkerNetworkProviderForNavigation( + nullptr /* request_params */, + nullptr /* controller_service_worker_info */)); } - LoadNavigationErrorPage(failed_request, error, replace, nullptr, - error_page_content, std::move(document_state)); + error_page_content, std::move(navigation_params), + std::move(document_state)); } void RenderFrameImpl::LoadNavigationErrorPage( @@ -2638,6 +2680,7 @@ bool replace, HistoryEntry* entry, const base::Optional<std::string>& error_page_content, + std::unique_ptr<blink::WebNavigationParams> navigation_params, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data) { blink::WebFrameLoadType frame_load_type = entry ? blink::WebFrameLoadType::kBackForward @@ -2656,8 +2699,8 @@ } LoadNavigationErrorPageInternal(error_html, GURL(kUnreachableWebDataURL), error.url(), replace, frame_load_type, - history_item, std::move(navigation_data), - failed_request); + history_item, std::move(navigation_params), + std::move(navigation_data), failed_request); } void RenderFrameImpl::LoadNavigationErrorPageForHttpStatusError( @@ -2666,6 +2709,7 @@ int http_status, bool replace, HistoryEntry* entry, + std::unique_ptr<blink::WebNavigationParams> navigation_params, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data) { blink::WebFrameLoadType frame_load_type = entry ? blink::WebFrameLoadType::kBackForward @@ -2676,10 +2720,10 @@ std::string error_html; GetContentClient()->renderer()->PrepareErrorPageForHttpStatusError( this, failed_request, unreachable_url, http_status, &error_html, nullptr); - std::unique_ptr<DocumentState> document_state(BuildDocumentState()); - LoadNavigationErrorPageInternal( - error_html, GURL(kUnreachableWebDataURL), unreachable_url, replace, - frame_load_type, history_item, std::move(document_state), failed_request); + LoadNavigationErrorPageInternal(error_html, GURL(kUnreachableWebDataURL), + unreachable_url, replace, frame_load_type, + history_item, std::move(navigation_params), + std::move(navigation_data), failed_request); } void RenderFrameImpl::LoadNavigationErrorPageInternal( @@ -2689,13 +2733,14 @@ bool replace, blink::WebFrameLoadType frame_load_type, const blink::WebHistoryItem& history_item, + std::unique_ptr<blink::WebNavigationParams> navigation_params, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data, const WebURLRequest& failed_request) { - frame_->CommitDataNavigation(error_html, WebString::FromUTF8("text/html"), - WebString::FromUTF8("UTF-8"), error_page_url, - error_url, replace, frame_load_type, - history_item, false, std::move(navigation_data), - &failed_request, blink::WebNavigationTimings()); + frame_->CommitDataNavigation( + error_html, WebString::FromUTF8("text/html"), + WebString::FromUTF8("UTF-8"), error_page_url, error_url, replace, + frame_load_type, history_item, false, std::move(navigation_params), + std::move(navigation_data), &failed_request); } void RenderFrameImpl::DidMeaningfulLayout( @@ -2822,8 +2867,8 @@ error_html, WebString::FromUTF8("text/html"), WebString::FromUTF8("UTF-8"), GURL(kUnreachableWebDataURL), error.url(), true, blink::WebFrameLoadType::kStandard, blink::WebHistoryItem(), true, - nullptr /* navigation_data */, nullptr /* original_failed_request */, - blink::WebNavigationTimings()); + nullptr /* navigation_params */, nullptr /* navigation_data */, + nullptr /* original_failed_request */); } void RenderFrameImpl::ExecuteJavaScript(const base::string16& javascript) { @@ -3080,7 +3125,6 @@ return; } - controller_service_worker_info_ = std::move(controller_service_worker_info); prefetch_loader_factory_ = std::move(prefetch_loader_factory); // If the request was initiated in the context of a user gesture then make @@ -3164,10 +3208,12 @@ head); frame_->CommitNavigation( request, load_type, item_for_history_navigation, is_client_redirect, - devtools_navigation_token, std::move(document_state), - BuildNavigationTimings(common_params.navigation_start, - request_params.navigation_timing, - common_params.input_start)); + devtools_navigation_token, + BuildNavigationParams( + common_params, request_params, + BuildServiceWorkerNetworkProviderForNavigation( + &request_params, std::move(controller_service_worker_info))), + std::move(document_state)); // The commit can result in this frame being removed. Use a // WeakPtr as an easy way to detect whether this has occured. If so, this // method should return immediately and not touch any part of the object, @@ -3326,14 +3372,19 @@ return; } - // If we didn't call didFailProvisionalLoad or there wasn't a + // If we didn't call DidFailProvisionalLoad or there wasn't a // GetProvisionalDocumentLoader(), LoadNavigationErrorPage wasn't called, so // do it now. if (request_params.nav_entry_id != 0 || !had_provisional_document_loader) { + std::unique_ptr<blink::WebNavigationParams> navigation_params = + BuildNavigationParams(common_params, request_params, + BuildServiceWorkerNetworkProviderForNavigation( + &request_params, nullptr)); std::unique_ptr<DocumentState> document_state(BuildDocumentStateFromPending( pending_navigation_params_.get(), nullptr)); LoadNavigationErrorPage(failed_request, error, replace, history_entry.get(), - error_page_content, std::move(document_state)); + error_page_content, std::move(navigation_params), + std::move(document_state)); if (!weak_this) return; } @@ -4060,55 +4111,17 @@ void RenderFrameImpl::DidCreateDocumentLoader( blink::WebDocumentLoader* document_loader) { - // Ensure that the pending_navigation_params are destroyed when doing an - // early return. - std::unique_ptr<PendingNavigationParams> pending_navigation_params( - std::move(pending_navigation_params_)); - bool has_pending_params = pending_navigation_params.get(); - + pending_navigation_params_.reset(); DocumentState* document_state = DocumentState::FromDocumentLoader(document_loader); if (!document_state) { // This is either a placeholder document loader or an initial empty // document. document_loader->SetExtraData(BuildDocumentState()); + document_loader->SetServiceWorkerNetworkProvider( + BuildServiceWorkerNetworkProviderForNavigation( + nullptr /* request_params */, nullptr /* controller_info */)); } - - // Create the serviceworker's per-document network observing object. - // Same document navigation do not go through here so it should never exist. - DCHECK(!document_loader->GetServiceWorkerNetworkProvider()); - scoped_refptr<network::SharedURLLoaderFactory> fallback_factory = - network::SharedURLLoaderFactory::Create( - GetLoaderFactoryBundle()->CloneWithoutDefaultFactory()); - document_loader->SetServiceWorkerNetworkProvider( - ServiceWorkerNetworkProvider::CreateForNavigation( - routing_id_, - has_pending_params ? &(pending_navigation_params->request_params) - : nullptr, - frame_, std::move(controller_service_worker_info_), - std::move(fallback_factory))); - - if (!has_pending_params) - return; - - const CommonNavigationParams& common_params = - pending_navigation_params->common_params; - const RequestNavigationParams& request_params = - pending_navigation_params->request_params; - - // Update the source location before processing the navigation commit. - if (pending_navigation_params->common_params.source_location.has_value()) { - blink::WebSourceLocation source_location; - source_location.url = - WebString::FromLatin1(common_params.source_location->url); - source_location.line_number = common_params.source_location->line_number; - source_location.column_number = - common_params.source_location->column_number; - document_loader->SetSourceLocation(source_location); - } - - if (request_params.was_activated) - document_loader->SetUserActivated(); } void RenderFrameImpl::DidStartProvisionalLoad( @@ -4504,9 +4517,15 @@ if (GetContentClient()->renderer()->HasErrorPage(http_status_code)) { // This call may run scripts, e.g. via the beforeunload event. std::unique_ptr<DocumentState> document_state(BuildDocumentState()); + std::unique_ptr<blink::WebNavigationParams> navigation_params = + std::make_unique<blink::WebNavigationParams>(); + navigation_params->service_worker_network_provider = + BuildServiceWorkerNetworkProviderForNavigation( + nullptr /* request_params */, nullptr /* controller_info */); LoadNavigationErrorPageForHttpStatusError( frame_->GetDocumentLoader()->GetRequest(), frame_->GetDocument().Url(), - http_status_code, true, nullptr, std::move(document_state)); + http_status_code, true /* replace */, nullptr /* entry */, + std::move(navigation_params), std::move(document_state)); } // Do not use |this| or |frame_| here without checking |weak_self|. } @@ -6834,7 +6853,7 @@ } void RenderFrameImpl::LoadDataURL( - const CommonNavigationParams& params, + const CommonNavigationParams& common_params, const RequestNavigationParams& request_params, WebLocalFrame* frame, blink::WebFrameLoadType load_type, @@ -6842,7 +6861,7 @@ bool is_client_redirect, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data) { // A loadData request with a specified base URL. - GURL data_url = params.url; + GURL data_url = common_params.url; #if defined(OS_ANDROID) if (!request_params.data_url_as_string.empty()) { #if DCHECK_IS_ON() @@ -6854,14 +6873,15 @@ #endif data_url = GURL(request_params.data_url_as_string); if (!data_url.is_valid() || !data_url.SchemeIs(url::kDataScheme)) { - data_url = params.url; + data_url = common_params.url; } } #endif std::string mime_type, charset, data; if (net::DataURL::Parse(data_url, &mime_type, &charset, &data)) { - const GURL base_url = params.base_url_for_data_url.is_empty() ? - params.url : params.base_url_for_data_url; + const GURL base_url = common_params.base_url_for_data_url.is_empty() + ? common_params.url + : common_params.base_url_for_data_url; bool replace = load_type == WebFrameLoadType::kReloadBypassingCache || load_type == WebFrameLoadType::kReload; @@ -6869,16 +6889,17 @@ WebData(data.c_str(), data.length()), WebString::FromUTF8(mime_type), WebString::FromUTF8(charset), base_url, // Needed so that history-url-only changes don't become reloads. - params.history_url_for_data_url, replace, load_type, + common_params.history_url_for_data_url, replace, load_type, item_for_history_navigation, is_client_redirect, + BuildNavigationParams( + common_params, request_params, + BuildServiceWorkerNetworkProviderForNavigation( + &request_params, nullptr /* controller_service_worker_info */)), std::move(navigation_data), - nullptr, // original_failed_request - BuildNavigationTimings(params.navigation_start, - request_params.navigation_timing, - params.input_start)); + nullptr); // original_failed_request } else { CHECK(false) << "Invalid URL passed: " - << params.url.possibly_invalid_spec(); + << common_params.url.possibly_invalid_spec(); } } @@ -7338,4 +7359,16 @@ return false; } +std::unique_ptr<blink::WebServiceWorkerNetworkProvider> +RenderFrameImpl::BuildServiceWorkerNetworkProviderForNavigation( + const RequestNavigationParams* request_params, + mojom::ControllerServiceWorkerInfoPtr controller_service_worker_info) { + scoped_refptr<network::SharedURLLoaderFactory> fallback_factory = + network::SharedURLLoaderFactory::Create( + GetLoaderFactoryBundle()->CloneWithoutDefaultFactory()); + return ServiceWorkerNetworkProvider::CreateForNavigation( + routing_id_, request_params, frame_, + std::move(controller_service_worker_info), std::move(fallback_factory)); +} + } // namespace content
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h index 163cdcbf..555540a60 100644 --- a/content/renderer/render_frame_impl.h +++ b/content/renderer/render_frame_impl.h
@@ -125,6 +125,7 @@ struct FramePolicy; struct WebContextMenuData; struct WebCursorInfo; +struct WebNavigationParams; struct WebMediaPlayerAction; struct WebImeTextSpan; struct WebScrollIntoViewParams; @@ -1132,6 +1133,7 @@ bool replace, HistoryEntry* entry, const base::Optional<std::string>& error_page_content, + std::unique_ptr<blink::WebNavigationParams> navigation_params, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data); void LoadNavigationErrorPageForHttpStatusError( const blink::WebURLRequest& failed_request, @@ -1139,6 +1141,7 @@ int http_status, bool replace, HistoryEntry* entry, + std::unique_ptr<blink::WebNavigationParams> navigation_params, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data); void LoadNavigationErrorPageInternal( const std::string& error_html, @@ -1147,6 +1150,7 @@ bool replace, blink::WebFrameLoadType frame_load_type, const blink::WebHistoryItem& history_item, + std::unique_ptr<blink::WebNavigationParams> navigation_params, std::unique_ptr<blink::WebDocumentLoader::ExtraData> navigation_data, const blink::WebURLRequest& failed_request); @@ -1170,7 +1174,7 @@ // Loads a data url. void LoadDataURL( - const CommonNavigationParams& params, + const CommonNavigationParams& common_params, const RequestNavigationParams& request_params, blink::WebLocalFrame* frame, blink::WebFrameLoadType load_type, @@ -1312,6 +1316,13 @@ // Whether url download should be throttled. bool ShouldThrottleDownload(); + // Creates a service worker network provider using browser provided data, + // to be supplied to the loader. + std::unique_ptr<blink::WebServiceWorkerNetworkProvider> + BuildServiceWorkerNetworkProviderForNavigation( + const RequestNavigationParams* request_params, + mojom::ControllerServiceWorkerInfoPtr controller_service_worker_info); + // Stores the WebLocalFrame we are associated with. This is null from the // constructor until BindToFrame() is called, and it is null after // FrameDetached() is called until destruction (which is asynchronous in the @@ -1599,12 +1610,6 @@ mojo::BindingSet<service_manager::mojom::InterfaceProvider> interface_provider_bindings_; - // Non-null if this frame is to be controlled by a service worker. - // Sent from the browser process on navigation commit. Valid until the - // document loader for this frame is actually created (where this is - // consumed to initialize a subresource loader). - mojom::ControllerServiceWorkerInfoPtr controller_service_worker_info_; - // Set on CommitNavigation when Network Service is enabled, and used // by FrameURLLoaderFactory for prefetch requests. network::mojom::URLLoaderFactoryPtr prefetch_loader_factory_;
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc index d81b3bad..1ed96f95 100644 --- a/content/renderer/service_worker/service_worker_context_client.cc +++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -304,7 +304,8 @@ web_request->SetIsHistoryNavigation(request.is_history_navigation); } -// Converts |response| to its equivalent type in the Blink API. +// Converts |response| to its equivalent type in the Blink API. This conversion +// is destructive. // TODO(leonhsl): Remove this when we propagate // blink::mojom::FetchAPIResponsePtr into Blink instead of // WebServiceWorkerResponse.
diff --git a/content/renderer/service_worker/service_worker_network_provider.h b/content/renderer/service_worker/service_worker_network_provider.h index ab53df9..0145765 100644 --- a/content/renderer/service_worker/service_worker_network_provider.h +++ b/content/renderer/service_worker/service_worker_network_provider.h
@@ -63,6 +63,8 @@ // renderer by the browser on a navigation commit. It is null if we have not // yet heard from the browser (currently only during the time it takes from // having the renderer initiate a navigation until the browser commits it). + // Note: in particular, provisional load failure do not provide + // |request_params|. // TODO(ahemery): Update this comment when do not create placeholder document // loaders for renderer-initiated navigations. In this case, this should never // be null.
diff --git a/content/renderer/webgraphicscontext3d_provider_impl.cc b/content/renderer/webgraphicscontext3d_provider_impl.cc index f44ed3276..c256427 100644 --- a/content/renderer/webgraphicscontext3d_provider_impl.cc +++ b/content/renderer/webgraphicscontext3d_provider_impl.cc
@@ -4,6 +4,7 @@ #include "content/renderer/webgraphicscontext3d_provider_impl.h" +#include "cc/paint/paint_image.h" #include "cc/tiles/gpu_image_decode_cache.h" #include "components/viz/common/gl_helper.h" #include "gpu/command_buffer/client/context_support.h" @@ -83,7 +84,8 @@ image_decode_cache_ = std::make_unique<cc::GpuImageDecodeCache>( provider_.get(), use_transfer_cache, kN32_SkColorType, - kMaxWorkingSetBytes, provider_->ContextCapabilities().max_texture_size); + kMaxWorkingSetBytes, provider_->ContextCapabilities().max_texture_size, + cc::PaintImage::kDefaultGeneratorClientId); return image_decode_cache_.get(); }
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc index daceca6..75cbe850 100644 --- a/content/shell/renderer/layout_test/blink_test_runner.cc +++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -84,7 +84,7 @@ #include "third_party/blink/public/web/web_frame_widget.h" #include "third_party/blink/public/web/web_history_item.h" #include "third_party/blink/public/web/web_local_frame.h" -#include "third_party/blink/public/web/web_navigation_timings.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_script_source.h" #include "third_party/blink/public/web/web_testing_support.h" #include "third_party/blink/public/web/web_view.h" @@ -854,8 +854,8 @@ main_frame->CommitNavigation( WebURLRequest(GURL(url::kAboutBlankURL)), blink::WebFrameLoadType::kStandard, blink::WebHistoryItem(), false, - base::UnguessableToken::Create(), nullptr /* extra_data */, - blink::WebNavigationTimings()); + base::UnguessableToken::Create(), nullptr /* navigation_params */, + nullptr /* extra_data */); Send(new ShellViewHostMsg_ResetDone(routing_id())); }
diff --git a/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt b/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt index e23fba0..222db467 100644 --- a/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt +++ b/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt
@@ -1,8 +1,8 @@ AXWebArea AXRoleDescription='HTML content' -++AXTextArea AXRoleDescription='text entry area' AXValue='TextBox1<newline>' +++AXTextArea AXRoleDescription='text entry area' AXValue='TextBox1' ++++AXHeading AXRoleDescription='heading' AXTitle='TextBox1' AXValue='1' ++++++AXStaticText AXRoleDescription='text' AXValue='TextBox1' -++AXTextArea AXRoleDescription='text entry area' AXValue='TextBox2<newline>Some text.' +++AXTextArea AXRoleDescription='text entry area' AXValue='TextBox2<newline><newline>Some text.' ++++AXHeading AXRoleDescription='heading' AXTitle='TextBox2' AXValue='2' ++++++AXStaticText AXRoleDescription='text' AXValue='TextBox2' ++++AXGroup AXRoleDescription='group'
diff --git a/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt b/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt index eccb69c..e1cbace3a 100644 --- a/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt +++ b/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt
@@ -1,9 +1,9 @@ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0><obj1>' n_characters=2 caret_offset=0 n_selections=0 -++ROLE_SYSTEM_TEXT value='TextBox1<newline>' FOCUSABLE IA2_STATE_SINGLE_LINE xml-roles:textbox ia2_hypertext='<obj0>' n_characters=1 caret_offset=0 n_selections=0 +++ROLE_SYSTEM_TEXT value='TextBox1' FOCUSABLE IA2_STATE_SINGLE_LINE xml-roles:textbox ia2_hypertext='<obj0>' n_characters=1 caret_offset=0 n_selections=0 ++++IA2_ROLE_HEADING name='TextBox1' xml-roles:heading ia2_hypertext='TextBox1' n_characters=8 caret_offset=0 n_selections=0 ++++++ROLE_SYSTEM_STATICTEXT name='TextBox1' ia2_hypertext='TextBox1' n_characters=8 caret_offset=0 n_selections=0 -++ROLE_SYSTEM_TEXT value='TextBox2<newline>Some text.' FOCUSABLE IA2_STATE_MULTI_LINE xml-roles:textbox ia2_hypertext='<obj0><obj1>' n_characters=2 n_selections=0 +++ROLE_SYSTEM_TEXT value='TextBox2<newline><newline>Some text.' FOCUSABLE IA2_STATE_MULTI_LINE xml-roles:textbox ia2_hypertext='<obj0><obj1>' n_characters=2 n_selections=0 ++++IA2_ROLE_HEADING name='TextBox2' xml-roles:heading ia2_hypertext='TextBox2' n_characters=8 n_selections=0 ++++++ROLE_SYSTEM_STATICTEXT name='TextBox2' ia2_hypertext='TextBox2' n_characters=8 n_selections=0 ++++IA2_ROLE_PARAGRAPH ia2_hypertext='Some text.' n_characters=10 n_selections=0 -++++++ROLE_SYSTEM_STATICTEXT name='Some text.' ia2_hypertext='Some text.' n_characters=10 n_selections=0 \ No newline at end of file +++++++ROLE_SYSTEM_STATICTEXT name='Some text.' ia2_hypertext='Some text.' n_characters=10 n_selections=0
diff --git a/content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt b/content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt index f7bdcfb..09e1f70b 100644 --- a/content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt +++ b/content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt
@@ -1,5 +1,5 @@ rootWebArea -++genericContainer editable multiline richlyEditable value='A contenteditable with a link and an and a .<newline><newline>Always expose editable tables as tables.<newline>Editable list item.<newline>' editableRoot=true +++genericContainer editable multiline richlyEditable value='A contenteditable with a link and an and a.<newline><newline>Always expose editable tables as tables.<newline>Editable list item.' editableRoot=true ++++paragraph editable richlyEditable ++++++staticText editable richlyEditable name='A contenteditable with a ' ++++++++inlineTextBox name='A contenteditable with a '
diff --git a/content/test/data/accessibility/html/contenteditable-descendants-expected-mac.txt b/content/test/data/accessibility/html/contenteditable-descendants-expected-mac.txt index 8835c47..a69d1603 100644 --- a/content/test/data/accessibility/html/contenteditable-descendants-expected-mac.txt +++ b/content/test/data/accessibility/html/contenteditable-descendants-expected-mac.txt
@@ -1,5 +1,5 @@ AXWebArea -++AXTextArea AXValue='A contenteditable with a link and an and a . +++AXTextArea AXValue='A contenteditable with a link and an and a. Always expose editable tables as tables. Editable list item. '
diff --git a/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt b/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt index aae558a..01b0ffd8 100644 --- a/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt +++ b/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt
@@ -1,5 +1,5 @@ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0><obj1><obj2>' n_selections=0 -++IA2_ROLE_SECTION value='A contenteditable with a link and an and a .<newline><newline>Always expose editable tables as tables.<newline>Editable list item.<newline>' FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE ia2_hypertext='<obj0><obj1><obj2>' n_selections=0 +++IA2_ROLE_SECTION value='A contenteditable with a link and an and a.<newline><newline>Always expose editable tables as tables.<newline>Editable list item.' FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE ia2_hypertext='<obj0><obj1><obj2>' n_selections=0 ++++IA2_ROLE_PARAGRAPH IA2_STATE_EDITABLE ia2_hypertext='A contenteditable with a <obj1> and an <obj3> and a <obj5>.' n_selections=0 ++++++ROLE_SYSTEM_STATICTEXT name='A contenteditable with a ' IA2_STATE_EDITABLE ia2_hypertext='A contenteditable with a ' n_selections=0 ++++++ROLE_SYSTEM_LINK name='link' LINKED IA2_STATE_EDITABLE ia2_hypertext='link' n_selections=0
diff --git a/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt b/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt index c0ba87e..b75fe51 100644 --- a/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt +++ b/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt
@@ -1,5 +1,5 @@ rootWebArea -++genericContainer editable multiline richlyEditable value='A contenteditable with a link and an and a .<newline><newline>Always expose editable tables as tables.<newline>Editable list item.' editableRoot=true +++genericContainer editable multiline richlyEditable value='A contenteditable with a link and an and a.<newline><newline>Always expose editable tables as tables.<newline>Editable list item.' editableRoot=true ++++paragraph editable richlyEditable ++++++staticText editable richlyEditable name='A contenteditable with a ' TreeData.textSelStartOffset=0 ++++++++inlineTextBox name='A contenteditable with a '
diff --git a/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-mac.txt b/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-mac.txt index 4ae3f37..45cb0b5 100644 --- a/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-mac.txt +++ b/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-mac.txt
@@ -1,5 +1,5 @@ AXWebArea -++AXTextArea AXValue='A contenteditable with a link and an and a . +++AXTextArea AXValue='A contenteditable with a link and an and a. Always expose editable tables as tables. Editable list item.' ++++AXGroup
diff --git a/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt b/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt index ecaf180..4197929 100644 --- a/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt +++ b/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt
@@ -1,5 +1,5 @@ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0>' caret_offset=1 n_selections=1 selection_start=0 selection_end=1 -++IA2_ROLE_SECTION value='A contenteditable with a link and an and a .<newline><newline>Always expose editable tables as tables.<newline>Editable list item.' FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE ia2_hypertext='<obj0><obj1><obj2>' caret_offset=3 n_selections=1 selection_start=0 selection_end=3 +++IA2_ROLE_SECTION value='A contenteditable with a link and an and a.<newline><newline>Always expose editable tables as tables.<newline>Editable list item.' FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE ia2_hypertext='<obj0><obj1><obj2>' caret_offset=3 n_selections=1 selection_start=0 selection_end=3 ++++IA2_ROLE_PARAGRAPH IA2_STATE_EDITABLE ia2_hypertext='A contenteditable with a <obj1> and an <obj3> and a <obj5>.' n_selections=1 selection_start=0 selection_end=44 ++++++ROLE_SYSTEM_STATICTEXT name='A contenteditable with a ' IA2_STATE_EDITABLE ia2_hypertext='A contenteditable with a ' n_selections=1 selection_start=0 selection_end=25 ++++++ROLE_SYSTEM_LINK name='link' LINKED IA2_STATE_EDITABLE ia2_hypertext='link' n_selections=1 selection_start=0 selection_end=4
diff --git a/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-blink.txt b/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-blink.txt index daa1ea2..4bf712d1 100644 --- a/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-blink.txt +++ b/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-blink.txt
@@ -1,5 +1,5 @@ rootWebArea -++genericContainer editable multiline richlyEditable value='This is editable.<newline><newline>This is not editable.<newline>But this one is.<newline><newline>So is this one.' editableRoot=true +++genericContainer editable multiline richlyEditable value='This is editable.<newline><newline>This is not editable.<newline><newline><newline>But this one is.<newline><newline>So is this one.' editableRoot=true ++++paragraph editable richlyEditable ++++++staticText editable richlyEditable name='This is editable.' ++++++++inlineTextBox name='This is editable.'
diff --git a/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-mac.txt b/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-mac.txt index 0acdb3c6..86bf5ac1 100644 --- a/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-mac.txt +++ b/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-mac.txt
@@ -1,5 +1,5 @@ AXWebArea -++AXTextArea AXValue='This is editable.<newline><newline>This is not editable.<newline>But this one is.<newline><newline>So is this one.' +++AXTextArea AXValue='This is editable.<newline><newline>This is not editable.<newline><newline><newline>But this one is.<newline><newline>So is this one.' ++++AXGroup ++++++AXStaticText AXValue='This is editable.' ++++AXStaticText AXValue='This is not editable.'
diff --git a/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt b/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt index 4ecf5ac..a74662b 100644 --- a/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt +++ b/content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt
@@ -1,5 +1,5 @@ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0>' n_selections=0 -++IA2_ROLE_SECTION value='This is editable.<newline><newline>This is not editable.<newline>But this one is.<newline><newline>So is this one.' FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE ia2_hypertext='<obj0>This is not editable.<newline><obj3><obj4>' n_selections=0 +++IA2_ROLE_SECTION value='This is editable.<newline><newline>This is not editable.<newline><newline><newline>But this one is.<newline><newline>So is this one.' FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE ia2_hypertext='<obj0>This is not editable.<newline><obj3><obj4>' n_selections=0 ++++IA2_ROLE_PARAGRAPH IA2_STATE_EDITABLE ia2_hypertext='This is editable.' n_selections=0 ++++++ROLE_SYSTEM_STATICTEXT name='This is editable.' IA2_STATE_EDITABLE ia2_hypertext='This is editable.' n_selections=0 ++++ROLE_SYSTEM_STATICTEXT name='This is not editable.' ia2_hypertext='This is not editable.' n_selections=0
diff --git a/content/test/data/sxg/generate-test-sxgs.sh b/content/test/data/sxg/generate-test-sxgs.sh index 1a8b24a..119b54f 100755 --- a/content/test/data/sxg/generate-test-sxgs.sh +++ b/content/test/data/sxg/generate-test-sxgs.sh
@@ -14,6 +14,14 @@ fi done +dumpSignature() { + # Switch to dump-signedexchange again once it support b2 format. + # dump-signedexchange -i $1 | \ + # sed -n 's/^signature: //p' | \ + strings $1 | grep label | \ + tr -d '\n' +} + tmpdir=$(mktemp -d) sctdir=$tmpdir/scts mkdir $sctdir @@ -32,6 +40,7 @@ # Generate the signed exchange file. gen-signedexchange \ + -version 1b2 \ -uri https://test.example.org/test/ \ -status 200 \ -content test.html \ @@ -45,6 +54,7 @@ # Generate the signed exchange file with noext certificate gen-signedexchange \ + -version 1b2 \ -uri https://test.example.org/test/ \ -status 200 \ -content test.html \ @@ -58,6 +68,7 @@ # Generate the signed exchange file with invalid URL. gen-signedexchange \ + -version 1b2 \ -uri https://test.example.com/test/ \ -status 200 \ -content test.html \ @@ -71,6 +82,7 @@ # Generate the signed exchange for a plain text file. gen-signedexchange \ + -version 1b2 \ -uri https://test.example.org/hello.txt \ -status 200 \ -content hello.txt \ @@ -93,6 +105,7 @@ ../../../../net/data/ssl/certificates/wildcard.pem \ > $tmpdir/wildcard_example.org.public.pem gen-signedexchange \ + -version 1b2 \ -uri https://test.example.org/test/ \ -content test.html \ -certificate $tmpdir/wildcard_example.org.public.pem \ @@ -101,26 +114,27 @@ -o $tmpdir/out.htxg echo -n 'constexpr char kSignatureHeaderRSA[] = R"(' -dump-signedexchange -i $tmpdir/out.htxg | \ - sed -n 's/^signature: //p' | \ - tr -d '\n' +dumpSignature $tmpdir/out.htxg echo ')";' gen-signedexchange \ + -version 1b2 \ -uri https://test.example.org/test/ \ -content test.html \ -certificate ./prime256v1-sha256.public.pem \ -privateKey ./prime256v1.key \ -date 2018-02-06T04:45:41Z \ - -o $tmpdir/out.htxg + -o $tmpdir/out.htxg \ + -dumpHeadersCbor $tmpdir/out.cborheader echo -n 'constexpr char kSignatureHeaderECDSAP256[] = R"(' -dump-signedexchange -i $tmpdir/out.htxg | \ - sed -n 's/^signature: //p' | \ - tr -d '\n' +dumpSignature $tmpdir/out.htxg echo ')";' +echo 'constexpr uint8_t kCborHeaderECDSAP256[] = {' +xxd --include $tmpdir/out.cborheader | sed '1d;$d' gen-signedexchange \ + -version 1b2 \ -uri https://test.example.org/test/ \ -content test.html \ -certificate ./secp384r1-sha256.public.pem \ @@ -129,9 +143,7 @@ -o $tmpdir/out.htxg echo -n 'constexpr char kSignatureHeaderECDSAP384[] = R"(' -dump-signedexchange -i $tmpdir/out.htxg | \ - sed -n 's/^signature: //p' | \ - tr -d '\n' +dumpSignature $tmpdir/out.htxg echo ')";' echo "===="
diff --git a/content/test/data/sxg/test.example.com_invalid_test.sxg b/content/test/data/sxg/test.example.com_invalid_test.sxg index 8806861..227935d 100644 --- a/content/test/data/sxg/test.example.com_invalid_test.sxg +++ b/content/test/data/sxg/test.example.com_invalid_test.sxg Binary files differ
diff --git a/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers b/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers index c43a900..9617855 100644 --- a/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers +++ b/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers
@@ -1,2 +1,2 @@ HTTP/1.1 200 OK -Content-Type: application/signed-exchange;v=b1 +Content-Type: application/signed-exchange;v=b2
diff --git a/content/test/data/sxg/test.example.org_hello.txt.sxg b/content/test/data/sxg/test.example.org_hello.txt.sxg index 611ea70..6f729e0 100644 --- a/content/test/data/sxg/test.example.org_hello.txt.sxg +++ b/content/test/data/sxg/test.example.org_hello.txt.sxg Binary files differ
diff --git a/content/test/data/sxg/test.example.org_noext_test.sxg b/content/test/data/sxg/test.example.org_noext_test.sxg index 6ad78193..57e3e2d 100644 --- a/content/test/data/sxg/test.example.org_noext_test.sxg +++ b/content/test/data/sxg/test.example.org_noext_test.sxg Binary files differ
diff --git a/content/test/data/sxg/test.example.org_test.sxg b/content/test/data/sxg/test.example.org_test.sxg index 4d60e61..9d8d772 100644 --- a/content/test/data/sxg/test.example.org_test.sxg +++ b/content/test/data/sxg/test.example.org_test.sxg Binary files differ
diff --git a/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers b/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers index c43a900..9617855 100644 --- a/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers +++ b/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers
@@ -1,2 +1,2 @@ HTTP/1.1 200 OK -Content-Type: application/signed-exchange;v=b1 +Content-Type: application/signed-exchange;v=b2
diff --git a/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc b/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc index 661d69d..1ab3ae5 100644 --- a/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc +++ b/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc
@@ -10,6 +10,8 @@ namespace content { +namespace signed_exchange_prologue { + struct IcuEnvironment { IcuEnvironment() { CHECK(base::i18n::InitializeICU()); } // used by ICU integration. @@ -18,34 +20,56 @@ IcuEnvironment* env = new IcuEnvironment(); +std::vector<uint8_t> CopyIntoSeparateBufferToSurfaceOutOfBoundAccess( + base::span<const uint8_t> data) { + return std::vector<uint8_t>(data.begin(), data.end()); +} + extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { - if (size < SignedExchangePrologue::kEncodedPrologueInBytes) + if (size < BeforeFallbackUrl::kEncodedSizeInBytes) return 0; - auto prologue_bytes = - base::make_span(data, SignedExchangePrologue::kEncodedPrologueInBytes); - base::Optional<SignedExchangePrologue> prologue = - SignedExchangePrologue::Parse(prologue_bytes, - nullptr /* devtools_proxy */); - if (!prologue) + auto before_fallback_url_bytes = + CopyIntoSeparateBufferToSurfaceOutOfBoundAccess( + base::make_span(data, BeforeFallbackUrl::kEncodedSizeInBytes)); + auto before_fallback_url = BeforeFallbackUrl::Parse( + base::make_span(before_fallback_url_bytes), nullptr /* devtools_proxy */); + + data += BeforeFallbackUrl::kEncodedSizeInBytes; + size -= BeforeFallbackUrl::kEncodedSizeInBytes; + + size_t fallback_url_and_after_length = + before_fallback_url.ComputeFallbackUrlAndAfterLength(); + if (size < fallback_url_and_after_length) return 0; - data += SignedExchangePrologue::kEncodedPrologueInBytes; - size -= SignedExchangePrologue::kEncodedPrologueInBytes; + auto fallback_url_and_after_bytes = + CopyIntoSeparateBufferToSurfaceOutOfBoundAccess( + base::make_span(data, fallback_url_and_after_length)); + auto fallback_url_and_after = FallbackUrlAndAfter::Parse( + base::make_span(fallback_url_and_after_bytes), before_fallback_url, + nullptr /* devtools_proxy */); + if (!fallback_url_and_after.is_valid()) + return 0; - // Copy the headers into separate buffers so that out-of-bounds access can be - // detected. + data += fallback_url_and_after_length; + size -= fallback_url_and_after_length; + std::string signature_header_field( reinterpret_cast<const char*>(data), - std::min(size, prologue->signature_header_field_length())); + std::min(size, fallback_url_and_after.signature_header_field_length())); data += signature_header_field.size(); size -= signature_header_field.size(); - std::vector<uint8_t> cbor_header( - data, data + std::min(size, prologue->cbor_header_length())); - SignedExchangeEnvelope::Parse(signature_header_field, - base::make_span(cbor_header), - nullptr /* devtools_proxy */); + auto cbor_header = + CopyIntoSeparateBufferToSurfaceOutOfBoundAccess(base::make_span( + data, std::min(size, fallback_url_and_after.cbor_header_length()))); + + SignedExchangeEnvelope::Parse( + fallback_url_and_after.fallback_url(), signature_header_field, + base::make_span(cbor_header), nullptr /* devtools_proxy */); return 0; } +} // namespace signed_exchange_prologue + } // namespace content
diff --git a/device/fido/device_operation.h b/device/fido/device_operation.h index 79b907b..7579963 100644 --- a/device/fido/device_operation.h +++ b/device/fido/device_operation.h
@@ -10,9 +10,11 @@ #include <utility> #include <vector> +#include "base/bind.h" #include "base/callback.h" #include "base/macros.h" #include "base/optional.h" +#include "base/threading/sequenced_task_runner_handle.h" #include "device/fido/fido_constants.h" #include "device/fido/fido_device.h" @@ -39,8 +41,9 @@ // TODO(hongjunchoi): Refactor so that |command| is never base::nullopt. void DispatchDeviceRequest(base::Optional<std::vector<uint8_t>> command, FidoDevice::DeviceCallback callback) { - if (!command) { - std::move(callback).Run(base::nullopt); + if (!command || device_->state() == FidoDevice::State::kDeviceError) { + base::SequencedTaskRunnerHandle::Get()->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), base::nullopt)); return; }
diff --git a/device/fido/fido_device.cc b/device/fido/fido_device.cc index e3f448c..b9b3001 100644 --- a/device/fido/fido_device.cc +++ b/device/fido/fido_device.cc
@@ -42,6 +42,10 @@ void FidoDevice::OnDeviceInfoReceived( base::OnceClosure done, base::Optional<std::vector<uint8_t>> response) { + // TODO(hongjunchoi): Add tests that verify this behavior. + if (state_ == FidoDevice::State::kDeviceError) + return; + state_ = FidoDevice::State::kReady; base::Optional<AuthenticatorGetInfoResponse> get_info_response =
diff --git a/device/fido/hid/fido_hid_device.cc b/device/fido/hid/fido_hid_device.cc index 0f1abc5..3baed2134 100644 --- a/device/fido/hid/fido_hid_device.cc +++ b/device/fido/hid/fido_hid_device.cc
@@ -217,6 +217,7 @@ void FidoHidDevice::ReadMessage(HidMessageCallback callback) { if (!connection_) { + state_ = State::kDeviceError; std::move(callback).Run(base::nullopt); return; } @@ -230,6 +231,7 @@ uint8_t report_id, const base::Optional<std::vector<uint8_t>>& buf) { if (!success) { + state_ = State::kDeviceError; std::move(callback).Run(base::nullopt); return; } @@ -267,6 +269,7 @@ uint8_t report_id, const base::Optional<std::vector<uint8_t>>& buf) { if (!success) { + state_ = State::kDeviceError; std::move(callback).Run(base::nullopt); return; }
diff --git a/gpu/BUILD.gn b/gpu/BUILD.gn index 2b9f9e2..51ab0be 100644 --- a/gpu/BUILD.gn +++ b/gpu/BUILD.gn
@@ -23,6 +23,10 @@ defines = [ "RASTER_IMPLEMENTATION" ] } +config("webgpu_implementation") { + defines = [ "WEBGPU_IMPLEMENTATION" ] +} + component("gpu") { public_deps = [ "//gpu/command_buffer/client:client_sources", @@ -49,6 +53,12 @@ ] } +component("webgpu") { + public_deps = [ + "//gpu/command_buffer/client:webgpu_sources", + ] +} + if (!use_static_angle) { shared_library("command_buffer_gles2") { sources = [ @@ -148,11 +158,14 @@ "ipc/raster_in_process_context.cc", "ipc/raster_in_process_context.h", "ipc/service/gpu_memory_buffer_factory_test_template.h", + "ipc/webgpu_in_process_context.cc", + "ipc/webgpu_in_process_context.h", ] public_deps = [ ":gles2", ":gpu", + ":webgpu", "//gpu/command_buffer/client:gles2_interface", ] deps = [ @@ -229,6 +242,7 @@ "ipc/client/gpu_context_tests.h", "ipc/client/gpu_in_process_context_tests.cc", "ipc/client/raster_in_process_context_tests.cc", + "ipc/client/webgpu_in_process_context_tests.cc", "ipc/service/direct_composition_surface_win_unittest.cc", ] @@ -248,6 +262,7 @@ "//gpu/command_buffer/client:gles2_c_lib", "//gpu/command_buffer/client:gles2_implementation", "//gpu/command_buffer/client:raster", + "//gpu/command_buffer/client:webgpu", "//gpu/command_buffer/common:gles2_utils", "//gpu/ipc:gl_in_process_context", "//gpu/ipc/host", @@ -286,6 +301,7 @@ "command_buffer/client/command_buffer_direct_locked.h", "command_buffer/client/fenced_allocator_test.cc", "command_buffer/client/gles2_implementation_unittest.cc", + "command_buffer/client/gles2_implementation_unittest_autogen.h", "command_buffer/client/mapped_memory_unittest.cc", "command_buffer/client/mock_transfer_buffer.cc", "command_buffer/client/mock_transfer_buffer.h", @@ -293,9 +309,12 @@ "command_buffer/client/query_tracker_unittest.cc", "command_buffer/client/raster_implementation_gles_unittest.cc", "command_buffer/client/raster_implementation_unittest.cc", + "command_buffer/client/raster_implementation_unittest_autogen.h", "command_buffer/client/ring_buffer_test.cc", "command_buffer/client/transfer_buffer_unittest.cc", "command_buffer/client/vertex_array_object_manager_unittest.cc", + "command_buffer/client/webgpu_implementation_unittest.cc", + "command_buffer/client/webgpu_implementation_unittest_autogen.h", "command_buffer/common/activity_flags_unittest.cc", "command_buffer/common/bitfield_helpers_test.cc", "command_buffer/common/buffer_unittest.cc", @@ -310,6 +329,8 @@ "command_buffer/common/raster_cmd_format_test.cc", "command_buffer/common/raster_cmd_format_test_autogen.h", "command_buffer/common/unittest_main.cc", + "command_buffer/common/webgpu_cmd_format_test.cc", + "command_buffer/common/webgpu_cmd_format_test_autogen.h", "command_buffer/service/buffer_manager_unittest.cc", "command_buffer/service/client_service_map_unittest.cc", "command_buffer/service/command_buffer_service_unittest.cc", @@ -382,6 +403,7 @@ "command_buffer/service/transform_feedback_manager_unittest.cc", "command_buffer/service/vertex_array_manager_unittest.cc", "command_buffer/service/vertex_attrib_manager_unittest.cc", + "command_buffer/service/webgpu_decoder_unittest.cc", "config/gpu_blacklist_unittest.cc", "config/gpu_control_list_entry_unittest.cc", "config/gpu_control_list_testing_arrays_and_structs_autogen.h", @@ -465,6 +487,7 @@ "//gpu/command_buffer/client:gles2_c_lib", "//gpu/command_buffer/client:gles2_implementation", "//gpu/command_buffer/client:raster", + "//gpu/command_buffer/client:webgpu", "//gpu/command_buffer/common", "//gpu/command_buffer/common:gles2_utils", "//gpu/command_buffer/service",
diff --git a/gpu/command_buffer/build_cmd_buffer_lib.py b/gpu/command_buffer/build_cmd_buffer_lib.py index b033bac..caf5cfa 100644 --- a/gpu/command_buffer/build_cmd_buffer_lib.py +++ b/gpu/command_buffer/build_cmd_buffer_lib.py
@@ -1410,8 +1410,8 @@ if len(func.GetOriginalArgs()): comma = " << " f.write( - ' GPU_CLIENT_LOG("[" << GetLogPrefix() << "] gl%s("%s%s << ")");\n' % - (func.original_name, comma, func.MakeLogArgString())) + ' GPU_CLIENT_LOG("[" << GetLogPrefix() << "] %s("%s%s << ")");\n' % + (func.prefixed_name, comma, func.MakeLogArgString())) def WriteClientGLReturnLog(self, func, f): """Writes the return value logging code.""" @@ -1457,7 +1457,8 @@ arg.WriteClientSideValidationCode(f, func) f.write(" helper_->%s(%s);\n" % (func.name, func.MakeHelperArgString(""))) - f.write(" CheckGLError();\n") + if _prefix != 'WebGPU': + f.write(" CheckGLError();\n") self.WriteClientGLReturnLog(func, f) f.write("}\n") f.write("\n") @@ -5599,6 +5600,7 @@ self.name = name self.named_type_info = named_type_info + self.prefixed_name = info['prefixed_name'] self.original_name = info['original_name'] self.original_args = self.ParseArgs(info['original_args']) @@ -6387,12 +6389,14 @@ continue match = self._function_re.match(line) if match: - func_name = match.group(2)[2:] + prefixed_name = match.group(2) + func_name = prefixed_name[2:] func_info = self.GetFunctionInfo(func_name) if func_info['type'] == 'Noop': continue parsed_func_info = { + 'prefixed_name': prefixed_name, 'original_name': func_name, 'original_args': match.group(3), 'return_type': match.group(1).strip(), @@ -6492,7 +6496,7 @@ def WriteFormatTest(self, filename): """Writes the command buffer format test.""" - comment = ("// This file contains unit tests for %s commmands\n" + comment = ("// This file contains unit tests for %s commands\n" "// It is included by %s_cmd_format_test.cc\n\n" % (_lower_prefix, _lower_prefix)) with CHeaderWriter(filename, self.year, comment) as f: @@ -6870,7 +6874,7 @@ with CHeaderWriter(filename, self.year, comment) as f: for func in self.functions: func.WriteServiceImplementation(f) - if self.capability_flags and _prefix != 'Raster': + if self.capability_flags and _prefix == 'GLES2': f.write(""" bool GLES2DecoderImpl::SetCapabilityState(GLenum cap, bool enabled) { switch (cap) { @@ -7292,7 +7296,7 @@ f.write(" {\n"); f.write("}\n\n"); - if _prefix != 'Raster': + if _prefix == 'GLES2': f.write("void Validators::UpdateValuesES3() {\n") for name in names: named_type = NamedType(self.named_type_info[name])
diff --git a/gpu/command_buffer/build_webgpu_cmd_buffer.py b/gpu/command_buffer/build_webgpu_cmd_buffer.py new file mode 100755 index 0000000..76b2a6f --- /dev/null +++ b/gpu/command_buffer/build_webgpu_cmd_buffer.py
@@ -0,0 +1,94 @@ +#!/usr/bin/env python +# Copyright 2018 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""code generator for webgpu command buffers.""" + +import os +import os.path +import sys +from optparse import OptionParser + +import build_cmd_buffer_lib + +# Named type info object represents a named type that is used in API call +# arguments. The named types are used in 'webgpu_cmd_buffer_functions.txt'. +# +# Options are documented in build_gles2_cmd_buffer.py/build_raster_cmd_buffer.py +_NAMED_TYPE_INFO = { +} + +# A function info object specifies the type and other special data for the +# command that will be generated. A base function info object is generated by +# parsing the "webgpu_cmd_buffer_functions.txt", one for each function in the +# file. These function info objects can be augmented and their values can be +# overridden by adding an object to the table below. +# +# Must match function names specified in "webgpu_cmd_buffer_functions.txt". +# +# Options are documented in build_gles2_cmd_buffer.py/build_raster_cmd_buffer.py +_FUNCTION_INFO = { + 'NoOp': { + 'decoder_func': 'DoNoOp', + 'unit_test': False, + }, +} + + +def main(argv): + """This is the main function.""" + parser = OptionParser() + parser.add_option( + "--output-dir", + help="base directory for resulting files, under chrome/src. default is " + "empty. Use this if you want the result stored under gen.") + parser.add_option( + "-v", "--verbose", action="store_true", + help="prints more output.") + + (options, _) = parser.parse_args(args=argv) + + # This script lives under gpu/command_buffer, cd to base directory. + os.chdir(os.path.dirname(__file__) + "/../..") + base_dir = os.getcwd() + build_cmd_buffer_lib.InitializePrefix("WebGPU") + gen = build_cmd_buffer_lib.GLGenerator(options.verbose, "2018", + _FUNCTION_INFO, _NAMED_TYPE_INFO) + gen.ParseGLH("gpu/command_buffer/webgpu_cmd_buffer_functions.txt") + + # Support generating files under gen/ + if options.output_dir != None: + os.chdir(options.output_dir) + + os.chdir(base_dir) + + gen.WriteCommandIds("gpu/command_buffer/common/webgpu_cmd_ids_autogen.h") + gen.WriteFormat("gpu/command_buffer/common/webgpu_cmd_format_autogen.h") + gen.WriteFormatTest( + "gpu/command_buffer/common/webgpu_cmd_format_test_autogen.h") + gen.WriteGLES2InterfaceHeader( + "gpu/command_buffer/client/webgpu_interface_autogen.h") + gen.WriteGLES2ImplementationHeader( + "gpu/command_buffer/client/webgpu_implementation_autogen.h") + gen.WriteGLES2Implementation( + "gpu/command_buffer/client/webgpu_implementation_impl_autogen.h") + gen.WriteGLES2ImplementationUnitTests( + "gpu/command_buffer/client/webgpu_implementation_unittest_autogen.h") + gen.WriteCmdHelperHeader( + "gpu/command_buffer/client/webgpu_cmd_helper_autogen.h") + gen.WriteServiceUtilsHeader( + "gpu/command_buffer/service/webgpu_cmd_validation_autogen.h") + gen.WriteServiceUtilsImplementation( + "gpu/command_buffer/service/" + "webgpu_cmd_validation_implementation_autogen.h") + + build_cmd_buffer_lib.Format(gen.generated_cpp_filenames) + + if gen.errors > 0: + print "%d errors" % gen.errors + return 1 + return 0 + + +if __name__ == '__main__': + sys.exit(main(sys.argv[1:]))
diff --git a/gpu/command_buffer/client/BUILD.gn b/gpu/command_buffer/client/BUILD.gn index 00be50c..86708c0 100644 --- a/gpu/command_buffer/client/BUILD.gn +++ b/gpu/command_buffer/client/BUILD.gn
@@ -41,6 +41,18 @@ } } +group("webgpu") { + if (is_component_build) { + public_deps = [ + "//gpu:webgpu", + ] + } else { + public_deps = [ + ":webgpu_sources", + ] + } +} + source_set("client_sources") { # External code should depend on this via //gpu/client above rather than # depending on this directly or the component build will break. @@ -161,6 +173,7 @@ source_set("raster_interface") { sources = [ "raster_interface.h", + "raster_interface_autogen.h", ] public_configs = [ "//third_party/khronos:khronos_headers" ] deps = [ @@ -170,6 +183,16 @@ ] } +source_set("webgpu_interface") { + sources = [ + "webgpu_interface.h", + "webgpu_interface_autogen.h", + ] + deps = [ + "//base", + ] +} + # Library emulates GLES2 using command_buffers. component("gles2_implementation") { sources = gles2_implementation_source_files @@ -235,6 +258,28 @@ ] } +source_set("webgpu_sources") { + visibility = [ "//gpu/*" ] + + configs += [ "//gpu:webgpu_implementation" ] + deps = [ + ":client", + ":gles2_implementation", + ":webgpu_interface", + "//gpu/command_buffer/common:webgpu", + ] + sources = [ + "webgpu_cmd_helper.cc", + "webgpu_cmd_helper.h", + "webgpu_cmd_helper_autogen.h", + "webgpu_export.h", + "webgpu_implementation.cc", + "webgpu_implementation.h", + "webgpu_implementation_autogen.h", + "webgpu_implementation_impl_autogen.h", + ] +} + # Library emulates GLES2 using command_buffers. component("gles2_implementation_no_check") { sources = gles2_implementation_source_files
diff --git a/gpu/command_buffer/client/webgpu_cmd_helper.cc b/gpu/command_buffer/client/webgpu_cmd_helper.cc new file mode 100644 index 0000000..e306d38 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_cmd_helper.cc
@@ -0,0 +1,16 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gpu/command_buffer/client/webgpu_cmd_helper.h" + +namespace gpu { +namespace webgpu { + +WebGPUCmdHelper::WebGPUCmdHelper(CommandBuffer* command_buffer) + : CommandBufferHelper(command_buffer) {} + +WebGPUCmdHelper::~WebGPUCmdHelper() = default; + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/client/webgpu_cmd_helper.h b/gpu/command_buffer/client/webgpu_cmd_helper.h new file mode 100644 index 0000000..6a2390a --- /dev/null +++ b/gpu/command_buffer/client/webgpu_cmd_helper.h
@@ -0,0 +1,36 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_CMD_HELPER_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_CMD_HELPER_H_ + +#include <stdint.h> + +#include "base/macros.h" +#include "gpu/command_buffer/client/cmd_buffer_helper.h" +#include "gpu/command_buffer/client/webgpu_export.h" +#include "gpu/command_buffer/common/webgpu_cmd_format.h" + +namespace gpu { +namespace webgpu { + +// A class that helps write GL command buffers. +class WEBGPU_EXPORT WebGPUCmdHelper : public CommandBufferHelper { + public: + explicit WebGPUCmdHelper(CommandBuffer* command_buffer); + ~WebGPUCmdHelper() override; + +// Include the auto-generated part of this class. We split this because it +// means we can easily edit the non-auto generated parts right here in this +// file instead of having to edit some template or the code generator. +#include "gpu/command_buffer/client/webgpu_cmd_helper_autogen.h" + + private: + DISALLOW_COPY_AND_ASSIGN(WebGPUCmdHelper); +}; + +} // namespace webgpu +} // namespace gpu + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_CMD_HELPER_H_
diff --git a/gpu/command_buffer/client/webgpu_cmd_helper_autogen.h b/gpu/command_buffer/client/webgpu_cmd_helper_autogen.h new file mode 100644 index 0000000..477a9f7 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_cmd_helper_autogen.h
@@ -0,0 +1,21 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_CMD_HELPER_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_CMD_HELPER_AUTOGEN_H_ + +void Dummy() { + webgpu::cmds::Dummy* c = GetCmdSpace<webgpu::cmds::Dummy>(); + if (c) { + c->Init(); + } +} + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_CMD_HELPER_AUTOGEN_H_
diff --git a/gpu/command_buffer/client/webgpu_export.h b/gpu/command_buffer/client/webgpu_export.h new file mode 100644 index 0000000..ce53a67 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_export.h
@@ -0,0 +1,29 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_EXPORT_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_EXPORT_H_ + +#if defined(COMPONENT_BUILD) && !defined(NACL_WIN64) +#if defined(WIN32) + +#if defined(WEBGPU_IMPLEMENTATION) +#define WEBGPU_EXPORT __declspec(dllexport) +#else +#define WEBGPU_EXPORT __declspec(dllimport) +#endif // defined(WEBGPU_IMPLEMENTATION) + +#else // defined(WIN32) +#if defined(WEBGPU_IMPLEMENTATION) +#define WEBGPU_EXPORT __attribute__((visibility("default"))) +#else +#define WEBGPU_EXPORT +#endif +#endif + +#else // defined(COMPONENT_BUILD) +#define WEBGPU_EXPORT +#endif + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_EXPORT_H_
diff --git a/gpu/command_buffer/client/webgpu_implementation.cc b/gpu/command_buffer/client/webgpu_implementation.cc new file mode 100644 index 0000000..ff1c356 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_implementation.cc
@@ -0,0 +1,18 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gpu/command_buffer/client/webgpu_implementation.h" + +#define GPU_CLIENT_SINGLE_THREAD_CHECK() + +namespace gpu { +namespace webgpu { + +// Include the auto-generated part of this file. We split this because it means +// we can easily edit the non-auto generated parts right here in this file +// instead of having to edit some template or the code generator. +#include "gpu/command_buffer/client/webgpu_implementation_impl_autogen.h" + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/client/webgpu_implementation.h b/gpu/command_buffer/client/webgpu_implementation.h new file mode 100644 index 0000000..3363ea0 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_implementation.h
@@ -0,0 +1,40 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_H_ + +#include "gpu/command_buffer/client/implementation_base.h" +#include "gpu/command_buffer/client/logging.h" +#include "gpu/command_buffer/client/webgpu_cmd_helper.h" +#include "gpu/command_buffer/client/webgpu_export.h" +#include "gpu/command_buffer/client/webgpu_interface.h" + +namespace gpu { +namespace webgpu { + +class WEBGPU_EXPORT WebGPUImplementation final : public WebGPUInterface { + public: + explicit WebGPUImplementation(WebGPUCmdHelper* helper) : helper_(helper) {} + ~WebGPUImplementation() override {} + +// Include the auto-generated part of this class. We split this because +// it means we can easily edit the non-auto generated parts right here in +// this file instead of having to edit some template or the code generator. +#include "gpu/command_buffer/client/webgpu_implementation_autogen.h" + + private: + const std::string& GetLogPrefix() const { + static const std::string prefix = "webgpu"; + return prefix; + } + + WebGPUCmdHelper* helper_; + LogSettings log_settings_; +}; + +} // namespace webgpu +} // namespace gpu + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_H_
diff --git a/gpu/command_buffer/client/webgpu_implementation_autogen.h b/gpu/command_buffer/client/webgpu_implementation_autogen.h new file mode 100644 index 0000000..2f9ed13c --- /dev/null +++ b/gpu/command_buffer/client/webgpu_implementation_autogen.h
@@ -0,0 +1,18 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +// This file is included by webgpu_implementation.h to declare the +// GL api functions. +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_AUTOGEN_H_ + +void Dummy() override; + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_AUTOGEN_H_
diff --git a/gpu/command_buffer/client/webgpu_implementation_impl_autogen.h b/gpu/command_buffer/client/webgpu_implementation_impl_autogen.h new file mode 100644 index 0000000..b260cfb --- /dev/null +++ b/gpu/command_buffer/client/webgpu_implementation_impl_autogen.h
@@ -0,0 +1,23 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +// This file is included by webgpu_implementation.cc to define the +// GL api functions. +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_IMPL_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_IMPL_AUTOGEN_H_ + +void WebGPUImplementation::Dummy() { + GPU_CLIENT_SINGLE_THREAD_CHECK(); + GPU_CLIENT_LOG("[" << GetLogPrefix() << "] wgDummy(" + << ")"); + helper_->Dummy(); +} + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_IMPL_AUTOGEN_H_
diff --git a/gpu/command_buffer/client/webgpu_implementation_unittest.cc b/gpu/command_buffer/client/webgpu_implementation_unittest.cc new file mode 100644 index 0000000..384b0fe --- /dev/null +++ b/gpu/command_buffer/client/webgpu_implementation_unittest.cc
@@ -0,0 +1,114 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Tests for WebGPUImplementation. + +#include "gpu/command_buffer/client/webgpu_implementation.h" + +#include "gpu/command_buffer/client/client_test_helper.h" +#include "gpu/command_buffer/client/mock_transfer_buffer.h" +#include "gpu/command_buffer/client/shared_memory_limits.h" +#include "gpu/command_buffer/client/webgpu_cmd_helper.h" +#include "testing/gmock/include/gmock/gmock.h" +#include "testing/gtest/include/gtest/gtest.h" + +using testing::_; +using testing::AtLeast; +using testing::AnyNumber; +using testing::DoAll; +using testing::InSequence; +using testing::Invoke; +using testing::Mock; +using testing::Sequence; +using testing::StrictMock; +using testing::Return; +using testing::ReturnRef; + +namespace gpu { +namespace webgpu { + +class WebGPUImplementationTest : public testing::Test { + protected: + static const uint8_t kInitialValue = 0xBD; + static const int32_t kNumCommandEntries = 500; + static const int32_t kCommandBufferSizeBytes = + kNumCommandEntries * sizeof(CommandBufferEntry); + static const size_t kTransferBufferSize = 512; + + static const GLint kMaxCombinedTextureImageUnits = 8; + static const GLint kMaxTextureImageUnits = 8; + static const GLint kMaxTextureSize = 128; + static const GLint kNumCompressedTextureFormats = 0; + + WebGPUImplementationTest() {} + + bool Initialize() { + SharedMemoryLimits limits = SharedMemoryLimitsForTesting(); + command_buffer_.reset(new StrictMock<MockClientCommandBuffer>()); + + transfer_buffer_.reset( + new MockTransferBuffer(command_buffer_.get(), kTransferBufferSize, + ImplementationBase::kStartingOffset, + ImplementationBase::kAlignment, false)); + + helper_.reset(new WebGPUCmdHelper(command_buffer_.get())); + helper_->Initialize(limits.command_buffer_size); + + { + InSequence sequence; + + gl_.reset(new WebGPUImplementation(helper_.get())); + } + + helper_->CommandBufferHelper::Finish(); + Mock::VerifyAndClearExpectations(gl_.get()); + + scoped_refptr<Buffer> ring_buffer = helper_->get_ring_buffer(); + commands_ = static_cast<CommandBufferEntry*>(ring_buffer->memory()) + + command_buffer_->GetServicePutOffset(); + ClearCommands(); + EXPECT_TRUE(transfer_buffer_->InSync()); + + Mock::VerifyAndClearExpectations(command_buffer_.get()); + return true; + } + + void ClearCommands() { + scoped_refptr<Buffer> ring_buffer = helper_->get_ring_buffer(); + memset(ring_buffer->memory(), kInitialValue, ring_buffer->size()); + } + + void SetUp() override { ASSERT_TRUE(Initialize()); } + + void TearDown() override { + Mock::VerifyAndClear(gl_.get()); + EXPECT_CALL(*command_buffer_, OnFlush()).Times(AnyNumber()); + // For command buffer. + EXPECT_CALL(*command_buffer_, DestroyTransferBuffer(_)).Times(AtLeast(1)); + // The client should be unset. + gl_.reset(); + } + + static SharedMemoryLimits SharedMemoryLimitsForTesting() { + SharedMemoryLimits limits; + limits.command_buffer_size = kCommandBufferSizeBytes; + limits.start_transfer_buffer_size = kTransferBufferSize; + limits.min_transfer_buffer_size = kTransferBufferSize; + limits.max_transfer_buffer_size = kTransferBufferSize; + limits.mapped_memory_reclaim_limit = SharedMemoryLimits::kNoLimit; + return limits; + } + + std::unique_ptr<MockClientCommandBuffer> command_buffer_; + std::unique_ptr<WebGPUCmdHelper> helper_; + std::unique_ptr<MockTransferBuffer> transfer_buffer_; + std::unique_ptr<WebGPUImplementation> gl_; + CommandBufferEntry* commands_ = nullptr; +}; + +#include "base/macros.h" +#include "gpu/command_buffer/client/webgpu_implementation_unittest_autogen.h" + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/client/webgpu_implementation_unittest_autogen.h b/gpu/command_buffer/client/webgpu_implementation_unittest_autogen.h new file mode 100644 index 0000000..d5b79cd1 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_implementation_unittest_autogen.h
@@ -0,0 +1,26 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +// This file is included by webgpu_implementation.h to declare the +// GL api functions. +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_UNITTEST_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_UNITTEST_AUTOGEN_H_ + +TEST_F(WebGPUImplementationTest, Dummy) { + struct Cmds { + cmds::Dummy cmd; + }; + Cmds expected; + expected.cmd.Init(); + + gl_->Dummy(); + EXPECT_EQ(0, memcmp(&expected, commands_, sizeof(expected))); +} +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_IMPLEMENTATION_UNITTEST_AUTOGEN_H_
diff --git a/gpu/command_buffer/client/webgpu_interface.h b/gpu/command_buffer/client/webgpu_interface.h new file mode 100644 index 0000000..4360ac32 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_interface.h
@@ -0,0 +1,28 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_INTERFACE_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_INTERFACE_H_ + +extern "C" typedef struct _ClientBuffer* ClientBuffer; +extern "C" typedef struct _GLColorSpace* GLColorSpace; + +namespace gpu { +namespace webgpu { + +class WebGPUInterface { + public: + WebGPUInterface() {} + virtual ~WebGPUInterface() {} + +// Include the auto-generated part of this class. We split this because +// it means we can easily edit the non-auto generated parts right here in +// this file instead of having to edit some template or the code generator. +#include "gpu/command_buffer/client/webgpu_interface_autogen.h" +}; + +} // namespace webgpu +} // namespace gpu + +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_INTERFACE_H_
diff --git a/gpu/command_buffer/client/webgpu_interface_autogen.h b/gpu/command_buffer/client/webgpu_interface_autogen.h new file mode 100644 index 0000000..52ecc28 --- /dev/null +++ b/gpu/command_buffer/client/webgpu_interface_autogen.h
@@ -0,0 +1,17 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +// This file is included by webgpu_interface.h to declare the +// GL api functions. +#ifndef GPU_COMMAND_BUFFER_CLIENT_WEBGPU_INTERFACE_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_CLIENT_WEBGPU_INTERFACE_AUTOGEN_H_ + +virtual void Dummy() = 0; +#endif // GPU_COMMAND_BUFFER_CLIENT_WEBGPU_INTERFACE_AUTOGEN_H_
diff --git a/gpu/command_buffer/common/BUILD.gn b/gpu/command_buffer/common/BUILD.gn index 9eb6780..7489cbf8 100644 --- a/gpu/command_buffer/common/BUILD.gn +++ b/gpu/command_buffer/common/BUILD.gn
@@ -43,6 +43,12 @@ } } +group("webgpu") { + public_deps = [ + ":webgpu_sources", + ] +} + source_set("common_sources") { visibility = [ "//gpu/*" ] @@ -156,6 +162,28 @@ ] } +source_set("webgpu_sources") { + visibility = [ "//gpu/*" ] + + sources = [ + "webgpu_cmd_format.cc", + "webgpu_cmd_format.h", + "webgpu_cmd_format_autogen.h", + "webgpu_cmd_ids.h", + "webgpu_cmd_ids_autogen.h", + ] + + configs += [ "//gpu:webgpu_implementation" ] + + deps = [ + ":gles2_utils", + "//base", + ] + public_deps = [ + ":common", + ] +} + component("gles2_utils") { sources = [ "gles2_cmd_utils.cc",
diff --git a/gpu/command_buffer/common/context_creation_attribs.cc b/gpu/command_buffer/common/context_creation_attribs.cc index 90414ef..fdedf7f 100644 --- a/gpu/command_buffer/common/context_creation_attribs.cc +++ b/gpu/command_buffer/common/context_creation_attribs.cc
@@ -8,6 +8,23 @@ namespace gpu { +bool IsGLContextType(ContextType context_type) { + // Switch statement to cause a compile-time error if we miss a case. + switch (context_type) { + case CONTEXT_TYPE_OPENGLES2: + case CONTEXT_TYPE_OPENGLES3: + case CONTEXT_TYPE_WEBGL1: + case CONTEXT_TYPE_WEBGL2: + case CONTEXT_TYPE_WEBGL2_COMPUTE: + return true; + case CONTEXT_TYPE_WEBGPU: + return false; + } + + NOTREACHED(); + return false; +} + bool IsWebGLContextType(ContextType context_type) { // Switch statement to cause a compile-time error if we miss a case. switch (context_type) { @@ -17,6 +34,7 @@ return true; case CONTEXT_TYPE_OPENGLES2: case CONTEXT_TYPE_OPENGLES3: + case CONTEXT_TYPE_WEBGPU: return false; } @@ -33,6 +51,7 @@ case CONTEXT_TYPE_WEBGL2: case CONTEXT_TYPE_OPENGLES3: case CONTEXT_TYPE_WEBGL2_COMPUTE: + case CONTEXT_TYPE_WEBGPU: return false; } @@ -49,6 +68,7 @@ case CONTEXT_TYPE_WEBGL1: case CONTEXT_TYPE_OPENGLES2: case CONTEXT_TYPE_WEBGL2_COMPUTE: + case CONTEXT_TYPE_WEBGPU: return false; } @@ -65,6 +85,7 @@ return true; case CONTEXT_TYPE_WEBGL1: case CONTEXT_TYPE_OPENGLES2: + case CONTEXT_TYPE_WEBGPU: return false; } @@ -81,6 +102,24 @@ case CONTEXT_TYPE_WEBGL2: case CONTEXT_TYPE_WEBGL1: case CONTEXT_TYPE_OPENGLES2: + case CONTEXT_TYPE_WEBGPU: + return false; + } + + NOTREACHED(); + return false; +} + +bool IsWebGPUContextType(ContextType context_type) { + // Switch statement to cause a compile-time error if we miss a case. + switch (context_type) { + case CONTEXT_TYPE_WEBGPU: + return true; + case CONTEXT_TYPE_OPENGLES2: + case CONTEXT_TYPE_OPENGLES3: + case CONTEXT_TYPE_WEBGL1: + case CONTEXT_TYPE_WEBGL2: + case CONTEXT_TYPE_WEBGL2_COMPUTE: return false; }
diff --git a/gpu/command_buffer/common/context_creation_attribs.h b/gpu/command_buffer/common/context_creation_attribs.h index 3965fe9..ed03f15 100644 --- a/gpu/command_buffer/common/context_creation_attribs.h +++ b/gpu/command_buffer/common/context_creation_attribs.h
@@ -19,14 +19,17 @@ CONTEXT_TYPE_WEBGL2_COMPUTE, CONTEXT_TYPE_OPENGLES2, CONTEXT_TYPE_OPENGLES3, - CONTEXT_TYPE_LAST = CONTEXT_TYPE_OPENGLES3 + CONTEXT_TYPE_WEBGPU, + CONTEXT_TYPE_LAST = CONTEXT_TYPE_WEBGPU }; +GPU_EXPORT bool IsGLContextType(ContextType context_type); GPU_EXPORT bool IsWebGLContextType(ContextType context_type); GPU_EXPORT bool IsWebGL1OrES2ContextType(ContextType context_type); GPU_EXPORT bool IsWebGL2OrES3ContextType(ContextType context_type); GPU_EXPORT bool IsWebGL2OrES3OrHigherContextType(ContextType context_type); GPU_EXPORT bool IsWebGL2ComputeContextType(ContextType context_type); +GPU_EXPORT bool IsWebGPUContextType(ContextType context_type); enum ColorSpace { COLOR_SPACE_UNSPECIFIED,
diff --git a/gpu/command_buffer/common/raster_cmd_format.h b/gpu/command_buffer/common/raster_cmd_format.h index f9cc039..3e7a7e1 100644 --- a/gpu/command_buffer/common/raster_cmd_format.h +++ b/gpu/command_buffer/common/raster_cmd_format.h
@@ -27,12 +27,6 @@ namespace gpu { namespace raster { -// Command buffer is GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT byte aligned. -#pragma pack(push, 4) -static_assert(GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT == 4, - "pragma pack alignment must be equal to " - "GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT"); - namespace id_namespaces { enum class IdNamespaces { kQueries, kTextures }; @@ -41,11 +35,15 @@ namespace cmds { +// Command buffer is GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT byte aligned. +#pragma pack(push, 4) +static_assert(GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT == 4, + "pragma pack alignment must be equal to " + "GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT"); #include "gpu/command_buffer/common/raster_cmd_format_autogen.h" - #pragma pack(pop) -} // namespace cmd +} // namespace cmds } // namespace raster } // namespace gpu
diff --git a/gpu/command_buffer/common/webgpu_cmd_format.cc b/gpu/command_buffer/common/webgpu_cmd_format.cc new file mode 100644 index 0000000..73e21dcf --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_format.cc
@@ -0,0 +1,32 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file contains the binary format definition of the command buffer and +// command buffer commands. + +// We explicitly do NOT include webgpu_cmd_format.h here because client side +// and service side have different requirements. +#include "base/stl_util.h" +#include "gpu/command_buffer/common/cmd_buffer_common.h" + +namespace gpu { +namespace webgpu { + +#include "gpu/command_buffer/common/webgpu_cmd_ids_autogen.h" + +const char* GetCommandName(CommandId id) { + static const char* const names[] = { +#define WEBGPU_CMD_OP(name) "k" #name, + + WEBGPU_COMMAND_LIST(WEBGPU_CMD_OP) + +#undef WEBGPU_CMD_OP + }; + + size_t index = static_cast<size_t>(id) - kFirstWebGPUCommand; + return (index < base::size(names)) ? names[index] : "*unknown-command*"; +} + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/common/webgpu_cmd_format.h b/gpu/command_buffer/common/webgpu_cmd_format.h new file mode 100644 index 0000000..327d1f9 --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_format.h
@@ -0,0 +1,36 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_H_ +#define GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_H_ + +#include <stddef.h> +#include <stdint.h> +#include <string.h> + +#include "base/atomicops.h" +#include "base/logging.h" +#include "base/macros.h" +#include "gpu/command_buffer/common/common_cmd_format.h" +#include "gpu/command_buffer/common/webgpu_cmd_ids.h" +#include "ui/gfx/buffer_types.h" + +namespace gpu { +namespace webgpu { +namespace cmds { + +// Command buffer is GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT byte aligned. +#pragma pack(push, 4) +static_assert(GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT == 4, + "pragma pack alignment must be equal to " + "GPU_COMMAND_BUFFER_ENTRY_ALIGNMENT"); + +#include "gpu/command_buffer/common/webgpu_cmd_format_autogen.h" + +#pragma pack(pop) + +} // namespace cmds +} // namespace webgpu +} // namespace gpu +#endif // GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_H_
diff --git a/gpu/command_buffer/common/webgpu_cmd_format_autogen.h b/gpu/command_buffer/common/webgpu_cmd_format_autogen.h new file mode 100644 index 0000000..f8c549e --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_format_autogen.h
@@ -0,0 +1,42 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +#ifndef GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_AUTOGEN_H_ + +#define GL_SCANOUT_CHROMIUM 0x6000 + +struct Dummy { + typedef Dummy ValueType; + static const CommandId kCmdId = kDummy; + static const cmd::ArgFlags kArgFlags = cmd::kFixed; + static const uint8_t cmd_flags = CMD_FLAG_SET_TRACE_LEVEL(3); + + static uint32_t ComputeSize() { + return static_cast<uint32_t>(sizeof(ValueType)); // NOLINT + } + + void SetHeader() { header.SetCmd<ValueType>(); } + + void Init() { SetHeader(); } + + void* Set(void* cmd) { + static_cast<ValueType*>(cmd)->Init(); + return NextCmdAddress<ValueType>(cmd); + } + + gpu::CommandHeader header; +}; + +static_assert(sizeof(Dummy) == 4, "size of Dummy should be 4"); +static_assert(offsetof(Dummy, header) == 0, + "offset of Dummy header should be 0"); + +#endif // GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_AUTOGEN_H_
diff --git a/gpu/command_buffer/common/webgpu_cmd_format_test.cc b/gpu/command_buffer/common/webgpu_cmd_format_test.cc new file mode 100644 index 0000000..95af7e2 --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_format_test.cc
@@ -0,0 +1,65 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file contains unit tests for webgpu commands + +#include <stddef.h> +#include <stdint.h> + +#include <limits> + +#include "base/bind.h" +#include "base/location.h" +#include "base/single_thread_task_runner.h" +#include "base/synchronization/waitable_event.h" +#include "base/threading/thread.h" +#include "gpu/command_buffer/common/webgpu_cmd_format.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace gpu { +namespace webgpu { + +class WebGPUFormatTest : public testing::Test { + protected: + static const unsigned char kInitialValue = 0xBD; + + void SetUp() override { memset(buffer_, kInitialValue, sizeof(buffer_)); } + + void TearDown() override {} + + template <typename T> + T* GetBufferAs() { + return static_cast<T*>(static_cast<void*>(&buffer_)); + } + + void CheckBytesWritten(const void* end, + size_t expected_size, + size_t written_size) { + size_t actual_size = static_cast<const unsigned char*>(end) - + GetBufferAs<const unsigned char>(); + EXPECT_LT(actual_size, sizeof(buffer_)); + EXPECT_GT(actual_size, 0u); + EXPECT_EQ(expected_size, actual_size); + EXPECT_EQ(kInitialValue, buffer_[written_size]); + EXPECT_NE(kInitialValue, buffer_[written_size - 1]); + } + + void CheckBytesWrittenMatchesExpectedSize(const void* end, + size_t expected_size) { + CheckBytesWritten(end, expected_size, expected_size); + } + + private: + unsigned char buffer_[1024]; +}; + +// GCC requires these declarations, but MSVC requires they not be present +#ifndef _MSC_VER +const unsigned char WebGPUFormatTest::kInitialValue; +#endif + +#include "gpu/command_buffer/common/webgpu_cmd_format_test_autogen.h" + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/common/webgpu_cmd_format_test_autogen.h b/gpu/command_buffer/common/webgpu_cmd_format_test_autogen.h new file mode 100644 index 0000000..45c2b09 --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_format_test_autogen.h
@@ -0,0 +1,25 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +// This file contains unit tests for webgpu commands +// It is included by webgpu_cmd_format_test.cc + +#ifndef GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_TEST_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_TEST_AUTOGEN_H_ + +TEST_F(WebGPUFormatTest, Dummy) { + cmds::Dummy& cmd = *GetBufferAs<cmds::Dummy>(); + void* next_cmd = cmd.Set(&cmd); + EXPECT_EQ(static_cast<uint32_t>(cmds::Dummy::kCmdId), cmd.header.command); + EXPECT_EQ(sizeof(cmd), cmd.header.size * 4u); + CheckBytesWrittenMatchesExpectedSize(next_cmd, sizeof(cmd)); +} + +#endif // GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_FORMAT_TEST_AUTOGEN_H_
diff --git a/gpu/command_buffer/common/webgpu_cmd_ids.h b/gpu/command_buffer/common/webgpu_cmd_ids.h new file mode 100644 index 0000000..5e3e659d --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_ids.h
@@ -0,0 +1,22 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file defines the webgpu command buffer commands. + +#ifndef GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_IDS_H_ +#define GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_IDS_H_ + +#include "gpu/command_buffer/common/cmd_buffer_common.h" + +namespace gpu { +namespace webgpu { + +#include "gpu/command_buffer/common/webgpu_cmd_ids_autogen.h" + +const char* GetCommandName(CommandId command_id); + +} // namespace webgpu +} // namespace gpu + +#endif // GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_IDS_H_
diff --git a/gpu/command_buffer/common/webgpu_cmd_ids_autogen.h b/gpu/command_buffer/common/webgpu_cmd_ids_autogen.h new file mode 100644 index 0000000..9d6d4a7 --- /dev/null +++ b/gpu/command_buffer/common/webgpu_cmd_ids_autogen.h
@@ -0,0 +1,26 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +#ifndef GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_IDS_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_IDS_AUTOGEN_H_ + +#define WEBGPU_COMMAND_LIST(OP) OP(Dummy) /* 256 */ + +enum CommandId { + kOneBeforeStartPoint = + cmd::kLastCommonId, // All WebGPU commands start after this. +#define WEBGPU_CMD_OP(name) k##name, + WEBGPU_COMMAND_LIST(WEBGPU_CMD_OP) +#undef WEBGPU_CMD_OP + kNumCommands, + kFirstWebGPUCommand = kOneBeforeStartPoint + 1 +}; + +#endif // GPU_COMMAND_BUFFER_COMMON_WEBGPU_CMD_IDS_AUTOGEN_H_
diff --git a/gpu/command_buffer/service/BUILD.gn b/gpu/command_buffer/service/BUILD.gn index d8b8205..b414b1a 100644 --- a/gpu/command_buffer/service/BUILD.gn +++ b/gpu/command_buffer/service/BUILD.gn
@@ -230,12 +230,19 @@ "vertex_array_manager.h", "vertex_attrib_manager.cc", "vertex_attrib_manager.h", + "webgpu_cmd_validation.cc", + "webgpu_cmd_validation.h", + "webgpu_cmd_validation_autogen.h", + "webgpu_cmd_validation_implementation_autogen.h", + "webgpu_decoder.cc", + "webgpu_decoder.h", ] configs += [ "//build/config:precompiled_headers", "//gpu:gpu_gles2_implementation", "//gpu:raster_implementation", + "//gpu:webgpu_implementation", "//third_party/khronos:khronos_headers", ] @@ -246,6 +253,7 @@ "//gpu/command_buffer/common", "//gpu/command_buffer/common:gles2_sources", "//gpu/command_buffer/common:raster_sources", + "//gpu/command_buffer/common:webgpu_sources", ] deps = [ ":disk_cache_proto",
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc index 5c00fcd0..88304b50 100644 --- a/gpu/command_buffer/service/feature_info.cc +++ b/gpu/command_buffer/service/feature_info.cc
@@ -816,6 +816,7 @@ case CONTEXT_TYPE_WEBGL1: case CONTEXT_TYPE_WEBGL2: case CONTEXT_TYPE_WEBGL2_COMPUTE: + case CONTEXT_TYPE_WEBGPU: break; } } @@ -1826,6 +1827,10 @@ } } +bool FeatureInfo::IsGLContext() const { + return IsGLContextType(context_type_); +} + bool FeatureInfo::IsWebGLContext() const { return IsWebGLContextType(context_type_); } @@ -1846,6 +1851,10 @@ return IsWebGL2ComputeContextType(context_type_); } +bool FeatureInfo::IsWebGPUContext() const { + return IsWebGPUContextType(context_type_); +} + void FeatureInfo::AddExtensionString(const base::StringPiece& extension) { extensions_.insert(extension); }
diff --git a/gpu/command_buffer/service/feature_info.h b/gpu/command_buffer/service/feature_info.h index d983db4b..b02b5ac 100644 --- a/gpu/command_buffer/service/feature_info.h +++ b/gpu/command_buffer/service/feature_info.h
@@ -179,11 +179,13 @@ bool disable_shader_translator() const { return disable_shader_translator_; } + bool IsGLContext() const; bool IsWebGLContext() const; bool IsWebGL1OrES2Context() const; bool IsWebGL2OrES3Context() const; bool IsWebGL2OrES3OrHigherContext() const; bool IsWebGL2ComputeContext() const; + bool IsWebGPUContext() const; void EnableCHROMIUMTextureStorageImage(); void EnableCHROMIUMColorBufferFloatRGBA();
diff --git a/gpu/command_buffer/service/webgpu_cmd_validation.cc b/gpu/command_buffer/service/webgpu_cmd_validation.cc new file mode 100644 index 0000000..d87568d --- /dev/null +++ b/gpu/command_buffer/service/webgpu_cmd_validation.cc
@@ -0,0 +1,16 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Contains various validation functions for the Webgpu service. + +#include "gpu/command_buffer/service/webgpu_cmd_validation.h" +#include "gpu/command_buffer/service/gl_utils.h" + +namespace gpu { +namespace webgpu { + +#include "gpu/command_buffer/service/webgpu_cmd_validation_implementation_autogen.h" + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/service/webgpu_cmd_validation.h b/gpu/command_buffer/service/webgpu_cmd_validation.h new file mode 100644 index 0000000..5b9d460 --- /dev/null +++ b/gpu/command_buffer/service/webgpu_cmd_validation.h
@@ -0,0 +1,26 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Contains various validation functions for the Webgpu service. + +#ifndef GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_H_ +#define GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_H_ + +#include <algorithm> +#include <vector> +#include "gpu/command_buffer/common/webgpu_cmd_format.h" + +namespace gpu { +namespace webgpu { + +struct Validators { + Validators(); + +#include "gpu/command_buffer/service/webgpu_cmd_validation_autogen.h" +}; + +} // namespace webgpu +} // namespace gpu + +#endif // GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_H_
diff --git a/gpu/command_buffer/service/webgpu_cmd_validation_autogen.h b/gpu/command_buffer/service/webgpu_cmd_validation_autogen.h new file mode 100644 index 0000000..18fd85321 --- /dev/null +++ b/gpu/command_buffer/service/webgpu_cmd_validation_autogen.h
@@ -0,0 +1,14 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +#ifndef GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_AUTOGEN_H_ + +#endif // GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_AUTOGEN_H_
diff --git a/gpu/command_buffer/service/webgpu_cmd_validation_implementation_autogen.h b/gpu/command_buffer/service/webgpu_cmd_validation_implementation_autogen.h new file mode 100644 index 0000000..ee3bf3d --- /dev/null +++ b/gpu/command_buffer/service/webgpu_cmd_validation_implementation_autogen.h
@@ -0,0 +1,16 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is auto-generated from +// gpu/command_buffer/build_webgpu_cmd_buffer.py +// It's formatted by clang-format using chromium coding style: +// clang-format -i -style=chromium filename +// DO NOT EDIT! + +#ifndef GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_IMPLEMENTATION_AUTOGEN_H_ +#define GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_IMPLEMENTATION_AUTOGEN_H_ + +Validators::Validators() {} + +#endif // GPU_COMMAND_BUFFER_SERVICE_WEBGPU_CMD_VALIDATION_IMPLEMENTATION_AUTOGEN_H_
diff --git a/gpu/command_buffer/service/webgpu_decoder.cc b/gpu/command_buffer/service/webgpu_decoder.cc new file mode 100644 index 0000000..fe60745 --- /dev/null +++ b/gpu/command_buffer/service/webgpu_decoder.cc
@@ -0,0 +1,354 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gpu/command_buffer/service/webgpu_decoder.h" + +#include "base/macros.h" +#include "gpu/command_buffer/common/webgpu_cmd_format.h" +#include "gpu/command_buffer/common/webgpu_cmd_ids.h" +#include "gpu/command_buffer/service/command_buffer_service.h" + +namespace gpu { +namespace webgpu { + +class WebGPUDecoderImpl final : public WebGPUDecoder { + public: + WebGPUDecoderImpl(DecoderClient* client, + CommandBufferServiceBase* command_buffer_service, + gles2::Outputter* outputter); + ~WebGPUDecoderImpl() override; + + // DecoderContext implementation. + base::WeakPtr<DecoderContext> AsWeakPtr() override { + NOTIMPLEMENTED(); + return nullptr; + } + ContextResult Initialize( + const scoped_refptr<gl::GLSurface>& surface, + const scoped_refptr<gl::GLContext>& context, + bool offscreen, + const gles2::DisallowedFeatures& disallowed_features, + const ContextCreationAttribs& attrib_helper) override { + return ContextResult::kSuccess; + } + const gles2::ContextState* GetContextState() override { + NOTREACHED(); + return nullptr; + } + void Destroy(bool have_context) override {} + bool MakeCurrent() override { return true; } + gl::GLContext* GetGLContext() override { + NOTREACHED(); + return nullptr; + } + gl::GLSurface* GetGLSurface() override { + NOTREACHED(); + return nullptr; + } + const gles2::FeatureInfo* GetFeatureInfo() const override { + NOTREACHED(); + return nullptr; + } + Capabilities GetCapabilities() override { return {}; } + void RestoreGlobalState() const override { NOTREACHED(); } + void ClearAllAttributes() const override { NOTREACHED(); } + void RestoreAllAttributes() const override { NOTREACHED(); } + void RestoreState(const gles2::ContextState* prev_state) override { + NOTREACHED(); + } + void RestoreActiveTexture() const override { NOTREACHED(); } + void RestoreAllTextureUnitAndSamplerBindings( + const gles2::ContextState* prev_state) const override { + NOTREACHED(); + } + void RestoreActiveTextureUnitBinding(unsigned int target) const override { + NOTREACHED(); + } + void RestoreBufferBinding(unsigned int target) override { NOTREACHED(); } + void RestoreBufferBindings() const override { NOTREACHED(); } + void RestoreFramebufferBindings() const override { NOTREACHED(); } + void RestoreRenderbufferBindings() override { NOTREACHED(); } + void RestoreProgramBindings() const override { NOTREACHED(); } + void RestoreTextureState(unsigned service_id) const override { NOTREACHED(); } + void RestoreTextureUnitBindings(unsigned unit) const override { + NOTREACHED(); + } + void RestoreVertexAttribArray(unsigned index) override { NOTREACHED(); } + void RestoreAllExternalTextureBindingsIfNeeded() override { NOTREACHED(); } + QueryManager* GetQueryManager() override { + NOTREACHED(); + return nullptr; + } + void SetQueryCallback(unsigned int query_client_id, + base::OnceClosure callback) override { + NOTREACHED(); + } + gles2::GpuFenceManager* GetGpuFenceManager() override { + NOTREACHED(); + return nullptr; + } + bool HasPendingQueries() const override { return false; } + void ProcessPendingQueries(bool did_finish) override { NOTREACHED(); } + bool HasMoreIdleWork() const override { return false; } + void PerformIdleWork() override { NOTREACHED(); } + bool HasPollingWork() const override { + NOTREACHED(); + return false; + } + void PerformPollingWork() override { NOTREACHED(); } + TextureBase* GetTextureBase(uint32_t client_id) override { + NOTREACHED(); + return nullptr; + } + void SetLevelInfo(uint32_t client_id, + int level, + unsigned internal_format, + unsigned width, + unsigned height, + unsigned depth, + unsigned format, + unsigned type, + const gfx::Rect& cleared_rect) override { + NOTREACHED(); + } + bool WasContextLost() const override { + NOTIMPLEMENTED(); + return false; + } + bool WasContextLostByRobustnessExtension() const override { + NOTREACHED(); + return false; + } + void MarkContextLost(error::ContextLostReason reason) override { + NOTIMPLEMENTED(); + } + bool CheckResetStatus() override { + NOTREACHED(); + return false; + } + void BeginDecoding() override {} + void EndDecoding() override {} + const char* GetCommandName(unsigned int command_id) const; + error::Error DoCommands(unsigned int num_commands, + const volatile void* buffer, + int num_entries, + int* entries_processed) override; + base::StringPiece GetLogPrefix() override { + NOTIMPLEMENTED(); + return ""; + } + void BindImage(uint32_t client_texture_id, + uint32_t texture_target, + gl::GLImage* image, + bool can_bind_to_sampler) override { + NOTREACHED(); + } + gles2::ContextGroup* GetContextGroup() override { + NOTREACHED(); + return nullptr; + } + gles2::ErrorState* GetErrorState() override { + NOTREACHED(); + return nullptr; + } + std::unique_ptr<gles2::AbstractTexture> CreateAbstractTexture( + GLenum target, + GLenum internal_format, + GLsizei width, + GLsizei height, + GLsizei depth, + GLint border, + GLenum format, + GLenum type) override { + NOTREACHED(); + return nullptr; + } + bool IsCompressedTextureFormat(unsigned format) override { + NOTREACHED(); + return false; + } + bool ClearLevel(gles2::Texture* texture, + unsigned target, + int level, + unsigned format, + unsigned type, + int xoffset, + int yoffset, + int width, + int height) override { + NOTREACHED(); + return false; + } + bool ClearCompressedTextureLevel(gles2::Texture* texture, + unsigned target, + int level, + unsigned format, + int width, + int height) override { + NOTREACHED(); + return false; + } + bool ClearLevel3D(gles2::Texture* texture, + unsigned target, + int level, + unsigned format, + unsigned type, + int width, + int height, + int depth) override { + NOTREACHED(); + return false; + } + bool initialized() const override { return true; } + void SetLogCommands(bool log_commands) override { NOTIMPLEMENTED(); } + gles2::Outputter* outputter() const override { + NOTIMPLEMENTED(); + return nullptr; + } + + private: + typedef error::Error (WebGPUDecoderImpl::*CmdHandler)( + uint32_t immediate_data_size, + const volatile void* data); + + // A struct to hold info about each command. + struct CommandInfo { + CmdHandler cmd_handler; + uint8_t arg_flags; // How to handle the arguments for this command + uint8_t cmd_flags; // How to handle this command + uint16_t arg_count; // How many arguments are expected for this command. + }; + + // A table of CommandInfo for all the commands. + static const CommandInfo command_info[kNumCommands - kFirstWebGPUCommand]; + +// Generate a member function prototype for each command in an automated and +// typesafe way. +#define WEBGPU_CMD_OP(name) \ + Error Handle##name(uint32_t immediate_data_size, const volatile void* data); + WEBGPU_COMMAND_LIST(WEBGPU_CMD_OP) +#undef WEBGPU_CMD_OP + + // The current decoder error communicates the decoder error through command + // processing functions that do not return the error value. Should be set + // only if not returning an error. + error::Error current_decoder_error_ = error::kNoError; + + DISALLOW_COPY_AND_ASSIGN(WebGPUDecoderImpl); +}; + +constexpr WebGPUDecoderImpl::CommandInfo WebGPUDecoderImpl::command_info[] = { +#define WEBGPU_CMD_OP(name) \ + { \ + &WebGPUDecoderImpl::Handle##name, cmds::name::kArgFlags, \ + cmds::name::cmd_flags, \ + sizeof(cmds::name) / sizeof(CommandBufferEntry) - 1, \ + }, /* NOLINT */ + WEBGPU_COMMAND_LIST(WEBGPU_CMD_OP) +#undef WEBGPU_CMD_OP +}; + +// static +WebGPUDecoder* WebGPUDecoder::Create( + DecoderClient* client, + CommandBufferServiceBase* command_buffer_service, + gles2::Outputter* outputter) { + return new WebGPUDecoderImpl(client, command_buffer_service, outputter); +} + +WebGPUDecoder::WebGPUDecoder(DecoderClient* client, + CommandBufferServiceBase* command_buffer_service, + gles2::Outputter* outputter) + : CommonDecoder(command_buffer_service) {} + +WebGPUDecoder::~WebGPUDecoder() {} + +WebGPUDecoderImpl::WebGPUDecoderImpl( + DecoderClient* client, + CommandBufferServiceBase* command_buffer_service, + gles2::Outputter* outputter) + : WebGPUDecoder(client, command_buffer_service, outputter) {} + +WebGPUDecoderImpl::~WebGPUDecoderImpl() {} + +const char* WebGPUDecoderImpl::GetCommandName(unsigned int command_id) const { + if (command_id >= kFirstWebGPUCommand && command_id < kNumCommands) { + return webgpu::GetCommandName(static_cast<CommandId>(command_id)); + } + return GetCommonCommandName(static_cast<cmd::CommandId>(command_id)); +} + +error::Error WebGPUDecoderImpl::DoCommands(unsigned int num_commands, + const volatile void* buffer, + int num_entries, + int* entries_processed) { + DCHECK(entries_processed); + int commands_to_process = num_commands; + error::Error result = error::kNoError; + const volatile CommandBufferEntry* cmd_data = + static_cast<const volatile CommandBufferEntry*>(buffer); + int process_pos = 0; + CommandId command = static_cast<CommandId>(0); + + while (process_pos < num_entries && result == error::kNoError && + commands_to_process--) { + const unsigned int size = cmd_data->value_header.size; + command = static_cast<CommandId>(cmd_data->value_header.command); + + if (size == 0) { + result = error::kInvalidSize; + break; + } + + if (static_cast<int>(size) + process_pos > num_entries) { + result = error::kOutOfBounds; + break; + } + + const unsigned int arg_count = size - 1; + unsigned int command_index = command - kFirstWebGPUCommand; + if (command_index < base::size(command_info)) { + const CommandInfo& info = command_info[command_index]; + unsigned int info_arg_count = static_cast<unsigned int>(info.arg_count); + if ((info.arg_flags == cmd::kFixed && arg_count == info_arg_count) || + (info.arg_flags == cmd::kAtLeastN && arg_count >= info_arg_count)) { + uint32_t immediate_data_size = (arg_count - info_arg_count) * + sizeof(CommandBufferEntry); // NOLINT + result = (this->*info.cmd_handler)(immediate_data_size, cmd_data); + } else { + result = error::kInvalidArguments; + } + } else { + result = DoCommonCommand(command, arg_count, cmd_data); + } + + if (result == error::kNoError && + current_decoder_error_ != error::kNoError) { + result = current_decoder_error_; + current_decoder_error_ = error::kNoError; + } + + if (result != error::kDeferCommandUntilLater) { + process_pos += size; + cmd_data += size; + } + } + + *entries_processed = process_pos; + + if (error::IsError(result)) { + LOG(ERROR) << "Error: " << result << " for Command " + << GetCommandName(command); + } + + return result; +} + +error::Error WebGPUDecoderImpl::HandleDummy(uint32_t immediate_data_size, + const volatile void* cmd_data) { + return error::kNoError; +} + +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/service/webgpu_decoder.h b/gpu/command_buffer/service/webgpu_decoder.h new file mode 100644 index 0000000..af9f52e --- /dev/null +++ b/gpu/command_buffer/service/webgpu_decoder.h
@@ -0,0 +1,44 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_COMMAND_BUFFER_SERVICE_WEBGPU_DECODER_H_ +#define GPU_COMMAND_BUFFER_SERVICE_WEBGPU_DECODER_H_ + +#include "base/macros.h" +#include "gpu/command_buffer/service/common_decoder.h" +#include "gpu/command_buffer/service/decoder_context.h" +#include "gpu/gpu_gles2_export.h" + +namespace gpu { + +class DecoderClient; + +namespace gles2 { +class Outputter; +} // namespace gles2 + +namespace webgpu { + +class GPU_GLES2_EXPORT WebGPUDecoder : public DecoderContext, + public CommonDecoder { + public: + static WebGPUDecoder* Create(DecoderClient* client, + CommandBufferServiceBase* command_buffer_service, + gles2::Outputter* outputter); + + ~WebGPUDecoder() override; + + protected: + WebGPUDecoder(DecoderClient* client, + CommandBufferServiceBase* command_buffer_service, + gles2::Outputter* outputter); + + private: + DISALLOW_COPY_AND_ASSIGN(WebGPUDecoder); +}; + +} // namespace webgpu +} // namespace gpu + +#endif // GPU_COMMAND_BUFFER_SERVICE_WEBGPU_DECODER_H_
diff --git a/gpu/command_buffer/service/webgpu_decoder_unittest.cc b/gpu/command_buffer/service/webgpu_decoder_unittest.cc new file mode 100644 index 0000000..e9ff2f5 --- /dev/null +++ b/gpu/command_buffer/service/webgpu_decoder_unittest.cc
@@ -0,0 +1,55 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gpu/command_buffer/service/webgpu_decoder.h" + +#include "gpu/command_buffer/client/client_test_helper.h" +#include "gpu/command_buffer/common/webgpu_cmd_format.h" +#include "gpu/command_buffer/service/context_group.h" +#include "gpu/command_buffer/service/decoder_client.h" +#include "gpu/command_buffer/service/gpu_tracer.h" +#include "gpu/command_buffer/service/test_helper.h" +#include "testing/gtest/include/gtest/gtest.h" + +using ::testing::_; +using ::testing::Return; +using ::testing::SetArgPointee; + +namespace gpu { +namespace webgpu { + +class WebGPUDecoderTest : public ::testing::Test { + public: + WebGPUDecoderTest() {} + + void SetUp() override { + command_buffer_service_.reset(new FakeCommandBufferServiceBase()); + decoder_.reset(WebGPUDecoder::Create(nullptr, command_buffer_service_.get(), + &outputter_)); + } + + template <typename T> + error::Error ExecuteCmd(const T& cmd) { + static_assert(T::kArgFlags == cmd::kFixed, + "T::kArgFlags should equal cmd::kFixed"); + int entries_processed = 0; + return decoder_->DoCommands(1, (const void*)&cmd, + ComputeNumEntries(sizeof(cmd)), + &entries_processed); + } + + protected: + std::unique_ptr<FakeCommandBufferServiceBase> command_buffer_service_; + std::unique_ptr<WebGPUDecoder> decoder_; + gles2::TraceOutputter outputter_; + scoped_refptr<gles2::ContextGroup> group_; +}; + +TEST_F(WebGPUDecoderTest, Dummy) { + cmds::Dummy dummy; + dummy.Init(); + EXPECT_EQ(error::kNoError, ExecuteCmd(dummy)); +} +} // namespace webgpu +} // namespace gpu
diff --git a/gpu/command_buffer/webgpu_cmd_buffer_functions.txt b/gpu/command_buffer/webgpu_cmd_buffer_functions.txt new file mode 100644 index 0000000..464899c --- /dev/null +++ b/gpu/command_buffer/webgpu_cmd_buffer_functions.txt
@@ -0,0 +1,9 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file is read by build_webgpu_cmd_buffer.py to generate commands. + +// WebGPU commands. Note the first 2 characters (usually 'gl') are +// completely ignored. +GL_APICALL void GL_APIENTRY wgDummy (void);
diff --git a/gpu/config/gpu_driver_bug_list.json b/gpu/config/gpu_driver_bug_list.json index 7ac23f6..7f941e9 100644 --- a/gpu/config/gpu_driver_bug_list.json +++ b/gpu/config/gpu_driver_bug_list.json
@@ -2965,7 +2965,7 @@ { "id":273, "cr_bugs": [866613], - "description": "Frequent crashes on Adreno (TM) 405 on L", + "description": "Frequent crashes on Adreno (TM) on L and below", "os": { "type": "android", "version": { @@ -2973,7 +2973,7 @@ "value": "6.0" } }, - "gl_renderer": "Adreno \\(TM\\) 4.*", + "gl_renderer": "Adreno.*", "features": [ "use_es2_for_oopr" ]
diff --git a/gpu/ipc/client/webgpu_in_process_context_tests.cc b/gpu/ipc/client/webgpu_in_process_context_tests.cc new file mode 100644 index 0000000..764ff863 --- /dev/null +++ b/gpu/ipc/client/webgpu_in_process_context_tests.cc
@@ -0,0 +1,61 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include <memory> + +#include "base/command_line.h" +#include "build/build_config.h" +#include "gpu/command_buffer/client/shared_memory_limits.h" +#include "gpu/command_buffer/client/webgpu_implementation.h" +#include "gpu/config/gpu_switches.h" +#include "gpu/ipc/webgpu_in_process_context.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace gpu { + +namespace { + +class WebGPUInProcessCommandBufferTest : public ::testing::Test { + public: + std::unique_ptr<WebGPUInProcessContext> CreateWebGPUInProcessContext() { + base::CommandLine::ForCurrentProcess()->AppendSwitch( + switches::kEnableUnsafeWebGPU); + + ContextCreationAttribs attributes; + attributes.bind_generates_resource = false; + attributes.enable_gles2_interface = false; + attributes.context_type = CONTEXT_TYPE_WEBGPU; + + static scoped_refptr<CommandBufferTaskExecutor> task_executor = nullptr; + static constexpr GpuMemoryBufferManager* memory_buffer_manager = nullptr; + static constexpr ImageFactory* image_factory = nullptr; + static constexpr GpuChannelManagerDelegate* channel_manager = nullptr; + auto context = std::make_unique<WebGPUInProcessContext>(); + auto result = context->Initialize( + task_executor, attributes, SharedMemoryLimits(), memory_buffer_manager, + image_factory, channel_manager); + DCHECK_EQ(result, ContextResult::kSuccess); + return context; + } + + void SetUp() override { + context_ = CreateWebGPUInProcessContext(); + wg_ = context_->GetImplementation(); + } + + void TearDown() override { context_.reset(); } + + protected: + webgpu::WebGPUInterface* wg_; // not owned + std::unique_ptr<WebGPUInProcessContext> context_; +}; + +} // namespace + +TEST_F(WebGPUInProcessCommandBufferTest, Dummy) { + wg_->Dummy(); + // TODO +} + +} // namespace gpu
diff --git a/gpu/ipc/in_process_command_buffer.cc b/gpu/ipc/in_process_command_buffer.cc index 63bf0e4..f44319e4 100644 --- a/gpu/ipc/in_process_command_buffer.cc +++ b/gpu/ipc/in_process_command_buffer.cc
@@ -52,6 +52,7 @@ #include "gpu/command_buffer/service/shared_image_factory.h" #include "gpu/command_buffer/service/sync_point_manager.h" #include "gpu/command_buffer/service/transfer_buffer_manager.h" +#include "gpu/command_buffer/service/webgpu_decoder.h" #include "gpu/config/gpu_crash_keys.h" #include "gpu/config/gpu_feature_info.h" #include "gpu/config/gpu_preferences.h" @@ -486,103 +487,114 @@ crash_keys::gpu_gl_context_is_virtual.Set(use_virtualized_gl_context_ ? "1" : "0"); - // TODO(khushalsagar): A lot of this initialization code is duplicated in - // GpuChannelManager. Pull it into a common util method. - scoped_refptr<gl::GLContext> real_context = - use_virtualized_gl_context_ - ? gl_share_group_->GetSharedContext(surface_.get()) - : nullptr; - if (!real_context) { - real_context = gl::init::CreateGLContext( - gl_share_group_.get(), surface_.get(), - GenerateGLContextAttribs(params.attribs, context_group_.get())); + if (params.attribs.context_type == CONTEXT_TYPE_WEBGPU) { + if (!task_executor_->gpu_preferences().enable_webgpu) { + DLOG(ERROR) << "ContextResult::kFatalFailure: WebGPU not enabled"; + return gpu::ContextResult::kFatalFailure; + } + + decoder_.reset(webgpu::WebGPUDecoder::Create(this, command_buffer_.get(), + task_executor_->outputter())); + } else { + // TODO(khushalsagar): A lot of this initialization code is duplicated in + // GpuChannelManager. Pull it into a common util method. + scoped_refptr<gl::GLContext> real_context = + use_virtualized_gl_context_ + ? gl_share_group_->GetSharedContext(surface_.get()) + : nullptr; if (!real_context) { - // TODO(piman): This might not be fatal, we could recurse into - // CreateGLContext to get more info, tho it should be exceedingly - // rare and may not be recoverable anyway. + real_context = gl::init::CreateGLContext( + gl_share_group_.get(), surface_.get(), + GenerateGLContextAttribs(params.attribs, context_group_.get())); + if (!real_context) { + // TODO(piman): This might not be fatal, we could recurse into + // CreateGLContext to get more info, tho it should be exceedingly + // rare and may not be recoverable anyway. + DestroyOnGpuThread(); + LOG(ERROR) << "ContextResult::kFatalFailure: " + "Failed to create shared context for virtualization."; + return gpu::ContextResult::kFatalFailure; + } + // Ensure that context creation did not lose track of the intended share + // group. + DCHECK(real_context->share_group() == gl_share_group_.get()); + task_executor_->gpu_feature_info().ApplyToGLContext(real_context.get()); + + if (use_virtualized_gl_context_) + gl_share_group_->SetSharedContext(surface_.get(), real_context.get()); + } + + if (!real_context->MakeCurrent(surface_.get())) { + LOG(ERROR) + << "ContextResult::kTransientFailure, failed to make context current"; DestroyOnGpuThread(); - LOG(ERROR) << "ContextResult::kFatalFailure: " - "Failed to create shared context for virtualization."; - return gpu::ContextResult::kFatalFailure; - } - // Ensure that context creation did not lose track of the intended share - // group. - DCHECK(real_context->share_group() == gl_share_group_.get()); - task_executor_->gpu_feature_info().ApplyToGLContext(real_context.get()); - - if (use_virtualized_gl_context_) - gl_share_group_->SetSharedContext(surface_.get(), real_context.get()); - } - - if (!real_context->MakeCurrent(surface_.get())) { - LOG(ERROR) - << "ContextResult::kTransientFailure, failed to make context current"; - DestroyOnGpuThread(); - return ContextResult::kTransientFailure; - } - - bool supports_oop_rasterization = - task_executor_->gpu_feature_info() - .status_values[GPU_FEATURE_TYPE_OOP_RASTERIZATION] == - kGpuFeatureStatusEnabled; - if (supports_oop_rasterization && params.attribs.enable_oop_rasterization && - params.attribs.enable_raster_interface && - !params.attribs.enable_gles2_interface) { - scoped_refptr<raster::RasterDecoderContextState> context_state = - new raster::RasterDecoderContextState(gl_share_group_, surface_, - real_context, - use_virtualized_gl_context_); - gr_shader_cache_ = params.gr_shader_cache; - context_state->InitializeGrContext(workarounds, params.gr_shader_cache, - params.activity_flags); - - if (base::ThreadTaskRunnerHandle::IsSet()) { - gr_cache_controller_.emplace(context_state.get(), - base::ThreadTaskRunnerHandle::Get()); + return ContextResult::kTransientFailure; } - decoder_.reset(raster::RasterDecoder::Create( - this, command_buffer_.get(), task_executor_->outputter(), - context_group_.get(), std::move(context_state))); - } else { - decoder_.reset(gles2::GLES2Decoder::Create(this, command_buffer_.get(), - task_executor_->outputter(), - context_group_.get())); - } + bool supports_oop_rasterization = + task_executor_->gpu_feature_info() + .status_values[GPU_FEATURE_TYPE_OOP_RASTERIZATION] == + kGpuFeatureStatusEnabled; - if (use_virtualized_gl_context_) { - context_ = base::MakeRefCounted<GLContextVirtual>( - gl_share_group_.get(), real_context.get(), decoder_->AsWeakPtr()); - if (!context_->Initialize( - surface_.get(), - GenerateGLContextAttribs(params.attribs, context_group_.get()))) { - // TODO(piman): This might not be fatal, we could recurse into - // CreateGLContext to get more info, tho it should be exceedingly - // rare and may not be recoverable anyway. - DestroyOnGpuThread(); - LOG(ERROR) << "ContextResult::kFatalFailure: " - "Failed to initialize virtual GL context."; - return gpu::ContextResult::kFatalFailure; + if (supports_oop_rasterization && params.attribs.enable_oop_rasterization && + params.attribs.enable_raster_interface && + !params.attribs.enable_gles2_interface) { + scoped_refptr<raster::RasterDecoderContextState> context_state = + new raster::RasterDecoderContextState(gl_share_group_, surface_, + real_context, + use_virtualized_gl_context_); + gr_shader_cache_ = params.gr_shader_cache; + context_state->InitializeGrContext(workarounds, params.gr_shader_cache, + params.activity_flags); + + if (base::ThreadTaskRunnerHandle::IsSet()) { + gr_cache_controller_.emplace(context_state.get(), + base::ThreadTaskRunnerHandle::Get()); + } + + decoder_.reset(raster::RasterDecoder::Create( + this, command_buffer_.get(), task_executor_->outputter(), + context_group_.get(), std::move(context_state))); + } else { + decoder_.reset(gles2::GLES2Decoder::Create(this, command_buffer_.get(), + task_executor_->outputter(), + context_group_.get())); } - if (!context_->MakeCurrent(surface_.get())) { - DestroyOnGpuThread(); - // The caller should retry making a context, but this one won't work. - LOG(ERROR) << "ContextResult::kTransientFailure: " - "Could not make context current."; - return gpu::ContextResult::kTransientFailure; + if (use_virtualized_gl_context_) { + context_ = base::MakeRefCounted<GLContextVirtual>( + gl_share_group_.get(), real_context.get(), decoder_->AsWeakPtr()); + if (!context_->Initialize( + surface_.get(), + GenerateGLContextAttribs(params.attribs, context_group_.get()))) { + // TODO(piman): This might not be fatal, we could recurse into + // CreateGLContext to get more info, tho it should be exceedingly + // rare and may not be recoverable anyway. + DestroyOnGpuThread(); + LOG(ERROR) << "ContextResult::kFatalFailure: " + "Failed to initialize virtual GL context."; + return gpu::ContextResult::kFatalFailure; + } + + if (!context_->MakeCurrent(surface_.get())) { + DestroyOnGpuThread(); + // The caller should retry making a context, but this one won't work. + LOG(ERROR) << "ContextResult::kTransientFailure: " + "Could not make context current."; + return gpu::ContextResult::kTransientFailure; + } + + context_->SetGLStateRestorer( + new GLStateRestorerImpl(decoder_->AsWeakPtr())); + } else { + context_ = real_context; + DCHECK(context_->IsCurrent(surface_.get())); } - context_->SetGLStateRestorer( - new GLStateRestorerImpl(decoder_->AsWeakPtr())); - } else { - context_ = real_context; - DCHECK(context_->IsCurrent(surface_.get())); - } - - if (!context_group_->has_program_cache() && - !context_group_->feature_info()->workarounds().disable_program_cache) { - context_group_->set_program_cache(task_executor_->program_cache()); + if (!context_group_->has_program_cache() && + !context_group_->feature_info()->workarounds().disable_program_cache) { + context_group_->set_program_cache(task_executor_->program_cache()); + } } gles2::DisallowedFeatures disallowed_features; @@ -597,7 +609,7 @@ if (task_executor_->gpu_preferences().enable_gpu_service_logging) decoder_->SetLogCommands(true); - if (use_virtualized_gl_context_) { + if (context_ && use_virtualized_gl_context_) { // If virtualized GL contexts are in use, then real GL context state // is in an indeterminate state, since the GLStateRestorer was not // initialized at the time the GLContextVirtual was made current. In
diff --git a/gpu/ipc/service/BUILD.gn b/gpu/ipc/service/BUILD.gn index 489fb52..dbf8aad 100644 --- a/gpu/ipc/service/BUILD.gn +++ b/gpu/ipc/service/BUILD.gn
@@ -36,6 +36,8 @@ "raster_command_buffer_stub.h", "shared_image_stub.cc", "shared_image_stub.h", + "webgpu_command_buffer_stub.cc", + "webgpu_command_buffer_stub.h", ] defines = [ "GPU_IPC_SERVICE_IMPLEMENTATION" ] if (is_chromecast) {
diff --git a/gpu/ipc/service/command_buffer_stub.cc b/gpu/ipc/service/command_buffer_stub.cc index e91476a..1ca1eba 100644 --- a/gpu/ipc/service/command_buffer_stub.cc +++ b/gpu/ipc/service/command_buffer_stub.cc
@@ -81,6 +81,8 @@ UMA_HISTOGRAM_MEMORY_LARGE_MB("GPU.ContextMemory.GLES." category, \ mb_used); \ break; \ + case CONTEXT_TYPE_WEBGPU: \ + break; \ } \ } while (false) @@ -462,7 +464,8 @@ } bool have_context = false; - if (decoder_context_ && decoder_context_->GetGLContext()) { + if (decoder_context_ && decoder_context_->GetFeatureInfo()->IsGLContext() && + decoder_context_->GetGLContext()) { // Try to make the context current regardless of whether it was lost, so we // don't leak resources. have_context =
diff --git a/gpu/ipc/service/gpu_channel.cc b/gpu/ipc/service/gpu_channel.cc index 2cf63f307..3ae6d87 100644 --- a/gpu/ipc/service/gpu_channel.cc +++ b/gpu/ipc/service/gpu_channel.cc
@@ -44,6 +44,7 @@ #include "gpu/ipc/service/gpu_channel_manager_delegate.h" #include "gpu/ipc/service/gpu_memory_buffer_factory.h" #include "gpu/ipc/service/raster_command_buffer_stub.h" +#include "gpu/ipc/service/webgpu_command_buffer_stub.h" #include "ipc/ipc_channel.h" #include "ipc/message_filter.h" #include "ui/gl/gl_context.h" @@ -624,10 +625,18 @@ gpu_channel_manager_->gpu_feature_info() .status_values[GPU_FEATURE_TYPE_GPU_RASTERIZATION] == kGpuFeatureStatusEnabled; - if (supports_oop_rasterization && - init_params.attribs.enable_oop_rasterization && - init_params.attribs.enable_raster_interface && - !init_params.attribs.enable_gles2_interface) { + if (init_params.attribs.context_type == CONTEXT_TYPE_WEBGPU) { + if (!gpu_channel_manager_->gpu_preferences().enable_webgpu) { + DLOG(ERROR) << "ContextResult::kFatalFailure: WebGPU not enabled"; + return; + } + + stub = std::make_unique<WebGPUCommandBufferStub>( + this, init_params, command_buffer_id, sequence_id, stream_id, route_id); + } else if (supports_oop_rasterization && + init_params.attribs.enable_oop_rasterization && + init_params.attribs.enable_raster_interface && + !init_params.attribs.enable_gles2_interface) { stub = std::make_unique<RasterCommandBufferStub>( this, init_params, command_buffer_id, sequence_id, stream_id, route_id); } else {
diff --git a/gpu/ipc/service/webgpu_command_buffer_stub.cc b/gpu/ipc/service/webgpu_command_buffer_stub.cc new file mode 100644 index 0000000..709a48c --- /dev/null +++ b/gpu/ipc/service/webgpu_command_buffer_stub.cc
@@ -0,0 +1,179 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gpu/ipc/service/webgpu_command_buffer_stub.h" + +#include <memory> +#include <utility> + +#include "base/macros.h" +#include "base/memory/shared_memory.h" +#include "base/trace_event/trace_event.h" +#include "build/build_config.h" +#include "gpu/command_buffer/common/constants.h" +#include "gpu/command_buffer/common/gpu_memory_buffer_support.h" +#include "gpu/command_buffer/common/mailbox.h" +#include "gpu/command_buffer/service/gl_context_virtual.h" +#include "gpu/command_buffer/service/gl_state_restorer_impl.h" +#include "gpu/command_buffer/service/image_manager.h" +#include "gpu/command_buffer/service/logger.h" +#include "gpu/command_buffer/service/mailbox_manager.h" +#include "gpu/command_buffer/service/memory_tracking.h" +#include "gpu/command_buffer/service/service_utils.h" +#include "gpu/command_buffer/service/sync_point_manager.h" +#include "gpu/command_buffer/service/transfer_buffer_manager.h" +#include "gpu/command_buffer/service/webgpu_decoder.h" +#include "gpu/config/gpu_crash_keys.h" +#include "gpu/ipc/common/gpu_messages.h" +#include "gpu/ipc/service/gpu_channel.h" +#include "gpu/ipc/service/gpu_channel_manager.h" +#include "gpu/ipc/service/gpu_channel_manager_delegate.h" +#include "gpu/ipc/service/gpu_memory_buffer_factory.h" +#include "gpu/ipc/service/gpu_watchdog_thread.h" +#include "ui/gl/gl_bindings.h" +#include "ui/gl/gl_context.h" +#include "ui/gl/gl_image.h" +#include "ui/gl/gl_implementation.h" +#include "ui/gl/gl_switches.h" +#include "ui/gl/gl_workarounds.h" +#include "ui/gl/init/gl_factory.h" + +#if defined(OS_WIN) +#include "base/win/win_util.h" +#endif + +#if defined(OS_ANDROID) +#include "gpu/ipc/service/stream_texture_android.h" +#endif + +namespace gpu { + +WebGPUCommandBufferStub::WebGPUCommandBufferStub( + GpuChannel* channel, + const GPUCreateCommandBufferConfig& init_params, + CommandBufferId command_buffer_id, + SequenceId sequence_id, + int32_t stream_id, + int32_t route_id) + : CommandBufferStub(channel, + init_params, + command_buffer_id, + sequence_id, + stream_id, + route_id) {} + +WebGPUCommandBufferStub::~WebGPUCommandBufferStub() {} + +gpu::ContextResult WebGPUCommandBufferStub::Initialize( + CommandBufferStub* share_command_buffer_stub, + const GPUCreateCommandBufferConfig& init_params, + base::UnsafeSharedMemoryRegion shared_state_shm) { +#if defined(OS_FUCHSIA) + // TODO(crbug.com/707031): Implement this. + NOTIMPLEMENTED(); + LOG(ERROR) << "ContextResult::kFatalFailure: no fuchsia support"; + return gpu::ContextResult::kFatalFailure; +#else + TRACE_EVENT0("gpu", "WebGPUBufferStub::Initialize"); + FastSetActiveURL(active_url_, active_url_hash_, channel_); + + GpuChannelManager* manager = channel_->gpu_channel_manager(); + DCHECK(manager); + + if (share_command_buffer_stub) { + LOG(ERROR) << "Using a share group is not supported with WebGPUDecoder"; + return ContextResult::kFatalFailure; + } + + if (surface_handle_ != kNullSurfaceHandle) { + LOG(ERROR) << "ContextResult::kFatalFailure: " + "WebGPUInterface clients must render offscreen."; + return ContextResult::kFatalFailure; + } + + if (init_params.attribs.context_type != CONTEXT_TYPE_WEBGPU) { + LOG(ERROR) << "ContextResult::kFatalFailure: Incompatible creation attribs " + "used with WebGPUDecoder"; + return ContextResult::kFatalFailure; + } + + share_group_ = manager->share_group(); + use_virtualized_gl_context_ = false; + + TransferBufferManager* transfer_buffer_manager; + // TODO: all of this is necessary to get a transfer buffer manager - we would + // prefer to create a standalone one instead. + { + scoped_refptr<gles2::FeatureInfo> feature_info = new gles2::FeatureInfo( + manager->gpu_driver_bug_workarounds(), manager->gpu_feature_info()); + gpu::GpuMemoryBufferFactory* gmb_factory = + manager->gpu_memory_buffer_factory(); + context_group_ = new gles2::ContextGroup( + manager->gpu_preferences(), gles2::PassthroughCommandDecoderSupported(), + manager->mailbox_manager(), CreateMemoryTracker(init_params), + manager->shader_translator_cache(), + manager->framebuffer_completeness_cache(), feature_info, + init_params.attribs.bind_generates_resource, channel_->image_manager(), + gmb_factory ? gmb_factory->AsImageFactory() : nullptr, + manager->watchdog() /* progress_reporter */, + manager->gpu_feature_info(), manager->discardable_manager()); + + transfer_buffer_manager = context_group_->transfer_buffer_manager(); + } + + command_buffer_ = + std::make_unique<CommandBufferService>(this, transfer_buffer_manager); + std::unique_ptr<webgpu::WebGPUDecoder> decoder(webgpu::WebGPUDecoder::Create( + this, command_buffer_.get(), manager->outputter())); + + sync_point_client_state_ = + channel_->sync_point_manager()->CreateSyncPointClientState( + CommandBufferNamespace::GPU_IO, command_buffer_id_, sequence_id_); + + // Initialize the decoder with either the view or pbuffer GLContext. + ContextResult result = decoder->Initialize( + nullptr, nullptr, true /* offscreen */, gpu::gles2::DisallowedFeatures(), + init_params.attribs); + if (result != gpu::ContextResult::kSuccess) { + DLOG(ERROR) << "Failed to initialize decoder."; + return result; + } + + if (manager->gpu_preferences().enable_gpu_service_logging) { + decoder->SetLogCommands(true); + } + set_decoder_context(std::move(decoder)); + + const size_t kSharedStateSize = sizeof(CommandBufferSharedState); + base::WritableSharedMemoryMapping shared_state_mapping = + shared_state_shm.MapAt(0, kSharedStateSize); + if (!shared_state_mapping.IsValid()) { + LOG(ERROR) << "ContextResult::kFatalFailure: " + "Failed to map shared state buffer."; + return gpu::ContextResult::kFatalFailure; + } + command_buffer_->SetSharedStateBuffer(MakeBackingFromSharedMemory( + std::move(shared_state_shm), std::move(shared_state_mapping))); + + if (!active_url_.is_empty()) + manager->delegate()->DidCreateOffscreenContext(active_url_); + + manager->delegate()->DidCreateContextSuccessfully(); + initialized_ = true; + return gpu::ContextResult::kSuccess; +#endif // defined(OS_FUCHSIA) +} + +// WebGPUInterface clients should not manipulate the front buffer. +void WebGPUCommandBufferStub::OnTakeFrontBuffer(const Mailbox& mailbox) { + LOG(ERROR) << "Called WebGPUCommandBufferStub::OnTakeFrontBuffer"; +} +void WebGPUCommandBufferStub::OnReturnFrontBuffer(const Mailbox& mailbox, + bool is_lost) { + LOG(ERROR) << "Called WebGPUCommandBufferStub::OnReturnFrontBuffer"; +} + +void WebGPUCommandBufferStub::OnSwapBuffers(uint64_t swap_id, uint32_t flags) {} + +} // namespace gpu
diff --git a/gpu/ipc/service/webgpu_command_buffer_stub.h b/gpu/ipc/service/webgpu_command_buffer_stub.h new file mode 100644 index 0000000..cc74b5d --- /dev/null +++ b/gpu/ipc/service/webgpu_command_buffer_stub.h
@@ -0,0 +1,41 @@ +// Copyright (c) 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_IPC_SERVICE_WEBGPU_COMMAND_BUFFER_STUB_H_ +#define GPU_IPC_SERVICE_WEBGPU_COMMAND_BUFFER_STUB_H_ + +#include "gpu/ipc/service/command_buffer_stub.h" + +namespace gpu { + +class GPU_IPC_SERVICE_EXPORT WebGPUCommandBufferStub + : public CommandBufferStub { + public: + WebGPUCommandBufferStub(GpuChannel* channel, + const GPUCreateCommandBufferConfig& init_params, + CommandBufferId command_buffer_id, + SequenceId sequence_id, + int32_t stream_id, + int32_t route_id); + ~WebGPUCommandBufferStub() override; + + // This must leave the GL context associated with the newly-created + // CommandBufferStub current, so the GpuChannel can initialize + // the gpu::Capabilities. + gpu::ContextResult Initialize( + CommandBufferStub* share_group, + const GPUCreateCommandBufferConfig& init_params, + base::UnsafeSharedMemoryRegion shared_state_shm) override; + + private: + void OnTakeFrontBuffer(const Mailbox& mailbox) override; + void OnReturnFrontBuffer(const Mailbox& mailbox, bool is_lost) override; + void OnSwapBuffers(uint64_t swap_id, uint32_t flags) override; + + DISALLOW_COPY_AND_ASSIGN(WebGPUCommandBufferStub); +}; + +} // namespace gpu + +#endif // GPU_IPC_SERVICE_WEBGPU_COMMAND_BUFFER_STUB_H_
diff --git a/gpu/ipc/webgpu_in_process_context.cc b/gpu/ipc/webgpu_in_process_context.cc new file mode 100644 index 0000000..f4280f86 --- /dev/null +++ b/gpu/ipc/webgpu_in_process_context.cc
@@ -0,0 +1,111 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gpu/ipc/webgpu_in_process_context.h" + +#include <utility> + +#include "base/command_line.h" +#include "base/logging.h" +#include "base/test/test_simple_task_runner.h" +#include "gpu/command_buffer/client/shared_memory_limits.h" +#include "gpu/command_buffer/client/transfer_buffer.h" +#include "gpu/command_buffer/client/webgpu_cmd_helper.h" +#include "gpu/command_buffer/client/webgpu_implementation.h" +#include "gpu/command_buffer/common/command_buffer.h" +#include "gpu/command_buffer/common/constants.h" +#include "gpu/command_buffer/common/context_creation_attribs.h" +#include "gpu/config/gpu_feature_info.h" +#include "gpu/config/gpu_switches.h" +#include "gpu/ipc/common/surface_handle.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace gpu { + +WebGPUInProcessContext::WebGPUInProcessContext() = default; + +WebGPUInProcessContext::~WebGPUInProcessContext() { + // Trigger any pending lost contexts. First do a full sync between client + // and service threads. Then execute any pending tasks. + if (webgpu_implementation_) { + // TODO(crbug.com/868192): do the equivalent of a glFinish here? + client_task_runner_->RunUntilIdle(); + webgpu_implementation_.reset(); + } + transfer_buffer_.reset(); + helper_.reset(); + command_buffer_.reset(); +} + +ContextResult WebGPUInProcessContext::Initialize( + scoped_refptr<CommandBufferTaskExecutor> task_executor, + const ContextCreationAttribs& attribs, + const SharedMemoryLimits& memory_limits, + GpuMemoryBufferManager* gpu_memory_buffer_manager, + ImageFactory* image_factory, + GpuChannelManagerDelegate* gpu_channel_manager_delegate) { + DCHECK(attribs.context_type == CONTEXT_TYPE_WEBGPU); + + if (attribs.context_type != CONTEXT_TYPE_WEBGPU || + attribs.enable_raster_interface || attribs.enable_gles2_interface) { + return ContextResult::kFatalFailure; + } + + client_task_runner_ = base::MakeRefCounted<base::TestSimpleTaskRunner>(); + command_buffer_ = + std::make_unique<InProcessCommandBuffer>(std::move(task_executor)); + + static const scoped_refptr<gl::GLSurface> surface = nullptr; + static constexpr bool is_offscreen = true; + static constexpr InProcessCommandBuffer* share_group = nullptr; + auto result = command_buffer_->Initialize( + surface, is_offscreen, kNullSurfaceHandle, attribs, share_group, + gpu_memory_buffer_manager, image_factory, gpu_channel_manager_delegate, + client_task_runner_, nullptr, nullptr); + if (result != ContextResult::kSuccess) { + DLOG(ERROR) << "Failed to initialize InProcessCommmandBuffer"; + return result; + } + + // Check for consistency. + DCHECK(!attribs.bind_generates_resource); + + // Create the WebGPUCmdHelper, which writes the command buffer protocol. + auto webgpu_helper = + std::make_unique<webgpu::WebGPUCmdHelper>(command_buffer_.get()); + result = webgpu_helper->Initialize(memory_limits.command_buffer_size); + if (result != ContextResult::kSuccess) { + LOG(ERROR) << "Failed to initialize WebGPUCmdHelper"; + return result; + } + transfer_buffer_ = std::make_unique<TransferBuffer>(webgpu_helper.get()); + + webgpu_implementation_ = + std::make_unique<webgpu::WebGPUImplementation>(webgpu_helper.get()); + helper_ = std::move(webgpu_helper); + return result; +} + +const Capabilities& WebGPUInProcessContext::GetCapabilities() const { + return command_buffer_->GetCapabilities(); +} + +const GpuFeatureInfo& WebGPUInProcessContext::GetGpuFeatureInfo() const { + return command_buffer_->GetGpuFeatureInfo(); +} + +webgpu::WebGPUInterface* WebGPUInProcessContext::GetImplementation() { + return webgpu_implementation_.get(); +} + +ServiceTransferCache* WebGPUInProcessContext::GetTransferCacheForTest() const { + return command_buffer_->GetTransferCacheForTest(); +} + +InProcessCommandBuffer* WebGPUInProcessContext::GetCommandBufferForTest() + const { + return command_buffer_.get(); +} + +} // namespace gpu
diff --git a/gpu/ipc/webgpu_in_process_context.h b/gpu/ipc/webgpu_in_process_context.h new file mode 100644 index 0000000..7ef77c59 --- /dev/null +++ b/gpu/ipc/webgpu_in_process_context.h
@@ -0,0 +1,73 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef GPU_IPC_WEBGPU_IN_PROCESS_CONTEXT_H_ +#define GPU_IPC_WEBGPU_IN_PROCESS_CONTEXT_H_ + +#include <memory> + +#include "base/macros.h" +#include "base/memory/scoped_refptr.h" +#include "base/single_thread_task_runner.h" +#include "gpu/ipc/command_buffer_task_executor.h" +#include "gpu/ipc/in_process_command_buffer.h" + +namespace base { +class TestSimpleTaskRunner; +} // namespace base + +namespace gpu { +class CommandBufferHelper; +class ServiceTransferCache; +class TransferBuffer; +struct GpuFeatureInfo; +struct SharedMemoryLimits; + +namespace webgpu { +class WebGPUInterface; +class WebGPUImplementation; +} // namespace webgpu + +// Runs client and server side command buffer code in process. Only supports +// WebGPUInterface. +class WebGPUInProcessContext { + public: + WebGPUInProcessContext(); + ~WebGPUInProcessContext(); + + // |attrib_list| must be null or a NONE-terminated list of attribute/value + // pairs. |gpu_channel_manager| should be non-null when used in the GPU + // process. + ContextResult Initialize( + scoped_refptr<CommandBufferTaskExecutor> task_executor, + const ContextCreationAttribs& attribs, + const SharedMemoryLimits& memory_limits, + GpuMemoryBufferManager* gpu_memory_buffer_manager, + ImageFactory* image_factory, + GpuChannelManagerDelegate* gpu_channel_manager_delegate); + + const Capabilities& GetCapabilities() const; + const GpuFeatureInfo& GetGpuFeatureInfo() const; + + // Allows direct access to the WebGPUImplementation so a + // WebGPUInProcessContext can be used without making it current. + gpu::webgpu::WebGPUInterface* GetImplementation(); + + // Test only functions. + ServiceTransferCache* GetTransferCacheForTest() const; + InProcessCommandBuffer* GetCommandBufferForTest() const; + + private: + std::unique_ptr<CommandBufferHelper> helper_; + std::unique_ptr<TransferBuffer> transfer_buffer_; + std::unique_ptr<webgpu::WebGPUImplementation> webgpu_implementation_; + std::unique_ptr<InProcessCommandBuffer> command_buffer_; + scoped_refptr<base::TestSimpleTaskRunner> client_task_runner_; + + DISALLOW_COPY_AND_ASSIGN(WebGPUInProcessContext); +}; + +} // namespace gpu + +#endif // GPU_IPC_WEBGPU_IN_PROCESS_CONTEXT_H_
diff --git a/headless/test/data/protocol/sanity/renderer-in-cross-origin-object-expected.txt b/headless/test/data/protocol/sanity/renderer-in-cross-origin-object-expected.txt index eef4a3d1..21f5e4b 100644 --- a/headless/test/data/protocol/sanity/renderer-in-cross-origin-object-expected.txt +++ b/headless/test/data/protocol/sanity/renderer-in-cross-origin-object-expected.txt
@@ -2,5 +2,4 @@ requested url: http://foo.com/ requested url: http://bar.com/ Blocked a frame with origin "http://foo.com" from accessing a cross-origin frame. - Pass \ No newline at end of file
diff --git a/infra/config/global/cr-buildbucket.cfg b/infra/config/global/cr-buildbucket.cfg index a06f7f2b..3e7a41a 100644 --- a/infra/config/global/cr-buildbucket.cfg +++ b/infra/config/global/cr-buildbucket.cfg
@@ -1602,12 +1602,6 @@ mixins: "android-fyi-ci" } builders { - name: "Mac Builder (dbg) Goma Canary (clobber)" - dimensions: "os:Mac-10.13" - dimensions: "cores:4" - mixins: "fyi-ci" - } - builders { name: "WebKit Linux Trusty MSAN" dimensions: "os:Ubuntu-14.04" mixins: "webkit-ci" @@ -1652,12 +1646,6 @@ mixins: "lkgr-ci" } builders { - name: "Mac Goma Canary (clobber)" - dimensions: "os:Mac-10.13" - dimensions: "cores:4" - mixins: "fyi-ci" - } - builders { name: "WebKit Linux Trusty ASAN" dimensions: "os:Ubuntu-14.04" mixins: "webkit-ci" @@ -1695,11 +1683,6 @@ mixins: "lkgr-ci" } builders { - name: "Win Builder Goma Canary" - dimensions: "os:Windows-10" - mixins: "fyi-ci" - } - builders { name: "ASAN Release Media" dimensions: "os:Ubuntu-14.04" mixins: "lkgr-ci" @@ -1745,11 +1728,6 @@ mixins: "chromium-ci" } builders { - name: "Android Builder (dbg) Goma Canary" - dimensions: "os:Ubuntu-14.04" - mixins: "fyi-ci" - } - builders { name: "Oreo Phone Tester" dimensions: "os:Ubuntu-14.04" mixins: "android-ci" @@ -1775,12 +1753,6 @@ mixins: "fyi-ci" } builders { - name: "Mac Goma Canary LocalOutputCache" - dimensions: "os:Mac-10.13" - dimensions: "cores:4" - mixins: "fyi-ci" - } - builders { name: "Android Cronet ARM64 Builder" dimensions: "os:Ubuntu-14.04" mixins: "android-ci" @@ -1820,11 +1792,6 @@ mixins: "memory-ci" } builders { - name: "Win7 Builder Goma Canary" - dimensions: "os:Windows-7" - mixins: "fyi-ci" - } - builders { name: "Mac ASan 64 Tests (1)" dimensions: "os:Mac-10.13" mixins: "memory-ci" @@ -1879,17 +1846,6 @@ mixins: "fyi-ci" } builders { - name: "Mac Builder (dbg) Goma Canary" - dimensions: "os:Mac-10.13" - dimensions: "cores:4" - mixins: "fyi-ci" - } - builders { - name: "Win Builder (dbg) Goma Canary" - dimensions: "os:Windows-10" - mixins: "fyi-ci" - } - builders { name: "Libfuzzer Upload Linux UBSan" dimensions: "os:Ubuntu-14.04" mixins: "fyi-ci" @@ -1954,11 +1910,6 @@ mixins: "fyi-ci" } builders { - name: "Linux x64 Goma Canary LocalOutputCache" - dimensions: "os:Ubuntu-14.04" - mixins: "fyi-ci" - } - builders { name: "Android Cronet KitKat Builder" dimensions: "os:Ubuntu-14.04" mixins: "android-fyi-ci" @@ -2060,16 +2011,6 @@ mixins: "fyi-ci" } builders { - name: "Linux Builder Goma Canary" - dimensions: "os:Ubuntu-14.04" - mixins: "fyi-ci" - } - builders { - name: "Win cl.exe Goma Canary LocalOutputCache" - dimensions: "os:Windows-10" - mixins: "fyi-ci" - } - builders { name: "Linux remote_run Builder" dimensions: "os:Ubuntu-14.04" mixins: "fyi-ci" @@ -2080,11 +2021,6 @@ mixins: "android-fyi-ci" } builders { - name: "Win7 Builder (dbg) Goma Canary" - dimensions: "os:Windows-7" - mixins: "fyi-ci" - } - builders { name: "Android Cronet ARM64 Builder (dbg)" dimensions: "os:Ubuntu-14.04" mixins: "android-ci" @@ -2130,11 +2066,6 @@ mixins: "fyi-ci" } builders { - name: "Win Goma Canary LocalOutputCache" - dimensions: "os:Windows-10" - mixins: "fyi-ci" - } - builders { name: "Linux Chromium OS ASan LSan Tests (1)" dimensions: "os:Ubuntu-14.04" mixins: "memory-ci" @@ -2150,12 +2081,6 @@ mixins: "android-fyi-ci" } builders { - name: "Mac Builder Goma Canary" - dimensions: "os:Mac-10.13" - dimensions: "cores:4" - mixins: "fyi-ci" - } - builders { name: "Chromium Windows Analyze" dimensions: "os:Windows-10" mixins: "fyi-ci" @@ -2178,16 +2103,6 @@ mixins: "lkgr-ci" } builders { - name: "WinMSVC64 Goma Canary" - dimensions: "os:Windows-10" - mixins: "fyi-ci" - } - builders { - name: "Linux x64 Goma Canary (clobber)" - dimensions: "os:Ubuntu-14.04" - mixins: "fyi-ci" - } - builders { name: "WebKit Win10" dimensions: "os:Windows-10" mixins: "webkit-ci" @@ -2235,6 +2150,7 @@ dimensions: "os:Ubuntu-14.04" mixins: "fyi-ci" } + # Goma Staging builders { name: "Chromium Linux Goma RBE Staging (dbg)" dimensions: "os:Ubuntu-14.04" @@ -2287,6 +2203,178 @@ dimensions: "os:Ubuntu-14.04" mixins: "goma-ci" } + # Goma Canary + builders { + name: "Mac Builder (dbg) Goma Canary (clobber)" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Mac Goma Canary (clobber)" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Win Builder Goma Canary" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Android Builder (dbg) Goma Canary" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + builders { + name: "Mac Goma Canary LocalOutputCache" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Win7 Builder Goma Canary" + dimensions: "os:Windows-7" + mixins: "fyi-ci" + } + builders { + name: "Mac Builder (dbg) Goma Canary" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Win Builder (dbg) Goma Canary" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Linux x64 Goma Canary LocalOutputCache" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + builders { + name: "Linux Builder Goma Canary" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + builders { + name: "Win cl.exe Goma Canary LocalOutputCache" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Win7 Builder (dbg) Goma Canary" + dimensions: "os:Windows-7" + mixins: "fyi-ci" + } + builders { + name: "Win Goma Canary LocalOutputCache" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Mac Builder Goma Canary" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "WinMSVC64 Goma Canary" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Linux x64 Goma Canary (clobber)" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + # Goma Latest Client + builders { + name: "Mac Builder (dbg) Goma Latest Client (clobber)" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Mac Goma Latest Client (clobber)" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Win Builder Goma Latest Client" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Android Builder (dbg) Goma Latest Client" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + builders { + name: "Mac Goma Latest Client LocalOutputCache" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Win7 Builder Goma Latest Client" + dimensions: "os:Windows-7" + mixins: "fyi-ci" + } + builders { + name: "Mac Builder (dbg) Goma Latest Client" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "Win Builder (dbg) Goma Latest Client" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Linux x64 Goma Latest Client LocalOutputCache" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + builders { + name: "Linux Builder Goma Latest Client" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } + builders { + name: "Win cl.exe Goma Latest Client LocalOutputCache" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Win7 Builder (dbg) Goma Latest Client" + dimensions: "os:Windows-7" + mixins: "fyi-ci" + } + builders { + name: "Win Goma Latest Client LocalOutputCache" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Mac Builder Goma Latest Client" + dimensions: "os:Mac-10.13" + dimensions: "cores:4" + mixins: "fyi-ci" + } + builders { + name: "WinMSVC64 Goma Latest Client" + dimensions: "os:Windows-10" + mixins: "fyi-ci" + } + builders { + name: "Linux x64 Goma Latest Client (clobber)" + dimensions: "os:Ubuntu-14.04" + mixins: "fyi-ci" + } ############################################################################ # End luci-check managed section ############################################################################
diff --git a/infra/config/global/luci-milo.cfg b/infra/config/global/luci-milo.cfg index 961da339..772d51c0 100644 --- a/infra/config/global/luci-milo.cfg +++ b/infra/config/global/luci-milo.cfg
@@ -2030,11 +2030,6 @@ short_name: "mac" } builders { - name: "buildbot/chromium.clang/CFI Linux (icall)" - category: "CFI|Linux" - short_name: "icl" - } - builders { name: "buildbot/chromium.clang/CFI Linux CF" category: "CFI|Linux" short_name: "CF"
diff --git a/ios/chrome/browser/ui/authentication/unified_consent/BUILD.gn b/ios/chrome/browser/ui/authentication/unified_consent/BUILD.gn index adf983247..7fa67df 100644 --- a/ios/chrome/browser/ui/authentication/unified_consent/BUILD.gn +++ b/ios/chrome/browser/ui/authentication/unified_consent/BUILD.gn
@@ -29,6 +29,7 @@ "identity_picker_view.mm", "unified_consent_view_controller.h", "unified_consent_view_controller.mm", + "unified_consent_view_controller_delegate.h", ] deps = [ "resources:ic_assistant",
diff --git a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm index 225970a..e0848c79 100644 --- a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm +++ b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm
@@ -9,13 +9,14 @@ #import "ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_coordinator_delegate.h" #import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_mediator.h" #import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h" +#import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller_delegate.h" #if !defined(__has_feature) || !__has_feature(objc_arc) #error "This file requires ARC support." #endif -@interface UnifiedConsentCoordinator ()<UnifiedConsentViewControllerDelegate, - IdentityChooserCoordinatorDelegate> +@interface UnifiedConsentCoordinator ()<IdentityChooserCoordinatorDelegate, + UnifiedConsentViewControllerDelegate> @property(nonatomic, strong) UnifiedConsentMediator* unifiedConsentMediator; @property(nonatomic, strong, readwrite)
diff --git a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h index f39ee6a5..5d8bba0e 100644 --- a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h +++ b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h
@@ -12,27 +12,7 @@ // Accessibility identifier for |-UnifiedConsentViewController.view|. extern NSString* const kUnifiedConsentScrollViewIdentifier; -@class UnifiedConsentViewController; - -// Delegate protocol for UnifiedConsentViewController. -@protocol UnifiedConsentViewControllerDelegate<NSObject> - -// Called when the user taps on the settings link. -- (void)unifiedConsentViewControllerDidTapSettingsLink: - (UnifiedConsentViewController*)controller; - -// Called when the user taps at |point| on the IdentityPickerView. |point| is in -// the window coordinates. -- (void)unifiedConsentViewControllerDidTapIdentityPickerView: - (UnifiedConsentViewController*)controller - atPoint:(CGPoint)point; - -// Called when the user scrolls down to the bottom (or when the view controller -// is loaded with no scroll needed). -- (void)unifiedConsentViewControllerDidReachBottom: - (UnifiedConsentViewController*)controller; - -@end +@protocol UnifiedConsentViewControllerDelegate; // UnifiedConsentViewController is a sub view controller to ask for the user // consent before the user can sign-in.
diff --git a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm index 5539323..b5b9f05 100644 --- a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm +++ b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
@@ -9,6 +9,7 @@ #include "ios/chrome/browser/application_context.h" #import "ios/chrome/browser/ui/authentication/authentication_constants.h" #import "ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.h" +#import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller_delegate.h" #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h" #import "ios/chrome/browser/ui/uikit_ui_util.h" #import "ios/chrome/browser/ui/util/label_link_controller.h"
diff --git a/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller_delegate.h b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller_delegate.h new file mode 100644 index 0000000..60e5d53 --- /dev/null +++ b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller_delegate.h
@@ -0,0 +1,32 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef IOS_CHROME_BROWSER_UI_AUTHENTICATION_UNIFIED_CONSENT_UNIFIED_CONSENT_VIEW_CONTROLLER_DELEGATE_H_ +#define IOS_CHROME_BROWSER_UI_AUTHENTICATION_UNIFIED_CONSENT_UNIFIED_CONSENT_VIEW_CONTROLLER_DELEGATE_H_ + +#import <UIKit/UIKit.h> + +@class UnifiedConsentViewController; + +// Delegate protocol for UnifiedConsentViewController. +@protocol UnifiedConsentViewControllerDelegate<NSObject> + +// Called when the user taps on the settings link. +- (void)unifiedConsentViewControllerDidTapSettingsLink: + (UnifiedConsentViewController*)controller; + +// Called when the user taps at |point| on the IdentityPickerView. |point| is in +// the window coordinates. +- (void)unifiedConsentViewControllerDidTapIdentityPickerView: + (UnifiedConsentViewController*)controller + atPoint:(CGPoint)point; + +// Called when the user scrolls down to the bottom (or when the view controller +// is loaded with no scroll needed). +- (void)unifiedConsentViewControllerDidReachBottom: + (UnifiedConsentViewController*)controller; + +@end + +#endif // IOS_CHROME_BROWSER_UI_AUTHENTICATION_UNIFIED_CONSENT_UNIFIED_CONSENT_VIEW_CONTROLLER_DELEGATE_H_
diff --git a/ios/chrome/browser/ui/bubble/bubble_presenter.mm b/ios/chrome/browser/ui/bubble/bubble_presenter.mm index a7c5893..2ffaaf7 100644 --- a/ios/chrome/browser/ui/bubble/bubble_presenter.mm +++ b/ios/chrome/browser/ui/bubble/bubble_presenter.mm
@@ -7,6 +7,7 @@ #include "base/bind.h" #include "base/metrics/user_metrics.h" #include "base/metrics/user_metrics_action.h" +#include "components/feature_engagement/public/event_constants.h" #include "components/feature_engagement/public/feature_constants.h" #include "components/feature_engagement/public/tracker.h" #include "ios/chrome/browser/browser_state/chrome_browser_state.h" @@ -142,6 +143,7 @@ [self.tabTipBubblePresenter dismissAnimated:NO]; [self.incognitoTabTipBubblePresenter dismissAnimated:NO]; [self.bottomToolbarTipBubblePresenter dismissAnimated:NO]; + [self.longPressToolbarTipBubblePresenter dismissAnimated:NO]; } - (void)userEnteredTabSwitcher { @@ -208,7 +210,7 @@ if (!presenter) return; - self.bottomToolbarTipBubblePresenter = presenter; + self.longPressToolbarTipBubblePresenter = presenter; } // Presents and returns a bubble view controller for the |feature| with an arrow @@ -266,6 +268,8 @@ return; self.bottomToolbarTipBubblePresenter = presenter; + feature_engagement::TrackerFactory::GetForBrowserState(self.browserState) + ->NotifyEvent(feature_engagement::events::kBottomToolbarOpened); } // Optionally presents a bubble associated with the new tab tip in-product help
diff --git a/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm b/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm index 50fa9bb..e644d6d5 100644 --- a/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm +++ b/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm
@@ -57,10 +57,14 @@ - (BOOL)webViewScrollViewShouldScrollToTop: (CRWWebViewScrollViewProxy*)webViewScrollViewProxy { - // Inform FullscreenUIElements that the content is going to be scrolled to the - // top. - self.mediator->ScrollToTop(); - return YES; + if (self.model->progress() > 0.05) { + // Inform FullscreenUIElements that the content is going to be scrolled to + // the top. + self.mediator->ScrollToTop(); + return YES; + } else { + return NO; + } } @end
diff --git a/ios/chrome/browser/ui/list_model/list_model.h b/ios/chrome/browser/ui/list_model/list_model.h index 844e7f1..94bbf4d 100644 --- a/ios/chrome/browser/ui/list_model/list_model.h +++ b/ios/chrome/browser/ui/list_model/list_model.h
@@ -96,6 +96,10 @@ // left in the section, they are removed. - (void)removeSectionWithIdentifier:(NSInteger)sectionIdentifier; +// Deletes all items from |sectionIdentifier|, |sectionIdentifier| won't be +// removed from the model. +- (void)deleteAllItemsFromSectionWithIdentifier:(NSInteger)sectionIdentifier; + // Sets the header item for the section with the given |sectionIdentifier|. - (void)setHeader:(SupplementalType)header forSectionWithIdentifier:(NSInteger)sectionIdentifier;
diff --git a/ios/chrome/browser/ui/list_model/list_model.mm b/ios/chrome/browser/ui/list_model/list_model.mm index 0b64a03..951df5b 100644 --- a/ios/chrome/browser/ui/list_model/list_model.mm +++ b/ios/chrome/browser/ui/list_model/list_model.mm
@@ -114,6 +114,12 @@ [_collapsedKeys removeObjectForKey:@(sectionIdentifier)]; } +- (void)deleteAllItemsFromSectionWithIdentifier:(NSInteger)sectionIdentifier { + NSInteger section = [self sectionForSectionIdentifier:sectionIdentifier]; + SectionItems* items = [_sections objectAtIndex:section]; + [items removeAllObjects]; +} + - (void)setHeader:(ListItem*)header forSectionWithIdentifier:(NSInteger)sectionIdentifier { NSNumber* key = [NSNumber numberWithInteger:sectionIdentifier];
diff --git a/ios/chrome/browser/ui/list_model/list_model_unittest.mm b/ios/chrome/browser/ui/list_model/list_model_unittest.mm index 4a94463..da4fe615 100644 --- a/ios/chrome/browser/ui/list_model/list_model_unittest.mm +++ b/ios/chrome/browser/ui/list_model/list_model_unittest.mm
@@ -384,6 +384,70 @@ EXPECT_EQ(2, indexPath.item); } +TEST_F(ListModelTest, RemoveAllItems) { + ListModel* model = [[ListModel alloc] init]; + + [model addSectionWithIdentifier:SectionIdentifierCheese]; + [model addItemWithType:ItemTypeCheesePepperJack + toSectionWithIdentifier:SectionIdentifierCheese]; + [model addItemWithType:ItemTypeCheeseGouda + toSectionWithIdentifier:SectionIdentifierCheese]; + + [model addSectionWithIdentifier:SectionIdentifierWeasley]; + [model addItemWithType:ItemTypeWeasleyGinny + toSectionWithIdentifier:SectionIdentifierWeasley]; + [model addItemWithType:ItemTypeWeasleyArthur + toSectionWithIdentifier:SectionIdentifierWeasley]; + + [model deleteAllItemsFromSectionWithIdentifier:SectionIdentifierCheese]; + + // Check we still have two sections. + EXPECT_EQ(2, [model numberOfSections]); + + // Check we have no more items in first section. + EXPECT_EQ(0, [model numberOfItemsInSection:0]); + EXPECT_EQ(2, [model numberOfItemsInSection:1]); + + // Check the index path retrieval method for a single item. + NSIndexPath* indexPath = + [model indexPathForItemType:ItemTypeWeasleyGinny + sectionIdentifier:SectionIdentifierWeasley]; + EXPECT_EQ(1, indexPath.section); + EXPECT_EQ(0, indexPath.item); + + [model addItemWithType:ItemTypeCheeseGouda + toSectionWithIdentifier:SectionIdentifierCheese]; + + // Check we could still add to the section. + EXPECT_EQ(1, [model numberOfItemsInSection:0]); + EXPECT_EQ(2, [model numberOfItemsInSection:1]); +} + +TEST_F(ListModelTest, RemoveAllItemsFromAnEmptySection) { + ListModel* model = [[ListModel alloc] init]; + + [model addSectionWithIdentifier:SectionIdentifierCheese]; + + [model addSectionWithIdentifier:SectionIdentifierWeasley]; + [model addItemWithType:ItemTypeWeasleyGinny + toSectionWithIdentifier:SectionIdentifierWeasley]; + [model addItemWithType:ItemTypeWeasleyArthur + toSectionWithIdentifier:SectionIdentifierWeasley]; + + // Check we have no more items in first section. + EXPECT_EQ(0, [model numberOfItemsInSection:0]); + EXPECT_EQ(2, [model numberOfItemsInSection:1]); + + [model deleteAllItemsFromSectionWithIdentifier:SectionIdentifierCheese]; + + // Check we still have two sections. + EXPECT_EQ(2, [model numberOfSections]); + + // Check we still have no items in first section. + EXPECT_EQ(0, [model numberOfItemsInSection:0]); + EXPECT_EQ(2, [model numberOfItemsInSection:1]); +} + TEST_F(ListModelTest, RemoveSections) { ListModel* model = [[ListModel alloc] init];
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm index 9a2c5a76..fa8876117 100644 --- a/ios/web/web_state/ui/crw_web_controller.mm +++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2069,6 +2069,7 @@ [_webView stopLoading]; [_pendingNavigationInfo setCancelled:YES]; _certVerificationErrors->Clear(); + web::WebFramesManagerImpl::FromWebState(self.webState)->RemoveAllWebFrames(); [self loadCancelled]; } @@ -4609,6 +4610,7 @@ } } + web::WebFramesManagerImpl::FromWebState(self.webState)->RemoveAllWebFrames(); // This must be reset at the end, since code above may need information about // the pending load. _pendingNavigationInfo = nil; @@ -4700,6 +4702,8 @@ } } + web::WebFramesManagerImpl::FromWebState(self.webState)->RemoveAllWebFrames(); + // This point should closely approximate the document object change, so reset // the list of injected scripts to those that are automatically injected. // Do not inject window ID if this is a placeholder URL: window ID is not @@ -4939,6 +4943,8 @@ [self handleLoadError:WKWebViewErrorWithSource(error, NAVIGATION) forNavigation:navigation]; + + web::WebFramesManagerImpl::FromWebState(self.webState)->RemoveAllWebFrames(); _certVerificationErrors->Clear(); [self forgetNullWKNavigation:navigation]; } @@ -4990,6 +4996,7 @@ [self didReceiveWebViewNavigationDelegateCallback]; _certVerificationErrors->Clear(); + web::WebFramesManagerImpl::FromWebState(self.webState)->RemoveAllWebFrames(); [self webViewWebProcessDidCrash]; }
diff --git a/ios/web/web_state/web_frames_manager_impl.h b/ios/web/web_state/web_frames_manager_impl.h index 0f316a1..5de3c60 100644 --- a/ios/web/web_state/web_frames_manager_impl.h +++ b/ios/web/web_state/web_frames_manager_impl.h
@@ -20,9 +20,14 @@ static WebFramesManagerImpl* FromWebState(WebState* web_state); // Adds |frame| to the list of web frames associated with WebState. + // The frame must not be already in the frame manager (the frame manager must + // not have a frame with the same frame ID). If |frame| is a main frame, the + // frame manager must not have a main frame already. void AddFrame(std::unique_ptr<WebFrame> frame); // Removes the web frame with |frame_id|, if one exists, from the list of // associated web frames. + // If the frame manager does not contain a frame with this ID, operation is a + // no-op. void RemoveFrameWithId(const std::string& frame_id); // Removes all web frames from the list of associated web frames. void RemoveAllWebFrames();
diff --git a/ios/web/web_state/web_frames_manager_impl.mm b/ios/web/web_state/web_frames_manager_impl.mm index 5b902e5..21dab0ae 100644 --- a/ios/web/web_state/web_frames_manager_impl.mm +++ b/ios/web/web_state/web_frames_manager_impl.mm
@@ -51,7 +51,10 @@ : web_state_(web_state) {} void WebFramesManagerImpl::AddFrame(std::unique_ptr<WebFrame> frame) { + DCHECK(frame); + DCHECK(!frame->GetFrameId().empty()); if (frame->IsMainFrame()) { + DCHECK(!main_web_frame_); main_web_frame_ = frame.get(); } DCHECK(web_frames_.count(frame->GetFrameId()) == 0); @@ -59,6 +62,11 @@ } void WebFramesManagerImpl::RemoveFrameWithId(const std::string& frame_id) { + DCHECK(!frame_id.empty()); + // If the removed frame is a main frame, it should be the current one. + DCHECK(web_frames_.count(frame_id) == 0 || + !web_frames_[frame_id]->IsMainFrame() || + main_web_frame_ == web_frames_[frame_id].get()); if (main_web_frame_ && main_web_frame_->GetFrameId() == frame_id) { main_web_frame_ = nullptr; }
diff --git a/media/base/video_frame_layout.h b/media/base/video_frame_layout.h index 52e1a84c..805dac6 100644 --- a/media/base/video_frame_layout.h +++ b/media/base/video_frame_layout.h
@@ -56,11 +56,6 @@ strides_ = std::move(strides); } - // Sets buffer_sizes. - void set_buffer_sizes(std::vector<size_t> buffer_sizes) { - buffer_sizes_ = std::move(buffer_sizes); - } - // Clones this as a explicitly copy constructor. VideoFrameLayout Clone() const;
diff --git a/media/base/video_frame_layout_unittest.cc b/media/base/video_frame_layout_unittest.cc index ee9f9d22..dc55ba6 100644 --- a/media/base/video_frame_layout_unittest.cc +++ b/media/base/video_frame_layout_unittest.cc
@@ -137,18 +137,16 @@ "strides:[0, 0, 0, 0]"); } -TEST(VideoFrameLayout, SetStrideBufferSize) { +TEST(VideoFrameLayout, SetStrideSize) { gfx::Size coded_size = gfx::Size(320, 180); VideoFrameLayout layout(PIXEL_FORMAT_NV12, coded_size); std::vector<int32_t> strides = {384, 192, 192}; layout.set_strides(std::move(strides)); - std::vector<size_t> buffer_sizes = {122880}; - layout.set_buffer_sizes(std::move(buffer_sizes)); EXPECT_EQ(layout.ToString(), "VideoFrameLayout format:PIXEL_FORMAT_NV12 coded_size:320x180 " - "num_buffers:1 buffer_sizes:[122880] num_strides:3 " + "num_buffers:4 buffer_sizes:[0, 0, 0, 0] num_strides:3 " "strides:[384, 192, 192]"); }
diff --git a/media/renderers/paint_canvas_video_renderer.cc b/media/renderers/paint_canvas_video_renderer.cc index 87ad624..8d12b5f 100644 --- a/media/renderers/paint_canvas_video_renderer.cc +++ b/media/renderers/paint_canvas_video_renderer.cc
@@ -295,6 +295,7 @@ void* pixels, size_t row_bytes, size_t frame_index, + cc::PaintImage::GeneratorClientId client_id, uint32_t lazy_pixel_ref) override { DCHECK_EQ(frame_index, 0u);
diff --git a/services/ui/public/cpp/gpu/BUILD.gn b/services/ui/public/cpp/gpu/BUILD.gn index d49bee4b..94dbf46 100644 --- a/services/ui/public/cpp/gpu/BUILD.gn +++ b/services/ui/public/cpp/gpu/BUILD.gn
@@ -35,6 +35,7 @@ "//gpu/command_buffer/client:gles2_cmd_helper", "//gpu/command_buffer/client:gles2_implementation", "//gpu/command_buffer/client:raster", + "//gpu/command_buffer/client:webgpu", "//gpu/command_buffer/common:raster", "//gpu/skia_bindings", "//mojo/public/cpp/system",
diff --git a/testing/buildbot/chromium.chromiumos.json b/testing/buildbot/chromium.chromiumos.json index 4c7285f..fc48a3f 100644 --- a/testing/buildbot/chromium.chromiumos.json +++ b/testing/buildbot/chromium.chromiumos.json
@@ -422,7 +422,7 @@ "args": [ "--enable-features=Mash", "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.browser_tests.filter" + "--test-launcher-filter-file=../../testing/buildbot/filters/mash.browser_tests.filter" ], "name": "mash_browser_tests", "swarming": { @@ -434,20 +434,6 @@ }, { "args": [ - "--enable-features=SingleProcessMash", - "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter" - ], - "name": "single_process_mash_browser_tests", - "swarming": { - "can_use_on_swarming_builders": true, - "hard_timeout": 1800, - "shards": 10 - }, - "test": "browser_tests" - }, - { - "args": [ "--enable-features=VizDisplayCompositor" ], "name": "viz_browser_tests", @@ -1091,24 +1077,11 @@ "args": [ "--enable-features=Mash", "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.browser_tests.filter" + "--test-launcher-filter-file=../../testing/buildbot/filters/mash.browser_tests.filter" ], "name": "mash_browser_tests", "swarming": { "can_use_on_swarming_builders": true, - "hard_timeout": 1800 - }, - "test": "browser_tests" - }, - { - "args": [ - "--enable-features=SingleProcessMash", - "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter" - ], - "name": "single_process_mash_browser_tests", - "swarming": { - "can_use_on_swarming_builders": true, "hard_timeout": 1800, "shards": 10 },
diff --git a/testing/buildbot/chromium.fyi.json b/testing/buildbot/chromium.fyi.json index 1af6fe87..9d4f873f 100644 --- a/testing/buildbot/chromium.fyi.json +++ b/testing/buildbot/chromium.fyi.json
@@ -1451,20 +1451,6 @@ }, { "args": [ - "--enable-features=Mash", - "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter" - ], - "name": "mash_fyi_browser_tests", - "swarming": { - "can_use_on_swarming_builders": true, - "hard_timeout": 1800, - "shards": 10 - }, - "test": "browser_tests" - }, - { - "args": [ "--enable-features=VizDisplayCompositor" ], "name": "viz_browser_tests", @@ -1493,9 +1479,9 @@ }, { "args": [ - "--enable-features=Mash" + "--enable-features=SingleProcessMash" ], - "name": "mash_fyi_content_unittests", + "name": "single_process_mash_content_unittests", "swarming": { "can_use_on_swarming_builders": true },
diff --git a/testing/buildbot/chromium.memory.json b/testing/buildbot/chromium.memory.json index 25997ba7..09a32eb 100644 --- a/testing/buildbot/chromium.memory.json +++ b/testing/buildbot/chromium.memory.json
@@ -4484,7 +4484,7 @@ "args": [ "--enable-features=Mash", "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.browser_tests.filter" + "--test-launcher-filter-file=../../testing/buildbot/filters/mash.browser_tests.filter" ], "name": "mash_browser_tests", "swarming": { @@ -4496,20 +4496,6 @@ }, { "args": [ - "--enable-features=SingleProcessMash", - "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter" - ], - "name": "single_process_mash_browser_tests", - "swarming": { - "can_use_on_swarming_builders": true, - "hard_timeout": 1800, - "shards": 10 - }, - "test": "browser_tests" - }, - { - "args": [ "--enable-features=VizDisplayCompositor" ], "name": "viz_browser_tests", @@ -5152,7 +5138,7 @@ "args": [ "--enable-features=Mash", "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.browser_tests.filter" + "--test-launcher-filter-file=../../testing/buildbot/filters/mash.browser_tests.filter" ], "name": "mash_browser_tests", "swarming": { @@ -5164,20 +5150,6 @@ }, { "args": [ - "--enable-features=SingleProcessMash", - "--override-use-software-gl-for-tests", - "--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter" - ], - "name": "single_process_mash_browser_tests", - "swarming": { - "can_use_on_swarming_builders": true, - "hard_timeout": 1800, - "shards": 10 - }, - "test": "browser_tests" - }, - { - "args": [ "--enable-features=VizDisplayCompositor" ], "name": "viz_browser_tests",
diff --git a/testing/buildbot/filters/BUILD.gn b/testing/buildbot/filters/BUILD.gn index 3e48477..65b07f1 100644 --- a/testing/buildbot/filters/BUILD.gn +++ b/testing/buildbot/filters/BUILD.gn
@@ -20,9 +20,7 @@ testonly = true data = [ - "//testing/buildbot/filters/chromeos.mash.browser_tests.filter", - "//testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter", - "//testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter", + "//testing/buildbot/filters/mash.browser_tests.filter", "//testing/buildbot/filters/mojo.fyi.network_browser_tests.filter", "//testing/buildbot/filters/webui_polymer2_browser_tests.filter", ]
diff --git a/testing/buildbot/filters/chromeos.mash.browser_tests.filter b/testing/buildbot/filters/chromeos.mash.browser_tests.filter deleted file mode 100644 index fb319e2d..0000000 --- a/testing/buildbot/filters/chromeos.mash.browser_tests.filter +++ /dev/null
@@ -1,4 +0,0 @@ -# Sanity test that validates basic login functionality. The full suite of -# Mash browser tests runs on the mojo.fyi waterfall. -# Context: http://crbug.com/874090 -LoginUtilsTest.MashLogin
diff --git a/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter b/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter deleted file mode 100644 index 6512437..0000000 --- a/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter +++ /dev/null
@@ -1,6 +0,0 @@ -# Placeholder tests that validate basic login functionality. -# TODO: replace with full suite and blacklist once it's ready. -# Bug: http://crbug.com/874090 -LoginPromptBrowserTest.* -LoginUtilsTest.* -LoginUIKeyboardTestWithUsersAndOwner.*
diff --git a/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter b/testing/buildbot/filters/mash.browser_tests.filter similarity index 100% rename from testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter rename to testing/buildbot/filters/mash.browser_tests.filter
diff --git a/testing/buildbot/test_suites.pyl b/testing/buildbot/test_suites.pyl index 825bcf4..f980bdb 100644 --- a/testing/buildbot/test_suites.pyl +++ b/testing/buildbot/test_suites.pyl
@@ -1730,53 +1730,13 @@ }, }, - 'mash_fyi_chromium_gtests': { - 'mash_fyi_browser_tests': { - 'test': 'browser_tests', - 'args': [ - '--enable-features=Mash', - '--override-use-software-gl-for-tests', - '--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter', - ], - 'swarming': { - 'hard_timeout': 1800, - 'shards': 10, - }, - }, - 'mash_fyi_content_unittests': { - 'test': 'content_unittests', - 'args': [ - '--enable-features=Mash', - ], - }, - }, - - # These can be folded into linux_chromeos_specific_gtests once we stop moving - # tests around on the main waterfall. - 'mash_chromium_gtests' : { + 'mash_chromium_gtests': { 'mash_browser_tests': { 'test': 'browser_tests', 'args': [ '--enable-features=Mash', '--override-use-software-gl-for-tests', - '--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.mash.browser_tests.filter', - ], - 'swarming': { - 'hard_timeout': 1800, - 'shards': 1, - }, - }, - }, - - # These can be folded into linux_chromeos_specific_gtests once we stop moving - # tests around on the main waterfall. - 'single_process_mash_chromium_gtests': { - 'single_process_mash_browser_tests': { - 'test': 'browser_tests', - 'args': [ - '--enable-features=SingleProcessMash', - '--override-use-software-gl-for-tests', - '--test-launcher-filter-file=../../testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter', + '--test-launcher-filter-file=../../testing/buildbot/filters/mash.browser_tests.filter', ], 'swarming': { 'hard_timeout': 1800, @@ -2064,7 +2024,6 @@ ], 'test': 'content_browsertests', }, - 'not_site_per_process_content_unittests': { 'args': [ '--disable-site-isolation-trials' @@ -2408,13 +2367,13 @@ # linux_chromium_gtests # - non_android_and_cast_and_chromeos_chromium_gtests # + linux_chromeos_specific_gtests + # + mash_chromium_gtests 'aura_gtests', 'chromium_gtests', 'chromium_gtests_for_devices_with_graphical_output', 'chromium_gtests_for_linux_and_chromeos_only', 'linux_chromeos_specific_gtests', 'linux_flavor_specific_chromium_gtests', - 'single_process_mash_chromium_gtests', 'mash_chromium_gtests', 'non_android_chromium_gtests', ], @@ -2749,7 +2708,7 @@ 'mojo_chromiumos_fyi_gtests': [ 'aura_gtests', - 'mash_fyi_chromium_gtests', + 'mash_chromium_gtests', 'mojo_chromiumos_specific_gtests', 'viz_gtests', 'viz_non_android_fyi_gtests',
diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json index 1cbcc59..5e57522 100644 --- a/testing/variations/fieldtrial_testing_config.json +++ b/testing/variations/fieldtrial_testing_config.json
@@ -4878,6 +4878,24 @@ ] } ], + "WebRTC-Aec3AgcGainChangeResponseKillSwitch": [ + { + "platforms": [ + "chromeos", + "linux", + "mac", + "windows" + ], + "experiments": [ + { + "name": "Default", + "enable_features": [ + "WebRTC-Aec3AgcGainChangeResponseKillSwitch" + ] + } + ] + } + ], "WebRTC-ApmGainController2Limiter": [ { "platforms": [
diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG index 92a383e83..ef8c077 100644 --- a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG +++ b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
@@ -30,6 +30,9 @@ # Superscript text off by 1px crbug.com/636993 external/wpt/css/css-text-decor/text-decoration-color.html [ Failure ] +# text-overflow:ellipsis and paint fragment +crbug.com/873957 http/tests/devtools/network/network-cookies-pane.js [ Failure ] + # rightsizing-grid.html is truly flaky, show flakiness on reload # Features that do not have active plans to support or turn on.
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 60fabcc..0ce8dfc 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1761,6 +1761,7 @@ crbug.com/840017 virtual/threaded/fast/events/pinch/pinch-zoom-into-center.html [ Failure Pass ] crbug.com/840017 virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html [ Failure Pass ] crbug.com/840017 virtual/threaded/fast/events/pinch/pinch-zoom-pan-within-zoomed-viewport.html [ Failure Pass ] +crbug.com/877361 virtual/threaded/fast/events/pinch/gesture-pinch-zoom-scroll-bubble.html [ Timeout Pass ] crbug.com/522648 fast/events/touch/compositor-touch-hit-rects-iframes.html [ Crash Failure Pass ] crbug.com/522648 virtual/mouseevent_fractional/fast/events/touch/compositor-touch-hit-rects-iframes.html [ Crash Failure Pass ] @@ -2727,12 +2728,17 @@ crbug.com/875249 external/wpt/infrastructure/testdriver/bless.html [ Timeout Pass ] # ====== New tests from wpt-importer added here ====== +crbug.com/626703 external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ] +crbug.com/626703 virtual/outofblink-cors/external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ] +crbug.com/626703 virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ] +crbug.com/626703 external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.html [ Timeout ] +crbug.com/626703 virtual/service-worker-servicification/external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ] crbug.com/626703 external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/fieldset-containing-block.html [ Failure ] crbug.com/626703 external/wpt/quirks/text-decoration-doesnt-propagate-into-tables/quirks.html [ Failure ] crbug.com/626703 external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/fieldset-transform-translatez.html [ Failure ] crbug.com/626703 external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/fieldset-overflow-hidden.html [ Failure ] crbug.com/626703 [ Mac10.12 ] external/wpt/webxr/xrSession_requestAnimationFrame_getDevicePose.https.html [ Failure Timeout ] -crbug.com/626703 [ Mac10.10 ] external/wpt/editing/run/delete.html?2001-3000 [ Failure Timeout ] +crbug.com/877300 external/wpt/editing/run/delete.html?2001-3000 [ Timeout Pass ] crbug.com/626703 external/wpt/payment-request/payment-response/onpayerdetailchange-attribute.manual.https.html [ Timeout ] crbug.com/626703 external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/fieldset-painting-order.html [ Failure ] crbug.com/626703 external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/tasks.window.html [ Timeout ] @@ -5041,4 +5047,7 @@ crbug.com/877183 [ Linux Win ] external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html [ Pass Failure ] # Sheriff 2018-08-24 +crbug.com/877104 external/wpt/editing/run/delete.html?1-1000 [ Timeout Pass ] crbug.com/877299 external/wpt/editing/run/forwarddelete.html?1-1000 [ Timeout Pass ] +crbug.com/877292 external/wpt/editing/run/forwarddelete.html?2001-3000 [ Timeout Pass ] +crbug.com/877293 external/wpt/editing/run/forwarddelete.html?3001-4000 [ Timeout Pass ]
diff --git a/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt b/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt index 3b68714..c32bbfe 100644 --- a/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 26: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Make sure that a debug assert is not triggered when a call to LayoutBlockFlow::deleteLineBoxTree calls AccessibilityRenderObject::accessibilityIsIgnored which may require the AXObject for a node that is being deleted. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/accessibility/menu-list-sends-change-notification-expected.txt b/third_party/WebKit/LayoutTests/accessibility/menu-list-sends-change-notification-expected.txt index c6b263cc..4c8b011 100644 --- a/third_party/WebKit/LayoutTests/accessibility/menu-list-sends-change-notification-expected.txt +++ b/third_party/WebKit/LayoutTests/accessibility/menu-list-sends-change-notification-expected.txt
@@ -6,6 +6,7 @@ PASS successfullyParsed is true + TEST COMPLETE Got notification: MenuListValueChanged
diff --git a/third_party/WebKit/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt b/third_party/WebKit/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt index c1f89c9..7f9a04d2 100644 --- a/third_party/WebKit/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt +++ b/third_party/WebKit/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt
@@ -6,24 +6,43 @@ PASS successfullyParsed is true + TEST COMPLETE + PASS accessibleOne.isSelected is true + PASS accessibleOne.isSelectedOptionActive is true + PASS accessibleTwo.isSelected is false + PASS accessibleTwo.isSelectedOptionActive is false + PASS accessibleThree.isSelected is false + PASS accessibleThree.isSelectedOptionActive is false + PASS accessibleOne.isSelected is false + PASS accessibleOne.isSelectedOptionActive is false + PASS accessibleTwo.isSelected is true + PASS accessibleTwo.isSelectedOptionActive is true + PASS accessibleThree.isSelected is false + PASS accessibleThree.isSelectedOptionActive is false + PASS accessibleOne.isSelected is false + PASS accessibleOne.isSelectedOptionActive is false + PASS accessibleTwo.isSelected is true + PASS accessibleTwo.isSelectedOptionActive is false + PASS accessibleThree.isSelected is true + PASS accessibleThree.isSelectedOptionActive is true List notification: ActiveDescendantChanged List notification: SelectedChildrenChanged
diff --git a/third_party/WebKit/LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize-expected.txt b/third_party/WebKit/LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize-expected.txt index 4cd34ec0..0f449d3 100644 --- a/third_party/WebKit/LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize-expected.txt +++ b/third_party/WebKit/LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS window.innerWidth is 800 PASS window.innerHeight is 600 PASS getComputedStyle(test).fontSize is '30px'
diff --git a/third_party/WebKit/LayoutTests/editing/pasteboard/innerText-inline-table.html b/third_party/WebKit/LayoutTests/editing/pasteboard/innerText-inline-table.html index 3e78986a..26a9564 100644 --- a/third_party/WebKit/LayoutTests/editing/pasteboard/innerText-inline-table.html +++ b/third_party/WebKit/LayoutTests/editing/pasteboard/innerText-inline-table.html
@@ -5,9 +5,9 @@ <div id="test2">foo <table style="display:inline-table"><tr><td>2</td></tr></table> bar</div> <script> test(() => { - assert_equals('hello 1 world', document.getElementById('test1').innerText, + assert_equals(document.getElementById('test1').innerText, 'hello1world', 'test1.innerText'); - assert_equals('foo 2 bar', document.getElementById('test2').innerText, + assert_equals(document.getElementById('test2').innerText, 'foo 2 bar', 'test2.innerText'); }, 'Checks that the text iterator is emitting a space before and after an inline table'); </script>
diff --git a/third_party/WebKit/LayoutTests/editing/pasteboard/newlines-around-floating-or-positioned.html b/third_party/WebKit/LayoutTests/editing/pasteboard/newlines-around-floating-or-positioned.html index ec304bf..ae207d74 100644 --- a/third_party/WebKit/LayoutTests/editing/pasteboard/newlines-around-floating-or-positioned.html +++ b/third_party/WebKit/LayoutTests/editing/pasteboard/newlines-around-floating-or-positioned.html
@@ -7,19 +7,19 @@ <div id="test4">Lorem<div style="position: absolute;"></div>ipsum</div> <script> test(() => assert_equals( - 'Lorem-ipsum', - document.getElementById('test1').innerText), + document.getElementById('test1').innerText, + 'Lorem\n-\nipsum'), '1 float:left minus'); test(() => assert_equals( - 'Loremipsum', - document.getElementById('test2').innerText), + document.getElementById('test2').innerText, + 'Lorem\nipsum'), '2 float:left empty'); test(() => assert_equals( - 'Lorem-ipsum', - document.getElementById('test3').innerText), + document.getElementById('test3').innerText, + 'Lorem\n-\nipsum'), '3 position:absolute minus'); test(() => assert_equals( - 'Loremipsum', - document.getElementById('test4').innerText), + document.getElementById('test4').innerText, + 'Lorem\nipsum'), '4 position:absolute empty'); </script>
diff --git a/third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt b/third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt index a5809d6a..4501959 100644 --- a/third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt
@@ -1,4 +1,5 @@ CONSOLE ERROR: line 29: The given range isn't in document. +CONSOLE WARNING: line 46: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test error handling of Selection.addRange(). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/505092-fieldset-is-not-ua-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/505092-fieldset-is-not-ua-shadow-crash-expected.txt index abab587..f782200 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/505092-fieldset-is-not-ua-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/505092-fieldset-is-not-ua-shadow-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 7: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test passes if it does not crash
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/adjusting-editing-boundary-with-table-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/adjusting-editing-boundary-with-table-in-shadow-expected.txt index 999c84e..cf151ab 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/adjusting-editing-boundary-with-table-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/adjusting-editing-boundary-with-table-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Selecting around a table which is distributed from shadow subtree to nested shadow subtree will trigger an assertion. To try manually, select from "shadow 2" to around "after" and confirm a crash does not occur. PASS
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/bold-twice-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/bold-twice-in-shadow-expected.txt index 62d79b3..07319a46 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/bold-twice-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/bold-twice-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 20: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Applying document.execCommand('Bold') to elements having insertion points (<shadow> or <content>) shoud not cause a crash. To test manually, make a selection from somewhere in "nested before" to somehwere in "nested after", then press Ctrl+B twice. It should not cause a crash.
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt index 7c0dcba6..be15b06 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 18: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. When selecting from a child of ShadowRoot to an element outside of shadow host, a crash should not be caused. To test manually, select from 'before shadow' to 'after host'.
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-expected.txt index 72e7c1f..9140f901 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundaries-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 16: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. When selecting from a child of shadow host to an element in Shadow DOM, a crash should not be caused. This is because the start position of Selection comes after the end position of Selection. before host drag from here after host
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundary-with-table-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundary-with-table-expected.txt index 9fb67e9..45e72a8 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundary-with-table-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/breaking-editing-boundary-with-table-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 17: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. On the second time selecting <span>, it should not become non-contenteditable. If it becomes non-contenteditable, the selection from <span> to <table> will break editing boundaries and contain "a". This test checks the <span> does not changed to non-contenteditable element. PASS contains(selectedString, "a") is false
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/compare-positions-in-nested-shadow-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/compare-positions-in-nested-shadow-expected.txt index 32ee0bc..d1c332e 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/compare-positions-in-nested-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/compare-positions-in-nested-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 20: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS selection2.anchorNode is selection2.focusNode PASS selection2.anchorOffset is 5 PASS selection2.focusOffset is 0
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-at-shadow-boundary-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-at-shadow-boundary-expected.txt index d713805..03b6566 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-at-shadow-boundary-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-at-shadow-boundary-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that content-editable is not propagated from shadow host to a shadow subtree. This p is required to produce the issue.
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-to-distributed-node-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-to-distributed-node-expected.txt index 4293c561..9ebf4836 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-to-distributed-node-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/contenteditable-propagation-to-distributed-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that contenteditable is propagated to distributed nodes. PASS getComputedStyle(shadowRoot.querySelector('span'), null).webkitUserModify is "read-only"
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/delete-characters-in-distributed-node-crash-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/delete-characters-in-distributed-node-crash-expected.txt index 2f66040..67b1043 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/delete-characters-in-distributed-node-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/delete-characters-in-distributed-node-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 9: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests the deletion of text in distributed node does not crash. To run it outside of DRT, you must delete text, 'foo', manually. PASS
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/delete-list-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/delete-list-in-shadow-expected.txt index bc6e69c4..12d2581e 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/delete-list-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/delete-list-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 22: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Elements distributed to Shadow DOM should be deleted correctly when pressing delete key. To test manually, select somewhere in ABCDE from somehwere in 12345, and press delete, and check the selected text is deleted correctly.
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/execcommand-indent-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/execcommand-indent-in-shadow-expected.txt index 41cf344..f5f1b62 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/execcommand-indent-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/execcommand-indent-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 16: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. In this test, we do execCommand('Indent') in the direct child of ShadowRoot to confirm a crash doesn't happen.
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/insertorderedlist-crash-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/insertorderedlist-crash-expected.txt index d713963d..30bc8bb6 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/insertorderedlist-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/insertorderedlist-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test confirms some combination of editing command with Shadow DOM does not cause a crash. To test manually, select from (before nested) to (after nested), then press Italic, and InsertUnorderedList. PASS
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/pressing-enter-on-list-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/pressing-enter-on-list-expected.txt index 75e3968..daf0dc1 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/pressing-enter-on-list-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/pressing-enter-on-list-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 22: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Pressing enter on the last character of <li> element in Shadow DOM was triggering assertion, because modifying Shadow DOM removes the renderer in Shadow DOM and desendant of shadow host. This tests confirms it won't happen any more.
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt index a227218..4939f4f0 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 17: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test ensures context click around meter won't crash. PASS
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/select-contenteditable-shadowhost-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/select-contenteditable-shadowhost-expected.txt index a390790..31cb6d9 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/select-contenteditable-shadowhost-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/select-contenteditable-shadowhost-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test confirms that selecting an element having Shadow DOM doesn't cross editing boundaries errornously. BEFORE
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/selection-all-with-shadow-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/selection-all-with-shadow-expected.txt index 404ded3..8d5915d 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/selection-all-with-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/selection-all-with-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 24: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. SelectAll and Shadow DOM Tree On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/selection-of-orphan-shadowroot-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/selection-of-orphan-shadowroot-expected.txt index 2fcc79e..77a0d33 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/selection-of-orphan-shadowroot-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/selection-of-orphan-shadowroot-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 16: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Nodes of the selection for an orphan shadow root should return null. PASS selection.anchorNode is null
diff --git a/third_party/WebKit/LayoutTests/editing/shadow/shadow-selection-not-exported-expected.txt b/third_party/WebKit/LayoutTests/editing/shadow/shadow-selection-not-exported-expected.txt index 7067bcd..91372fda 100644 --- a/third_party/WebKit/LayoutTests/editing/shadow/shadow-selection-not-exported-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/shadow/shadow-selection-not-exported-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 16: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS assertNotInShadow(selection.anchorNode) is true PASS assertNotInShadow(selection.focusNode) is true PASS assertNotInShadow(selection.anchorNode) is true
diff --git a/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt b/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt index 8f47bce..b2ef39ec 100644 --- a/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 22: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Unit tests for WebCore text iterator with shadow tree support enabled On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/editing/text-iterator/findString-shadow-roots-expected.txt b/third_party/WebKit/LayoutTests/editing/text-iterator/findString-shadow-roots-expected.txt index c6b7ec9..cb77b545 100644 --- a/third_party/WebKit/LayoutTests/editing/text-iterator/findString-shadow-roots-expected.txt +++ b/third_party/WebKit/LayoutTests/editing/text-iterator/findString-shadow-roots-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Find text in shadow roots. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json b/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json index 8fc043c..616b928f 100644 --- a/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json +++ b/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
@@ -105054,6 +105054,11 @@ {} ] ], + "beacon/beacon-readablestream.window-expected.txt": [ + [ + {} + ] + ], "beacon/headers/header-content-type-expected.txt": [ [ {} @@ -145574,6 +145579,26 @@ {} ] ], + "fetch/api/request/request-init-stream.any-expected.txt": [ + [ + {} + ] + ], + "fetch/api/request/request-init-stream.any.sharedworker-expected.txt": [ + [ + {} + ] + ], + "fetch/api/request/request-init-stream.any.worker-expected.txt": [ + [ + {} + ] + ], + "fetch/api/request/request-init-stream.https.any.serviceworker-expected.txt": [ + [ + {} + ] + ], "fetch/api/request/request-keepalive-expected.txt": [ [ {} @@ -145764,6 +145789,26 @@ {} ] ], + "fetch/api/response/response-from-stream.any-expected.txt": [ + [ + {} + ] + ], + "fetch/api/response/response-from-stream.any.sharedworker-expected.txt": [ + [ + {} + ] + ], + "fetch/api/response/response-from-stream.any.worker-expected.txt": [ + [ + {} + ] + ], + "fetch/api/response/response-from-stream.https.any.serviceworker-expected.txt": [ + [ + {} + ] + ], "fetch/api/response/response-idl-expected.txt": [ [ {} @@ -155014,6 +155059,11 @@ {} ] ], + "html/rendering/non-replaced-elements/the-fieldset-element-0/legend-dynamic-update.html": [ + [ + {} + ] + ], "html/rendering/non-replaced-elements/the-fieldset-element-0/legend-expected.txt": [ [ {} @@ -159954,16 +160004,41 @@ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-custom-element-with-domain-frame.sub.html": [ + [ + {} + ] + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-frame.html": [ [ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-with-domain-frame.sub.html": [ + [ + {} + ] + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-domain-frame.sub.xhtml": [ + [ + {} + ] + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-synchronous-script-frame.xhtml": [ + [ + {} + ] + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/document-open-side-effects.js": [ [ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/dummy.html": [ + [ + {} + ] + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/encoding-frame.html": [ [ {} @@ -159984,6 +160059,11 @@ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt": [ + [ + {} + ] + ], "html/webappapis/microtask-queuing/queue-microtask-exceptions.any-expected.txt": [ [ {} @@ -170149,6 +170229,11 @@ {} ] ], + "service-workers/service-worker/resources/update-top-level-worker.py": [ + [ + {} + ] + ], "service-workers/service-worker/resources/update-worker.py": [ [ {} @@ -178099,6 +178184,21 @@ {} ] ], + "xhr/send-data-readablestream.any-expected.txt": [ + [ + {} + ] + ], + "xhr/send-data-readablestream.any.sharedworker-expected.txt": [ + [ + {} + ] + ], + "xhr/send-data-readablestream.any.worker-expected.txt": [ + [ + {} + ] + ], "xhr/send-no-response-event-order-expected.txt": [ [ {} @@ -186708,6 +186808,12 @@ } ] ], + "beacon/beacon-readablestream.window.js": [ + [ + "/beacon/beacon-readablestream.window.html", + {} + ] + ], "beacon/beacon-redirect.window.js": [ [ "/beacon/beacon-redirect.window.html", @@ -215226,6 +215332,24 @@ {} ] ], + "fetch/api/request/request-init-stream.any.js": [ + [ + "/fetch/api/request/request-init-stream.any.html", + {} + ], + [ + "/fetch/api/request/request-init-stream.any.sharedworker.html", + {} + ], + [ + "/fetch/api/request/request-init-stream.any.worker.html", + {} + ], + [ + "/fetch/api/request/request-init-stream.https.any.serviceworker.html", + {} + ] + ], "fetch/api/request/request-keepalive-quota.html": [ [ "/fetch/api/request/request-keepalive-quota.html?include=fast", @@ -215322,6 +215446,24 @@ {} ] ], + "fetch/api/response/response-from-stream.any.js": [ + [ + "/fetch/api/response/response-from-stream.any.html", + {} + ], + [ + "/fetch/api/response/response-from-stream.any.sharedworker.html", + {} + ], + [ + "/fetch/api/response/response-from-stream.any.worker.html", + {} + ], + [ + "/fetch/api/response/response-from-stream.https.any.serviceworker.html", + {} + ] + ], "fetch/api/response/response-init-001.html": [ [ "/fetch/api/response/response-init-001.html", @@ -228146,6 +228288,18 @@ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.js": [ + [ + "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.html", + {} + ] + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.js": [ + [ + "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.html", + {} + ] + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-side-effects-ignore-opens-during-unload.window.js": [ [ "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-side-effects-ignore-opens-during-unload.window.html", @@ -228212,6 +228366,12 @@ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/history-state.window.js": [ + [ + "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/history-state.window.html", + {} + ] + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window.js": [ [ "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window.html", @@ -228242,6 +228402,12 @@ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.js": [ + [ + "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.html", + {} + ] + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/tasks.window.js": [ [ "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/tasks.window.html", @@ -228266,6 +228432,12 @@ {} ] ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js": [ + [ + "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html", + {} + ] + ], "html/webappapis/microtask-queuing/queue-microtask-exceptions.any.js": [ [ "/html/webappapis/microtask-queuing/queue-microtask-exceptions.any.html", @@ -253426,6 +253598,12 @@ {} ] ], + "service-workers/service-worker/update-top-level.https.html": [ + [ + "/service-workers/service-worker/update-top-level.https.html", + {} + ] + ], "service-workers/service-worker/update.https.html": [ [ "/service-workers/service-worker/update.https.html", @@ -265714,6 +265892,20 @@ {} ] ], + "xhr/send-data-readablestream.any.js": [ + [ + "/xhr/send-data-readablestream.any.html", + {} + ], + [ + "/xhr/send-data-readablestream.any.sharedworker.html", + {} + ], + [ + "/xhr/send-data-readablestream.any.worker.html", + {} + ] + ], "xhr/send-data-unexpected-tostring.htm": [ [ "/xhr/send-data-unexpected-tostring.htm", @@ -279921,6 +280113,14 @@ "88999e7d123854f9e40411365b58da15d7d651a0", "testharness" ], + "beacon/beacon-readablestream.window-expected.txt": [ + "4095512b29fd113a4d95792d8dd1c66fd57cdafc", + "support" + ], + "beacon/beacon-readablestream.window.js": [ + "c967844923bc6301b879b0740f85756ab3cf65a5", + "testharness" + ], "beacon/beacon-redirect.window.js": [ "8c75ccdace165cfc3697797b571c3d5ca79ac6a4", "testharness" @@ -361221,6 +361421,26 @@ "98e47b378d13b9b94601eb7c6035c457d53151ca", "testharness" ], + "fetch/api/request/request-init-stream.any-expected.txt": [ + "44a06694656a083b2252f67080b8d570bf4d25ed", + "support" + ], + "fetch/api/request/request-init-stream.any.js": [ + "3f18655423b38d5cc2208ed4125ffb9339488af9", + "testharness" + ], + "fetch/api/request/request-init-stream.any.sharedworker-expected.txt": [ + "44a06694656a083b2252f67080b8d570bf4d25ed", + "support" + ], + "fetch/api/request/request-init-stream.any.worker-expected.txt": [ + "44a06694656a083b2252f67080b8d570bf4d25ed", + "support" + ], + "fetch/api/request/request-init-stream.https.any.serviceworker-expected.txt": [ + "44a06694656a083b2252f67080b8d570bf4d25ed", + "support" + ], "fetch/api/request/request-keepalive-expected.txt": [ "d8e34b014a45f1cf61cfd557dfe5cf398207718a", "support" @@ -361429,6 +361649,26 @@ "06489e75d56cbbdbfee903bea7e39c549310ba3e", "testharness" ], + "fetch/api/response/response-from-stream.any-expected.txt": [ + "b741b0002c4481e80a8b1404046b7c319a6a3599", + "support" + ], + "fetch/api/response/response-from-stream.any.js": [ + "c10e4bcd90f7a74a1490e1001f9165209e077a6e", + "testharness" + ], + "fetch/api/response/response-from-stream.any.sharedworker-expected.txt": [ + "b741b0002c4481e80a8b1404046b7c319a6a3599", + "support" + ], + "fetch/api/response/response-from-stream.any.worker-expected.txt": [ + "b741b0002c4481e80a8b1404046b7c319a6a3599", + "support" + ], + "fetch/api/response/response-from-stream.https.any.serviceworker-expected.txt": [ + "b741b0002c4481e80a8b1404046b7c319a6a3599", + "support" + ], "fetch/api/response/response-idl-expected.txt": [ "01853687c6cae858953a54f7baf5da363bd1c739", "support" @@ -367270,7 +367510,7 @@ "testharness" ], "html/dom/elements/the-innertext-idl-attribute/getter-expected.txt": [ - "195ae384846ff37afca4eab243d040943296497c", + "59d1edaa8ebf6bfe735c50d60d6bb38d19231fb1", "support" ], "html/dom/elements/the-innertext-idl-attribute/getter-tests.js": [ @@ -372669,6 +372909,10 @@ "7b3ff5e10296f258774bfb935401d184611bcc78", "testharness" ], + "html/rendering/non-replaced-elements/the-fieldset-element-0/legend-dynamic-update.html": [ + "a31ca9c2a6ce39cfa4dd5c1a149d17cc0f1e5a2e", + "support" + ], "html/rendering/non-replaced-elements/the-fieldset-element-0/legend-expected.txt": [ "cdeb6f45e6108aed938dbfcc8db6e2185d447065", "support" @@ -382529,6 +382773,14 @@ "0ef6dab1d5e2364a0a75513469e339c20b14c674", "testharness" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.js": [ + "4bacfe61caab2aebd003fd9de6c97f546f862e93", + "testharness" + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.js": [ + "b38620160e84162e0eba06b4a6abe00658fdafa5", + "testharness" + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-side-effects-ignore-opens-during-unload.window.js": [ "648a7635bcdd0c776178725e82235dbcca58ddf7", "testharness" @@ -382577,6 +382829,10 @@ "5d301193b16c624b0d56dbc266c005ac9996ad72", "testharness" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/history-state.window.js": [ + "b67ed497f216e06f1c2589c810b56d0732d4ef78", + "testharness" + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window.js": [ "00c35c00efc1c05b90837b311601f647a1ff6be0", "testharness" @@ -382597,6 +382853,10 @@ "b4cdd98c6eb9a3946b49a6876c62c7e35501f413", "testharness" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.js": [ + "9902c539c24ec5b067258b472a098b795859682c", + "testharness" + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/aborted-parser-async-frame.html": [ "38be68cf85bbe4cef461963768fe1390733d67db", "support" @@ -382605,14 +382865,34 @@ "4cb26a783d232652a580e511e439b8bfaac04dfe", "support" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-custom-element-with-domain-frame.sub.html": [ + "d04506e014871b236cadeab2bac3a2e0f630abe3", + "support" + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-frame.html": [ "d3bb181459a2e8105fd228c00a376bef82918af6", "support" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-with-domain-frame.sub.html": [ + "e3c56e30d606f802590739506188fce300ef1ff6", + "support" + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-domain-frame.sub.xhtml": [ + "f7364d2697465f70263a04f6a62c1896cdfdef75", + "support" + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-synchronous-script-frame.xhtml": [ + "bb557d4de2b39a73e4187b15b6a3d1fcfadd36fb", + "support" + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/document-open-side-effects.js": [ "85011156282e56c67b3b94cee3c2c7bc5a8e1e59", "support" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/dummy.html": [ + "0c9e6bf3c6640ef015e9a04510c93a784a696f7e", + "support" + ], "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/encoding-frame.html": [ "1d8ae9f75fe05343c1858caad637c9f7602c9f28", "support" @@ -382645,6 +382925,14 @@ "ec42238235a256b406460abad6bf77f465038bea", "testharness" ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt": [ + "42995fd39904c4fc497f8abe9f5f352303ec717c", + "support" + ], + "html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js": [ + "4968b713e0c9173c8f6b007264ec5ed780ed0401", + "testharness" + ], "html/webappapis/microtask-queuing/queue-microtask-exceptions.any-expected.txt": [ "f18fe9015568d485ff599b0bf63ca14d32e5da7e", "support" @@ -406834,11 +407122,11 @@ "testharness" ], "service-workers/service-worker/navigation-redirect.https-expected.txt": [ - "3f8ea6985a70441edf6836e2b81bc72f0079c32c", + "b97f39ff652abfaf11e426c8df5b53a9608eeec6", "support" ], "service-workers/service-worker/navigation-redirect.https.html": [ - "92638db88808806e49a648c55749f23af4bf8cc1", + "69c4477849f68cd18431413a846a2204f4aed4db", "testharness" ], "service-workers/service-worker/navigation-timing.https-expected.txt": [ @@ -408037,6 +408325,10 @@ "44f6bb6b7ce13d1c2f9b073c649a0ea2218c07ad", "support" ], + "service-workers/service-worker/resources/update-top-level-worker.py": [ + "3c0dcead4582c45783619a3efeada8131f068ce7", + "support" + ], "service-workers/service-worker/resources/update-worker.py": [ "123ef31418e9d2198c2d64855cc8570f354aa877", "support" @@ -408237,6 +408529,10 @@ "06741e887be9746d7354394f74c054dd920d1b60", "testharness" ], + "service-workers/service-worker/update-top-level.https.html": [ + "343ea6257d95cce3d2ae4c39c3b8b8813fdd7def", + "testharness" + ], "service-workers/service-worker/update.https.html": [ "d55da98b05b5885084474ebdbabdf6c0998f8bca", "testharness" @@ -415522,7 +415818,7 @@ "support" ], "webrtc/RTCIceTransport-extension.https.html": [ - "7124d5112bf71807172936c1a0a0b9fd4b3484cd", + "bb19b47eaa03d6ecd92fee9f03f4f7b720f81566", "testharness" ], "webrtc/RTCIceTransport.html": [ @@ -416042,7 +416338,7 @@ "support" ], "webrtc/idlharness.https.window-expected.txt": [ - "167fcf23339122dcf75efc3804727422c8db5ec5", + "560a024fbbbb8bd4eafaebdf25e79fc2cab31d16", "support" ], "webrtc/idlharness.https.window.js": [ @@ -423593,6 +423889,22 @@ "e7dd3b36ef8e4986edf49aebbd9ff439e101f3ae", "testharness" ], + "xhr/send-data-readablestream.any-expected.txt": [ + "662a1cc4f95d67ea5bb98c1e75510417563b8055", + "support" + ], + "xhr/send-data-readablestream.any.js": [ + "5aa804857b0d8bfdcbc2a7309855a0e9eb2464f2", + "testharness" + ], + "xhr/send-data-readablestream.any.sharedworker-expected.txt": [ + "662a1cc4f95d67ea5bb98c1e75510417563b8055", + "support" + ], + "xhr/send-data-readablestream.any.worker-expected.txt": [ + "662a1cc4f95d67ea5bb98c1e75510417563b8055", + "support" + ], "xhr/send-data-unexpected-tostring.htm": [ "f74fdf2bfdfb97d8fc648db3d8bcbf28bf348e53", "testharness"
diff --git a/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-readablestream.window-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-readablestream.window-expected.txt new file mode 100644 index 0000000..e8d4d24f --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-readablestream.window-expected.txt
@@ -0,0 +1,4 @@ +This is a testharness.js-based test. +FAIL sendBeacon() with a stream does not work due to the keepalive flag being set assert_throws: function "() => navigator.sendBeacon("...", new ReadableStream())" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-readablestream.window.js b/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-readablestream.window.js new file mode 100644 index 0000000..fc7f81f --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/beacon/beacon-readablestream.window.js
@@ -0,0 +1,3 @@ +test(() => { + assert_throws(new TypeError(), () => navigator.sendBeacon("...", new ReadableStream())); +}, "sendBeacon() with a stream does not work due to the keepalive flag being set");
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any-expected.txt new file mode 100644 index 0000000..8bb2ebc --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any-expected.txt
@@ -0,0 +1,9 @@ +This is a testharness.js-based test. +FAIL Constructing a Request with a stream on which getReader() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() and releaseLock() are called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a Request on which body.getReader() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which body.getReader().read() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which read() and releaseLock() are called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.js b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.js new file mode 100644 index 0000000..22e3f41 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.js
@@ -0,0 +1,51 @@ +// META: global=window,worker + +"use strict"; + +async function assert_request(input, init) { + assert_throws(new TypeError(), () => new Request(input, init), "new Request()"); + assert_throws(new TypeError(), async () => await fetch(input, init), "fetch()"); +} + +promise_test(async () => { + const stream = new ReadableStream(); + stream.getReader(); + await assert_request("...", { method:"POST", body: stream }); +}, "Constructing a Request with a stream on which getReader() is called"); + +promise_test(async () => { + const stream = new ReadableStream(); + stream.getReader().read(); + await assert_request("...", { method:"POST", body: stream }); +}, "Constructing a Request with a stream on which read() is called"); + +promise_test(async () => { + const stream = new ReadableStream({ pull: c => c.enqueue(new Uint8Array()) }), + reader = stream.getReader(); + await reader.read(); + reader.releaseLock(); + await assert_request("...", { method:"POST", body: stream }); +}, "Constructing a Request with a stream on which read() and releaseLock() are called"); + +promise_test(async () => { + const request = new Request("...", { method: "POST", body: "..." }); + request.body.getReader(); + await assert_request(request); + assert_class_string(new Request(request, { body: "..." }), "Request"); +}, "Constructing a Request with a Request on which body.getReader() is called"); + +promise_test(async () => { + const request = new Request("...", { method: "POST", body: "..." }); + request.body.getReader().read(); + await assert_request(request); + assert_class_string(new Request(request, { body: "..." }), "Request"); +}, "Constructing a Request with a Request on which body.getReader().read() is called"); + +promise_test(async () => { + const request = new Request("...", { method: "POST", body: "..." }), + reader = request.body.getReader(); + await reader.read(); + reader.releaseLock(); + await assert_request(request); + assert_class_string(new Request(request, { body: "..." }), "Request"); +}, "Constructing a Request with a Request on which read() and releaseLock() are called");
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.sharedworker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.sharedworker-expected.txt new file mode 100644 index 0000000..8bb2ebc --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.sharedworker-expected.txt
@@ -0,0 +1,9 @@ +This is a testharness.js-based test. +FAIL Constructing a Request with a stream on which getReader() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() and releaseLock() are called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a Request on which body.getReader() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which body.getReader().read() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which read() and releaseLock() are called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.worker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.worker-expected.txt new file mode 100644 index 0000000..8bb2ebc --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.worker-expected.txt
@@ -0,0 +1,9 @@ +This is a testharness.js-based test. +FAIL Constructing a Request with a stream on which getReader() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() and releaseLock() are called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a Request on which body.getReader() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which body.getReader().read() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which read() and releaseLock() are called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.https.any.serviceworker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.https.any.serviceworker-expected.txt new file mode 100644 index 0000000..8bb2ebc --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.https.any.serviceworker-expected.txt
@@ -0,0 +1,9 @@ +This is a testharness.js-based test. +FAIL Constructing a Request with a stream on which getReader() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() is called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a stream on which read() and releaseLock() are called assert_throws: new Request() function "() => new Request(input, init)" did not throw +FAIL Constructing a Request with a Request on which body.getReader() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which body.getReader().read() is called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +FAIL Constructing a Request with a Request on which read() and releaseLock() are called promise_test: Unhandled rejection with value: object "TypeError: Cannot read property 'getReader' of undefined" +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any-expected.txt new file mode 100644 index 0000000..86adede7 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL Constructing a Response with a stream on which getReader() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() and releaseLock() are called assert_throws: function "() => new Response(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.js b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.js new file mode 100644 index 0000000..93b29b4 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.js
@@ -0,0 +1,23 @@ +// META: global=window,worker + +"use strict"; + +test(() => { + const stream = new ReadableStream(); + stream.getReader(); + assert_throws(new TypeError(), () => new Response(stream)); +}, "Constructing a Response with a stream on which getReader() is called"); + +test(() => { + const stream = new ReadableStream(); + stream.getReader().read(); + assert_throws(new TypeError(), () => new Response(stream)); +}, "Constructing a Response with a stream on which read() is called"); + +promise_test(async () => { + const stream = new ReadableStream({ pull: c => c.enqueue(new Uint8Array()) }), + reader = stream.getReader(); + await reader.read(); + reader.releaseLock(); + assert_throws(new TypeError(), () => new Response(stream)); +}, "Constructing a Response with a stream on which read() and releaseLock() are called");
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.sharedworker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.sharedworker-expected.txt new file mode 100644 index 0000000..86adede7 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.sharedworker-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL Constructing a Response with a stream on which getReader() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() and releaseLock() are called assert_throws: function "() => new Response(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.worker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.worker-expected.txt new file mode 100644 index 0000000..86adede7 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.worker-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL Constructing a Response with a stream on which getReader() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() and releaseLock() are called assert_throws: function "() => new Response(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.https.any.serviceworker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.https.any.serviceworker-expected.txt new file mode 100644 index 0000000..86adede7 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.https.any.serviceworker-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL Constructing a Response with a stream on which getReader() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() is called assert_throws: function "() => new Response(stream)" did not throw +FAIL Constructing a Response with a stream on which read() and releaseLock() are called assert_throws: function "() => new Response(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt index ae90cea..e7d5531 100644 --- a/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt +++ b/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
@@ -1,20 +1,20 @@ This is a testharness.js-based test. -Found 214 tests; 140 PASS, 74 FAIL, 0 TIMEOUT, 0 NOTRUN. +Found 214 tests; 211 PASS, 3 FAIL, 0 TIMEOUT, 0 NOTRUN. PASS Simplest possible test ("<div>abc") PASS Leading whitespace removed ("<div> abc") PASS Trailing whitespace removed ("<div>abc ") PASS Internal whitespace compressed ("<div>abc def") PASS \n converted to space ("<div>abc\ndef") PASS \r converted to space ("<div>abc\rdef") -FAIL \t converted to space ("<div>abc\tdef") assert_equals: expected "abc def" but got "abc\tdef" -FAIL Trailing whitespace before hard line break removed ("<div>abc <br>def") assert_equals: expected "abc\ndef" but got "abc \ndef" +PASS \t converted to space ("<div>abc\tdef") +PASS Trailing whitespace before hard line break removed ("<div>abc <br>def") PASS Leading whitespace preserved ("<pre> abc") PASS Trailing whitespace preserved ("<pre>abc ") PASS Internal whitespace preserved ("<pre>abc def") PASS \n preserved ("<pre>abc\ndef") PASS \r converted to newline ("<pre>abc\rdef") PASS \t preserved ("<pre>abc\tdef") -FAIL Two <pre> siblings ("<div><pre>abc</pre><pre>def</pre>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS Two <pre> siblings ("<div><pre>abc</pre><pre>def</pre>") PASS Leading whitespace preserved ("<div style='white-space:pre'> abc") PASS Trailing whitespace preserved ("<div style='white-space:pre'>abc ") PASS Internal whitespace preserved ("<div style='white-space:pre'>abc def") @@ -32,10 +32,10 @@ PASS Internal whitespace collapsed ("<div style='white-space:pre-line'>abc def") PASS \n preserved ("<div style='white-space:pre-line'>abc\ndef") PASS \r converted to newline ("<div style='white-space:pre-line'>abc\rdef") -FAIL \t converted to space ("<div style='white-space:pre-line'>abc\tdef") assert_equals: expected "abc def" but got "abc\tdef" +PASS \t converted to space ("<div style='white-space:pre-line'>abc\tdef") PASS Whitespace collapses across element boundaries ("<div><span>abc </span> def") PASS Whitespace collapses across element boundaries ("<div><span>abc </span><span></span> def") -FAIL Whitespace collapses across element boundaries ("<div><span>abc </span><span style='white-space:pre'></span> def") assert_equals: expected "abc def" but got "abc def" +PASS Whitespace collapses across element boundaries ("<div><span>abc </span><span style='white-space:pre'></span> def") PASS Soft line breaks ignored ("<div style='width:0'>abc def") PASS Whitespace text node preserved ("<div style='width:0'><span>abc</span> <span>def</span>") FAIL ::first-line styles applied ("<div class='first-line-uppercase' style='width:0'>abc def") assert_equals: expected "ABC def" but got "abc def" @@ -61,10 +61,10 @@ PASS visibility:collapse row-group ("<table><tbody style='visibility:collapse'><tr><td>abc") PASS visibility:collapse row ("<table><tr style='visibility:collapse'><td>abc") PASS visibility:collapse cell ("<table><tr><td style='visibility:collapse'>abc") -FAIL visibility:collapse row-group with visible cell ("<table><tbody style='visibility:collapse'><tr><td style='visibility:visible'>abc") assert_equals: expected "abc" but got "abc\n" -FAIL visibility:collapse row with visible cell ("<table><tr style='visibility:collapse'><td style='visibility:visible'>abc") assert_equals: expected "abc" but got "abc\n" -FAIL visibility:collapse honored on flex item ("<div style='display:flex'><span style='visibility:collapse'>1</span><span>2</span></div>") assert_equals: expected "2" but got "2\n" -FAIL visibility:collapse honored on grid item ("<div style='display:grid'><span style='visibility:collapse'>1</span><span>2</span></div>") assert_equals: expected "2" but got "2\n" +PASS visibility:collapse row-group with visible cell ("<table><tbody style='visibility:collapse'><tr><td style='visibility:visible'>abc") +PASS visibility:collapse row with visible cell ("<table><tr style='visibility:collapse'><td style='visibility:visible'>abc") +PASS visibility:collapse honored on flex item ("<div style='display:flex'><span style='visibility:collapse'>1</span><span>2</span></div>") +PASS visibility:collapse honored on grid item ("<div style='display:grid'><span style='visibility:collapse'>1</span><span>2</span></div>") PASS opacity:0 container ("<div style='opacity:0'>abc") PASS Whitespace compression in opacity:0 container ("<div style='opacity:0'>abc def") PASS Remove leading/trailing whitespace in opacity:0 container ("<div style='opacity:0'> abc def ") @@ -73,7 +73,7 @@ PASS Generated content on child not included ("<div><div class='before'>") PASS <button> contents preserved ("<button>abc") PASS <fieldset> contents preserved ("<fieldset>abc") -FAIL <fieldset> <legend> contents preserved ("<fieldset><legend>abc") assert_equals: expected "abc" but got "abc\n" +PASS <fieldset> <legend> contents preserved ("<fieldset><legend>abc") PASS <input> contents ignored ("<input type='text' value='abc'>") PASS <textarea> contents ignored ("<textarea>abc") PASS <iframe> contents ignored ("<iframe>abc") @@ -89,28 +89,28 @@ PASS <canvas><div id='target'> contents ok for element not being rendered ("<canvas><div id='target'>abc") PASS <img> alt text ignored ("<img alt='abc'>") PASS <img> contents ignored ("<img src='about:blank' class='poke'>") -FAIL <select size='1'> contents of options preserved ("<select size='1'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" -FAIL <select size='2'> contents of options preserved ("<select size='2'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" +PASS <select size='1'> contents of options preserved ("<select size='1'><option>abc</option><option>def") +PASS <select size='2'> contents of options preserved ("<select size='2'><option>abc</option><option>def") PASS <select size='1'> contents of target option preserved ("<select size='1'><option id='target'>abc</option><option>def") PASS <select size='2'> contents of target option preserved ("<select size='2'><option id='target'>abc</option><option>def") PASS empty <select> ("<div>a<select></select>bc") -FAIL empty <optgroup> in <select> ("<div>a<select><optgroup></select>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL empty <option> in <select> ("<div>a<select><option></select>bc") assert_equals: expected "a\nbc" but got "abc" +PASS empty <optgroup> in <select> ("<div>a<select><optgroup></select>bc") +PASS empty <option> in <select> ("<div>a<select><option></select>bc") PASS <select> containing text node child ("<select class='poke'></select>") PASS <optgroup> containing <optgroup> ("<select><optgroup class='poke-optgroup'></select>") -FAIL <optgroup> containing <option> ("<select><optgroup><option>abc</select>") assert_equals: expected "abc" but got "" -FAIL <div> in <option> ("<select><option class='poke-div'>123</select>") assert_equals: expected "123\nabc" but got "" -FAIL empty <optgroup> in <div> ("<div>a<optgroup></optgroup>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL <optgroup> in <div> ("<div>a<optgroup>123</optgroup>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL empty <option> in <div> ("<div>a<option></option>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL <option> in <div> ("<div>a<option>123</option>bc") assert_equals: expected "a\n123\nbc" but got "abc" +PASS <optgroup> containing <option> ("<select><optgroup><option>abc</select>") +FAIL <div> in <option> ("<select><option class='poke-div'>123</select>") assert_equals: expected "123\nabc" but got "123abc" +PASS empty <optgroup> in <div> ("<div>a<optgroup></optgroup>bc") +PASS <optgroup> in <div> ("<div>a<optgroup>123</optgroup>bc") +PASS empty <option> in <div> ("<div>a<option></option>bc") +PASS <option> in <div> ("<div>a<option>123</option>bc") PASS <button> contents preserved ("<div><button>abc") -FAIL <fieldset> contents preserved ("<div><fieldset>abc") assert_equals: expected "abc" but got "abc\n" -FAIL <fieldset> <legend> contents preserved ("<div><fieldset><legend>abc") assert_equals: expected "abc" but got "abc\n" +PASS <fieldset> contents preserved ("<div><fieldset>abc") +PASS <fieldset> <legend> contents preserved ("<div><fieldset><legend>abc") PASS <input> contents ignored ("<div><input type='text' value='abc'>") PASS <textarea> contents ignored ("<div><textarea>abc") -FAIL <select size='1'> contents of options preserved ("<div><select size='1'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" -FAIL <select size='2'> contents of options preserved ("<div><select size='2'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" +PASS <select size='1'> contents of options preserved ("<div><select size='1'><option>abc</option><option>def") +PASS <select size='2'> contents of options preserved ("<div><select size='2'><option>abc</option><option>def") PASS <iframe> contents ignored ("<div><iframe>abc") PASS <iframe> subdocument ignored ("<div><iframe src='data:text/html,abc'>") PASS <audio> contents ignored ("<div><audio>abc") @@ -121,22 +121,22 @@ PASS Newline at display:block boundary ("<div>123<span style='display:block'>abc</span>def") PASS Empty block induces single line break ("<div>abc<div></div>def") PASS Consecutive empty blocks ignored ("<div>abc<div></div><div></div>def") -FAIL No blank lines around <p> alone ("<div><p>abc") assert_equals: expected "abc" but got "abc\n\n" -FAIL No blank lines around <p> followed by only collapsible whitespace ("<div><p>abc</p> ") assert_equals: expected "abc" but got "abc\n\n" -FAIL No blank lines around <p> preceded by only collapsible whitespace ("<div> <p>abc</p>") assert_equals: expected "abc" but got "abc\n\n" -FAIL Blank line between consecutive <p>s ("<div><p>abc<p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Blank line between consecutive <p>s separated only by collapsible whitespace ("<div><p>abc</p> <p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Blank line between consecutive <p>s separated only by empty block ("<div><p>abc</p><div></div><p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Blank lines between <p>s separated by non-empty block ("<div><p>abc</p><div>123</div><p>def") assert_equals: expected "abc\n\n123\n\ndef" but got "abc\n\n123\ndef\n\n" -FAIL Blank lines around a <p> in its own block ("<div>abc<div><p>123</p></div>def") assert_equals: expected "abc\n\n123\n\ndef" but got "abc\n123\n\ndef" -FAIL Blank line before <p> ("<div>abc<p>def") assert_equals: expected "abc\n\ndef" but got "abc\ndef\n\n" +PASS No blank lines around <p> alone ("<div><p>abc") +PASS No blank lines around <p> followed by only collapsible whitespace ("<div><p>abc</p> ") +PASS No blank lines around <p> preceded by only collapsible whitespace ("<div> <p>abc</p>") +PASS Blank line between consecutive <p>s ("<div><p>abc<p>def") +PASS Blank line between consecutive <p>s separated only by collapsible whitespace ("<div><p>abc</p> <p>def") +PASS Blank line between consecutive <p>s separated only by empty block ("<div><p>abc</p><div></div><p>def") +PASS Blank lines between <p>s separated by non-empty block ("<div><p>abc</p><div>123</div><p>def") +PASS Blank lines around a <p> in its own block ("<div>abc<div><p>123</p></div>def") +PASS Blank line before <p> ("<div>abc<p>def") PASS Blank line after <p> ("<div><p>abc</p>def") -FAIL One blank line between <p>s, ignoring empty <p>s ("<div><p>abc<p></p><p></p><p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Invisible <p> doesn't induce extra line breaks ("<div style='visibility:hidden'><p><span style='visibility:visible'>abc</span></p>\n<div style='visibility:visible'>def</div>") assert_equals: expected "abc\ndef" but got "abc\n\ndef\n" -FAIL No blank lines around <div> with margin ("<div>abc<div style='margin:2em'>def") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS One blank line between <p>s, ignoring empty <p>s ("<div><p>abc<p></p><p></p><p>def") +PASS Invisible <p> doesn't induce extra line breaks ("<div style='visibility:hidden'><p><span style='visibility:visible'>abc</span></p>\n<div style='visibility:visible'>def</div>") +PASS No blank lines around <div> with margin ("<div>abc<div style='margin:2em'>def") PASS No newlines at display:inline-block boundary ("<div>123<span style='display:inline-block'>abc</span>def") -FAIL Leading/trailing space removal at display:inline-block boundary ("<div>123<span style='display:inline-block'> abc </span>def") assert_equals: expected "123abcdef" but got "123 abc def" -FAIL Blank lines around <p> even without margin ("<div>123<p style='margin:0px'>abc</p>def") assert_equals: expected "123\n\nabc\n\ndef" but got "123\nabc\n\ndef" +PASS Leading/trailing space removal at display:inline-block boundary ("<div>123<span style='display:inline-block'> abc </span>def") +PASS Blank lines around <p> even without margin ("<div>123<p style='margin:0px'>abc</p>def") PASS No blank lines around <h1> ("<div>123<h1>abc</h1>def") PASS No blank lines around <h2> ("<div>123<h2>abc</h2>def") PASS No blank lines around <h3> ("<div>123<h3>abc</h3>def") @@ -154,27 +154,27 @@ PASS <code> gets no special treatment ("<div>123<code>abc</code>def") PASS soft hyphen preserved ("<div>abc­def") PASS soft hyphen preserved ("<div style='width:0'>abc­def") -FAIL Ignoring non-rendered table whitespace ("<div><table style='white-space:pre'> <td>abc</td> </table>") assert_equals: expected "abc" but got "abc\n" -FAIL Tab-separated table cells ("<div><table><tr><td>abc<td>def</table>") assert_equals: expected "abc\tdef" but got "abc\tdef\n" -FAIL Tab-separated table cells including empty cells ("<div><table><tr><td>abc<td><td>def</table>") assert_equals: expected "abc\t\tdef" but got "abc\t\tdef\n" -FAIL Tab-separated table cells including trailing empty cells ("<div><table><tr><td>abc<td><td></table>") assert_equals: expected "abc\t\t" but got "abc\t\t\n" -FAIL Newline-separated table rows ("<div><table><tr><td>abc<tr><td>def</table>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS Ignoring non-rendered table whitespace ("<div><table style='white-space:pre'> <td>abc</td> </table>") +PASS Tab-separated table cells ("<div><table><tr><td>abc<td>def</table>") +PASS Tab-separated table cells including empty cells ("<div><table><tr><td>abc<td><td>def</table>") +PASS Tab-separated table cells including trailing empty cells ("<div><table><tr><td>abc<td><td></table>") +PASS Newline-separated table rows ("<div><table><tr><td>abc<tr><td>def</table>") PASS Newlines around table ("<div>abc<table><td>def</table>ghi") -FAIL Tab-separated table cells in a border-collapse table ("<div><table style='border-collapse:collapse'><tr><td>abc<td>def</table>") assert_equals: expected "abc\tdef" but got "abc\tdef\n" -FAIL tfoot not reordered ("<div><table><tfoot>x</tfoot><tbody>y</tbody></table>") assert_equals: expected "xy" but got "xy\n" -FAIL ("<table><tfoot><tr><td>footer</tfoot><thead><tr><td style='visibility:collapse'>thead</thead><tbody><tr><td>tbody</tbody></table>") assert_equals: expected "footer\n\ntbody" but got "footer\ntbody\n" -FAIL Newline between cells and caption ("<div><table><tr><td>abc<caption>def</caption></table>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" -FAIL Tab-separated table cells ("<div><div class='table'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") assert_equals: expected "abc\tdef" but got "abc\tdef\n" -FAIL Newline-separated table rows ("<div><div class='table'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS Tab-separated table cells in a border-collapse table ("<div><table style='border-collapse:collapse'><tr><td>abc<td>def</table>") +PASS tfoot not reordered ("<div><table><tfoot>x</tfoot><tbody>y</tbody></table>") +PASS ("<table><tfoot><tr><td>footer</tfoot><thead><tr><td style='visibility:collapse'>thead</thead><tbody><tr><td>tbody</tbody></table>") +PASS Newline between cells and caption ("<div><table><tr><td>abc<caption>def</caption></table>") +PASS Tab-separated table cells ("<div><div class='table'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") +PASS Newline-separated table rows ("<div><div class='table'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") PASS Newlines around table ("<div>abc<div class='table'><span class='cell'>def</span></div>ghi") -FAIL Tab-separated table cells ("<div><div class='itable'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") assert_equals: expected "abc\tdef" but got "abc\tdef " -FAIL Newline-separated table rows ("<div><div class='itable'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") assert_equals: expected "abc\ndef" but got "abc\tdef " -FAIL No newlines around inline-table ("<div>abc<div class='itable'><span class='cell'>def</span></div>ghi") assert_equals: expected "abcdefghi" but got "abc def ghi" -FAIL Single newline in two-row inline-table ("<div>abc<div class='itable'><span class='row'><span class='cell'>def</span></span>\n<span class='row'><span class='cell'>123</span></span></div>ghi") assert_equals: expected "abcdef\n123ghi" but got "abc def\t123 ghi" -FAIL <ol> list items get no special treatment ("<div><ol><li>abc") assert_equals: expected "abc" but got "abc\n" -FAIL <ul> list items get no special treatment ("<div><ul><li>abc") assert_equals: expected "abc" but got "abc\n" -FAIL display:block <script> is rendered ("<div><script style='display:block'>abc") assert_equals: expected "abc" but got "abc\n" -FAIL display:block <style> is rendered ("<div><style style='display:block'>abc") assert_equals: expected "abc" but got "abc\n" +PASS Tab-separated table cells ("<div><div class='itable'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") +PASS Newline-separated table rows ("<div><div class='itable'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") +PASS No newlines around inline-table ("<div>abc<div class='itable'><span class='cell'>def</span></div>ghi") +PASS Single newline in two-row inline-table ("<div>abc<div class='itable'><span class='row'><span class='cell'>def</span></span>\n<span class='row'><span class='cell'>123</span></span></div>ghi") +PASS <ol> list items get no special treatment ("<div><ol><li>abc") +PASS <ul> list items get no special treatment ("<div><ul><li>abc") +PASS display:block <script> is rendered ("<div><script style='display:block'>abc") +PASS display:block <style> is rendered ("<div><style style='display:block'>abc") PASS display:block <noscript> is not rendered (it's not parsed!) ("<div><noscript style='display:block'>abc") PASS display:block <template> contents are not rendered (the contents are in a different document) ("<div><template style='display:block'>abc") PASS <br> induces line break ("<div>abc<br>def") @@ -183,22 +183,22 @@ PASS <hr> induces line break ("<div>abc<hr>def") PASS <hr><hr> induces just one line break ("<div>abc<hr><hr>def") PASS <hr><hr><hr> induces just one line break ("<div>abc<hr><hr><hr>def") -FAIL <hr> content rendered ("<div><hr class='poke'>") assert_equals: expected "abc" but got "abc\n" +PASS <hr> content rendered ("<div><hr class='poke'>") PASS comment ignored ("<div>abc<!--comment-->def") -FAIL text-transform is applied ("<div><div style='text-transform:uppercase'>abc") assert_equals: expected "ABC" but got "ABC\n" -FAIL text-transform handles es-zet ("<div><div style='text-transform:uppercase'>Maß") assert_equals: expected "MASS" but got "MASS\n" -FAIL text-transform handles Turkish casing ("<div><div lang='tr' style='text-transform:uppercase'>i ı") assert_equals: expected "İ I" but got "İ I\n" +PASS text-transform is applied ("<div><div style='text-transform:uppercase'>abc") +PASS text-transform handles es-zet ("<div><div style='text-transform:uppercase'>Maß") +PASS text-transform handles Turkish casing ("<div><div lang='tr' style='text-transform:uppercase'>i ı") PASS block-in-inline doesn't add unnecessary newlines ("<div>abc<span>123<div>456</div>789</span>def") -FAIL floats induce a block boundary ("<div>abc<div style='float:left'>123</div>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" -FAIL floats induce a block boundary ("<div>abc<span style='float:left'>123</span>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" -FAIL position:absolute induces a block boundary ("<div>abc<div style='position:absolute'>123</div>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" -FAIL position:absolute induces a block boundary ("<div>abc<span style='position:absolute'>123</span>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" +PASS floats induce a block boundary ("<div>abc<div style='float:left'>123</div>def") +PASS floats induce a block boundary ("<div>abc<span style='float:left'>123</span>def") +PASS position:absolute induces a block boundary ("<div>abc<div style='position:absolute'>123</div>def") +PASS position:absolute induces a block boundary ("<div>abc<span style='position:absolute'>123</span>def") PASS position:relative has no effect ("<div>abc<div style='position:relative'>123</div>def") PASS position:relative has no effect ("<div>abc<span style='position:relative'>123</span>def") PASS overflow:hidden ignored ("<div style='overflow:hidden'>abc") -FAIL overflow:hidden ignored even with zero width ("<div style='width:0; overflow:hidden'>abc") assert_equals: expected "abc" but got "" -FAIL overflow:hidden ignored even with zero height ("<div style='height:0; overflow:hidden'>abc") assert_equals: expected "abc" but got "" -FAIL text-overflow:ellipsis ignored ("<div style='width:0; overflow:hidden; text-overflow:ellipsis'>abc") assert_equals: expected "abc" but got "" +PASS overflow:hidden ignored even with zero width ("<div style='width:0; overflow:hidden'>abc") +PASS overflow:hidden ignored even with zero height ("<div style='height:0; overflow:hidden'>abc") +PASS text-overflow:ellipsis ignored ("<div style='width:0; overflow:hidden; text-overflow:ellipsis'>abc") PASS innerText not supported on SVG elements ("<svg>abc") PASS innerText not supported on MathML elements ("<math>abc") PASS <rt> and no <rp> ("<div><ruby>abc<rt>def</rt></ruby>") @@ -210,9 +210,9 @@ PASS <rp> in a <select> ("<div><select class='poke-rp'></select>") PASS Shadow DOM contents ignored ("<div class='shadow'>") PASS Shadow DOM contents ignored ("<div><div class='shadow'>") -FAIL CSS 'order' property ignored ("<div style='display:flex'><div style='order:1'>1</div><div>2</div></div>") assert_equals: expected "1\n2" but got "1\n2\n" -FAIL Flex items blockified ("<div style='display:flex'><span>1</span><span>2</span></div>") assert_equals: expected "1\n2" but got "1\n2\n" -FAIL CSS 'order' property ignored ("<div style='display:grid'><div style='order:1'>1</div><div>2</div></div>") assert_equals: expected "1\n2" but got "1\n2\n" -FAIL Grid items blockified ("<div style='display:grid'><span>1</span><span>2</span></div>") assert_equals: expected "1\n2" but got "1\n2\n" +PASS CSS 'order' property ignored ("<div style='display:flex'><div style='order:1'>1</div><div>2</div></div>") +PASS Flex items blockified ("<div style='display:flex'><span>1</span><span>2</span></div>") +PASS CSS 'order' property ignored ("<div style='display:grid'><div style='order:1'>1</div><div>2</div></div>") +PASS Grid items blockified ("<div style='display:grid'><span>1</span><span>2</span></div>") Harness: the test ran to completion.
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-dynamic-update.html b/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-dynamic-update.html new file mode 100644 index 0000000..5dc68244 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-dynamic-update.html
@@ -0,0 +1,19 @@ +<!DOCTYPE html> +<html class=reftest-wait> +<title>legend and dynamic update</title> +<link rel=fieldset-foo-ref.html> +<p>There should be a normal fieldset below with the legend "Foo".</p> +<fieldset> + <legend>F</legend> +</fieldset> +<script> + const legend = document.querySelector('legend'); + // force layout + legend.offsetTop; + requestAnimationFrame(() => { + legend.textContent += "oo"; + requestAnimationFrame(() => { + document.documentElement.removeAttribute('class'); + }); + }); +</script>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.js b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.js new file mode 100644 index 0000000..0e1c54b --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.js
@@ -0,0 +1,97 @@ +document.domain = "{{host}}"; + +// In many cases in this test, we want to delay execution of a piece of code so +// that the entry settings object would be the top-level page. A microtask is +// perfect for this purpose as it is executed in the "clean up after running +// script" algorithm, which is generally called right after the callback. +function setEntryToTopLevel(cb) { + Promise.resolve().then(cb); +} + +async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => { iframe.remove(); }); + iframe.onload = t.step_func_done(() => { + // Since this is called as an event handler on an element of this window, + // the entry settings object is that of this browsing context. + assert_throws("InvalidStateError", () => { + iframe.contentDocument.open(); + }, "opening an XML document should throw an InvalidStateError"); + }); + const frameURL = new URL("resources/bailout-order-xml-with-domain-frame.sub.xhtml", document.URL); + frameURL.port = "{{ports[http][1]}}"; + iframe.src = frameURL.href; +}, "document.open should throw an InvalidStateError with XML document even if it is cross-origin"); + +async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => { iframe.remove(); }); + window.onCustomElementReady = t.step_func(() => { + window.onCustomElementReady = t.unreached_func("onCustomElementReady called again"); + // Here, the entry settings object is still the iframe's, as the function + // is called from a custom element constructor in the iframe document. + // Delay execution in such a way that makes the entry settings object the + // top-level page's, but without delaying too much that the + // throw-on-dynamic-markup-insertion counter gets decremented (which is + // what this test tries to pit against the cross-origin document check). + // + // "Clean up after running script" is executed through the "construct" Web + // IDL algorithm in "create an element", called by "create an element for a + // token" in the parser. + setEntryToTopLevel(t.step_func_done(() => { + assert_throws("InvalidStateError", () => { + iframe.contentDocument.open(); + }, "opening a document when the throw-on-dynamic-markup-insertion counter is incremented should throw an InvalidStateError"); + })); + }); + const frameURL = new URL("resources/bailout-order-custom-element-with-domain-frame.sub.html", document.URL); + frameURL.port = "{{ports[http][1]}}"; + iframe.src = frameURL.href; +}, "document.open should throw an InvalidStateError when the throw-on-dynamic-markup-insertion counter is incremented even if the document is cross-origin"); + +async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => { iframe.remove(); }); + self.testSynchronousScript = t.step_func(() => { + // Here, the entry settings object is still the iframe's, as the function + // is synchronously called from a <script> element in the iframe's + // document. + // + // "Clean up after running script" is executed when the </script> tag is + // seen by the HTML parser. + setEntryToTopLevel(t.step_func_done(() => { + assert_throws("SecurityError", () => { + iframe.contentDocument.open(); + }, "opening a same origin-domain (but not same origin) document should throw a SecurityError"); + })); + }); + const frameURL = new URL("resources/bailout-order-synchronous-script-with-domain-frame.sub.html", document.URL); + frameURL.port = "{{ports[http][1]}}"; + iframe.src = frameURL.href; +}, "document.open should throw a SecurityError with cross-origin document even when there is an active parser executing script"); + +for (const ev of ["beforeunload", "pagehide", "unload"]) { + async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => { iframe.remove(); }); + iframe.addEventListener("load", t.step_func(() => { + iframe.contentWindow.addEventListener(ev, t.step_func(() => { + // Here, the entry settings object should be the top-level page's, as + // the callback context of this event listener is the incumbent + // settings object, which is the this page. However, due to a Chrome + // bug (https://crbug.com/606900), the entry settings object may be + // mis-set to the iframe's. + // + // "Clean up after running script" is called in the task that + // navigates. + setEntryToTopLevel(t.step_func_done(() => { + assert_throws("SecurityError", () => { + iframe.contentDocument.open(); + }, "opening a same origin-domain (but not same origin) document should throw a SecurityError"); + })); + })); + iframe.src = "about:blank"; + }), { once: true }); + iframe.src = "http://{{host}}:{{ports[http][1]}}/common/domain-setter.sub.html"; + }, `document.open should throw a SecurityError with cross-origin document even when the ignore-opens-during-unload counter is greater than 0 (during ${ev} event)`); +}
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.js b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.js new file mode 100644 index 0000000..3558397 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window.js
@@ -0,0 +1,26 @@ +async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => { iframe.remove(); }); + self.testSynchronousScript = t.step_func_done(() => { + assert_throws("InvalidStateError", () => { + iframe.contentDocument.open(); + }, "opening an XML document should throw"); + }); + iframe.src = "resources/bailout-order-xml-with-synchronous-script-frame.xhtml"; +}, "document.open should throw an InvalidStateError with XML document even when there is an active parser executing script"); + +for (const ev of ["beforeunload", "pagehide", "unload"]) { + async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => { iframe.remove(); }); + iframe.addEventListener("load", t.step_func(() => { + iframe.contentWindow.addEventListener(ev, t.step_func_done(() => { + assert_throws("InvalidStateError", () => { + iframe.contentDocument.open(); + }, "opening an XML document should throw"); + })); + iframe.src = "about:blank"; + }), { once: true }); + iframe.src = "/common/dummy.xhtml"; + }, `document.open should throw an InvalidStateError with XML document even when the ignore-opens-during-unload counter is greater than 0 (during ${ev} event)`); +}
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/history-state.window.js b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/history-state.window.js new file mode 100644 index 0000000..7fb172a1 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/history-state.window.js
@@ -0,0 +1,29 @@ +async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => iframe.remove()); + iframe.src = "/common/blank.html"; + iframe.onload = t.step_func_done(() => { + const win = iframe.contentWindow; + const doc = iframe.contentDocument; + assert_equals(win.history.state, null); + win.history.replaceState("state", ""); + assert_equals(win.history.state, "state"); + assert_equals(doc.open(), doc); + assert_equals(win.history.state, "state"); + }); +}, "history.state is kept by document.open()"); + +async_test(t => { + const iframe = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => iframe.remove()); + iframe.src = "/common/blank.html"; + iframe.onload = t.step_func_done(() => { + const win = iframe.contentWindow; + const doc = iframe.contentDocument; + assert_equals(win.history.state, null); + win.history.replaceState("state", ""); + assert_equals(win.history.state, "state"); + assert_equals(doc.open("", "replace"), doc); + assert_equals(win.history.state, "state"); + }); +}, "history.state is kept by document.open() (with historical replace parameter set)");
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.js b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.js new file mode 100644 index 0000000..d6ff9dc7a --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/reload.window.js
@@ -0,0 +1,71 @@ +// This test tests for the nonexistence of a reload override buffer, which is +// used in a previous version of the HTML Standard to make reloads of a +// document.open()'d document load the written-to document rather than doing an +// actual reload of the document's URL. +// +// This test has a somewhat interesting structure compared to the other tests +// in this directory. It eschews the <iframe> structure used by other tests, +// since when the child frame is reloaded it would adopt the URL of the test +// page (the responsible document of the entry settings object), and the spec +// forbids navigation in nested browsing contexts to the same URL as their +// parent. To work around that, we use window.open() which does not suffer from +// that restriction. +// +// In any case, this test as the caller of `document.open()` would be used both +// as the test file and as part of the test file. The `if (!opener)` condition +// controls what role this file plays. + +if (!opener) { + async_test(t => { + const testURL = document.URL; + const dummyURL = new URL("resources/dummy.html", document.URL).href; + + // 1. Open an auxiliary window. + const win = window.open("resources/dummy.html"); + t.add_cleanup(() => { win.close(); }); + + win.addEventListener("load", t.step_func(() => { + // The timeout seems to be necessary for Firefox, which when `load` is + // called may still have an active parser. + t.step_timeout(() => { + const doc = win.document; + assert_true(doc.body.textContent.includes("Dummy"), "precondition"); + assert_equals(doc.URL, dummyURL, "precondition"); + + window.onChildLoad = t.step_func(message => { + // 3. The dynamically overwritten content will trigger this function, + // which puts in place the actual test. + + assert_equals(message, "Written", "script on written page is executed"); + assert_true(win.document.body.textContent.includes("Content"), "page is written to"); + assert_equals(win.document.URL, testURL, "postcondition: after document.write()"); + assert_equals(win.document, doc, "document.open should not change the document object"); + window.onChildLoad = t.step_func_done(message => { + // 6. This function should be called from the if (opener) branch of + // this file. It would throw an assertion error if the overwritten + // content was executed instead. + assert_equals(message, "Done!", "actual test"); + assert_true(win.document.body.textContent.includes("Back to the test"), "test is reloaded"); + assert_equals(win.document.URL, testURL, "postcondition: after reload"); + assert_not_equals(win.document, doc, "reload should change the document object"); + }); + + // 4. Reload the pop-up window. Because of the doc.open() call, this + // pop-up window will reload to the same URL as this test itself. + win.location.reload(); + }); + + // 2. When it is loaded, dynamically overwrite its content. + assert_equals(doc.open(), doc); + assert_equals(doc.URL, testURL, "postcondition: after document.open()"); + doc.write("<p>Content</p><script>opener.onChildLoad('Written');</script>"); + doc.close(); + }, 100); + }), { once: true }); + }, "Reloading a document.open()'d page should reload the URL of the entry realm's responsible document"); +} else { + document.write("<p>Back to the test</p>"); + // 5. Since this window is window.open()'d, opener refers to the test window. + // Inform the opener that reload succeeded. + opener.onChildLoad("Done!"); +}
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-custom-element-with-domain-frame.sub.html b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-custom-element-with-domain-frame.sub.html new file mode 100644 index 0000000..4de97e8 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-custom-element-with-domain-frame.sub.html
@@ -0,0 +1,13 @@ +<p>Text</p> +<script> +document.domain = "{{host}}"; + +class CustomElement extends HTMLElement { + constructor() { + super(); + parent.onCustomElementReady(); + } +} +customElements.define("custom-element", CustomElement); +</script> +<custom-element></custom-element>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-with-domain-frame.sub.html b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-with-domain-frame.sub.html new file mode 100644 index 0000000..7ca7b5f4 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-synchronous-script-with-domain-frame.sub.html
@@ -0,0 +1,5 @@ +<p>Text</p> +<script> +document.domain = "{{host}}"; +parent.testSynchronousScript(); +</script>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-domain-frame.sub.xhtml b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-domain-frame.sub.xhtml new file mode 100644 index 0000000..b054c0f --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-domain-frame.sub.xhtml
@@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="utf-8"?> +<!DOCTYPE html> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head><title>XHTML document with domain set</title></head> + <body> + <p>Text</p> + <script> + document.domain = "{{host}}"; + </script> + </body> +</html>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-synchronous-script-frame.xhtml b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-synchronous-script-frame.xhtml new file mode 100644 index 0000000..00fc71ec --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/bailout-order-xml-with-synchronous-script-frame.xhtml
@@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="utf-8"?> +<!DOCTYPE html> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head><title>XHTML document with hook to run script from a script tag</title></head> + <body> + <p>Text</p> + <script> + parent.testSynchronousScript(); + </script> + </body> +</html>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/dummy.html b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/dummy.html new file mode 100644 index 0000000..a092f4e --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/dummy.html
@@ -0,0 +1,2 @@ +<!-- Like /common/blank.html, but with some content in it. --> +<p>Dummy</p>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt new file mode 100644 index 0000000..4e75b86 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +PASS document.open() changes document's URL (fully active document) +FAIL document.open() does not change document's URL (active but not fully active document) Cannot read property 'contentDocument' of null +FAIL document.open() does not change document's URL (non-active document with an associated Window object; frame is removed) assert_equals: expected "about:blank" but got "http://web-platform.test:8001/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html" +FAIL document.open() does not change document's URL (non-active document with an associated Window object; navigated away) assert_equals: expected "about:blank" but got "http://web-platform.test:8001/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html" +FAIL document.open() does not change document's URL (non-active document without an associated Window object) assert_equals: expected "about:blank" but got "http://web-platform.test:8001/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html" +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js new file mode 100644 index 0000000..282e58e --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js
@@ -0,0 +1,87 @@ +test(t => { + const frame = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => frame.remove()); + assert_equals(frame.contentDocument.URL, "about:blank"); + assert_equals(frame.contentWindow.location.href, "about:blank"); + frame.contentDocument.open(); + assert_equals(frame.contentDocument.URL, document.URL); + assert_equals(frame.contentWindow.location.href, document.URL); +}, "document.open() changes document's URL (fully active document)"); + +async_test(t => { + const blankURL = new URL("/common/blank.html", document.URL).href; + const frameURL = new URL("resources/page-with-frame.html", document.URL).href; + const frame = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => frame.remove()); + frame.onload = t.step_func(() => { + assert_equals(frame.contentDocument.URL, frameURL); + assert_equals(frame.contentWindow.location.href, frameURL); + const childFrame = frame.contentDocument.querySelector("iframe"); + const childDoc = childFrame.contentDocument; + const childWin = childFrame.contentWindow; + assert_equals(childDoc.URL, blankURL); + assert_equals(childWin.location.href, blankURL); + + // Right now childDoc is still fully active. + + frame.onload = t.step_func_done(() => { + // Now childDoc is still active but no longer fully active. + childDoc.open(); + assert_equals(childDoc.URL, blankURL); + assert_equals(childWin.location.href, blankURL); + }); + frame.src = "/common/blank.html"; + }); + frame.src = frameURL; +}, "document.open() does not change document's URL (active but not fully active document)"); + +test(t => { + const frame = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => frame.remove()); + const doc = frame.contentDocument; + + // Right now the frame is connected and it has an active document. + assert_equals(doc.URL, "about:blank"); + + frame.remove(); + + // Now the frame is no longer connected. Its document is no longer active. + assert_equals(doc.URL, "about:blank"); + assert_equals(doc.open(), doc); + assert_equals(doc.URL, "about:blank"); +}, "document.open() does not change document's URL (non-active document with an associated Window object; frame is removed)"); + +async_test(t => { + const frame = document.createElement("iframe"); + t.add_cleanup(() => frame.remove()); + + frame.onload = t.step_func(() => { + const doc = frame.contentDocument; + // Right now the frame is connected and it has an active document. + assert_equals(doc.URL, "about:blank"); + + frame.onload = t.step_func_done(() => { + // Now even though the frame is still connected, its document is no + // longer active. + assert_not_equals(frame.contentDocument, doc); + assert_equals(doc.URL, "about:blank"); + assert_equals(doc.open(), doc); + assert_equals(doc.URL, "about:blank"); + }); + + frame.src = "/common/blank.html"; + }); + + // We need to connect the frame after the load event is set up to mitigate + // against https://crbug.com/569511. + document.body.appendChild(frame); +}, "document.open() does not change document's URL (non-active document with an associated Window object; navigated away)"); + +test(t => { + const frame = document.body.appendChild(document.createElement("iframe")); + t.add_cleanup(() => frame.remove()); + const doc = frame.contentDocument.implementation.createHTMLDocument(); + assert_equals(doc.URL, "about:blank"); + assert_equals(doc.open(), doc); + assert_equals(doc.URL, "about:blank"); +}, "document.open() does not change document's URL (non-active document without an associated Window object)");
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt index f757823..10b1fd1 100644 --- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt +++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
@@ -1,4 +1,5 @@ This is a testharness.js-based test. +PASS initialize global state PASS Normal redirect to same-origin scope. FAIL Normal redirect to same-origin scope with a hash fragment. assert_object_equals: Intercepted URLs should match. property "0" expected ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?#ref"] got ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?"] FAIL Normal redirect to same-origin scope with different hash fragments. assert_object_equals: Intercepted URLs should match. property "0" expected ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?#ref2"] got ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?"] @@ -12,7 +13,7 @@ PASS SW-fallbacked redirect to other-origin in-scope. PASS SW-generated redirect to same-origin out-scope. FAIL SW-generated redirect to same-origin out-scope with a hash fragment. assert_object_equals: Intercepted URLs should match. property "0" expected ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?sw=gen&url=https%3A%2F%2Fweb-platform.test%3A8444%2Fservice-workers%2Fservice-worker%2Fresources%2Fnavigation-redirect-out-scope.py%3F#ref"] got ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?sw=gen&url=https%3A%2F%2Fweb-platform.test%3A8444%2Fservice-workers%2Fservice-worker%2Fresources%2Fnavigation-redirect-out-scope.py%3F"] -FAIL SW-generated redirect to same-origin out-scope with different hashfragments. assert_object_equals: Intercepted URLs should match. property "0" expected ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?sw=gen&url=https%3A%2F%2Fweb-platform.test%3A8444%2Fservice-workers%2Fservice-worker%2Fresources%2Fnavigation-redirect-out-scope.py%3F%23ref2#ref"] got ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?sw=gen&url=https%3A%2F%2Fweb-platform.test%3A8444%2Fservice-workers%2Fservice-worker%2Fresources%2Fnavigation-redirect-out-scope.py%3F%23ref2"] +FAIL SW-generated redirect to same-origin out-scope with different hash fragments. assert_object_equals: Intercepted URLs should match. property "0" expected ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?sw=gen&url=https%3A%2F%2Fweb-platform.test%3A8444%2Fservice-workers%2Fservice-worker%2Fresources%2Fnavigation-redirect-out-scope.py%3F%23ref2#ref"] got ["https://web-platform.test:8444/service-workers/service-worker/resources/navigation-redirect-scope1.py?sw=gen&url=https%3A%2F%2Fweb-platform.test%3A8444%2Fservice-workers%2Fservice-worker%2Fresources%2Fnavigation-redirect-out-scope.py%3F%23ref2"] PASS SW-generated redirect to same-origin same-scope. PASS SW-generated redirect to same-origin other-scope. PASS SW-generated redirect to other-origin out-scope. @@ -34,5 +35,6 @@ PASS Redirect to other-origin out-scope with opaque redirect response which is passed through Cache. PASS Redirect to other-origin in-scope with opaque redirect response which is passed through Cache. PASS No location redirect response via Cache. +PASS clean up global state Harness: the test ran to completion.
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html index ed300fa..0f1d377 100644 --- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html +++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
@@ -7,62 +7,51 @@ <script src="resources/test-helpers.sub.js"></script> <body> <script> -var host_info = get_host_info(); +const host_info = get_host_info(); // This test registers three Service Workers at SCOPE1, SCOPE2 and // OTHER_ORIGIN_SCOPE. And checks the redirected page's URL and the requests // which are intercepted by Service Worker while loading redirect page. -var BASE_URL = host_info['HTTPS_ORIGIN'] + base_path(); -var OTHER_BASE_URL = host_info['HTTPS_REMOTE_ORIGIN'] + base_path(); +const BASE_URL = host_info['HTTPS_ORIGIN'] + base_path(); +const OTHER_BASE_URL = host_info['HTTPS_REMOTE_ORIGIN'] + base_path(); -var SCOPE1 = BASE_URL + 'resources/navigation-redirect-scope1.py?'; -var SCOPE2 = BASE_URL + 'resources/navigation-redirect-scope2.py?'; -var OUT_SCOPE = BASE_URL + 'resources/navigation-redirect-out-scope.py?'; -var SCRIPT = 'resources/redirect-worker.js'; +const SCOPE1 = BASE_URL + 'resources/navigation-redirect-scope1.py?'; +const SCOPE2 = BASE_URL + 'resources/navigation-redirect-scope2.py?'; +const OUT_SCOPE = BASE_URL + 'resources/navigation-redirect-out-scope.py?'; +const SCRIPT = 'resources/redirect-worker.js'; -var OTHER_ORIGIN_IFRAME_URL = - OTHER_BASE_URL + 'resources/navigation-redirect-other-origin.html'; -var OTHER_ORIGIN_SCOPE = - OTHER_BASE_URL + 'resources/navigation-redirect-scope1.py?'; -var OTHER_ORIGIN_OUT_SCOPE = - OTHER_BASE_URL + 'resources/navigation-redirect-out-scope.py?'; +const OTHER_ORIGIN_IFRAME_URL = + OTHER_BASE_URL + 'resources/navigation-redirect-other-origin.html'; +const OTHER_ORIGIN_SCOPE = + OTHER_BASE_URL + 'resources/navigation-redirect-scope1.py?'; +const OTHER_ORIGIN_OUT_SCOPE = + OTHER_BASE_URL + 'resources/navigation-redirect-out-scope.py?'; -var workers; -var other_origin_frame; -var setup_environment_promise; -var message_resolvers = {}; -var next_message_id = 0; +let registrations; +let workers; +let other_origin_frame; +let message_resolvers = {}; +let next_message_id = 0; -function setup_environment(t) { - if (setup_environment_promise) - return setup_environment_promise; - setup_environment_promise = - with_iframe(OTHER_ORIGIN_IFRAME_URL) - .then(function(f) { - // In this frame we register a Service Worker at OTHER_ORIGIN_SCOPE. - // And will use this frame to communicate with the worker. - other_origin_frame = f; - return Promise.all( - [service_worker_unregister_and_register(t, SCRIPT, SCOPE1), - service_worker_unregister_and_register(t, SCRIPT, SCOPE2)]); - }) - .then(function(registrations) { - add_completion_callback(function() { - registrations[0].unregister(); - registrations[1].unregister(); - send_to_iframe(other_origin_frame, 'unregister') - .then(function() { other_origin_frame.remove(); }); - }); - workers = registrations.map(get_effective_worker); - return Promise.all([ - wait_for_state(t, workers[0], 'activated'), - wait_for_state(t, workers[1], 'activated'), - // This promise will resolve when |wait_for_worker_promise| - // in OTHER_ORIGIN_IFRAME_URL resolves. - send_to_iframe(other_origin_frame, 'wait_for_worker')]); - }); - return setup_environment_promise; -} +promise_test(async t => { + // In this frame we register a service worker at OTHER_ORIGIN_SCOPE. + // And will use this frame to communicate with the worker. + other_origin_frame = await with_iframe(OTHER_ORIGIN_IFRAME_URL); + + // Register same-origin service workers. + registrations = await Promise.all([ + service_worker_unregister_and_register(t, SCRIPT, SCOPE1), + service_worker_unregister_and_register(t, SCRIPT, SCOPE2)]); + + // Wait for all workers to activate. + workers = registrations.map(get_effective_worker); + return Promise.all([ + wait_for_state(t, workers[0], 'activated'), + wait_for_state(t, workers[1], 'activated'), + // This promise will resolve when |wait_for_worker_promise| + // in OTHER_ORIGIN_IFRAME_URL resolves. + send_to_iframe(other_origin_frame, 'wait_for_worker')]); +}, 'initialize global state'); function get_effective_worker(registration) { if (registration.active) @@ -73,45 +62,43 @@ return registration.installing; } -function check_all_intercepted_urls(expected_urls) { - var urls = []; - return get_intercepted_urls(workers[0]) - .then(function(url) { - urls.push(url); - return get_intercepted_urls(workers[1]); - }).then(function(url) { - urls.push(url); - // Gets the request URLs which are intercepted by OTHER_ORIGIN_SCOPE's - // SW. This promise will resolve when get_intercepted_urls() in - // OTHER_ORIGIN_IFRAME_URL resolves. - return send_to_iframe(other_origin_frame, 'get_intercepted_urls'); - }).then(function(url) { - urls.push(url); - return urls; - }).then(function(urls) { - assert_object_equals( - urls, expected_urls, - 'Intercepted URLs should match.'); - }); +async function check_all_intercepted_urls(expected_urls) { + const urls = []; + urls.push(await get_intercepted_urls(workers[0])); + urls.push(await get_intercepted_urls(workers[1])); + // Gets the request URLs which are intercepted by OTHER_ORIGIN_SCOPE's + // SW. This promise will resolve when get_intercepted_urls() in + // OTHER_ORIGIN_IFRAME_URL resolves. + urls.push(await send_to_iframe(other_origin_frame, 'get_intercepted_urls')); + assert_object_equals(urls, expected_urls, 'Intercepted URLs should match.'); } -function test_redirect(url, expected_last_url, - expected_intercepted_urls) { - var message_promise = new Promise(function(resolve) { - // A message which ID is 'last_url' will be sent from the iframe. - message_resolvers['last_url'] = resolve; +// Creates an iframe and navigates to |url|, which is expected to start a chain +// of redirects. +// - |expected_last_url| is the expected window.location after the +// navigation. +// - |expected_intercepted_urls| is the expected URLs that the service +// workers were dispatched fetch events for. The format is: +// [ +// [urls from workers[0]], +// [urls from workers[1]], +// [urls from cross-origin worker] +// ] +function redirect_test(url, + expected_last_url, + expected_intercepted_urls, + test_name) { + promise_test(async t => { + const message_promise = new Promise(resolve => { + // A message with ID 'last_url' will be sent from the iframe. + message_resolvers['last_url'] = resolve; }); - return with_iframe(url) - .then(function(f) { - f.remove(); - return check_all_intercepted_urls(expected_intercepted_urls); - }) - .then(function() { return message_promise; }) - .then(function(last_url) { - assert_equals( - last_url, expected_last_url, - 'Last URL should match.'); - }); + const frame = await with_iframe(url); + frame.remove(); + await check_all_intercepted_urls(expected_intercepted_urls); + const last_url = await message_promise; + assert_equals(last_url, expected_last_url, 'Last URL should match.'); + }, test_name); } window.addEventListener('message', on_message, false); @@ -129,400 +116,310 @@ function send_to_iframe(frame, message) { var message_id = next_message_id++; - return new Promise(function(resolve) { - message_resolvers[message_id] = resolve; - frame.contentWindow.postMessage( - {id: message_id, message: message}, - host_info['HTTPS_REMOTE_ORIGIN']); - }); + return new Promise(resolve => { + message_resolvers[message_id] = resolve; + frame.contentWindow.postMessage( + {id: message_id, message: message}, + host_info['HTTPS_REMOTE_ORIGIN']); + }); } function get_intercepted_urls(worker) { - return new Promise(function(resolve) { - var channel = new MessageChannel(); - channel.port1.onmessage = function(msg) { resolve(msg.data.urls); }; - worker.postMessage({port: channel.port2}, [channel.port2]); - }); + return new Promise(resolve => { + var channel = new MessageChannel(); + channel.port1.onmessage = function(msg) { resolve(msg.data.urls); }; + worker.postMessage({port: channel.port2}, [channel.port2]); + }); } -// Normal redirect. -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - OUT_SCOPE + 'url=' + encodeURIComponent(SCOPE1), - SCOPE1, - [[SCOPE1], [], []]); - }); - }, 'Normal redirect to same-origin scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - OUT_SCOPE + 'url=' + encodeURIComponent(SCOPE1) + '#ref', - SCOPE1 + '#ref', - [[SCOPE1 + '#ref'], [], []]); - }); - }, 'Normal redirect to same-origin scope with a hash fragment.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - OUT_SCOPE + 'url=' + encodeURIComponent(SCOPE1 + '#ref2') + '#ref', - SCOPE1 + '#ref2', - [[SCOPE1 + '#ref2'], [], []]); - }); - }, 'Normal redirect to same-origin scope with different hash fragments.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - OUT_SCOPE + 'url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), - OTHER_ORIGIN_SCOPE, - [[], [], [OTHER_ORIGIN_SCOPE]]); - }); - }, 'Normal redirect to other-origin scope.'); +// Normal redirect (from out-scope to in-scope). +redirect_test( + OUT_SCOPE + 'url=' + encodeURIComponent(SCOPE1), + SCOPE1, + [[SCOPE1], [], []], + 'Normal redirect to same-origin scope.'); +redirect_test( + OUT_SCOPE + 'url=' + encodeURIComponent(SCOPE1) + '#ref', + SCOPE1 + '#ref', + [[SCOPE1 + '#ref'], [], []], + 'Normal redirect to same-origin scope with a hash fragment.'); +redirect_test( + OUT_SCOPE + 'url=' + encodeURIComponent(SCOPE1 + '#ref2') + '#ref', + SCOPE1 + '#ref2', + [[SCOPE1 + '#ref2'], [], []], + 'Normal redirect to same-origin scope with different hash fragments.'); +redirect_test( + OUT_SCOPE + 'url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), + OTHER_ORIGIN_SCOPE, + [[], [], [OTHER_ORIGIN_SCOPE]], + 'Normal redirect to other-origin scope.'); // SW fallbacked redirect. SW doesn't handle the fetch request. -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(OUT_SCOPE), - OUT_SCOPE, - [[SCOPE1 + 'url=' + encodeURIComponent(OUT_SCOPE)], [], []]); - }); - }, 'SW-fallbacked redirect to same-origin out-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(SCOPE1), - SCOPE1, - [[SCOPE1 + 'url=' + encodeURIComponent(SCOPE1), SCOPE1], [], []]); - }); - }, 'SW-fallbacked redirect to same-origin same-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(SCOPE1) + '#ref', - SCOPE1 + '#ref', - [[SCOPE1 + 'url=' + encodeURIComponent(SCOPE1) + '#ref', - SCOPE1 + '#ref'], - [], []]); - }); - }, 'SW-fallbacked redirect to same-origin same-scope with a hash fragment.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(SCOPE1 + '#ref2') + '#ref', - SCOPE1 + '#ref2', - [[SCOPE1 + 'url=' + encodeURIComponent(SCOPE1 + '#ref2') + '#ref', - SCOPE1 + '#ref2'], - [], []]); - }); - }, 'SW-fallbacked redirect to same-origin same-scope with different hash ' + - 'fragments.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(SCOPE2), - SCOPE2, - [[SCOPE1 + 'url=' + encodeURIComponent(SCOPE2)], [SCOPE2], []]); - }); - }, 'SW-fallbacked redirect to same-origin other-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), - OTHER_ORIGIN_OUT_SCOPE, - [[SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], - [], - []]); - }); - }, 'SW-fallbacked redirect to other-origin out-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), - OTHER_ORIGIN_SCOPE, - [[SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE)], - [], - [OTHER_ORIGIN_SCOPE]]); - }); - }, 'SW-fallbacked redirect to other-origin in-scope.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(OUT_SCOPE), + OUT_SCOPE, + [[SCOPE1 + 'url=' + encodeURIComponent(OUT_SCOPE)], [], []], + 'SW-fallbacked redirect to same-origin out-scope.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(SCOPE1), + SCOPE1, + [[SCOPE1 + 'url=' + encodeURIComponent(SCOPE1), SCOPE1], [], []], + 'SW-fallbacked redirect to same-origin same-scope.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(SCOPE1) + '#ref', + SCOPE1 + '#ref', + [ + [SCOPE1 + 'url=' + encodeURIComponent(SCOPE1) + '#ref', SCOPE1 + '#ref'], + [], + [] + ], + 'SW-fallbacked redirect to same-origin same-scope with a hash fragment.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(SCOPE1 + '#ref2') + '#ref', + SCOPE1 + '#ref2', + [ + [ + SCOPE1 + 'url=' + encodeURIComponent(SCOPE1 + '#ref2') + '#ref', + SCOPE1 + '#ref2' + ], + [], + [] + ], + 'SW-fallbacked redirect to same-origin same-scope with different hash ' + + 'fragments.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(SCOPE2), + SCOPE2, + [[SCOPE1 + 'url=' + encodeURIComponent(SCOPE2)], [SCOPE2], []], + 'SW-fallbacked redirect to same-origin other-scope.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), + OTHER_ORIGIN_OUT_SCOPE, + [[SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], [], []], + 'SW-fallbacked redirect to other-origin out-scope.'); +redirect_test( + SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), + OTHER_ORIGIN_SCOPE, + [ + [SCOPE1 + 'url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE)], + [], + [OTHER_ORIGIN_SCOPE] + ], + 'SW-fallbacked redirect to other-origin in-scope.'); // SW generated redirect. // SW: event.respondWith(Response.redirect(params['url'])); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE), - OUT_SCOPE, - [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE)], [], []]); - }); - }, 'SW-generated redirect to same-origin out-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE) + '#ref', - OUT_SCOPE + '#ref', - [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE) + '#ref'], - [], []]); - }); - }, 'SW-generated redirect to same-origin out-scope with a hash fragment.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE + '#ref2') + - '#ref', - OUT_SCOPE + '#ref2', - [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE + '#ref2') + - '#ref'], - [], []]); - }); - }, 'SW-generated redirect to same-origin out-scope with different hash' + - 'fragments.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE1), - SCOPE1, - [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE1), SCOPE1], - [], - []]); - }); - }, 'SW-generated redirect to same-origin same-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE2), - SCOPE2, - [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE2)], - [SCOPE2], - []]); - }); - }, 'SW-generated redirect to same-origin other-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), - OTHER_ORIGIN_OUT_SCOPE, - [[SCOPE1 + 'sw=gen&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], - [], - []]); - }); - }, 'SW-generated redirect to other-origin out-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), - OTHER_ORIGIN_SCOPE, - [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE)], - [], - [OTHER_ORIGIN_SCOPE]]); - }); - }, 'SW-generated redirect to other-origin in-scope.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE), + OUT_SCOPE, + [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE)], [], []], + 'SW-generated redirect to same-origin out-scope.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE) + '#ref', + OUT_SCOPE + '#ref', + [ + [SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE) + '#ref'], + [], + [] + ], + 'SW-generated redirect to same-origin out-scope with a hash fragment.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE + '#ref2') + '#ref', + OUT_SCOPE + '#ref2', + [ + [SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OUT_SCOPE + '#ref2') + '#ref'], + [], + [] + ], + 'SW-generated redirect to same-origin out-scope with different hash ' + + 'fragments.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE1), + SCOPE1, + [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE1), SCOPE1], [], []], + 'SW-generated redirect to same-origin same-scope.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE2), + SCOPE2, + [[SCOPE1 + 'sw=gen&url=' + encodeURIComponent(SCOPE2)], [SCOPE2], []], + 'SW-generated redirect to same-origin other-scope.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), + OTHER_ORIGIN_OUT_SCOPE, + [ + [SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], + [], + [] + ], + 'SW-generated redirect to other-origin out-scope.'); +redirect_test( + SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), + OTHER_ORIGIN_SCOPE, + [ + [SCOPE1 + 'sw=gen&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE)], + [], + [OTHER_ORIGIN_SCOPE] + ], + 'SW-generated redirect to other-origin in-scope.'); // SW fetched redirect. // SW: event.respondWith(fetch(event.request)); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OUT_SCOPE), - OUT_SCOPE, - [[SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OUT_SCOPE)], - [], - []]); - }); - }, 'SW-fetched redirect to same-origin out-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE1), - SCOPE1, - [[SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE1), SCOPE1], - [], - []]); - }); - }, 'SW-fetched redirect to same-origin same-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE2), - SCOPE2, - [[SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE2)], - [SCOPE2], - []]); - }); - }, 'SW-fetched redirect to same-origin other-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=fetch&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), - OTHER_ORIGIN_OUT_SCOPE, - [[SCOPE1 + 'sw=fetch&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], - [], - []]); - }); - }, 'SW-fetched redirect to other-origin out-scope.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), - OTHER_ORIGIN_SCOPE, - [[SCOPE1 + 'sw=fetch&url=' + - encodeURIComponent(OTHER_ORIGIN_SCOPE)], - [], - [OTHER_ORIGIN_SCOPE]]); - }); - }, 'SW-fetched redirect to other-origin in-scope.'); +redirect_test( + SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OUT_SCOPE), + OUT_SCOPE, + [[SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OUT_SCOPE)], + [], + []], + 'SW-fetched redirect to same-origin out-scope.'); +redirect_test( + SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE1), + SCOPE1, + [[SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE1), SCOPE1], [], []], + 'SW-fetched redirect to same-origin same-scope.'); +redirect_test( + SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE2), + SCOPE2, + [ + [SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(SCOPE2)], + [SCOPE2], + [] + ], + 'SW-fetched redirect to same-origin other-scope.'); +redirect_test( + SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), + OTHER_ORIGIN_OUT_SCOPE, + [ + [SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], + [], + [] + ], 'SW-fetched redirect to other-origin out-scope.'); +redirect_test( + SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), + OTHER_ORIGIN_SCOPE, + [ + [SCOPE1 + 'sw=fetch&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE)], + [], + [OTHER_ORIGIN_SCOPE] + ], + 'SW-fetched redirect to other-origin in-scope.'); // Opaque redirect. // SW: event.respondWith(fetch( // new Request(event.request.url, {redirect: 'manual'}))); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OUT_SCOPE), - OUT_SCOPE, - [[SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OUT_SCOPE)], - [], - []]); - }); - }, 'Redirect to same-origin out-scope with opaque redirect response.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE1), - SCOPE1, - [[SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE1), SCOPE1], - [], - []]); - }); - }, 'Redirect to same-origin same-scope with opaque redirect response.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE2), - SCOPE2, - [[SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE2)], - [SCOPE2], - []]); - }); - }, 'Redirect to same-origin other-scope with opaque redirect response.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manual&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), - OTHER_ORIGIN_OUT_SCOPE, - [[SCOPE1 + 'sw=manual&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], - [], - []]); - }); - }, 'Redirect to other-origin out-scope with opaque redirect response.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), - OTHER_ORIGIN_SCOPE, - [[SCOPE1 + 'sw=manual&url=' + - encodeURIComponent(OTHER_ORIGIN_SCOPE)], - [], - [OTHER_ORIGIN_SCOPE]]); - }); - }, 'Redirect to other-origin in-scope with opaque redirect response.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manual&noLocationRedirect', - SCOPE1 + 'sw=manual&noLocationRedirect', - [[SCOPE1 + 'sw=manual&noLocationRedirect'], - [], - []]); - }); - }, 'No location redirect response.'); +redirect_test( + SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OUT_SCOPE), + OUT_SCOPE, + [[SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OUT_SCOPE)], [], []], + 'Redirect to same-origin out-scope with opaque redirect response.'); +redirect_test( + SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE1), + SCOPE1, + [[SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE1), SCOPE1], [], []], + 'Redirect to same-origin same-scope with opaque redirect response.'); +redirect_test( + SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE2), + SCOPE2, + [[SCOPE1 + 'sw=manual&url=' + encodeURIComponent(SCOPE2)], [SCOPE2], []], + 'Redirect to same-origin other-scope with opaque redirect response.'); +redirect_test( + SCOPE1 + 'sw=manual&url=' + + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), + OTHER_ORIGIN_OUT_SCOPE, + [ + [SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], + [], + [] + ], + 'Redirect to other-origin out-scope with opaque redirect response.'); +redirect_test( + SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE), + OTHER_ORIGIN_SCOPE, + [ + [SCOPE1 + 'sw=manual&url=' + encodeURIComponent(OTHER_ORIGIN_SCOPE)], + [], + [OTHER_ORIGIN_SCOPE] + ], + 'Redirect to other-origin in-scope with opaque redirect response.'); +redirect_test( + SCOPE1 + 'sw=manual&noLocationRedirect', + SCOPE1 + 'sw=manual&noLocationRedirect', + [[SCOPE1 + 'sw=manual&noLocationRedirect'], [], []], + 'No location redirect response.'); // Opaque redirect passed through Cache. // SW responds with an opaque redirectresponse from the Cache API. -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(OUT_SCOPE), - OUT_SCOPE, - [[SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(OUT_SCOPE)], - [], - []]); - }); - }, - 'Redirect to same-origin out-scope with opaque redirect response which ' + - 'is passed through Cache.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(SCOPE1), - SCOPE1, - [[SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(SCOPE1), SCOPE1], - [], - []]); - }); - }, - 'Redirect to same-origin same-scope with opaque redirect response which ' + - 'is passed through Cache.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(SCOPE2), - SCOPE2, - [[SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(SCOPE2)], - [SCOPE2], - []]); - }); - }, - 'Redirect to same-origin other-scope with opaque redirect response which ' + - 'is passed through Cache.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), - OTHER_ORIGIN_OUT_SCOPE, - [[SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE)], - [], - []]); - }); - }, - 'Redirect to other-origin out-scope with opaque redirect response which ' + - 'is passed through Cache.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(OTHER_ORIGIN_SCOPE), - OTHER_ORIGIN_SCOPE, - [[SCOPE1 + 'sw=manualThroughCache&url=' + - encodeURIComponent(OTHER_ORIGIN_SCOPE)], - [], - [OTHER_ORIGIN_SCOPE]]); - }); - }, - 'Redirect to other-origin in-scope with opaque redirect response which ' + - 'is passed through Cache.'); -promise_test(function(t) { - return setup_environment(t).then(function() { - return test_redirect( - SCOPE1 + 'sw=manualThroughCache&noLocationRedirect', - SCOPE1 + 'sw=manualThroughCache&noLocationRedirect', - [[SCOPE1 + 'sw=manualThroughCache&noLocationRedirect'], - [], - []]); - }); - }, 'No location redirect response via Cache.'); +redirect_test( + SCOPE1 + 'sw=manualThroughCache&url=' + encodeURIComponent(OUT_SCOPE), + OUT_SCOPE, + [ + [SCOPE1 + 'sw=manualThroughCache&url=' + encodeURIComponent(OUT_SCOPE)], + [], + [] + ], + 'Redirect to same-origin out-scope with opaque redirect response which ' + + 'is passed through Cache.'); +redirect_test( + SCOPE1 + 'sw=manualThroughCache&url=' + encodeURIComponent(SCOPE1), + SCOPE1, + [ + [ + SCOPE1 + 'sw=manualThroughCache&url=' + encodeURIComponent(SCOPE1), + SCOPE1 + ], + [], + [] + ], + 'Redirect to same-origin same-scope with opaque redirect response which ' + + 'is passed through Cache.'); +redirect_test( + SCOPE1 + 'sw=manualThroughCache&url=' + encodeURIComponent(SCOPE2), + SCOPE2, + [ + [SCOPE1 + 'sw=manualThroughCache&url=' + encodeURIComponent(SCOPE2)], + [SCOPE2], + [] + ], + 'Redirect to same-origin other-scope with opaque redirect response which ' + + 'is passed through Cache.'); +redirect_test( + SCOPE1 + 'sw=manualThroughCache&url=' + + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE), + OTHER_ORIGIN_OUT_SCOPE, + [ + [SCOPE1 + 'sw=manualThroughCache&url=' + + encodeURIComponent(OTHER_ORIGIN_OUT_SCOPE) + ], + [], + [] + ], + 'Redirect to other-origin out-scope with opaque redirect response which ' + + 'is passed through Cache.'); +redirect_test( + SCOPE1 + 'sw=manualThroughCache&url=' + + encodeURIComponent(OTHER_ORIGIN_SCOPE), + OTHER_ORIGIN_SCOPE, + [ + [SCOPE1 + 'sw=manualThroughCache&url=' + + encodeURIComponent(OTHER_ORIGIN_SCOPE)], + [], + [OTHER_ORIGIN_SCOPE], + ], + 'Redirect to other-origin in-scope with opaque redirect response which ' + + 'is passed through Cache.'); +redirect_test( + SCOPE1 + 'sw=manualThroughCache&noLocationRedirect', + SCOPE1 + 'sw=manualThroughCache&noLocationRedirect', + [[SCOPE1 + 'sw=manualThroughCache&noLocationRedirect'], [], []], + 'No location redirect response via Cache.'); + +// Clean up the test environment. This promise_test() needs to be the last one. +promise_test(async t => { + registrations.forEach(async registration => { + if (registration) + await registration.unregister(); + }); + await send_to_iframe(other_origin_frame, 'unregister'); + other_origin_frame.remove(); +}, 'clean up global state'); </script> </body>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-top-level-worker.py b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-top-level-worker.py new file mode 100644 index 0000000..f77ef28 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-top-level-worker.py
@@ -0,0 +1,18 @@ +import time + +def main(request, response): + # no-cache itself to ensure the user agent finds a new version for each update. + headers = [('Cache-Control', 'no-cache, must-revalidate'), + ('Pragma', 'no-cache')] + content_type = 'application/javascript' + + headers.append(('Content-Type', content_type)) + + body = ''' +let promise = self.registration.update() +onmessage = (evt) => { + promise.then(r => { + evt.source.postMessage(self.registration === r ? 'PASS' : 'FAIL'); + }); +};''' + return headers, '/* %s %s */ %s' % (time.time(), time.clock(), body)
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/update-top-level.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/update-top-level.https.html new file mode 100644 index 0000000..e382028b --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/update-top-level.https.html
@@ -0,0 +1,32 @@ +<!DOCTYPE html> +<title>Service Worker: Registration update()</title> +<script src="/resources/testharness.js"></script> +<script src="/resources/testharnessreport.js"></script> +<script src="resources/test-helpers.sub.js"></script> +<script> +'use strict'; + +function wait_for_message() { + return new Promise(resolve => { + navigator.serviceWorker.addEventListener("message", + e => { + resolve(e.data); + }, { once: true }); + }); +} + +promise_test(async t => { + const script = './resources/update-top-level-worker.py'; + const scope = './resources/empty.html?update-result'; + + let reg = await navigator.serviceWorker.register(script, { scope }); + t.add_cleanup(async _ => await reg.unregister()); + await wait_for_state(t, reg.installing, 'activated'); + + reg.addEventListener("updatefound", + () => assert_unreached("shouldn't find an update")); + + reg.active.postMessage("ping"); + assert_equals(await wait_for_message(), 'PASS', 'did not hang'); +}, 'A serviceworker with a top-level update should not hang'); +</script>
diff --git a/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any-expected.txt new file mode 100644 index 0000000..eaa4adf9 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL XMLHttpRequest: send() with a stream on which getReader() is called assert_throws: function "() => client.send(stream)" did not throw +FAIL XMLHttpRequest: send() with a stream on which read() is called assert_throws: function "() => client.send(stream)" did not throw +FAIL XMLHttpRequest: send() with a stream on which read() and releaseLock() are called assert_throws: function "() => client.send(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.js b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.js new file mode 100644 index 0000000..cca6e76a --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.js
@@ -0,0 +1,27 @@ +// META: global=window,dedicatedworker,sharedworker + +function assert_xhr(stream) { + const client = new XMLHttpRequest(); + client.open("POST", "..."); + assert_throws(new TypeError(), () => client.send(stream)); +} + +test(() => { + const stream = new ReadableStream(); + stream.getReader(); + assert_xhr(stream); +}, "XMLHttpRequest: send() with a stream on which getReader() is called"); + +test(() => { + const stream = new ReadableStream(); + stream.getReader().read(); + assert_xhr(stream); +}, "XMLHttpRequest: send() with a stream on which read() is called"); + +promise_test(async () => { + const stream = new ReadableStream({ pull: c => c.enqueue(new Uint8Array()) }), + reader = stream.getReader(); + await reader.read(); + reader.releaseLock(); + assert_xhr(stream); +}, "XMLHttpRequest: send() with a stream on which read() and releaseLock() are called");
diff --git a/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.sharedworker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.sharedworker-expected.txt new file mode 100644 index 0000000..eaa4adf9 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.sharedworker-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL XMLHttpRequest: send() with a stream on which getReader() is called assert_throws: function "() => client.send(stream)" did not throw +FAIL XMLHttpRequest: send() with a stream on which read() is called assert_throws: function "() => client.send(stream)" did not throw +FAIL XMLHttpRequest: send() with a stream on which read() and releaseLock() are called assert_throws: function "() => client.send(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.worker-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.worker-expected.txt new file mode 100644 index 0000000..eaa4adf9 --- /dev/null +++ b/third_party/WebKit/LayoutTests/external/wpt/xhr/send-data-readablestream.any.worker-expected.txt
@@ -0,0 +1,6 @@ +This is a testharness.js-based test. +FAIL XMLHttpRequest: send() with a stream on which getReader() is called assert_throws: function "() => client.send(stream)" did not throw +FAIL XMLHttpRequest: send() with a stream on which read() is called assert_throws: function "() => client.send(stream)" did not throw +FAIL XMLHttpRequest: send() with a stream on which read() and releaseLock() are called assert_throws: function "() => client.send(stream)" did not throw +Harness: the test ran to completion. +
diff --git a/third_party/WebKit/LayoutTests/fast/canvas/bug535171-expected.txt b/third_party/WebKit/LayoutTests/fast/canvas/bug535171-expected.txt index 8b13789..e249790c 100644 --- a/third_party/WebKit/LayoutTests/fast/canvas/bug535171-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/canvas/bug535171-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 7: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.
diff --git a/third_party/WebKit/LayoutTests/fast/css/clear-activechain-list-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/css/clear-activechain-list-shadow-dom-expected.txt index d171d68..170651e 100644 --- a/third_party/WebKit/LayoutTests/fast/css/clear-activechain-list-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/clear-activechain-list-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 25: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Click Me Chain of active elements should be cleared including the Shadow DOM elements
diff --git a/third_party/WebKit/LayoutTests/fast/css/content-distributed-nodes-expected.txt b/third_party/WebKit/LayoutTests/fast/css/content-distributed-nodes-expected.txt index 5c4b032..38748bf 100644 --- a/third_party/WebKit/LayoutTests/fast/css/content-distributed-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/content-distributed-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checking if styles in the nested shadow roots apply properly to distributed elements. (v0 bug compatible) On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-redistribution-expected.txt b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-redistribution-expected.txt index e6ef0b8..b0bf42b 100644 --- a/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-redistribution-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-redistribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 17: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check that getComputedStyle causes a shadow re-distribution when necessary. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/content-pseudo-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/content-pseudo-expected.txt index 676926fd..e90a009 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/content-pseudo-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/content-pseudo-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. No need to invalidate for selectors right of ::content as ::content causes subtree invalidation. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt index b21c915..2770812 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/removed-hover-shadow-rule-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/removed-hover-shadow-rule-expected.txt index 0971054..828d66d9 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/removed-hover-shadow-rule-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/removed-hover-shadow-rule-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 34: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Removing a shadow tree stylesheet should cause an invalidation set update. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-content-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-content-expected.txt index eb9fd417..a6673552 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-content-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 22: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Insert a style element into a shadow tree affecting a distributed node. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-host-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-host-expected.txt index eeae9a7..b1dc52f 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-host-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-add-sheet-host-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Insert a style element into a shadow tree affecting the host. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-host-toggle-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-host-toggle-expected.txt index a76f6fc..128d49e 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-host-toggle-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-host-toggle-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 8: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS getComputedStyle(foo).backgroundColor is "rgb(0, 128, 0)" PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-content-pseudo-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-content-pseudo-expected.txt index 16121fc..ed21ff7a 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-content-pseudo-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-content-pseudo-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 25: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check that targeted class invalidation works for ::content selectors. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt index 85deec7..c724590 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check that targeted class invalidation works with the :host pseudo class. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/toggle-style-inside-shadow-root-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/toggle-style-inside-shadow-root-expected.txt index 45cd2a80..de07348a 100644 --- a/third_party/WebKit/LayoutTests/fast/css/invalidation/toggle-style-inside-shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/toggle-style-inside-shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 5: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS internals.updateStyleAndReturnAffectedElementCount() is 1 PASS getComputedStyle(rootDiv).backgroundColor is "rgb(255, 0, 0)" PASS internals.updateStyleAndReturnAffectedElementCount() is 1
diff --git a/third_party/WebKit/LayoutTests/fast/css/remove-stylesheet-from-shadow-form-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/css/remove-stylesheet-from-shadow-form-crash-expected.txt index ea4527b7..876acc0 100644 --- a/third_party/WebKit/LayoutTests/fast/css/remove-stylesheet-from-shadow-form-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/remove-stylesheet-from-shadow-form-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS if no crash.
diff --git a/third_party/WebKit/LayoutTests/fast/css/shadow-style-removed-out-of-document-expected.txt b/third_party/WebKit/LayoutTests/fast/css/shadow-style-removed-out-of-document-expected.txt index 13505ed..91f9eba 100644 --- a/third_party/WebKit/LayoutTests/fast/css/shadow-style-removed-out-of-document-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/css/shadow-style-removed-out-of-document-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 6: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Remove style element before its shadow root is attached to document but it should not crash. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/style-onload-remove-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/style-onload-remove-crash-expected.txt index 37b1c6c..c450a0f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/style-onload-remove-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/style-onload-remove-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt index 38f2f95..75d2a24 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that cycle detection traverses over both templates and shadow roots On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/only-shadow-host-in-shadow-tree-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/only-shadow-host-in-shadow-tree-expected.txt index 45d4972c..7821424f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/only-shadow-host-in-shadow-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/only-shadow-host-in-shadow-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/359854: test for traversing elements in shadow tree. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-shadow-style-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-shadow-style-expected.txt index ef5910c30..fb0c1dc 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-shadow-style-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-shadow-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Testing <style>... PASS sheet.ownerNode is style PASS style.sheet === sheet is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/empty-shadow-style-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/empty-shadow-style-expected.txt index 0ab6f19a0..174e46f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/empty-shadow-style-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/empty-shadow-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS shadowRoot.styleSheets.length is 2 PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/elementsFromPoint/elementsFromPoint-shadowroot-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/elementsFromPoint/elementsFromPoint-shadowroot-expected.txt index 2ba1baf..146657b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/elementsFromPoint/elementsFromPoint-shadowroot-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/elementsFromPoint/elementsFromPoint-shadowroot-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 38: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS shadowRoot.elementsFromPoint() threw exception TypeError: Failed to execute 'elementsFromPoint' on 'ShadowRoot': 2 arguments required, but only 0 present.. PASS shadowRoot.elementsFromPoint(0) threw exception TypeError: Failed to execute 'elementsFromPoint' on 'ShadowRoot': 2 arguments required, but only 1 present..
diff --git a/third_party/WebKit/LayoutTests/fast/dom/gc-treescope-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/gc-treescope-expected.txt index 0383162..b75f99f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/gc-treescope-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/gc-treescope-expected.txt
@@ -1 +1,32 @@ +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test passes if it does not crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/hover-node-refcnt-asan-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/hover-node-refcnt-asan-crash-expected.txt index 9578d0d..d8b51bb 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/hover-node-refcnt-asan-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/hover-node-refcnt-asan-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test should not crash on ASAN
diff --git a/third_party/WebKit/LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt index 97eb1b7..a0aba727 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 9: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. importNode should throw informative errors for unsupported node types On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt index 6e6a24d..728ae80 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt
@@ -26,13 +26,14 @@ 1 2 3 4 5 6 -Right here is an inline block. -And an inline table with one row is here, too. -And an inline table with rows not far behind. +Right here is an inline block. + And an inline table with one row is here, too. + And an inline table +with rows not far behind. Check collapsed margins Collapsed margins are supposed to result in an extra line break. First header Second header First list element Second list element -This line contains an image. +This line contains an image.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/inner-text-first-letter.html b/third_party/WebKit/LayoutTests/fast/dom/inner-text-first-letter.html index 688c9cb..17387123 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/inner-text-first-letter.html +++ b/third_party/WebKit/LayoutTests/fast/dom/inner-text-first-letter.html
@@ -103,13 +103,13 @@ test(() => assert_equals(document.getElementById('collapsedSpaceCollapsedDivFirst').innerText, document.getElementById('collapsedSpaceCollapsedDivNormal').innerText), 'collapsedSpaceCollapsedDivFirst.innerText'); -test(() => assert_equals(document.getElementById('collapsedSpaceCollapsedDivFirst').innerText, 'foo\nabc\n'), +test(() => assert_equals(document.getElementById('collapsedSpaceCollapsedDivFirst').innerText, 'foo\nabc'), 'collapsedSpaceSollapsedDivFirst.innerText literal'); test(() => assert_equals(document.getElementById('collapsedSpacePunctDivFirst').innerText, document.getElementById('collapsedSpacePunctDivNormal').innerText), 'collapsedSpacePunctDivFirst.innerText'); -test(() => assert_equals(document.getElementById('collapsedSpacePunctDivFirst').innerText, 'foo\n| abc\n'), +test(() => assert_equals(document.getElementById('collapsedSpacePunctDivFirst').innerText, 'foo\n| abc'), 'collapsedSpacePunctDivFirst.innerText literal'); test(() => assert_equals(document.getElementById('divSpanFirst').innerText, document.getElementById('divSpanNormal').innerText), @@ -118,13 +118,13 @@ test(() => assert_equals(document.getElementById('invisiblePre').innerText, ''), 'invisiblePre.innerText'); -test(() => assert_equals(document.getElementById('invisiblePreFirst').innerText, 't\n'), +test(() => assert_equals(document.getElementById('invisiblePreFirst').innerText, ''), 'invisiblePreFirst.innerText'); -test(() => assert_equals(document.getElementById('invisible').innerText, 'test\n'), +test(() => assert_equals(document.getElementById('invisible').innerText, 'test'), 'invisible.innerText'); -test(() => assert_equals(document.getElementById('floatDt').innerText, 'AbCdE'), +test(() => assert_equals(document.getElementById('floatDt').innerText, 'Ab\nCd\nE'), 'floatDt.innerText'); </script> </body>
diff --git a/third_party/WebKit/LayoutTests/fast/dom/inner-text-with-no-renderer.html b/third_party/WebKit/LayoutTests/fast/dom/inner-text-with-no-renderer.html index e01f315d..99aaf67f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/inner-text-with-no-renderer.html +++ b/third_party/WebKit/LayoutTests/fast/dom/inner-text-with-no-renderer.html
@@ -5,7 +5,7 @@ test(() => { const div = document.createElement('div'); div.innerHTML = '"Text"<br>new line'; - assert_equals('"Text"\nnew line', div.innerText); + assert_equals(div.innerText, '"Text"new line'); }, 'innerText for an element without layout object'); </script>
diff --git a/third_party/WebKit/LayoutTests/fast/dom/nodesFromRect/nodesFromRect-basic-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/nodesFromRect/nodesFromRect-basic-expected.txt index 9319b14..2377e47 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/nodesFromRect/nodesFromRect-basic-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/nodesFromRect/nodesFromRect-basic-expected.txt
@@ -39,9 +39,9 @@ PASS All correct nodes found for rect PASS All correct nodes found for rect PASS All correct nodes found for rect -PASS All correct nodes found for rect -PASS All correct nodes found for rect -PASS All correct nodes found for rect +FAIL Unexpected node #0 for rect [39,202], [2,41] - DIV#d2 +FAIL Unexpected node #1 for rect [39,202], [6,41] - DIV#d2 +FAIL Unexpected node #2 for rect [39,202], [16,41] - DIV#d2 PASS All correct nodes found for rect PASS All correct nodes found for rect PASS All correct nodes found for rect
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash-expected.txt index e4ddf95c..43ccfd8d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for crbug.com/337059: accessing StyleSheetList::document() from GC causes crash. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/access-key-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/access-key-expected.txt index 3f58fac5..eb6b0ee 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/access-key-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/access-key-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that accesskey works in regard to shadow DOM boundary. Can only run within DRT. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt index e63f21f0..bba47c9 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 32: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Makes sure that document.activeElement returns a shadow host when a element in the correspoinding shadow tree is focused.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/adopt-node-with-shadow-root-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/adopt-node-with-shadow-root-expected.txt index bd5ef0d..5b923f9 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/adopt-node-with-shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/adopt-node-with-shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt index dcfff27d..088d90b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for issue 432257: Matched properties cache should work for all property. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets-expected.txt index 7396617..1040ba6 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 5: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Title attribute should be ignored for style elements in shadow trees. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/anchor-content-projected-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/anchor-content-projected-expected.txt index 4058bedd..8d6b4e0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/anchor-content-projected-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/anchor-content-projected-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Links should be clickable even when their content is projected into them. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/base-in-shadow-tree-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/base-in-shadow-tree-expected.txt index 5cfec9f..8215caf8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/base-in-shadow-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/base-in-shadow-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS anchorInShadow.href.indexOf("http://www.example.com") is -1 PASS anchorInHostChildren.href.indexOf("http://www.example.com") is -1 PASS anchorOutsideOfShadow.href.indexOf("http://www.example.com") is -1
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/caret-range-from-point-in-nested-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/caret-range-from-point-in-nested-shadow-expected.txt index 106e40c..a6ead6a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/caret-range-from-point-in-nested-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/caret-range-from-point-in-nested-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 25: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS internals.treeScopeRootNode(range.startContainer) is document PASS internals.treeScopeRootNode(range.endContainer) is document PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt index 1366088..a31d3e2 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for casacde of treeboundary crossing rules. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-document-position-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-document-position-expected.txt index 205801f..4fbaa8b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-document-position-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-document-position-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for Node.compareDocumentPosition() for nodes in shadow tree. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-treescope-position-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-treescope-position-expected.txt index a1d5f43..b5e3569 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-treescope-position-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/compare-treescope-position-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for TreeScope.comparePosition(). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt index 45946916..47e9e07e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for node's contains(). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-crash-expected.txt index 46cc850..03ed4842 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-distributed-nodes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-distributed-nodes-expected.txt index 29a03d98..dae414e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-distributed-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-distributed-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for content element's getDistributedNodes(). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-media-element-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-media-element-expected.txt index 6aa33588..91f9f5b0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-media-element-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-media-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. contentElementInVideoElement PASS TEST COMPLETED
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-meter-element-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-meter-element-expected.txt index 56e20353..a82f21a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-meter-element-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-meter-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. contentElementInMeterElement PASS TEST COMPLETED
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-progress-element-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-progress-element-expected.txt index 83c109e..8dc21f96 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-progress-element-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-progress-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. contentElementInProgressElement PASS TEST COMPLETED
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-select-element-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-select-element-expected.txt index ea006b2..a3e0190 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-select-element-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-in-select-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. contentElementInSelectElement PASS TEST COMPLETED
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-includer-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-includer-expected.txt index fbdf74d..0d966d5 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-includer-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-includer-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 32: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests the correctness of includers of forwarded children. Note that this test needs internals object thus cannot run outside DRT. PASS includerFor(childOfElementWithoutShadow) is null
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-move-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-move-expected.txt index 648498c..85fa6c8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-move-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-move-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 26: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. testRemoveContent PASS testRemoveContentToRecalc1
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-renderers-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-renderers-expected.txt index d29f834..b6063fe0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-renderers-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-renderers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 83: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test compares a shadow-based render tree with one for a reference DOM tree. Note that this test only runs on DRT. PASS[0,0]: content=<div/> shadow=<content/>
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-select-dynamic-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-select-dynamic-expected.txt index 9e7b7b3..480869b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-select-dynamic-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-element-select-dynamic-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. testChangeSelect1 PASS testChangeSelect2
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-not-last-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-not-last-expected.txt index 69b030a..b18014d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-not-last-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-not-last-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 9: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Accept simple selectors after ::content For Polymer 0.5 compat On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt index 0efd555..59de53e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for crbug.com/274059. Compare rules from a style in a shadow tree with ::content in a different shadow tree. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-expected.txt index 014d017c..3fdd502 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 33: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. content Test for crbug.com/274059. Should be able to override ::content styles in shadow root style sheet from the document.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2-expected.txt index 1639514c..569b6dfd 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. content Test for crbug.com/274063: cannot style ::content with a rule that includes :host.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-expected.txt index 1a7bafb..3a8b8e8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 34: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. content Test for crbug.com/274063, cannot style ::content with a rule that includes :host.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-nested-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-nested-shadow-expected.txt index fd11336..b6d7876 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-nested-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-nested-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for http://crbug.com/360679, ::content rules in nested ShadowDOM should match correctly. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-fallback-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-fallback-crash-expected.txt index 5d50ca21..3610f4c1 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-fallback-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-fallback-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. A crash should not happen when fallback elements are reprojected. PASS distributedNodes.item(0) is shadowRoot1.getElementById("fallback")
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-recalc-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-recalc-expected.txt index f7e9dbb..645e68cd 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-recalc-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-recalc-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 16: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Redistribution into same position should not cause style recalc On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt index cbe72250..787f6c49 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 32: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. dark: copy is fired. host: copy is fired. dark: cut is fired.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt index cbe72250..d42e5f3 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 30: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. dark: copy is fired. host: copy is fired. dark: cut is fired.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/create-content-element-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/create-content-element-expected.txt index 990e9ab..3a688a8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/create-content-element-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/create-content-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test compares a shadow-based render tree with one for a reference DOM tree. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/css-computed-style-declarations-length-with-dirty-distribution-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/css-computed-style-declarations-length-with-dirty-distribution-crash-expected.txt index 807303b..d0ad2c5 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/css-computed-style-declarations-length-with-dirty-distribution-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/css-computed-style-declarations-length-with-dirty-distribution-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 7: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CSSComputedStyleDeclaration.length with dirty distribution doesn't crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/cyclic-append-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/cyclic-append-crash-expected.txt index 383288d..627a952 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/cyclic-append-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/cyclic-append-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. CONSOLE MESSAGE: line 20: Failed to execute 'appendChild' on 'Node': The new child element contains the parent. If this does not crash, the test passed.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/disconnected-distribution-cycle-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/disconnected-distribution-cycle-expected.txt index be9286d0..0b3d020 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/disconnected-distribution-cycle-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/disconnected-distribution-cycle-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Distributions from disconnected subtrees should be cleared when inserted again to avoid cycles. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/distributed-node-focus-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/distributed-node-focus-expected.txt index 4ebcecc..8ecf5f53 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/distributed-node-focus-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/distributed-node-focus-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS document.activeElement.id is "input1" PASS document.activeElement.id is "input1"
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-detached-subtree-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-detached-subtree-expected.txt index dbbc6d99..942e794 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-detached-subtree-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-detached-subtree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 8: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. distribution should be recalculated correctly for a detached subtree. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-event-path-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-event-path-expected.txt index 0034c5d6..fdb9945 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-event-path-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-for-event-path-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. B, A, CAPTURING_PHASE B, #document-fragment, CAPTURING_PHASE B, CONTENT, CAPTURING_PHASE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style-expected.txt index 0bf6c34..1bccea8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/distribution-update-recalcs-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that updating the select rule in projection causes style recalc. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-shadow-expected.txt index d721472..655c6ef 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-and-drop-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests whether we can start dragging a node in shadow trees. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt index e3293d69..d02d86a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks selecting from outside of a shadow tree and to inside of a shadow tree won't crash. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-for-input-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-for-input-in-shadow-expected.txt index ae56ee4..e83646b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-for-input-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-for-input-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-in-shadow-expected.txt index ae56ee4..61ed25b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/drop-event-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 24: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/element-from-point-in-nested-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/element-from-point-in-nested-shadow-expected.txt index 19046ce6..0addb94 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/element-from-point-in-nested-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/element-from-point-in-nested-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 25: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS internals.treeScopeRootNode(element) is document PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/element-name-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/element-name-in-shadow-expected.txt index a168bd8..d2a6494 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/element-name-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/element-name-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. <a>: Before appendChild, named_a should not be in document. PASS element.name in document is false PASS element.name in window is false
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/elementfrompoint-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/elementfrompoint-expected.txt index 305ad637..0cf0d9a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/elementfrompoint-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/elementfrompoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 31: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS shadowRoot.elementFromPoint() threw exception TypeError: Failed to execute 'elementFromPoint' on 'ShadowRoot': 2 arguments required, but only 0 present.. PASS shadowRoot.elementFromPoint(0) threw exception TypeError: Failed to execute 'elementFromPoint' on 'ShadowRoot': 2 arguments required, but only 1 present..
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-in-shadow-tree-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-in-shadow-tree-expected.txt index 730f36f..c6b5a75b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-in-shadow-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-in-shadow-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. event.path on node #C #C, #B, #F, #J, #I, #M, #L, #K, #H, #G, #E, #D, #A, #sandbox, [object HTMLBodyElement], [object HTMLHtmlElement], [object HTMLDocument], [object Window], length: 18
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-dom-mutation-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-dom-mutation-expected.txt index 3f0eec75..233408d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-dom-mutation-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-dom-mutation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. event.path on node #C #C, #B, #F, #J, #I, #M, #L, #K, #H, #G, #E, #D, #A, #sandbox, [object HTMLBodyElement], [object HTMLHtmlElement], [object HTMLDocument], [object Window], length: 18
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt index 481bf26..118f08b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that all kinds of events are not stopeed at shadow boundary if created by users. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/exposed-object-within-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/exposed-object-within-shadow-expected.txt index edc37b0c..9b2e058 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/exposed-object-within-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/exposed-object-within-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Shadow DOM inside an <object> and a <div> PASS child.name in document is false PASS child.name in window is false
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-expected.txt index 77227c3..315c5555 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for Composed Shadow DOM Tree Traversal APIs. Can only run within DRT On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-negative-tabindex-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-negative-tabindex-expected.txt index 012736ef..7687e42 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-negative-tabindex-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-negative-tabindex-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests navigation from non keyboard-focusable shadow host to its shadow. crbug.com/446584 Should move from host-div to host-div/input-in-shadow in forward
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-skips-non-focusable-shadow-in-iframe-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-skips-non-focusable-shadow-in-iframe-expected.txt index e070289..5df97a8e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-skips-non-focusable-shadow-in-iframe-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-skips-non-focusable-shadow-in-iframe-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 6: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests whether focus can navigate between the two buttons by pressing tab twice. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt index a13ad77..93b14803 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that pressing Tab key should traverse into shadow DOM subtrees, and pressing Shift-Tab should reverse the order.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-no-keyboard-navigatable-but-focusable-shadow-host-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-no-keyboard-navigatable-but-focusable-shadow-host-crash-expected.txt index bf0d8fa..da5821e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-no-keyboard-navigatable-but-focusable-shadow-host-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-no-keyboard-navigatable-but-focusable-shadow-host-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-shadow-crash-expected.txt index d13a5f2e..eaabae0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-shadow-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/form-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/form-in-shadow-expected.txt index dec76f1..62be061 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/form-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/form-in-shadow-expected.txt
@@ -1,3 +1,5 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS obj.hidden is 'hidden' PASS obj.text is 'text' PASS obj.checkbox1 is 'on'
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-after-body-removed-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-after-body-removed-expected.txt index 8b13789..640cdd24 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-after-body-removed-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-after-body-removed-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 5: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-collected-shadowroot-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-collected-shadowroot-crash-expected.txt index 7ef22e9..a19ba50 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-collected-shadowroot-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-collected-shadowroot-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 8: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-shadow-expected.txt index 8f2e2fb55..5409a24d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/gc-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 20: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that the JavaScript wrapper objects of shadow DOM objects are not prematurely garbage collected.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-expected.txt index 5abdc71..ea98933 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. gesturetap @div1-shadow-root-child (target: div1-shadow-root-child)
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash-expected.txt index 8147b47..75b976d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/417064 minimal reproduction case for hitting assertion check
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-remove-node-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-remove-node-crash-expected.txt index a6afe2d..65a7e2c 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-remove-node-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/gesture-tap-remove-node-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-skips-user-agent-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-skips-user-agent-shadow-expected.txt index cc6a2c6..33c8a098 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-skips-user-agent-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/get-destination-insertion-points-skips-user-agent-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that getDestinationInsertionPoints() should skip insertion points in user-agent shadow roots. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt index 5e88ef1..4a8b64d3 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 26: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. getDistributedNodes() should work out of Document On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt index 6b70ba2..7d77b88 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that ShadowRoot.getElementById works even after mutation On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty-expected.txt index c3f7dea..b2d0c5b 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. getComputedStyle should update style if the parent node in the flat tree needs a recalc. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-with-distribution-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-with-distribution-expected.txt index cd1c356..16499af 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-with-distribution-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-with-distribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/337618: computedStyle should be cleared when distribution is updated On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-in-orphan-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-in-orphan-expected.txt index b0e222c8..756f256 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-in-orphan-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-in-orphan-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure ShadowRoot.getElementById works even if a ShadowRoot is orphan. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt index 6ff7bae..26a09b8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 23: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure ShadowRoot.getElementById works after complex DOM manipulation. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/has-elementshadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/has-elementshadow-expected.txt index 1a31d60..ae59a97 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/has-elementshadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/has-elementshadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test confirms that the number of elements having Shadow in a shadow subtree is correctly counted. See Bug 100922 also. Initial count should be 0
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/hit-test-inside-shadow-root-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/hit-test-inside-shadow-root-expected.txt index 245ae319..ab2e105 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/hit-test-inside-shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/hit-test-inside-shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Text crbug.com/491844 Moving a node from inside a shadow-root to a detached tree should not crash when we hit-test it. Hover over 'Text' to test.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/host-context-class-change-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/host-context-class-change-expected.txt index 5f6dee2..19f979c3 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/host-context-class-change-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/host-context-class-change-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Class change affecting a node in a distributed node's subtree. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/host-pseudo-class-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/host-pseudo-class-expected.txt index 9f235a2..852f7fd 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/host-pseudo-class-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/host-pseudo-class-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test whether :host matches a shadow host correctly. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/host-wrapper-reclaimed-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/host-wrapper-reclaimed-expected.txt index a3ea8e233..815556fb 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/host-wrapper-reclaimed-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/host-wrapper-reclaimed-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-first-child-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-first-child-expected.txt index 2944670..bedc194c 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-first-child-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-first-child-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that :host-context(:first-child) is re-evaluated when :first-child changes. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt index b59425e4..c0702ac 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test whether :host-context matches a shadow host correctly. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/hover-active-drag-distributed-nodes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/hover-active-drag-distributed-nodes-expected.txt index 9cfc865..e7bcfb0d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/hover-active-drag-distributed-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/hover-active-drag-distributed-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 56: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Top-level text Nested text Other div PASS backgroundColor is "rgb(0, 128, 0)"
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/hovered-detached-with-dirty-distribution-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/hovered-detached-with-dirty-distribution-crash-expected.txt index 9736deb6..bf2627d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/hovered-detached-with-dirty-distribution-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/hovered-detached-with-dirty-distribution-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 18: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that detaching a hovered node with dirty distributuion doesn't crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/iframe-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/iframe-shadow-expected.txt index 83e7fca..cce1107 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/iframe-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/iframe-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 33: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test ensures that iframe inside shadow isn't visible from the host document. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/inner-scope-important-wins-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/inner-scope-important-wins-expected.txt index 7df82ed7..241df4e0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/inner-scope-important-wins-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/inner-scope-important-wins-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Outer scope !important rules wins with higher specificity (v0 bug compatibility). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/input-color-in-content-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/input-color-in-content-expected.txt index a5e53dc2..01e2a97 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/input-color-in-content-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/input-color-in-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS mockColorChooser.isChooserShown() is false PASS mockColorChooser.isChooserShown() is true PASS mockColorChooser.isChooserShown() is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt index d6c0008b..2bc5dbf 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that layout tests can access shadow DOM.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/mouse-click-mouseup-listener-update-distribution-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/mouse-click-mouseup-listener-update-distribution-crash-expected.txt index 8147b47..75b976d 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/mouse-click-mouseup-listener-update-distribution-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/mouse-click-mouseup-listener-update-distribution-crash-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/417064 minimal reproduction case for hitting assertion check
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound-expected.txt index 6dd084ac..835c9f6c 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/multiple-host-pseudos-in-compound-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 7: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Multiple :host(-context) pseudos in same compound. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt index e7293e61..de1360e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 33: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. offsetParent should not leak nodes in user agent Shadow DOM. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/offsetWidth-host-style-change-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/offsetWidth-host-style-change-expected.txt index 67a5303e..8335a2e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/offsetWidth-host-style-change-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/offsetWidth-host-style-change-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. offsetWidth of a fixed width element should cause a style recalc if host styles are invalid On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/outer-scope-lower-specificity-wins-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/outer-scope-lower-specificity-wins-expected.txt index 5dc677d..8cc1eaaa 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/outer-scope-lower-specificity-wins-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/outer-scope-lower-specificity-wins-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Inner scope rules wins, with higher specificity (v0 bug compatibility). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/parent-tree-scope-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/parent-tree-scope-in-shadow-expected.txt index faeee4e..a3da826 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/parent-tree-scope-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/parent-tree-scope-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Creating shadow dom subtrees from top to bottom. PASS internals.parentTreeScope(shadow1) is document PASS internals.parentTreeScope(shadow2) is shadow1
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-host-parameter-matches-shadow-host-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-host-parameter-matches-shadow-host-expected.txt index af28be4..39825d1 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-host-parameter-matches-shadow-host-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-host-parameter-matches-shadow-host-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that :host(selector) can match a shadow host when the host matches the selector: http://crbug.com/313935. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-not-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-not-expected.txt index 0fe3028..e6a7e66a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-not-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/pseudo-not-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test the :not pseudo selector in On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-detached-node-distribution-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-detached-node-distribution-expected.txt index 1ee52dd..dacd1c5 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-detached-node-distribution-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-detached-node-distribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/337618: querySelector needs ensure distribution. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-distribution-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-distribution-expected.txt index 1ee52dd..dacd1c5 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-distribution-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-distribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/337618: querySelector needs ensure distribution. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt index f318d03..dc9a008 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/337616: test for querySelectorAll with ::shadow and /deep/ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/reinsert-insertion-point-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/reinsert-insertion-point-expected.txt index ca86afd..0f08dd4 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/reinsert-insertion-point-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/reinsert-insertion-point-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 9: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS inside.offsetHeight > 0 is true PASS inside.offsetHeight > 0 is true PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-and-insert-style-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-and-insert-style-expected.txt index 46d2fcf..66e6574a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-and-insert-style-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-and-insert-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 48: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for Issue: 246300: Styles in nested shadows are not recalculated correctly on insertion. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash-expected.txt index 7ef22e9..84ce308 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 9: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-2-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-2-expected.txt index 7ef22e9..cfbca39 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-2-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-2-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-3-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-3-expected.txt index b3ba06d4..0266ea9 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-3-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS if no crash
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt index 7ef22e9..22c2217 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-stylesheet-from-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-stylesheet-from-shadow-crash-expected.txt index d31f6ea..b20ecd0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-stylesheet-from-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/remove-stylesheet-from-shadow-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 9: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test should not crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/resize-in-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/resize-in-shadow-dom-expected.txt index 8b6f2b0..fde7aa1 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/resize-in-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/resize-in-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 22: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS box.offsetWidth is 114 PASS box.offsetHeight is 114 PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt index af369cd3..f273406 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/select-in-shadowdom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 18: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. When selecting from non-anchor Node to anchor node in ShadowDOM, client should not cause page jump. Selecting from a node to another node in ShadowDOM. This should not start page navigation.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt index e02e0ea8..3ab108f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS internals.treeScopeRootNode(selection.anchorNode) is document PASS internals.treeScopeRootNode(selection.focusNode) is document PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/selections-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/selections-in-shadow-expected.txt index beb7b3a3b..d868fdd4 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/selections-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/selections-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 40: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. CONTAINER1 --> CONTAINER1
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash-expected.txt index 4ff4c1a..8c9f63b6 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 8: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that setting an attribute in Shadow DOM does not cause a crash. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-added-display-none-host-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-added-display-none-host-expected.txt index 5fd0bb0..0fb3c7f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-added-display-none-host-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-added-display-none-host-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests adding a shadow root to a display none host doesn't leave dirty bits. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-crossing-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-crossing-expected.txt index a3a37de..4f6fbab 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-crossing-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-crossing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 125: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that shadow DOM boundary is not crossed during event propagation. Can only run within DRT. See bug 46015 for details.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-events-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-events-expected.txt index 0855fb7..20d0f66 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-events-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-boundary-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that shadow DOM boundary is not crossed during event propagation. Can only run within DRT. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt index 58c86e2..9862c5a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 62: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. testAppendFallback PASS testAppendFallbackDeep
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-expected.txt index 82201599..499599f2 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-contents-fallback-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 63: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS PASS PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt index e1dbfab5..f1c67bd0 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 1: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that shadow element cannot be created in elements having dynamically created shadow root. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt index 192fc66..3b336c29 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt index 82c9810..aec2478 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt index 318ca78e..908400d3 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Text Node
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt index b0fd055..04458ed 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt index f4517c5..0ab5ff6 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt index ba44ebf..a2a5700 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt index 73d5d0dc..c8480732 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt index 7f7ba51..7b71e3e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt index 83f72ab..2a185a82 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Flat Tree will be:
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-mouse-event-adjust-offset-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-mouse-event-adjust-offset-expected.txt index 50dd1d0..92a6abf 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-mouse-event-adjust-offset-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-mouse-event-adjust-offset-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that MouseEvent's offsetX and offsetY are adjusted in re-targeting. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt index 8b13789..5084798 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt index fa6e2011..0f568a768 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for a shadow element's getDistributedNodes(). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-rendering-single-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-rendering-single-expected.txt index 3323b96..62e3376 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-rendering-single-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-element-rendering-single-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. renderingShadowElementDynamicallyAdded PASS renderingShadowElementDynamicallyRemoved
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-hierarchy-exception-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-hierarchy-exception-expected.txt index c9776e5d..8ee5dc1 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-hierarchy-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-hierarchy-exception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Appending an ancestor to a shadow tree should throw an exception On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-removechild-and-blur-event-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-removechild-and-blur-event-expected.txt index 16e8400..e033b60 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-removechild-and-blur-event-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-removechild-and-blur-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check focused shadow node dispatchs blur event on removeChild of host. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-activeElement-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-activeElement-expected.txt index 051f3b2..4f896bb 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-activeElement-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-activeElement-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests the activeElement property of a ShadowRoot. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-append-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-append-expected.txt index bd2c8362..ca1d1a4 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-append-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-append-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that appending shadow root as a child does not crash. PASS root.firstChild is null
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-blur-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-blur-expected.txt index 0559f7b..2f7c6ca 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-blur-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-blur-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests the blur() on on shadow host should work when a shadow host contains a focused element in its shadow DOM subtrees property (bug 81102) On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-direction-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-direction-expected.txt index ce7665c..d5569525 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-direction-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-direction-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 8: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Element direction details are accessible to shadow root On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt index 2869d33..306bb84 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 17: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests the innerHTML property of a shadow root. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt index 62c20cfb..52bbb2a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for ShadowRoot JS APIs. Can only run within DRT On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt index 96cacb5..c34c625 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks the object 'host.createShadowRoot()' and internals.shadowRoot(div) are the same. PASS root1 is root2
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-node-list-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-node-list-expected.txt index a6146aa..236d30a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-node-list-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-node-list-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-text-child-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-text-child-expected.txt index a6146aa..c5827a48 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-text-child-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-text-child-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt index 37b1c6c..cc82ea1a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-selection-detach-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-selection-detach-crash-expected.txt index 5128d68..844e4160 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-selection-detach-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-selection-detach-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Garbage collection of Selection objects with shorter lifetimes must not crash. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-listener-clearance-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-listener-clearance-expected.txt index ecbdd8fe3..7f1eccb 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-listener-clearance-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-listener-clearance-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 7: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS firedCount is 1 PASS firedCount is 1 PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host-expected.txt index 03af4c7..a34a1e1 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for issue 247275: shadow tree styles selects shadow host. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt index 46cc850..33a04c14 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-ul-li-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-dynamic-styling-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-dynamic-styling-expected.txt index 0950f83..795ff590 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-dynamic-styling-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-dynamic-styling-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for https://bugs.webkit.org/show_bug.cgi?id=92899. Dynamically styling ShadowDom content on a node distributed to another shadow insertion point fails. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-unknown-with-form-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-unknown-with-form-expected.txt index fbfeed9..c04c7aa 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-unknown-with-form-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-unknown-with-form-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 4: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS if not crashed.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowhost-keyframes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowhost-keyframes-expected.txt index 7574b67d..187e1cf3 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowhost-keyframes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowhost-keyframes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 30: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test if @keyframes works for shadow host when using :host. i.e. crbug.com/332577 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt index 0e7af41..7867432 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Calling ShadowRoot.cloneNode() should throw a NotSupportedError exception. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt index ddbeb5f..46da255 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-type-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-type-expected.txt index 6bf6d8b..9daf07e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-type-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-type-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test ensures ShadowRootType is correctly reflected On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-dynamic-changes-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-dynamic-changes-expected.txt index a2dd5eb..60b7531 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-dynamic-changes-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-dynamic-changes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 19: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test dynamically changing sibling rule matches in ShadowRoots On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-under-shadow-root-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-under-shadow-root-expected.txt index 5aedb18..8d2d8271 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-under-shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/sibling-rules-under-shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. crbug.com/337573: Test direct/indirect adjucent and positinal rules under shadow root. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-insertion-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-insertion-crash-expected.txt index 37b1c6c..52f7d95 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-insertion-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-insertion-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-of-distributed-node-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-of-distributed-node-expected.txt index 5fbf751..3ee57b7 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-of-distributed-node-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-of-distributed-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 27: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that styles of distributed nodes are different if their parent styles are different. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-host-attribute-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-host-attribute-expected.txt index 6024dcd..d95a8f1 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-host-attribute-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-host-attribute-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 18: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Don't share style between two hosts with different attribute matching for :host([]) On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-sibling-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-sibling-shadow-expected.txt index d4beba10..cd453821 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-sibling-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/style-sharing-sibling-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 22: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Siblings should only share if their host rules match On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt index d12dca1..ec2ba68 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensures that DOMCharacterDataModified isn't fired inside shadows. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/svg-style-in-shadow-tree-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/svg-style-in-shadow-tree-crash-expected.txt index 7ef22e9..4503f94 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/svg-style-in-shadow-tree-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/svg-style-in-shadow-tree-crash-expected.txt
@@ -1 +1,12 @@ +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt index 3224037..0bc3f8e 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that pressing Tab key should traverse into iframe and shadow tree, and pressing Shift-Tab should reverse the order. Should move from input-01 to input-13 in forward
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt index 77cdfb7..d1311f8 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test ensures that title elements in a shadow subtree do not affect document.title attribute. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/tooltips-in-shadow-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/tooltips-in-shadow-expected.txt index a3b01006..df2c9a9f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/tooltips-in-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/tooltips-in-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test for Case1: Non-Nested PASS harness.expected is testRunner.tooltipText Test for Case 2: Nested
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-expected.txt index 79990c6..dc44467 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Touch event should be fired in Shadow DOM. Elements in ShadowDOM should not be revealed in touchTarget if it's examined in non shadow tree.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-retargeting-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-retargeting-expected.txt index f3b0fea..539b9c5 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-retargeting-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/touch-event-retargeting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Touch event retargeting. foo
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-createshadowroot-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-createshadowroot-expected.txt index f95165f..3798915 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-createshadowroot-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-createshadowroot-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS - "opacity" property for "target" element at 0.5s saw something close to: 0.5 PASS - "width" property for "target" element at 0.5s saw something close to: 100
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-with-distributed-node-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-with-distributed-node-expected.txt index 54c31f8..e42b052a 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-with-distributed-node-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/transition-on-shadow-host-with-distributed-node-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 30: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS - "opacity" property for "box" element at 0.5s saw something close to: 0.5
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/update-text-of-style-in-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/update-text-of-style-in-shadow-dom-expected.txt index 1ad50e2..c09ffa9 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/update-text-of-style-in-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/update-text-of-style-in-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests update the text of styles updates styles in shadow dom, crbug.com/247280 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/user-modify-inheritance-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/user-modify-inheritance-expected.txt index b1bea8f..ff565cf 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/user-modify-inheritance-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/user-modify-inheritance-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 30: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure that a '-webkit-user-modify' CSS property is not inherited across shadow boundaries. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-in-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-in-shadow-dom-expected.txt index 7cdc97c..7b9533f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-in-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-in-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 25: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS: mousewheel event is fired. PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-on-input-in-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-on-input-in-shadow-dom-expected.txt index 7cdc97c..7b9533f 100644 --- a/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-on-input-in-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/dom/shadow/wheel-event-on-input-in-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 25: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS: mousewheel event is fired. PASS successfullyParsed is true
diff --git a/third_party/WebKit/LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt index b73159e..4a73ca7 100644 --- a/third_party/WebKit/LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests ensures that an event listener on an attribute node inside a shadow DOM is properly unregistered when parent element of the attribute is moved to a new document. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt b/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt index 32d288e..4828ceb 100644 --- a/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01-expected.txt
@@ -1,31 +1,26 @@ +CONSOLE ERROR: line 11: Uncaught Error: Error in isolated world inline script. +CONSOLE ERROR: line 8: Uncaught Error: Error in isolated world load handler. +CONSOLE ERROR: line 6: Uncaught Error: Error in isolated world setTimeout callback. Test that window.onerror and "error" event listeners from main world are not invoked for uncaught exceptions in scripts running in isolate worlds, but only for exceptions in the main world. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -Handling 'error' event (phase 2): "Uncaught Error: Error in isolated world inline script." at window-onerror-isolatedworld-01.html:11 -No stack trace. -PASS eventPassedToTheErrorListener is window.event -PASS eventCurrentTarget is window -Calling e.preventDefault(): the error should not be reported in the console as an unhandled exception. - - - -window.onerror: "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html (Line: 52, Column: 13) +window.onerror: "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html (Line: 49, Column: 13) Stack Trace: Error: Error in main world inline script. - at exceptions window-onerror-isolatedworld-01.html:52:19 - at window-onerror-isolatedworld-01.html:58:9 + at exceptions window-onerror-isolatedworld-01.html:49:19 + at window-onerror-isolatedworld-01.html:55:9 Returning 'true': the error should not be reported in the console as an unhandled exception. -Handling 'error' event (phase 2): "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html:52 +Handling 'error' event (phase 2): "Uncaught Error: Error in main world inline script." at window-onerror-isolatedworld-01.html:49 Stack Trace: Error: Error in main world inline script. - at exceptions window-onerror-isolatedworld-01.html:52:19 - at window-onerror-isolatedworld-01.html:58:9 + at exceptions window-onerror-isolatedworld-01.html:49:19 + at window-onerror-isolatedworld-01.html:55:9 PASS eventPassedToTheErrorListener is window.event PASS eventCurrentTarget is window @@ -33,27 +28,19 @@ -Handling 'error' event (phase 2): "Uncaught Error: Error in isolated world load handler." at window-onerror-isolatedworld-01.html:8 -No stack trace. -PASS eventPassedToTheErrorListener is window.event -PASS eventCurrentTarget is window -Calling e.preventDefault(): the error should not be reported in the console as an unhandled exception. - - - -window.onerror: "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html (Line: 49, Column: 17) +window.onerror: "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html (Line: 46, Column: 17) Stack Trace: Error: Error in main world load handler. - at window-onerror-isolatedworld-01.html:49:23 + at window-onerror-isolatedworld-01.html:46:23 Returning 'true': the error should not be reported in the console as an unhandled exception. -Handling 'error' event (phase 2): "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html:49 +Handling 'error' event (phase 2): "Uncaught Error: Error in main world load handler." at window-onerror-isolatedworld-01.html:46 Stack Trace: Error: Error in main world load handler. - at window-onerror-isolatedworld-01.html:49:23 + at window-onerror-isolatedworld-01.html:46:23 PASS eventPassedToTheErrorListener is window.event PASS eventCurrentTarget is window @@ -61,29 +48,19 @@ -FAIL Only main-world exceptions should be caught by ErrorEvent listeners. -Handling 'error' event (phase 2): "Uncaught Error: Error in isolated world setTimeout callback." at window-onerror-isolatedworld-01.html:6 -No stack trace. -PASS eventPassedToTheErrorListener is window.event -PASS eventCurrentTarget is window -Calling e.preventDefault(): the error should not be reported in the console as an unhandled exception. - - - -FAIL Only main-world exceptions should be caught by ErrorEvent listeners. -window.onerror: "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html (Line: 47, Column: 21) +window.onerror: "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html (Line: 44, Column: 21) Stack Trace: Error: Error in main world setTimeout callback. - at window-onerror-isolatedworld-01.html:47:27 + at window-onerror-isolatedworld-01.html:44:27 Returning 'true': the error should not be reported in the console as an unhandled exception. -Handling 'error' event (phase 2): "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html:47 +Handling 'error' event (phase 2): "Uncaught Error: Error in main world setTimeout callback." at window-onerror-isolatedworld-01.html:44 Stack Trace: Error: Error in main world setTimeout callback. - at window-onerror-isolatedworld-01.html:47:27 + at window-onerror-isolatedworld-01.html:44:27 PASS eventPassedToTheErrorListener is window.event PASS eventCurrentTarget is window @@ -91,7 +68,6 @@ -FAIL Only main-world exceptions should be caught by ErrorEvent listeners. PASS successfullyParsed is true TEST COMPLETE
diff --git a/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01.html b/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01.html index 31b08930..e583a28 100644 --- a/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01.html +++ b/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-01.html
@@ -18,8 +18,7 @@ if (onerrorsHandled > 3) testFailed("Only main-world exceptions should be caught by onerror handlers."); - // FIXME: This should be 6 once we correctly handle 'error' event dispatch for worlds: crbug.com/225513 - if (errorsHandled === 9) + if (errorsHandled === 6) finishJSTest(); } @@ -27,12 +26,10 @@ function errorEventCallback(errorsHandled) { errorEventsHandled++; if (errorEventsHandled > 3) { - // FIXME: This currently fails. We need to correctly handle 'error' event dispatch for worlds: crbug.com/225513 testFailed("Only main-world exceptions should be caught by ErrorEvent listeners."); } - // FIXME: This should be 6 once we correctly handle 'error' event dispatch for worlds: crbug.com/225513 - if (errorsHandled === 9) + if (errorsHandled === 6) finishJSTest(); }
diff --git a/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-02-expected.txt b/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-02-expected.txt index 49353f0..515cd38 100644 --- a/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-02-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/events/window-onerror-isolatedworld-02-expected.txt
@@ -1,14 +1,14 @@ +CONSOLE ERROR: line 30: Uncaught Error: Error in main world inline script. +CONSOLE ERROR: line 27: Uncaught Error: Error in main world load handler. Test that window.onerror and "error" event listeners from isolated world are invoked for uncaught exceptions in scripts running in isolate worlds as well as for exceptions in the main world.Bug 8519. isolated world window.onerror: Uncaught Error: Error in isolated world inline script. at window-onerror-isolatedworld-02.html, Line: 41, Column: 13 Error object present! isolated world error event listener: Uncaught Error: Error in isolated world inline script. at window-onerror-isolatedworld-02.html:, Line: 41 Error object present! -isolated world error event listener: Uncaught Error: Error in main world inline script. at window-onerror-isolatedworld-02.html:, Line: 30 -No error object present! isolated world window.onerror: Uncaught Error: Error in isolated world load handler. at window-onerror-isolatedworld-02.html, Line: 38, Column: 17 Error object present! isolated world error event listener: Uncaught Error: Error in isolated world load handler. at window-onerror-isolatedworld-02.html:, Line: 38 Error object present! -isolated world error event listener: Uncaught Error: Error in main world load handler. at window-onerror-isolatedworld-02.html:, Line: 27 -No error object present! +isolated world window.onerror: Uncaught Error: Error in isolated world setTimeout callback. at window-onerror-isolatedworld-02.html, Line: 36, Column: 21 +Error object present!
diff --git a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-adoptnode-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-adoptnode-crash-expected.txt index 46cc850..4ea0ba7010 100644 --- a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-adoptnode-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-adoptnode-crash-expected.txt
@@ -1 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash.
diff --git a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-shadowdom-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-shadowdom-crash-expected.txt index 46cc850..8427c012 100644 --- a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-shadowdom-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-shadowdom-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 14: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS unless crash.
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children-expected.txt b/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children-expected.txt deleted file mode 100644 index 869305c..0000000 --- a/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children-expected.txt +++ /dev/null
@@ -1,10 +0,0 @@ -Check that a select control does not render children that are not <option> or <optgroup>. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS select.innerText is "" -PASS successfullyParsed is true - -TEST COMPLETE -
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children.html b/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children.html index ecb080f..5606dee 100644 --- a/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children.html +++ b/third_party/WebKit/LayoutTests/fast/forms/select/menulist-no-renderer-for-unexpected-children.html
@@ -1,11 +1,10 @@ <!DOCTYPE html> -<script src="../../../resources/js-test.js"></script> +<script src="../../../resources/testharness.js"></script> +<script src="../../../resources/testharnessreport.js"></script> <select size="2"> <option>PASS</option>FAIL </select> <script> -description('Check that a select control does not render children that are not <option> or <optgroup>.'); - var select = document.querySelector('select'); var div = select.appendChild(document.createElement('div')); @@ -15,5 +14,7 @@ // innerText uses the render tree, and the "FAIL" text (from either the initial // HTML or the dynamially inserted <div>) should not be in the render tree, thus // not appear. -shouldBeEqualToString('select.innerText', ''); +test(() => + assert_equals(select.innerText, 'PASS'), + 'SELECT should not render other than OPTION and OPTGROUP'); </script>
diff --git a/third_party/WebKit/LayoutTests/fast/frames/detached-shadow-frame-expected.txt b/third_party/WebKit/LayoutTests/fast/frames/detached-shadow-frame-expected.txt index 4b393dd..fbeaaa5e 100644 --- a/third_party/WebKit/LayoutTests/fast/frames/detached-shadow-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/frames/detached-shadow-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Should not be able to create an iframe with a loaded contentDocument that is not in the document tree. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area-expected.txt b/third_party/WebKit/LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area-expected.txt index e55251bb5..26924b4 100644 --- a/third_party/WebKit/LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that Layer doesn't crash because it is missing a ScrollableArea. This test has PASSED if it didn't CRASH.
diff --git a/third_party/WebKit/LayoutTests/fast/selectors/query-update-distribution-expected.txt b/third_party/WebKit/LayoutTests/fast/selectors/query-update-distribution-expected.txt index 4189371..fe654b4 100644 --- a/third_party/WebKit/LayoutTests/fast/selectors/query-update-distribution-expected.txt +++ b/third_party/WebKit/LayoutTests/fast/selectors/query-update-distribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 15: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Should update distribution when needed for querySelector and related methods. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash-expected.txt new file mode 100644 index 0000000..88e5335 --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash-expected.txt
@@ -0,0 +1 @@ +Shouldn't crash.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash.html index 44fb1553..0623be38 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash.html
@@ -1,12 +1,13 @@ <div style="display: contents"><a href="#"></a></div> Shouldn't crash. -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> <script> - test(() => { - assert_true(!!window.testRunner); - testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); - testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); - eventSender.keyDown("ArrowLeft"); - }, "No crash or assertion failure"); +testRunner.dumpAsText(); +testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); +testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + +function runTest() { + eventSender.keyDown("ArrowLeft"); +} + +window.onload = runTest; </script>
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor-expected.txt new file mode 100644 index 0000000..1c858f0 --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor-expected.txt
@@ -0,0 +1,7 @@ +DivInLinkA +DivInLinkB + PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "e1" +This test is testing that we can navigate on links with divs inside.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor.html index 0337d10..dbefb71 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor.html
@@ -1,15 +1,43 @@ +<html> + <head> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> + + var resultMap = [ + ["Down", "e1"], + ["DONE", "DONE"] + ]; + + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } + + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + </script> + </head> +<body id="some-content" xmlns="http://www.w3.org/1999/xhtml" style="padding:20px"> <a href="#" id="start"><div>DivInLinkA</div></a> <a href="#" id="e1"><div>DivInLinkB</div></a> -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "e1"], - ]; - - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> +<div id="console"></div> +This test is testing that we can navigate on links with divs inside. +</body> +</html>
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally-expected.txt new file mode 100644 index 0000000..60c3770 --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally-expected.txt
@@ -0,0 +1,49 @@ +test +H ow Now Brown Cow +Ho w Now Brown Cow +How Now Brown Cow +How N ow Brown Cow +How No w Brown Cow +How Now Brown Cow +How Now B rown Cow +How Now Br own Cow +How Now Bro wn Cow +How Now Brow n Cow +How Now Brown Cow +How Now Brown C ow +How Now Brown Co w +How Now Brown Cow + +test + PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "2" +PASS gFocusedDocument.activeElement.getAttribute("id") is "4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "5" +PASS gFocusedDocument.activeElement.getAttribute("id") is "6" +PASS gFocusedDocument.activeElement.getAttribute("id") is "8" +PASS gFocusedDocument.activeElement.getAttribute("id") is "7" +PASS gFocusedDocument.activeElement.getAttribute("id") is "9" +PASS gFocusedDocument.activeElement.getAttribute("id") is "10" +PASS gFocusedDocument.activeElement.getAttribute("id") is "12" +PASS gFocusedDocument.activeElement.getAttribute("id") is "11" +PASS gFocusedDocument.activeElement.getAttribute("id") is "13" +PASS gFocusedDocument.activeElement.getAttribute("id") is "14" +PASS gFocusedDocument.activeElement.getAttribute("id") is "16" +PASS gFocusedDocument.activeElement.getAttribute("id") is "15" +PASS gFocusedDocument.activeElement.getAttribute("id") is "17" +PASS gFocusedDocument.activeElement.getAttribute("id") is "18" +PASS gFocusedDocument.activeElement.getAttribute("id") is "20" +PASS gFocusedDocument.activeElement.getAttribute("id") is "19" +PASS gFocusedDocument.activeElement.getAttribute("id") is "21" +PASS gFocusedDocument.activeElement.getAttribute("id") is "22" +PASS gFocusedDocument.activeElement.getAttribute("id") is "24" +PASS gFocusedDocument.activeElement.getAttribute("id") is "23" +PASS gFocusedDocument.activeElement.getAttribute("id") is "25" +PASS gFocusedDocument.activeElement.getAttribute("id") is "26" +PASS gFocusedDocument.activeElement.getAttribute("id") is "27" +PASS gFocusedDocument.activeElement.getAttribute("id") is "end" +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally.html index faacd22a..d40935d 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-horizontally.html
@@ -1,58 +1,98 @@ -<a id="start" href="a">test<br></a> -<a id="1" href="a">H</a> <a id="2" href="p">ow Now Brown Cow</a><br> -<a id="3" href="a">Ho</a> <a id="4" href="p">w Now Brown Cow</a><br> -<a id="5" href="a">How</a> <a id="6" href="p">Now Brown Cow</a><br> -<a id="7" href="a">How N</a> <a id="8" href="p">ow Brown Cow</a><br> -<a id="9" href="a">How No</a> <a id="10" href="p">w Brown Cow</a><br> -<a id="11" href="a">How Now </a> <a id="12" href="p">Brown Cow</a><br> -<a id="13" href="a">How Now B</a> <a id="14" href="p">rown Cow</a><br> -<a id="15" href="a">How Now Br</a> <a id="16" href="p">own Cow</a><br> -<a id="17" href="a">How Now Bro</a> <a id="18" href="p">wn Cow</a><br> -<a id="19" href="a">How Now Brow</a> <a id="20" href="p">n Cow</a><br> -<a id="21" href="a">How Now Brown</a> <a id="22" href="p">Cow</a><br> -<a id="23" href="a">How Now Brown C</a> <a id="24" href="p">ow</a><br> -<a id="25" href="a">How Now Brown Co</a> <a id="26" href="p">w</a><br> -<a id="27" href="a">How Now Brown Cow</a><br><br> -<a id="end" href="a">test<br></a> +<html> + <!-- + This test ensures the correctness of the "Fully aligned" precedence + logic implemented by Spatial Navigation algorithm in an horizontal direction: + targets whose middle falls between the top and bottom of the current focused + element are preferably to move focus to, even if it is not the shortest distance. -<p>This test ensures the correctness of the "Fully aligned" precedence logic implemented by Spatial Navigation algorithm in an horizontal direction: targets whose middle falls between the top and bottom of the current focused element are preferably to move focus to, even if it is not the shortest distance.</p> + * Pre-conditions: + 1) DRT support for SNav enable/disable. -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "1"], - ["Right", "2"], - ["Down", "4"], - ["Left", "3"], - ["Down", "5"], - ["Right", "6"], - ["Down", "8"], - ["Left", "7"], - ["Down", "9"], - ["Right", "10"], - ["Down", "12"], - ["Left", "11"], - ["Down", "13"], - ["Right", "14"], - ["Down", "16"], - ["Left", "15"], - ["Down", "17"], - ["Right", "18"], - ["Down", "20"], - ["Left", "19"], - ["Down", "21"], - ["Right", "22"], - ["Down", "24"], - ["Left", "23"], - ["Down", "25"], - ["Right", "26"], - ["Down", "27"], - ["Down", "end"], - ]; + * Navigation steps: + 1) Loads this page, focus goes to "start" automatically. + 2) Focus moves preferably to elements right up or above the + current focused element, even when there are some other closer + but not vertically aligned elements in the same direction. + --> + <head> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + var resultMap = [ + ["Down", "1"], + ["Right", "2"], + ["Down", "4"], + ["Left", "3"], + ["Down", "5"], + ["Right", "6"], + ["Down", "8"], + ["Left", "7"], + ["Down", "9"], + ["Right", "10"], + ["Down", "12"], + ["Left", "11"], + ["Down", "13"], + ["Right", "14"], + ["Down", "16"], + ["Left", "15"], + ["Down", "17"], + ["Right", "18"], + ["Down", "20"], + ["Left", "19"], + ["Down", "21"], + ["Right", "22"], + ["Down", "24"], + ["Left", "23"], + ["Down", "25"], + ["Right", "26"], + ["Down", "27"], + ["Down", "end"], + ["DONE", "DONE"] + ]; + + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } + + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + </script> + </head> + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <a id="start" href="a">test<br></a> + <a id="1" href="a">H</a> <a id="2" href="p">ow Now Brown Cow</a><br> + <a id="3" href="a">Ho</a> <a id="4" href="p">w Now Brown Cow</a><br> + <a id="5" href="a">How</a> <a id="6" href="p">Now Brown Cow</a><br> + <a id="7" href="a">How N</a> <a id="8" href="p">ow Brown Cow</a><br> + <a id="9" href="a">How No</a> <a id="10" href="p">w Brown Cow</a><br> + <a id="11" href="a">How Now </a> <a id="12" href="p">Brown Cow</a><br> + <a id="13" href="a">How Now B</a> <a id="14" href="p">rown Cow</a><br> + <a id="15" href="a">How Now Br</a> <a id="16" href="p">own Cow</a><br> + <a id="17" href="a">How Now Bro</a> <a id="18" href="p">wn Cow</a><br> + <a id="19" href="a">How Now Brow</a> <a id="20" href="p">n Cow</a><br> + <a id="21" href="a">How Now Brown</a> <a id="22" href="p">Cow</a><br> + <a id="23" href="a">How Now Brown C</a> <a id="24" href="p">ow</a><br> + <a id="25" href="a">How Now Brown Co</a> <a id="26" href="p">w</a><br> + <a id="27" href="a">How Now Brown Cow</a><br><br> + <a id="end" href="a">test<br></a> + <div id="console"></div> + </body> +</html> +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically-expected.txt new file mode 100644 index 0000000..d2657a7 --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically-expected.txt
@@ -0,0 +1,22 @@ +test +test test +test +test +test +test + + + + +test +test + PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "6" +PASS gFocusedDocument.activeElement.getAttribute("id") is "7" +PASS gFocusedDocument.activeElement.getAttribute("id") is "end" +PASS gFocusedDocument.activeElement.getAttribute("id") is "8" +PASS gFocusedDocument.activeElement.getAttribute("id") is "6" +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically.html index 29801b6..abca83a3 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-fully-aligned-vertically.html
@@ -1,41 +1,81 @@ -<div style="margin-left: 40px; text-align: left;"> - <div style="margin-left: 40px;"> - <a id="start" href="a">test<br></a> - </div> - <a id="2" href="a">test</a> <a id="3" href="a">test</a><br> - <div style="margin-left: 40px;"> - <a id="4" href="a">test<br></a> - </div> - <div style="margin-left: 80px;"> - <a id="5" href="a">test<br></a> - </div> - <div style="margin-left: 40px;"> - <a id="6" href="a">test<br></a> - </div> - <a id="7" href="a">test<br></a> - <br><br><br><br> - <div style="margin-left: 40px;"> - <a id="8" href="a">test<br></a> - </div> - <a id="end" href="a">test<br></a> -</div> +<html> + <!-- + This test ensures the correctness of the "Fully aligned" precedence + logic implemented by Spatial Navigation algorithm in an vertical direction: + targets whose middle falls between the top and bottom of the current focused + element are preferably to move focus to, even if it is not the shortest distance. -<p>This test ensures the correctness of the "Fully aligned" precedence logic implemented by Spatial Navigation algorithm in an vertical direction: targets whose middle falls between the top and bottom of the current focused element are preferably to move focus to, even if it is not the shortest distance.</p> + * Pre-conditions: + 1) DRT support for SNav enable/disable. -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "4"], - ["Down", "6"], - ["Down", "7"], - ["Down", "end"], - ["Up", "8"], - ["Up", "6"], - ]; + * Navigation steps: + 1) Loads this page, focus goes to "start" automatically. + 2) Focus moves preferably to elements right up or above the + current focused element, even when there are some other closer + but not vertically aligned elements in the same direction. + --> + <head> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + var resultMap = [ + ["Down", "4"], + ["Down", "6"], + ["Down", "7"], + ["Down", "end"], + ["Up", "8"], + ["Up", "6"], + ["DONE", "DONE"] + ]; + + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } + + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + </script> + </head> + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <div style="margin-left: 40px; text-align: left;"> + <div style="margin-left: 40px;"> + <a id="start" href="a">test<br></a> + </div> + <a id="2" href="a">test</a> <a id="3" href="a">test</a><br> + <div style="margin-left: 40px;"> + <a id="4" href="a">test<br></a> + </div> + <div style="margin-left: 80px;"> + <a id="5" href="a">test<br></a> + </div> + <div style="margin-left: 40px;"> + <a id="6" href="a">test<br></a> + </div> + <a id="7" href="a">test<br></a> + <br><br><br><br> + <div style="margin-left: 40px;"> + <a id="8" href="a">test<br></a> + </div> + <a id="end" href="a">test<br></a> + </div> + <div id="console"></div> + </body> +</html> +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element-expected.txt new file mode 100644 index 0000000..40bbddea --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element-expected.txt
@@ -0,0 +1,11 @@ +This is link_1. + + +This is hidden link. +This is link_2. + +PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "end" +This test is to test that focusable elements with display:none do not grab the focus.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element.html index 7de1065..baf820dcf 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-focusable-element.html
@@ -1,16 +1,45 @@ -<p>This is <a id="start" href="a">link_1</a>.</p> -<br>This is <a id="1" style="display:none;" href="a">you should not see me</a> hidden link.<br> -<p>This is <a id="end" href="a">link_2</a>.</p> +<html> + <head> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "end"], - ]; + var resultMap = [ + ["Down", "end"], + ["DONE", "DONE"] + ]; - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } + + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + + </script> + </head> + + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <p>This is <a id="start" href="a">link_1</a>.</p> + <br>This is <a id="1" style="display:none;" href="a">you should not see me</a> hidden link.<br> + <p>This is <a id="end" href="a">link_2</a>.</p> + <div id="console"></div> + <p>This test is to test that focusable elements with display:none do not grab the focus.</p> + </body> +</html>
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt new file mode 100644 index 0000000..e7a08aca --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt
@@ -0,0 +1,11 @@ + + + +PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "start" +This test tests that areas of an imagemap without an href are not focusable, thus can not be reached with spatial navigation.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable.html index 4cbde2d4..187e7aa 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-not-focusable.html
@@ -1,28 +1,57 @@ -<map name="map" title="map" id="firstmap"> - <area shape="rect" coords="20,20,70,70" href="#" id="1"> - <area shape="rect" coords="20,130,70,180" id="2"> -</map> +<html> + <head> -<a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> -<div> - <img src="resources/green.png" width=200px height=200px usemap="#map"><a id="6" href="a"><img src="resources/green.png" width=50px height=50px></a> -</div> -<a id="3" href="a"><img src="resources/green.png" width=50px height=50px></a> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> -<p>This test tests that areas of an imagemap without an href are not focusable, thus can not be reached with spatial navigation.</p> + var resultMap = [ + ["Down", "1"], + ["Down", "3"], + ["Up", "1"], + ["Up", "start"], + ["DONE", "DONE"] + ]; -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "1"], - ["Down", "3"], - ["Up", "1"], - ["Up", "start"], - ]; + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + + </script> + </head> + + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <map name="map" title="map" id="firstmap"> + <area shape="rect" coords="20,20,70,70" href="#" id="1"> + <area shape="rect" coords="20,130,70,180" id="2"> + </map> + + <a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div> + <img src="resources/green.png" width=200px height=200px usemap="#map"><a id="6" href="a"><img src="resources/green.png" width=50px height=50px></a> + </div> + <a id="3" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div id="console"></div> + <div>This test tests that areas of an imagemap without an href are not focusable, thus can not be reached with spatial navigation.</div> + </body> +</html> +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt new file mode 100644 index 0000000..bd9c9022 --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt
@@ -0,0 +1,9 @@ + + + +PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "start" +This test tests that areas of an imagemap without an image using it, are not focusable, thus can not be reached with spatial navigation.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image.html index b5f4246..13e9b737 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-area-without-image.html
@@ -1,26 +1,55 @@ -<map name="map" title="map" id="firstmap"> - <area shape="rect" coords="20,20,70,70" href="#" id="1"> - <area shape="rect" coords="20,130,70,180" href="#" id="2"> -</map> +<html> + <head> -<a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> -<div> - <img src="resources/green.png" width=200px height=200px usemap="#othermap"><a id="6" href="a"><img src="resources/green.png" width=50px height=50px></a> -</div> -<a id="3" href="a"><img src="resources/green.png" width=50px height=50px></a> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> -<p>This test tests that areas of an imagemap without an image using it, are not focusable, thus can not be reached with spatial navigation.</p> + var resultMap = [ + ["Down", "3"], + ["Up", "start"], + ["DONE", "DONE"] + ]; -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "3"], - ["Up", "start"], - ]; + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + + </script> + </head> + + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <map name="map" title="map" id="firstmap"> + <area shape="rect" coords="20,20,70,70" href="#" id="1"> + <area shape="rect" coords="20,130,70,180" href="#" id="2"> + </map> + + <a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div> + <img src="resources/green.png" width=200px height=200px usemap="#othermap"><a id="6" href="a"><img src="resources/green.png" width=50px height=50px></a> + </div> + <a id="3" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div id="console"></div> + <div>This test tests that areas of an imagemap without an image using it, are not focusable, thus can not be reached with spatial navigation.</div> + </body> +</html> +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt new file mode 100644 index 0000000..7d7984ba --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt
@@ -0,0 +1,19 @@ + + + +PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "2" +PASS gFocusedDocument.activeElement.getAttribute("id") is "5" +PASS gFocusedDocument.activeElement.getAttribute("id") is "4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "2" +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "2" +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "start" +This test tests that areas of an imagemap can be reached with spatial navigation even if they are overlapped.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas.html index 22aab431f..0641d6e 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-overlapped-areas.html
@@ -1,38 +1,67 @@ -<map name="map" title="map" id="firstmap"> - <area shape="circle" coords="45,45,25" href="#" id="1"> - <area shape="rect" coords="45,60,95,110" href="#" id="2"> - <area shape="poly" coords="80,20,130,20,130,180,30,180,30,130,80,130" href="#" id="3"> - <area shape="default" href="#" id="4"> -</map> +<html> + <head> -<a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> -<div> - <img src="resources/green.png" width=200px height=200px usemap="#map"> -</div> -<a id="5" href="a"><img src="resources/green.png" width=50px height=50px></a> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> -<p>This test tests that areas of an imagemap can be reached with spatial navigation even if they are overlapped.</p> + var resultMap = [ + ["Down", "4"], + ["Down", "1"], + ["Down", "2"], + ["Down", "5"], + ["Up", "4"], + ["Up", "3"], + ["Up", "2"], + ["Left", "1"], + ["Right", "3"], + ["Left", "2"], + ["Up", "1"], + ["Up", "start"], + ["DONE", "DONE"] + ]; -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "4"], - ["Down", "1"], - ["Down", "2"], - ["Down", "5"], - ["Up", "4"], - ["Up", "3"], - ["Up", "2"], - ["Left", "1"], - ["Right", "3"], - ["Left", "2"], - ["Up", "1"], - ["Up", "start"], - ]; + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + + </script> + </head> + + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <map name="map" title="map" id="firstmap"> + <area shape="circle" coords="45,45,25" href="#" id="1"> + <area shape="rect" coords="45,60,95,110" href="#" id="2"> + <area shape="poly" coords="80,20,130,20,130,180,30,180,30,130,80,130" href="#" id="3"> + <area shape="default" href="#" id="4"> + </map> + + <a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div> + <img src="resources/green.png" width=200px height=200px usemap="#map"> + </div> + <a id="5" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div id="console"></div> + <div>This test tests that areas of an imagemap can be reached with spatial navigation even if they are overlapped.</div> + </body> +</html> +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple-expected.txt new file mode 100644 index 0000000..83ba4df --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple-expected.txt
@@ -0,0 +1,17 @@ + + + +PASS successfullyParsed is true + +TEST COMPLETE +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "5" +PASS gFocusedDocument.activeElement.getAttribute("id") is "3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "6" +PASS gFocusedDocument.activeElement.getAttribute("id") is "4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "2" +PASS gFocusedDocument.activeElement.getAttribute("id") is "1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "start" +This test tests that areas of an imagemap can be reached with spatial navigation.
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple.html index 5691c28..b9ce67d 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-imagemap-simple.html
@@ -1,36 +1,65 @@ -<map name="map" title="map" id="firstmap"> - <area shape="rect" coords="20,20,70,70" href="#" id="1"> - <area shape="rect" coords="130,20,180,70" href="#" id="2"> - <area shape="rect" coords="20,130,70,180" href="#" id="3"> - <area shape="rect" coords="130,130,180,180" href="#" id="4"> -</map> +<html> + <head> -<a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> -<div> - <img src="resources/green.png" width=200px height=200px usemap="#map"><a id="6" href="a"><img src="resources/green.png" width=50px height=50px></a> -</div> -<a id="5" href="a"><img src="resources/green.png" width=50px height=50px></a> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> -<p>This test tests that areas of an imagemap can be reached with spatial navigation.</p> + var resultMap = [ + ["Down", "1"], + ["Down", "3"], + ["Down", "5"], + ["Up", "3"], + ["Right", "4"], + ["Right", "6"], + ["Left", "4"], + ["Up", "2"], + ["Left", "1"], + ["Up", "start"], + ["DONE", "DONE"] + ]; -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Down", "1"], - ["Down", "3"], - ["Down", "5"], - ["Up", "3"], - ["Right", "4"], - ["Right", "6"], - ["Left", "4"], - ["Up", "2"], - ["Left", "1"], - ["Up", "start"], - ]; + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + testRunner.waitUntilDone(); + } - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + if (window.testRunner) + testRunner.notifyDone(); + } + + window.onload = runTest; + + </script> + </head> + + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + <map name="map" title="map" id="firstmap"> + <area shape="rect" coords="20,20,70,70" href="#" id="1"> + <area shape="rect" coords="130,20,180,70" href="#" id="2"> + <area shape="rect" coords="20,130,70,180" href="#" id="3"> + <area shape="rect" coords="130,130,180,180" href="#" id="4"> + </map> + + <a id="start" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div> + <img src="resources/green.png" width=200px height=200px usemap="#map"><a id="6" href="a"><img src="resources/green.png" width=50px height=50px></a> + </div> + <a id="5" href="a"><img src="resources/green.png" width=50px height=50px></a> + <div id="console"></div> + <div>This test tests that areas of an imagemap can be reached with spatial navigation.</div> + </body> +</html> +
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt new file mode 100644 index 0000000..4910987 --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements-expected.txt
@@ -0,0 +1,28 @@ +This is a link start of Test. + +This is a link i2. + +This is a link i4. + +This is a link i6. + +This is a link i8. + +This is a link End of Test. + +PASS gFocusedDocument.activeElement.getAttribute("id") is "start" +PASS gFocusedDocument.activeElement.getAttribute("id") is "v1" +PASS gFocusedDocument.activeElement.getAttribute("id") is "i2" +PASS gFocusedDocument.activeElement.getAttribute("id") is "v3" +PASS gFocusedDocument.activeElement.getAttribute("id") is "i4" +PASS gFocusedDocument.activeElement.getAttribute("id") is "v5" +PASS gFocusedDocument.activeElement.getAttribute("id") is "i6" +PASS gFocusedDocument.activeElement.getAttribute("id") is "a7" +PASS gFocusedDocument.activeElement.getAttribute("id") is "i8" +PASS gFocusedDocument.activeElement.getAttribute("id") is "end" +PASS gFocusedDocument.activeElement.getAttribute("id") is "i8" +PASS gFocusedDocument.activeElement.getAttribute("id") is "end" +PASS successfullyParsed is true + +TEST COMPLETE +This tests that a media elements ie: <Audio> or <video>, without tabindex are able to be reached through keyboard access
diff --git a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements.html b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements.html index fb42a2d..84019d6 100644 --- a/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements.html +++ b/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-media-elements.html
@@ -1,39 +1,72 @@ -<p>This is a link <a id="start" href="a">start of Test</a>.</p> -<video id="v1" controls tabindex="0" src="../../media/content/test.mp4"></video> -<p>This is a link <a id="i2" href="a">i2</a>.</p> -<video id="v3" controls src="../../media/content/test.mp4"></video> -<p>This is a link <a id="i4" href="a">i4</a>.</p> -<video id="v5" tabindex="0" src="../../media/content/test.mp4"></video> -<p>This is a link <a id="i6" href="a">i6</a>.</p> -<audio id="a7" controls src="../../media/content/test.wav"></audio> -<p>This is a link <a id="i8" href="a">i8</a>.</p> -<!-- 'a9' is not focussable: no controls attribute as well no tab index. -Key down from 'i8' should go to 'end'. --> -<audio id="a9" src="../../media/content/test.mp4"></audio> -<p>This is a link <a id="end" href="a">End of Test</a>.</p> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> +<html> + <head> + <script src="../../resources/js-test.js"></script> + <script src="resources/spatial-navigation-utils.js"></script> + <script type="application/javascript"> -<p>This tests that a media elements ie: <code><Audio></code> or <code><video></code>, without tabindex are able to be reached through keyboard access</p> + var resultMap = [ + ["Up", "start"], + ["Down", "v1"], + ["Down", "i2"], + ["Down", "v3"], + ["Down", "i4"], + ["Down", "v5"], + ["Down", "i6"], + ["Down", "a7"], + ["Down", "i8"], + ["Down", "end"], + ["Up", "i8"], + ["Down", "end"], + ["DONE", "DONE"] + ]; -<script src="../../resources/testharness.js"></script> -<script src="../../resources/testharnessreport.js"></script> -<script src="resources/snav-testharness.js"></script> -<script> - var resultMap = [ - ["Up", "start"], - ["Down", "v1"], - ["Down", "i2"], - ["Down", "v3"], - ["Down", "i4"], - ["Down", "v5"], - ["Down", "i6"], - ["Down", "a7"], - ["Down", "i8"], - ["Down", "end"], - ["Up", "i8"], - ["Down", "end"], - ]; + if (window.testRunner) { + testRunner.dumpAsText(); + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); + testRunner.overridePreference("WebKitSpatialNavigationEnabled", 1); + } - // Start at a known place. - document.getElementById("start").focus(); - snav.assertFocusMoves(resultMap); -</script> + function runTest() + { + // starting the test itself: get to a known place. + document.getElementById("start").focus(); + + initTest(resultMap, testCompleted); + } + + function testCompleted() + { + finishJSTest(); + } + + window.onload = runTest; + jsTestIsAsync = true; + </script> + </head> + + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> + + <p>This is a link <a id="start" href="a">start of Test</a>.</p> + <video id="v1" controls tabindex="0" src="../../media/content/test.mp4"></video> + + <p>This is a link <a id="i2" href="a">i2</a>.</p> + <video id="v3" controls src="../../media/content/test.mp4"></video> + + <p>This is a link <a id="i4" href="a">i4</a>.</p> + <video id="v5" tabindex="0" src="../../media/content/test.mp4"></video> + + <p>This is a link <a id="i6" href="a">i6</a>.</p> + <audio id="a7" controls src="../../media/content/test.wav"></audio> + + <p>This is a link <a id="i8" href="a">i8</a>.</p> + <!-- 'a9' is not focussable: no controls attribute as well no tab index. + Key down from 'i8' should go to 'end'. --> + <audio id="a9" src="../../media/content/test.mp4"></audio> + + <p>This is a link <a id="end" href="a">End of Test</a>.</p> + + <div id="console"></div> + <p>This tests that a media elements ie: <code><Audio></code> or <code><video></code>, without tabindex are able to be reached through keyboard access</p> + </body> +</html>
diff --git a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt b/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt index 32236562..3cba9f6 100644 --- a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt +++ b/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
@@ -1,5 +1,5 @@ This is a testharness.js-based test. -Found 214 tests; 141 PASS, 73 FAIL, 0 TIMEOUT, 0 NOTRUN. +Found 214 tests; 212 PASS, 2 FAIL, 0 TIMEOUT, 0 NOTRUN. PASS Simplest possible test ("<div>abc") PASS Leading whitespace removed ("<div> abc") PASS Trailing whitespace removed ("<div>abc ") @@ -14,7 +14,7 @@ PASS \n preserved ("<pre>abc\ndef") PASS \r converted to newline ("<pre>abc\rdef") PASS \t preserved ("<pre>abc\tdef") -FAIL Two <pre> siblings ("<div><pre>abc</pre><pre>def</pre>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS Two <pre> siblings ("<div><pre>abc</pre><pre>def</pre>") PASS Leading whitespace preserved ("<div style='white-space:pre'> abc") PASS Trailing whitespace preserved ("<div style='white-space:pre'>abc ") PASS Internal whitespace preserved ("<div style='white-space:pre'>abc def") @@ -38,7 +38,7 @@ PASS Whitespace collapses across element boundaries ("<div><span>abc </span><span style='white-space:pre'></span> def") PASS Soft line breaks ignored ("<div style='width:0'>abc def") PASS Whitespace text node preserved ("<div style='width:0'><span>abc</span> <span>def</span>") -FAIL ::first-line styles applied ("<div class='first-line-uppercase' style='width:0'>abc def") assert_equals: expected "ABC def" but got "abc def" +PASS ::first-line styles applied ("<div class='first-line-uppercase' style='width:0'>abc def") PASS ::first-letter styles applied ("<div class='first-letter-uppercase' style='width:0'>abc def") PASS ::first-letter float ignored ("<div class='first-letter-float' style='width:0'>abc def") PASS preserved ("<div> ") @@ -47,7 +47,7 @@ PASS No removal of leading/trailing whitespace in display:none container ("<div style='display:none'> abc def ") PASS display:none child not rendered ("<div>123<span style='display:none'>abc") PASS display:none container with non-display-none target child ("<div style='display:none'><span id='target'>abc") -FAIL non-display-none child of svg ("<div id='target'>abc") assert_equals: expected "" but got "abc" +PASS non-display-none child of svg ("<div id='target'>abc") PASS display:none child of svg ("<div style='display:none' id='target'>abc") PASS child of display:none child of svg ("<div style='display:none'><div id='target'>abc") PASS display:contents container ("<div style='display:contents'>abc") @@ -61,10 +61,10 @@ PASS visibility:collapse row-group ("<table><tbody style='visibility:collapse'><tr><td>abc") PASS visibility:collapse row ("<table><tr style='visibility:collapse'><td>abc") PASS visibility:collapse cell ("<table><tr><td style='visibility:collapse'>abc") -FAIL visibility:collapse row-group with visible cell ("<table><tbody style='visibility:collapse'><tr><td style='visibility:visible'>abc") assert_equals: expected "abc" but got "abc\n" -FAIL visibility:collapse row with visible cell ("<table><tr style='visibility:collapse'><td style='visibility:visible'>abc") assert_equals: expected "abc" but got "abc\n" -FAIL visibility:collapse honored on flex item ("<div style='display:flex'><span style='visibility:collapse'>1</span><span>2</span></div>") assert_equals: expected "2" but got "2\n" -FAIL visibility:collapse honored on grid item ("<div style='display:grid'><span style='visibility:collapse'>1</span><span>2</span></div>") assert_equals: expected "2" but got "2\n" +PASS visibility:collapse row-group with visible cell ("<table><tbody style='visibility:collapse'><tr><td style='visibility:visible'>abc") +PASS visibility:collapse row with visible cell ("<table><tr style='visibility:collapse'><td style='visibility:visible'>abc") +PASS visibility:collapse honored on flex item ("<div style='display:flex'><span style='visibility:collapse'>1</span><span>2</span></div>") +PASS visibility:collapse honored on grid item ("<div style='display:grid'><span style='visibility:collapse'>1</span><span>2</span></div>") PASS opacity:0 container ("<div style='opacity:0'>abc") PASS Whitespace compression in opacity:0 container ("<div style='opacity:0'>abc def") PASS Remove leading/trailing whitespace in opacity:0 container ("<div style='opacity:0'> abc def ") @@ -73,44 +73,44 @@ PASS Generated content on child not included ("<div><div class='before'>") PASS <button> contents preserved ("<button>abc") PASS <fieldset> contents preserved ("<fieldset>abc") -FAIL <fieldset> <legend> contents preserved ("<fieldset><legend>abc") assert_equals: expected "abc" but got "abc\n" +PASS <fieldset> <legend> contents preserved ("<fieldset><legend>abc") PASS <input> contents ignored ("<input type='text' value='abc'>") PASS <textarea> contents ignored ("<textarea>abc") PASS <iframe> contents ignored ("<iframe>abc") PASS <iframe> contents ignored ("<iframe><div id='target'>abc") PASS <iframe> subdocument ignored ("<iframe src='data:text/html,abc'>") FAIL <audio> contents ignored ("<audio style='display:block'>abc") assert_equals: expected "" but got "abc" -FAIL <audio> contents ignored ("<audio style='display:block'><source id='target' class='poke' style='display:block'>") assert_equals: expected "" but got "abc" -PASS <audio> contents ok if display:none ("<audio style='display:block'><source id='target' class='poke' style='display:none'>") +PASS <audio> contents ok for element not being rendered ("<audio style='display:block'><source id='target' class='poke' style='display:block'>") +PASS <audio> contents ok for element not being rendered ("<audio style='display:block'><source id='target' class='poke' style='display:none'>") PASS <video> contents ignored ("<video>abc") -FAIL <video> contents ignored ("<video style='display:block'><source id='target' class='poke' style='display:block'>") assert_equals: expected "" but got "abc" -PASS <video> contents ok if display:none ("<video style='display:block'><source id='target' class='poke' style='display:none'>") +PASS <video> contents ok for element not being rendered ("<video style='display:block'><source id='target' class='poke' style='display:block'>") +PASS <video> contents ok for element not being rendered ("<video style='display:block'><source id='target' class='poke' style='display:none'>") PASS <canvas> contents ignored ("<canvas>abc") -FAIL <canvas><div id='target'> contents ignored ("<canvas><div id='target'>abc") assert_equals: expected "" but got "abc" +PASS <canvas><div id='target'> contents ok for element not being rendered ("<canvas><div id='target'>abc") PASS <img> alt text ignored ("<img alt='abc'>") PASS <img> contents ignored ("<img src='about:blank' class='poke'>") -FAIL <select size='1'> contents of options preserved ("<select size='1'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" -FAIL <select size='2'> contents of options preserved ("<select size='2'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" +PASS <select size='1'> contents of options preserved ("<select size='1'><option>abc</option><option>def") +PASS <select size='2'> contents of options preserved ("<select size='2'><option>abc</option><option>def") PASS <select size='1'> contents of target option preserved ("<select size='1'><option id='target'>abc</option><option>def") PASS <select size='2'> contents of target option preserved ("<select size='2'><option id='target'>abc</option><option>def") PASS empty <select> ("<div>a<select></select>bc") -FAIL empty <optgroup> in <select> ("<div>a<select><optgroup></select>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL empty <option> in <select> ("<div>a<select><option></select>bc") assert_equals: expected "a\nbc" but got "abc" +PASS empty <optgroup> in <select> ("<div>a<select><optgroup></select>bc") +PASS empty <option> in <select> ("<div>a<select><option></select>bc") PASS <select> containing text node child ("<select class='poke'></select>") PASS <optgroup> containing <optgroup> ("<select><optgroup class='poke-optgroup'></select>") -FAIL <optgroup> containing <option> ("<select><optgroup><option>abc</select>") assert_equals: expected "abc" but got "" -FAIL <div> in <option> ("<select><option class='poke-div'>123</select>") assert_equals: expected "123\nabc" but got "" -FAIL empty <optgroup> in <div> ("<div>a<optgroup></optgroup>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL <optgroup> in <div> ("<div>a<optgroup>123</optgroup>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL empty <option> in <div> ("<div>a<option></option>bc") assert_equals: expected "a\nbc" but got "abc" -FAIL <option> in <div> ("<div>a<option>123</option>bc") assert_equals: expected "a\n123\nbc" but got "abc" +PASS <optgroup> containing <option> ("<select><optgroup><option>abc</select>") +FAIL <div> in <option> ("<select><option class='poke-div'>123</select>") assert_equals: expected "123\nabc" but got "123abc" +PASS empty <optgroup> in <div> ("<div>a<optgroup></optgroup>bc") +PASS <optgroup> in <div> ("<div>a<optgroup>123</optgroup>bc") +PASS empty <option> in <div> ("<div>a<option></option>bc") +PASS <option> in <div> ("<div>a<option>123</option>bc") PASS <button> contents preserved ("<div><button>abc") -FAIL <fieldset> contents preserved ("<div><fieldset>abc") assert_equals: expected "abc" but got "abc\n" -FAIL <fieldset> <legend> contents preserved ("<div><fieldset><legend>abc") assert_equals: expected "abc" but got "abc\n" +PASS <fieldset> contents preserved ("<div><fieldset>abc") +PASS <fieldset> <legend> contents preserved ("<div><fieldset><legend>abc") PASS <input> contents ignored ("<div><input type='text' value='abc'>") PASS <textarea> contents ignored ("<div><textarea>abc") -FAIL <select size='1'> contents of options preserved ("<div><select size='1'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" -FAIL <select size='2'> contents of options preserved ("<div><select size='2'><option>abc</option><option>def") assert_equals: expected "abc\ndef" but got "" +PASS <select size='1'> contents of options preserved ("<div><select size='1'><option>abc</option><option>def") +PASS <select size='2'> contents of options preserved ("<div><select size='2'><option>abc</option><option>def") PASS <iframe> contents ignored ("<div><iframe>abc") PASS <iframe> subdocument ignored ("<div><iframe src='data:text/html,abc'>") PASS <audio> contents ignored ("<div><audio>abc") @@ -121,22 +121,22 @@ PASS Newline at display:block boundary ("<div>123<span style='display:block'>abc</span>def") PASS Empty block induces single line break ("<div>abc<div></div>def") PASS Consecutive empty blocks ignored ("<div>abc<div></div><div></div>def") -FAIL No blank lines around <p> alone ("<div><p>abc") assert_equals: expected "abc" but got "abc\n\n" -FAIL No blank lines around <p> followed by only collapsible whitespace ("<div><p>abc</p> ") assert_equals: expected "abc" but got "abc\n\n" -FAIL No blank lines around <p> preceded by only collapsible whitespace ("<div> <p>abc</p>") assert_equals: expected "abc" but got "abc\n\n" -FAIL Blank line between consecutive <p>s ("<div><p>abc<p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Blank line between consecutive <p>s separated only by collapsible whitespace ("<div><p>abc</p> <p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Blank line between consecutive <p>s separated only by empty block ("<div><p>abc</p><div></div><p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Blank lines between <p>s separated by non-empty block ("<div><p>abc</p><div>123</div><p>def") assert_equals: expected "abc\n\n123\n\ndef" but got "abc\n\n123\ndef\n\n" -FAIL Blank lines around a <p> in its own block ("<div>abc<div><p>123</p></div>def") assert_equals: expected "abc\n\n123\n\ndef" but got "abc\n123\n\ndef" -FAIL Blank line before <p> ("<div>abc<p>def") assert_equals: expected "abc\n\ndef" but got "abc\ndef\n\n" +PASS No blank lines around <p> alone ("<div><p>abc") +PASS No blank lines around <p> followed by only collapsible whitespace ("<div><p>abc</p> ") +PASS No blank lines around <p> preceded by only collapsible whitespace ("<div> <p>abc</p>") +PASS Blank line between consecutive <p>s ("<div><p>abc<p>def") +PASS Blank line between consecutive <p>s separated only by collapsible whitespace ("<div><p>abc</p> <p>def") +PASS Blank line between consecutive <p>s separated only by empty block ("<div><p>abc</p><div></div><p>def") +PASS Blank lines between <p>s separated by non-empty block ("<div><p>abc</p><div>123</div><p>def") +PASS Blank lines around a <p> in its own block ("<div>abc<div><p>123</p></div>def") +PASS Blank line before <p> ("<div>abc<p>def") PASS Blank line after <p> ("<div><p>abc</p>def") -FAIL One blank line between <p>s, ignoring empty <p>s ("<div><p>abc<p></p><p></p><p>def") assert_equals: expected "abc\n\ndef" but got "abc\n\ndef\n\n" -FAIL Invisible <p> doesn't induce extra line breaks ("<div style='visibility:hidden'><p><span style='visibility:visible'>abc</span></p>\n<div style='visibility:visible'>def</div>") assert_equals: expected "abc\ndef" but got "abc\n\ndef\n" -FAIL No blank lines around <div> with margin ("<div>abc<div style='margin:2em'>def") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS One blank line between <p>s, ignoring empty <p>s ("<div><p>abc<p></p><p></p><p>def") +PASS Invisible <p> doesn't induce extra line breaks ("<div style='visibility:hidden'><p><span style='visibility:visible'>abc</span></p>\n<div style='visibility:visible'>def</div>") +PASS No blank lines around <div> with margin ("<div>abc<div style='margin:2em'>def") PASS No newlines at display:inline-block boundary ("<div>123<span style='display:inline-block'>abc</span>def") PASS Leading/trailing space removal at display:inline-block boundary ("<div>123<span style='display:inline-block'> abc </span>def") -FAIL Blank lines around <p> even without margin ("<div>123<p style='margin:0px'>abc</p>def") assert_equals: expected "123\n\nabc\n\ndef" but got "123\nabc\n\ndef" +PASS Blank lines around <p> even without margin ("<div>123<p style='margin:0px'>abc</p>def") PASS No blank lines around <h1> ("<div>123<h1>abc</h1>def") PASS No blank lines around <h2> ("<div>123<h2>abc</h2>def") PASS No blank lines around <h3> ("<div>123<h3>abc</h3>def") @@ -154,27 +154,27 @@ PASS <code> gets no special treatment ("<div>123<code>abc</code>def") PASS soft hyphen preserved ("<div>abc­def") PASS soft hyphen preserved ("<div style='width:0'>abc­def") -FAIL Ignoring non-rendered table whitespace ("<div><table style='white-space:pre'> <td>abc</td> </table>") assert_equals: expected "abc" but got "abc\n" -FAIL Tab-separated table cells ("<div><table><tr><td>abc<td>def</table>") assert_equals: expected "abc\tdef" but got "abc\tdef\n" -FAIL Tab-separated table cells including empty cells ("<div><table><tr><td>abc<td><td>def</table>") assert_equals: expected "abc\t\tdef" but got "abc\t\tdef\n" -FAIL Tab-separated table cells including trailing empty cells ("<div><table><tr><td>abc<td><td></table>") assert_equals: expected "abc\t\t" but got "abc\t\t\n" -FAIL Newline-separated table rows ("<div><table><tr><td>abc<tr><td>def</table>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS Ignoring non-rendered table whitespace ("<div><table style='white-space:pre'> <td>abc</td> </table>") +PASS Tab-separated table cells ("<div><table><tr><td>abc<td>def</table>") +PASS Tab-separated table cells including empty cells ("<div><table><tr><td>abc<td><td>def</table>") +PASS Tab-separated table cells including trailing empty cells ("<div><table><tr><td>abc<td><td></table>") +PASS Newline-separated table rows ("<div><table><tr><td>abc<tr><td>def</table>") PASS Newlines around table ("<div>abc<table><td>def</table>ghi") -FAIL Tab-separated table cells in a border-collapse table ("<div><table style='border-collapse:collapse'><tr><td>abc<td>def</table>") assert_equals: expected "abc\tdef" but got "abc\tdef\n" -FAIL tfoot not reordered ("<div><table><tfoot>x</tfoot><tbody>y</tbody></table>") assert_equals: expected "xy" but got "xy\n" -FAIL ("<table><tfoot><tr><td>footer</tfoot><thead><tr><td style='visibility:collapse'>thead</thead><tbody><tr><td>tbody</tbody></table>") assert_equals: expected "footer\n\ntbody" but got "footer\ntbody\n" -FAIL Newline between cells and caption ("<div><table><tr><td>abc<caption>def</caption></table>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" -FAIL Tab-separated table cells ("<div><div class='table'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") assert_equals: expected "abc\tdef" but got "abc\tdef\n" -FAIL Newline-separated table rows ("<div><div class='table'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") assert_equals: expected "abc\ndef" but got "abc\ndef\n" +PASS Tab-separated table cells in a border-collapse table ("<div><table style='border-collapse:collapse'><tr><td>abc<td>def</table>") +PASS tfoot not reordered ("<div><table><tfoot>x</tfoot><tbody>y</tbody></table>") +PASS ("<table><tfoot><tr><td>footer</tfoot><thead><tr><td style='visibility:collapse'>thead</thead><tbody><tr><td>tbody</tbody></table>") +PASS Newline between cells and caption ("<div><table><tr><td>abc<caption>def</caption></table>") +PASS Tab-separated table cells ("<div><div class='table'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") +PASS Newline-separated table rows ("<div><div class='table'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") PASS Newlines around table ("<div>abc<div class='table'><span class='cell'>def</span></div>ghi") -FAIL Tab-separated table cells ("<div><div class='itable'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") assert_equals: expected "abc\tdef" but got "abc\tdef " -FAIL Newline-separated table rows ("<div><div class='itable'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") assert_equals: expected "abc\ndef" but got "abc\tdef " -FAIL No newlines around inline-table ("<div>abc<div class='itable'><span class='cell'>def</span></div>ghi") assert_equals: expected "abcdefghi" but got "abc def ghi" -FAIL Single newline in two-row inline-table ("<div>abc<div class='itable'><span class='row'><span class='cell'>def</span></span>\n<span class='row'><span class='cell'>123</span></span></div>ghi") assert_equals: expected "abcdef\n123ghi" but got "abc def\t123 ghi" -FAIL <ol> list items get no special treatment ("<div><ol><li>abc") assert_equals: expected "abc" but got "abc\n" -FAIL <ul> list items get no special treatment ("<div><ul><li>abc") assert_equals: expected "abc" but got "abc\n" -FAIL display:block <script> is rendered ("<div><script style='display:block'>abc") assert_equals: expected "abc" but got "abc\n" -FAIL display:block <style> is rendered ("<div><style style='display:block'>abc") assert_equals: expected "abc" but got "abc\n" +PASS Tab-separated table cells ("<div><div class='itable'><span class='cell'>abc</span>\n<span class='cell'>def</span></div>") +PASS Newline-separated table rows ("<div><div class='itable'><span class='row'><span class='cell'>abc</span></span>\n<span class='row'><span class='cell'>def</span></span></div>") +PASS No newlines around inline-table ("<div>abc<div class='itable'><span class='cell'>def</span></div>ghi") +PASS Single newline in two-row inline-table ("<div>abc<div class='itable'><span class='row'><span class='cell'>def</span></span>\n<span class='row'><span class='cell'>123</span></span></div>ghi") +PASS <ol> list items get no special treatment ("<div><ol><li>abc") +PASS <ul> list items get no special treatment ("<div><ul><li>abc") +PASS display:block <script> is rendered ("<div><script style='display:block'>abc") +PASS display:block <style> is rendered ("<div><style style='display:block'>abc") PASS display:block <noscript> is not rendered (it's not parsed!) ("<div><noscript style='display:block'>abc") PASS display:block <template> contents are not rendered (the contents are in a different document) ("<div><template style='display:block'>abc") PASS <br> induces line break ("<div>abc<br>def") @@ -183,22 +183,22 @@ PASS <hr> induces line break ("<div>abc<hr>def") PASS <hr><hr> induces just one line break ("<div>abc<hr><hr>def") PASS <hr><hr><hr> induces just one line break ("<div>abc<hr><hr><hr>def") -FAIL <hr> content rendered ("<div><hr class='poke'>") assert_equals: expected "abc" but got "abc\n" +PASS <hr> content rendered ("<div><hr class='poke'>") PASS comment ignored ("<div>abc<!--comment-->def") -FAIL text-transform is applied ("<div><div style='text-transform:uppercase'>abc") assert_equals: expected "ABC" but got "ABC\n" -FAIL text-transform handles es-zet ("<div><div style='text-transform:uppercase'>Maß") assert_equals: expected "MASS" but got "MAS\n" -FAIL text-transform handles Turkish casing ("<div><div lang='tr' style='text-transform:uppercase'>i ı") assert_equals: expected "İ I" but got "İ I\n" +PASS text-transform is applied ("<div><div style='text-transform:uppercase'>abc") +PASS text-transform handles es-zet ("<div><div style='text-transform:uppercase'>Maß") +PASS text-transform handles Turkish casing ("<div><div lang='tr' style='text-transform:uppercase'>i ı") PASS block-in-inline doesn't add unnecessary newlines ("<div>abc<span>123<div>456</div>789</span>def") -FAIL floats induce a block boundary ("<div>abc<div style='float:left'>123</div>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" -FAIL floats induce a block boundary ("<div>abc<span style='float:left'>123</span>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" -FAIL position:absolute induces a block boundary ("<div>abc<div style='position:absolute'>123</div>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" -FAIL position:absolute induces a block boundary ("<div>abc<span style='position:absolute'>123</span>def") assert_equals: expected "abc\n123\ndef" but got "abc123def" +PASS floats induce a block boundary ("<div>abc<div style='float:left'>123</div>def") +PASS floats induce a block boundary ("<div>abc<span style='float:left'>123</span>def") +PASS position:absolute induces a block boundary ("<div>abc<div style='position:absolute'>123</div>def") +PASS position:absolute induces a block boundary ("<div>abc<span style='position:absolute'>123</span>def") PASS position:relative has no effect ("<div>abc<div style='position:relative'>123</div>def") PASS position:relative has no effect ("<div>abc<span style='position:relative'>123</span>def") PASS overflow:hidden ignored ("<div style='overflow:hidden'>abc") -FAIL overflow:hidden ignored even with zero width ("<div style='width:0; overflow:hidden'>abc") assert_equals: expected "abc" but got "" -FAIL overflow:hidden ignored even with zero height ("<div style='height:0; overflow:hidden'>abc") assert_equals: expected "abc" but got "" -FAIL text-overflow:ellipsis ignored ("<div style='width:0; overflow:hidden; text-overflow:ellipsis'>abc") assert_equals: expected "abc" but got "" +PASS overflow:hidden ignored even with zero width ("<div style='width:0; overflow:hidden'>abc") +PASS overflow:hidden ignored even with zero height ("<div style='height:0; overflow:hidden'>abc") +PASS text-overflow:ellipsis ignored ("<div style='width:0; overflow:hidden; text-overflow:ellipsis'>abc") PASS innerText not supported on SVG elements ("<svg>abc") PASS innerText not supported on MathML elements ("<math>abc") PASS <rt> and no <rp> ("<div><ruby>abc<rt>def</rt></ruby>") @@ -210,9 +210,9 @@ PASS <rp> in a <select> ("<div><select class='poke-rp'></select>") PASS Shadow DOM contents ignored ("<div class='shadow'>") PASS Shadow DOM contents ignored ("<div><div class='shadow'>") -FAIL CSS 'order' property ignored ("<div style='display:flex'><div style='order:1'>1</div><div>2</div></div>") assert_equals: expected "1\n2" but got "1\n2\n" -FAIL Flex items blockified ("<div style='display:flex'><span>1</span><span>2</span></div>") assert_equals: expected "1\n2" but got "1\n2\n" -FAIL CSS 'order' property ignored ("<div style='display:grid'><div style='order:1'>1</div><div>2</div></div>") assert_equals: expected "1\n2" but got "1\n2\n" -FAIL Grid items blockified ("<div style='display:grid'><span>1</span><span>2</span></div>") assert_equals: expected "1\n2" but got "1\n2\n" +PASS CSS 'order' property ignored ("<div style='display:flex'><div style='order:1'>1</div><div>2</div></div>") +PASS Flex items blockified ("<div style='display:flex'><span>1</span><span>2</span></div>") +PASS CSS 'order' property ignored ("<div style='display:grid'><div style='order:1'>1</div><div>2</div></div>") +PASS Grid items blockified ("<div style='display:grid'><span>1</span><span>2</span></div>") Harness: the test ran to completion.
diff --git a/third_party/WebKit/LayoutTests/html/dialog/form-method-dialog-expected.txt b/third_party/WebKit/LayoutTests/html/dialog/form-method-dialog-expected.txt index 1ff6a0ee..a61e927 100644 --- a/third_party/WebKit/LayoutTests/html/dialog/form-method-dialog-expected.txt +++ b/third_party/WebKit/LayoutTests/html/dialog/form-method-dialog-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 177: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests form submission with method=dialog On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/html/dialog/modal-dialog-distributed-child-is-not-inert-expected.txt b/third_party/WebKit/LayoutTests/html/dialog/modal-dialog-distributed-child-is-not-inert-expected.txt index c2bb343..b670497 100644 --- a/third_party/WebKit/LayoutTests/html/dialog/modal-dialog-distributed-child-is-not-inert-expected.txt +++ b/third_party/WebKit/LayoutTests/html/dialog/modal-dialog-distributed-child-is-not-inert-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 28: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that nodes transposed into the dialog are not inert. The test passes if you can click the button. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/agents-enable-disable-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/agents-enable-disable-expected.txt index e6469ed..7e94da87 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/agents-enable-disable-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/agents-enable-disable-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that each agent could be enabled/disabled separately. Animation.disable finished successfully
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffect-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffect-crash-expected.txt index 2a3f37d..4a5764d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffect-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-KeyframeEffect-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that animations can be created with KeyframeEffect without crashing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-empty-web-animations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-empty-web-animations-expected.txt index 6c1f66e..8600472 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-empty-web-animations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-empty-web-animations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the empty web animations do not show up in animation timeline. 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-animations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-animations-expected.txt index b69f2a4..2e568ea 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-animations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-animations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the matching performed in AnimationModel of groups composed of animations, which are applied through a variety of selectors. >> restartAnimation('node1', 'expandWidth')
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-expected.txt index e7876492e..56276037 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the matching of groups in AnimationModel. Animation group triggered
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-transitions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-transitions-expected.txt index 42a95d65..3c0b67e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-transitions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-group-matching-transitions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the matching performed in AnimationModel of groups composed of transitions, which are applied through a variety of selectors. >> resetElement('node1'); startTransition('node1')
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-timeline-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-timeline-expected.txt index 2ce9ad5a..cc83e5e2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-timeline-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-timeline-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the display of animations on the animation timeline. >>>> Animation with start delay only
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-transition-setTiming-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-transition-setTiming-crash-expected.txt index 4900486..001175f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-transition-setTiming-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-transition-setTiming-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test passes if it does not crash.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-web-anim-negative-start-time-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-web-anim-negative-start-time-expected.txt index 0b5a3d9..5814b788 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-web-anim-negative-start-time-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-web-anim-negative-start-time-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that animation with negative start delay gets added. true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-iframe-manifests-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-iframe-manifests-expected.txt index e745f062..01faf16 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-iframe-manifests-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-iframe-manifests-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that application cache model keeps track of manifest urls and statuses correctly. https://bugs.webkit.org/show_bug.cgi?id=64581 Dumping application cache tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-manifest-with-non-existing-file-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-manifest-with-non-existing-file-expected.txt index a93aa282..69496fd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-manifest-with-non-existing-file-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-manifest-with-non-existing-file-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that application cache model keeps track of manifest urls and statuses correctly when there is a non existing file listed in manifest. https://bugs.webkit.org/show_bug.cgi?id=64581 Dumping application cache tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-swap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-swap-expected.txt index 6d08427..56a2ec6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-swap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/appcache/appcache-swap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that application cache model keeps track of manifest urls and statuses correctly after UPDATEREADY event and swapCache() call. Dumping application cache tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-on-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-on-navigation-expected.txt index 1c9c29d..c43d744 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-on-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-on-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Application Panel response to a main frame navigation. Initial state:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-resource-preview-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-resource-preview-expected.txt index 526a5fd..be111a4f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-resource-preview-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-resource-preview-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Application Panel preview for resources of different types. Initial state:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt index 8e62242..c6965109 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Application Panel response to a main frame navigation. Initial state:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-websql-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-websql-expected.txt index 658806b..4d2a1b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-websql-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-websql-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Application Panel WebSQL support. Initial state:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/storage-view-reports-quota-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/storage-view-reports-quota-expected.txt index 61726d2f4..8d3617d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/storage-view-reports-quota-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/storage-view-reports-quota-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests quota reporting. Tree element found: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt index b9b42c8..f5ee20b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that audits panel works when only performance category is selected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt index 87b80b22..9d9f5546 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that audits panel prevents run of unauditable pages. **Prevents audit with no categories**
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt index ab81cff..0168ec4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that audits panel works.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-attach-detach-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-attach-detach-expected.txt index 0d378e8..6c574116 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-attach-detach-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-attach-detach-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodes are added and removed as iframe gets attached and detached.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-navigate-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-navigate-expected.txt index cc9c305..2bfe62c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-navigate-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-frame-navigate-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodes are removed as the frame gets navigated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-main-frame-navigated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-main-frame-navigated-expected.txt index 177bc9b46..c350966 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-main-frame-navigated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-main-frame-navigated-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodes are removed as main frame gets navigated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-multiple-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-multiple-frames-expected.txt index 046f233..f7399afe 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-multiple-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/bindings-multiple-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodes are removed as iframes are getting detached.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-bindings-multiple-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-bindings-multiple-frames-expected.txt index e949b03..d29cf69 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-bindings-multiple-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-bindings-multiple-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that SourceMap bindings are generating UISourceCodes properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-navigator-multiple-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-navigator-multiple-frames-expected.txt index ea29e5711..bf803dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-navigator-multiple-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/contentscripts-navigator-multiple-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that SourceMap bindings are generating UISourceCodes properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-bindings-frame-attach-detach-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-bindings-frame-attach-detach-expected.txt index 3161791..e9db4026 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-bindings-frame-attach-detach-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-bindings-frame-attach-detach-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodes are added and removed as iframe with dynamic script and stylesheet is added and removed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-navigator-frame-attach-detach-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-navigator-frame-attach-detach-expected.txt index fcfe525..50de468 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-navigator-frame-attach-detach-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-navigator-frame-attach-detach-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator is rendered properly when frame with dynamic script and style is added and removed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/inline-styles-binding-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/inline-styles-binding-expected.txt index 00f2fbc..777ec1e6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/inline-styles-binding-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/inline-styles-binding-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Editing inline styles should play nice with inline scripts. LiveLocation 'script0' was updated 13:12
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-bindings-overlapping-sources-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-bindings-overlapping-sources-expected.txt index 432e72a..379efa59 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-bindings-overlapping-sources-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-bindings-overlapping-sources-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that JavaScript SourceMap handle different sourcemap with overlapping sources. Running: initialWorkspace
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-navigator-overlapping-sources-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-navigator-overlapping-sources-expected.txt index 34339e4..abe0aef6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-navigator-overlapping-sources-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/jssourcemap-navigator-overlapping-sources-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that JavaScript SourceMap handle different sourcemaps with overlapping sources. Running: dumpInitialNavigator
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt index 3ec31c32..3431bad 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that debugger live location gets updated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-attach-detach-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-attach-detach-expected.txt index 6c00310..ff352bf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-attach-detach-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-attach-detach-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator is rendered properly when frames come and go.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-navigate-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-navigate-expected.txt index 5bbc3a6..f090df90c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-navigate-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-navigate-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator is updated as frame gets navigated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-main-frame-navigated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-main-frame-navigated-expected.txt index f9db0d4..c81e97a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-main-frame-navigated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-main-frame-navigated-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator properly handles main frame navigated event.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-multiple-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-multiple-frames-expected.txt index c4c9042..5c26008 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-multiple-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-multiple-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator is properly rendered in case of multiple iframes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-bindings-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-bindings-expected.txt index d8d372b..d6140ec 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-bindings-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-bindings-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodes are added and removed as shadow dom styles and scripts are added and removed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator-expected.txt index 58681bb..98ff8b08 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator shows proper UISourceCodes as shadow dom styles and scripts are added and removed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-bindings-multiple-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-bindings-multiple-frames-expected.txt index 003444a..682917a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-bindings-multiple-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-bindings-multiple-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that SourceMap bindings are generating UISourceCodes properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-navigator-multiple-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-navigator-multiple-frames-expected.txt index e8cfaa1..725b77c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-navigator-multiple-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-navigator-multiple-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that SourceMap sources are correctly displayed in navigator.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-bindings-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-bindings-expected.txt index a0549b4..d53a6e3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-bindings-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-bindings-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that bindings handle target suspension as expected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-navigator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-navigator-expected.txt index d459cfcb..3ce27e6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-navigator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-navigator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator is rendered properly when targets are suspended and resumed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-data-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-data-expected.txt index 4f877c8..5c1e5b8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-data-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-data-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cache data is correctly populated in the Inspector. Dumping CacheStorage tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-deletion-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-deletion-expected.txt index 838e549..2dc4a78 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-deletion-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-deletion-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cache data is correctly deleted by the inspector. Dumping CacheStorage tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-entry-deletion-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-entry-deletion-expected.txt index e60bac93..ddb737b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-entry-deletion-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-entry-deletion-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cache entry data is correctly deleted by the inspector. Dumping CacheStorage tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-cache-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-cache-content-expected.txt index 5d380c3..d9b17217 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-cache-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-cache-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cache view updates when the cache is changed. Dumping CacheStorage tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-list-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-list-expected.txt index 7f7d664..2fbe91f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-list-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-live-update-list-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the cache storage list live updates. Dumping CacheStorage tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-names-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-names-expected.txt index 3f6f582..654d97b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-names-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-names-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cache names are correctly loaded and displayed in the inspector. Dumping CacheStorage tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-track-valid-origin-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-track-valid-origin-expected.txt index 7801f66..50be6ca 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-track-valid-origin-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cache-storage/cache-track-valid-origin-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cache storage live update only tracks valid security origins. Invalid Origins:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/change-iframe-src-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/change-iframe-src-expected.txt index 58b876f..42668b9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/change-iframe-src-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/change-iframe-src-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Elements panel allows to change src attribute on iframes inside inspected page. See bug 41350. IFRAME HOST: 127.0.0.1:8000
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-highlighter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-highlighter-expected.txt index 81890d2..abe5abb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-highlighter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-highlighter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the changes view highlights diffs correctly. - .will-be-deleted-but-will-show-modified-because-first-line {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-sidebar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-sidebar-expected.txt index 59843675..b421549 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-sidebar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/changes/changes-sidebar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the changes sidebar contains the changed uisourcecodes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/color_picker/contrast-overlay-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/color_picker/contrast-overlay-expected.txt index 4719be3..08bebe2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/color_picker/contrast-overlay-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/color_picker/contrast-overlay-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the contrast line algorithm produces good results and terminates.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/command-line-api-inspect-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/command-line-api-inspect-expected.txt index 0cb77c9..59b504d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/command-line-api-inspect-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/command-line-api-inspect-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect() command line api works.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-script-mapping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-script-mapping-expected.txt index e41eec9e..7c37f0db 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-script-mapping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-script-mapping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests SourceMap and CompilerScriptMapping.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-source-mapping-debug-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-source-mapping-debug-expected.txt index 4f90209..d3e3ac3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-source-mapping-debug-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-source-mapping-debug-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests installing compiler source map in scripts panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/chunked-file-reader-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/chunked-file-reader-expected.txt index 54b6b5d..cd613336 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/chunked-file-reader-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/chunked-file-reader-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that ChunkedFileReader properly re-assembles chunks, especially in case these contain multibyte characters. Read result: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/color-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/color-expected.txt index 624c28e..88df260 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/color-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/color-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Common.Color Dumping 'red' in different formats:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookie-parser-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookie-parser-expected.txt index 87f0c46..063f464 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookie-parser-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookie-parser-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inspector cookie parser source: cookie=value
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookies-table-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookies-table-expected.txt index 270df13..18bb9763 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookies-table-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/cookies-table-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inspector cookies table
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/css-shadow-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/css-shadow-model-expected.txt index bab4298b..efe3a294 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/css-shadow-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/css-shadow-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests CSSLength.parse, CSSShadowModel.parseTextShadow, and CSSShadowModel.parseBoxShadow. -----CSSLengths-----
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-autosize-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-autosize-expected.txt index 57644a6..d45ee78 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-autosize-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-autosize-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DataGrid column auto size calculation. Auto sizing [198,2,400], minPercent=90, maxPercent=undefined
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-expected.txt index 18da43a..32c25e646 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/datagrid-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ViewportDataGrid. data-grid
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/dom-extension-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/dom-extension-expected.txt index ab05449a..c6fe1bb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/dom-extension-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/dom-extension-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks dom extensions.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/file-path-scoring-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/file-path-scoring-expected.txt index 274a5bf..dd267d3e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/file-path-scoring-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/file-path-scoring-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test file path scoring function Expected score must be equal to the actual score
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/flame-chart-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/flame-chart-expected.txt index 1bc8e19e..254d668 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/flame-chart-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/flame-chart-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Smoke test for basic FlameChart functionality. PASSED
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/fragment-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/fragment-expected.txt index 71da14a..d62c6e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/fragment-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/fragment-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how fragment works. f1.outerHTML:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/geometry-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/geometry-expected.txt index e39db24..948c0b712 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/geometry-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/geometry-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Geometry utility class
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/json-balanced-tokenizer-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/json-balanced-tokenizer-expected.txt index c2825b9d..5cd3dca 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/json-balanced-tokenizer-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/json-balanced-tokenizer-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test TextUtils.TextUtils.BalancedJSONTokenizer.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/linkifier-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/linkifier-expected.txt index 356e66e..c0dd661 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/linkifier-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/linkifier-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Linkifier works correctly. Live locations count: 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/minimum-size-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/minimum-size-expected.txt index b76530e1..b9cf5fb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/minimum-size-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/minimum-size-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how widget minimum size works. Creating simple hierarchy
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/parsed-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/parsed-url-expected.txt index d31cb6b..545c683f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/parsed-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/parsed-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inspector ParsedURL class Parsing url: http://example.com/?queryParam1=value1&queryParam2=value2#fragmentWith/Many//Slashes
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/progress-bar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/progress-bar-expected.txt index b8600030..20540a8b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/progress-bar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/progress-bar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inspector's composite progress bar.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/segmented-range-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/segmented-range-expected.txt index 6eea7f5..0dc5f23 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/segmented-range-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/segmented-range-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests SegmentedRange Test case: one
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-string-by-regexes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-string-by-regexes-expected.txt index 6865744..9ae09b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-string-by-regexes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-string-by-regexes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests TextUtils.TextUtils.splitStringByRegexes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-widget-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-widget-expected.txt index 013c97b3..a92b8c8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-widget-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/split-widget-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how split widget saving to settings works. Create default split widget
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/throttler-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/throttler-expected.txt index c9a4342..87eb734f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/throttler-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/throttler-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies throttler behavior.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-expected.txt index 9d893eb3..2bff756 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks Web Inspector utilities.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-highlight-results-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-highlight-results-expected.txt index 68aa31b..5beb6fb9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-highlight-results-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/utilities-highlight-results-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how utilities functions highlight text and then revert/re-apply highlighting changes. --------- Running test: ----------
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/viewport-datagrid-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/viewport-datagrid-expected.txt index 0e6aeb3..eaa9f8e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/viewport-datagrid-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/viewport-datagrid-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ViewportDataGrid. Building tree.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-events-expected.txt index 2935a99..133a2fa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that events are properly propagated through Widget hierarchy.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-focus-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-focus-expected.txt index 901ce28..68b66d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-focus-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/components/widget-focus-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests whether focus is properly remembered on widgets. Focusing outer input...
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-completions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-completions-expected.txt index 674eccd..4d7dc87 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-completions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-completions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that completions in the context of an iframe with a different origin will result in names of its global variables. Test passes if all global variables are found among completions AND there are NO console messages. Bug 65457.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-expected.txt index 2187bea..7b70482 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-cd-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console evaluation can be performed in an iframe context.Bug 19872. foo = 2011
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-completions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-completions-expected.txt index e901c0b..518da24 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-completions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-completions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests completions prototype chain and scope variables. Completions for objectC.:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-cross-origin-iframe-logging-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-cross-origin-iframe-logging-expected.txt index 0ceb6d0..31eca37 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-cross-origin-iframe-logging-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-cross-origin-iframe-logging-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cross origin errors are logged with source url and line number. console-cross-origin…frame-logging.js:25 Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('http://127.0.0.1:8000') does not match the recipient window's origin ('http://localhost:8000').
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-document-write-from-external-script-logging-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-document-write-from-external-script-logging-expected.txt index 99dac37..827fc73a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-document-write-from-external-script-logging-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-document-write-from-external-script-logging-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that ignored document.write() called from an external asynchronously loaded script is reported to console as a warning external-script-with-document-write.js:2 Failed to execute 'write' on 'Document': It isn't possible to write into a document from an asynchronously-loaded external script unless it is explicitly opened.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-fetch-logging-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-fetch-logging-expected.txt index 2027d18c..d887f54 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-fetch-logging-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-fetch-logging-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that fetch logging works when XMLHttpRequest Logging is Enabled and doesn't show logs when it is Disabled. Making requests with monitoring ENABLED @@ -32,6 +33,7 @@ step1 @ console-fetch-logging.js:33 makeRequests @ console-fetch-logging.js:27 (anonymous) @ VM:1 +console-fetch-logging.js:13 sending a GET request to http://localhost:8000/devtools/resources/xhr-exists.html VM:58 Fetch finished loading: POST "http://127.0.0.1:8000/devtools/resources/post-target.cgi". makeFetch @ VM:58 requestHelper @ console-fetch-logging.js:20 @@ -48,8 +50,28 @@ step1 @ console-fetch-logging.js:33 makeRequests @ console-fetch-logging.js:27 (anonymous) @ VM:1 -console-fetch-logging.js:13 sending a GET request to http://localhost:8000/devtools/resources/xhr-exists.html -inspected-page.html:1 Failed to load http://localhost:8000/devtools/resources/xhr-exists.html: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://127.0.0.1:8000' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. +inspected-page.html:1 Access to fetch at 'http://localhost:8000/devtools/resources/xhr-exists.html' from origin 'http://127.0.0.1:8000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. +VM:58 Cross-Origin Read Blocking (CORB) blocked cross-origin response http://localhost:8000/devtools/resources/xhr-exists.html with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details. +makeFetch @ VM:58 +requestHelper @ console-fetch-logging.js:20 +step4 @ console-fetch-logging.js:51 +setTimeout (async) +delayCallback @ console-fetch-logging.js:18 +Promise.then (async) +requestHelper @ console-fetch-logging.js:20 +step3 @ console-fetch-logging.js:45 +setTimeout (async) +delayCallback @ console-fetch-logging.js:18 +Promise.then (async) +requestHelper @ console-fetch-logging.js:20 +step2 @ console-fetch-logging.js:39 +setTimeout (async) +delayCallback @ console-fetch-logging.js:18 +Promise.then (async) +requestHelper @ console-fetch-logging.js:20 +step1 @ console-fetch-logging.js:33 +makeRequests @ console-fetch-logging.js:27 +(anonymous) @ VM:1 VM:58 Fetch finished loading: GET "http://localhost:8000/devtools/resources/xhr-exists.html". makeFetch @ VM:58 requestHelper @ console-fetch-logging.js:20 @@ -87,5 +109,26 @@ (anonymous) @ VM:1 console-fetch-logging.js:13 sending a POST request to resources/post-target.cgi console-fetch-logging.js:13 sending a GET request to http://localhost:8000/devtools/resources/xhr-exists.html -inspected-page.html:1 Failed to load http://localhost:8000/devtools/resources/xhr-exists.html: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://127.0.0.1:8000' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. +inspected-page.html:1 Access to fetch at 'http://localhost:8000/devtools/resources/xhr-exists.html' from origin 'http://127.0.0.1:8000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. +VM:58 Cross-Origin Read Blocking (CORB) blocked cross-origin response http://localhost:8000/devtools/resources/xhr-exists.html with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details. +makeFetch @ VM:58 +requestHelper @ console-fetch-logging.js:20 +step4 @ console-fetch-logging.js:51 +setTimeout (async) +delayCallback @ console-fetch-logging.js:18 +Promise.then (async) +requestHelper @ console-fetch-logging.js:20 +step3 @ console-fetch-logging.js:45 +setTimeout (async) +delayCallback @ console-fetch-logging.js:18 +Promise.then (async) +requestHelper @ console-fetch-logging.js:20 +step2 @ console-fetch-logging.js:39 +setTimeout (async) +delayCallback @ console-fetch-logging.js:18 +Promise.then (async) +requestHelper @ console-fetch-logging.js:20 +step1 @ console-fetch-logging.js:33 +makeRequests @ console-fetch-logging.js:27 +(anonymous) @ VM:1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors-expected.txt index 2e48f475..646b985 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that errors to load a resource cause error messages to be logged to console. console-resource-errors-iframe.html:3 GET http://127.0.0.1:8000/devtools/missing.css net::ERR_ABORTED 404 (Not Found) console-message-wrapper console-error-level > console-message
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-show-all-messages-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-show-all-messages-expected.txt index aab374a..44e22af 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-show-all-messages-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-show-all-messages-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console shows messages only from specific context when show target checkbox is checked.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt index a531922..f82dfb3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console sidebar behaves properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-async-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-async-expected.txt index ddc8d00..8e1b428 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-async-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-async-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XMLHttpRequest Logging works when Enabled and doesn't show logs when Disabled for asynchronous XHRs. XHR with logging enabled:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-expected.txt index 648886b..4857cb6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XMLHttpRequest Logging works when Enabled and doesn't show logs when Disabled. Message count: 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/alert-toString-exception-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/alert-toString-exception-expected.txt index c58926336..63f3b0fb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/alert-toString-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/alert-toString-exception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that browser won't crash if inspector is opened for a page that fails to convert alert() argument to string. The test passes if it doesn't crash. Bug 60541 Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/argument-hints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/argument-hints-expected.txt index b2c90ca..64879f9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/argument-hints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/argument-hints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests function argument hints. open(
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-expected.txt index 680f042..9c68ce8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that command line api works.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-getEventListeners-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-getEventListeners-expected.txt index af463a6..a0bb150 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-getEventListeners-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-getEventListeners-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests getEventListeners() method of console command line API. [page] - inner -
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-Object-overwritten-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-Object-overwritten-expected.txt index 16dd1bef..e5e3166e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-Object-overwritten-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-Object-overwritten-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector's console is not broken if Object is overwritten in the inspected page. Test passes if the expression is evaluated in the console and no errors printed. Bug 101320. var foo = {bar:2012}; foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-api-on-call-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-api-on-call-frame-expected.txt index af26fc27..95fa6c3a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-api-on-call-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-api-on-call-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that command line api does not mask values of scope variables while evaluating on a call frame. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-assert-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-assert-expected.txt index 8184931..614ac19b8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-assert-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-assert-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.assert() will dump a message and stack trace with source URLs and line numbers. console-assert.js:14 Assertion failed: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bad-stacktrace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bad-stacktrace-expected.txt index 6dcbc994..9ea94ac 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bad-stacktrace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bad-stacktrace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console messages with invalid stacktraces will still be rendered, crbug.com/826210 (unknown) This should be visible
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-big-array-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-big-array-expected.txt index 5aebdf40..1efef2c7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-big-array-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-big-array-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps large arrays properly. console-big-array.js:18 Array(101)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bind-fake-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bind-fake-expected.txt index 4b29cfc..90610b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bind-fake-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-bind-fake-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that overriding Function.prototype.bind does not break inspector. foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-call-getter-on-proto-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-call-getter-on-proto-expected.txt index 7047e39a..0ff1784 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-call-getter-on-proto-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-call-getter-on-proto-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that calling getter on prototype will call it on the object. console-call-getter-on-proto.js:27 B {value: 239}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-expected.txt index 6aff65e..dc6e6be 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console is cleared upon requestClearMessages call. === Before clear ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-function-expected.txt index da5f10bb..4736944 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-clear-function-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console is cleared via console.clear() method
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-clear-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-clear-expected.txt index 5636c991..df03989 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-clear-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-clear-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console is cleared upon clear() eval in console. === Before clear ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-copy-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-copy-expected.txt index 8daebd7..566482c5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-copy-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-command-copy-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console's copy command is copying into front-end buffer. InspectorFrontendHost.copyText: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector-expected.txt index 0a70b2e..15b5741a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console execution context selector. Console context selector:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-control-characters-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-control-characters-expected.txt index 1eef2b3e2..739a0cf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-control-characters-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-control-characters-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that control characters are substituted with printable characters. var� i = 0;
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-treeoutline-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-treeoutline-expected.txt index e693da3..1e2d6f3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-treeoutline-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-treeoutline-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console copies tree outline messages properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-truncated-text-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-truncated-text-expected.txt index ca63ddc2..efe2219 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-truncated-text-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-copy-truncated-text-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console copies truncated text in messages properly. Message count: 8
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions-expected.txt index 1268482..dcf060e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-correct-suggestions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console correctly finds suggestions in complicated cases. Checking 'window.|foo'
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters-expected.txt index 7cf9becb..5e1eff6c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-custom-formatters-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps properly when there are multiple custom formatters on the page console-custom-formatters.js:120 Header formatted by 1 aBody formatted by 1 a
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-deprecated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-deprecated-expected.txt index 0cb9383..2acc2d1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-deprecated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-deprecated-expected.txt
@@ -1,5 +1,9 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console does not log deprecated warning messages while dir-dumping objects. console-dir-deprecated.js:17 Window +console-dir-deprecated.js:18 [Deprecation] Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +logObjects @ console-dir-deprecated.js:18 +(anonymous) @ console-dir-deprecated.js:22 console-dir-deprecated.js:18 #document-fragment
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-es6-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-es6-expected.txt index 3a2e3bf..c1c0449 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-es6-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-es6-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proper messages. console-dir-es6.js:20 Object
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt index f9639b12..b7d7401 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proper messages. console-dir.js:12 Array(2)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-global-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-global-expected.txt index 4111acf..27c5bd3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-global-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-global-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console dumps global object with properties. {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-primitives-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-primitives-expected.txt index cd446ef..de863b1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-primitives-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dir-primitives-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console dir makes messages expandable only when necessary. Message text: console-dir-primitives.js:13 true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml-expected.txt index 71a226c..db8ee51 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proper messages. console-dirxml.js:17 #document
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-expanded-tree-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-expanded-tree-expected.txt index 3b2e8d6..1f9c89ed 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-expanded-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-expanded-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that expanded tree element is editable in console. After viewport refresh tree element remains in editing mode: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-property-value-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-property-value-expected.txt index d2a2acd5..95373e6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-property-value-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-property-value-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that property values can be edited inline in the console via double click. Node was hidden after dblclick: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-error-on-call-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-error-on-call-frame-expected.txt index 6b28f44..7b0806d7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-error-on-call-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-error-on-call-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.error does not throw exception when executed in console on call frame. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-blocked-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-blocked-expected.txt index 4fb9276f0..799697f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-blocked-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-blocked-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluation in console still works even if script evals are prohibited by Content-Security-Policy. Bug 60800. 1+2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-exception-report-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-exception-report-expected.txt index 35c7f6f..4bd5361 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-exception-report-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-exception-report-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluating an expression with an exception in the console provide correct exception information. function foo()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-expected.txt index 73a50420..3d53dd9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that simple evaluations may be performed in the console. 1+2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-fake-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-fake-expected.txt index 80737d1..92a487e8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-fake-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-fake-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that overriding window.eval does not break inspector. foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-global-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-global-expected.txt index b05f9be..7c73dfd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-global-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-global-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that simple evaluations may be performed in the console on global object. foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-object-literal-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-object-literal-expected.txt index f8fa7240..33c1c273 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-object-literal-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-object-literal-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluating object literal in the console correctly reported. {a:1, b:2}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-scoped-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-scoped-expected.txt index 3178647..e60a4538 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-scoped-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-scoped-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluating 'console.log()' in the console will have access to its outer scope variables. Bug 60547.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-syntax-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-syntax-error-expected.txt index 45a50e9..d60d0f23 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-syntax-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-syntax-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluating an expression with a syntax error in the console won't crash the browser. Bug 61194. foo().
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-throw-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-throw-expected.txt index 57f4223..3e561f7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-throw-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-throw-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluating 'throw undefined|1|string|object|Error' in the console won't crash the browser and correctly reported. Bug 59611.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-undefined-override-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-undefined-override-expected.txt index 660f71e..5a257a5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-undefined-override-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-eval-undefined-override-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluating something in console won't crash the browser if undefined value is overriden. The test passes if it doesn't crash. Bug 64155. var x = {a:1}; x.self = x; undefined = x;
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-export-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-export-expected.txt index 538557ac..d1b686b0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-export-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-export-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that exporting console messages produces proper output.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array-expected.txt index 2eded13..b6b22710 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging detects external arrays as arrays. console-external-array.js:14 Int8Array(10) [0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test-expected.txt index 63b0465..d88f6e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console can filter messages by source.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt index 5967758..c0b8b4e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console can filter messages by source.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-focus-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-focus-expected.txt index 9dd2ca8f..7796695 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-focus-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-focus-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that interacting with the console gives appropriate focus. Message count: 2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt index 83b607c..4667e9c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps array values defined on Array.prototype[]. a0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-bigint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-bigint-expected.txt index 25dba9c..cb0477f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-bigint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-bigint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console properly displays BigInts. console-format-bigint.js:15 1n
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-broken-unicode-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-broken-unicode-expected.txt index d750d7c9..13c04559 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-broken-unicode-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-broken-unicode-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proper messages with broken Unicode. PASS: Found all nodes with the broken text
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-classes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-classes-expected.txt index 29d2118..48c87c5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-classes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-classes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console produces instant previews for arrays and objects. console-format-classes.js:30 Error: custom error with link www.chromium.org
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-collections-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-collections-expected.txt index de11b49d..2398f5c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-collections-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-collections-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console nicely formats HTML Collections, NodeLists and DOMTokenLists. console-format-collections.js:33 HTMLCollection [select#sel, sel: select#sel]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2-expected.txt index a4f09e0..bb585ee 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console properly displays information about ES6 features. console-format-es6-2.js:15 MapIterator {41, {…}}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-expected.txt index a3cc0c1..fb3ba39 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console properly displays information about ES6 features. console-format-es6.js:15 Promise {<rejected>: -0}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error-expected.txt index a2d8d5f2..b861b142 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-symbols-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console properly displays information about ES6 Symbols. console-format-es6-symbols-error.js:16 Symbol
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt index 6d16679..a19d3ec3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proper messages. console-format.js:34 (10) ["test", "test2", empty × 2, "test4", empty × 5, foo: {…}]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-perfomance-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-perfomance-expected.txt index 88623e7..da7a23e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-perfomance-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-perfomance-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console nicely formats perfomance getters. console-format-perfomance.js:14 PerformanceTiming {navigationStart: <number>, unloadEventStart: <number>, unloadEventEnd: <number>, redirectStart: <number>, redirectEnd: <number>, …}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-expected.txt index a7ab358..d28280a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps properly styled messages. console-format-style.js:14 Blue!.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-whitelist-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-whitelist-expected.txt index b59fd9d..1295be2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-whitelist-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-style-whitelist-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps properly styled messages, and that the whole message gets the same style, regardless of multiple %c settings. console-format-style-whitelist.js:13 Colors are awesome.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-table-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-table-expected.txt index 0f0687e..e9ca56f7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-table-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-table-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console.table. console-format-table.js:11
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-functions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-functions-expected.txt index 1a32b572..0fd08ee 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-functions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-functions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging different types of functions correctly. console-functions.js:27 ƒ simple() {}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar-expected.txt index 3a1f30b..ff97880 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console correctly groups similar messages. 5[Violation] Verbose-level violation
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-history-contains-requested-text-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-history-contains-requested-text-expected.txt index 827a79c3..a102bda 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-history-contains-requested-text-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-history-contains-requested-text-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that expression which is evaluated as Object Literal, is correctly stored in console history. (crbug.com/584881) {a:1, b:2}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-last-result-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-last-result-expected.txt index 9bd3490..f5823ef 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-last-result-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-last-result-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console exposes last evaluation result as $_.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-link-to-snippet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-link-to-snippet-expected.txt index 23275769..4643800 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-link-to-snippet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-link-to-snippet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that link to snippet works.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-message-location-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-message-location-expected.txt index da29245..cd3e3155 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-message-location-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-message-location-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that console.log() would linkify its location in respect with blackboxing. foo.js:13
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-relative-links-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-relative-links-expected.txt index c5b7e7ee..fd8c04e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-relative-links-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-relative-links-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that logging an error in console would linkify relative URLs console-linkify-relative-links.js:10 Error with relative links
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-in-errors-with-trace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-in-errors-with-trace-expected.txt index 9d61ded..7e6ff49 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-in-errors-with-trace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-in-errors-with-trace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that relative links and links with hash open in the sources panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-on-messages-before-inspection-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-on-messages-before-inspection-expected.txt index 775b232..4dbcd67 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-on-messages-before-inspection-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-links-on-messages-before-inspection-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests a handling of a click on the link in a message, which had been shown before its originating script was added. source2.js:1 hello?
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-before-inspector-open-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-before-inspector-open-expected.txt index 06f2d5853..d8be380 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-before-inspector-open-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-before-inspector-open-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector won't crash if some console have been logged by the time it's opening. console-log-before-inspector-open.js:13 log
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-custom-elements-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-custom-elements-expected.txt index b7cd2733..35a1189 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-custom-elements-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-custom-elements-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that logging custom elements uses proper formatting. console-log-custom-elements.js:20 foo-bar
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-document-proto-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-document-proto-expected.txt index f9b6e26..1282051 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-document-proto-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-document-proto-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that console.dir(document.__proto__) won't result in an exception when the message is formatted in the inspector.Bug 27169. console-log-document-proto.js:14 HTMLDocument
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-eval-syntax-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-eval-syntax-error-expected.txt index 7cac82b..c2a9224 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-eval-syntax-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-eval-syntax-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that syntax errors in eval are logged into console, contains correct link and doesn't cause browser crash. VM:1 Uncaught SyntaxError: Unexpected token }
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-in-xhtml-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-in-xhtml-expected.txt index 894c669b..1bf16d9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-in-xhtml-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-in-xhtml-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console message from inline script in xhtml document contains correct script position information. 239:2:15
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-links-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-links-expected.txt index ab9f2fc..b109c1a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-links-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-links-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that console.log() would linkify the links. Bug 231074. Dump urls in messages
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-stack-in-errors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-stack-in-errors-expected.txt index ed5da8d..94ca914 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-stack-in-errors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-stack-in-errors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that console.log(new Error().stack) would linkify links in stacks for sourceUrls and sourceMaps Bug 424001. foob.js:5 Error: Some test
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-object-with-getter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-object-with-getter-expected.txt index 9b384cc..1bdfb5d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-object-with-getter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-object-with-getter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps object values defined by getters and allows to expand it. console-log-object-with-getter.js:30 {}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-short-hand-method-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-short-hand-method-expected.txt index 5fdcaf3..ece869b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-short-hand-method-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-short-hand-method-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector won't crash if some console have been logged by the time it's opening. console-log-short-hand-method.js:24 {foo: ƒ, boo: ƒ, gen: ƒ}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-side-effects-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-side-effects-expected.txt index c5f07cae..9e5248a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-side-effects-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-side-effects-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests various extreme usages of console.log() console-log-side-effects.js:24 string
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-syntax-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-syntax-error-expected.txt index 02fc3d1f..2e047f9a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-syntax-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-syntax-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that syntax errors are logged into console and doesn't cause browser crash. syntax-error.js:3 Uncaught SyntaxError: Unexpected token )
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-toString-object-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-toString-object-expected.txt index e7fa8ba..f0c270f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-toString-object-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-toString-object-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that passing an object which throws on string conversion into console.log won't crash inspected Page. The test passes if it doesn't crash. Bug 57557 Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-without-console-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-without-console-expected.txt index bc9c65e..5e3a442 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-without-console-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-without-console-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that console.log can be called without console receiver. console-log-without-console.js:12 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-wrapped-in-framework-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-wrapped-in-framework-expected.txt index a72352f..5e9a88d2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-wrapped-in-framework-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-wrapped-in-framework-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console.log() anchor location when the skip-stack-frames feature is enabled. console-log-wrapped-in-framework.js:13 direct console.log()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-memory-equals-console-memory-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-memory-equals-console-memory-expected.txt index 77c8554..5bffdc14 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-memory-equals-console-memory-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-memory-equals-console-memory-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.memory returns fresh instance/samples. console.memory === console.memory
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-contains-async-stack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-contains-async-stack-expected.txt index 6b4e2f8..012c5ed 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-contains-async-stack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-contains-async-stack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests exception message with empty stack in console contains async stack trace. VM:1 Uncaught SyntaxError: Unexpected end of input
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-format-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-format-expected.txt index cbceb37..f391463 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-format-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-format-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging uses proper message formatting. console-message-format.js:11 Message format number 1, 2 and 3.5
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-inline-with-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-inline-with-url-expected.txt index 3524e238..752cf02a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-inline-with-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-inline-with-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that log message and syntax errors from inline scripts with sourceURL are logged into console, contains correct link and doesn't cause browser crash. foo.js:13 foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-script-inside-svg-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-script-inside-svg-expected.txt index cb0a27e..f948df8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-script-inside-svg-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-script-inside-svg-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that message from script inside svg has correct source location. svg.html:2 42
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-native-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-native-function-expected.txt index 3550166..7ed8a4a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-native-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-native-function-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console dumps native function without exception. Math.random
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-nested-group-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-nested-group-expected.txt index 9d8c152..68436da7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-nested-group-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-nested-group-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.group/groupEnd messages won't be coalesced. Bug 56114. Bug 63521. console-nested-group.js:12 outer group console-message-wrapper console-group-title console-from-api console-info-level > console-message
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-constructor-name-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-constructor-name-expected.txt index cbb4b78..853e1bb8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-constructor-name-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-constructor-name-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the name of the function invoked as object constructor will be displayed as its type in the front-end. Bug 50063. console-object-constructor-name.js:17 Parent {}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-preview-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-preview-expected.txt index 0eaf3e4..6a71043 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-preview-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-preview-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console produces instant previews for arrays and objects. console-object-preview.js:10 Mutating object in a loop
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-on-paint-worklet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-on-paint-worklet-expected.txt index 1e0e73ec..28e7739 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-on-paint-worklet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-on-paint-worklet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console output from PaintWorklet. Message count: 6
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-originating-command-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-originating-command-expected.txt index e838a86..fb39849 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-originating-command-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-originating-command-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console result has originating command associated with it. 1 + 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-pins-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-pins-expected.txt index fc4320f..7b9dbc1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-pins-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-pins-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console can pin expressions.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-log-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-log-expected.txt index c066ec5..1ec4a6b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-log-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-log-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the console can preserve log messages across navigations. Bug 53359 Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll-expected.txt index cd38035..036f622c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-preserve-scroll-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console preserves scroll position when switching away. Message count: 100
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-prompt-keyboard-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-prompt-keyboard-expected.txt index 5456d37..712e604 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-prompt-keyboard-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-prompt-keyboard-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console prompt keyboard events work. Adding first message: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-proxy-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-proxy-expected.txt index 290c7adb..3674ada 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-proxy-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-proxy-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proxy properly. console-proxy.js:25 Proxy {boo: 42, foo: 43}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-repeat-count-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-repeat-count-expected.txt index a44e3f7..7178029 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-repeat-count-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-repeat-count-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that repeat count is properly updated. Message count: 2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-retain-autocomplete-on-typing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-retain-autocomplete-on-typing-expected.txt index bb1ad6b..af3d64a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-retain-autocomplete-on-typing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-retain-autocomplete-on-typing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that console does not hide autocomplete during typing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-expected.txt index 22e99e22..04cf5bbe 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console revokes lazily handled promise rejections. Creating promise
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-in-worker-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-in-worker-expected.txt index 5a54d8c..c377d8d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-in-worker-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-in-worker-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console revokes lazily handled promise rejections. Creating worker with promise
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-save-to-temp-var-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-save-to-temp-var-expected.txt index 91cafc33..d68ee564 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-save-to-temp-var-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-save-to-temp-var-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests saving objects to temporary variables. Number of expressions: 11
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-script-with-same-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-script-with-same-url-expected.txt index 1bd02b2..4fe5322 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-script-with-same-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-script-with-same-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that we show correct location for script evaluated twice. VM a.js:1 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-expected.txt index ecee5fc..0ea78cf0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console search.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-reveals-messages-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-reveals-messages-expected.txt index 15640ea..76cfa24 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-reveals-messages-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-search-reveals-messages-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console viewport reveals messages on searching.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-smart-enter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-smart-enter-expected.txt index 6001ba2..07b8df5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-smart-enter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-smart-enter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the console enters a newline instead of running a command if the command is incomplete. Text Before Enter:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-stack-overflow-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-stack-overflow-expected.txt index 7833edb..c10e16b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-stack-overflow-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-stack-overflow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when stack overflow exception happens when inspector is open the stack trace is correctly shown in console. console-stack-overflow.js:15 Uncaught RangeError: Maximum call stack size exceeded
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-string-format-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-string-format-expected.txt index f6778d3..0c54360 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-string-format-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-string-format-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that formatting processes '%' properly in case of missing formatters. String.sprintf(%T, 1) = "%T"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-substituted-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-substituted-expected.txt index ca54092d..98e1e944 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-substituted-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-substituted-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluate in console works even if window.console is substituted or deleted. Bug 53072 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-table-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-table-expected.txt index 2571c0a..9071a2a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-table-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-table-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.table is properly rendered on tables with more than 20 columns(maxColumnsToRender). HEADER (index) | b0 | b1 | b2 | b3 | b4 | b5 | b6 | b7 | b8 | b9 | b10 | b11 | b12 | b13 | b14 | a0 | a1 | a2 | a3 | a4 |
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tainted-globals-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tainted-globals-expected.txt index 74f58ad..a0a2619 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tainted-globals-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tainted-globals-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that overriding global methods (like Array.prototype.push, Math.max) will not break the inspector.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tests-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tests-expected.txt index ab91c608..8625936f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tests-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tests-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging dumps proper messages. console-tests.js:11 log console-message-wrapper console-from-api console-info-level > console-message
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-time-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-time-expected.txt index 410eec6..07e7acb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-time-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-time-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. console.time / console.timeEnd tests. console-time.js:14 default: <time>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-timestamp-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-timestamp-expected.txt index 274b75a..794b840 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-timestamp-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-timestamp-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the console timestamp setting. Console messages with timestamps disabled:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-top-level-await-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-top-level-await-expected.txt index ca767bc..68317af0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-top-level-await-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-top-level-await-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluation with top-level await may be perfomed in console. await Promise.resolve(1) 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-arguments-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-arguments-expected.txt index 53b4c199..618b53a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-arguments-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-arguments-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.trace dumps arguments alongside the stack trace. console-trace-arguments.js:13 1 2 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-expected.txt index 6caf37b15..6a0d94a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console.trace dumps stack trace with source URLs and line numbers. console-trace.js:13 console.trace
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-in-eval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-in-eval-expected.txt index 3a95e534..061b372 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-in-eval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trace-in-eval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when console.trace is called in eval'ed script ending with //# sourceURL=url it will dump a stack trace that will have the url as the script source. Bug 47252. evalURL.js:5 console.trace
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trim-long-urls-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trim-long-urls-expected.txt index f0d9e05852..5a91c57 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trim-long-urls-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-trim-long-urls-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that a URL logged to the console is trimmed down to 150 characters. console-trim-long-urls.js:14 The URL is: http://example.com/2---------3---------4---------5---------6---------7-----…---3---------4---------5---------6---------7---------8---------9---------0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-truncate-long-messages-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-truncate-long-messages-expected.txt index eddf0b8d..df7d36a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-truncate-long-messages-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-truncate-long-messages-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console logging large messages will be truncated. Setting max length to: 40
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-expected.txt index 77ce2ef0..b2c2b89 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that uncaught exceptions are logged into console.Bug 47250. uncaught-in-iframe.html:18 Uncaught Error: Exception in inline script.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-in-eval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-in-eval-expected.txt index 0efed9b..5a6be2cf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-in-eval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-exception-in-eval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when uncaught exception in eval'ed script ending with //# sourceURL=url is logged into console, its stack trace will have the url as the script source. Bug 47252. evalURL.js:5 Uncaught Error: Exception in eval:with sourceURL
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-expected.txt index 4ae14fa..13d64f9e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that uncaught promise rejections are logged into console. console-uncaught-promise.js:26 Uncaught (in promise) Error: err1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-in-worker-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-in-worker-expected.txt index ef42dca..623f790 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-in-worker-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-uncaught-promise-in-worker-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that uncaught promise rejections happenned in workers are logged into console. worker-with-unhandled-promises.js:3 Uncaught (in promise) Error: err1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-control-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-control-expected.txt index 909f48ff..523dbb9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-control-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-control-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies viewport correctly shows and hides messages while logging and scrolling. Logging 100 messages
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-indices-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-indices-expected.txt index 8386edae..ff8886cb5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-indices-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-indices-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies viewport's visible and active message ranges.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-selection-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-selection-expected.txt index d4493c7..7177fcd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-selection-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-selection-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console viewport handles selection properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-stick-to-bottom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-stick-to-bottom-expected.txt index 72b62a34..52c6f29d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-stick-to-bottom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-viewport-stick-to-bottom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies viewport stick-to-bottom behavior.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-worker-nested-imports-syntax-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-worker-nested-imports-syntax-error-expected.txt index 8f0fd2b..01f7892 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-worker-nested-imports-syntax-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-worker-nested-imports-syntax-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that nested import scripts in worker show correct stack on syntax error. Message count: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xml-document-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xml-document-expected.txt index 5a0dd62..13b94933 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xml-document-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xml-document-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XML document contents are logged using the correct case in the console. console-xml-document.js:11 #document<MixedCase> Test </MixedCase>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xpath-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xpath-expected.txt index 1da0e27..672cc0d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xpath-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-xpath-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests $x for iterator and non-iterator types. $x('42')
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/exception-objects-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/exception-objects-expected.txt index a297881..0b1fcb7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/exception-objects-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/exception-objects-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that expressions have thrown objects. setTimeout(throwError, 0); undefined
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/function-name-in-console-message-stack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/function-name-in-console-message-stack-expected.txt index a28f1b1..d1531b72b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/function-name-in-console-message-stack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/function-name-in-console-message-stack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests exception message contains stack with correct function name. function-name-in-con…message-stack.js:13 Uncaught Error
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/inspect-html-all-collection-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/inspect-html-all-collection-expected.txt index 098727d..e0076f70 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/inspect-html-all-collection-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/inspect-html-all-collection-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that HTMLAllCollection properties can be inspected. PASSED: retrieved length of document.all
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/nested-worker-eval-contains-stack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/nested-worker-eval-contains-stack-expected.txt index ccdcc5c..d5f188d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/nested-worker-eval-contains-stack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/nested-worker-eval-contains-stack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests exception message from eval on nested worker context in console contains stack trace. function foo()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/only-one-deprecation-warning-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/only-one-deprecation-warning-expected.txt index 38ce616..9f9089c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/only-one-deprecation-warning-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/only-one-deprecation-warning-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test passes if only one deprecation warning is presented in the console. only-one-deprecation-warning.js:10 [Deprecation] 'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/paintworklet-console-selector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/paintworklet-console-selector-expected.txt index 6736add..604a16ef 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/paintworklet-console-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/paintworklet-console-selector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console execution context selector for paintworklet. Console context selector:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/shadow-element-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/shadow-element-expected.txt index 197bdf9..02d1c92 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/shadow-element-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/shadow-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that $0 works with shadow dom. 'Author shadow element: ' + $0.id = "Author shadow element: shadow"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt-expected.txt index 5735d66..744a836 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console fills the empty element below the prompt editor.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt-expected.txt index 1566bbe1..faac5d9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies viewport stick-to-bottom behavior when prompt has space below editable area.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/console/worker-eval-contains-stack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/console/worker-eval-contains-stack-expected.txt index d5477ea..9fea4da 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/console/worker-eval-contains-stack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/console/worker-eval-contains-stack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests exception message from eval on worker context in console contains stack trace. function foo()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/cookie-resource-match-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/cookie-resource-match-expected.txt index 2dc129c..4fee7ee1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/cookie-resource-match-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/cookie-resource-match-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cookies are matched up with resources correctly. [0,2,4,6,8,10,12,14]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/copy-network-request-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/copy-network-request-expected.txt index 390376cbd..357ffa1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/copy-network-request-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/copy-network-request-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests curl command generation cURL Windows: curl "http://example.org/path" --compressed
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-repeated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-repeated-expected.txt index 3553bb4..3888a6fe 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-repeated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-repeated-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the coverage list view after finishing recording in the Coverage view. Initial
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-expected.txt index 8cd67b1..bf37f4d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the coverage list view after finishing recording in the Coverage view. .../devtools/coverage/resources/coverage.js JS (coarse) used: 411 unused: 157 total: 568
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-filter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-filter-expected.txt index be6ff9b..6e4b6321 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-filter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/coverage-view-filter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the filter is properly applied to coverage list view. Filter: devtools
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/decorations-after-script-formatter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/decorations-after-script-formatter-expected.txt index 665308d..4effee6d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/decorations-after-script-formatter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/decorations-after-script-formatter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the gutter decorations in target source code after ScriptFormatterEditorAction 0: + function outer(index) {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-css-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-css-expected.txt index ef188e3f..af136ee 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-css-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-css-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the coverage highlight in sources after the recording finishes. 0: + body {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-html-expected.txt index 81c1266..e12d605 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the coverage highlight in sources after the recording finishes. 0: <html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-js-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-js-expected.txt index 11c1df8..340ce7eb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-js-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/gutter-js-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the coverage highlight in sources after the recording finishes. 0: + function outer(index) {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/multiple-instances-merge-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/multiple-instances-merge-expected.txt index 5b46229..f21ac85 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/multiple-instances-merge-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/multiple-instances-merge-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the coverage list view after finishing recording in the Coverage view. .../devtools/coverage/resources/coverage.js JS used: 389 unused: 179 total: 568
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/reveal-autoformat-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/reveal-autoformat-expected.txt index c1dfdd3..c66bfa3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/reveal-autoformat-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/reveal-autoformat-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the CSS highlight in sources after the Pretty print formatting. The below should be formatted
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/segments-merge-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/segments-merge-expected.txt index 82930a96..54be031 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/segments-merge-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/coverage/segments-merge-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the merge of disjoint segment lists in CoverageModel. A: []
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-inline-warning-contains-stacktrace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-inline-warning-contains-stacktrace-expected.txt index efb370e..b3f2da2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-inline-warning-contains-stacktrace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-inline-warning-contains-stacktrace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test injects an inline script from JavaScript. The resulting console error should contain a stack trace. Message[0]: csp-inline-warning-contains-stacktrace.js:18 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-CihokcEcBW4atb/CW/XWsvWwbTjqwQlE9nj9ii5ww5M='), or a nonce ('nonce-...') is required to enable inline execution.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setInterval-warning-contains-stacktrace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setInterval-warning-contains-stacktrace-expected.txt index a18a0bff..f1c3a3ce 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setInterval-warning-contains-stacktrace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setInterval-warning-contains-stacktrace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test should trigger a CSP violation by attempting to evaluate a string with setInterval. Message[0]: csp-setInterval-warning-contains-stacktrace.js:16 Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' 'unsafe-inline'".
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setTimeout-warning-contains-stacktrace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setTimeout-warning-contains-stacktrace-expected.txt index bfbfa71..b3a7b37d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setTimeout-warning-contains-stacktrace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/csp/csp-setTimeout-warning-contains-stacktrace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test should trigger a CSP violation by attempting to evaluate a string with setTimeout. Message[0]: csp-setTimeout-warning-contains-stacktrace.js:16 Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' 'unsafe-inline'".
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/database-table-name-excaping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/database-table-name-excaping-expected.txt index c962e8b..5b3620c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/database-table-name-excaping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/database-table-name-excaping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how table names are escaped in database table view. Original value: table-name-with-dashes-and-"quotes"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/debugger/fetch-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/debugger/fetch-breakpoints-expected.txt index f4346b08..d55f267d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/debugger/fetch-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/debugger/fetch-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fetch() breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-responsive-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-responsive-expected.txt index a3d3515..e9cd4cc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-responsive-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-responsive-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that device mode's responsive mode behaves correctly when adjusting inputs.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-switching-devices-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-switching-devices-expected.txt index 2fa69ec..7f3e3e7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-switching-devices-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-switching-devices-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test preservation of orientation and scale when that switching devices in device mode.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-toolbar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-toolbar-expected.txt index 9145782f..b1e5585 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-toolbar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-toolbar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test toolbar state when switching modes. Type: None, Device: <no device>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt index 1f23e94..d635351 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test device orientation
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/diff-module-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/diff-module-expected.txt index 1ed9f51..c2618bf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/diff-module-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/diff-module-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the Diff module correctly diffs things.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/domdebugger/domdebugger-getEventListeners-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/domdebugger/domdebugger-getEventListeners-expected.txt index ccdd46b..df086dc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/domdebugger/domdebugger-getEventListeners-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/domdebugger/domdebugger-getEventListeners-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests RemoteObject.eventListeners.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/php-highlighter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/php-highlighter-expected.txt index e639673..8167f21 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/php-highlighter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/php-highlighter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that php highlighter loads successfully. Mode loaded: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-accessibility-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-accessibility-expected.txt index d9a4f40..3b45336 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-accessibility-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-accessibility-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that the text editor can be read by assistive technology. Without line wrapping:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-auto-whitespace-removing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-auto-whitespace-removing-expected.txt index 542f532..80ac5ae 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-auto-whitespace-removing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-auto-whitespace-removing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that auto-appended spaces are removed on consequent enters. function (){}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-block-indent-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-block-indent-expected.txt index a20c583..ff512271 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-block-indent-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-block-indent-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies applied indentation whenever you hit enter in "{|}" or type in "}" while inside opened block. {} {}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-char-to-coordinates-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-char-to-coordinates-expected.txt index c6ff113..67b4159 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-char-to-coordinates-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-char-to-coordinates-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test editor cursorPositionToCoordinates and coordinatesToCursorPosition API
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-1-expected.txt index 53a0b28..14232ee 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies Ctrl-D functionality, which selects next occurrence of word. function wordData() {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-2-expected.txt index 253eab6a..8a242014 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-ctrl-d-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies Ctrl-D functionality, which selects next occurrence of word. function wordData() {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-enter-behaviour-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-enter-behaviour-expected.txt index c4ff696b..ce570e4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-enter-behaviour-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-enter-behaviour-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks text editor enter behaviour.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-formatter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-formatter-expected.txt index 4a0ae66c..ba28eb99 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-formatter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-formatter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks text editor javascript formatting. /**
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-goto-matching-bracket-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-goto-matching-bracket-expected.txt index 49ac693..33b4463 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-goto-matching-bracket-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-goto-matching-bracket-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies editor's "Goto Matching Bracket" behavior, which is triggered via Ctrl-M shortcut. function MyClass(a, b)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-home-button-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-home-button-expected.txt index 25dbe35..13d9b22 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-home-button-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-home-button-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that home button triggers selection between first symbol of the line and first non-blank symbol of the line. function foo()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-indent-autodetection-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-indent-autodetection-expected.txt index 9e103f3f..2a34348a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-indent-autodetection-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-indent-autodetection-expected.txt
@@ -1,9 +1,11 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks text editor indent autodetection functionality --------------TEST 1-------------- function foo() { return 42; } + --------------TEST 2-------------- console.log("Hello!"); --------------TEST 3-------------- @@ -29,6 +31,7 @@ function foo() { return 42; } + --------------TEST 4-------------- function MyClass() { @@ -52,6 +55,7 @@ } }, } + --------------TEST 5-------------- a a @@ -60,11 +64,13 @@ b c c + --------------TEST 6-------------- tab tab tab tab + --------------TEST 7-------------- (empty content) --------------TEST 8-------------- function foo() {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-line-breaks-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-line-breaks-expected.txt index 54cda23..acfee43 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-line-breaks-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-line-breaks-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that line endings are inferred from the initial text content, not incremental editing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-mark-clean-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-mark-clean-expected.txt index a7b4aec..676e539 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-mark-clean-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-mark-clean-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks TextEditorModel.markClean/isClean methods
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-reveal-line-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-reveal-line-expected.txt index f3b2476..52e3fe7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-reveal-line-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-reveal-line-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that text editor's revealLine centers line where needed. ======= Revealing line: 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-replace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-replace-expected.txt index 4ae439b7..d8839d9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-replace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-replace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the search replace functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-switch-editor-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-switch-editor-expected.txt index fe7e1bb4..93c3a25 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-switch-editor-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-switch-editor-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that switching editor tabs after searching does not affect editor selection and viewport. Performing search...
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-selection-to-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-selection-to-search-expected.txt index cbc0cd4..07668f1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-selection-to-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-selection-to-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests synchronizing the search input field to the editor selection. Search controller: 'return'
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-smart-braces-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-smart-braces-expected.txt index c2d46de5..78afae85 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-smart-braces-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-smart-braces-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks text editor smart braces functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-token-at-position-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-token-at-position-expected.txt index 8470eeab..22137bb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-token-at-position-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-token-at-position-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test editor tokenAtTextPosition method.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-word-jumps-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-word-jumps-expected.txt index 73c11b0..5259b3b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-word-jumps-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-word-jumps-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks how text editor handles different movements: ctrl-left, ctrl-right, ctrl-shift-left, ctrl-backspace, alt-left, alt-right, alt-shift-left, alt-shift-right. function testFunction(foo, bar)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/autocomplete-attribute-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/autocomplete-attribute-expected.txt index 14f366a..116734c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/autocomplete-attribute-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/autocomplete-attribute-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that autocompletions are computed correctly when editing the ARIA pane.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/edit-aria-attributes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/edit-aria-attributes-expected.txt index 573a4721..86fb0b6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/edit-aria-attributes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/accessibility/edit-aria-attributes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that writing an ARIA attribute causes the accessibility node to be updated. === Before attribute modification ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/attribute-modified-ns-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/attribute-modified-ns-expected.txt index 2b7626c..5bf9790 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/attribute-modified-ns-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/attribute-modified-ns-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon changing the attribute with namespace.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/bidi-dom-tree-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/bidi-dom-tree-expected.txt index e76e5be..b9ed9cda 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/bidi-dom-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/bidi-dom-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel correctly displays DOM tree structure for bi-di pages. <!doctype html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/breadcrumb-updates-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/breadcrumb-updates-expected.txt index 595d684..431561f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/breadcrumb-updates-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/breadcrumb-updates-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breadcrumbs are updated upon involved element's attribute changes in the Elements panel. Original breadcrumb:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/classes-pane-widget-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/classes-pane-widget-expected.txt index 1c92ae4..a547ae1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/classes-pane-widget-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/classes-pane-widget-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that classes pane widget shows correct suggestions.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-rule-hover-highlights-selectors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-rule-hover-highlights-selectors-expected.txt index a72976f..395e82c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-rule-hover-highlights-selectors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-rule-hover-highlights-selectors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Running: setupProxyOverlay
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/color-swatch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/color-swatch-expected.txt index a7e41fa..a8539b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/color-swatch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/color-swatch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that swatches for var() functions are updated as CSS variable is changed. Before css Variable editing: "color" swatch:red
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/defined-css-variables-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/defined-css-variables-expected.txt index 2981203..cf0552ff 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/defined-css-variables-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/defined-css-variables-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that CSS variables are defined correctly wrt DOM inheritance matchedStyles.availableCSSVariables() element.style
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-css-variables-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-css-variables-expected.txt index cd84545..1675501b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-css-variables-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-css-variables-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that CSS variables are resolved inside cascade matchedStyles.computeCSSVariable() --foo === active-foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-inherited-css-variables-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-inherited-css-variables-expected.txt index b2a8ec3..4fec5449 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-inherited-css-variables-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/css-variables/resolve-inherited-css-variables-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that CSS variables are resolved properly for DOM inheritance compute "var(--color)" for element.style: blue compute "var(--color)" for span: blue
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-agent-query-selector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-agent-query-selector-expected.txt index b240b062..2b9d8f1b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-agent-query-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-agent-query-selector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOMAgent.querySelector and DOMAgent.querySelectorAll.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-search-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-search-crash-expected.txt index 79a14e8f..3330784 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-search-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-search-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel search is not crashing on documentElement-less cases.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html-expected.txt index f68af71..a47f5bd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that HTML editor hides only when focusing another element
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/delete-from-document-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/delete-from-document-expected.txt index 3df7d27..e20cef7e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/delete-from-document-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/delete-from-document-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that removing child from the document is handled properly in the elements panel. Before remove doctype
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-1-expected.txt index a816c79..60f930b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate DOM by means of elements panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-2-expected.txt index c506362..c944eb44 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate DOM by means of elements panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-3-expected.txt index fc2e802..f34731c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate DOM by means of elements panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-4-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-4-expected.txt index 9486865..7802cf5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-4-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-4-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate DOM by means of elements panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-1-expected.txt index 14492436..16e546d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate author shadow DOM by means of elements panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-2-expected.txt index 9a2e52c4..02676a5a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-dom-actions-shadow-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate author shadow DOM by means of elements panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-style-attribute-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-style-attribute-expected.txt index 0dc12b1..3f56bb3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-style-attribute-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-style-attribute-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that style modification generates attribute updated event only when attribute is actually changed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-trimmed-attribute-value-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-trimmed-attribute-value-expected.txt index 00d888c..d1d2b3e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-trimmed-attribute-value-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/edit-trimmed-attribute-value-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that user can mutate DOM by means of elements panel. Original textContent
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/insert-node-collapsed-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/insert-node-collapsed-expected.txt index 17f5fe8..72660b5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/insert-node-collapsed-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/insert-node-collapsed-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates hasChildren flag upon adding children to collapsed nodes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/perform-undo-undo-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/perform-undo-undo-expected.txt index 59a51cb..33384a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/perform-undo-undo-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/perform-undo-undo-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that client can call undo multiple times with non-empty history. ========= Original ========
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/remove-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/remove-node-expected.txt index 948667f..3af7c8a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/remove-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/remove-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon node removal.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-expected.txt index 4521ad50f..50c56d6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon setting attribute.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-non-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-non-html-expected.txt index 0cf94702..3f788d8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-non-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-attribute-non-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon setting attribute on non HTML elements. PASSes if there is no crash.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-2-expected.txt index 160d5f8..f05ddd4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOMAgent.setOuterHTML protocol method (part 2).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-body-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-body-expected.txt index 34dc284..14e107a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-body-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-body-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOMAgent.setOuterHTML invoked on body tag. See https://bugs.webkit.org/show_bug.cgi?id=62272.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-expected.txt index f2c30a0..b472e0a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOMAgent.setOuterHTML protocol method.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-for-xhtml-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-for-xhtml-expected.txt index 9ba3865..9decc75 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-for-xhtml-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-for-xhtml-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOMAgent.setOuterHTML protocol method against an XHTML document.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/shadow-dom-modify-chardata-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/shadow-dom-modify-chardata-expected.txt index d9ad90a..7df350d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/shadow-dom-modify-chardata-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/shadow-dom-modify-chardata-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates shadow dom tree structure upon typing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/switch-panels-while-editing-as-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/switch-panels-while-editing-as-html-expected.txt index e2554ca..927dd85f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/switch-panels-while-editing-as-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/switch-panels-while-editing-as-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies inspector doesn't break when switching panels while editing as HTML. crbug.com/485457
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-2-expected.txt index c9e5e52..99ec825 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that DOM modifications done in the Elements panel are undoable (Part 2).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-expected.txt index 5b52bfb..a437840f0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-dom-edits-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that DOM modifications done in the Elements panel are undoable.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-2-expected.txt index 4d3ea90..c63d43dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests undo for the DOMAgent.setOuterHTML protocol method (part 2).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-expected.txt index c974f94..49df65e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/undo-set-outer-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests undo for the DOMAgent.setOuterHTML protocol method.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-child-node-count-mismatch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-child-node-count-mismatch-expected.txt index 225d048..9fb4610 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-child-node-count-mismatch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-child-node-count-mismatch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Elements properly populate and select after immediate updates crbug.com/829884 BEFORE: children: null, childNodeCount: 2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-css-path-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-css-path-expected.txt index 939166d4..1bcf053 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-css-path-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-css-path-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOMNode.cssPath() html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-delete-inline-style-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-delete-inline-style-expected.txt index f4feac6..c5a1c69 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-delete-inline-style-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-delete-inline-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the "style" attribute removal results in the Styles sidebar pane update (not a crash). Bug 51478 Before style property removal:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-hide-html-comments-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-hide-html-comments-expected.txt index 548c863..e87df99 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-hide-html-comments-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-hide-html-comments-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies show/hide HTML comments setting. HTML comments shown:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-iframe-base-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-iframe-base-url-expected.txt index 9cd9e05..001ed9df 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-iframe-base-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-iframe-base-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that nodes have correct baseURL, documentURL. #document has no parent.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-img-tooltip-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-img-tooltip-expected.txt index 24066c2..753e15b6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-img-tooltip-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-img-tooltip-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the tooltip for the image on hover. PASSED, image dimensions for tooltip: 215x174.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-inspect-iframe-from-different-domain-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-inspect-iframe-from-different-domain-expected.txt index 8e115bb80..0eed526 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-inspect-iframe-from-different-domain-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-inspect-iframe-from-different-domain-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that web inspector can select element in an iframe even if the element was created via createElement of document other than iframe's document. Bug 60031 PASS: selected node with id 'main-frame-div'
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-linkify-attributes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-linkify-attributes-expected.txt index 857a8ba9..6420f64 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-linkify-attributes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-linkify-attributes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that you can click and hover on links in attributes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-correct-case-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-correct-case-expected.txt index 61915a8..7732234d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-correct-case-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-correct-case-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel shows all types of elements in the correct case. <!doctype html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-limited-children-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-limited-children-expected.txt index 3c4b52c..4c5bf6a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-limited-children-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-limited-children-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that src and href element targets are rewritten properly. =========== Loaded 5 children ===========
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-reload-assert-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-reload-assert-expected.txt index 61d7cd2..f85fa0f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-reload-assert-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-reload-assert-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the inspected page does not crash in a debug build when reloading a page containing shadow DOM with open inspector. Bug 84154. https://bugs.webkit.org/show_bug.cgi?id=84154 Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-restore-selection-when-node-comes-later-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-restore-selection-when-node-comes-later-expected.txt index f024bfc..716df3f1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-restore-selection-when-node-comes-later-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-restore-selection-when-node-comes-later-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that last selected element is restored properly later, even if it failed to do so once.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-rewrite-href-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-rewrite-href-expected.txt index 49e9a97..85d7714 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-rewrite-href-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-rewrite-href-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that src and href element targets are rewritten properly. javascript:alert('foo')
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-search-expected.txt index 995741c9..3ecc7234 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel search is returning proper results.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-after-delete-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-after-delete-expected.txt index 1fe9a51..eaf476c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-after-delete-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-after-delete-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel correctly updates selection on node removal.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-on-refresh-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-on-refresh-expected.txt index b7756b1..ba8bc78 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-on-refresh-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-on-refresh-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel preserves selected node on page refresh. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-structure-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-structure-expected.txt index 87d54b01..b04121dc2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-structure-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-structure-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel shows DOM tree structure. <!doctype html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-styles-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-styles-expected.txt index 7502a99e..b2bcf23 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-styles-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-styles-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel shows proper styles in the sidebar panel. border-bottom-left-radius: 5px;
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-tab-stops-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-tab-stops-expected.txt index 58b01693..cebd684 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-tab-stops-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-tab-stops-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests what elements have focus after pressing tab. DIV#tab-Styles:Styles
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-treeoutline-copy-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-treeoutline-copy-expected.txt index cd4196e..34949dc0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-treeoutline-copy-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-treeoutline-copy-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that nodes can be copied in ElementsTreeOutline. <span id="node-to-copy">This should be <b>copied</b>.</span>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-custom-framework-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-custom-framework-expected.txt index 07639ca8..055a4b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-custom-framework-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-custom-framework-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests framework event listeners output in the Elements sidebar panel. == Incorrect fetchers
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-expected.txt index 58208d2..ee7739f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listeners output in the Elements sidebar panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery1-expected.txt index 503c1777..84b386e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listeners output in the Elements sidebar panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery2-expected.txt index c03a22066f8..93f4c033 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listeners output in the Elements sidebar panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-remove-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-remove-expected.txt index 381809d..044c9548 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-remove-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-remove-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests removing event listeners in the Elements sidebar panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-about-blank-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-about-blank-expected.txt index 1ea4a89..14fcb021 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-about-blank-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-about-blank-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listeners output in the Elements sidebar panel when the listeners are added on an element in about:blank page.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-framework-with-service-worker-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-framework-with-service-worker-expected.txt index 6787f4fe..ef80089 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-framework-with-service-worker-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listeners-framework-with-service-worker-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests framework event listeners output in Sources panel when service worker is present. Selecting service worker thread
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/expand-recursively-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/expand-recursively-expected.txt index 3515b92..c4a1fdba 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/expand-recursively-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/expand-recursively-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that expanding elements recursively works. ===== Initial state of tree outline =====
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/hide-shortcut-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/hide-shortcut-expected.txt index 9b5deac..253519787 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/hide-shortcut-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/hide-shortcut-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the hide shortcut, which toggles visibility:hidden on the node and it's ancestors. Bug 110641
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-grid-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-grid-expected.txt index 062d571f..4faa39d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-grid-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-grid-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies the position and size of the highlight rectangles overlayed on an inspected CSS grid div. paddedGrid{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-expected.txt index 45f4c82..1e4c5dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Highlight CSS shapes. circle{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-scroll-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-scroll-expected.txt index 3117182..b53f0a7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-scroll-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-css-shapes-outside-scroll-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Highlight CSS shapes outside scroll. circle{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-dom-updates-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-dom-updates-expected.txt index c6d5ebb..e6de8661 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-dom-updates-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-dom-updates-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOM update highlights in the DOM tree.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-expected.txt index def655f..dd558f4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies the position and size of the highlight rectangles overlayed on an inspected div. inspectedElement{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-and-scrolled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-and-scrolled-expected.txt index 22767c7..45c8c14 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-and-scrolled-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-and-scrolled-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. div{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-expected.txt index ca46c886..f03a001 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scaled-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. div{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scroll-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scroll-expected.txt index 11aa8a4..482361a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scroll-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-scroll-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies the position and size of the highlight rectangles overlayed on an inspected div in the scrolled view. inspectedElement1{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-transformed-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-transformed-expected.txt index 7b66dbb..c4865a8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-transformed-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-node-transformed-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. div{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-content-inside-iframe-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-content-inside-iframe-expected.txt index deb37ea5..b5d4a6b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-content-inside-iframe-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-content-inside-iframe-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. svg-rect{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-expected.txt index 17c8f5c..243ce7b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies the position and size of the highlight rectangles overlayed on an SVG root element. svg-root{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-zoomed-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-zoomed-expected.txt index 91fdca77..f2a0ee05 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-zoomed-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-svg-root-zoomed-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies the position and size of the highlight rectangles overlayed on an SVG root element when the page is zoomed. svg-root{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/html-link-import-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/html-link-import-expected.txt index abb6264b..1dc5742 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/html-link-import-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/html-link-import-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that imported document is rendered within the import link. - <html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/iframe-load-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/iframe-load-event-expected.txt index 709d06a..c92a7de 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/iframe-load-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/iframe-load-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that iframe content is available after iframe's load event fired. See http://webkit.org/b/76552
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inline-style-title-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inline-style-title-expected.txt index 6b01f2b..043cadd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inline-style-title-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inline-style-title-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that external change of inline style element updates its title. === initial inline style text ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/insert-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/insert-node-expected.txt index 60f61ddf..b243385 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/insert-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/insert-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon node insertion.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-after-profiling-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-after-profiling-expected.txt index f99a3620..f1a1a84 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-after-profiling-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-after-profiling-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect mode works after profiling start/stop. Node selected: inspected
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-shadow-text-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-shadow-text-expected.txt index 161f366a..9e4e620 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-shadow-text-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-mode-shadow-text-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that devtools can inspect text element under shadow root. Node selected: host
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pointer-events-none-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pointer-events-none-expected.txt index 9f81702..9484c54 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pointer-events-none-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pointer-events-none-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that Web Inspector can inspect element with pointer-events:none. PASS: selected node with id 'inner'
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pseudo-element-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pseudo-element-expected.txt index 6c61d5ac..b09b5189a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pseudo-element-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/inspect-pseudo-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test Selected node pseudo type: before
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/modify-chardata-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/modify-chardata-expected.txt index 9020d616..653d7a6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/modify-chardata-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/modify-chardata-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon changes to characters.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/move-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/move-node-expected.txt index faf00775..ff75985 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/move-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/move-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests elements drag and drop operation internals, verifies post-move selection.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/navigate-styles-sidebar-with-arrow-keys-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/navigate-styles-sidebar-with-arrow-keys-expected.txt index 5da8cfb..f9d34d95 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/navigate-styles-sidebar-with-arrow-keys-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/navigate-styles-sidebar-with-arrow-keys-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that styles sidebar can be navigated with arrow keys. Editing: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-reselect-on-append-child-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-reselect-on-append-child-expected.txt index 6569487..2a86baf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-reselect-on-append-child-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-reselect-on-append-child-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies that SelectedNodeChanged event is not fired whenever a child gets added to the node.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-xpath-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-xpath-expected.txt index fec5d5fe..08d4420 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-xpath-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/node-xpath-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests node xPath construction '#document':'' - '/'
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-alien-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-alien-node-expected.txt index 211de28..4500ac4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-alien-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-alien-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resolveNode from alien document does not crash. https://bugs.webkit.org/show_bug.cgi?id=71806. Alien node should resolve to null: null
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-node-blocked-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-node-blocked-expected.txt index 51acd479..3d055f8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-node-blocked-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/resolve-node-blocked-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that JS object to node resolution still works even if script evals are prohibited by Content-Security-Policy. The test passes if it doesn't crash. Bug 78705. didReceiveDocumentObject
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/reveal-whitespace-text-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/reveal-whitespace-text-node-expected.txt index 8d4373a2..95b3dcd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/reveal-whitespace-text-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/reveal-whitespace-text-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that revealing a whitespace text node RemoteObject reveals its parentElement DIV. SelectedNodeChanged: div
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/selected-element-changes-execution-context-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/selected-element-changes-execution-context-expected.txt index 546629d5..bd4ae0b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/selected-element-changes-execution-context-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/selected-element-changes-execution-context-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the execution context is changed to match new selected node.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/breadcrumb-shadow-roots-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/breadcrumb-shadow-roots-expected.txt index 4103e917..72138f3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/breadcrumb-shadow-roots-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/breadcrumb-shadow-roots-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that shadow roots are displayed correctly in breadcrumbs. User-agent shadow root breadcrumb:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/create-shadow-root-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/create-shadow-root-expected.txt index 0a633f6..2007ed1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/create-shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/create-shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon shadow root creation.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-1-expected.txt index f97bf40..2b7c794 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel preserves selected shadow DOM node on page refresh.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-2-expected.txt index 2fdc0f1f..116b9a0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel preserves selected shadow DOM node on page refresh.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-3-expected.txt index d9b1664d..2842454 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel preserves selected shadow DOM node on page refresh.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-deep-shadow-element-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-deep-shadow-element-expected.txt index 802d33a..bcbb9cb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-deep-shadow-element-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-deep-shadow-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect element action works for deep shadow elements. /html/body/div/div/div//div/div/span
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-slot-not-in-shadow-tree-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-slot-not-in-shadow-tree-expected.txt index 4655c2c..f6e87bd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-slot-not-in-shadow-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/inspect-slot-not-in-shadow-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that slots that are not in a shadow tree can be inspected. Inspect successful
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/reveal-shadow-dom-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/reveal-shadow-dom-node-expected.txt index ad7be1e..3d7b93e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/reveal-shadow-dom-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/reveal-shadow-dom-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that the correct node is revealed in the DOM tree when asked to reveal a user-agent shadow DOM node. User-agent shadow DOM hidden:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-distribution-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-distribution-expected.txt index 6db52df7..3cce1d0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-distribution-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-distribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel updates dom tree structure upon distribution in shadow dom. @@ -100,10 +101,10 @@ - <div id="host1"> - #shadow-root (open) - <slot id="slot1" name="slot1"> - ↪ <span> ↪ <h2> </slot> - <slot id="slot2" name="slot2"> + ↪ <span> ↪ <h1> </slot> - <slot id="slot3"> @@ -120,14 +121,14 @@ - <div id="host1"> - #shadow-root (open) - <slot id="slot1" name="slot1"> - ↪ <span> + ↪ <h2> </slot> - <slot id="slot2" name="slot2"> + ↪ <span> ↪ <h1> </slot> - <slot id="slot3"> ↪ <div> - ↪ <h2> </slot> <span id="child1" slot="slot1"></span> <div id="child2"></div> @@ -140,14 +141,14 @@ - <div id="host1"> - #shadow-root (open) - <slot id="slot1" name="slot3"> - ↪ <h3> + ↪ <h2> </slot> - <slot id="slot2" name="slot2"> + ↪ <span> ↪ <h1> </slot> - <slot id="slot3"> ↪ <div> - ↪ <h2> </slot> <span id="child1" slot="slot1"></span> <div id="child2"></div> @@ -160,14 +161,14 @@ - <div id="host1"> - #shadow-root (open) - <slot id="slot1" name="slot3"> - ↪ <h3> + ↪ <h2> </slot> - <slot id="slot2" name="slot1"> ↪ <span> + ↪ <h1> </slot> - <slot id="slot3"> ↪ <div> - ↪ <h2> </slot> <span id="child1" slot="slot1"></span> <div id="child2"></div> @@ -246,10 +247,10 @@ - <div id="host1"> - #shadow-root (open) - <slot id="slot2" name="slot1"> - ↪ <h2> </slot> - <slot id="slot3"> ↪ <div> + ↪ <h2> </slot> <div id="child2"></div> <h2 id="child4" slot="slot1"></h2>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-host-display-modes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-host-display-modes-expected.txt index dd262d6..308c474 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-host-display-modes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-host-display-modes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that distributed nodes and their updates are correctly shown in different shadow host display modes. ========= Original ========
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-root-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-root-expected.txt index 9b4ecdd4..eeeccab 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-root-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/shadow-root-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that author shadow root's #document-fragment is displayed and user-agent one is hidden by default. - <div id="container">
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/update-shadowdom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/update-shadowdom-expected.txt index 9ad5899..8f481e2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/update-shadowdom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/shadow/update-shadowdom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test confirms that updating the shadow dom is reflected to the Inspector. - <div id="container">
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-inline-style-csp-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-inline-style-csp-expected.txt index 88b2abe..4d56a0197 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-inline-style-csp-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-inline-style-csp-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule does not crash the renderer and modifying an inline style does not report errors when forbidden by Content-Security-Policy.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-invalid-selector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-invalid-selector-expected.txt index bb0a5e1..c7a602e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-invalid-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-invalid-selector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule with invalid selector works as expected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard-expected.txt index 67bac53..e45b68ea 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule works properly with user input. Is editing? true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-with-style-after-body-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-with-style-after-body-expected.txt index 51a5349e..69fbf81 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-with-style-after-body-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/add-new-rule-with-style-after-body-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule works when there is a STYLE element after BODY. TIMEOUT SHOULD NOT OCCUR! Bug 111299 https://bugs.webkit.org/show_bug.cgi?id=111299 After adding new rule:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/background-parsing-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/background-parsing-crash-expected.txt index 2680e84..41232fc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/background-parsing-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/background-parsing-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test passes if it doesn't ASSERT.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cached-sync-computed-styles-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cached-sync-computed-styles-expected.txt index 5e7be13e..fd30e9f92 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cached-sync-computed-styles-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cached-sync-computed-styles-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that computed styles are cached across synchronous requests. # of backend calls sent [2 requests]: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/case-sensitive-suggestions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/case-sensitive-suggestions-expected.txt index bccec65..284efa6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/case-sensitive-suggestions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/case-sensitive-suggestions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that text prompt suggestions' casing follows that of the user input.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-aware-property-value-edit-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-aware-property-value-edit-expected.txt index 51cd6954e1..5131969 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-aware-property-value-edit-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-aware-property-value-edit-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that property value being edited uses the user-specified color format.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-nicknames-lowercase-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-nicknames-lowercase-expected.txt index 5baf68fd..944683e4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-nicknames-lowercase-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-nicknames-lowercase-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that all color nicknames are lowercase to facilitate lookup PASSED
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-swatch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-swatch-expected.txt index 9373b97..3bf458ed 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-swatch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/color-swatch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The patch verifies that color swatch functions properly in matched and computed styles. crbug.com/461363
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-expected.txt index 6c42192..76234629 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that renaming a selector updates element styles. Bug 70018. https://bugs.webkit.org/show_bug.cgi?id=70018 === Before selector modification ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-mark-matching-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-mark-matching-expected.txt index 67d604080..f5b75749 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-mark-matching-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/commit-selector-mark-matching-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that matching selectors are marked properly after new rule creation and selector change.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-live-edit-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-live-edit-expected.txt index a6f73e4b..6aadca4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-live-edit-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-live-edit-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that styles are updated when live-editing css resource.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-outline-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-outline-expected.txt index 95e6693fe..28bb33a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-outline-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/css-outline-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies the CSS outline functionality. {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cssom-media-insert-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cssom-media-insert-crash-expected.txt index 507c282..4389cf9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cssom-media-insert-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/cssom-media-insert-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the inspected page does not crash after inspecting element with CSSOM added rules. Bug 373508 crbug.com/373508 [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update-expected.txt index 085a900b..634e7d7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that style property disablement is propagated into the stylesheet UISourceCode working copy.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/dynamic-style-tag-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/dynamic-style-tag-expected.txt index b18a0e4..19ab5520 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/dynamic-style-tag-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/dynamic-style-tag-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that different types of inline styles are correctly disambiguated and their sourceURL is correct. Stylesheet added:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-inspector-stylesheet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-inspector-stylesheet-expected.txt index 38eee3c0..73d6a8b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-inspector-stylesheet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-inspector-stylesheet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule creates inspector stylesheet resource and allows its live editing. Inspector stylesheet URL: inspector-stylesheet
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-media-text-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-media-text-expected.txt index 46bb6c3..b519cd49 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-media-text-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-media-text-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that editing media text updates element styles. === Before media text modification ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-name-with-trimmed-value-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-name-with-trimmed-value-expected.txt index 19caa2b..7cf3184 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-name-with-trimmed-value-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-name-with-trimmed-value-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that editing a CSS property name in the Styles pane retains its original, non-trimmed value text. Viewing 'background' value in Styles:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt index bfe3e72..f575476 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that editing sourcecode which is referred by multiple stylesheets (via sourceURL comment) updates all stylesheets. Headers count: 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-inside-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-inside-property-expected.txt index a830743..6b8b2265 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-inside-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-inside-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that property value editing triggers style update in rendering engine. font-size: 119px
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-url-with-color-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-url-with-color-expected.txt index c896881..f0f2f12 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-url-with-color-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-url-with-color-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that colors are not re-formatted inside url(...) when editing property values. rgb(255, 255, 255)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-with-trimmed-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-with-trimmed-url-expected.txt index 23141aa..40abd74 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-with-trimmed-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/edit-value-with-trimmed-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that editing a CSS property value in the Styles pane restores the original, non-trimmed value text. Bug 107936. https://bugs.webkit.org/show_bug.cgi?id=107936 Viewing 'background' value in Styles:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/empty-background-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/empty-background-url-expected.txt index 440b5d3a..f3773d1c4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/empty-background-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/empty-background-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that empty url in the property value does not break inspector. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/filter-matched-styles-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/filter-matched-styles-expected.txt index 0b01cb2..d0c6a7f24 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/filter-matched-styles-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-1/filter-matched-styles-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that filtering in StylesSidebarPane works as expected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/add-import-rule-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/add-import-rule-expected.txt index 2ad324c..80052a51 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/add-import-rule-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/add-import-rule-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding an @import with data URI does not lead to stylesheet collection crbug.com/644719
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/cssom-shorthand-important-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/cssom-shorthand-important-expected.txt index 87c491b..5966fcb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/cssom-shorthand-important-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/cssom-shorthand-important-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CSSOM-modified shorthands are reporting their "important" bits. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/filter-matched-styles-hides-separators-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/filter-matched-styles-hides-separators-expected.txt index 74e1c3a2..28ff0150 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/filter-matched-styles-hides-separators-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/filter-matched-styles-hides-separators-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that filtering in StylesSidebarPane hides sidebar separators.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/force-pseudo-state-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/force-pseudo-state-expected.txt index 4b2c55d3..42abba4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/force-pseudo-state-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/force-pseudo-state-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that forced element state is reflected in the DOM tree and Styles pane.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/get-set-stylesheet-text-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/get-set-stylesheet-text-expected.txt index 6be198bf..793959ce 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/get-set-stylesheet-text-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/get-set-stylesheet-text-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that WebInspector.CSSStyleSheet methods work as expected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/import-pseudoclass-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/import-pseudoclass-crash-expected.txt index 412c59b..77a8ac01 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/import-pseudoclass-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/import-pseudoclass-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that modifying stylesheet text with @import and :last-child selector does not crash (Bug 95324).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inactive-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inactive-properties-expected.txt index eb0d0bd..8baf6e0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inactive-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inactive-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that effectively inactive properties are displayed correctly in the sidebar. display: block;
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inherited-mixed-case-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inherited-mixed-case-properties-expected.txt index e80a48d..1c38ac17 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inherited-mixed-case-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inherited-mixed-case-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that non-standard mixed-cased properties are displayed in the Styles pane. color: rgb(0, 0, 0);
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inject-stylesheet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inject-stylesheet-expected.txt index c31f289..60bfe5b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inject-stylesheet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/inject-stylesheet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that injected user stylesheets are reflected in the Styles pane. Main frame style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/keyframes-rules-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/keyframes-rules-expected.txt index 5c4e1b1..f75ae09 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/keyframes-rules-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/keyframes-rules-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that source data is extracted correctly from stylesheets with @keyframes rules.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/lazy-computed-style-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/lazy-computed-style-expected.txt index 11ffcb8..ff5cb35 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/lazy-computed-style-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/lazy-computed-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that computed styles expand and allow tracing to style rules. ==== All styles (should be no computed) ====
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-emulation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-emulation-expected.txt index 8bd0c87..bb4695f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-emulation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-emulation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that emulated CSS media is reflected in the Styles pane. Original style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-queries-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-queries-expected.txt index 2cfbb11..c8294ff 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-queries-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-queries-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that media query stack is rendered for associated rules. Main style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-using-same-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-using-same-url-expected.txt index f99258c..a79e28b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-using-same-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/media-using-same-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that media query stack is computed correctly when several stylesheets share the same URL. Main style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/metrics-box-sizing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/metrics-box-sizing-expected.txt index c467a12..85aa798 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/metrics-box-sizing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/metrics-box-sizing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that content-box and border-box content area dimensions are handled property by the Metrics pane.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/mixed-case-color-aware-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/mixed-case-color-aware-properties-expected.txt index 59f078c..a552d43 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/mixed-case-color-aware-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/mixed-case-color-aware-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that color-related mix-cased CSS properties are actually color aware. bAckground-ColoR is color aware
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/multiple-imports-edit-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/multiple-imports-edit-crash-expected.txt index e3102ba2..8b4c899 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/multiple-imports-edit-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/multiple-imports-edit-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that modifying stylesheet text with multiple @import at-rules does not crash. Initially added:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/page-reload-update-sidebar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/page-reload-update-sidebar-expected.txt index 3ab1a50..2a46d419 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/page-reload-update-sidebar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/page-reload-update-sidebar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that reloading page during styles sidebar pane editing cancels editing and re-renders the sidebar pane.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-comments-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-comments-expected.txt index d706b43..c88bac3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-comments-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-comments-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that comments in stylesheets are parsed correctly by the DevTools. Main style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-unterminated-comment-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-unterminated-comment-expected.txt index f9cb197a..18d202c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-unterminated-comment-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-unterminated-comment-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CSSParser correctly parses declarations with unterminated comments. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-with-quote-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-with-quote-expected.txt index fdb3dfb..364d726 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-with-quote-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-declaration-with-quote-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CSSParser correctly parses declarations with unterminated strings. Blink bug 231127 [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt index 8bd7152..4d1c871 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that source data are extracted correctly from external stylesheets in UTF-8 with BOM. Bug 59322. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/paste-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/paste-property-expected.txt index 3107f9e..04ed767 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/paste-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/paste-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that splitting properties when pasting works. Before pasting:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/perform-undo-perform-of-mergable-action-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/perform-undo-perform-of-mergable-action-expected.txt index 3f26013..d4c74fed 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/perform-undo-perform-of-mergable-action-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/perform-undo-perform-of-mergable-action-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that perform-undo-perform of the mergeable action does not crash. Initial value
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/property-ui-location-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/property-ui-location-expected.txt index f293232..b08a88b3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/property-ui-location-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/property-ui-location-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies Bindings.cssWorkspaceBinding.propertyUILocation functionality font-family -> source-url.css:2:4
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/pseudo-elements-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/pseudo-elements-expected.txt index 2cc90ff..e504a49 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/pseudo-elements-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/pseudo-elements-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pseudo elements and their styles are handled properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/region-style-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/region-style-crash-expected.txt index 3e4a8b5..db3f28e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/region-style-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/region-style-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that webkit css region styling can be parsed correctly. Test passes if it doesn't crash. color: rgb(255, 0, 0);
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/computed-properties-retain-expanded-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/computed-properties-retain-expanded-expected.txt index f62da1e..6e75f3ad 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/computed-properties-retain-expanded-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/computed-properties-retain-expanded-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that Computed Style preserves property expansion on re-rendering.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/remove-shadow-host-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/remove-shadow-host-expected.txt index eed15eb1..6531963 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/remove-shadow-host-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/remove-shadow-host-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test remove shadow host. Sheet added: data:text/css,#x{color:pink}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-list-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-list-expected.txt index db860a0..4ba9b4a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-list-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-list-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests representation of selector lists in the protocol. Bug 103118. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-source-data-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-source-data-expected.txt index 4bdb4b42..8fc0c73ff 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-source-data-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-source-data-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that WebInspector.CSSStyleSheet methods work as expected. h1: [user-agent] {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/shadow-dom-rules-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/shadow-dom-rules-expected.txt index 75cc7a5..d790822 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/shadow-dom-rules-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/shadow-dom-rules-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that style sheets hosted inside shadow roots could be inspected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/simple-selector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/simple-selector-expected.txt index 309ece1..16aef81 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/simple-selector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/simple-selector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies simple selector behavior. div#foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/spectrum-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/spectrum-expected.txt index ca38f90..0b88c070 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/spectrum-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/spectrum-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ColorPicker.Spectrum --- Testing colorString()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-expected.txt index 19d63c96..252d81d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that autocompletions are computed correctly when editing the Styles pane.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-swatches-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-swatches-expected.txt index f58145c..d15abaf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-swatches-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-autocomplete-swatches-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CSSPropertyPrompt properly builds suggestions. --blue-color
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet-expected.txt index 84d991e..93f0f21 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that rules from imported stylesheets are correctly shown and are editable in inspector. Rules before toggling:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-blank-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-blank-property-expected.txt index 9983c8a6..4ddce2c9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-blank-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-blank-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new blank property works. Before append:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-invalid-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-invalid-property-expected.txt index 056d3c6..dac028e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-invalid-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-invalid-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding an invalid property retains its syntax. Before append:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-colon-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-colon-expected.txt index 0e2aeb29..9743c73 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-colon-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-colon-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule works after switching nodes. After adding new rule (inspected):
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-expected.txt index f94af57..6fe5726 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule works after switching nodes. After adding new rule (inspected): @@ -7,7 +8,6 @@ [expanded] foo, [$div#inspected, $]bar { (inspector-stylesheet:1 -> inspector-stylesheet:1:26) - color: maroon; [expanded] [$div$] { (user agent stylesheet)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-tab-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-tab-expected.txt index 0e2aeb29..7526e3e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-tab-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-tab-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule works after switching nodes. After adding new rule (inspected): @@ -7,7 +8,6 @@ [expanded] foo, [$div#inspected, $]bar { (inspector-stylesheet:1 -> inspector-stylesheet:1:26) - color: maroon; [expanded] [$div$] { (user agent stylesheet)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-to-stylesheet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-to-stylesheet-expected.txt index 01da8e6..7e22e93 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-to-stylesheet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-add-new-rule-to-stylesheet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding new rule in the stylesheet end works as expected. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cancel-editing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cancel-editing-expected.txt index 9ecb2029..327bcdf3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cancel-editing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cancel-editing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that editing is canceled properly after incremental editing. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt index 6a79117..7db702ef 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that changing selected node while editing style does update styles sidebar. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-commit-editing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-commit-editing-expected.txt index 45d1034..89f669d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-commit-editing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-commit-editing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that editing is canceled properly after incremental editing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-computed-trace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-computed-trace-expected.txt index 8a2fe74..a84ba10 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-computed-trace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-computed-trace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that computed styles expand and allow tracing to style rules. ==== Computed style for ID1 ====
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cssom-important-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cssom-important-property-expected.txt index d48b600..138da2a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cssom-important-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-cssom-important-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that !important modifier is shown for CSSOM-generated properties. [expanded] element.style { ()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-inherited-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-inherited-expected.txt index 88213ba..942e8c39 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-inherited-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-inherited-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that disabling inherited style property does not break further style inspection. Before disable
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-property-after-selector-edit-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-property-after-selector-edit-expected.txt index 7fd16f6..87324ee 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-property-after-selector-edit-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-property-after-selector-edit-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that sequence of setting selector and disabling property works.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-change-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-change-expected.txt index c00bd75c..f76a57a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-change-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-change-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that changing a disabled property enables it as well. Before disable
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-delete-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-delete-expected.txt index 5ba9364..0765121 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-delete-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-delete-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that removal of property following its disabling works. Before disable
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-expected.txt index 96b282f..6a587b5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that disabling style property works. Before disable
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-overriden-ua-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-overriden-ua-expected.txt index b30c5017..acd1d32 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-overriden-ua-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-overriden-ua-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that disabling shorthand removes the "overriden" mark from the UA shorthand it overrides. Before disable
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-variables-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-variables-expected.txt index 80aa2ebc..ab7682af 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-variables-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-variables-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that computed styles expand and allow tracing to style rules. ==== Computed style for ID1 ====
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/disable-last-property-without-semicolon-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/disable-last-property-without-semicolon-expected.txt index db8d1e8..2985021 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/disable-last-property-without-semicolon-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/disable-last-property-without-semicolon-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that formatter adds a semicolon when enabling property.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/do-not-rebuild-styles-on-every-change-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/do-not-rebuild-styles-on-every-change-expected.txt index 88e38b2..8d1e6f9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/do-not-rebuild-styles-on-every-change-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/do-not-rebuild-styles-on-every-change-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests show that ssp isn't rebuild on every dom mutation
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/inline-style-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/inline-style-sourcemap-expected.txt index 4a4e87cd..d3a653d5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/inline-style-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/inline-style-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that inline style sourceMappingURL is resolved properly. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/keyframes-source-offsets-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/keyframes-source-offsets-expected.txt index 5ece2c0..ceff7d3d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/keyframes-source-offsets-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/keyframes-source-offsets-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that proper data and start/end offset positions are reported for CSS keyframes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/style-update-during-selector-edit-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/style-update-during-selector-edit-expected.txt index 5e1915b..6f88b58 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/style-update-during-selector-edit-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/style-update-during-selector-edit-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that modification of element styles while editing a selector does not commit the editor. SUCCESS: Styles pane not updated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-do-not-detach-sourcemap-on-edits-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-do-not-detach-sourcemap-on-edits-expected.txt index d9778fe..bc447e96b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-do-not-detach-sourcemap-on-edits-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-do-not-detach-sourcemap-on-edits-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that source map is not detached on edits. crbug.com/257778
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-edit-property-after-invalid-rule-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-edit-property-after-invalid-rule-expected.txt index cb47c43..0c77eaa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-edit-property-after-invalid-rule-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-edit-property-after-invalid-rule-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that proper source lines are reported for the styles after unrecognizer / invalid selector. Initial value
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-formatting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-formatting-expected.txt index d2b4787..77afb9ac 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-formatting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-formatting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that InspectorCSSAgent formats the CSS style text based on the CSS model modifications.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-iframe-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-iframe-expected.txt index fcc1fcc..05bfe1b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-iframe-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-iframe-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that proper (and different) styles are returned for body elements of main document and iframe. Main frame style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-inline-element-style-changes-should-not-force-style-recalc-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-inline-element-style-changes-should-not-force-style-recalc-expected.txt index b14da071d..a5e270b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-inline-element-style-changes-should-not-force-style-recalc-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-inline-element-style-changes-should-not-force-style-recalc-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspector doesn't force styles recalc on operations with inline element styles that result in no changes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-invalid-color-values-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-invalid-color-values-expected.txt index b161fd8..92446b47 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-invalid-color-values-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-invalid-color-values-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the displayed string for colors correctly handles clipped CSS values and RGB percentages.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-cssom-injected-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-cssom-injected-expected.txt index eeffce3..34eb342 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-cssom-injected-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-cssom-injected-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspecting keyframes injected via CSSOM doesn't crash.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-expected.txt index fbff4ec..d05368b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that keyframes are shown in styles pane. === Before key modification ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-live-locations-leak-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-live-locations-leak-expected.txt index 2d0a886..fda960a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-live-locations-leak-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-live-locations-leak-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that styles sidebar pane does not leak any LiveLocations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-new-API-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-new-API-expected.txt index 348c0b4c..5a6fa873 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-new-API-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-new-API-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that InspectorCSSAgent API methods work as expected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overloaded-shorthand-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overloaded-shorthand-expected.txt index 74a30032..43a11d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overloaded-shorthand-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overloaded-shorthand-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that shorthand is marked as overloaded if all its longhands are overloaded. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overriden-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overriden-properties-expected.txt index 04bd8b8..2620a1a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overriden-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-overriden-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that overriding shorthands within rule are visible. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-properties-overload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-properties-overload-expected.txt index aa0e98a..7fe5ee7d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-properties-overload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-properties-overload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that inspector figures out overloaded properties correctly. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-rerequest-sourcemap-on-watchdog-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-rerequest-sourcemap-on-watchdog-expected.txt index 083efed..5db3999 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-rerequest-sourcemap-on-watchdog-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-rerequest-sourcemap-on-watchdog-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that the sourceMap is in fact re-requested from network as SASS watchdog updates the CSS file. SourceMap successfully re-requested.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-should-not-force-sync-style-recalc-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-should-not-force-sync-style-recalc-expected.txt index 2942bb5..80c77c8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-should-not-force-sync-style-recalc-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-should-not-force-sync-style-recalc-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspector doesn't force sync layout on operations with CSSOM.Bug 315885.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-expected.txt index 1c07e982..15369ad 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that proper source lines are reported for the parsed styles. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-inline-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-inline-expected.txt index a028a91..b72cf48 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-inline-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-inline-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that elements panel shows proper inline style locations in the sidebar panel. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-recovery-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-recovery-expected.txt index 162e581..f589bc7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-recovery-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-lines-recovery-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that invalid rule inside @-rule doesn't break source code matching (http://crbug.com/317499). [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-offsets-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-offsets-expected.txt index b76437d..09eeb4d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-offsets-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-source-offsets-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that proper data and start/end offset positions are reported for CSS style declarations and properties. body: [0:0-0:4] [0:6-9:0]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-from-js-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-from-js-expected.txt index 257e46e..01707709 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-from-js-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-from-js-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that changes to an inline style and ancestor/sibling className from JavaScript are reflected in the Styles pane and Elements tree.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-1-expected.txt index c0837e7..4626bc4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that links are updated properly when inserting a new property.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-2-expected.txt index f075fb395d..31b763ae7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that links are updated properly when editing selector.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-3-expected.txt index 3c85c62a..c68ac6f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that links are updated properly after disabling property.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-4-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-4-expected.txt index 7c7fc22..bf5b453 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-4-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-update-links-4-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that links are updated property when editing pseudo element property.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-url-linkify-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-url-linkify-expected.txt index 72c4393..06407e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-url-linkify-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-url-linkify-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that URLs are linked to and completed correctly. Bugs 51663, 53171, 62643, 72373, 79905 URLs completed:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-with-spaces-in-sourceURL-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-with-spaces-in-sourceURL-expected.txt index f9e11a8..7422a6f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-with-spaces-in-sourceURL-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-with-spaces-in-sourceURL-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that links for URLs with spaces displayed properly for matched styles. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/stylesheet-source-url-comment-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/stylesheet-source-url-comment-expected.txt index 829e258..20984e2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/stylesheet-source-url-comment-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/stylesheet-source-url-comment-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that stylesheets with sourceURL comment are shown in the Sources panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supported-css-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supported-css-properties-expected.txt index 702a2b1..9f28d71 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supported-css-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supported-css-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test supported CSS properties. Margin longhands: margin-bottom, margin-left, margin-right, margin-top
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supports-rule-after-invalid-selector-rule-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supports-rule-after-invalid-selector-rule-crash-expected.txt index d9e8ba62..0e13d65 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supports-rule-after-invalid-selector-rule-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/supports-rule-after-invalid-selector-rule-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test passes if it doesn't crash. crbug.com/789263
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/svg-style-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/svg-style-expected.txt index db69e33..443d2a57 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/svg-style-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/svg-style-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that svg:style does not crash when the related element is inspected. Main style:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-new-rule-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-new-rule-expected.txt index e29a1c8a..eef19b9e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-new-rule-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-new-rule-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a new rule can be undone. After adding new rule:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-property-expected.txt index a668f21..e2eb8e8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding a property is undone properly. === Last property ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-rule-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-rule-crash-expected.txt index 6c95400..4e2fc8f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-rule-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-rule-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the inspected page does not crash after undoing a new rule addition. Bug 104806
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/cancel-upon-invalid-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/cancel-upon-invalid-property-expected.txt index c630e32..abb844e9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/cancel-upon-invalid-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/cancel-upon-invalid-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that entering poor property value restores original text. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/edit-css-with-source-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/edit-css-with-source-url-expected.txt index a5f0f1b7..652a432e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/edit-css-with-source-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/edit-css-with-source-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests file system project mappings.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/import-added-through-js-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/import-added-through-js-crash-expected.txt index 0d6b610..7a2b886 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/import-added-through-js-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/import-added-through-js-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that adding @import rules into a stylesheet through JavaScript does not crash the inspected page.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/inline-stylesheet-sourceurl-and-sourcemapurl-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/inline-stylesheet-sourceurl-and-sourcemapurl-expected.txt index 720bb8a..49a3d75c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/inline-stylesheet-sourceurl-and-sourcemapurl-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/inline-stylesheet-sourceurl-and-sourcemapurl-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that in case of complex scenario with both sourceURL and sourceMappingURL in inline stylesheet the sourceMap is resolved properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/original-content-provider-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/original-content-provider-expected.txt index 389b560..7b7e1696 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/original-content-provider-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/original-content-provider-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that CSSStyleSheetHeader.originalContentProvider() indeed returns original content.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-deprecated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-deprecated-expected.txt index f5c6c781..b5f2b828 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-deprecated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-deprecated-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that selector line is computed correctly regardless of its start column. Bug 110732. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-expected.txt index f5c6c781..b5f2b828 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that selector line is computed correctly regardless of its start column. Bug 110732. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt index d9f9e1a..2666b70 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that sourcemap is applied correctly when specified by the respective HTTP header. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-expected.txt index d9f9e1a..2666b70 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that sourcemap is applied correctly when specified by the respective HTTP header. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/show-all-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/show-all-properties-expected.txt index bc683d2..795b4a3c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/show-all-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/show-all-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that large rules are truncated and can be fully expanded. Before showing all properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt index da6563a..49d1b9d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that inline stylesheets do not appear in navigator. top
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-mouse-test-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-mouse-test-expected.txt index e02d970..a699bd6b5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-mouse-test-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-mouse-test-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the styles sidebar can be used with a mouse. Test switching between items
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-parse-invalid-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-parse-invalid-properties-expected.txt index 435ade6..9ce9e82 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-parse-invalid-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-parse-invalid-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that invalid css still parses into properties. [expanded]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-redirected-css-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-redirected-css-expected.txt index b8ffaca3..77914bb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-redirected-css-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-redirected-css-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that styles in redirected css are editable.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/stylesheet-tracking-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/stylesheet-tracking-expected.txt index 4e5fca4..eb76e26 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/stylesheet-tracking-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/stylesheet-tracking-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the styleSheetAdded and styleSheetRemoved events are reported into the frontend. Bug 105828. https://bugs.webkit.org/show_bug.cgi?id=105828 2 headers known:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-after-cancelled-editing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-after-cancelled-editing-expected.txt index 9a5a66f..1cf4d17 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-after-cancelled-editing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-after-cancelled-editing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that cancelling property value editing doesn't affect undo stack.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-change-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-change-property-expected.txt index 07549c1..d58d3aa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-change-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-change-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that changing a property is undone properly. Initial value
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-property-toggle-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-property-toggle-expected.txt index bebcc41..e65cadb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-property-toggle-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-property-toggle-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that disabling style is undone properly. Before disable
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-set-selector-text-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-set-selector-text-expected.txt index 83c63f6..71e45bb3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-set-selector-text-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-set-selector-text-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that setting selector text can be undone. === Before selector modification ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/up-down-numerics-and-colors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/up-down-numerics-and-colors-expected.txt index 0510a2a8..3fe8fe16 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/up-down-numerics-and-colors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/up-down-numerics-and-colors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that numeric and color values are incremented/decremented correctly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-during-dom-traversal-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-during-dom-traversal-expected.txt index e99fec2..324e31e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-during-dom-traversal-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-during-dom-traversal-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that style updates are throttled during DOM traversal. Bug 77643. OK: updates throttled
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-throttled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-throttled-expected.txt index 5c086c8..e38139d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-throttled-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/updates-throttled-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Styles sidebar DOM rebuilds are throttled during consecutive updates. Bug 78086. OK: rebuilds throttled
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-color-swatch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-color-swatch-expected.txt index c8a94d621..7390ed5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-color-swatch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-color-swatch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that url(...) with space-delimited color names as filename segments do not contain color swatches. Bug 106770. Also tests that CSS variables such as var(--blue) do not contain color swatches. Bug 595231. url(red green blue.jpg)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-multiple-collapsing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-multiple-collapsing-expected.txt index 82abc50..e5345dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-multiple-collapsing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/url-multiple-collapsing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that multiple URLs which are long are not squashed into a single URL. Bug 590172. -webkit-image-set(url(chrome-search://theme/IDR_THEME_NTP_BACKGROUND?pfncmbjabnpldlfbnmhnhblapoibfbei) 1x, url(chrome-search://theme/IDR_THEME_NTP_BACKGROUND@2x?pfncmbjabnpldlfbnmhnhblapoibfbei) 2x)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/xsl-transformed-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/xsl-transformed-expected.txt index 54443324..c0d92503 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/xsl-transformed-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/xsl-transformed-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XSL-transformed documents in the main frame are rendered correctly in the Elements panel. https://bugs.webkit.org/show_bug.cgi?id=111313 - <html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/user-properties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/user-properties-expected.txt index ee02615e..82d38b9f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/elements/user-properties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/user-properties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that DOMNode properly tracks own and descendants' user properties. attr1 set on aNode
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/evaluate-in-page-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/evaluate-in-page-expected.txt index b90ad43b..df7dcc79 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/evaluate-in-page-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/evaluate-in-page-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that layout test can evaluate scripts in the inspected page. 2 + 2 = 4
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-api-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-api-expected.txt index a39ed5b3..554726c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-api-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-api-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. CONSOLE WARNING: line 32: network.onFinished is deprecated. Use network.onRequestFinished instead CONSOLE WARNING: line 32: webInspector.resources is deprecated. Use webInspector.network instead Tests public interface of WebInspector Extensions API
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-content-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-content-script-expected.txt index f203d42..8696db0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-content-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-content-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-expected.txt index 1c53f21..8ec1e287 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-eval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-events-expected.txt index 455281f8..00e1cea6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-headers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-headers-expected.txt index 8e0c34b..2b1e2f3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-headers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-headers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-iframe-eval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-iframe-eval-expected.txt index 9dd079b..e3a2489 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-iframe-eval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-iframe-eval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-ignore-cache-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-ignore-cache-expected.txt index 5d87710b..2bed790 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-ignore-cache-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-ignore-cache-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ignoreCache flag of WebInspector.inspectedPage.reload() Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-expected.txt index d383798..8acbdda 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-redirect-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-redirect-expected.txt index df7f7b4..0cff09b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-redirect-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-network-redirect-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API returns valid data for redirected resources Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-panel-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-panel-expected.txt index c1427435..b7bd80d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-panel-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-panel-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-reload-expected.txt index cf2c9abe..f78bc4a9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that webInspector.inspectedWindow.reload() successfully injects and preprocesses user's code upon reload Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-resources-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-resources-expected.txt index d6958a7..4713b09 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-resources-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-resources-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource-related methods of WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-sidebar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-sidebar-expected.txt index 983efa0..d845430 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-sidebar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-sidebar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sidebars in WebInspector extensions API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-timeline-api-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-timeline-api-expected.txt index 2f1b6db1..98a06a0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-timeline-api-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-timeline-api-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Started extension. Running tests... RUNNING TEST: extension_testTimeline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-useragent-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-useragent-expected.txt index 7ec07a2..593da031 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-useragent-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-useragent-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests overriding user agent via WebInspector extension API Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt index 2814a44d..2148519 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests co-existence of multiple DevTools extensions Started extension.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/file-reader-with-network-panel-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/file-reader-with-network-panel-expected.txt index 375fadc9..5209605 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/file-reader-with-network-panel-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/file-reader-with-network-panel-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that FileReader's Blob request isn't shown in network panel. requests in the network panel: 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project-expected.txt index 132dc85..e070883 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests file system project.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/filtered-item-selection-dialog-rendering-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/filtered-item-selection-dialog-rendering-expected.txt index 059f19a..df0c4a3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/filtered-item-selection-dialog-rendering-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/filtered-item-selection-dialog-rendering-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that SelectUISourceCodeDialog rendering works properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/forced-layout-in-microtask-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/forced-layout-in-microtask-expected.txt index b3597e0..15a77b5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/forced-layout-in-microtask-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/forced-layout-in-microtask-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Layout record has correct locations of layout being invalidated and forced. Layout Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/fragment-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/fragment-expected.txt index e262170d..861b8a5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/fragment-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/fragment-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fragment is stripped from url by resource and page agents. Child frame url: http://127.0.0.1:8000/devtools/resources/fragment-frame.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/geolocation-emulation-tests-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/geolocation-emulation-tests-expected.txt index 67e3f39..6548094 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/geolocation-emulation-tests-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/geolocation-emulation-tests-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that geolocation emulation with latitude and longitude works as expected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-expected.txt index 83b5e68..0530cde 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test release note Last release note version seen: @@ -8,7 +9,6 @@ Improved Performance and Memory panels Edit cookies directly from the Application panel Learn moreClose - Last version of release note seen should be updated: 99
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-unit-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-unit-expected.txt index 59f7dd4..fb48694f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-unit-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/help/release-note-unit-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Unit test for release note
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/import-open-inspector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/import-open-inspector-expected.txt index 6364506..a8f59a17 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/import-open-inspector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/import-open-inspector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests that reloading a page with the inspector opened does not crash (rewritten test from r156199).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-data-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-data-expected.txt index 9504723..504cbf2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-data-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-data-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that data is correctly loaded by IndexedDBModel from IndexedDB object store and index. Dumping values, fromIndex = false, skipCount = 0, pageSize = 2, idbKeyRange = null
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-names-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-names-expected.txt index 93d1831..233772bc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-names-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-names-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that database names are correctly loaded and saved in IndexedDBModel. Dumping database names:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view-expected.txt index 0cf9566..380cf74 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests refreshing the database information and data views. Dumping IndexedDB tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-structure-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-structure-expected.txt index 524e5e7..b6df20d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-structure-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-structure-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that database names are correctly loaded and saved in IndexedDBModel. Dumping database:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/delete-entry-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/delete-entry-expected.txt index d31abdf..c0852f7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/delete-entry-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/delete-entry-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests object store and index entry deletion. Dumping IndexedDB tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-content-expected.txt index e1ba5d1..0a5db7b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the IndexedDB database content live updates. Dumping IndexedDB tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-list-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-list-expected.txt index 7e234f65..2357d3df 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-list-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/live-update-indexeddb-list-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the IndexedDB database list live updates. Dumping IndexedDB tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/resources-panel-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/resources-panel-expected.txt index 1c7bde6..836a460 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/resources-panel-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/resources-panel-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests IndexedDB tree element on resources panel. Expanded IndexedDB tree element.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/track-valid-origin-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/track-valid-origin-expected.txt index b0ef1f0a..c989da2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/track-valid-origin-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/track-valid-origin-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that IndexedDB live update only tracks valid security origins. Invalid Origins:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/transaction-promise-console-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/transaction-promise-console-expected.txt index 36a17b7..a1ad6b29 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/transaction-promise-console-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/transaction-promise-console-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensure transactions created within Promise callbacks are not deactivated due to console activity PASS: Transaction is still active
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/upgrade-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/upgrade-events-expected.txt index 5911642..7c664e2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/upgrade-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/upgrade-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that deleted databases do not get recreated. Preparing database
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/inline-source-map-loading-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/inline-source-map-loading-expected.txt index 0d2a7cfc..9b7a86a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/inline-source-map-loading-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/inline-source-map-loading-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that inline sourcemap has proper URL and compiledURL. SourceMap Loaded:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/input-event-warning-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/input-event-warning-expected.txt index 51d6c697..674d5a6c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/input-event-warning-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/input-event-warning-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console warnings are issued for a blocked event listener and that there is no crash when an offending listener is removed by the handler. There should be no warnings above this line
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-element-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-element-expected.txt index d3cc559..c0a6c62 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-element-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-element-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect element action works for iframe children (https://bugs.webkit.org/show_bug.cgi?id=76808). div#div
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-iframe-from-different-domain-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-iframe-from-different-domain-expected.txt index 46c6e8e..bb86b0a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-iframe-from-different-domain-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/inspect-iframe-from-different-domain-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that style properties of elements in iframes loaded from domain different from the main document domain can be inspected. See bug 31587. background: green;
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/inspected-objects-not-overriden-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/inspected-objects-not-overriden-expected.txt index cacedcc1..9e965b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/inspected-objects-not-overriden-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/inspected-objects-not-overriden-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that opening inspector front-end doesn't change methods defined by the inspected application. myImpl() => my value
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/inspector-backend-commands-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/inspector-backend-commands-expected.txt index a2294ec7..fb72e4c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/inspector-backend-commands-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/inspector-backend-commands-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests correctness of promisified protocol commands. error: Request Profiler.commandError failed. {"message":"this is the error message"}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/jump-to-previous-editing-location-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/jump-to-previous-editing-location-expected.txt index 769cef6..762319a1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/jump-to-previous-editing-location-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/jump-to-previous-editing-location-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that jumping to previous location works as intended.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-canvas-log-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-canvas-log-expected.txt index 3200056..59403cf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-canvas-log-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-canvas-log-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests layer command log Canvas log:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt index 91eb2da..b634c7a6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt
@@ -1,5 +1,6 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests layer compositing reasons in Layers Panel -Compositing reasons for #document: overflowScrollingTouch,root,rootScroller +Compositing reasons for #document: layerForScrollingContents Compositing reasons for div#transform3d: assumedOverlap,inlineTransform,transform3D Compositing reasons for div#transform3d-individual: assumedOverlap,inlineTransform,transform3D Compositing reasons for iframe#iframe: iFrame
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-oopif-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-oopif-expected.txt index a8d7cb5a..6f31fd3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-oopif-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-oopif-expected.txt
@@ -1,2 +1,3 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests renderer does not crash with an out-of-process iframe
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-replay-scale-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-replay-scale-expected.txt index 3c20c5d..996e04535 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-replay-scale-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-replay-scale-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when layer snapshots are replayed with scaling applied the image dimensions are properly scaled. Image dimensions at scale undefined: 180 x 180
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-scroll-rects-get-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-scroll-rects-get-expected.txt index 0d7eaa09..05308fb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-scroll-rects-get-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-scroll-rects-get-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests scroll rectangles support in in Layers3DViewxScroll rectangles Scroll rectangles
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-sticky-position-constraint-get-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-sticky-position-constraint-get-expected.txt index 953cdee5..212f55763 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-sticky-position-constraint-get-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-sticky-position-constraint-get-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sticky position constraints in Layers panel Sticky position constraint
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-tree-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-tree-model-expected.txt index c416372..7fa7693 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-tree-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-tree-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests general layer tree model functionality Initial layer tree #document (7)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt index 2839b22..b3c4bb9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-3d-view-hit-testing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests hit testing in Layers3DView Initial state
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-panel-mouse-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-panel-mouse-events-expected.txt index c35ec648..50719c6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-panel-mouse-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layers-panel-mouse-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests moust hover/select events handling in the Layers panel Hovering b1 in tree
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/no-overlay-layers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/no-overlay-layers-expected.txt index c0b48b61..d2c2fec 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/layers/no-overlay-layers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/layers/no-overlay-layers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests overlay layers are not present in the layer tree DONE
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/load-file-resource-for-frontend-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/load-file-resource-for-frontend-expected.txt index a04d82c..800400b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/load-file-resource-for-frontend-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/load-file-resource-for-frontend-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test loading file resource from front-end
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-expected.txt index 9adcf44..13b777e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests callFunction on local remote objects. getItem(1) result: 28
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-properties-section-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-properties-section-expected.txt index 1e346da9..7f55633 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-properties-section-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/local-object-properties-section-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that ObjectPropertiesSection works with local remote objects. local object
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/modify-cross-domain-rule-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/modify-cross-domain-rule-expected.txt index f24483d..2c75138a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/modify-cross-domain-rule-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/modify-cross-domain-rule-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that modifying a rule in a stylesheet loaded from a different domain does not crash the renderer.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-elements-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-elements-expected.txt index 6f84aa0..4fe32e4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-elements-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-elements-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test validates initial set of loaded modules for Elements panel. Loaded modules:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-initial-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-initial-expected.txt index 0d01d5a..d5f8010 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-initial-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-initial-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test validates initial set of loaded modules. Loaded modules:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-network-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-network-expected.txt index ace64b7..a03c6074 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-network-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-network-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test validates set of loaded modules for Network panel. Loaded modules:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-source-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-source-expected.txt index 81fef08fc..0a4595d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-source-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/modules-load-source-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test validates set of loaded modules for Sources panel. Loaded modules:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network-preflight-options-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network-preflight-options-expected.txt index 3345130..271b7643e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network-preflight-options-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network-preflight-options-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that preflight OPTIONS requests appear in Network resources 0 xhr:POST http://localhost:8000/devtools/resources/cors-target.php?id=0&deny=yes
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/async-xhr-json-mime-type-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/async-xhr-json-mime-type-expected.txt index 34c3dc8..8006dcf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/async-xhr-json-mime-type-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/async-xhr-json-mime-type-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the content of resources with JSON MIME types can be accessed. When loaded by asynchronous XHR requests (Bug 80684) or within iframes/documents.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-moved-to-storage-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-moved-to-storage-expected.txt index ce664dc..dfb4fda1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-moved-to-storage-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-moved-to-storage-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests content is moved from cached resource to resource agent's data storage when cached resource is destroyed. http://127.0.0.1:8000/devtools/network/resources/resource.php?type=image&random=1&size=400
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-too-big-discarded-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-too-big-discarded-expected.txt index 583ecc0..6908f09 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-too-big-discarded-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/cached-resource-destroyed-too-big-discarded-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests cached resource content is discarded when cached resource is destroyed if content size is too big for the resource agent's data storage. http://127.0.0.1:8000/devtools/network/resources/resource.php?type=image&random=1&size=400
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/disable-cache-on-interception-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/disable-cache-on-interception-expected.txt index 165b90d..b6d3843 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/disable-cache-on-interception-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/disable-cache-on-interception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure cache is disabled when interception is enabled. Enabling Interception
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/download-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/download-expected.txt index cc1ec15c..41fd03b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/download-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/download-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that responseReceived is called on NetworkDispatcher for downloads. Received response for download.zzz
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/font-face-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/font-face-expected.txt index c853592..0ea6b596 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/font-face-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/font-face-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that a used font-face is reported and an unused font-face is not reported. RequestStarted: font-face.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/from-disk-cache-timing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/from-disk-cache-timing-expected.txt index 23058eb..626c914 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/from-disk-cache-timing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/from-disk-cache-timing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests requests loaded from disk cache have correct timing URL:http://127.0.0.1:8000/devtools/network/resources/cached-script.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/har-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/har-content-expected.txt index dcd43234..872b4ff5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/har-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/har-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests conversion of Inspector's resource representation into HAR format. initiator.css:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/json-preview-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/json-preview-expected.txt index e3b36358..a1b36b47 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/json-preview-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/json-preview-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resources with JSON MIME types are previewed with the JSON viewer.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/load-resource-for-frontend-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/load-resource-for-frontend-expected.txt index f7b741c..80a5ae9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/load-resource-for-frontend-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/load-resource-for-frontend-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test loading resource for frontend.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/long-script-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/long-script-content-expected.txt index e993e4e..c95fad9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/long-script-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/long-script-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests long script content is correctly shown in source panel after page reload. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-blocked-reason-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-blocked-reason-expected.txt index 28e0629..2e151b19 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-blocked-reason-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-blocked-reason-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that blocked reason is recognized correctly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cachedresources-with-same-urls-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cachedresources-with-same-urls-expected.txt index 99b4fe44..d987137a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cachedresources-with-same-urls-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cachedresources-with-same-urls-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when we load two different images from the same url (e.g. counters), their content is different in network panel as well. http://127.0.0.1:8000/devtools/network/resources/resource.php?type=image&random=1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-choose-preview-view-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-choose-preview-view-expected.txt index bc465b9f..f317229 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-choose-preview-view-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-choose-preview-view-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to make sure the proper view is used for the data that is received in network panel. Simple JSON
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-close-request-view-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-close-request-view-expected.txt index 53b4c177f..fe7e0cb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-close-request-view-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-close-request-view-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Showing request foo Network Item View: true Hiding request
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-sorted-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-sorted-expected.txt index ed3be76..3ef45c3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-sorted-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-sorted-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests network columns are sortable. Sorted by: name
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-visible-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-visible-expected.txt index c55c1eb9..237e334 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-visible-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-visible-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure column names are matching data. name: empty.html?xhr/devtools/network/resources
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-content-replacement-xhr-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-content-replacement-xhr-expected.txt index cd5cd3c..94bc3fdf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-content-replacement-xhr-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-content-replacement-xhr-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests NetworkResourcesData logic for XHR content replacement. http://127.0.0.1:8000/devtools/network/resources/resource.php?size=200
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane-expected.txt index fe1d484..07c4780d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests cookie pane rendering in Network panel --------------------------
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane.js b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane.js index ce96d2eb..321d0f0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane.js +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cookies-pane.js
@@ -22,7 +22,7 @@ // Ensure this runs after all Promise.resolve setTimeout(() => { TestRunner.addResult('--------------------------'); - const value = panel._detailsWidget.element.innerText.split('\n').map(line => line.trim()).join('\n').trim(); + const value = panel._detailsWidget.element.innerText.split('\n').map(line => line.trim()).join('\n').replace(/\n\n+/g, '\n').trim(); TestRunner.addResult(value); TestRunner.completeTest(); }, 0);
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cyrillic-xhr-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cyrillic-xhr-expected.txt index 21e5d8da..a1a47ac1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cyrillic-xhr-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-cyrillic-xhr-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests cyrillic xhr content is correctly loaded in inspector. https://bugs.webkit.org/show_bug.cgi?id=79026
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datareceived-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datareceived-expected.txt index a4a121f..93916b3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datareceived-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datareceived-expected.txt
@@ -1,6 +1,6 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that dataReceived is called on NetworkDispatcher for all incoming data. - Received response. SUCCESS
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datasaver-warning-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datasaver-warning-expected.txt index c5dec33..48a8c6e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datasaver-warning-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-datasaver-warning-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure datsaver logs warning in console if enabled and only shown once on reloads. Console messages: @@ -6,7 +7,6 @@ Reloading Page Page reloaded. Console messages: -Consider disabling Chrome Data Saver while debugging. For more info see: https://support.google.com/chrome/?p=datasaver Reloading Page Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-cors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-cors-expected.txt index ba02386..130cc00 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-cors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-cors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that preflight OPTIONS is always sent if 'Disable cache' is checked, and that network instrumentation does not produce errors for redirected preflights. OPTIONS: http://localhost:8080/devtools/network/resources/cors-redirect.cgi
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-memory-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-memory-expected.txt index 7d8781d..653626b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-memory-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-memory-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests disabling cache from inspector. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-expected.txt index 1df37d5a..f5c00200 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests disabling cache from inspector and seeing that preloads are not evicted from memory cache. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-twice-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-twice-expected.txt index b6fc0f6..aacec17f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-twice-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-preloads-twice-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests disabling cache from inspector and seeing that preloads are not evicted from memory cache. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-xhrs-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-xhrs-expected.txt index b9f9adf..9c5a72cf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-xhrs-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disable-cache-xhrs-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests disabling cache from inspector. http://127.0.0.1:8000/devtools/network/resources/resource.php?random=1&cached=1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disabling-check-no-memory-leak-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disabling-check-no-memory-leak-expected.txt index cd57b42..471d32a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disabling-check-no-memory-leak-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-disabling-check-no-memory-leak-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that after disabling network domain, content saved on backend is removed. https://bugs.webkit.org/show_bug.cgi?id=67995 resource.content after disabling network domain: null
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-document-initiator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-document-initiator-expected.txt index f9be31d..d383207 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-document-initiator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-document-initiator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that page navigation initiated by JS is correctly reported. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-domain-filter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-domain-filter-expected.txt index b7fdd33..d331659 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-domain-filter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-domain-filter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests doamin filter.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-empty-xhr-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-empty-xhr-expected.txt index 2ec3830..c7538339 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-empty-xhr-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-empty-xhr-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests empty xhr content is correctly loaded in inspector. https://bugs.webkit.org/show_bug.cgi?id=79026 http://127.0.0.1:8000/devtools/network/resources/empty.html?sync resource.content:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-eventsource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-eventsource-expected.txt index 65f9d63..c7e2269a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-eventsource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-eventsource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests EventSource resource type and content. [page] got event: hello
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-expected.txt index 45b0f033..7147830 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fetch network resource type and content. http://127.0.0.1:8000/devtools/network/resources/resource.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-post-payload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-post-payload-expected.txt index 861f0a39..8cb3057 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-post-payload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-fetch-post-payload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fetch() network resource payload is not corrupted by transcoding. http://127.0.0.1:8000/devtools/network/resources/resource.php?foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filmstrip-overview-showing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filmstrip-overview-showing-expected.txt index 90daa9e..1da32ec 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filmstrip-overview-showing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filmstrip-overview-showing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to make sure film strip and overview pane show if the other does not exist. http://crbug.com/723659 Overview should not be showing
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-http-requests-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-http-requests-expected.txt index 6f5d30f4..f012b0e4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-http-requests-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-http-requests-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests filtering of requests suitable for HAR. HTTP request URL: http://webkit.org
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-updated-requests-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-updated-requests-expected.txt index 690744f..532c22f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-updated-requests-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filter-updated-requests-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that filter is reapplied when request is updated. Clicked 'XHR and Fetch' button.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-expected.txt index 0714dee..0cc75844 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fetch network filters filterText: -.css
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-internals-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-internals-expected.txt index 2adf3899..2855acc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-internals-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-filters-internals-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure data being passed from outside network to filter results filters properly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-iframe-load-and-delete-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-iframe-load-and-delete-expected.txt index cd157cf..8a0b4ab8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-iframe-load-and-delete-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-iframe-load-and-delete-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that if iframe is loaded and then deleted, inspector could still show its content. Note that if iframe.src is changed to "javascript:'...some html...'" after loading, then we have different codepath, hence two tests; http://127.0.0.1:8000/devtools/network/resources/resource.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-image-404-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-image-404-expected.txt index e3178f38..6d0f745 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-image-404-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-image-404-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests content is available for failed image request. http://127.0.0.1:8000/devtools/network/resources/404.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-imported-resource-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-imported-resource-content-expected.txt index e0315835..ca893a2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-imported-resource-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-imported-resource-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests content is available for imported resource request. http://127.0.0.1:8000/devtools/network/resources/imported.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-chain-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-chain-expected.txt index 3478cf5..8f431747 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-chain-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-chain-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that computing the initiator graph works for service worker request.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-expected.txt index afadbad..9ccdc10 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resources initiator for images initiated by IMG tag, static CSS, CSS class added from JavaScript and XHR. http://127.0.0.1:8000/devtools/network/resources/initiator.css: parser
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-from-console-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-from-console-expected.txt index 0147e0a..3b11c78 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-from-console-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-initiator-from-console-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that there is no javascript error when console evaluation causes resource loading. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-json-parser-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-json-parser-expected.txt index f889eb6..6dc8e2d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-json-parser-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-json-parser-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests JSON parsing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-memory-cached-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-memory-cached-resource-expected.txt index 11c32d1..72c3bd8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-memory-cached-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-memory-cached-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that memory-cached resources are correctly reported. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety-expected.txt index 9ed2c51d..1631d98 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. To make sure that filenames are encoded safely for Network Persistence. www.example.com/ -> www.example.com/index.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-recording-after-reload-with-screenshots-enabled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-recording-after-reload-with-screenshots-enabled-expected.txt index 65fbcb2..b8174dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-recording-after-reload-with-screenshots-enabled-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-recording-after-reload-with-screenshots-enabled-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests if page keeps recording after refresh with Screenshot enabled. Bug 569557 Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-parse-query-params-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-parse-query-params-expected.txt index 62ca11f..61a092f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-parse-query-params-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-parse-query-params-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests query string parsing. Query: a=b&c=d
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-query-string-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-query-string-expected.txt index 42456ab..727ce9c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-query-string-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-query-string-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests query string extraction. URL: http://webkit.org
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-revision-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-revision-content-expected.txt index 4d9d4fa..0c3e1c5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-revision-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-revision-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how revision requests content if original content was not loaded yet. https://bugs.webkit.org/show_bug.cgi?id=63631 http://127.0.0.1:8000/devtools/network/resources/style.css
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-type-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-type-expected.txt index 0b33d5a..8d7e6f9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-type-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-request-type-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XHR request type is detected on send.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-requestblocking-icon-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-requestblocking-icon-expected.txt index 74f59f7..be2ef3b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-requestblocking-icon-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-requestblocking-icon-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensures the icon is properly displayed when network request blocking setting is enabled/disabled. Is blocking: false
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-search-expected.txt index 72462d87..501d08f2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests search in network requests URL search
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-status-non-http-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-status-non-http-expected.txt index a966e18..74973cf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-status-non-http-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-status-non-http-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test network status of non http request. network-status-non-http.js:200 OKFinished
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-timing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-timing-expected.txt index 11f4e4f..d97a3f8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-timing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-timing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests network panel timing. http://127.0.0.1:8000/devtools/network/resources/resource.php?type=js&wait=100&send=200&jsdelay=300&jscontent=resourceLoaded()
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-toggle-type-filter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-toggle-type-filter-expected.txt index 93d0c24..0a53c88 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-toggle-type-filter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-toggle-type-filter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests toggling type filter on network panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-update-calculator-for-all-requests-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-update-calculator-for-all-requests-expected.txt index 200ae931..683a595 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-update-calculator-for-all-requests-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-update-calculator-for-all-requests-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that time calculator is updated for both visible and hidden requests. Clicked 'xhr' button.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-blocked-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-blocked-expected.txt index 995a7c8..33522f6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-blocked-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-blocked-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests blocking fetch in worker. Fetch in worker result: FETCH_FAILED
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-expected.txt index 6e298957..7d2a163 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fetch in worker. Fetch in worker result: Hello world
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-parallel-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-parallel-expected.txt index ed8f2907..74e2c88 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-parallel-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-worker-fetch-parallel-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that parallel fetches in worker should not cause crash. Parallel fetch in worker result: ["Hello world","Hello world"]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-double-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-double-expected.txt index 4f1368b..9600e15 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-double-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-double-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests responses in network tab for two XHRs sent without any delay between them. Bug 91630 resource1.content: request1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-expected.txt index 2a31e056..c025a54 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XHR network resource type and content for asynchronous requests. Bug 61205 http://127.0.0.1:8000/devtools/network/resources/resource.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-response-type-blob-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-response-type-blob-expected.txt index a7d0f4b..71edcf85 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-response-type-blob-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-async-response-type-blob-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XHR network resource type and size for asynchronous requests when "blob" is specified as the response type. http://127.0.0.1:8000/devtools/network/resources/resource.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-binary-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-binary-content-expected.txt index a600e98b..0c8eee5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-binary-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-binary-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that binary XHR response is not corrupted. request.type: xhr
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-data-received-async-response-type-blob-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-data-received-async-response-type-blob-expected.txt index 3bec1b1..16c14ae 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-data-received-async-response-type-blob-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-data-received-async-response-type-blob-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that dataReceived is called on NetworkDispatcher for XHR with responseType="blob". Received data for resource.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-post-payload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-post-payload-expected.txt index 993ac0a..83c2689 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-post-payload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-post-payload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XHR network resource payload is not corrupted by transcoding. http://127.0.0.1:8000/devtools/network/resources/resource.php?foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-body-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-body-expected.txt index 06a6620e..17ff938 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-body-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-body-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XHR redirects preserve request body. POST http://127.0.0.1:8000/devtools/network/resources/redirect.cgi?status=301&ttl=1 actual http method was: POST
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-method-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-method-expected.txt index 62153a0..adbef32a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-method-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-redirect-method-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XHR redirects preserve http-method. PUT http://127.0.0.1:8000/devtools/network/resources/redirect.cgi?status=301&ttl=3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-replay-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-replay-expected.txt index 2813ca5..c3405e4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-replay-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-replay-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XHR replaying. Bug 95187
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-same-url-as-main-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-same-url-as-main-resource-expected.txt index c45a9b7..4d74467 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-same-url-as-main-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-same-url-as-main-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XHRs with the same url as a main resource have correct category. xhr
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-sync-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-sync-expected.txt index b94eedc..0c7101b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-sync-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xhr-sync-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XHR network resource type and content for synchronous requests. Bug 61205 http://127.0.0.1:8000/devtools/network/resources/resource.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xsl-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xsl-content-expected.txt index ef74702..37b2e3f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xsl-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-xsl-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XSL stylsheet content. http://crbug.com/603806 http://127.0.0.1:8000/devtools/network/resources/xml-with-stylesheet.xml
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/oopif-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/oopif-content-expected.txt index 3c3533d..d22d84c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/oopif-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/oopif-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests content is available for a cross-process iframe. content: <html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/parse-form-data-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/parse-form-data-expected.txt index d0ad21b..3eb95b7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/parse-form-data-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/parse-form-data-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that form submissions appear and are parsed in the network panel resource.requestContentType: application/x-www-form-urlencoded [
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-expected.txt index 81fb9a1..6e22f346 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that hyperlink auditing (ping) requests appear in network panel http://127.0.0.1:8000/devtools/network/ping.js resource.requestContentType: text/ping
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-response-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-response-expected.txt index d8e319f..ddd171e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-response-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/ping-response-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that ping request response is recorded. URL: http://127.0.0.1:8000/devtools/network/resources/empty.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/preview-searchable-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/preview-searchable-expected.txt index 088cc5f..62fa676 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/preview-searchable-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/preview-searchable-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resources with JSON MIME types are previewed with the JSON viewer.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-name-path-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-name-path-expected.txt index 03febf92..567110a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-name-path-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-name-path-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests name() and path() methods of NetworkRequest. Dumping request name and path for url: http://www.example.com/foo/bar/baz?key=value
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-parameters-decoding-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-parameters-decoding-expected.txt index db51426..dc241d2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-parameters-decoding-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/request-parameters-decoding-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how request headers are decoded in network item view. Original value: Test+%21%40%23%24%25%5E%26*%28%29_%2B+parameters.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/resource-priority-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/resource-priority-expected.txt index 71ad775..6b4e226 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/resource-priority-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/resource-priority-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource priorities. sendSyncScriptRequest
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-long-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-long-url-expected.txt index a829dbe..ea16233 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-long-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-long-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that long URLs are correctly trimmed in anchor links. Message count: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-with-caret-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-with-caret-expected.txt index 1caf6550..dab353c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-with-caret-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-with-caret-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console message when script is loaded with incorrect text/html mime type and the URL contains the '^' character. Message count: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/server-timing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/server-timing-expected.txt index 27c5eb7..a843263 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/server-timing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/server-timing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that server-timing headers are parsed correctly. Tests ran to completion.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-script-expected.txt index 0a38651..729dfbf6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that only one request is made for basic script requests with integrity attribute. call-success-with-integrity-frame.html:5 Script loaded successfully.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-stylesheet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-stylesheet-expected.txt index 88b070f..28bc57d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-stylesheet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/subresource-integrity-number-of-requests-for-stylesheet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that only one request is made for basic stylesheet requests with integrity attribute. style-with-integrity-frame.html:5 Stylesheet loaded successfully.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/warning-for-long-cookie-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/warning-for-long-cookie-expected.txt index b29f6bcd..9145366c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/warning-for-long-cookie-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/warning-for-long-cookie-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that we show warning message for long cookie. Message count: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-header-height-updates-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-header-height-updates-expected.txt index 8d22d68d..6b620d8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-header-height-updates-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-header-height-updates-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests to ensure network waterfall column updates header height when headers are not visible. Setting initial large row setting to false
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-console-preserves-log-on-frame-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-console-preserves-log-on-frame-navigation-expected.txt index d33295c..4c3de73 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-console-preserves-log-on-frame-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-console-preserves-log-on-frame-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console preserves log on oopif navigation oopif-console-preser…me-navigation.js:12 Before navigation oopif-console-preser…me-navigation.js:14 After navigation
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-cookies-refresh-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-cookies-refresh-expected.txt index 1bb820f..6b75763d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-cookies-refresh-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-cookies-refresh-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that cookies are properly shown after oopif refresh Page reloaded. Available cookie domains:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-inspect-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-inspect-expected.txt index bf5845d..b9795474 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-inspect-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-inspect-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect request works for nested OOPIF elements. Selected node has text: #text
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-in-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-in-expected.txt index 8e9941c..d5ebf67c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-in-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-in-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that oopif iframes are rendered inline.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-out-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-out-expected.txt index e7d336c..59c77b9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-out-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-navigate-out-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that oopif iframes are rendered inline.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-error-page-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-error-page-expected.txt index 41ef288..33edcc7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-error-page-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-error-page-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that oopif iframes are rendered inline. - <html>
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-expected.txt index aaeb7049..68877fc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-nesting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that oopif iframes are rendered inline.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-navigator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-navigator-expected.txt index 770ada77..ea0be03 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-navigator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-navigator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify navigator rendering with OOPIFs Sources: -------- Setting mode: [frame]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt index e77cb7b..6416f0e80 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
@@ -1,11 +1,12 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test CPU profiles are recorded for OOPIFs. name: CrRendererMain url: http://127.0.0.1:8000/devtools/oopif/resources/page.html -has CpuProfile: true +has CpuProfile: false name: CrRendererMain url: http://devtools.oopif.test:8000/devtools/oopif/resources/inner-iframe.html?second -has CpuProfile: true +has CpuProfile: false
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-monitor-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-monitor-expected.txt index fe07caa..616463c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-monitor-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-monitor-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests stability of performance metrics list.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-presentation-console-messages-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-presentation-console-messages-expected.txt index e276c60..2c4cdb4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-presentation-console-messages-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-presentation-console-messages-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that links to UISourceCode work correctly when navigating OOPIF Navigating main frame
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-storage-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-storage-expected.txt index a48834ec..9d9c770 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-storage-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-storage-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify DOM storage with OOPIFs Local Storage: http://127.0.0.1:8000http://devtools.oopif.test:8000http://devtools.oopif.test:8000http://127.0.0.1:8000
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets-expected.txt index 360096a0..c1eb571 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that targets are created for oopif iframes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/can-edit-iframe-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/can-edit-iframe-html-expected.txt index e562942..605adc1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/can-edit-iframe-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/can-edit-iframe-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensures iframes are overridable if overrides are setup. URL: cross-origin-iframe.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash-expected.txt index 9586386..b90a3b1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensures iframes are overridable if overrides are setup. Creating UISourcecode for url: resources/bar.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind-expected.txt index cbd5468..ea7579a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensures that when a project is added with already existing files they bind. Bound Files:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-absolute-paths-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-absolute-paths-expected.txt index db61b346..4f25252 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-absolute-paths-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-absolute-paths-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that automapping is capable of mapping file:// urls. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-committed-network-sourcecode-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-committed-network-sourcecode-expected.txt index 15434de..71910ee9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-committed-network-sourcecode-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-committed-network-sourcecode-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that committed network uiSourceCode gets bound to fileSystem, making fileSystem dirty with its content Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-filesystem-sourcecode-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-filesystem-sourcecode-expected.txt index 915dd68..5dcf445c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-filesystem-sourcecode-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-filesystem-sourcecode-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that dirty fileSystem uiSourceCodes are bound to network. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-network-sourcecode-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-network-sourcecode-expected.txt index fb321d12..03ba0c7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-network-sourcecode-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-bind-dirty-network-sourcecode-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that dirty network uiSourceCodes are bound to filesystem. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-dynamic-uisourcecodes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-dynamic-uisourcecodes-expected.txt index a744a3f..e076594 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-dynamic-uisourcecodes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-dynamic-uisourcecodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that automapping works property when UISourceCodes come and go.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-git-folders-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-git-folders-expected.txt index f75afc7..b42b913 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-git-folders-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-git-folders-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that automapping is able to map ambiguous resources based on the selected project folder. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-rename-files-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-rename-files-expected.txt index 5cd0e9b..7c44adb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-rename-files-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-rename-files-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that automapping is sane. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sane-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sane-expected.txt index 73ec25b..e470d52a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sane-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sane-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that automapping is sane. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-expected.txt index ca97716..f5ec67ad 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that sourcemap sources are mapped with non-exact match. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-nameclash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-nameclash-expected.txt index 24860b3..d430e87 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-nameclash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/automapping-sourcemap-nameclash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that sourcemap sources are mapped event when sourcemap compiled url matches with one of the source urls. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/ensure-filesystem-create-files-doesnt-emit-change-first-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/ensure-filesystem-create-files-doesnt-emit-change-first-expected.txt index b6fb73a..6dabba4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/ensure-filesystem-create-files-doesnt-emit-change-first-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/ensure-filesystem-create-files-doesnt-emit-change-first-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that fs.createFile is creating UISourceCode atomically with content Added: file:///var/test/test.txt With content: file content
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-conflicting-paths-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-conflicting-paths-expected.txt index b96c8a99..640faf8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-conflicting-paths-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-conflicting-paths-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that uiSourceCode.delete actually deltes file from IsolatedFileSystem.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-delete-file-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-delete-file-expected.txt index d641e29..b6797ed9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-delete-file-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-delete-file-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that uiSourceCode.delete actually deltes file from IsolatedFileSystem. BEFORE:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-ignores-files-on-changed-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-ignores-files-on-changed-expected.txt index 0f703cbc..664fb51 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-ignores-files-on-changed-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/filesystem-ignores-files-on-changed-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Ensure that if a file that should be ignored is changed on the filesystem it does not propogate events. Creating filesystem
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/navigator-create-file-copy-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/navigator-create-file-copy-expected.txt index 127a3caf..7e77e46e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/navigator-create-file-copy-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/navigator-create-file-copy-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator's 'Make a copy' works as expected. BEFORE:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-do-not-overwrite-css-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-do-not-overwrite-css-expected.txt index 169819c..e702c78 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-do-not-overwrite-css-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-do-not-overwrite-css-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that persistence does not overwrite CSS files when CSS model reports error on getStyleSheetText.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-external-change-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-external-change-breakpoints-expected.txt index 41d7307..2dac215 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-external-change-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-external-change-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that breakpoints survive external editing.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-go-to-file-dialog-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-go-to-file-dialog-expected.txt index f8aff31..84a6c67 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-go-to-file-dialog-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-go-to-file-dialog-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that GoTo source dialog filters out mapped uiSourceCodes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-merge-editor-tabs-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-merge-editor-tabs-expected.txt index 0da1c5a..82cda70d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-merge-editor-tabs-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-merge-editor-tabs-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that tabs get merged when binding is added and removed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-mimetype-on-rename-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-mimetype-on-rename-expected.txt index ec1c6a7..1e0a647 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-mimetype-on-rename-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-mimetype-on-rename-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that text editor's mimeType gets changed as UISourceCode gets renamed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-expected.txt index cd88d3b..34a1208 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that breakpoints are moved appropriately
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload-expected.txt index fe61fe9..29e9682 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that breakpoints are moved appropriately in case of page reload.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator-unique-names-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator-unique-names-expected.txt index 27b7675..334cad88 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator-unique-names-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator-unique-names-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that navigator view removes mapped UISourceCodes. [largeicon-navigator-folder] bad/foo/bar [dimmed]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-search-across-all-files-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-search-across-all-files-expected.txt index 930751a..13ff6d69 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-search-across-all-files-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-search-across-all-files-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that search across all files omits filesystem uiSourceCodes with binding to network.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-highlight-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-highlight-expected.txt index e0b72b1..c2e7463 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-highlight-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-highlight-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that UISourceCodeFrames are highlighted based on their network UISourceCode. Network UISourceCodeFrame highlighter type: text/javascript
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-messages-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-messages-expected.txt index 0d7b9e6c..d1a845d5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-messages-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sourceframe-messages-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that messages are synced in UISourceCodeFrame between UISourceCodes of persistence binding.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-switch-editor-tab-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-switch-editor-tab-expected.txt index e654292a..50a5371 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-switch-editor-tab-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-switch-editor-tab-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that a network file tab gets substituted with filesystem tab when persistence binding comes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-expected.txt index 04ec26d..7215f64 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that persistence syncs network and filesystem UISourceCodes.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-nodejs-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-nodejs-expected.txt index a4943080..17a6a48c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-nodejs-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-sync-content-nodejs-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. CONFIRM: This file was changed externally. Would you like to reload it? Verify that syncing Node.js contents works fine.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-keeps-selected-tab-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-keeps-selected-tab-expected.txt index 6826d16..44b1ec2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-keeps-selected-tab-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-keeps-selected-tab-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that tab keeps selected as the persistence binding comes in. Opened tabs before persistence binding:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt index 46097e0..5896190 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that for a fileSystem UISourceCode with persistence binding TabbedEditorContainer opens filesystem UISourceCode. Binding created: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order-expected.txt index 9c454dd..1e11ee6b8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that tabbed editor doesn't shuffle tabs when bindings are dropped and then re-added during reload.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/agents-disabled-check-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/agents-disabled-check-expected.txt index ded37071..233ee6e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/agents-disabled-check-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/agents-disabled-check-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that if a profiler is working all the agents are disabled. --> SDK.targetManager.suspendAllTargets();
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-agent-crash-on-start-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-agent-crash-on-start-expected.txt index 7776824..e6a3501 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-agent-crash-on-start-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-agent-crash-on-start-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that ProfilerAgent start/stop doesn't crash. ProfilerAgent started.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-large-tree-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-large-tree-search-expected.txt index cdfd2cb9..e0d59c1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-large-tree-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-large-tree-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that search works for large bottom-up view of CPU profile. foo12@0:12:0: foo12 10 9890
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-times-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-times-expected.txt index 1c05cbdc..7bcd165 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-times-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-bottom-up-times-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests bottom-up view self and total time calculation in CPU profiler. (idle)@0:1:0: (idle) 500 500 500.0 ms500.0 ms(idle)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-calculate-time-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-calculate-time-expected.txt index e6f8565b1..5dfefa9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-calculate-time-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-calculate-time-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests self and total time calculation in CPU profiler. SUCCESS: all nodes have correct self and total times
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-fix-missing-samples-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-fix-missing-samples-expected.txt index 9450db1..19986275 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-fix-missing-samples-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-fix-missing-samples-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests missing samples are replaced with neighbor stacks. Profile tree: (root) id:1 total:16 self:0 depth:-1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-flame-chart-overview-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-flame-chart-overview-expected.txt index 7d50425..ddb26e35 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-flame-chart-overview-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-flame-chart-overview-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Overview pane calculation in FlameChart for different width = 2^n with n in range 4 - 0. Also tests loading of a legacy nodes format, where nodes were represented as a tree.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-native-nodes-filter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-native-nodes-filter-expected.txt index b5922933f..b33d22b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-native-nodes-filter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-native-nodes-filter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests filtering of native nodes. Also tests loading of a legacy nodes format, where nodes were represented as a tree.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt index d465d39..58ffe35 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests profile ending with GC node is parsed correctly. Profile tree: (root) id:1 total:3 self:0 depth:-1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profile-removal-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profile-removal-expected.txt index 734fe1c..64baa7b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profile-removal-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profile-removal-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CPU profile removal from a group works. Bug 110466 Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profiling-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profiling-expected.txt index 76a4df52..b6112981 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profiling-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-profiling-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CPU profiling works. https://bugs.webkit.org/show_bug.cgi?id=52634 Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-save-load-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-save-load-expected.txt index b160937..2dfa3f7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-save-load-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-save-load-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that CPU profiling is able to save/load. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-stopped-removed-race-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-stopped-removed-race-expected.txt index a224b4c..d75ce9c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-stopped-removed-race-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-stopped-removed-race-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that profile removal right after stop profiling issued works. Bug 476430. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-profiler-profiling-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-profiler-profiling-expected.txt index 26d4753..2fe59ac 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-profiler-profiling-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-profiler-profiling-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that sampling heap profiling works. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt index c690e8a..b4f11b2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Comparison view of heap snapshots will contain added nodes even if their ids are less than the maximumm JS object id in the base snapshot. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt index 520fd50..b178848 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Comparison view of detailed heap snapshots. Expanded nodes must be preserved after sorting. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-all-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-all-expected.txt index 1d250ff..136215a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-all-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-all-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Comparison view of detailed heap snapshots. The "Show All" button must show all nodes. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-next-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-next-expected.txt index f8d1243c2..b693cab 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-next-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-show-next-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Comparison view of detailed heap snapshots. Repeated clicks on "Show Next" button must show all nodes. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt index ee778ff..033ffacc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Comparison view of detailed heap snapshots. Shown node count must be preserved after sorting. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-sorting-expected.txt index b1e2be9..13b6393b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-comparison-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sorting in Comparison view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt index 42df0227..b6b0f846 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Containment view of detailed heap snapshots. Expanded nodes must be preserved after sorting. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-all-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-all-expected.txt index d63fde5..c28691e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-all-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-all-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Containment view of detailed heap snapshots. The "Show All" button must show all nodes. Test object distances calculation. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-next-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-next-expected.txt index 0455016..5ff950f2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-next-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-show-next-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Containment view of detailed heap snapshots. Repeated clicks on "Show Next" button must show all nodes. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt index 8d187ff..8c2e834 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Containment view of detailed heap snapshots. Shown node count must be preserved after sorting. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-sorting-expected.txt index f0e034f..d18f644 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-containment-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sorting in Containment view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-event-listeners-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-event-listeners-expected.txt index 2aa753f..124680e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-event-listeners-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-event-listeners-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that event listeners not user reachable from the root are still present in the class list. PASS: the class name is found
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-expected.txt index d5e97c41..865765b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks HeapSnapshots module.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-function-location-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-function-location-expected.txt index fbb8b15..ea9cd17 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-function-location-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-function-location-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that function objects have source links in heap snapshot view. Function source: my-test-script.js:14
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt index 76c5aaf0..743e3ff 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that resolving heap snapshot object to a JS object will not crash on DOM wrapper boilerplate. Test passes if it doesn't crash. PASS: snapshot was taken
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-loader-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-loader-expected.txt index 6d1cdf9..ee42402 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-loader-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-loader-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks HeapSnapshots loader.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-orphan-nodes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-orphan-nodes-expected.txt index 56cfad3..6fe5fb7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-orphan-nodes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-orphan-nodes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that weak references are ignored when dominators are calculated and that weak references won't affect object's retained size. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-statistics-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-statistics-expected.txt index 2673e5d48..8ccaaf4c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-statistics-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-statistics-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Statistics view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expand-collapse-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expand-collapse-expected.txt index ffdb1a3..86e1350c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expand-collapse-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expand-collapse-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. https://crbug.com/738932 Tests the snapshot view is not empty on repeatitive expand-collapse. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt index d06e404..8b334a3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Summary view of detailed heap snapshots. Expanded nodes must be preserved after sorting. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-retainers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-retainers-expected.txt index fd8aaba..d3673d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-retainers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-retainers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests retainers view. - Number of retainers of an A object must be 2 (A itself and B). - When an object has just one retainer it must be expanded automatically until
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-by-id-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-by-id-expected.txt index dc8db54..1a9330b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-by-id-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-by-id-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests search in Summary view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-expected.txt index 14aa5a5..753dfc13 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests search in Summary view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-all-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-all-expected.txt index 36a3817..20989a05 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-all-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-all-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Summary view of detailed heap snapshots. The "Show All" button must show all nodes. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-next-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-next-expected.txt index 1688639..cccc404 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-next-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-next-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Summary view of detailed heap snapshots. Repeated clicks on "Show Next" button must show all nodes. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-ranges-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-ranges-expected.txt index 7fde097..a08e7c0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-ranges-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-show-ranges-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests showing several node ranges in the Summary view of detailed heap snapshot. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt index 2af8c7c..075fa7c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Summary view of detailed heap snapshots. Shown node count must be preserved after sorting. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-expected.txt index 7da0da1..34c39878 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sorting in Summary view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-fields-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-fields-expected.txt index 7da0da1..34c39878 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-fields-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-fields-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sorting in Summary view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-instances-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-instances-expected.txt index 7da0da1..34c39878 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-instances-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-summary-sorting-instances-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests sorting in Summary view of detailed heap snapshots. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-weak-dominator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-weak-dominator-expected.txt index ddca1b71..cea7df2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-weak-dominator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-weak-dominator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that weak references are ignored when dominators are calculated and that weak references won't affect object's retained size. Profiler was enabled.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/quick-open/command-menu-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/quick-open/command-menu-expected.txt index a587793..2f3163a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/quick-open/command-menu-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/quick-open/command-menu-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that the command menu is properly filled. Categories active:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/remote-object-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/remote-object-expected.txt index 52c2e26..0d62fb7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/remote-object-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/remote-object-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests formatting of different types of remote objects. date = Wed Dec 07 2011 12:01:00
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/report-API-errors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/report-API-errors-expected.txt index 9d64730e..c7986c6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/report-API-errors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/report-API-errors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that InspectorBackendStub is catching incorrect arguments. Protocol Error: Invalid type of argument 'userAgent' for method 'Network.setUserAgentOverride' call. It must be 'string' but it is 'number'.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/report-protocol-errors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/report-protocol-errors-expected.txt index a361760..f1e2268 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/report-protocol-errors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/report-protocol-errors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that InspectorBackendDispatcher is catching incorrect messages. {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-conversion-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-conversion-expected.txt index e9f8b31..2afaeb68 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-conversion-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-conversion-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests conversion of Inspector's resource representation into HAR format. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-headers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-headers-expected.txt index eb07e76..ffe048a6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-headers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-har-headers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the nondeterministic bits of HAR conversion via the magic of hard-coded values. Resource:{
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-expected.txt index 09243e7..b1f66b8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resources panel shows form data parameters. http://127.0.0.1:8000/devtools/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6-expected.txt index 95c10794..9ddd83b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-parameters-ipv6-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resources panel shows form data parameters. http://[::1]:8000/devtools/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/iframe-main-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/iframe-main-resource-expected.txt index fe43ea54..47c7322 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/iframe-main-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/iframe-main-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that iframe's main resource is reported only once. Reported resources:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-metadata-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-metadata-expected.txt index 1e91959f..6762ffa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-metadata-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-metadata-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that dynamically added resource has metadata. Last modified: 1989-12-01T08:00:00.000Z
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt index 0354bd42..a38ecbbf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource content is correctly loaded if Resource.requestContent was called before network request was finished. https://bugs.webkit.org/show_bug.cgi?id=90153 Adding dynamic script:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-while-loading-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-while-loading-expected.txt index d27417b..866cc12 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-while-loading-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-request-content-while-loading-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource content is correctly loaded if Resource.requestContent was called before network request was finished. https://bugs.webkit.org/show_bug.cgi?id=90153 Resource url: http://127.0.0.1:8000/devtools/resource-tree/resources/styles-initial.css
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-crafted-frame-add-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-crafted-frame-add-expected.txt index aba63a8..0f54a6e3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-crafted-frame-add-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-crafted-frame-add-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource tree model on crafted iframe addition (will time out on failure).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-document-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-document-url-expected.txt index 35291fb1..a0287ea2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-document-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-document-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resources have proper documentURL set in the tree model. http://127.0.0.1:8000/devtools/resource-tree/resources/resource-tree-reload-iframe.html => http://127.0.0.1:8000/devtools/resource-tree/resources/resource-tree-reload-iframe.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-events-expected.txt index 69202a7..42834dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests top frame navigation events. Navigating root frame
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-add-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-add-expected.txt index 3b2abd3..1179bdc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-add-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-add-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource tree model on iframe addition, compares resource tree against golden. Every line is important. Before addition
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-in-crafted-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-in-crafted-frame-expected.txt index d9b68e8..f6167d8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-in-crafted-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-in-crafted-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that frame inside crafted frame doesn't cause 'MainFrameNavigated' event and correctly attaches to frame tree. crbug/259036 FrameAdded id: 2, parentFrameId: 1, isMainFrame: false
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-navigate-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-navigate-expected.txt index 208d2b4..d0e2f63a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-navigate-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-frame-navigate-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource tree model on iframe navigation, compares resource tree against golden. Every line is important. Before navigation
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-htmlimports-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-htmlimports-expected.txt index c06d299..dc63763 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-htmlimports-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-htmlimports-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource tree model for imports. Resources:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt index 8ead216..b2e68ca 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that content is correctly shown for css loaded with invalid mime type in quirks mode. https://bugs.webkit.org/show_bug.cgi?id=80528 http://127.0.0.1:8000/devtools/resource-tree/resources/stylesheet-text-plain.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-no-xhrs-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-no-xhrs-expected.txt index 7ad9b08b..ec221d8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-no-xhrs-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-no-xhrs-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that XHRs are not added to resourceTreeModel. https://bugs.webkit.org/show_bug.cgi?id=60321
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-non-unique-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-non-unique-url-expected.txt index 547456b..f6b0717b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-non-unique-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-non-unique-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resources panel shows several resources with the same url if they were loaded with inspector already opened. Resources Tree:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-reload-expected.txt index 80b02dd2..40a86ab 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resource tree model on page reload, compares resource tree against golden. Every line is important. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/reveal-objects-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/reveal-objects-expected.txt index 0302376..d575101 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/reveal-objects-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/reveal-objects-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests object revelation in the UI.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime-expected.txt index e725413..5e93712 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks various Runtime functions.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt index 7f0380f..e323e9e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test frontend's timeout support.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-without-side-effects-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-without-side-effects-expected.txt index 0337729..6de09633 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-without-side-effects-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-without-side-effects-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test frontend's side-effect support check for compatibility.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-callFunctionOn-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-callFunctionOn-expected.txt index fc4a7ff..402f188 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-callFunctionOn-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-callFunctionOn-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests TestRunner.RuntimeAgent.callFunctionOn usages.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-es6-setSymbolPropertyValue-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-es6-setSymbolPropertyValue-expected.txt index 3917cce..d411901 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-es6-setSymbolPropertyValue-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-es6-setSymbolPropertyValue-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests editing Symbol properties.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-expected.txt index c709018..a45164f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests RemoteObject.getProperties.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-isOwnProperty-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-isOwnProperty-expected.txt index e18522f6..2697e31 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-isOwnProperty-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-getProperties-isOwnProperty-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests RemoteObject.getProperties. property.name=="testBar" isOwn=="true"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-localStorage-getProperties-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-localStorage-getProperties-expected.txt index f8cce45..78c4b4f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-localStorage-getProperties-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-localStorage-getProperties-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests RemoteObject.getProperties on localStorage object. 66215 {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-setPropertyValue-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-setPropertyValue-expected.txt index 4a0e645..a1b7790 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-setPropertyValue-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/runtime-setPropertyValue-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests WebInspector.RemoveObject.setPropertyValue implementation.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/schema-get-domains-matches-agents-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/schema-get-domains-matches-agents-expected.txt index 124c9b2..9695582 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/schema-get-domains-matches-agents-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/schema-get-domains-matches-agents-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that generated agent prototypes match with domains returned by schema.getDomains. domain Browser is missing from schema.getDomains
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/screen-orientation-override-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/screen-orientation-override-expected.txt index 56485c5..699f1910 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/screen-orientation-override-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/screen-orientation-override-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test screen orientation override.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching-expected.txt index a273df14..918f5f90 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test to ensure the consistency of front-end patterns vs backend patterns for request interception. Setting Pattern: **bar.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-ignore-binary-files-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-ignore-binary-files-expected.txt index 933228ff..c16c6715 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-ignore-binary-files-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-ignore-binary-files-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that search doesn't search in binary resources. Search result #1: uiSourceCode.url = http://127.0.0.1:8000/devtools/search/search-ignore-binary-files.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-non-existing-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-non-existing-resource-expected.txt index c708bb6..9527559 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-non-existing-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-non-existing-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests single resource search in inspector page agent with non existing resource url does not cause a crash. No resource with given URL found
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-resource-expected.txt index 801dacaadf..6b547f7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests single resource search in inspector page agent. http://127.0.0.1:8000/devtools/search/resources/search.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-script-expected.txt index 99a8fa0..038830a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests script search in inspector debugger agent. http://127.0.0.1:8000/devtools/search/resources/search.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-sourcemap-expected.txt index ff6c2e2..d986ef0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests single resource search in inspector page agent.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-static-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-static-expected.txt index b741d98..9d7f39b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-static-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-static-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests static content provider search. http://127.0.0.1:8000/devtools/search/resources/search.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-1-expected.txt index cda67e1..3732b1a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests different types of search-and-replace in SourceFrame Running replace test for /REPLACEME1/REPLACED/ (caseSensitive):
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-2-expected.txt index 1864792..8c6c9a0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests different types of search-and-replace in SourceFrame Running replace test for /replaceMe1/replaced/ :
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-3-expected.txt index 9709b4a6..828f2af 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests different types of search-and-replace in SourceFrame Running replace test for /(REPLACE)ME[38]/$1D/ (regex, caseSensitive):
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-4-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-4-expected.txt index 41c48d3..a434345 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-4-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-replace-4-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests different types of search-and-replace in SourceFrame Running replace test for /(replac)eMe[38]/$1d/ (regex):
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-search-expected.txt index dc9cdcb..b9a5f8c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/source-frame-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests different types of search in SourceFrame
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-expected.txt index db5a7afe..3a80f7ab 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that ScriptSearchScope performs search across all sources correctly. See https://bugs.webkit.org/show_bug.cgi?id=41350
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-in-files-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-in-files-expected.txt index af5c522f..1fad06a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-in-files-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-in-files-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that ScriptSearchScope performs search across all sources correctly. Total uiSourceCodes: 7
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-many-projects-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-many-projects-expected.txt index e173a7b..5aa3c254 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-many-projects-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-many-projects-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that ScriptSearchScope sorts network and dirty results correctly.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/blank-origins-not-shown-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/blank-origins-not-shown-expected.txt index ff23453..c50833e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/blank-origins-not-shown-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that blank origins aren't shown in the security panel origins list. Group: Main origin
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/blocked-mixed-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/blocked-mixed-content-expected.txt index ced5f44..1e0ba2c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/blocked-mixed-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/blocked-mixed-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests active mixed content blocking in the security panel. <DIV class=security-explanation security-explanation-info >
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/failed-request-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/failed-request-expected.txt index 709926a..6a4e7f4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/failed-request-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/failed-request-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that origins with failed requests are shown correctly in the security panel origins list. Group: Main origin
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/interstitial-sidebar-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/interstitial-sidebar-expected.txt index decd73e..3d1f0932 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/interstitial-sidebar-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/interstitial-sidebar-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the sidebar origin list disappears and appers when an interstitial is shown or hidden. Before interstitial is shown:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt index bc9da3c..40fc263 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the Main Origin is assigned even if there is no matching Request. Page origin: http://127.0.0.1:8000
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-active-and-passive-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-active-and-passive-reload-expected.txt index b34a37717..e4e455f1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-active-and-passive-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-active-and-passive-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the active and pasive mixed content explanations prompt the user to refresh when there are no recorded requests, and link to the network panel when there are recorded requests.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-reload-expected.txt index c0dd7e2..4860cdc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/mixed-content-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the mixed content explanation prompts the user to refresh when there are no recorded requests, and links to the network panel when there are recorded requests.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-group-names-unique-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-group-names-unique-expected.txt index c677a06..6642c81 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-group-names-unique-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-group-names-unique-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that origin group names in the Security panel are distinct. Number of names (4) == number of unique names (4): true (expected: true)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt index af134f2d..5e9a6d5e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the panel includes Certificate Transparency compliance status Panel on origin view:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt index b525227..3419710 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the panel transitions to the overview view when navigating to an interstitial. Regression test for https://crbug.com/638601 Before selecting origin view:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-blocked-mixed-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-blocked-mixed-content-expected.txt index ced5f44..1e0ba2c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-blocked-mixed-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-blocked-mixed-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests active mixed content blocking in the security panel. <DIV class=security-explanation security-explanation-info >
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt index 5638d88..61229f4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the security details for an origin are updated if its security state changes. Sidebar Origins --------------------------------
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-explanation-ordering-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-explanation-ordering-expected.txt index 104c328..bbf45ea 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-explanation-ordering-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-explanation-ordering-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that info explanations are placed after regular explanations. <DIV class=security-explanation security-explanation-secure >
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-state-comparator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-state-comparator-expected.txt index 804f3fc71..95048326 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-state-comparator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-state-comparator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that SecurityStateComparator correctly compares the severity of security states. Sign of SecurityStateComparator("info","info"): 0 (expected: 0)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-summary-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-summary-expected.txt index 24c6aac9..60b954d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-summary-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-summary-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests specifying a security summary for the Security panel overview. <DIV class=security-summary-text >
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-unknown-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-unknown-resource-expected.txt index a95b9c2b..0a1b117 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-unknown-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/security/security-unknown-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that requests to unresolved origins result in unknown security state and show up in the sidebar origin list. Group: Main origin
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/lazy-addeventlisteners-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/lazy-addeventlisteners-expected.txt index 8d9b376..89d6e95 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/lazy-addeventlisteners-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/lazy-addeventlisteners-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that a warning is shown in the console if addEventListener is called after initial evaluation of the service worker script. Message count: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-agents-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-agents-expected.txt index 112f1cc..8ebfc15 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-agents-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-agents-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the way service workers don't enable DOM agent and does enable Debugger agent. Debugger-related command should be issued: {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-manager-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-manager-expected.txt index 552d1b95d..e7a5c4d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-manager-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-manager-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the way service worker manager manages targets. Target added: Main; type: page
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-blocked-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-blocked-expected.txt index 4141088..0d92271 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-blocked-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-blocked-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests blocking fetch in Service Workers. Fetch in worker result: FETCH_FAILED
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-expected.txt index 92b7012f..17d3f48d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-network-fetch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests fetch in Service Workers. Fetch in worker result: Hello world
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-pause-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-pause-expected.txt index 33c7466..71dfbd59 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-pause-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-pause-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that we can pause in service worker. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt index 3512437..65a38e59 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests V8 cache information of Service Worker Cache Storage in timeline --- Trace events while installing -------------
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-cors-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-cors-expected.txt index a048c1db..b548e46 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-cors-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-cors-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "Bypass for network" checkbox works with CORS requests. crbug.com/771742 Loading an iframe.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-navigation-expected.txt index fe30670..1aa7c02 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "Bypass for network" checkbox works with navigations. crbug.com/746220 Loading an iframe.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-redirect-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-redirect-expected.txt index ff94fd897..824326e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-redirect-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-redirect-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "Bypass for network" checkbox with redirection doesn't cause crash. Success
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-force-update-on-page-load-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-force-update-on-page-load-expected.txt index 3b047582..8cd5ff0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-force-update-on-page-load-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-force-update-on-page-load-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "Force update on page load" checkbox A new ServiceWorker is activated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-navigation-preload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-navigation-preload-expected.txt index d82dae89..52c1c9f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-navigation-preload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-navigation-preload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the navigation request related events are available in the DevTools -----------------
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-redundant-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-redundant-expected.txt index 5325bce..ab554e06 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-redundant-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-redundant-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. ServiceWorkers must be shown correctly even if there is a redundant worker. The first ServiceWorker is activated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-view-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-view-expected.txt index 9733a2a8..c9e32a8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-view-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-view-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ServiceWorkersView on resources panel. Select ServiceWorkers tree element.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/user-agent-override-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/user-agent-override-expected.txt index ddf9879b..2abf263 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/user-agent-override-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/user-agent-override-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that User-Agent override works for requests from Service Workers. Enable emulation and set User-Agent override
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sha1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sha1-expected.txt index 8b74348..afe6db9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sha1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sha1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests SHA-1 hashes. foobar : 8843d7f92416211de9ebb963ff4ce28125932878
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-css-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-css-expected.txt index e3c611392..e524534 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-css-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-css-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies autocomplete suggestions for CSS file.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-general-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-general-expected.txt index fc2835c78..8812aa7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-general-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-general-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks how text editor updates autocompletion dictionary in a response to user input.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-hide-on-smart-brace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-hide-on-smart-brace-expected.txt index 13170bd..d90c3f1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-hide-on-smart-brace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-hide-on-smart-brace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that suggest box gets hidden whenever a cursor jumps over smart brace.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-scss-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-scss-expected.txt index 32c290f..8306194b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-scss-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/autocomplete-scss-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies autocomplete suggestions for SCSS file.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/bezier-swatch-position-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/bezier-swatch-position-expected.txt index 0faedae9..c925632 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/bezier-swatch-position-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/bezier-swatch-position-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that bezier swatches are updated properly in CSS Sources. Initial swatch positions:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/color-swatch-position-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/color-swatch-position-expected.txt index e2eeb857..f4b2146 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/color-swatch-position-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/color-swatch-position-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that color swatch positions are updated properly. Initial swatch positions:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/compile-javascript-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/compile-javascript-expected.txt index 834a60e..6ca47689 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/compile-javascript-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/compile-javascript-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies proactive javascript compilation. SourceFrame edit-me.js: 1 message(s)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-inline-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-inline-sourcemap-expected.txt index 3eee6b2..8ad7b26d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-inline-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-inline-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies that source maps are loaded if specified inside style tag. Source mapping loaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-outline-dialog-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-outline-dialog-expected.txt index 543aaff..22d253c9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-outline-dialog-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-outline-dialog-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Top-down test to verify css outline dialog. Cursor position: line 2, column 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-sourcemaps-toggle-enabled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-sourcemaps-toggle-enabled-expected.txt index 44ae19f2..eb58c03 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-sourcemaps-toggle-enabled-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-sourcemaps-toggle-enabled-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that CSS sourcemap enabling and disabling adds/removes sourcemap sources.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt index db669b4..41ee7e4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for async functions. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt index 4911b63c..44cd1d9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for async functions. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await3-expected.txt index 0328b5c..ca686c5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-callstack-async-await3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for async functions. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-pause-on-exception-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-pause-on-exception-expected.txt index 810f2c2..fe57330 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-pause-on-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-await/async-pause-on-exception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pause on promise rejection works. === Pausing only on uncaught exceptions ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-events-expected.txt index edc18fc..1fc4d30 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for various DOM events. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-expected.txt index bd83697..91b71b96 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks in debugger. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-get-as-string-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-get-as-string-expected.txt index cf25873..74be0e72 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-get-as-string-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-get-as-string-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for DataTransferItem.getAsString. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-in-console-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-in-console-expected.txt index f049d11..7695e25b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-in-console-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-in-console-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks printed in console. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-indexed-db-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-indexed-db-expected.txt index 0dc595c..e1c00bd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-indexed-db-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-indexed-db-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for IndexedDB. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-middle-run-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-middle-run-expected.txt index 5ac3ed9..10c5ff971 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-middle-run-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-middle-run-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that capturing asynchronous call stacks in debugger works if started after some time since the page loads. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-mutation-observer-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-mutation-observer-expected.txt index 8bc750b..f95fca7c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-mutation-observer-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-mutation-observer-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for MutationObserver. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-post-message-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-post-message-expected.txt index f9ae734..e38c0ef 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-post-message-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-post-message-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for window.postMessage. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-promises-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-promises-expected.txt index 7259d97..6b76ad9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-promises-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-promises-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for Promises. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-reload-no-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-reload-no-crash-expected.txt index 603f6e97..86d34953 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-reload-no-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-reload-no-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that page reload with async stacks turned on does not crash. Bug 441223. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-scripted-scroll-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-scripted-scroll-expected.txt index b4fe8ce7..f079cf0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-scripted-scroll-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-scripted-scroll-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for scripted scroll events. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-set-interval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-set-interval-expected.txt index 296949ce..b46f359 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-set-interval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-set-interval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for setInterval. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-web-sql-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-web-sql-expected.txt index 0db895a..6e51a7256 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-web-sql-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-web-sql-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for Web SQL. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-xhrs-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-xhrs-expected.txt index e6142aad..78dc340b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-xhrs-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-async/async-callstack-xhrs-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for XHRs. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-in-collected-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-in-collected-function-expected.txt index c80d022..62434d1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-in-collected-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-in-collected-function-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check that we can set breakpoint in collected function evaluate script and collect function foo.. set breakpoint inside function foo and dump it..
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-listeners-count-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-listeners-count-expected.txt index 5fb674d..2b0c4e7f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-listeners-count-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-listeners-count-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scripts panel does not create too many source frames.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-one-target-with-source-map-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-one-target-with-source-map-expected.txt index edb7ee44..60257be 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-one-target-with-source-map-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-one-target-with-source-map-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breakpoints work when one target has source map and another does not. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-dart-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-dart-expected.txt index 38ba9a4..473905d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-dart-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-dart-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks breakpoint in file with dart sourcemap breakpoint at 2 breakpoint at 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt index 7b91509c..ba58387 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks breakpoint in file with sourcemap Script execution paused. Call stack:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt index 1c73857..6510875 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breakpoints work in anonymous scripts with >1 targets. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame-expected.txt index 54cc17cb..4823250 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests setting breakpoint in source frame UI. Running: setBreakpoint
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers-expected.txt index 97718be..d4bc020c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests breakpoint works in multiple workers. Set different breakpoints and dump them breakpoint at 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation-expected.txt index 66a289d..ed76e8a0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests breakpoints on navigation. Set different breakpoints in inline script and dump them breakpoint at 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint-expected.txt index 1d8c5c4..0272ddf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests breakpoint is restored. Set different breakpoints and dump them breakpoint at 5 disabled
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint-expected.txt index 591177d..eb6c850 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests shifted breakpoint. Set enabled breakpoint close to shifted location breakpoint at 29
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-breakpoints-not-activated-on-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-breakpoints-not-activated-on-reload-expected.txt index fe8e4f1..a6ffe42 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-breakpoints-not-activated-on-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-breakpoints-not-activated-on-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breakpoints are not activated on page reload.Bug 41461 Main resource was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-disable-add-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-disable-add-breakpoint-expected.txt index a26ea63b..82be559 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-disable-add-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-disable-add-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breakpoints are correctly handled while debugger is turned off Main resource was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps-expected.txt index e653e02..75a5c72 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "reload" from within inspector window while on pause. Breakpoint sidebar pane before reload: source1.js:17}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-set-breakpoint-regex-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-set-breakpoint-regex-expected.txt index d7ced47..5c82cd5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-set-breakpoint-regex-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-set-breakpoint-regex-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests Debugger.setBreakpointByUrl with isRegex set to true.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/disable-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/disable-breakpoints-expected.txt index ae9cd336..4fab97e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/disable-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/disable-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests disabling breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector-expected.txt index 486a5e0..6e638165 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-editing-dom-from-inspector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that DOM debugger will not crash when editing DOM nodes from the Web Inspector. Chromium bug 249655
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-expected.txt index 572cd171..cc0c05d5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dom-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests DOM breakpoints. Running: testInsertChild
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dynamic-scripts-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dynamic-scripts-breakpoints-expected.txt index 4ed99b38..65d8d3a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dynamic-scripts-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/dynamic-scripts-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that there is no exception in front-end on page reload when breakpoint is set in HTML document and some dynamic scripts are loaded before the script with the breakpoint is loaded. Setting breakpoint: Reloading page.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension-expected.txt index ef7562f..0151bbac 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listener breakpoints. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt index f8d8ba1..df079da2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listener breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-script-first-stmt-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-script-first-stmt-expected.txt index c132c03..c99504e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-script-first-stmt-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-script-first-stmt-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listener breakpoint to break on the first statement of new scripts. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio-expected.txt index 6093a858..0fb4fb8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listener breakpoints for WebAudio. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-xhr-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-xhr-expected.txt index 9ebdce1..c21c0d7e1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-xhr-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-xhr-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listener breakpoints on XHRs. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap-expected.txt index f8815c7f1..0295149 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks inline breakpoint in file with sourcemap Setting breakpoint at second line.. breakpoint at 2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint-expected.txt index a6811a46..5c219fc7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests disabled breakpoint. Set breakpoint Run function and check pause
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt index 8fbf4e8c..d07dd24 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that front-end is able to set breakpoint for node.js scripts. Setting breakpoint:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/possible-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/possible-breakpoints-expected.txt index 0c9a612b..210558a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/possible-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/possible-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that BreakpointManager.possibleBreakpoints returns correct locations Locations for first line
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints-expected.txt index a898de9..eab53f9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/provisional-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests provisional breakpoints on navigation. Set breakpoint in inline script and dump it breakpoint at 3
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map-expected.txt index c13257b0..d33a0e6c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that we update breakpoint location on source map loading error. Breakpoint sidebar pane a.ts:2 console.log(42);
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-breakpoint-expected.txt index 8c47bb6..80e6fe8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests setting breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-conditional-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-conditional-breakpoint-expected.txt index 7ae6c9d..7e971abb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-conditional-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/set-conditional-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests setting breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint-expected.txt index a960ac99..ed9fde3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that locations are correctly resolved for gutter click. 3: breakpointAdded(3, 11)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/xhr-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/xhr-breakpoints-expected.txt index 08a0b3d..87ddf78 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/xhr-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/xhr-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests XHR breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debug-console-command-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debug-console-command-expected.txt index ed3021c..768dcd4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debug-console-command-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debug-console-command-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests debug(fn) console command.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debugger-command-line-api-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debugger-command-line-api-expected.txt index a90962a..8504ef574 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debugger-command-line-api-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/debugger-command-line-api-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect() command line api works while on breakpoint. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/step-into-async-fetch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/step-into-async-fetch-expected.txt index 1c19b44..2f7bcc93 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/step-into-async-fetch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-console/step-into-async-fetch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks stepInto fetch Script execution paused. Call stack:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-by-source-code-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-by-source-code-expected.txt index 9ab983a..c989047 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-by-source-code-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-by-source-code-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests provisional blackboxing. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-patterns-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-patterns-expected.txt index b3774fa..38716bc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-patterns-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-blackbox-patterns-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests framework blackbox patterns for various URLs. Testing "http://www.example.com/foo/jquery-1.7-min.js"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints-expected.txt index 94409bc..1aca5714 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests framework black-boxing on DOM, XHR and Event breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery-expected.txt index 0e2b3ef..04379ca 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests framework blackboxing feature on jQuery. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-break-program-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-break-program-expected.txt index 988f606d..e6e2cbb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-break-program-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-break-program-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that framework blackboxing skips instant pauses (e.g. breakpoints on console.assert(), setTimeout(), etc.) if they happen entirely inside the framework. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-exceptions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-exceptions-expected.txt index 90eddc0f..636fa15 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-exceptions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-exceptions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that framework black-boxing skips exceptions, including those that happened deeper inside V8 native script. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt index a556579..88a4ef8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the skip stack frames feature when stepping. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-sourcemap-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-sourcemap-expected.txt index f0560a0..cde1b137 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-sourcemap-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-sourcemap-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests framework blackboxing feature with sourcemaps. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt index ea0309d..35005a9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that stepping into blackboxed framework will not pause on setTimeout() inside the framework. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-steppings-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-steppings-expected.txt index 7291737..4c1cf70 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-steppings-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-steppings-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests stepping into/over/out with framework black-boxing. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-async-callstack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-async-callstack-expected.txt index 5267794b4..2310994 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-async-callstack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-async-callstack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the async call stacks and framework black-boxing features working together. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-worker-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-worker-expected.txt index caea5b9..4f79320 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-worker-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-frameworks/frameworks-with-worker-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that blackboxed script will be skipped while stepping on worker. Executing StepOver...
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-change-variable-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-change-variable-expected.txt index e7c5549..ab21a22 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-change-variable-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-change-variable-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that modifying local variables works fine. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-expected.txt index 1ae0afa..03bcc6a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that evaluation in the context of top frame will see values of its local variables, even if there are global variables with same names. On success the test will print a = 2(value of the local variable a). Bug 47358. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt index db7a5c05..dc8a50f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that evaluation on call frame works across all inspected windows in the call stack. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-expected.txt index 0ab31f4a..a501d38 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluation in console works fine when script is paused. It also checks that stack and global variables are accessible from the console. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt index 7db3255..e31a92cd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evaluation in console that throws works fine when script is paused. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-mute-exception-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-mute-exception-expected.txt index 76cf5bb..21715c7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-mute-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-mute-exception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pause on exception is muted when conditional breakpoint is set to "false". Script source was shown. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-no-nested-pause-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-no-nested-pause-expected.txt index 2ea35976..c5e30e86 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-no-nested-pause-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-no-nested-pause-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger will skip breakpoint hit when script execution is already paused. See bug Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-eval-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-eval-script-expected.txt index 2fe61ba..9dd0ac9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-eval-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-eval-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger will stop on "debugger" statement in a function that was added to the inspected page via evaluation in Web Inspector console. Script execution paused. Call stack:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-internal-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-internal-expected.txt index e6617047..e084f2f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-internal-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-in-internal-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pause on exception in internal script does not crash. Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-infinite-loop-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-infinite-loop-expected.txt index 568b043..95a81232 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-infinite-loop-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-infinite-loop-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that we can break infinite loop started from console. Run infinite loop Request pause
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-debugger-statement-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-debugger-statement-expected.txt index 01190b0..09a498a5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-debugger-statement-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-debugger-statement-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger will stop on "debugger" statement. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-exception-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-exception-expected.txt index 7f23d30..021e9300 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-exception-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pause on exception works. Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-failed-assertion-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-failed-assertion-expected.txt index 89a0f13b5..fe1b3840 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-failed-assertion-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-failed-assertion-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger breaks on failed assertion when pause on exception mode is enabled. Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-promise-rejection-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-promise-rejection-expected.txt index c214bddf..d299b577 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-promise-rejection-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-on-promise-rejection-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pause on promise rejection works. === Pausing only on uncaught exceptions ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-with-overrides-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-with-overrides-expected.txt index f056895..423d81d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-with-overrides-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-pause-with-overrides-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger will stop on "debugger" statement w/ overriden string, etc. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-resume-button-in-overlay-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-resume-button-in-overlay-expected.txt index 2d4734e2..a150353 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-resume-button-in-overlay-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-resume-button-in-overlay-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resume button in overlay works Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/eval-on-pause-blocked-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/eval-on-pause-blocked-expected.txt index 4e84328..8fb6254 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/eval-on-pause-blocked-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/eval-on-pause-blocked-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that evaluation in the context of top frame will not be blocked by Content-Security-Policy. Bug 77203. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/function-name-in-callstack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/function-name-in-callstack-expected.txt index 07494cc..2a8e4f1a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/function-name-in-callstack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/function-name-in-callstack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that callFrames on pause contains function name taking into account displayName and Function.name. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script-expected.txt index c4423d4..6125a30f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that main resource script text is correct when paused in inline script on reload. Script execution paused. Did load front-end
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-internal-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-internal-script-expected.txt index 8fba2b86..2ef6db3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-internal-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-internal-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that internal scripts unknown to front-end are processed correctly when appear in debugger call frames. Bug 64995
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-on-elements-panel-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-on-elements-panel-expected.txt index 1111b77..560348c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-on-elements-panel-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-on-elements-panel-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger pause button works on Elements panel after a DOM node highlighting. Chromium bug 433366 Call stack:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/set-return-value-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/set-return-value-expected.txt index 95f05fd..005e5e6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/set-return-value-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/set-return-value-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check that return value can be changed. Set timer for test function. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/skip-pauses-until-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/skip-pauses-until-reload-expected.txt index 6186e44b..499fa89 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/skip-pauses-until-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/skip-pauses-until-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that 'skip all pauses' mode blocks breakpoint and gets cancelled right at page reload. Script source was shown. Set up breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-expected.txt index 94719b1..a458101e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "step in" functionality in debugger. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-ignore-injected-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-ignore-injected-script-expected.txt index f5c3a3e..ae41296b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-ignore-injected-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-in-ignore-injected-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that stepInto doesn't pause in InjectedScriptSource. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-across-timeouts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-across-timeouts-expected.txt index 87c89ce..2405047 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-across-timeouts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-across-timeouts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepInto will stop inside next timeout handler. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-custom-element-callbacks-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-custom-element-callbacks-expected.txt index cef613a..28a6ee5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-custom-element-callbacks-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-custom-element-callbacks-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that stepping into custom element methods will lead to a pause in the callbacks. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-document-write-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-document-write-expected.txt index e53800f..3b9ac36 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-document-write-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-document-write-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepInto will step into inlined scripts created by document.write(). Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-event-listener-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-event-listener-expected.txt index c7e8ec8..df6db55 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-event-listener-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-event-listener-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that stepping into dispatchEvent() method will lead to a pause in the first event listener. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt index 11910fc..e311c1a8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepInto will step through inlined scripts. Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-across-timeouts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-across-timeouts-expected.txt index a9b53c64..ea20918 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-across-timeouts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-across-timeouts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepOut will stop inside next timeout handler. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-custom-element-callbacks-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-custom-element-callbacks-expected.txt index 107a47da..28f606a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-custom-element-callbacks-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-custom-element-callbacks-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests stepping out from custom element callbacks. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-document-write-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-document-write-expected.txt index dcc0b0a..b99cbe1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-document-write-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-document-write-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepOut will skip inlined scripts created by document.write(). Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-event-listener-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-event-listener-expected.txt index 1f53e52..462d256a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-event-listener-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-event-listener-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that stepping out of an event listener will lead to a pause in the next event listener. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-expected.txt index 4c3afbe..e82f559 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-out-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "step out" functionality in debugger. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-across-timeouts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-across-timeouts-expected.txt index b741caa..630726e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-across-timeouts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-across-timeouts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepOver will stop inside next timeout handler. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-document-write-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-document-write-expected.txt index 6d665ab5..323275e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-document-write-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-document-write-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepOver will skip inlined scripts created by document.write(). Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-expected.txt index 79815e7..63b77d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "step over" functionality in debugger. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt index c91ce1f4..2448111 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger StepOver will step through inlined scripts. Script source was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-through-promises-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-through-promises-expected.txt index 2134860f..35e32c9f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-through-promises-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/debugger-step-through-promises-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger will step through Promise handlers while not stepping into V8 internal scripts. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/step-through-event-listeners-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/step-through-event-listeners-expected.txt index d8799920..80b6a63b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/step-through-event-listeners-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-step/step-through-event-listeners-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that debugger will pause in all event listeners when corresponding breakpoint is set. Bug 77331.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-async-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-async-function-expected.txt index 549cfad..5051888c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-async-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-async-function-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that call stack sidebar contains correct labels for async await functions. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-url-expected.txt index 0a06c97..fa51da9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that call stack sidebar contains correct urls for call frames. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-worker-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-worker-expected.txt index 11325f4..9aa1d3d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-worker-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/async-call-stack-worker-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests async call stack for workers. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-empty-event-listener-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-empty-event-listener-expected.txt index 8d73b02..2493d3a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-empty-event-listener-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-empty-event-listener-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scheduled pause is cleared after processing event with empty handler. Call stack:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt index 2ba88a1..e9281741 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scheduled pause is cleared after processing event with empty handler. Call stack:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/call-stack-show-more-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/call-stack-show-more-expected.txt index 43732ef..25cb3ff2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/call-stack-show-more-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/call-stack-show-more-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "Show more" button in CallStackSidebarPane. Set timer for test function. callWithAsyncStacktest.js:19
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/callstack-placards-discarded-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/callstack-placards-discarded-expected.txt index 83c210d6..b3b43da 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/callstack-placards-discarded-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/callstack-placards-discarded-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that RawSourceCode listeners count won't grow on each script pause. Bug 70996
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint-expected.txt index a8349836..bd7e2f1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breakpoints can be added and removed by clicking the gutter. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-expected.txt index a0b0102..fa5a920 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that continue to location markers are computed correctly. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function-expected.txt index 718f010..c146676 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that continue to location markers are computed correctly. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/copy-stack-trace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/copy-stack-trace-expected.txt index 0640224..3e7153e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/copy-stack-trace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/copy-stack-trace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger will copy valid stack trace upon context menu action. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/custom-element-lifecycle-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/custom-element-lifecycle-events-expected.txt index 58c4ea2d..147a862 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/custom-element-lifecycle-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/custom-element-lifecycle-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that custom element lifecycle events fire while debugger is paused. Custom element registered.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-expand-scope-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-expand-scope-expected.txt index 5c0cc59..bda4f99 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-expand-scope-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-expand-scope-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that sections representing scopes of the current call frame are expandable and contain correct data. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-expected.txt index d253eaa..69171a53 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inline values rendering in the sources panel. =========== 11< ==========
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-frames-expected.txt index 34f098f..b0212b9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-frames-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inline values rendering while stepping between call frames. =========== 11< ==========
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-save-to-temp-var-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-save-to-temp-var-expected.txt index 12e0c1a1..fe3c5c5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-save-to-temp-var-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-save-to-temp-var-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests saving objects to temporary variables while paused. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/error-in-watch-expressions-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/error-in-watch-expressions-expected.txt index abfb8022..4e9731e6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/error-in-watch-expressions-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/error-in-watch-expressions-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that watches pane renders errors in red. SUCCESS
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/execution-context-sorted-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/execution-context-sorted-expected.txt index c1256c4..19a0ce9a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/execution-context-sorted-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/execution-context-sorted-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how execution context and target are selected. top
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-details-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-details-expected.txt index 5566289..c1abc7b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-details-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-details-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Debugger.getFunctionDetails command returns correct location. Bug 71808
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-display-name-call-stack-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-display-name-call-stack-expected.txt index 9f190c8..cee1d15 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-display-name-call-stack-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-display-name-call-stack-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that we display function's "displayName" property in the call stack. CrBug 17356 Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-generator-details-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-generator-details-expected.txt index fdb789a0..1c1ef9a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-generator-details-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/function-generator-details-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Debugger.getGeneratorObjectDetails command returns correct result.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/inline-scope-variables-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/inline-scope-variables-expected.txt index e8bcb667..8d5a3c6a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/inline-scope-variables-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/inline-scope-variables-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inline scope variables are rendering correctly. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context-expected.txt index 78d7ee8..b806d9b8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how execution context and target are selected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/monitor-console-command-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/monitor-console-command-expected.txt index 89fdf94e..024cd245 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/monitor-console-command-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/monitor-console-command-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests traceCalls(fn) console command.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/popover-for-spread-operator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/popover-for-spread-operator-expected.txt index fe244e4..3fb610f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/popover-for-spread-operator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/popover-for-spread-operator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests popver for spread operator. Request popover for array:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-execution-line-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-execution-line-expected.txt index 4dc46f7..04b70c7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-execution-line-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-execution-line-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that execution line is revealed and highlighted when debugger is paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-not-skipped-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-not-skipped-expected.txt index 30586ad..ea78bb35 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-not-skipped-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-not-skipped-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that certain user actions in scripts panel reveal execution line.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-2-expected.txt index b703bf6a..04544f2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the script formatting is working fine with breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-3-expected.txt index a3f6f63..3e61382 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-breakpoints-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the script formatting is working fine with breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-search-expected.txt index ee97a25..7ef6f6f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-formatter-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that search across files works with formatted scripts. Pre-format search results:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-snippet-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-snippet-model-expected.txt index c1422fc..bcaefb3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-snippet-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/script-snippet-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests script snippet model.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-panel-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-panel-expected.txt index 0a20789..f3322af 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-panel-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-panel-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scripts panel UI elements work as intended.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting-expected.txt index 5996176..82655f4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests scripts sorting in the scripts panel. Sources:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-with-same-source-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-with-same-source-url-expected.txt index 2f3f68a..4e0e8525 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-with-same-source-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-with-same-source-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that script is replaced with the newer version when the names match. Added: debugger:///VMXX MyScript.js to debugger
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/selected-call-frame-after-formatting-source-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/selected-call-frame-after-formatting-source-expected.txt index a53274ca..240d9f4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/selected-call-frame-after-formatting-source-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/selected-call-frame-after-formatting-source-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests selected call frame does not change when pretty-print is toggled. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-function-definition-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-function-definition-expected.txt index 6e4dff8..199787d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-function-definition-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-function-definition-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that "Show Function Definition" jumps to the correct location.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-generator-location-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-generator-location-expected.txt index 0a293f9..cdacf03 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-generator-location-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/show-generator-location-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that "Show Generator Location" jumps to the correct location.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-frame-expected.txt index 2363be4..a783c08 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that it's possible to set breakpoint in source frame, and that source frame displays breakpoints and console errors.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-url-comment-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-url-comment-expected.txt index c30a149..c4f717e6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-url-comment-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-url-comment-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evals with sourceURL comment are shown in scripts panel.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/switch-file-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/switch-file-expected.txt index a8d6c1c..b9e0468 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/switch-file-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/switch-file-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how switch to next file with the same name and different extension feature works. Dumping next file for each file:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-display-name-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-display-name-expected.txt index f656aa9..0fe163c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-display-name-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-display-name-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests UISourceCode display name. UISourceCode display name for url "http://localhost:8080/folder/filename?parameter=value&nnn=1" is "filename?parameter=value&nnn=1".
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-expected.txt index 3c28df80..ce9a7a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/ui-source-code-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests UISourceCode class.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-panel-switch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-panel-switch-expected.txt index 996471a..4bab2e98 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-panel-switch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-panel-switch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests debugger does not fail when stopped while a panel other than scripts was opened. Both valid and invalid expressions are added to watch expressions. Watches before running testFunction:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt index 8fe7ba7..a5005cb3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that watch expressions expansion state is restored after update. Watch expressions added.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/anonymous-script-with-source-map-breakpoint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/anonymous-script-with-source-map-breakpoint-expected.txt index 1b77e3d..5f154b7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/anonymous-script-with-source-map-breakpoint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/anonymous-script-with-source-map-breakpoint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests breakpoint in anonymous script with source map on reload. Script execution paused. Script execution resumed.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-fetch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-fetch-expected.txt index 97d6af4..4f76647 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-fetch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-fetch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks for fetch. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-expected.txt index cf6f7a6..65de18c7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous call stacks printed in console for a Network.Initiator. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-image-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-image-expected.txt index d59d6a3..38485ece 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-image-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/async-callstack-network-initiator-image-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests asynchronous network initiator for image loaded from JS. async-callstack-network-initiator-image.js:14
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-expected.txt index 9277367..d4c5aa27 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that all inlined scripts from the same document are shown in the same source frame with html script tags. Script source was shown. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-fragment-id-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-fragment-id-expected.txt index ac34475..3a0c32d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-fragment-id-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debug-inlined-scripts-fragment-id-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that all inlined scripts from the same document are shown in the same source frame with html script tags. Bug 54544. window.location: #hash
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-autocontinue-on-syntax-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-autocontinue-on-syntax-error-expected.txt index f0526df..dd391bd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-autocontinue-on-syntax-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-autocontinue-on-syntax-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugger won't stop on syntax errors even if "pause on uncaught exceptions" is on. syntax-error.html:4 Uncaught SyntaxError: Unexpected token )
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-compile-and-run-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-compile-and-run-expected.txt index fa7e86f..634fe520 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-compile-and-run-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-compile-and-run-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests separate compilation and run.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame-expected.txt index f8681ab..b707ec2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that completions in the context of the call frame will result in names of its scope variables.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-cyclic-reference-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-cyclic-reference-expected.txt index 1980c43..ae2703f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-cyclic-reference-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-cyclic-reference-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that debugging a page where Object prototype has a cyclic reference won't crash the browser.Bug 43558 Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-disable-enable-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-disable-enable-expected.txt index 2e4b31f..b9c1922 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-disable-enable-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-disable-enable-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that breakpoints are successfully restored after debugger disabling. Main resource was shown.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-es6-harmony-scopes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-es6-harmony-scopes-expected.txt index fa559246..7da4b344 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-es6-harmony-scopes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-es6-harmony-scopes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ES6 harmony scope sections. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-minified-variables-evalution-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-minified-variables-evalution-expected.txt index 910c6e5..7f481b4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-minified-variables-evalution-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-minified-variables-evalution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests evaluation in minified scripts. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-proto-property-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-proto-property-expected.txt index d3deed0..7c69d82 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-proto-property-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-proto-property-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that object's __proto__ property is present in object properties section when script is paused on a breakpoint.Bug 41214 Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-reload-on-pause-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-reload-on-pause-expected.txt index b231884b..e791e8c1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-reload-on-pause-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-reload-on-pause-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests "reload" from within inspector window while on pause. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-return-value-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-return-value-expected.txt index 98cd2c8..362e0688 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-return-value-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-return-value-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests function's return value reported from backend. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-minified-variables-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-minified-variables-expected.txt index 6778500..12fc19f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-minified-variables-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-minified-variables-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resolving variable names via source maps. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-identifiers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-identifiers-expected.txt index 99157ac2..8c543d8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-identifiers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-identifiers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resolving variable names via source maps. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt index 8c08f20..670b96b2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests resolving this object name via source maps. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-expected.txt index fce77c6..f380a57 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that valid parsed script notifications are received by front-end. script 1: start: 1:12
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-reload-expected.txt index 514c3f76..db57305d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scripts-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scripts list is cleared upon page reload. Dummy script found: dummyScript.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-suspend-active-dom-objects-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-suspend-active-dom-objects-expected.txt index 54d2f7c..8405958 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-suspend-active-dom-objects-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-suspend-active-dom-objects-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that browser won't crash if user evaluates something in the console that would suspend active dom objects (e.g. if user attempts to show an alert) when script execution is paused on a breakpoint and all active dom objects are already suspended. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dont-report-injected-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dont-report-injected-script-expected.txt index 37fdfbfa..53c942a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dont-report-injected-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dont-report-injected-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that injected script isn't reported to frontend. foo.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-script-tag-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-script-tag-expected.txt index bdfde92..5eecfec 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-script-tag-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-script-tag-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inline scripts and document.write scripts get different uiSourceCodes with different URLs. Running: testOpenDevToolsAfterLoad
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-scripts-expected.txt index c3f96cf..3f5f5af0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/dynamic-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scripts for dynamically added script elements are shown in sources panel if loaded with inspector open. UISourceCodes:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/extract-javascript-identifiers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/extract-javascript-identifiers-expected.txt index 673cdc35f..ab0c720 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/extract-javascript-identifiers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/extract-javascript-identifiers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the extraction of javascript identifier names from function text.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/js-with-inline-stylesheets-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/js-with-inline-stylesheets-expected.txt index fbc526e..6101ea1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/js-with-inline-stylesheets-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/js-with-inline-stylesheets-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that JS sourcemapping for inline scripts followed by inline stylesheets does not break.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-breakpoints-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-breakpoints-expected.txt index cc63595d..1d816b71 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-breakpoints-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-breakpoints-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests breakpoints are correctly dimmed and restored in JavaScriptSourceFrame during live edit.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-expected.txt index 55b9e91c5..60f5ebf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests live edit feature.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-no-reveal-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-no-reveal-expected.txt index b05f78a..5d6a1a1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-no-reveal-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-no-reveal-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests live edit feature. @@ -29,7 +30,7 @@ Script execution resumed. Script execution paused. Script execution resumed. -Cursor position is: (2, 4). +Cursor position is: (8, 20). Running: testLiveEditWithStepInWhenPausedThenStepIntoCausesCursorMove Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-original-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-original-content-expected.txt index 4e33695..d39148a8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-original-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/live-edit-original-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the original content is accessible on live edited scripts. ==== Original Content ====
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/mutation-observer-suspend-while-paused-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/mutation-observer-suspend-while-paused-expected.txt index bfe2781..4e3defaf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/mutation-observer-suspend-while-paused-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/mutation-observer-suspend-while-paused-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that DOM Mutation Observers do not attempt to deliver mutation records while the debugger is paused.Bug 105810 DIV and observer setup.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view-expected.txt index 5a64206..bab3086 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests scripts panel file selectors.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/network-uisourcecode-provider-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/network-uisourcecode-provider-expected.txt index 2ebefb56..c99fa8a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/network-uisourcecode-provider-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/network-uisourcecode-provider-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests NetworkUISourceCodeProvider class.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/pause-in-removed-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/pause-in-removed-frame-expected.txt index 2f54b78..7a861bf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/pause-in-removed-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/pause-in-removed-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests pause functionality in detached frame. Set timer for test function. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/properties-special-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/properties-special-expected.txt index 8aaa146..0253ad6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/properties-special-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/properties-special-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how debugger presents special properties of closures, bound functions and object wrappers. properties-special.js:11 Boolean __proto__: Boolean
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/resource-script-mapping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/resource-script-mapping-expected.txt index 5835ea1..4c0feb4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/resource-script-mapping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/resource-script-mapping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests ResourceScriptMapping class. Waiting for scripts
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/rethrow-error-from-bindings-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/rethrow-error-from-bindings-crash-expected.txt index e99a7ee..1590dae 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/rethrow-error-from-bindings-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/rethrow-error-from-bindings-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that pausing on uncaught exceptions thrown from C++ bindings will not crash. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-collected-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-collected-expected.txt index 794a28f9..01baa03e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-collected-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-collected-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that DiscardedAnonymousScriptSource event is fired and workspace is cleared. Discarded: 1100
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-failed-to-parse-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-failed-to-parse-expected.txt index b8091a21..0996894 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-failed-to-parse-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/script-failed-to-parse-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that ParsedScriptSource event is raised after compile script with syntax error.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt index 52c2b75..9fe54587 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that JavaScriptSourceFrame show breakpoints correctly
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt index b994268..0dbf0d8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that JavaScriptSourceFrame show inline breakpoints correctly
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-map-http-header-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-map-http-header-expected.txt index 73400dd..f5f5d726 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-map-http-header-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-map-http-header-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that SourceMap and X-SourceMap http headers are propagated to scripts in the front-end. Added script:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/sources-panel-content-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/sources-panel-content-scripts-expected.txt index ab5df7d..e6a6c8f1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/sources-panel-content-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/sources-panel-content-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that content scripts are reported. Content Scripts:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-expected.txt index b8db886..88a50d90 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests stopping in debugger in the worker. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-script-mapping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-script-mapping-expected.txt index af8f6c9b..d61312a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-script-mapping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/worker-debugging-script-mapping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests stopping in debugger in the worker with source mapping. Script execution paused.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/dont-diverge-script-evaluated-twice-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/dont-diverge-script-evaluated-twice-expected.txt index 68e896e..0b9f01a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/dont-diverge-script-evaluated-twice-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/dont-diverge-script-evaluated-twice-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks that script evaluated twice with different source and the same sourceURL won't be diverged from VM.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/event-listener-breakpoints-script-fst-stmt-for-module-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/event-listener-breakpoints-script-fst-stmt-for-module-expected.txt index acb5710..aa8651f8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/event-listener-breakpoints-script-fst-stmt-for-module-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/event-listener-breakpoints-script-fst-stmt-for-module-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests event listener breakpoint to break on the first statement of new modules. Set timer for test function.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-css-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-css-expected.txt index b5880c2..cfd44868f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-css-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-css-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how SourceFormatter handles CSS sources Formatted:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-js-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-js-expected.txt index 3bf673b..60db4dc 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-js-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/formatter-js-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests how SourceFormatter handles JS sources Formatted:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inline-script-with-source-map-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inline-script-with-source-map-expected.txt index 18c44d80..6b3eed5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inline-script-with-source-map-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inline-script-with-source-map-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inline source with source map. Set breakpoint at console.log line Call function and dump stack trace
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inspect-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inspect-function-expected.txt index 7f2f230..466e4407 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inspect-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/inspect-function-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that inspect object action works for function and resolve bound function location. Function was revealed:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/javascript-outline-dialog-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/javascript-outline-dialog-expected.txt index c72dcfc..a41c63e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/javascript-outline-dialog-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/javascript-outline-dialog-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify JavaScriptOutlineDialog scoring. Scores for query="te"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/js-sourcemaps-toggle-enabled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/js-sourcemaps-toggle-enabled-expected.txt index e446bcc0..b7ef248 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/js-sourcemaps-toggle-enabled-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/js-sourcemaps-toggle-enabled-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that JavaScript sourcemap enabling and disabling adds/removes sourcemap sources.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/navigator-view-content-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/navigator-view-content-scripts-expected.txt index 577ac30f..39c5eccd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/navigator-view-content-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/navigator-view-content-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that removal of one of the multiple projects, all of which are associated with the same frame, doesn't lead navigator to discard the frame treenode.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-1-expected.txt index d2d0323..d9eeadd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify javascript outline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-2-expected.txt index b05c51c..f84e1239 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify javascript outline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-3-expected.txt index 0e94278..11f1ef6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify javascript outline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-4-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-4-expected.txt index d01f43c..4daf2266 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-4-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-4-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify javascript outline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-5-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-5-expected.txt index cb02b62..c32b7e7d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-5-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-5-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify javascript outline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-6-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-6-expected.txt index b936ab8..c68b33c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-6-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/outline-javascript-6-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify javascript outline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-1-expected.txt index 1996d104..0fe0ede 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies CSS pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-2-expected.txt index 03fa5d53..39f8be4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies CSS pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-3-expected.txt index 84d3898..f6928cf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-css-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies CSS pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-1-expected.txt index f7afe9b9..0b16624 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-2-expected.txt index 24df69df..d6da9e0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-3-expected.txt index 19db3a2f3..474f409 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-html-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-1-expected.txt index 3e4dfa22..f3622ab6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-2-expected.txt index 627afa41..0472713 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-3-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-3-expected.txt index c90de76..a07fba3b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-3-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-3-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-4-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-4-expected.txt index 96f3d48..b11beb5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-4-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-4-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-5-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-5-expected.txt index be3d728..ff8fd31 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-5-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-5-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-6-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-6-expected.txt index ab1a048..36f61fd9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-6-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-6-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-7-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-7-expected.txt index 95982df..eaf8207 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-7-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-7-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-8-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-8-expected.txt index 6c3f1cf..f599d31 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-8-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-8-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-9-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-9-expected.txt index 100a911..032c6bdf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-9-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-9-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-classes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-classes-expected.txt index 06080dc..0c70c75 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-classes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-classes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-template-literals-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-template-literals-expected.txt index 925409b..511719f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-template-literals-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/pretty-print-javascript-template-literals-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies JavaScript pretty-printing functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sass-highlighter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sass-highlighter-expected.txt index fc388861..0d55442 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sass-highlighter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sass-highlighter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that highlighter type for SCSS file loaded via sourceMap is correct. text/x-scss
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/search-config-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/search-config-expected.txt index f227c261..79e0ea11 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/search-config-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/search-config-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests search query parsing. Dumping parsed search query [function]:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/source-code-diff-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/source-code-diff-expected.txt index 1292858a..bfa2438c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/source-code-diff-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/source-code-diff-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that diff markers correctly appear in the gutter. 0:Modify
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sourcemap-hot-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sourcemap-hot-reload-expected.txt index 30edf6e..9d7ae77 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sourcemap-hot-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sourcemap-hot-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that sourcemap sources are updated when a new sourcemap is added Evaluating script with new source map.. console.log(1);
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-extension-names-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-extension-names-expected.txt index f6dffa9..4fa267d5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-extension-names-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-extension-names-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies that extension names are resolved properly in navigator view.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-focus-editor-on-select-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-focus-editor-on-select-expected.txt index c3b30c3..a762e0bf5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-focus-editor-on-select-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-panel-focus-editor-on-select-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that text editor has focus after panel re-selecting. initial: focused = true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-pretty-print-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-pretty-print-expected.txt index fd1e18b..8e9d57c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-pretty-print-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/sources-pretty-print-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verifies that editing a pretty printed resource works properly. * Initial state *
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-highlight-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-highlight-expected.txt index cfc46b4..33e0b4a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-highlight-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-highlight-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that network-loaded UISourceCodes are highlighted according to their HTTP header mime type instead of their extension. crbug.com/411863
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-metadata-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-metadata-expected.txt index ea24df96..6cb85eb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-metadata-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/sources/ui-source-code-metadata-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that network UISourceCode has metadata.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/cached-resource-metadata-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/cached-resource-metadata-expected.txt index 833ab7d..c23f994 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/cached-resource-metadata-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/cached-resource-metadata-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify that cached resource has metadata. Last modified: 1989-12-01T08:00:00.000Z
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-navigation-expected.txt index 8afcedea..d6afc49 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector will discard console message arguments and convert first argument into a string when iframe where the message was logged is navigated to a different page. Message: "A message with first argument string", arguments: [string]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-remove-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-remove-expected.txt index 713da739..de880a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-remove-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-clear-arguments-on-frame-remove-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console message arguments will be cleared and first argument will be converted into a string when iframe where the messages were created is removed. Message: "A message with first argument string", arguments: [string]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-source-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-source-url-expected.txt index d9836114..29cd930 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-source-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-source-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when exception happens before inspector is open source url is correctly shown in console. foo2.js:1 Uncaught ReferenceError: FAIL is not defined
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-while-no-inspector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-while-no-inspector-expected.txt index f5fd37d..a9a113e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-while-no-inspector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-exception-while-no-inspector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console will NOT contain stack trace for exception thrown when inspector front-end was closed. Bug 109427. https://bugs.webkit.org/show_bug.cgi?id=109427 SUCCESS: message doesn't have stack trace
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-log-before-frame-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-log-before-frame-navigation-expected.txt index fb8fba96..5adf82e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-log-before-frame-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-log-before-frame-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector won't crash if there are messages written to console from a frame which has already navigated to a page from a different domain. Received console messages:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-promise-reject-and-handle-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-promise-reject-and-handle-expected.txt index 6178cde..d0b4fec1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-promise-reject-and-handle-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-promise-reject-and-handle-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that evt.preventDefault() in window.onunhandledrejection suppresses console output. ----console messages start----
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-stack-overflow-source-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-stack-overflow-source-url-expected.txt index 7c87269..46d9501 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-stack-overflow-source-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-stack-overflow-source-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that when stack overflow happens before inspector is open source url is correctly shown in console. foo2.js:1 Uncaught RangeError: Maximum call stack size exceeded
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-bigint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-bigint-expected.txt index 25cc56f..070d2b0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-bigint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-bigint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console logging for messages with BigInts that happen before DevTools is open. console-format-startup-bigint.html:5 1n
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-expected.txt index d760a150..7f82664 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console logging for messages that happen before DevTools is open. console-format-startup.html:21 Array(10)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-uncaught-promise-no-inspector-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-uncaught-promise-no-inspector-expected.txt index 2db76b4..3b5632b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-uncaught-promise-no-inspector-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-uncaught-promise-no-inspector-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that uncaught promise rejection messages have line numbers when the inspector is closed and stack traces are not collected. console-uncaught-pro…no-inspector.html:4 Uncaught (in promise) Error: err1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/database-open-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/database-open-expected.txt index eb20697..54b911e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/database-open-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/database-open-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector gets populated with databases that were opened before inspector is shown. Name: InspectorDatabaseTest
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dedicated-workers-list-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dedicated-workers-list-expected.txt index 63304b1..2ed9654 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dedicated-workers-list-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dedicated-workers-list-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that dedicated workers created before worker inspection was enabled will be reported to the front-end. Bug 72020 https://bugs.webkit.org/show_bug.cgi?id=72020 Worker inspection enabled
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/document-write-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/document-write-expected.txt index 612209d..b84d1897 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/document-write-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/document-write-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that console reports zero line number for scripts generated with document.write. https://bugs.webkit.org/show_bug.cgi?id=71099 document-write.html:4 Line 4
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dom-storage-open-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dom-storage-open-expected.txt index a468211..4b0ce09 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dom-storage-open-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dom-storage-open-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Web Inspector gets populated with DOM storages according to security origins found in the page. SecurityOrigin: http://127.0.0.1:8000
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dynamic-scripts-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dynamic-scripts-expected.txt index b129381..98b2d37 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dynamic-scripts-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/dynamic-scripts-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that scripts for dynamically added script elements are shown in sources panel if inspector is opened after the scripts were loaded. https://bugs.webkit.org/show_bug.cgi?id=99324 UISourceCodes:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/main-resource-content-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/main-resource-content-expected.txt index 2a38b660..3d92bf6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/main-resource-content-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/main-resource-content-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests main resource content is correctly loaded and decoded using correct encoding. Requesting content:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/resource-tree-mimetype-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/resource-tree-mimetype-expected.txt index 9d8ac30..4d3e92d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/resource-tree-mimetype-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/resource-tree/resource-tree-mimetype-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that resources panel correctly shows mime type when it loads data from memory cache. https://bugs.webkit.org/show_bug.cgi?id=63701 image text/html http://127.0.0.1:8000/devtools/devtools/resource-tree/resources/empty.png
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/shadow-dom-rules-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/shadow-dom-rules-expected.txt index 75cc7a5..d790822 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/shadow-dom-rules-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/shadow-dom-rules-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test checks that style sheets hosted inside shadow roots could be inspected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/linkifier-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/linkifier-expected.txt index 469c415..d28d2b7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/linkifier-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/linkifier-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Linkifier works correctly. listeners added on raw source code: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-1-expected.txt index 0505d56a..890c218 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the script formatting is working fine with breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4-expected.txt index 6ab3599..618c19f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-breakpoints-4-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the script formatting is working fine with breakpoints.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-console-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-console-expected.txt index dbfefcd..9b1c7c0d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-console-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/startup/sources/debugger/script-formatter-console-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the script formatting changes console line numbers.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-expected.txt index 7ecbef8..833295b3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that storage panel is present and that it contains correct data for local and session DOM storages. Populated local and session storage
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-update-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-update-expected.txt index 1e0d1bc..a94c8e9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-update-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/storage-panel-dom-storage-update-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that storage panel is present and that it contains correct data whenever localStorage is updated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/stylesheet-source-mapping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/stylesheet-source-mapping-expected.txt index 0beb700..aedbdf51 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/stylesheet-source-mapping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/stylesheet-source-mapping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests SourceMap and StyleSheetMapping. Added CSS uiSourceCode: http://127.0.0.1:8000/devtools/resources/example.css
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-css-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-css-expected.txt index 0c14fa20..04f830b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-css-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-css-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that (S)CSS syntax highlighter properly detects the tokens. a[href='/']: cm-css-tag, *, cm-css-tag, *, cm-css-string, *
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-html-expected.txt index b24992d..c9bb616 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that SourceHTMLTokenizer detects the tokens. <html>: cm-xml-tag xml-bracket, cm-xml-tag, cm-xml-tag xml-bracket
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-javascript-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-javascript-expected.txt index 222485f..e4685d2b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-javascript-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/syntax-highlight-javascript-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that JavaScriptSourceSyntaxHighlighter detects the tokens. return'foo';: cm-js-keyword, cm-js-string, *
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-editors-history-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-editors-history-expected.txt index 398a166..651eb5d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-editors-history-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-editors-history-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests history saving logic in TabbedEditorContainer. history = []
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-closeable-persistence-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-closeable-persistence-expected.txt index 738d1f91..01770b3b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-closeable-persistence-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-closeable-persistence-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests extensible tabbed pane closeable tabs persistence logic. Closeable tabs to restore: {}
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-max-tab-width-calculation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-max-tab-width-calculation-expected.txt index 963d92a..a6919db 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-max-tab-width-calculation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-max-tab-width-calculation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests tabbed pane max tab element width calculation. measuredWidths = [20,50,70], totalWidth = 150, maxWidth = 70.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-tabs-to-show-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-tabs-to-show-expected.txt index c5ec688..de7d4eda 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-tabs-to-show-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tabbed-pane-tabs-to-show-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests tabbed pane tabs to show calculation. Running tabs to show test:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/template-content-inspect-crash-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/template-content-inspect-crash-expected.txt index 141bb477..a9328781 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/template-content-inspect-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/template-content-inspect-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This test verifies that template's content DocumentFragment is accessible from DevTools. SUCCESS
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/text-autosizing-override-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/text-autosizing-override-expected.txt index 712d0cb..9852dec 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/text-autosizing-override-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/text-autosizing-override-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This text should be autosized to 40px computed font-size (16 * 800/320).
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/text-source-map-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/text-source-map-expected.txt index 69bc1edd..bff2585e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/text-source-map-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/text-source-map-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify TextSourceMap implementation
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/throttling/mobile-throttling-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/throttling/mobile-throttling-expected.txt index b6a2ccb3..282c788 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/throttling/mobile-throttling-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/throttling/mobile-throttling-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that mobile, network, and CPU throttling interact with each other logically. Initial throttling state
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-browser-thread-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-browser-thread-expected.txt index 31fb31b2..4b77b5c0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-browser-thread-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-browser-thread-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that tracing model correctly finds the main browser thread in the trace. chrome: main browser thread is CrBrowserMain (#4)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-expected.txt index 580f9f6..40285f2d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test tracing Tracing started
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-async-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-async-expected.txt index 9b2d431..ce4cb27 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-async-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-async-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that tracing model correctly processes trace events. simple1 100-101: S 100, F 101
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-expected.txt index 24de8d68..204c5742 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that tracing model correctly processes trace events. X Outer 10 - 11
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-ids-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-ids-expected.txt index e06113f..457265f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-ids-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-ids-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that tracing model correctly processes trace events. simple1 100-101: S 100, F 101
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-storage-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-storage-expected.txt index e6512801..c6c42bc9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-storage-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-model-storage-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that tracing model correctly processes trace events. DONE
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-session-id-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-session-id-expected.txt index e22f627..9e030695 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-session-id-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-session-id-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Tracing agent returns a session id upon a start that is matching one issued in trace events. Got DevTools metadata event: TracingStartedInBrowser
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/anonymous-image-object-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/anonymous-image-object-expected.txt index 0e8d424..11aaaea 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/anonymous-image-object-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/anonymous-image-object-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline instrumentation does not crash the renderer upon encountering an anonymous image render object DONE
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/buffer-usage-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/buffer-usage-expected.txt index 1bac6f4..5ceb625 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/buffer-usage-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/buffer-usage-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that buffer usage update are sent when recording trace events and TimelineLifecycleDelegate methods are properly invoked in the expected order. TimelineControllerClient.recordingStarted
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter-expected.txt index 99fa0f5..127a2dfa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test the set of visible records is correctly update when category filter changes Original records
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline-expected.txt index b0855a3..6cc9634 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests console.time and timeEnd methods.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/decode-resize-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/decode-resize-expected.txt index 9085825..891a5aa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/decode-resize-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/decode-resize-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the instrumentation of a DecodeImage and ResizeImage events event: Decode Image
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-expected.txt index d63ffc3..e7db258e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test the frames are correctly built based on trace events Test: main thread only
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-instrumentation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-instrumentation-expected.txt index eea5ff9..05780f59 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-instrumentation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model-instrumentation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. layerTree: object mainFrameId: number paints: present
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/generic-trace-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/generic-trace-expected.txt index 9537acf..1358a02f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/generic-trace-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/generic-trace-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks DevTools timeline is capable of reading and displaying generic traces. isGenericTrace: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/hit-test-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/hit-test-expected.txt index 151590e..f236251 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/hit-test-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/hit-test-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests instrumentation for Timeline HitTest event. HitTest Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/scroll-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/scroll-invalidations-expected.txt index 4097578e..7174959 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/scroll-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/scroll-invalidations-expected.txt
@@ -1,16 +1,9 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests invalidations produced by scrolling a page with position: fixed elements. -Scroll invalidations[ - { - cause : {reason: Scroll with viewport-constrained element, stackTrace: undefined} - changedAttribute : undefined - changedClass : undefined - changedId : undefined - changedPseudo : undefined - extraData : undefined - nodeName : "DIV" - selectorPart : undefined - type : "ScrollInvalidationTracking" - } -] +TEST ENDED EARLY DUE TO UNCAUGHT ERROR: +TypeError: Cannot read property 'Symbol(invalidationTrackingEvents)' of undefined + at Function.invalidationEventsFor (file:///usr/local/google/src/chromium/src/out_linux_chromium_rel_ng/Release/resources/inspector/timeline_model/timeline_model_module.js:279:49) + at eval (http://127.0.0.1:8000/devtools/tracing/scroll-invalidations.js:25:41) +=== DO NOT COMMIT THIS INTO -expected.txt ===
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/compile-script-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/compile-script-expected.txt index b373d48..69ca9b9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/compile-script-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/compile-script-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline instrumentation for CompileScript event. v8.compile Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/cpu-profile-unsorted-timestamps-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/cpu-profile-unsorted-timestamps-expected.txt index ee686e24..1b54072 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/cpu-profile-unsorted-timestamps-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/cpu-profile-unsorted-timestamps-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test CPU profile timestamps are properly sorted. process_name: 0 0.00/0.00
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-gc-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-gc-event-expected.txt index cf61ea4..5958912 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-gc-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-gc-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a gc event SUCCESS: Found expected GC event record
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-injected-script-eval-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-injected-script-eval-expected.txt index 00a89b3..82ebf8bf 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-injected-script-eval-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-injected-script-eval-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API function call is not recorded for InjectedScript.eval.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing-expected.txt index 1654404..5661826 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests JS blackboxing for timeline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-callstacks-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-callstacks-expected.txt index 3876b845..998abb6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-callstacks-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-callstacks-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test JS callstacks in timeline. Program: 200.000 / 300.000
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-expected.txt index 792f507b..a6ba61f6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that a line-level CPU profile is shown in the text editor. .../devtools/tracing/resources/empty.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt index d15b204..a13bbf1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests streaming CPU profile within trace log. JSFrame: 111.000 / 6.500 foo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-microtasks-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-microtasks-expected.txt index 6ed674f..d6d0c91 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-microtasks-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-microtasks-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks the RunMicrotasks event is emitted. RunMicrotasks Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-open-function-call-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-open-function-call-expected.txt index 7cd9347..00c074b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-open-function-call-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-open-function-call-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks the FunctionCall with no closing event processed properly. 101 142
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-runtime-stats-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-runtime-stats-expected.txt index 63c8a1e2..b351670 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-runtime-stats-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-runtime-stats-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check that RuntimeCallStats are present in profile.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-id-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-id-expected.txt index 08a0a3a..dd0fbd99 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-id-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-id-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that checks location resolving mechanics for TimerInstall TimerRemove and FunctionCall events with scriptId. It expects two FunctionCall for InjectedScript, two TimerInstall events, two FunctionCall events and one TimerRemove event to be logged with performActions.js script name and some line number.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-1-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-1-expected.txt index c0d7894..398d842b1 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-1-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of an HTML script tag. EvaluateScript Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-2-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-2-expected.txt index 28f5ab8..841f1b2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-2-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-2-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a script tag with an external script. EvaluateScript Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-expected.txt index eacb3b79b..0ff6545 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a Layout event Layout Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-reason-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-reason-expected.txt index c001e0c..7c8e0c4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-reason-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-reason-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Layout record has correct locations of layout being invalidated and forced. layout invalidated: invalidateStyle
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-with-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-with-invalidations-expected.txt index 6dfca3b..5930175 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-with-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-layout/timeline-layout-with-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of layout events with invalidations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-aggregated-details-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-aggregated-details-expected.txt index 97a1842..7870f11e5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-aggregated-details-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-aggregated-details-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test timeline aggregated details. Cleared ProductRegistryImpl
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-animation-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-animation-frame-expected.txt index 33e4c07..c65843d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-animation-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-animation-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for Animation Frame feature RequestAnimationFrame Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-auto-zoom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-auto-zoom-expected.txt index 3772bb06..48a41dd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-auto-zoom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-auto-zoom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test auto zoom feature of the timeline.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-bound-function-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-bound-function-expected.txt index 4151574..bfea2e8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-bound-function-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-bound-function-expected.txt
@@ -1,5 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests extracting information about original functions from bound ones -FunctionCall timeline-bound-function.html:7 -
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-crypto-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-crypto-expected.txt index 60c35ef..1d85815 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-crypto-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-crypto-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for module compile & evaluate. DoEncryptReply Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-dom-gc-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-dom-gc-expected.txt index fc15c7c..4b093645 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-dom-gc-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-dom-gc-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a DOM GC event SUCCESS: Found expected Blink GC event record
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-causes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-causes-expected.txt index aec8ae8d..a26a890 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-causes-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-causes-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that causes are correctly generated for various types of events.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-details-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-details-expected.txt index d1fb6c55..cbad538 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-details-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-details-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Checks the Product property in details pane for a node with URL. Cleared ProductRegistryImpl
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-dispatch-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-dispatch-expected.txt index beaf144..c49ec05 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-dispatch-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-dispatch-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a DOM Dispatch (mousedown) EventDispatch Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering-expected.txt index 4de52cf..d557f8f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test filtering in Timeline Tree View panel. Initial:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window-expected.txt index 695e5d2..e1894c5c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the TimelineFlameChart automatically sized window. time delta: 1416.3081498146057
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt index 6a8db3f..c3e4b94 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests grouped invalidations on the timeline. paint invalidations[
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-load-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-load-event-expected.txt index 54ef9e5..abc0e65b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-load-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-load-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the load event. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-model-expected.txt index 0ca0edb..ad253b34 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test trace-specific implementation of timeline model TracingStartedInPage:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-node-reference-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-node-reference-expected.txt index 0d88249..408a02f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-node-reference-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-node-reference-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a Layout event Layout root node id: boundary
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-parse-html-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-parse-html-expected.txt index 7f4a4913..eca90a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-parse-html-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-parse-html-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of ParseHTML ParseHTML Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats-expected.txt index d5a1627..f69b626 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that aggregated summary in Timeline is properly computed. 100000-101000: idle: 0 other: 0.5 rendering: 0 scripting: 0.5 total: 1
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-record-reload-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-record-reload-expected.txt index 62de7835..eb5dd05 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-record-reload-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-record-reload-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test recording page reload works in Timeline. Page reloaded.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt index 2b820f19..6a49bdd 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test search in Timeline FlameChart View. 2010: B TimeStamp CrRendererMain
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-trivial-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-trivial-expected.txt index 443f7dbd..6edcd09 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-trivial-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-trivial-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Trivial use of inspector frontend tests Timeline started
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings-expected.txt index bdd41d29..f93324b2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test timeline aggregated details.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-window-filter-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-window-filter-expected.txt index 89a804fe..4e497b2 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-window-filter-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-window-filter-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline window filter. It applies different ranges to the OverviewGrid and expects that current view reflects the change.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network-received-data-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network-received-data-expected.txt index c2fb712..3515259 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network-received-data-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network-received-data-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a network resource received data Script evaluated.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-details-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-details-expected.txt index ae55d6b3..ec67d48 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-details-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-details-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline UI API for network requests. URL: timeline-network-resource.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-expected.txt index 9f0d8f2..65240d3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a network resource load
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt index 79b72a38..27022ab 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/layer-tree-expected.txt
@@ -1,18 +1,15 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that LayerTreeModel successfully imports layers from a trace. -#document - #document 0x0 - #document - #document 0x0 - #document 0x0 - #document - #document - #document - #document - #document - div#a 200x200 - div#b1 100x150 - div#b2 110x140 - div#c 90x100 - div#b3 110x140 +<invalid node id> + <invalid node id> 0x0 + <invalid node id> + <invalid node id> 0x0 + <invalid node id> 0x0 + <invalid node id> + <invalid node id> 200x200 + <invalid node id> 100x150 + <invalid node id> 110x140 + <invalid node id> 90x100 + <invalid node id> 110x140
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/paint-profiler-update-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/paint-profiler-update-expected.txt index e47342f..a7921c7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/paint-profiler-update-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/paint-profiler-update-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that paint profiler is properly update when an event is selected in Flame Chart Paint 0 log size: >0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations-expected.txt index 3b71d2e..bd1e883 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of multiple style recalc invalidations and ensures they are all collected on the paint event. first style recalc[
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-expected.txt index 750bb15..0530a53 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a paint event Paint Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-image-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-image-expected.txt index c461b02..4cd50e0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-image-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-image-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a paint image event
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-expected.txt index 68d64a25..6ed9e82 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of paint events with layout invalidations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt index 97b753c..bed55f39 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of layout invalidations on a deleted node.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations-expected.txt index 71ded10..df05e6f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of paint events with style recalc invalidations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/update-layer-tree-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/update-layer-tree-expected.txt index 0f7ca2e..079d55f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/update-layer-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/update-layer-tree-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the instrumentation of UpdateLayerTree event Got UpdateLayerTree event, phase: X
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-receive-response-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-receive-response-event-expected.txt index 21f3a531..83ecb35 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-receive-response-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-receive-response-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a SendRequest, ReceiveResponse etc. ResourceSendRequest
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-module-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-module-expected.txt index 9ac0a31..bf23d1e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-module-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-module-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for module compile & evaluate. v8.compileModule Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-parse-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-parse-expected.txt index b794b51..e23bf7d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-parse-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-script-parse-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for v8.parseOnBackground v8.parseOnBackground Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/parse-author-style-sheet-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/parse-author-style-sheet-expected.txt index 18deee3..4b6bf8a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/parse-author-style-sheet-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/parse-author-style-sheet-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that ParseAuthorStyleSheet trace event is recorded. SUCCESS: found ParseAuthorStyleSheet record
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles-expected.txt index dfa7024..1a05a0b8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a style recalculation event Test data
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types-expected.txt index c9d520c..4157f742 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of style recalc invalidator invalidations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidations-expected.txt index 4abf35a..a511d65 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of style recalc events with invalidations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations-expected.txt index 1b63b92..8c5de4e 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of style recalc events with invalidations.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-expected.txt index 12d37a0f..f6c2b933 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test nesting of time/timeEnd records on Timeline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-stamp-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-stamp-expected.txt index 3941645..e39eaa4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-stamp-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-time-stamp-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API timeStamp feature TimeStamp Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt index 3297a2e..bac62aa0 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for Timers TimerInstall Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-fired-from-eval-call-site-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-fired-from-eval-call-site-expected.txt index 6687017..3b857a7 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-fired-from-eval-call-site-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-fired-from-eval-call-site-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline API instrumentation of a TimerFired events inside evaluated scripts. TimerFire fromEval.js:2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming-expected.txt index 216e957..91cfd84 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test performance.mark/measure records on Timeline
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-worker-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-worker-events-expected.txt index 665335c..71eff61 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-worker-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-worker-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that worker events are properly filtered in timeline. Got 2 worker metadata events
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-event-expected.txt index 804dac6..f9d23e5 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for XMLHttpReqeust XHRReadyStateChange Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-response-type-blob-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-response-type-blob-event-expected.txt index 6188c5c..3f7701a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-response-type-blob-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-xhr-response-type-blob-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for XMLHttpReqeust with responseType="blob" XHRReadyStateChange Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt index f405b90..c518a62 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test trace event self time. process_name: 0 0.00/0.00
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/tracing-timeline-load-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/tracing-timeline-load-expected.txt index a72c13b..312e9ab 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/tracing-timeline-load-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/tracing-timeline-load-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests tracing based Timeline save/load functionality.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/websocket/timeline-websocket-event-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/websocket/timeline-websocket-event-expected.txt index 48bf3d5..d628c8b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/websocket/timeline-websocket-event-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/websocket/timeline-websocket-event-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests the Timeline events for WebSocket WebSocketCreate Properties:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-events-expected.txt index 87aa6b6..6f2ed862 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that worker events are recorded with proper devtools metadata events. Got DevTools worker metadata event(1): TracingSessionIdForWorker
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-js-frames-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-js-frames-expected.txt index add010f..2b35913 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-js-frames-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-js-frames-expected.txt
@@ -1,6 +1,10 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests js cpu profile in timeline. -Main Thread -DedicatedWorker Thread -DedicatedWorker Thread +CrRendererMain +FAIL: missing events: +startSecondWorker +worker2.onmessage +DedicatedWorker thread +DedicatedWorker thread
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt index 1b4bd59f9..9407703 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests long text in datagrid. Original lengths key text length: 1500
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-items-attached-to-dom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-items-attached-to-dom-expected.txt index 471326e..37f018c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-items-attached-to-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/datagrid-items-attached-to-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests viewport datagrid. Nodes attached to dom: a0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-item-selection-dialog-filtering-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-item-selection-dialog-filtering-expected.txt index 2da59d1..8b63942 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-item-selection-dialog-filtering-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-item-selection-dialog-filtering-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Check to see that FilteredItemSelectionDialog uses proper regex to filter results. test: emptyQueryMatchesEverything
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-list-widget-providers-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-list-widget-providers-expected.txt index 025da732..015dc6c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-list-widget-providers-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/filtered-list-widget-providers-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that FilteredListWidget.setProvider changes the provider. test: providerWithOneItem
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-equal-height-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-equal-height-expected.txt index ec113cad..1586c75d 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-equal-height-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-equal-height-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test ListControl rendering and selection for equal height items case. Adding 0, 1, 2 Creating element for 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-non-viewport-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-non-viewport-expected.txt index 256dcddf..4300822 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-non-viewport-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-non-viewport-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test ListControl rendering and selection for non-viewport mode. Adding 0, 1, 2 Creating element for 2
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-various-height-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-various-height-expected.txt index d302d8cc..3f6a1c69 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-various-height-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-control-various-height-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test ListControl rendering for various height items case. Adding 0, 1, 2 Creating element for 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-model-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-model-expected.txt index a078ea0c..55e237eb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-model-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/list-model-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test ListModel API. Adding 0, 1, 2 Replaced [] at index 0 with [0, 1, 2]
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/object-events-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/object-events-expected.txt index 83a54f5..124670e9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/object-events-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/object-events-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. The test verifies that DevTools events work. Adding a listener with this 'original listener'
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/parse-filter-query-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/parse-filter-query-expected.txt index 38d79a5..da1eefbeb 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/parse-filter-query-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/parse-filter-query-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests a utility's ability to parse filter queries. Query: text
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/preprocess-top-level-awaits-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/preprocess-top-level-awaits-expected.txt index cec1d3e..231c6564 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/preprocess-top-level-awaits-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/preprocess-top-level-awaits-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests preprocessTopLevelAwaitExpressions. -------------- 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/product-registry-impl-register-sanity-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/product-registry-impl-register-sanity-expected.txt index f2f01b9..2943a0a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/product-registry-impl-register-sanity-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/product-registry-impl-register-sanity-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests product registry impl's register function. Cleared ProductRegistryImpl Testing: example.com -> example.(com|org)
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local-expected.txt index 6a9a140..846cb13 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/remote-object-from-local-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests construction of RemoteObjects from local values. Expression: "1n"
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/resolve-relative-url-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/resolve-relative-url-expected.txt index af9d24d..f46b218 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/resolve-relative-url-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/resolve-relative-url-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. http://example.com/map.json === http://example.com/map.json http://example.com/map.json === http://example.com/map.json http://example.com/maps/map.json === http://example.com/maps/map.json
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-context-menu-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-context-menu-expected.txt index 5ca14c0..f3ec70c9 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-context-menu-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-context-menu-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Initial focused element has focus [null] ArrowDown
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-drop-down-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-drop-down-expected.txt index 01bd99d..f98d9a4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-drop-down-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/soft-drop-down-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Item selected: fifth Showing drop down Item highlighted: fifth
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/source-frame-pretty-print-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/source-frame-pretty-print-expected.txt index cd2251e..1a8485b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/source-frame-pretty-print-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/source-frame-pretty-print-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that Source Frame can pretty print Showing raw content: true
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/string-util-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/string-util-expected.txt index 1e6bdf9a..731b9a34 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/string-util-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/string-util-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. test: testEmptyPrefixSuffix {
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/suggest-box-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/suggest-box-expected.txt index d9419c6..e2579f8 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/suggest-box-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/suggest-box-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests if the SuggestBox works properly. Testing that the first item is selected.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/tabbed-pane-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/tabbed-pane-expected.txt index 3c65a698..a6b4e936 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/tabbed-pane-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/tabbed-pane-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests if the TabbedPane is keyboard navigable. Tab 0 Moving right and wrapping around
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/test-failure-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/test-failure-expected.txt index 876e0f0..4479e4fa 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/test-failure-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/test-failure-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that a test will properly exit if it has an asynchronous error. TEST ENDED IN ERROR: This error is expected
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-expected.txt index 8d36b10..8e01372 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests if the TextPrompt autocomplete works properly. Text:hey
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-hint-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-hint-expected.txt index 5b37e11..30e4e70 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-hint-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/text-prompt-hint-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that the hint displays properly on a UI.TextPrompt with autocomplete. Requesting completions Text:testT
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/treeoutline-keyboard-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/treeoutline-keyboard-expected.txt index 7977ab0..956e6af 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/treeoutline-keyboard-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/treeoutline-keyboard-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests if the treeoutline responds to navigation keys. Selected: 0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/trie-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/trie-expected.txt index 39e8db9..37cf85c 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/trie-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/trie-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Verify "trie" functionality. test: testAddWord
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/view-location-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/view-location-expected.txt index 0bbce416..806153b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/view-location-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/view-location-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Creating new TabbedLocation [] Appending three views
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-attached-to-dom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-attached-to-dom-expected.txt index a3862dc0..f1ac950 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-attached-to-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-attached-to-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests viewport datagrid. Nodes attached to dom: a0
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-expandable-attached-to-dom-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-expandable-attached-to-dom-expected.txt index f1fd2fe..ae0dc311 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-expandable-attached-to-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/unit/viewport-datagrid-items-expandable-attached-to-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This tests viewport datagrid. Nodes 3 and 24 have children but should be collapsed initially Nodes attached to dom:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/user-agent-setting-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/user-agent-setting-expected.txt index e0c3b3f..9bcfd76 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/user-agent-setting-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/user-agent-setting-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test user agent setting Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.77.34.5 Safari/537.36
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/user-metrics-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/user-metrics-expected.txt index 2619391..25680e7b 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/user-metrics-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/user-metrics-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests list of user metrics codes and invocations. recordActionTaken:
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/version-controller-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/version-controller-expected.txt index f2e9d2c..d1f94c6 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/version-controller-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/version-controller-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests inspector version controller.
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/network-preserve-selection-on-frame-receive-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/network-preserve-selection-on-frame-receive-expected.txt index dd81c27..03afa56 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/network-preserve-selection-on-frame-receive-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/network-preserve-selection-on-frame-receive-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that WebSocket network requests do not loose focus on frame being received. Selected Request: ws://localhost:8880/echo
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-error-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-error-expected.txt index 583d08bc..5b0d129 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-error-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-error-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that WebSocketFrames errors are visible to Web Inspector. 1-error: Error during WebSocket handshake: Unexpected response code: 404
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-expected.txt index b2033e6..7fa5f53 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-frame-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that WebSocketFrames are being sent and received by Web Inspector. 1-send: test
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-handshake-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-handshake-expected.txt index dc1dc566..e9da54f 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-handshake-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/websocket/websocket-handshake-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that WebSocket handshake information is passed to Web Inspector. log: requestMethod: GET
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/workers-on-navigation-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/workers-on-navigation-expected.txt index 92760735..dc6e80c4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/workers-on-navigation-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/workers-on-navigation-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests that workers are correctly detached upon navigation. Worker added
diff --git a/third_party/WebKit/LayoutTests/http/tests/devtools/workspace-mapping-expected.txt b/third_party/WebKit/LayoutTests/http/tests/devtools/workspace-mapping-expected.txt index 487230e..e0b8874 100644 --- a/third_party/WebKit/LayoutTests/http/tests/devtools/workspace-mapping-expected.txt +++ b/third_party/WebKit/LayoutTests/http/tests/devtools/workspace-mapping-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests workspace mappings uiSourceCode for url http://www.example.com/index.html: EXISTS
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/fallback-to-another-sxg.sxg b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/fallback-to-another-sxg.sxg index 9577748..86eca18 100644 --- a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/fallback-to-another-sxg.sxg +++ b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/fallback-to-another-sxg.sxg Binary files differ
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh index e5f69aa9..7a75a69 100755 --- a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh +++ b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh
@@ -28,6 +28,7 @@ # Generate the signed exchange file. gen-signedexchange \ + -version 1b2 \ -uri https://127.0.0.1:8443/loading/sxg/resources/inner-url.html \ -status 200 \ -content sxg-location.html \ @@ -42,6 +43,7 @@ # Generate the signed exchange file which certificate file is not available. gen-signedexchange \ + -version 1b2 \ -uri https://127.0.0.1:8443/loading/sxg/resources/inner-url.html \ -status 200 \ -content sxg-location.html \ @@ -57,6 +59,7 @@ # Generate the signed exchange file which validity URL is different origin from # request URL. gen-signedexchange \ + -version 1b2 \ -uri https://127.0.0.1:8443/loading/sxg/resources/inner-url.html \ -status 200 \ -content sxg-location.html \ @@ -72,6 +75,7 @@ # Generate the signed exchange whose certUrl is 404 and fallback URL is another # signed exchange. gen-signedexchange \ + -version 1b2 \ -uri https://127.0.0.1:8443/loading/sxg/resources/sxg-location.sxg \ -status 200 \ -content failure.html \
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg index bcc218d..29420ce3 100644 --- a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg +++ b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg Binary files differ
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg index ed2a3d7..3a8f2a9a 100644 --- a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg +++ b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg Binary files differ
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php index e5f8fb0..9b75d2d4 100644 --- a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php +++ b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php
@@ -2,7 +2,7 @@ header('HTTP/1.0 200 OK'); // generate_token.py http://127.0.0.1:8000 SignedHTTPExchange --expire-timestamp=2000000000 header("Origin-Trial: AgeFm+W/+DvAEn/vDjtqgd5PQX73YxKJLGBwLp14SiMjKFNTEUK2Bx5R3gH23JOfP+IL2EGNj+x9uhzh2krVRgsAAABaeyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR1cmUiOiAiU2lnbmVkSFRUUEV4Y2hhbmdlIiwgImV4cGlyeSI6IDIwMDAwMDAwMDB9"); -header("Content-Type: application/signed-exchange;v=b1"); +header("Content-Type: application/signed-exchange;v=b2"); $name = 'sxg-location.sxg'; $fp = fopen($name, 'rb'); header("Content-Length: " . filesize($name));
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg index e65a0db2..10280df 100644 --- a/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg +++ b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg Binary files differ
diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-expected.txt b/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-expected.txt new file mode 100644 index 0000000..b864cded --- /dev/null +++ b/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe-expected.txt
@@ -0,0 +1,12 @@ +ALERT: Going back. +Tests that subsequent navigation in an iframe restored from history does not report resource timing. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS resources.length is 1 +PASS resources[0].name is "http://127.0.0.1:8000/js-test-resources/js-test.js" +PASS successfullyParsed is true + +TEST COMPLETE +
diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html b/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html new file mode 100644 index 0000000..14a559dc --- /dev/null +++ b/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html
@@ -0,0 +1,30 @@ +<!DOCTYPE html> +<script src="/js-test-resources/js-test.js"></script> +<script> +description('Tests that subsequent navigation in an iframe restored from history does not report resource timing.'); +window.jsTestIsAsync = true; + +function runTest() { + if (!sessionStorage.didNav) { + sessionStorage.didNav = true; + // Navigate a timeout to make sure we generate a history entry that we can go back to. + setTimeout(function() { + location.href = 'resources/alert-then-back.html'; + }, 0); + } else { + delete sessionStorage.didNav; + window.addEventListener('message', (event) => { + resources = performance.getEntriesByType('resource'); + shouldBe('resources.length', '1'); + shouldBeEqualToString('resources[0].name', 'http://127.0.0.1:8000/js-test-resources/js-test.js'); + if (window.testRunner) + finishJSTest(); + }); + document.getElementById('target-iframe').contentWindow.postMessage('navigate', '*'); + } +} + +window.onload = runTest; + +</script> +<iframe id="target-iframe" src="http://localhost:8080/misc/resources/navigate-on-message.html"></iframe>
diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/resources/navigate-on-message.html b/third_party/WebKit/LayoutTests/http/tests/misc/resources/navigate-on-message.html new file mode 100644 index 0000000..d410668 --- /dev/null +++ b/third_party/WebKit/LayoutTests/http/tests/misc/resources/navigate-on-message.html
@@ -0,0 +1,8 @@ +<!DOCTYPE html> +<script> +function handleMessage() { + window.location = 'post-message-to-parent.html'; +} + +window.addEventListener("message", handleMessage); +</script>
diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/resources/post-message-to-parent.html b/third_party/WebKit/LayoutTests/http/tests/misc/resources/post-message-to-parent.html new file mode 100644 index 0000000..136a5a50 --- /dev/null +++ b/third_party/WebKit/LayoutTests/http/tests/misc/resources/post-message-to-parent.html
@@ -0,0 +1,4 @@ +<!DOCTYPE html> +<script> + window.parent.postMessage('navigated', '*'); +</script>
diff --git a/third_party/WebKit/LayoutTests/platform/win/html/marquee/marquee-scroll-expected.png b/third_party/WebKit/LayoutTests/platform/win/html/marquee/marquee-scroll-expected.png index a1731b05..5f521e0e 100644 --- a/third_party/WebKit/LayoutTests/platform/win/html/marquee/marquee-scroll-expected.png +++ b/third_party/WebKit/LayoutTests/platform/win/html/marquee/marquee-scroll-expected.png Binary files differ
diff --git a/third_party/WebKit/LayoutTests/plugins/mouse-capture-inside-shadow-expected.txt b/third_party/WebKit/LayoutTests/plugins/mouse-capture-inside-shadow-expected.txt index 3d25c66..04924a62 100644 --- a/third_party/WebKit/LayoutTests/plugins/mouse-capture-inside-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/plugins/mouse-capture-inside-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 23: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. CONSOLE MESSAGE: Blink Test Plugin: initializing CONSOLE MESSAGE: Blink Test Plugin: DidChangeFocus(true) CONSOLE MESSAGE: Blink Test Plugin: MouseDown at (12,12)
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1-expected.txt b/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1-expected.txt index 3315e7b..5ef0871 100644 --- a/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1-expected.txt +++ b/third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. :focus and shadow host without delegatesFocus for crbug/479050 PASS backgroundColorOf('shadow-host') is "rgb(255, 255, 255)" Test shadow host without tabindex
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/range-caret-range-from-point-left-of-shadow-expected.txt b/third_party/WebKit/LayoutTests/shadow-dom/range-caret-range-from-point-left-of-shadow-expected.txt index 3e4b4a7..2c747ec 100644 --- a/third_party/WebKit/LayoutTests/shadow-dom/range-caret-range-from-point-left-of-shadow-expected.txt +++ b/third_party/WebKit/LayoutTests/shadow-dom/range-caret-range-from-point-left-of-shadow-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 29: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. This is a testharness.js-based test. Harness Error. harness_status.status = 1 , harness_status.message = 1 duplicate test name: "DIV" PASS DIV
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-in-v0-tree-crash-expected.txt b/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-in-v0-tree-crash-expected.txt index ea4527b7..a82fe33 100644 --- a/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-in-v0-tree-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/shadow-dom/slotted-pseudo-element-in-v0-tree-crash-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 11: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS if no crash.
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators-expected.txt b/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators-expected.txt index ddc8873..84527af 100644 --- a/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators-expected.txt +++ b/third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS result.length is 7 PASS node.id is "openhost" PASS node.id is "closedhost"
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt b/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt index 9aa3c0b..c78773f 100644 --- a/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt +++ b/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for getDestinationInsertionPoints(). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt b/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt index 7895820..9b7f7a4 100644 --- a/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt +++ b/third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 87: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Tests for getDestinationInsertionPoints() which involves re-distribution. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/svg/custom/smil-in-shadow-tree-crash-expected.txt b/third_party/WebKit/LayoutTests/svg/custom/smil-in-shadow-tree-crash-expected.txt index caf0b8f1..09e18d57 100644 --- a/third_party/WebKit/LayoutTests/svg/custom/smil-in-shadow-tree-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/svg/custom/smil-in-shadow-tree-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 10: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test PASSES if it does not assert in debug builds.
diff --git a/third_party/WebKit/LayoutTests/svg/custom/stop-style-crash-expected.txt b/third_party/WebKit/LayoutTests/svg/custom/stop-style-crash-expected.txt index 9b9c9725..183f0ee 100644 --- a/third_party/WebKit/LayoutTests/svg/custom/stop-style-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/svg/custom/stop-style-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 13: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS: did not crash.
diff --git a/third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-expected.txt b/third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-expected.txt index dac398e..6b703d1 100644 --- a/third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-expected.txt +++ b/third_party/WebKit/LayoutTests/svg/dom/title-in-shadow-tree-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 20: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS: This text should appear as a tooltip.
diff --git a/third_party/WebKit/LayoutTests/svg/foreign-object-under-shadow-root-under-hidden-expected.txt b/third_party/WebKit/LayoutTests/svg/foreign-object-under-shadow-root-under-hidden-expected.txt index cd68e36..d2bdff4d 100644 --- a/third_party/WebKit/LayoutTests/svg/foreign-object-under-shadow-root-under-hidden-expected.txt +++ b/third_party/WebKit/LayoutTests/svg/foreign-object-under-shadow-root-under-hidden-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 6: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Passes if it does not crash.
diff --git a/third_party/WebKit/LayoutTests/svg/foreignObject/invalid-svg-child-renderer-expected.txt b/third_party/WebKit/LayoutTests/svg/foreignObject/invalid-svg-child-renderer-expected.txt index 4e30d38..ec4aed1 100644 --- a/third_party/WebKit/LayoutTests/svg/foreignObject/invalid-svg-child-renderer-expected.txt +++ b/third_party/WebKit/LayoutTests/svg/foreignObject/invalid-svg-child-renderer-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 18: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS: test did not crash.
diff --git a/third_party/WebKit/LayoutTests/svg/foreignObject/overflow-clip-in-hidden-container-crash-expected.txt b/third_party/WebKit/LayoutTests/svg/foreignObject/overflow-clip-in-hidden-container-crash-expected.txt index 9b9c9725..c675d79 100644 --- a/third_party/WebKit/LayoutTests/svg/foreignObject/overflow-clip-in-hidden-container-crash-expected.txt +++ b/third_party/WebKit/LayoutTests/svg/foreignObject/overflow-clip-in-hidden-container-crash-expected.txt
@@ -1 +1,2 @@ +CONSOLE WARNING: line 12: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. PASS: did not crash.
diff --git a/third_party/WebKit/LayoutTests/touchadjustment/context-menu-shadow-node-expected.txt b/third_party/WebKit/LayoutTests/touchadjustment/context-menu-shadow-node-expected.txt index 9965984..13c4251e 100644 --- a/third_party/WebKit/LayoutTests/touchadjustment/context-menu-shadow-node-expected.txt +++ b/third_party/WebKit/LayoutTests/touchadjustment/context-menu-shadow-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 33: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test touch adjustment for context-menu gestures on a shadow-DOM element. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/touchadjustment/nested-shadow-node-expected.txt b/third_party/WebKit/LayoutTests/touchadjustment/nested-shadow-node-expected.txt index 48b2915..6b62b44b 100644 --- a/third_party/WebKit/LayoutTests/touchadjustment/nested-shadow-node-expected.txt +++ b/third_party/WebKit/LayoutTests/touchadjustment/nested-shadow-node-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 42: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test the case where a clickable target contains a shadow-DOM element. The adjusted point should snap to the location of the shadow-DOM element if close enough to the original touch position. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/touchadjustment/simple-shadow-dom-expected.txt b/third_party/WebKit/LayoutTests/touchadjustment/simple-shadow-dom-expected.txt index 4a18491..5f88264d 100644 --- a/third_party/WebKit/LayoutTests/touchadjustment/simple-shadow-dom-expected.txt +++ b/third_party/WebKit/LayoutTests/touchadjustment/simple-shadow-dom-expected.txt
@@ -1,3 +1,4 @@ +CONSOLE WARNING: line 21: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. Test that a hit right in the middle of a shadow dom node returns it and not its host. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
diff --git a/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-cert-not-found-expected.txt b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-cert-not-found-expected.txt new file mode 100644 index 0000000..7dddcba --- /dev/null +++ b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-cert-not-found-expected.txt
@@ -0,0 +1,23 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +Tests the signed exchange information are available when the certificate file is not available. + +inspected-page.html:1 Invalid reponse code: 404 +inspected-page.html:1 Failed to fetch the certificate. +* http://127.0.0.1:8000/loading/sxg/resources/sxg-cert-not-found.sxg + failed: false + statusCode: 200 + resourceType: signed-exchange + SignedExchangeInfo + Request URL: https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + Certificate URL: https://127.0.0.1:8443/loading/sxg/resources/not_found_cert.pem.cbor + Error: {"message":"Invalid reponse code: 404"} + Error: {"message":"Failed to fetch the certificate.","signatureIndex":0,"errorField":"signatureCertUrl"} +* https://127.0.0.1:8443/loading/sxg/resources/not_found_cert.pem.cbor + failed: false + statusCode: 404 + resourceType: other +* https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + failed: false + statusCode: 200 + resourceType: document +
diff --git a/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-disable-cache-expected.txt b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-disable-cache-expected.txt new file mode 100644 index 0000000..3ffdb0d --- /dev/null +++ b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-disable-cache-expected.txt
@@ -0,0 +1,12 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +The 'disable cache' flag must affect on the certificate fetch request. + +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + cached: false +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + cached: false +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + cached: false +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + cached: false +
diff --git a/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-navigation-expected.txt b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-navigation-expected.txt new file mode 100644 index 0000000..028a29c --- /dev/null +++ b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-navigation-expected.txt
@@ -0,0 +1,21 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +Tests the signed exchange information are available when the navigation succeeded. + +* http://127.0.0.1:8000/loading/sxg/resources/sxg-location.sxg + failed: false + statusCode: 200 + resourceType: signed-exchange + SignedExchangeInfo + Request URL: https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + Certificate URL: https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + Certificate Subject: 127.0.0.1 + Certificate Issuer: web-platform-tests +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + failed: false + statusCode: 200 + resourceType: other +* https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + failed: false + statusCode: 200 + resourceType: document +
diff --git a/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-navigation-expired-expected.txt b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-navigation-expired-expected.txt new file mode 100644 index 0000000..df458bf9 --- /dev/null +++ b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-navigation-expired-expected.txt
@@ -0,0 +1,23 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +Tests the signed exchange information are available when the navigation failed. + +inspected-page.html:1 Invalid timestamp. creation_time: 1522540800, expires_time: 1523145600, verification_time: 1523318460 +inspected-page.html:1 Failed to verify the signed exchange header. +* http://127.0.0.1:8000/loading/sxg/resources/sxg-location.sxg + failed: false + statusCode: 200 + resourceType: signed-exchange + SignedExchangeInfo + Request URL: https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + Certificate URL: https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + Error: {"message":"Invalid timestamp. creation_time: 1522540800, expires_time: 1523145600, verification_time: 1523318460"} + Error: {"message":"Failed to verify the signed exchange header.","signatureIndex":0,"errorField":"signatureTimestamps"} +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + failed: false + statusCode: 200 + resourceType: other +* https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + failed: false + statusCode: 200 + resourceType: document +
diff --git a/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-prefetch-expected.txt b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-prefetch-expected.txt new file mode 100644 index 0000000..f01c0b1 --- /dev/null +++ b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-prefetch-expected.txt
@@ -0,0 +1,21 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +Tests the signed exchange information are available when the prefetch succeeded. + +* http://127.0.0.1:8000/loading/sxg/resources/sxg-location.sxg + failed: false + statusCode: 200 + resourceType: signed-exchange + SignedExchangeInfo + Request URL: https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + Certificate URL: https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + Certificate Subject: 127.0.0.1 + Certificate Issuer: web-platform-tests +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + failed: false + statusCode: 200 + resourceType: other +* https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + failed: false + statusCode: 200 + resourceType: other +
diff --git a/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-prefetch-expired-expected.txt b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-prefetch-expired-expected.txt new file mode 100644 index 0000000..45750fa --- /dev/null +++ b/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/sxg-prefetch-expired-expected.txt
@@ -0,0 +1,17 @@ +CONSOLE WARNING: line 3078: Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details. +Tests the signed exchange information are available when the prefetch failed. + +* http://127.0.0.1:8000/loading/sxg/resources/sxg-location.sxg + failed: true + statusCode: 200 + resourceType: other + SignedExchangeInfo + Request URL: https://127.0.0.1:8443/loading/sxg/resources/inner-url.html + Certificate URL: https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + Error: {"message":"Invalid timestamp. creation_time: 1522540800, expires_time: 1523145600, verification_time: 1523318460"} + Error: {"message":"Failed to verify the signed exchange header.","signatureIndex":0,"errorField":"signatureTimestamps"} +* https://127.0.0.1:8443/loading/sxg/resources/127.0.0.1.sxg.pem.cbor + failed: false + statusCode: 200 + resourceType: other +
diff --git a/third_party/abseil-cpp/OWNERS b/third_party/abseil-cpp/OWNERS index ceca4a8b..38ebaf22 100644 --- a/third_party/abseil-cpp/OWNERS +++ b/third_party/abseil-cpp/OWNERS
@@ -1,2 +1,4 @@ +danilchap@chromium.org +kwiberg@chromium.org mbonadei@chromium.org phoglund@chromium.org
diff --git a/third_party/blink/public/platform/web_feature.mojom b/third_party/blink/public/platform/web_feature.mojom index 4f1beb4..fe6086e 100644 --- a/third_party/blink/public/platform/web_feature.mojom +++ b/third_party/blink/public/platform/web_feature.mojom
@@ -1985,6 +1985,8 @@ kReportingObserver = 2529, kDeprecationReport = 2530, kInterventionReport = 2531, + kV8WasmSharedMemory = 2532, + kV8WasmThreadOpcodes = 2533, // Add new features immediately above this line. Don't change assigned // numbers of any item, and don't reuse removed slots.
diff --git a/third_party/blink/public/web/web_document_loader.h b/third_party/blink/public/web/web_document_loader.h index 3b4c95a..632bf50 100644 --- a/third_party/blink/public/web/web_document_loader.h +++ b/third_party/blink/public/web/web_document_loader.h
@@ -119,15 +119,8 @@ virtual WebServiceWorkerNetworkProvider* GetServiceWorkerNetworkProvider() = 0; - // PlzNavigate - // Allows to specify the SourceLocation that triggered the navigation. - virtual void SetSourceLocation(const WebSourceLocation&) = 0; virtual void ResetSourceLocation() = 0; - // Mark that the load was user activated. This is meant to be used for browser - // initiated loads that may have had a user activation from the browser UI. - virtual void SetUserActivated() = 0; - // Can be used to temporarily suspend feeding the parser with new data. The // parser will be allowed to read new data when ResumeParser() is called the // same number of time than BlockParser().
diff --git a/third_party/blink/public/web/web_local_frame.h b/third_party/blink/public/web/web_local_frame.h index 5cfce4ee..c41cf70 100644 --- a/third_party/blink/public/web/web_local_frame.h +++ b/third_party/blink/public/web/web_local_frame.h
@@ -27,7 +27,7 @@ #include "third_party/blink/public/web/web_frame_load_type.h" #include "third_party/blink/public/web/web_history_item.h" #include "third_party/blink/public/web/web_ime_text_span.h" -#include "third_party/blink/public/web/web_navigation_timings.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_text_direction.h" #include "v8/include/v8.h" @@ -59,6 +59,7 @@ struct WebAssociatedURLLoaderOptions; struct WebConsoleMessage; struct WebContentSecurityPolicyViolation; +struct WebNavigationParams; struct WebFindOptions; struct WebMediaPlayerAction; struct WebPrintParams; @@ -215,8 +216,8 @@ const WebHistoryItem&, bool is_client_redirect, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) = 0; + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) = 0; // Commits a same-document navigation in the frame. For history navigations, a // valid WebHistoryItem should be provided. Returns CommitResult::Ok if the @@ -258,9 +259,9 @@ WebFrameLoadType, const WebHistoryItem&, bool is_client_redirect, + std::unique_ptr<WebNavigationParams> navigation_params, std::unique_ptr<WebDocumentLoader::ExtraData> navigation_data, - const WebURLRequest* original_failed_request, - const WebNavigationTimings& navigation_timings) = 0; + const WebURLRequest* original_failed_request) = 0; // Returns the document loader that is currently loading. May be null. virtual WebDocumentLoader* GetProvisionalDocumentLoader() const = 0;
diff --git a/third_party/blink/public/web/web_navigation_params.h b/third_party/blink/public/web/web_navigation_params.h new file mode 100644 index 0000000..3ab4c5bd --- /dev/null +++ b/third_party/blink/public/web/web_navigation_params.h
@@ -0,0 +1,30 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef THIRD_PARTY_BLINK_PUBLIC_WEB_WEB_NAVIGATION_PARAMS_H_ +#define THIRD_PARTY_BLINK_PUBLIC_WEB_WEB_NAVIGATION_PARAMS_H_ + +#include <memory> + +#include "third_party/blink/public/platform/modules/service_worker/web_service_worker_network_provider.h" +#include "third_party/blink/public/platform/web_source_location.h" +#include "third_party/blink/public/web/web_navigation_timings.h" + +namespace blink { + +// This structure holds all information provided by the embedder that is +// needed for blink to load a Document. This is hence different from +// WebDocumentLoader::ExtraData, which is an opaque structure stored in the +// DocumentLoader and used by the embedder. +struct WebNavigationParams { + WebNavigationTimings navigation_timings; + WebSourceLocation source_location; + bool is_user_activated = false; + std::unique_ptr<blink::WebServiceWorkerNetworkProvider> + service_worker_network_provider; +}; + +} // namespace blink + +#endif
diff --git a/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc b/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc index cf23a90d..ce86343 100644 --- a/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc +++ b/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc
@@ -75,10 +75,7 @@ void end() { // Gracefully terminate tracing. - AdvanceTracing( - 0, - v8::EmbedderHeapTracer::AdvanceTracingActions( - v8::EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)); + AdvanceTracing(std::numeric_limits<double>::infinity()); AbortTracing(); } @@ -147,9 +144,7 @@ visitor->RegisterV8Reference(pair); EXPECT_EQ(visitor->MarkingDeque()->size(), 1ul); - visitor->AdvanceTracing( - 0, v8::EmbedderHeapTracer::AdvanceTracingActions( - v8::EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)); + visitor->AdvanceTracing(std::numeric_limits<double>::infinity()); EXPECT_EQ(visitor->MarkingDeque()->size(), 0ul); EXPECT_TRUE(target_header->IsWrapperHeaderMarked()); EXPECT_TRUE(dependency_header->IsWrapperHeaderMarked()); @@ -442,9 +437,7 @@ EXPECT_FALSE(visitor->MarkingDeque()->IsEmpty()); EXPECT_TRUE(visitor->MarkingDequeContains(base)); - visitor->AdvanceTracing( - 0, v8::EmbedderHeapTracer::AdvanceTracingActions( - v8::EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)); + visitor->AdvanceTracing(std::numeric_limits<double>::infinity()); EXPECT_EQ(visitor->MarkingDeque()->size(), 0ul); EXPECT_TRUE(base_header->IsWrapperHeaderMarked()); EXPECT_TRUE(
diff --git a/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc b/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc index 3daee53..170c063 100644 --- a/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc +++ b/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc
@@ -151,6 +151,12 @@ case v8::Isolate::kFunctionTokenOffsetTooLongForToString: blink_feature = WebFeature::kV8FunctionTokenOffsetTooLongForToString; break; + case v8::Isolate::kWasmSharedMemory: + blink_feature = WebFeature::kV8WasmSharedMemory; + break; + case v8::Isolate::kWasmThreadOpcodes: + blink_feature = WebFeature::kV8WasmThreadOpcodes; + break; default: // This can happen if V8 has added counters that this version of Blink // does not know about. It's harmless.
diff --git a/third_party/blink/renderer/bindings/core/v8/v8_error_handler.cc b/third_party/blink/renderer/bindings/core/v8/v8_error_handler.cc index d80961a..24f422f 100644 --- a/third_party/blink/renderer/bindings/core/v8/v8_error_handler.cc +++ b/third_party/blink/renderer/bindings/core/v8/v8_error_handler.cc
@@ -53,9 +53,6 @@ } ErrorEvent* error_event = static_cast<ErrorEvent*>(event); - if (error_event->World() && error_event->World() != &World()) - return v8::Null(GetIsolate()); - v8::Local<v8::Context> context = script_state->GetContext(); ExecutionContext* execution_context = ToExecutionContext(context); v8::Local<v8::Object> listener = GetListenerObjectInternal(execution_context);
diff --git a/third_party/blink/renderer/core/dom/element.cc b/third_party/blink/renderer/core/dom/element.cc index b13dad2..9ebd8b8 100644 --- a/third_party/blink/renderer/core/dom/element.cc +++ b/third_party/blink/renderer/core/dom/element.cc
@@ -82,7 +82,6 @@ #include "third_party/blink/renderer/core/editing/editing_utilities.h" #include "third_party/blink/renderer/core/editing/ephemeral_range.h" #include "third_party/blink/renderer/core/editing/frame_selection.h" -#include "third_party/blink/renderer/core/editing/iterators/text_iterator.h" #include "third_party/blink/renderer/core/editing/selection_template.h" #include "third_party/blink/renderer/core/editing/serializers/serialization.h" #include "third_party/blink/renderer/core/editing/set_selection_options.h" @@ -3777,19 +3776,6 @@ pointer_id, this); } -String Element::innerText() { - // We need to update layout, since plainText uses line boxes in the layout - // tree. - GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this); - - if (!GetLayoutObject() && !HasDisplayContentsStyle()) - return textContent(true); - - return PlainText( - EphemeralRange::RangeOfContents(*this), - TextIteratorBehavior::Builder().SetForInnerText(true).Build()); -} - String Element::outerText() { // Getting outerText is the same as getting innerText, only // setting is different. You would think this should get the plain
diff --git a/third_party/blink/renderer/core/dom/element.h b/third_party/blink/renderer/core/dom/element.h index 7387b56..7bf4971b 100644 --- a/third_party/blink/renderer/core/dom/element.h +++ b/third_party/blink/renderer/core/dom/element.h
@@ -663,7 +663,8 @@ Element* new_focused_element, InputDeviceCapabilities* source_capabilities = nullptr); - virtual String innerText(); + // The implementation of |innerText()| is found in "element_inner_text.cc". + String innerText(); String outerText(); String InnerHTMLAsString() const; String OuterHTMLAsString() const;
diff --git a/third_party/blink/renderer/core/dom/element.idl b/third_party/blink/renderer/core/dom/element.idl index 0afa850..8c6d62d 100644 --- a/third_party/blink/renderer/core/dom/element.idl +++ b/third_party/blink/renderer/core/dom/element.idl
@@ -125,7 +125,7 @@ // Non-standard API [MeasureAs=ElementScrollIntoViewIfNeeded] void scrollIntoViewIfNeeded(optional boolean centerIfNeeded); - [RuntimeEnabled=ShadowDOMV0, RaisesException, MeasureAs=ElementCreateShadowRoot] ShadowRoot createShadowRoot(); + [RuntimeEnabled=ShadowDOMV0, RaisesException, DeprecateAs=ElementCreateShadowRoot] ShadowRoot createShadowRoot(); [RuntimeEnabled=ShadowDOMV0] NodeList getDestinationInsertionPoints(); // Experimental accessibility API
diff --git a/third_party/blink/renderer/core/editing/BUILD.gn b/third_party/blink/renderer/core/editing/BUILD.gn index 9b6c9a7..bd5bbf4a 100644 --- a/third_party/blink/renderer/core/editing/BUILD.gn +++ b/third_party/blink/renderer/core/editing/BUILD.gn
@@ -127,6 +127,7 @@ "editor.cc", "editor.h", "editor_key_bindings.cc", + "element_inner_text.cc", "ephemeral_range.cc", "ephemeral_range.h", "finder/find_in_page_coordinates.cc",
diff --git a/third_party/blink/renderer/core/editing/element_inner_text.cc b/third_party/blink/renderer/core/editing/element_inner_text.cc new file mode 100644 index 0000000..a1fd19e --- /dev/null +++ b/third_party/blink/renderer/core/editing/element_inner_text.cc
@@ -0,0 +1,690 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "third_party/blink/renderer/core/dom/element.h" + +#include <algorithm> + +#include "base/auto_reset.h" +#include "third_party/blink/renderer/core/dom/node_computed_style.h" +#include "third_party/blink/renderer/core/dom/node_traversal.h" +#include "third_party/blink/renderer/core/dom/text.h" +#include "third_party/blink/renderer/core/editing/editing_utilities.h" +#include "third_party/blink/renderer/core/html/forms/html_opt_group_element.h" +#include "third_party/blink/renderer/core/html/forms/html_option_element.h" +#include "third_party/blink/renderer/core/html/forms/html_select_element.h" +#include "third_party/blink/renderer/core/html/html_br_element.h" +#include "third_party/blink/renderer/core/html/html_paragraph_element.h" +#include "third_party/blink/renderer/core/layout/layout_table_cell.h" +#include "third_party/blink/renderer/core/layout/layout_table_row.h" +#include "third_party/blink/renderer/core/layout/layout_table_section.h" +#include "third_party/blink/renderer/core/layout/layout_text_fragment.h" +#include "third_party/blink/renderer/core/layout/line/inline_text_box.h" +#include "third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.h" +#include "third_party/blink/renderer/core/paint/ng/ng_paint_fragment.h" +#include "third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.h" +#include "third_party/blink/renderer/platform/wtf/text/character_names.h" +#include "third_party/blink/renderer/platform/wtf/text/string_builder.h" +#include "third_party/blink/renderer/platform/wtf/vector.h" + +namespace blink { + +namespace { + +// The implementation of Element#innerText algorithm[1]. +// [1] +// https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute +class ElementInnerTextCollector final { + public: + ElementInnerTextCollector() = default; + + String RunOn(const Element& element); + + private: + // Result characters of innerText collection steps. + class Result final { + public: + Result() = default; + + void EmitBeginBlock(); + void EmitChar16(UChar code_point); + void EmitCollapsibleSpace(); + void EmitEndBlock(); + void EmitNewline(); + void EmitRequiredLineBreak(int count); + void EmitTab(); + void EmitText(const StringView& text); + String Finish(); + + bool HasCollapsibleSpace() const { return has_collapsible_space_; } + + private: + void FlushCollapsibleSpace(); + void FlushRequiredLineBreak(); + + StringBuilder builder_; + int required_line_break_count_ = 0; + bool at_start_of_block_ = false; + bool has_collapsible_space_ = false; + + DISALLOW_COPY_AND_ASSIGN(Result); + }; + + // Minimal CSS text box representation for collecting character. + struct TextBox { + StringView text; + // An offset in |LayoutText::GetText()| or |NGInlineItemsData.text_content|. + unsigned start = 0; + + TextBox(StringView passed_text, unsigned passed_start) + : text(passed_text), start(passed_start) { + DCHECK_GT(text.length(), 0u); + } + }; + + static bool EndsWithWhiteSpace(const InlineTextBox& text_box); + static bool EndsWithWhiteSpace(const LayoutText& layout_text); + static bool EndsWithWhiteSpace(const NGPhysicalTextFragment& fragment); + static bool HasDisplayContentsStyle(const Node& node); + static bool IsAfterWhiteSpace(const InlineTextBox& text_box); + static bool IsAfterWhiteSpace(const LayoutText& layout_text); + static bool IsAfterWhiteSpace(const NGPhysicalTextFragment& fragment); + static bool IsBeingRendered(const Node& node); + static bool IsCollapsibleSpace(UChar code_point); + // Returns true if used value of "display" is block-level. + static bool IsDisplayBlockLevel(const Node&); + static LayoutObject* PreviousLeafOf(const LayoutObject& layout_object); + static bool ShouldEmitNewlineForTableRow(const LayoutTableRow& table_row); + static bool StartsWithWhiteSpace(const LayoutText& layout_text); + + void ProcessChildren(const Node& node); + void ProcessChildrenWithRequiredLineBreaks(const Node& node, + int required_line_break_count); + void ProcessLayoutText(const LayoutText& layout_text); + void ProcessLayoutTextEmpty(const LayoutText& layout_text); + void ProcessLayoutTextForNG(const NGPaintFragment::FragmentRange& fragments); + void ProcessNode(const Node& node); + void ProcessOptionElement(const HTMLOptionElement& element); + void ProcessSelectElement(const HTMLSelectElement& element); + void ProcessText(StringView text, EWhiteSpace white_space); + void ProcessTextBoxes(const LayoutText& layout_text, + const Vector<TextBox>& text_boxes); + void ProcessTextNode(const Text& node); + + // Result character buffer. + Result result_; + + DISALLOW_COPY_AND_ASSIGN(ElementInnerTextCollector); +}; + +String ElementInnerTextCollector::RunOn(const Element& element) { + DCHECK(!element.InActiveDocument() || !NeedsLayoutTreeUpdate(element)); + + // 1. If this element is not being rendered, or if the user agent is a non-CSS + // user agent, then return the same value as the textContent IDL attribute on + // this element. + // Note: To pass WPT test, case we don't use |textContent| for + // "display:content". See [1] for discussion about "display:contents" and + // "being rendered". + // [1] https://github.com/whatwg/html/issues/1837 + if (!IsBeingRendered(element) && !HasDisplayContentsStyle(element)) { + const bool convert_brs_to_newlines = false; + return element.textContent(convert_brs_to_newlines); + } + + // 2. Let results be the list resulting in running the inner text collection + // steps with this element. Each item in results will either be a JavaScript + // string or a positive integer (a required line break count). + ProcessNode(element); + return result_.Finish(); +} + +// static +bool ElementInnerTextCollector::EndsWithWhiteSpace( + const InlineTextBox& text_box) { + const unsigned length = text_box.Len(); + if (length == 0) + return false; + const String text = text_box.GetLineLayoutItem().GetText(); + return IsCollapsibleSpace(text[text_box.Start() + length - 1]); +} + +// static +bool ElementInnerTextCollector::EndsWithWhiteSpace( + const LayoutText& layout_text) { + const unsigned length = layout_text.TextLength(); + return length > 0 && layout_text.ContainsOnlyWhitespace(length - 1, 1); +} + +// static +bool ElementInnerTextCollector::EndsWithWhiteSpace( + const NGPhysicalTextFragment& fragment) { + return IsCollapsibleSpace(fragment.Text()[fragment.Length() - 1]); +} + +// static +bool ElementInnerTextCollector::HasDisplayContentsStyle(const Node& node) { + return node.IsElementNode() && ToElement(node).HasDisplayContentsStyle(); +} + +// An element is *being rendered* if it has any associated CSS layout boxes, +// SVG layout boxes, or some equivalent in other styling languages. +// Note: Just being off-screen does not mean the element is not being rendered. +// The presence of the "hidden" attribute normally means the element is not +// being rendered, though this might be overridden by the style sheets. +// From https://html.spec.whatwg.org/multipage/rendering.html#being-rendered +// static +bool ElementInnerTextCollector::IsBeingRendered(const Node& node) { + return node.GetLayoutObject(); +} + +// static +bool ElementInnerTextCollector::IsAfterWhiteSpace( + const InlineTextBox& text_box) { + const unsigned start = text_box.Start(); + if (start == 0) + return false; + const String text = text_box.GetLineLayoutItem().GetText(); + return IsCollapsibleSpace(text[start - 1]); +} + +// static +bool ElementInnerTextCollector::IsAfterWhiteSpace( + const LayoutText& layout_text) { + if (RuntimeEnabledFeatures::LayoutNGEnabled()) { + const auto fragments = NGPaintFragment::InlineFragmentsFor(&layout_text); + if (!fragments.IsEmpty() && + fragments.IsInLayoutNGInlineFormattingContext()) { + NGPaintFragmentTraversalContext previous = + NGPaintFragmentTraversal::PreviousInlineLeafOfIgnoringLineBreak( + NGPaintFragmentTraversalContext::Create(&fragments.front())); + if (previous.IsNull()) + return false; + const NGPhysicalFragment& previous_fragment = + previous.GetFragment()->PhysicalFragment(); + if (!previous_fragment.IsText()) + return false; + return EndsWithWhiteSpace(ToNGPhysicalTextFragment(previous_fragment)); + } + } + if (InlineTextBox* text_box = layout_text.FirstTextBox()) { + const InlineBox* previous = text_box->PrevLeafChild(); + if (!previous || !previous->IsText()) + return false; + return EndsWithWhiteSpace(ToInlineTextBox(*previous)); + } + const LayoutObject* previous_leaf = PreviousLeafOf(layout_text); + if (!previous_leaf || !previous_leaf->IsText()) + return false; + const LayoutText& previous_text = ToLayoutText(*previous_leaf); + const unsigned length = previous_text.TextLength(); + if (length == 0) + return false; + return previous_text.ContainsOnlyWhitespace(length - 1, 1); +} + +bool ElementInnerTextCollector::IsAfterWhiteSpace( + const NGPhysicalTextFragment& text_box) { + const unsigned start = text_box.StartOffset(); + if (start == 0) + return false; + const String text = text_box.TextContent(); + return IsCollapsibleSpace(text[start - 1]); +} + +// See https://drafts.csswg.org/css-text-3/#white-space-phase-2 +bool ElementInnerTextCollector::IsCollapsibleSpace(UChar code_point) { + return code_point == kSpaceCharacter || code_point == kNewlineCharacter || + code_point == kTabulationCharacter || + code_point == kCarriageReturnCharacter; +} + +// static +bool ElementInnerTextCollector::IsDisplayBlockLevel(const Node& node) { + const LayoutObject* const layout_object = node.GetLayoutObject(); + if (!layout_object || !layout_object->IsLayoutBlock()) + return false; + if (layout_object->IsAtomicInlineLevel()) + return false; + if (layout_object->IsRubyText()) { + // RT isn't consider as block-level. + // e.g. <ruby>abc<rt>def</rt>.innerText == "abcdef" + return false; + } + // Note: CAPTION is associated to |LayoutNGTableCaption| in LayoutNG or + // |LayoutBlockFlow| in legacy layout. + return true; +} + +// static +LayoutObject* ElementInnerTextCollector::PreviousLeafOf( + const LayoutObject& layout_object) { + LayoutObject* parent = layout_object.Parent(); + for (LayoutObject* runner = layout_object.PreviousInPreOrder(); runner; + runner = runner->PreviousInPreOrder()) { + if (runner != parent) + return runner; + parent = runner->Parent(); + } + return nullptr; +} + +// static +bool ElementInnerTextCollector::ShouldEmitNewlineForTableRow( + const LayoutTableRow& table_row) { + const LayoutTable* const table = table_row.Table(); + if (!table) + return false; + if (table_row.NextRow()) + return true; + // For TABLE contains TBODY, TFOOTER, THEAD. + const LayoutTableSection* const table_section = table_row.Section(); + if (!table_section) + return false; + // See |LayoutTable::SectionAbove()| and |SectionBelow()| for traversing + // |LayoutTableSection|. + for (LayoutObject* runner = table_section->NextSibling(); runner; + runner = runner->NextSibling()) { + if (!runner->IsTableSection()) + continue; + if (ToLayoutTableSection(*runner).NumRows() > 0) + return true; + } + // No table row after |node|. + return false; +} + +// static +bool ElementInnerTextCollector::StartsWithWhiteSpace( + const LayoutText& layout_text) { + const unsigned length = layout_text.TextLength(); + return length > 0 && layout_text.ContainsOnlyWhitespace(0, 1); +} + +void ElementInnerTextCollector::ProcessChildren(const Node& container) { + for (const Node& node : NodeTraversal::ChildrenOf(container)) + ProcessNode(node); +} + +void ElementInnerTextCollector::ProcessChildrenWithRequiredLineBreaks( + const Node& node, + int required_line_break_count) { + DCHECK_GE(required_line_break_count, 0); + DCHECK_LE(required_line_break_count, 2); + result_.EmitBeginBlock(); + result_.EmitRequiredLineBreak(required_line_break_count); + ProcessChildren(node); + result_.EmitRequiredLineBreak(required_line_break_count); + result_.EmitEndBlock(); +} + +void ElementInnerTextCollector::ProcessLayoutText( + const LayoutText& layout_text) { + if (layout_text.TextLength() == 0) + return; + if (layout_text.Style()->Visibility() != EVisibility::kVisible) { + // TODO(editing-dev): Once we make ::first-letter don't apply "visibility", + // we should get rid of this if-statement. http://crbug.com/866744 + return; + } + if (RuntimeEnabledFeatures::LayoutNGEnabled()) { + const auto fragments = NGPaintFragment::InlineFragmentsFor(&layout_text); + if (!fragments.IsEmpty() && + fragments.IsInLayoutNGInlineFormattingContext()) { + ProcessLayoutTextForNG(fragments); + return; + } + } + + if (!layout_text.FirstTextBox()) { + if (!layout_text.ContainsOnlyWhitespace(0, layout_text.TextLength())) + return; + if (IsAfterWhiteSpace(layout_text)) + return; + // <div style="width:0">abc<span> <span>def</span></div> reaches here for + // a space between SPAN. + result_.EmitCollapsibleSpace(); + return; + } + + // TODO(editing-dev): We should handle "text-transform" in "::first-line". + // In legacy layout, |InlineTextBox| holds original text and text box + // paint does text transform. + const String text = layout_text.GetText(); + const bool collapse_white_space = layout_text.Style()->CollapseWhiteSpace(); + bool may_have_leading_space = collapse_white_space && + StartsWithWhiteSpace(layout_text) && + !IsAfterWhiteSpace(layout_text); + Vector<TextBox> text_boxes; + for (InlineTextBox* text_box : layout_text.TextBoxes()) { + const unsigned start = + may_have_leading_space && IsAfterWhiteSpace(*text_box) + ? text_box->Start() - 1 + : text_box->Start(); + const unsigned end = text_box->Start() + text_box->Len(); + may_have_leading_space = + collapse_white_space && !IsCollapsibleSpace(text[end - 1]); + text_boxes.emplace_back(StringView(text, start, end - start), start); + } + ProcessTextBoxes(layout_text, text_boxes); + if (!collapse_white_space || !EndsWithWhiteSpace(layout_text)) + return; + result_.EmitCollapsibleSpace(); +} + +void ElementInnerTextCollector::ProcessLayoutTextForNG( + const NGPaintFragment::FragmentRange& paint_fragments) { + DCHECK(!paint_fragments.IsEmpty()); + const LayoutText& layout_text = + ToLayoutText(*paint_fragments.front().GetLayoutObject()); + const bool collapse_white_space = layout_text.Style()->CollapseWhiteSpace(); + bool may_have_leading_space = collapse_white_space && + StartsWithWhiteSpace(layout_text) && + !IsAfterWhiteSpace(layout_text); + // TODO(editing-dev): We should include overflow text to result of CSS + // "text-overflow". See http://crbug.com/873957 + Vector<TextBox> text_boxes; + const StringImpl* last_text_content = nullptr; + for (const NGPaintFragment* paint_fragment : paint_fragments) { + const NGPhysicalTextFragment& text_fragment = + ToNGPhysicalTextFragment(paint_fragment->PhysicalFragment()); + if (text_fragment.IsGeneratedText()) + continue; + // Symbol marker should be appeared in pseudo-element only. + DCHECK_NE(text_fragment.TextType(), NGPhysicalTextFragment::kSymbolMarker); + if (last_text_content != text_fragment.TextContent().Impl()) { + if (!text_boxes.IsEmpty()) { + ProcessTextBoxes(layout_text, text_boxes); + text_boxes.clear(); + } + last_text_content = text_fragment.TextContent().Impl(); + } + const unsigned start = + may_have_leading_space && IsAfterWhiteSpace(text_fragment) + ? text_fragment.StartOffset() - 1 + : text_fragment.StartOffset(); + const unsigned end = text_fragment.EndOffset(); + may_have_leading_space = + collapse_white_space && + !IsCollapsibleSpace(text_fragment.TextContent()[end - 1]); + text_boxes.emplace_back( + StringView(text_fragment.TextContent(), start, end - start), start); + } + if (!text_boxes.IsEmpty()) + ProcessTextBoxes(layout_text, text_boxes); + if (!collapse_white_space || !EndsWithWhiteSpace(layout_text)) + return; + result_.EmitCollapsibleSpace(); +} + +// The "inner text collection steps". +void ElementInnerTextCollector::ProcessNode(const Node& node) { + // 1. Let items be the result of running the inner text collection steps with + // each child node of node in tree order, and then concatenating the results + // to a single list. + + // 2. If node's computed value of 'visibility' is not 'visible', then return + // items. + const ComputedStyle* style = node.GetComputedStyle(); + if (style && style->Visibility() != EVisibility::kVisible) + return ProcessChildren(node); + + // 3. If node is not being rendered, then return items. For the purpose of + // this step, the following elements must act as described if the computed + // value of the 'display' property is not 'none': + // Note: items can be non-empty due to 'display:contents'. + if (!IsBeingRendered(node)) { + // "display:contents" also reaches here since it doesn't have a CSS box. + return ProcessChildren(node); + } + // * select elements have an associated non-replaced inline CSS box whose + // child boxes include only those of optgroup and option element child + // nodes; + // * optgroup elements have an associated non-replaced block-level CSS box + // whose child boxes include only those of option element child nodes; and + // * option element have an associated non-replaced block-level CSS box whose + // child boxes are as normal for non-replaced block-level CSS boxes. + if (IsHTMLSelectElement(node)) + return ProcessSelectElement(ToHTMLSelectElement(node)); + if (IsHTMLOptionElement(node)) { + // Since child nodes of OPTION are not rendered, we use dedicated function. + // e.g. <div>ab<option>12</div>cd</div>innerText == "ab\n12\ncd" + // Note: "label" attribute doesn't affect value of innerText. + return ProcessOptionElement(ToHTMLOptionElement(node)); + } + + // 4. If node is a Text node, then for each CSS text box produced by node. + if (node.IsTextNode()) + return ProcessTextNode(ToText(node)); + + // 5. If node is a br element, then append a string containing a single U+000A + // LINE FEED (LF) character to items. + if (IsHTMLBRElement(node)) { + ProcessChildren(node); + result_.EmitNewline(); + return; + } + + // 6. If node's computed value of 'display' is 'table-cell', and node's CSS + // box is not the last 'table-cell' box of its enclosing 'table-row' box, then + // append a string containing a single U+0009 CHARACTER TABULATION (tab) + // character to items. + const LayoutObject& layout_object = *node.GetLayoutObject(); + if (style->Display() == EDisplay::kTableCell) { + ProcessChildrenWithRequiredLineBreaks(node, 0); + result_.EmitEndBlock(); + if (ToLayoutTableCell(layout_object).NextCell()) + result_.EmitTab(); + return; + } + + // 7. If node's computed value of 'display' is 'table-row', and node's CSS box + // is not the last 'table-row' box of the nearest ancestor 'table' box, then + // append a string containing a single U+000A LINE FEED (LF) character to + // items. + if (style->Display() == EDisplay::kTableRow) { + ProcessChildrenWithRequiredLineBreaks(node, 0); + // Note: The node with "display:table-row" should have |LayoutTableRow|. + if (ShouldEmitNewlineForTableRow(ToLayoutTableRow(layout_object))) + result_.EmitNewline(); + return; + } + + // 8. If node is a p element, then append 2 (a required line break count) at + // the beginning and end of items. + if (IsHTMLParagraphElement(node)) { + // Note: <p style="display:contents>foo</p> doesn't generate layout object + // for P. + ProcessChildrenWithRequiredLineBreaks(node, 2); + return; + } + + // 9. If node's used value of 'display' is block-level or 'table-caption', + // then append 1 (a required line break count) at the beginning and end of + // items. + if (IsDisplayBlockLevel(node)) + return ProcessChildrenWithRequiredLineBreaks(node, 1); + + if (layout_object.IsLayoutBlock()) + return ProcessChildrenWithRequiredLineBreaks(node, 0); + ProcessChildren(node); +} + +void ElementInnerTextCollector::ProcessOptionElement( + const HTMLOptionElement& option_element) { + result_.EmitRequiredLineBreak(1); + result_.EmitText(option_element.text()); + result_.EmitRequiredLineBreak(1); +} + +void ElementInnerTextCollector::ProcessSelectElement( + const HTMLSelectElement& select_element) { + for (const Node& child : NodeTraversal::ChildrenOf(select_element)) { + if (IsHTMLOptionElement(child)) { + ProcessOptionElement(ToHTMLOptionElement(child)); + continue; + } + if (!IsHTMLOptGroupElement(child)) + continue; + // Note: We should emit newline for OPTGROUP even if it has no OPTION. + // e.g. <div>a<select><optgroup></select>b</div>.innerText == "a\nb" + result_.EmitRequiredLineBreak(1); + for (const Node& maybe_option : NodeTraversal::ChildrenOf(child)) { + if (IsHTMLOptionElement(maybe_option)) + ProcessOptionElement(ToHTMLOptionElement(maybe_option)); + } + result_.EmitRequiredLineBreak(1); + } +} + +void ElementInnerTextCollector::ProcessTextBoxes( + const LayoutText& layout_text, + const Vector<TextBox>& passed_text_boxes) { + DCHECK(!passed_text_boxes.IsEmpty()); + Vector<TextBox> text_boxes = passed_text_boxes; + // TODO(editing-dev): We may want to check |ContainsReversedText()| in + // |LayoutText|. See http://crbug.com/873949 + std::sort(text_boxes.begin(), text_boxes.end(), + [](const TextBox& text_box1, const TextBox& text_box2) { + return text_box1.start < text_box2.start; + }); + const EWhiteSpace white_space = layout_text.Style()->WhiteSpace(); + for (const TextBox& text_box : text_boxes) + ProcessText(text_box.text, white_space); +} + +void ElementInnerTextCollector::ProcessText(StringView text, + EWhiteSpace white_space) { + if (!ComputedStyle::CollapseWhiteSpace(white_space)) + return result_.EmitText(text); + for (unsigned index = 0; index < text.length(); ++index) { + if (white_space == EWhiteSpace::kPreLine && + text[index] == kNewlineCharacter) { + result_.EmitNewline(); + continue; + } + if (IsCollapsibleSpace(text[index])) { + result_.EmitCollapsibleSpace(); + continue; + } + result_.EmitChar16(text[index]); + } +} + +void ElementInnerTextCollector::ProcessTextNode(const Text& node) { + if (!node.GetLayoutObject()) + return; + const LayoutText& layout_text = *node.GetLayoutObject(); + if (LayoutText* first_letter_part = layout_text.GetFirstLetterPart()) + ProcessLayoutText(*first_letter_part); + ProcessLayoutText(layout_text); +} + +// ---- + +void ElementInnerTextCollector::Result::EmitBeginBlock() { + if (has_collapsible_space_) + return; + at_start_of_block_ = true; +} + +void ElementInnerTextCollector::Result::EmitChar16(UChar code_point) { + if (required_line_break_count_ > 0) + FlushRequiredLineBreak(); + else + FlushCollapsibleSpace(); + DCHECK_EQ(required_line_break_count_, 0); + DCHECK(!has_collapsible_space_); + builder_.Append(code_point); + at_start_of_block_ = false; +} + +void ElementInnerTextCollector::Result::EmitCollapsibleSpace() { + if (at_start_of_block_) + return; + FlushRequiredLineBreak(); + has_collapsible_space_ = true; +} + +void ElementInnerTextCollector::Result::EmitEndBlock() { + // Discard tailing collapsible spaces from last child of the block. + has_collapsible_space_ = false; +} + +void ElementInnerTextCollector::Result::EmitNewline() { + FlushRequiredLineBreak(); + has_collapsible_space_ = false; + builder_.Append(kNewlineCharacter); +} + +void ElementInnerTextCollector::Result::EmitRequiredLineBreak(int count) { + DCHECK_GE(count, 0); + DCHECK_LE(count, 2); + if (count == 0) + return; + // 4. Remove any runs of consecutive required line break count items at the + // start or end of results. + if (builder_.IsEmpty()) { + DCHECK_EQ(required_line_break_count_, 0); + return; + } + // 5. Replace each remaining run of consecutive required line break count + // items with a string consisting of as many U+000A LINE FEED (LF) characters + // as the maximum of the values in the required line break count items. + required_line_break_count_ = std::max(required_line_break_count_, count); + at_start_of_block_ = true; +} + +void ElementInnerTextCollector::Result::EmitTab() { + if (required_line_break_count_ > 0) + FlushRequiredLineBreak(); + has_collapsible_space_ = false; + at_start_of_block_ = false; + builder_.Append(kTabulationCharacter); +} + +void ElementInnerTextCollector::Result::EmitText(const StringView& text) { + if (text.IsEmpty()) + return; + at_start_of_block_ = false; + if (required_line_break_count_ > 0) + FlushRequiredLineBreak(); + else + FlushCollapsibleSpace(); + DCHECK_EQ(required_line_break_count_, 0); + DCHECK(!has_collapsible_space_); + builder_.Append(text); +} + +String ElementInnerTextCollector::Result::Finish() { + if (required_line_break_count_ == 0) + FlushCollapsibleSpace(); + return builder_.ToString(); +} + +void ElementInnerTextCollector::Result::FlushCollapsibleSpace() { + if (!has_collapsible_space_) + return; + has_collapsible_space_ = false; + builder_.Append(kSpaceCharacter); +} + +void ElementInnerTextCollector::Result::FlushRequiredLineBreak() { + DCHECK_GE(required_line_break_count_, 0); + DCHECK_LE(required_line_break_count_, 2); + builder_.Append("\n\n", required_line_break_count_); + required_line_break_count_ = 0; + has_collapsible_space_ = false; +} + +} // anonymous namespace + +String Element::innerText() { + // We need to update layout, since |ElementInnerTextCollector()| uses line + // boxes in the layout tree. + GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this); + return ElementInnerTextCollector().RunOn(*this); +} + +} // namespace blink
diff --git a/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc b/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc index 292c578..04c32e1 100644 --- a/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc +++ b/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc
@@ -1029,7 +1029,7 @@ "sample"); Controller().SetEditableSelectionOffsets(PlainTextRange(17, 17)); - EXPECT_STREQ("hello\nworld\n0123456789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n0123456789", div->innerText().Utf8().data()); EXPECT_EQ(17u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(17u, Controller().GetSelectionOffsets().End()); @@ -1039,79 +1039,79 @@ ImeTextSpanThickness::kThin, 0)); // The caret exceeds left boundary. - // "*hello\nworld\n01234AB56789", where * stands for caret. + // "*hello\nworld\n\n01234AB56789", where * stands for caret. Controller().SetComposition("AB", ime_text_spans, -100, -100); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(0u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(0u, Controller().GetSelectionOffsets().End()); // The caret is on left boundary. - // "*hello\nworld\n01234AB56789". + // "*hello\nworld\n\n01234AB56789". Controller().SetComposition("AB", ime_text_spans, -17, -17); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(0u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(0u, Controller().GetSelectionOffsets().End()); // The caret is in the 1st node. - // "he*llo\nworld\n01234AB56789". + // "he*llo\nworld\n\n01234AB56789". Controller().SetComposition("AB", ime_text_spans, -15, -15); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(2u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(2u, Controller().GetSelectionOffsets().End()); // The caret is on right boundary of the 1st node. - // "hello*\nworld\n01234AB56789". + // "hello*\nworld\n\n01234AB56789". Controller().SetComposition("AB", ime_text_spans, -12, -12); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(5u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(5u, Controller().GetSelectionOffsets().End()); // The caret is on right boundary of the 2nd node. - // "hello\n*world\n01234AB56789". + // "hello\n*world\n\n01234AB56789". Controller().SetComposition("AB", ime_text_spans, -11, -11); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(6u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(6u, Controller().GetSelectionOffsets().End()); // The caret is on right boundary of the 3rd node. // "hello\nworld*\n01234AB56789". Controller().SetComposition("AB", ime_text_spans, -6, -6); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(11u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(11u, Controller().GetSelectionOffsets().End()); // The caret is on right boundary of the 4th node. // "hello\nworld\n*01234AB56789". Controller().SetComposition("AB", ime_text_spans, -5, -5); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(12u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(12u, Controller().GetSelectionOffsets().End()); // The caret is before the composing text. - // "hello\nworld\n01234*AB56789". + // "hello\nworld\n\n01234*AB56789". Controller().SetComposition("AB", ime_text_spans, 0, 0); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(17u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(17u, Controller().GetSelectionOffsets().End()); // The caret is after the composing text. - // "hello\nworld\n01234AB*56789". + // "hello\nworld\n\n01234AB*56789". Controller().SetComposition("AB", ime_text_spans, 2, 2); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(19u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(19u, Controller().GetSelectionOffsets().End()); // The caret is on right boundary. - // "hello\nworld\n01234AB56789*". + // "hello\nworld\n\n01234AB56789*". Controller().SetComposition("AB", ime_text_spans, 7, 7); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(24u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(24u, Controller().GetSelectionOffsets().End()); // The caret exceeds right boundary. - // "hello\nworld\n01234AB56789*". + // "hello\nworld\n\n01234AB56789*". Controller().SetComposition("AB", ime_text_spans, 100, 100); - EXPECT_STREQ("hello\nworld\n01234AB56789", div->innerText().Utf8().data()); + EXPECT_STREQ("hello\nworld\n\n01234AB56789", div->innerText().Utf8().data()); EXPECT_EQ(24u, Controller().GetSelectionOffsets().Start()); EXPECT_EQ(24u, Controller().GetSelectionOffsets().End()); }
diff --git a/third_party/blink/renderer/core/editing/iterators/text_iterator_behavior.h b/third_party/blink/renderer/core/editing/iterators/text_iterator_behavior.h index 14bafd6..59eb8df 100644 --- a/third_party/blink/renderer/core/editing/iterators/text_iterator_behavior.h +++ b/third_party/blink/renderer/core/editing/iterators/text_iterator_behavior.h
@@ -46,6 +46,7 @@ bool ExcludeAutofilledValue() const { return values_.bits.exclude_autofilled_value; } + // TODO(editing-dev): We should remove unused flag |ForInnerText()|. bool ForInnerText() const { return values_.bits.for_inner_text; } bool ForSelectionToString() const { return values_.bits.for_selection_to_string;
diff --git a/third_party/blink/renderer/core/events/error_event.cc b/third_party/blink/renderer/core/events/error_event.cc index 52507ab..46fce0c0 100644 --- a/third_party/blink/renderer/core/events/error_event.cc +++ b/third_party/blink/renderer/core/events/error_event.cc
@@ -82,6 +82,10 @@ return EventNames::ErrorEvent; } +bool ErrorEvent::CanBeDispatchedInWorld(const DOMWrapperWorld& world) const { + return !world_ || world_ == &world; +} + ScriptValue ErrorEvent::error(ScriptState* script_state) const { // Don't return |m_error| when we are in the different worlds to avoid // leaking a V8 value.
diff --git a/third_party/blink/renderer/core/events/error_event.h b/third_party/blink/renderer/core/events/error_event.h index a18243e..e6a8d72 100644 --- a/third_party/blink/renderer/core/events/error_event.h +++ b/third_party/blink/renderer/core/events/error_event.h
@@ -88,6 +88,7 @@ SourceLocation* Location() const { return location_.get(); } const AtomicString& InterfaceName() const override; + bool CanBeDispatchedInWorld(const DOMWrapperWorld&) const override; DOMWrapperWorld* World() const { return world_.get(); }
diff --git a/third_party/blink/renderer/core/exported/local_frame_client_impl.cc b/third_party/blink/renderer/core/exported/local_frame_client_impl.cc index 605c305..cb68b825 100644 --- a/third_party/blink/renderer/core/exported/local_frame_client_impl.cc +++ b/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
@@ -53,6 +53,7 @@ #include "third_party/blink/public/web/web_dom_event.h" #include "third_party/blink/public/web/web_form_element.h" #include "third_party/blink/public/web/web_local_frame_client.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_node.h" #include "third_party/blink/public/web/web_plugin.h" #include "third_party/blink/public/web/web_plugin_params.h" @@ -157,6 +158,29 @@ cc::EventListenerProperties::kNone); } +void SetupDocumentLoader( + DocumentLoader* document_loader, + std::unique_ptr<WebNavigationParams> navigation_params) { + if (!navigation_params) { + document_loader->GetTiming().SetNavigationStart(CurrentTimeTicks()); + return; + } + + const WebNavigationTimings& navigation_timings = + navigation_params->navigation_timings; + document_loader->UpdateNavigationTimings( + navigation_timings.navigation_start, navigation_timings.redirect_start, + navigation_timings.redirect_end, navigation_timings.fetch_start, + navigation_timings.input_start); + + document_loader->SetSourceLocation(navigation_params->source_location); + if (navigation_params->is_user_activated) + document_loader->SetUserActivated(); + + document_loader->SetServiceWorkerNetworkProvider( + std::move(navigation_params->service_worker_network_provider)); +} + } // namespace LocalFrameClientImpl::LocalFrameClientImpl(WebLocalFrameImpl* frame) @@ -743,17 +767,14 @@ const SubstituteData& data, ClientRedirectPolicy client_redirect_policy, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) { + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) { DCHECK(frame); WebDocumentLoaderImpl* document_loader = WebDocumentLoaderImpl::Create( frame, request, data, client_redirect_policy, devtools_navigation_token); + SetupDocumentLoader(document_loader, std::move(navigation_params)); document_loader->SetExtraData(std::move(extra_data)); - document_loader->UpdateNavigationTimings( - navigation_timings.navigation_start, navigation_timings.redirect_start, - navigation_timings.redirect_end, navigation_timings.fetch_start, - navigation_timings.input_start); if (web_frame_->Client()) web_frame_->Client()->DidCreateDocumentLoader(document_loader); return document_loader;
diff --git a/third_party/blink/renderer/core/exported/local_frame_client_impl.h b/third_party/blink/renderer/core/exported/local_frame_client_impl.h index 15c6c839..3e2f194 100644 --- a/third_party/blink/renderer/core/exported/local_frame_client_impl.h +++ b/third_party/blink/renderer/core/exported/local_frame_client_impl.h
@@ -163,8 +163,8 @@ const SubstituteData&, ClientRedirectPolicy, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) override; + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) override; WTF::String UserAgent() override; WTF::String DoNotTrackValue() override; void TransitionToCommittedForNewPage() override;
diff --git a/third_party/blink/renderer/core/exported/web_document.cc b/third_party/blink/renderer/core/exported/web_document.cc index 963fa6d2..addbe64 100644 --- a/third_party/blink/renderer/core/exported/web_document.cc +++ b/third_party/blink/renderer/core/exported/web_document.cc
@@ -47,6 +47,8 @@ #include "third_party/blink/renderer/core/dom/document_type.h" #include "third_party/blink/renderer/core/dom/element.h" #include "third_party/blink/renderer/core/dom/events/event.h" +#include "third_party/blink/renderer/core/editing/ephemeral_range.h" +#include "third_party/blink/renderer/core/editing/iterators/text_iterator.h" #include "third_party/blink/renderer/core/frame/web_local_frame_impl.h" #include "third_party/blink/renderer/core/html/forms/html_form_element.h" #include "third_party/blink/renderer/core/html/html_all_collection.h" @@ -156,9 +158,17 @@ } WebString WebDocument::ContentAsTextForTesting() const { - if (Element* document_element = ConstUnwrap<Document>()->documentElement()) - return WebString(document_element->innerText()); - return WebString(); + Element* document_element = ConstUnwrap<Document>()->documentElement(); + if (!document_element) + return WebString(); + // TODO(editing-dev): We should use |Element::innerText()|. + const_cast<Document*>(ConstUnwrap<Document>()) + ->UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(document_element); + if (!document_element->GetLayoutObject()) + return document_element->textContent(true); + return WebString( + PlainText(EphemeralRange::RangeOfContents(*document_element), + TextIteratorBehavior::Builder().SetForInnerText(true).Build())); } WebElementCollection WebDocument::All() {
diff --git a/third_party/blink/renderer/core/exported/web_document_loader_impl.cc b/third_party/blink/renderer/core/exported/web_document_loader_impl.cc index ddb7c6c8..e6cc9b8b 100644 --- a/third_party/blink/renderer/core/exported/web_document_loader_impl.cc +++ b/third_party/blink/renderer/core/exported/web_document_loader_impl.cc
@@ -150,20 +150,8 @@ return DocumentLoader::GetServiceWorkerNetworkProvider(); } -void WebDocumentLoaderImpl::SetSourceLocation( - const WebSourceLocation& source_location) { - std::unique_ptr<SourceLocation> location = - SourceLocation::Create(source_location.url, source_location.line_number, - source_location.column_number, nullptr); - DocumentLoader::SetSourceLocation(std::move(location)); -} - void WebDocumentLoaderImpl::ResetSourceLocation() { - DocumentLoader::SetSourceLocation(nullptr); -} - -void WebDocumentLoaderImpl::SetUserActivated() { - DocumentLoader::SetUserActivated(); + DocumentLoader::ResetSourceLocation(); } void WebDocumentLoaderImpl::BlockParser() {
diff --git a/third_party/blink/renderer/core/exported/web_document_loader_impl.h b/third_party/blink/renderer/core/exported/web_document_loader_impl.h index e222cbeb..fef873f 100644 --- a/third_party/blink/renderer/core/exported/web_document_loader_impl.h +++ b/third_party/blink/renderer/core/exported/web_document_loader_impl.h
@@ -77,9 +77,7 @@ void SetServiceWorkerNetworkProvider( std::unique_ptr<WebServiceWorkerNetworkProvider>) override; WebServiceWorkerNetworkProvider* GetServiceWorkerNetworkProvider() override; - void SetSourceLocation(const WebSourceLocation&) override; void ResetSourceLocation() override; - void SetUserActivated() override; void BlockParser() override; void ResumeParser() override; bool IsArchive() const override;
diff --git a/third_party/blink/renderer/core/exported/web_frame_test.cc b/third_party/blink/renderer/core/exported/web_frame_test.cc index 24bd5bc..c828a08 100644 --- a/third_party/blink/renderer/core/exported/web_frame_test.cc +++ b/third_party/blink/renderer/core/exported/web_frame_test.cc
@@ -7382,7 +7382,8 @@ history_item->GenerateResourceRequest(mojom::FetchCacheMode::kDefault); main_frame->CommitNavigation( WrappedResourceRequest(request), WebFrameLoadType::kBackForward, item, - false, base::UnguessableToken::Create(), nullptr, WebNavigationTimings()); + false, base::UnguessableToken::Create(), nullptr /* navigation_params */, + nullptr /* extra_data */); FrameTestHelpers::ReloadFrame(child_frame); EXPECT_EQ(item.UrlString(), main_frame->GetDocument().Url().GetString());
diff --git a/third_party/blink/renderer/core/frame/deprecation.cc b/third_party/blink/renderer/core/frame/deprecation.cc index 1f6c44d..7ad7dcb 100644 --- a/third_party/blink/renderer/core/frame/deprecation.cc +++ b/third_party/blink/renderer/core/frame/deprecation.cc
@@ -53,6 +53,8 @@ kM69, kM70, kM71, + kM72, + kM73, }; // Returns estimated milestone dates as human-readable strings. @@ -87,6 +89,10 @@ return "M70, around October 2018"; case kM71: return "M71, around December 2018"; + case kM72: + return "M72, around January 2019"; + case kM73: + return "M73, around March 2019"; } NOTREACHED(); @@ -97,7 +103,8 @@ double MilestoneDate(Milestone milestone) { // These are the Estimated Stable Dates: // https://www.chromium.org/developers/calendar - + // All are at 04:00:00 GMT. + // TODO(yoichio): We should have something like "Time(March, 6, 2018)". switch (milestone) { case kUnknown: return 0; @@ -125,6 +132,10 @@ return 1539662400000; // October 16, 2018. case kM71: return 1543899600000; // December 4, 2018. + case kM72: + return 1548734400000; // January 29, 2019. + case kM73: + return 1552363200000; // March 12, 2019. } NOTREACHED(); @@ -445,6 +456,12 @@ WillBeRemoved("The step timing function with step position 'middle'", kM62, "5189363944128512")}; + case WebFeature::kElementCreateShadowRoot: + return {"ElementCreateShadowRoot", kM73, + ReplacedWillBeRemoved("Element.createShadowRoot", + "Element.attachShadow", kM73, + "4507242028072960")}; + case WebFeature::kHTMLImportsHasStyleSheets: return {"HTMLImportsHasStyleSheets", kUnknown, "Styling master document from stylesheets defined in "
diff --git a/third_party/blink/renderer/core/frame/frame_test_helpers.cc b/third_party/blink/renderer/core/frame/frame_test_helpers.cc index c054a70a..cf9cee1 100644 --- a/third_party/blink/renderer/core/frame/frame_test_helpers.cc +++ b/third_party/blink/renderer/core/frame/frame_test_helpers.cc
@@ -44,7 +44,7 @@ #include "third_party/blink/public/platform/web_url_request.h" #include "third_party/blink/public/platform/web_url_response.h" #include "third_party/blink/public/web/web_frame_widget.h" -#include "third_party/blink/public/web/web_navigation_timings.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_settings.h" #include "third_party/blink/public/web/web_tree_scope_type.h" #include "third_party/blink/public/web/web_view_client.h" @@ -101,11 +101,13 @@ return owned_client; } -WebNavigationTimings BuildDummyWebNavigationTimings() { - WebNavigationTimings web_navigation_timings; - web_navigation_timings.navigation_start = base::TimeTicks::Now(); - web_navigation_timings.fetch_start = base::TimeTicks::Now(); - return web_navigation_timings; +std::unique_ptr<WebNavigationParams> BuildDummyNavigationParams() { + std::unique_ptr<WebNavigationParams> navigation_params = + std::make_unique<WebNavigationParams>(); + navigation_params->navigation_timings.navigation_start = + base::TimeTicks::Now(); + navigation_params->navigation_timings.fetch_start = base::TimeTicks::Now(); + return navigation_params; } } // namespace @@ -118,7 +120,7 @@ frame->CommitNavigation( WebURLRequest(web_url), blink::WebFrameLoadType::kStandard, blink::WebHistoryItem(), false, base::UnguessableToken::Create(), - nullptr, BuildDummyWebNavigationTimings()); + BuildDummyNavigationParams(), nullptr /* extra_data */); } PumpPendingRequestsForFrameToLoad(frame); } @@ -136,9 +138,9 @@ HistoryItem* history_item = item; frame->CommitNavigation( WrappedResourceRequest(history_item->GenerateResourceRequest(cache_mode)), - WebFrameLoadType::kBackForward, item, - /*is_client_redirect=*/false, base::UnguessableToken::Create(), nullptr, - BuildDummyWebNavigationTimings()); + WebFrameLoadType::kBackForward, item, false /* is_client_redirect */, + base::UnguessableToken::Create(), BuildDummyNavigationParams(), + nullptr /* extra_data */); PumpPendingRequestsForFrameToLoad(frame); }
diff --git a/third_party/blink/renderer/core/frame/local_frame.h b/third_party/blink/renderer/core/frame/local_frame.h index ddb1f140..f14e8bf 100644 --- a/third_party/blink/renderer/core/frame/local_frame.h +++ b/third_party/blink/renderer/core/frame/local_frame.h
@@ -325,8 +325,8 @@ bool should_send_resource_timing_info_to_parent() const { return should_send_resource_timing_info_to_parent_; } - void DidSendResourceTimingInfoToParent() { - should_send_resource_timing_info_to_parent_ = false; + void SetShouldSendResourceTimingInfoToParent(bool value) { + should_send_resource_timing_info_to_parent_ = value; } // TODO(https://crbug.com/578349): provisional frames are a hack that should
diff --git a/third_party/blink/renderer/core/frame/local_frame_client.h b/third_party/blink/renderer/core/frame/local_frame_client.h index 864324156..e66fde7 100644 --- a/third_party/blink/renderer/core/frame/local_frame_client.h +++ b/third_party/blink/renderer/core/frame/local_frame_client.h
@@ -45,7 +45,7 @@ #include "third_party/blink/public/platform/web_worker_fetch_context.h" #include "third_party/blink/public/web/web_global_object_reuse_policy.h" #include "third_party/blink/public/web/web_history_commit_type.h" -#include "third_party/blink/public/web/web_navigation_timings.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_triggering_event_info.h" #include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/core/dom/document.h" @@ -239,8 +239,8 @@ const SubstituteData&, ClientRedirectPolicy, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) = 0; + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) = 0; virtual String UserAgent() = 0;
diff --git a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc index 345ce73..4415311 100644 --- a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc +++ b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
@@ -119,6 +119,7 @@ #include "third_party/blink/public/web/web_input_element.h" #include "third_party/blink/public/web/web_local_frame_client.h" #include "third_party/blink/public/web/web_media_player_action.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_node.h" #include "third_party/blink/public/web/web_performance.h" #include "third_party/blink/public/web/web_plugin.h" @@ -948,7 +949,7 @@ CommitDataNavigation(data, WebString::FromUTF8("text/html"), WebString::FromUTF8("UTF-8"), base_url, unreachable_url, replace, WebFrameLoadType::kStandard, WebHistoryItem(), - false, nullptr, nullptr, WebNavigationTimings()); + false, nullptr, nullptr, nullptr); } void WebLocalFrameImpl::StopLoading() { @@ -2036,8 +2037,8 @@ const WebHistoryItem& item, bool is_client_redirect, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) { + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) { DCHECK(GetFrame()); DCHECK(!request.IsNull()); DCHECK(!request.Url().ProtocolIs("javascript")); @@ -2052,9 +2053,9 @@ if (is_client_redirect) frame_request.SetClientRedirect(ClientRedirectPolicy::kClientRedirect); HistoryItem* history_item = item; - GetFrame()->Loader().CommitNavigation(frame_request, web_frame_load_type, - history_item, std::move(extra_data), - navigation_timings); + GetFrame()->Loader().CommitNavigation( + frame_request, web_frame_load_type, history_item, + std::move(navigation_params), std::move(extra_data)); } blink::mojom::CommitResult WebLocalFrameImpl::CommitSameDocumentNavigation( @@ -2121,9 +2122,9 @@ WebFrameLoadType web_frame_load_type, const WebHistoryItem& item, bool is_client_redirect, + std::unique_ptr<WebNavigationParams> navigation_params, std::unique_ptr<WebDocumentLoader::ExtraData> navigation_data, - const WebURLRequest* original_failed_request, - const WebNavigationTimings& navigation_timings) { + const WebURLRequest* original_failed_request) { DCHECK(GetFrame()); // TODO(dgozman): this whole logic of rewriting the params is odd, @@ -2178,7 +2179,7 @@ GetFrame()->Loader().CommitNavigation( frame_request, web_frame_load_type, history_item, - std::move(navigation_data), navigation_timings); + std::move(navigation_params), std::move(navigation_data)); } WebLocalFrame::FallbackContentResult @@ -2251,7 +2252,7 @@ DCHECK(GetFrame()); GetFrame()->Loader().StateMachine()->AdvanceTo( FrameLoaderStateMachine::kCommittedMultipleRealLoads); - GetFrame()->DidSendResourceTimingInfoToParent(); + GetFrame()->SetShouldSendResourceTimingInfoToParent(false); } void WebLocalFrameImpl::NotifyUserActivation() {
diff --git a/third_party/blink/renderer/core/frame/web_local_frame_impl.h b/third_party/blink/renderer/core/frame/web_local_frame_impl.h index cd50924..448cefc 100644 --- a/third_party/blink/renderer/core/frame/web_local_frame_impl.h +++ b/third_party/blink/renderer/core/frame/web_local_frame_impl.h
@@ -265,8 +265,8 @@ const WebHistoryItem&, bool is_client_redirect, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) override; + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) override; blink::mojom::CommitResult CommitSameDocumentNavigation( const WebURL&, WebFrameLoadType, @@ -283,9 +283,9 @@ WebFrameLoadType, const WebHistoryItem&, bool is_client_redirect, + std::unique_ptr<WebNavigationParams> navigation_params, std::unique_ptr<WebDocumentLoader::ExtraData> navigation_data, - const WebURLRequest* original_request_to_replace, - const WebNavigationTimings& navigation_timings) override; + const WebURLRequest* original_request_to_replace) override; FallbackContentResult MaybeRenderFallbackContent( const WebURLError&) const override; void ReportContentSecurityPolicyViolation(
diff --git a/third_party/blink/renderer/core/html/forms/file_chooser.h b/third_party/blink/renderer/core/html/forms/file_chooser.h index d2cb33b..f4c300b 100644 --- a/third_party/blink/renderer/core/html/forms/file_chooser.h +++ b/third_party/blink/renderer/core/html/forms/file_chooser.h
@@ -64,7 +64,7 @@ const FileMetadata metadata; }; -class FileChooserClient : public PopupOpeningObserver { +class CORE_EXPORT FileChooserClient : public PopupOpeningObserver { public: virtual void FilesChosen(const Vector<FileChooserFileInfo>&) = 0; virtual LocalFrame* FrameOrNull() const = 0; @@ -84,8 +84,9 @@ class FileChooser : public RefCounted<FileChooser>, public WebFileChooserCompletion { public: - static scoped_refptr<FileChooser> Create(FileChooserClient*, - const WebFileChooserParams&); + CORE_EXPORT static scoped_refptr<FileChooser> Create( + FileChooserClient*, + const WebFileChooserParams&); ~FileChooser() override; LocalFrame* FrameOrNull() const {
diff --git a/third_party/blink/renderer/core/html/forms/html_option_element.cc b/third_party/blink/renderer/core/html/forms/html_option_element.cc index 7ccac04..7b5479e 100644 --- a/third_party/blink/renderer/core/html/forms/html_option_element.cc +++ b/third_party/blink/renderer/core/html/forms/html_option_element.cc
@@ -392,11 +392,4 @@ return !style || style->Display() == EDisplay::kNone; } -String HTMLOptionElement::innerText() { - // A workaround for crbug.com/424578. We add ShadowRoot to an OPTION, but - // innerText behavior for Shadow DOM is unclear. We just return the same - // string before adding ShadowRoot. - return textContent(); -} - } // namespace blink
diff --git a/third_party/blink/renderer/core/html/forms/html_option_element.h b/third_party/blink/renderer/core/html/forms/html_option_element.h index 1232e25..854489f 100644 --- a/third_party/blink/renderer/core/html/forms/html_option_element.h +++ b/third_party/blink/renderer/core/html/forms/html_option_element.h
@@ -102,7 +102,6 @@ void RemovedFrom(ContainerNode&) override; void AccessKeyAction(bool) override; void ChildrenChanged(const ChildrenChange&) override; - String innerText() override; void DidAddUserAgentShadowRoot(ShadowRoot&) override;
diff --git a/third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.h b/third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.h index 19758ce7..582c7be 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.h +++ b/third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.h
@@ -96,6 +96,7 @@ unsigned Length() const { return end_offset_ - start_offset_; } StringView Text() const { return StringView(text_, start_offset_, Length()); } + const String& TextContent() const { return text_; } // ShapeResult may be nullptr if |IsFlowControl()|. const ShapeResult* TextShapeResult() const { return shape_result_.get(); }
diff --git a/third_party/blink/renderer/core/loader/document_loader.cc b/third_party/blink/renderer/core/loader/document_loader.cc index 0f5dab2..50296b8 100644 --- a/third_party/blink/renderer/core/loader/document_loader.cc +++ b/third_party/blink/renderer/core/loader/document_loader.cc
@@ -259,8 +259,15 @@ } void DocumentLoader::SetSourceLocation( - std::unique_ptr<SourceLocation> source_location) { - source_location_ = std::move(source_location); + const WebSourceLocation& source_location) { + std::unique_ptr<SourceLocation> location = + SourceLocation::Create(source_location.url, source_location.line_number, + source_location.column_number, nullptr); + source_location_ = std::move(location); +} + +void DocumentLoader::ResetSourceLocation() { + source_location_ = nullptr; } std::unique_ptr<SourceLocation> DocumentLoader::CopySourceLocation() const {
diff --git a/third_party/blink/renderer/core/loader/document_loader.h b/third_party/blink/renderer/core/loader/document_loader.h index 8d487ff8..2d105d4 100644 --- a/third_party/blink/renderer/core/loader/document_loader.h +++ b/third_party/blink/renderer/core/loader/document_loader.h
@@ -227,8 +227,10 @@ return service_worker_network_provider_.get(); } + // Allows to specify the SourceLocation that triggered the navigation. + void SetSourceLocation(const WebSourceLocation& source_location); + void ResetSourceLocation(); std::unique_ptr<SourceLocation> CopySourceLocation() const; - void SetSourceLocation(std::unique_ptr<SourceLocation>); void LoadFailed(const ResourceError&);
diff --git a/third_party/blink/renderer/core/loader/empty_clients.cc b/third_party/blink/renderer/core/loader/empty_clients.cc index b07f958..c469d73 100644 --- a/third_party/blink/renderer/core/loader/empty_clients.cc +++ b/third_party/blink/renderer/core/loader/empty_clients.cc
@@ -120,8 +120,8 @@ const SubstituteData& substitute_data, ClientRedirectPolicy client_redirect_policy, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) { + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) { DCHECK(frame); return DocumentLoader::Create(frame, request, substitute_data,
diff --git a/third_party/blink/renderer/core/loader/empty_clients.h b/third_party/blink/renderer/core/loader/empty_clients.h index cff83b9..df822a1 100644 --- a/third_party/blink/renderer/core/loader/empty_clients.h +++ b/third_party/blink/renderer/core/loader/empty_clients.h
@@ -300,8 +300,8 @@ const SubstituteData&, ClientRedirectPolicy, const base::UnguessableToken& devtools_navigation_token, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) override; + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) override; String UserAgent() override { return ""; }
diff --git a/third_party/blink/renderer/core/loader/frame_fetch_context.cc b/third_party/blink/renderer/core/loader/frame_fetch_context.cc index df843406..8e3816d 100644 --- a/third_party/blink/renderer/core/loader/frame_fetch_context.cc +++ b/third_party/blink/renderer/core/loader/frame_fetch_context.cc
@@ -818,7 +818,7 @@ // Main resource timing information is reported through the owner to be // passed to the parent frame, if appropriate. frame->Owner()->AddResourceTiming(info); - frame->DidSendResourceTimingInfoToParent(); + frame->SetShouldSendResourceTimingInfoToParent(false); return; } @@ -896,9 +896,12 @@ if (!GetFrame()->should_send_resource_timing_info_to_parent()) return false; // Do not report iframe navigation that restored from history, since its - // location may have been changed after initial navigation. - if (MasterDocumentLoader()->LoadType() == WebFrameLoadType::kBackForward) + // location may have been changed after initial navigation, + if (MasterDocumentLoader()->LoadType() == WebFrameLoadType::kBackForward) { + // ...and do not report subsequent navigations in the iframe too. + GetFrame()->SetShouldSendResourceTimingInfoToParent(false); return false; + } return true; }
diff --git a/third_party/blink/renderer/core/loader/frame_loader.cc b/third_party/blink/renderer/core/loader/frame_loader.cc index 23bd7254..8215b0a 100644 --- a/third_party/blink/renderer/core/loader/frame_loader.cc +++ b/third_party/blink/renderer/core/loader/frame_loader.cc
@@ -45,6 +45,7 @@ #include "third_party/blink/public/platform/web_url_request.h" #include "third_party/blink/public/web/web_frame_load_type.h" #include "third_party/blink/public/web/web_history_item.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/renderer/bindings/core/v8/script_controller.h" #include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h" #include "third_party/blink/renderer/core/dom/document.h" @@ -223,8 +224,8 @@ provisional_document_loader_ = Client()->CreateDocumentLoader( frame_, initial_request, SubstituteData(), ClientRedirectPolicy::kNotClientRedirect, - base::UnguessableToken::Create(), nullptr /* extra_data */, - WebNavigationTimings()); + base::UnguessableToken::Create(), nullptr /* navigation_params */, + nullptr /* extra_data */); provisional_document_loader_->StartLoading(); frame_->GetDocument()->CancelParsing(); @@ -921,7 +922,7 @@ provisional_document_loader_ = CreateDocumentLoader( resource_request, request, frame_load_type, navigation_type, - nullptr /* extra_data */, WebNavigationTimings()); + nullptr /* navigation_params */, nullptr /* extra_data */); if (request.Form()) Client()->DispatchWillSubmitForm(request.Form()); @@ -966,8 +967,8 @@ const FrameLoadRequest& passed_request, WebFrameLoadType frame_load_type, HistoryItem* history_item, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) { + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) { CHECK(!passed_request.OriginDocument()); CHECK(passed_request.FrameName().IsEmpty()); CHECK(!passed_request.Form()); @@ -1032,7 +1033,7 @@ // below. We should probably call DocumentLoader::CommitNavigation directly. provisional_document_loader_ = CreateDocumentLoader( resource_request, request, frame_load_type, navigation_type, - std::move(extra_data), navigation_timings); + std::move(navigation_params), std::move(extra_data)); provisional_document_loader_->AppendRedirect( provisional_document_loader_->Url()); if (IsBackForwardLoadType(frame_load_type)) { @@ -1752,16 +1753,16 @@ const FrameLoadRequest& frame_load_request, WebFrameLoadType load_type, WebNavigationType navigation_type, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data, - const WebNavigationTimings& navigation_timings) { + std::unique_ptr<WebNavigationParams> navigation_params, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data) { DocumentLoader* loader = Client()->CreateDocumentLoader( frame_, request, frame_load_request.GetSubstituteData().IsValid() ? frame_load_request.GetSubstituteData() : DefaultSubstituteDataForURL(request.Url()), frame_load_request.ClientRedirect(), - frame_load_request.GetDevToolsNavigationToken(), std::move(extra_data), - navigation_timings); + frame_load_request.GetDevToolsNavigationToken(), + std::move(navigation_params), std::move(extra_data)); loader->SetLoadType(load_type); loader->SetNavigationType(navigation_type);
diff --git a/third_party/blink/renderer/core/loader/frame_loader.h b/third_party/blink/renderer/core/loader/frame_loader.h index dcfc8df..91c48c09 100644 --- a/third_party/blink/renderer/core/loader/frame_loader.h +++ b/third_party/blink/renderer/core/loader/frame_loader.h
@@ -39,7 +39,7 @@ #include "third_party/blink/public/web/commit_result.mojom-shared.h" #include "third_party/blink/public/web/web_document_loader.h" #include "third_party/blink/public/web/web_frame_load_type.h" -#include "third_party/blink/public/web/web_navigation_timings.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/public/web/web_navigation_type.h" #include "third_party/blink/public/web/web_triggering_event_info.h" #include "third_party/blink/renderer/core/core_export.h" @@ -73,6 +73,7 @@ class SerializedScriptValue; class SubstituteData; struct FrameLoadRequest; +struct WebNavigationParams; CORE_EXPORT bool IsBackForwardLoadType(WebFrameLoadType); CORE_EXPORT bool IsReloadLoadType(WebFrameLoadType); @@ -111,8 +112,8 @@ const FrameLoadRequest&, WebFrameLoadType = WebFrameLoadType::kStandard, HistoryItem* = nullptr, - std::unique_ptr<WebDocumentLoader::ExtraData> extra_data = nullptr, - const WebNavigationTimings& navigation_timings = WebNavigationTimings()); + std::unique_ptr<WebNavigationParams> navigation_params = nullptr, + std::unique_ptr<WebDocumentLoader::ExtraData> extra_data = nullptr); // Called when the browser process has asked this renderer process to commit a // same document navigation in that frame. Returns false if the navigation @@ -263,8 +264,8 @@ const FrameLoadRequest&, WebFrameLoadType, WebNavigationType, - std::unique_ptr<WebDocumentLoader::ExtraData>, - const WebNavigationTimings&); + std::unique_ptr<WebNavigationParams>, + std::unique_ptr<WebDocumentLoader::ExtraData>); LocalFrameClient* Client() const;
diff --git a/third_party/blink/renderer/core/loader/link_loader.cc b/third_party/blink/renderer/core/loader/link_loader.cc index c9400a6..46ceb06 100644 --- a/third_party/blink/renderer/core/loader/link_loader.cc +++ b/third_party/blink/renderer/core/loader/link_loader.cc
@@ -576,9 +576,13 @@ resource_request.SetReferrerPolicy(params.referrer_policy); resource_request.SetFetchImportanceMode( GetFetchImportanceAttributeValue(params.importance)); + + // If Signed Exchange is enabled, prefer the application/signed-exchange + // content type + // (https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#internet-media-type-applicationsigned-exchange). if (RuntimeEnabledFeatures::SignedHTTPExchangeEnabled()) { DEFINE_STATIC_LOCAL(const AtomicString, accept_prefetch, - ("application/signed-exchange;v=b1;q=0.9,*/*;q=0.8")); + ("application/signed-exchange;v=b2;q=0.9,*/*;q=0.8")); resource_request.SetHTTPAccept(accept_prefetch); }
diff --git a/third_party/blink/renderer/core/page/chrome_client_impl.cc b/third_party/blink/renderer/core/page/chrome_client_impl.cc index 6abd7c7..b2c5d8f 100644 --- a/third_party/blink/renderer/core/page/chrome_client_impl.cc +++ b/third_party/blink/renderer/core/page/chrome_client_impl.cc
@@ -612,7 +612,7 @@ void ChromeClientImpl::DidCompleteFileChooser(FileChooser& chooser) { if (!file_chooser_queue_.IsEmpty() && - file_chooser_queue_.front() != &chooser) { + file_chooser_queue_.front().get() != &chooser) { // This function is called even if |chooser| wasn't stored in // file_chooser_queue_. return; @@ -620,7 +620,7 @@ file_chooser_queue_.EraseAt(0); if (file_chooser_queue_.IsEmpty()) return; - FileChooser* next_chooser = file_chooser_queue_.front(); + FileChooser* next_chooser = file_chooser_queue_.front().get(); if (next_chooser->OpenFileChooser(*this)) return; // Choosing failed, so try the next chooser.
diff --git a/third_party/blink/renderer/core/page/chrome_client_impl.h b/third_party/blink/renderer/core/page/chrome_client_impl.h index 206f416..9b6d78e 100644 --- a/third_party/blink/renderer/core/page/chrome_client_impl.h +++ b/third_party/blink/renderer/core/page/chrome_client_impl.h
@@ -248,10 +248,12 @@ WebViewImpl* web_view_; // Weak pointer. HeapHashSet<WeakMember<PopupOpeningObserver>> popup_opening_observers_; - Vector<FileChooser*> file_chooser_queue_; + Vector<scoped_refptr<FileChooser>> file_chooser_queue_; Cursor last_set_mouse_cursor_for_testing_; bool cursor_overridden_; bool did_request_non_empty_tool_tip_; + + FRIEND_TEST_ALL_PREFIXES(FileChooserQueueTest, DerefQueuedChooser); }; DEFINE_TYPE_CASTS(ChromeClientImpl,
diff --git a/third_party/blink/renderer/core/page/chrome_client_impl_test.cc b/third_party/blink/renderer/core/page/chrome_client_impl_test.cc index 30b4bcc6..4e20e23 100644 --- a/third_party/blink/renderer/core/page/chrome_client_impl_test.cc +++ b/third_party/blink/renderer/core/page/chrome_client_impl_test.cc
@@ -42,6 +42,7 @@ #include "third_party/blink/renderer/core/html/forms/color_chooser_client.h" #include "third_party/blink/renderer/core/html/forms/date_time_chooser.h" #include "third_party/blink/renderer/core/html/forms/date_time_chooser_client.h" +#include "third_party/blink/renderer/core/html/forms/file_chooser.h" #include "third_party/blink/renderer/core/html/forms/html_select_element.h" #include "third_party/blink/renderer/core/loader/frame_load_request.h" #include "third_party/blink/renderer/core/page/page.h" @@ -239,4 +240,64 @@ EXPECT_TRUE(CanOpenDateTimeChooser()); } +// A WebLocalFrameClient which makes FileChooser::OpenFileChooser() success. +class FrameClientForFileChooser : public FrameTestHelpers::TestWebFrameClient { + bool RunFileChooser(const WebFileChooserParams& params, + WebFileChooserCompletion* chooser_completion) override { + return true; + } +}; + +// A FileChooserClient which makes FileChooser::OpenFileChooser() success. +class MockFileChooserClient + : public GarbageCollectedFinalized<MockFileChooserClient>, + public FileChooserClient { + USING_GARBAGE_COLLECTED_MIXIN(MockFileChooserClient); + + public: + explicit MockFileChooserClient(LocalFrame* frame) : frame_(frame) {} + void Trace(Visitor* visitor) override { + visitor->Trace(frame_); + FileChooserClient::Trace(visitor); + } + + private: + // FilesChosen() and WillOpenPopup() are never called in the test. + void FilesChosen(const Vector<FileChooserFileInfo>&) override {} + void WillOpenPopup() override {} + + LocalFrame* FrameOrNull() const override { return frame_; } + + Member<LocalFrame> frame_; +}; + +class FileChooserQueueTest : public testing::Test { + protected: + void SetUp() override { + web_view_ = helper_.Initialize(&frame_client_); + chrome_client_impl_ = + ToChromeClientImpl(&web_view_->GetPage()->GetChromeClient()); + } + + FrameTestHelpers::WebViewHelper helper_; + FrameClientForFileChooser frame_client_; + WebViewImpl* web_view_; + Persistent<ChromeClientImpl> chrome_client_impl_; +}; + +TEST_F(FileChooserQueueTest, DerefQueuedChooser) { + LocalFrame* frame = helper_.LocalMainFrame()->GetFrame(); + auto* client = new MockFileChooserClient(frame); + WebFileChooserParams params; + scoped_refptr<FileChooser> chooser1 = FileChooser::Create(client, params); + scoped_refptr<FileChooser> chooser2 = FileChooser::Create(client, params); + + chrome_client_impl_->OpenFileChooser(frame, chooser1); + chrome_client_impl_->OpenFileChooser(frame, chooser2); + EXPECT_EQ(2u, chrome_client_impl_->file_chooser_queue_.size()); + chooser2.reset(); + chrome_client_impl_->DidCompleteFileChooser(*chooser1); + EXPECT_EQ(1u, chrome_client_impl_->file_chooser_queue_.size()); +} + } // namespace blink
diff --git a/third_party/blink/renderer/core/testing/sim/sim_test.cc b/third_party/blink/renderer/core/testing/sim/sim_test.cc index 001d6b6..c6a502e 100644 --- a/third_party/blink/renderer/core/testing/sim/sim_test.cc +++ b/third_party/blink/renderer/core/testing/sim/sim_test.cc
@@ -6,7 +6,7 @@ #include "content/test/test_blink_web_unit_test_support.h" #include "third_party/blink/public/platform/web_cache.h" -#include "third_party/blink/public/web/web_navigation_timings.h" +#include "third_party/blink/public/web/web_navigation_params.h" #include "third_party/blink/renderer/core/dom/document.h" #include "third_party/blink/renderer/core/exported/web_view_impl.h" #include "third_party/blink/renderer/core/frame/local_dom_window.h" @@ -61,7 +61,8 @@ WebURLRequest request{KURL(url)}; WebView().MainFrameImpl()->CommitNavigation( request, WebFrameLoadType::kStandard, WebHistoryItem(), false, - base::UnguessableToken::Create(), nullptr, WebNavigationTimings()); + base::UnguessableToken::Create(), nullptr /* navigation_params */, + nullptr /* extra_data */); } LocalDOMWindow& SimTest::Window() {
diff --git a/third_party/blink/renderer/core/workers/worker_thread.cc b/third_party/blink/renderer/core/workers/worker_thread.cc index 172204d7..0e1ce1e 100644 --- a/third_party/blink/renderer/core/workers/worker_thread.cc +++ b/third_party/blink/renderer/core/workers/worker_thread.cc
@@ -86,6 +86,28 @@ return next_worker_thread_id; } +// RefCountedWaitableEvent makes WaitableEvent thread-safe refcounted. +// WorkerThread retains references to the event from both the parent context +// thread and the worker thread with this wrapper. See +// WorkerThread::PerformShutdownOnWorkerThread() for details. +class WorkerThread::RefCountedWaitableEvent + : public WTF::ThreadSafeRefCounted<RefCountedWaitableEvent> { + public: + static scoped_refptr<RefCountedWaitableEvent> Create() { + return base::AdoptRef<RefCountedWaitableEvent>(new RefCountedWaitableEvent); + } + + void Wait() { event_.Wait(); } + void Signal() { event_.Signal(); } + + private: + RefCountedWaitableEvent() = default; + + base::WaitableEvent event_; + + DISALLOW_COPY_AND_ASSIGN(RefCountedWaitableEvent); +}; + WorkerThread::~WorkerThread() { MutexLocker lock(ThreadSetMutex()); DCHECK(WorkerThreads().Contains(this)); @@ -111,7 +133,7 @@ // Synchronously initialize the per-global-scope scheduler to prevent someone // from posting a task to the thread before the scheduler is ready. - WaitableEvent waitable_event; + base::WaitableEvent waitable_event; GetWorkerBackingThread().BackingThread().PostTask( FROM_HERE, CrossThreadBind(&WorkerThread::InitializeSchedulerOnWorkerThread, @@ -200,7 +222,7 @@ } for (WorkerThread* thread : threads) - thread->shutdown_event_->Wait(); + thread->WaitForShutdownForTesting(); // Destruct base::Thread and join the underlying system threads. for (WorkerThread* thread : threads) @@ -302,6 +324,11 @@ return false; } +void WorkerThread::WaitForShutdownForTesting() { + DCHECK_CALLED_ON_VALID_THREAD(parent_thread_checker_); + shutdown_event_->Wait(); +} + ExitCode WorkerThread::GetExitCodeForTesting() { MutexLocker lock(mutex_); return exit_code_; @@ -336,9 +363,7 @@ forcible_termination_delay_(kForcibleTerminationDelay), devtools_worker_token_(base::UnguessableToken::Create()), worker_reporting_proxy_(worker_reporting_proxy), - shutdown_event_(std::make_unique<WaitableEvent>( - WaitableEvent::ResetPolicy::kManual, - WaitableEvent::InitialState::kNonSignaled)) { + shutdown_event_(RefCountedWaitableEvent::Create()) { MutexLocker lock(ThreadSetMutex()); WorkerThreads().insert(this); } @@ -389,7 +414,7 @@ } void WorkerThread::InitializeSchedulerOnWorkerThread( - WaitableEvent* waitable_event) { + base::WaitableEvent* waitable_event) { DCHECK(IsCurrentThread()); DCHECK(!worker_scheduler_); scheduler::WebThreadImplForWorkerScheduler& web_thread_for_worker = @@ -550,14 +575,22 @@ if (IsOwningBackingThread()) GetWorkerBackingThread().ShutdownOnBackingThread(); - // We must not touch workerBackingThread() from now on. + // We must not touch GetWorkerBackingThread() from now on. + + // Keep the reference to the shutdown event in a local variable so that the + // worker thread can signal it even after calling DidTerminateWorkerThread(), + // which may destroy |this|. + scoped_refptr<RefCountedWaitableEvent> shutdown_event = shutdown_event_; // Notify the proxy that the WorkerOrWorkletGlobalScope has been disposed // of. This can free this thread object, hence it must not be touched // afterwards. GetWorkerReportingProxy().DidTerminateWorkerThread(); - shutdown_event_->Signal(); + // This should be signaled at the end because this may induce the main thread + // to clear the worker backing thread and stop thread execution in the system + // level. + shutdown_event->Signal(); } void WorkerThread::SetThreadState(ThreadState next_thread_state) {
diff --git a/third_party/blink/renderer/core/workers/worker_thread.h b/third_party/blink/renderer/core/workers/worker_thread.h index 19d31e73..aa25d12 100644 --- a/third_party/blink/renderer/core/workers/worker_thread.h +++ b/third_party/blink/renderer/core/workers/worker_thread.h
@@ -32,6 +32,7 @@ #include "base/memory/scoped_refptr.h" #include "base/optional.h" #include "base/single_thread_task_runner.h" +#include "base/synchronization/waitable_event.h" #include "base/thread_annotations.h" #include "base/unguessable_token.h" #include "services/network/public/mojom/fetch_api.mojom-shared.h" @@ -43,7 +44,6 @@ #include "third_party/blink/renderer/core/workers/worker_backing_thread_startup_data.h" #include "third_party/blink/renderer/core/workers/worker_inspector_proxy.h" #include "third_party/blink/renderer/platform/scheduler/public/worker_scheduler.h" -#include "third_party/blink/renderer/platform/waitable_event.h" #include "third_party/blink/renderer/platform/web_task_runner.h" #include "third_party/blink/renderer/platform/wtf/forward.h" #include "third_party/blink/renderer/platform/wtf/functional.h" @@ -182,7 +182,7 @@ bool IsForciblyTerminated() LOCKS_EXCLUDED(mutex_); - void WaitForShutdownForTesting() { shutdown_event_->Wait(); } + void WaitForShutdownForTesting(); ExitCode GetExitCodeForTesting() LOCKS_EXCLUDED(mutex_); ParentExecutionContextTaskRunners* GetParentExecutionContextTaskRunners() @@ -262,7 +262,7 @@ void EnsureScriptExecutionTerminates(ExitCode) LOCKS_EXCLUDED(mutex_); // These are called in this order during worker thread startup. - void InitializeSchedulerOnWorkerThread(WaitableEvent*); + void InitializeSchedulerOnWorkerThread(base::WaitableEvent*); void InitializeOnWorkerThread( std::unique_ptr<GlobalScopeCreationParams>, const base::Optional<WorkerBackingThreadStartupData>&, @@ -323,8 +323,11 @@ CrossThreadPersistent<WorkerOrWorkletGlobalScope> global_scope_; CrossThreadPersistent<WorkerInspectorController> worker_inspector_controller_; - // Signaled when the thread completes termination on the worker thread. - std::unique_ptr<WaitableEvent> shutdown_event_; + // Signaled when the thread completes termination on the worker thread. Only + // the parent context thread should wait on this event after calling + // Terminate(). + class RefCountedWaitableEvent; + scoped_refptr<RefCountedWaitableEvent> shutdown_event_; // Used to cancel a scheduled forcible termination task. See // mayForciblyTerminateExecution() for details.
diff --git a/third_party/blink/renderer/platform/BUILD.gn b/third_party/blink/renderer/platform/BUILD.gn index ef168b8b..87b2da8 100644 --- a/third_party/blink/renderer/platform/BUILD.gn +++ b/third_party/blink/renderer/platform/BUILD.gn
@@ -974,6 +974,8 @@ "graphics/image_animation_policy.h", "graphics/image_data_buffer.cc", "graphics/image_data_buffer.h", + "graphics/image_decoder_wrapper.cc", + "graphics/image_decoder_wrapper.h", "graphics/image_decoding_store.cc", "graphics/image_decoding_store.h", "graphics/image_frame_generator.cc",
diff --git a/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc b/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc index ee2a9616..1106c97 100644 --- a/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc +++ b/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
@@ -42,7 +42,7 @@ ThreadState::Current()->EnableWrapperTracingBarrier(); } -void ScriptWrappableMarkingVisitor::EnterFinalPause() { +void ScriptWrappableMarkingVisitor::EnterFinalPause(EmbedderStackState) { CHECK(ThreadState::Current()); CHECK(!ThreadState::Current()->IsWrapperTracingForbidden()); ActiveScriptWrappableBase::TraceActiveScriptWrappables(isolate_, this); @@ -181,9 +181,7 @@ } } -bool ScriptWrappableMarkingVisitor::AdvanceTracing( - double deadline_in_ms, - v8::EmbedderHeapTracer::AdvanceTracingActions actions) { +bool ScriptWrappableMarkingVisitor::AdvanceTracing(double deadline_in_ms) { // Do not drain the marking deque in a state where we can generally not // perform a GC. This makes sure that TraceTraits and friends find // themselves in a well-defined environment, e.g., properly set up vtables. @@ -193,15 +191,13 @@ base::AutoReset<bool>(&advancing_tracing_, true); TimeTicks deadline = TimeTicks() + TimeDelta::FromMillisecondsD(deadline_in_ms); - while (actions.force_completion == - v8::EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION || - WTF::CurrentTimeTicks() < deadline) { + while (WTF::CurrentTimeTicks() < deadline) { if (marking_deque_.IsEmpty()) { - return false; + return true; } marking_deque_.TakeFirst().Trace(this); } - return true; + return false; } void ScriptWrappableMarkingVisitor::MarkWrapperHeader(
diff --git a/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h b/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h index 715d062..1d9f3803 100644 --- a/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h +++ b/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h
@@ -73,11 +73,10 @@ void RegisterV8References(const std::vector<std::pair<void*, void*>>& internal_fields_of_potential_wrappers) override; void RegisterV8Reference(const std::pair<void*, void*>& internal_fields); - bool AdvanceTracing(double deadline_in_ms, - v8::EmbedderHeapTracer::AdvanceTracingActions) override; + bool AdvanceTracing(double deadline_in_ms) override; void TraceEpilogue() override; void AbortTracing() override; - void EnterFinalPause() override; + void EnterFinalPause(EmbedderStackState) override; size_t NumberOfWrappersToTrace() override; // ScriptWrappableVisitor interface.
diff --git a/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc b/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc index 18b65a5..eb0cd37 100644 --- a/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc +++ b/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc
@@ -54,12 +54,15 @@ class FrameSettingImageProvider : public cc::ImageProvider { public: - FrameSettingImageProvider(size_t frame_index) : frame_index_(frame_index) {} + FrameSettingImageProvider(size_t frame_index, + cc::PaintImage::GeneratorClientId client_id) + : frame_index_(frame_index), client_id_(client_id) {} ~FrameSettingImageProvider() override = default; ScopedDecodedDrawImage GetDecodedDrawImage( const cc::DrawImage& draw_image) override { - auto sk_image = draw_image.paint_image().GetSkImageForFrame(frame_index_); + auto sk_image = + draw_image.paint_image().GetSkImageForFrame(frame_index_, client_id_); return ScopedDecodedDrawImage( cc::DecodedDrawImage(sk_image, SkSize::MakeEmpty(), SkSize::Make(1, 1), draw_image.filter_quality(), true)); @@ -67,8 +70,25 @@ private: size_t frame_index_; + cc::PaintImage::GeneratorClientId client_id_; }; +void GenerateBitmapForPaintImage(cc::PaintImage paint_image, + size_t frame_index, + cc::PaintImage::GeneratorClientId client_id, + SkBitmap* bitmap) { + CHECK(paint_image); + CHECK_GE(paint_image.FrameCount(), frame_index); + + SkImageInfo info = + SkImageInfo::MakeN32Premul(paint_image.width(), paint_image.height()); + bitmap->allocPixels(info, paint_image.width() * 4); + bitmap->eraseColor(SK_AlphaTRANSPARENT); + FrameSettingImageProvider image_provider(frame_index, client_id); + cc::SkiaPaintCanvas canvas(*bitmap, &image_provider); + canvas.drawImage(paint_image, 0u, 0u, nullptr); +} + } // namespace class BitmapImageTest : public testing::Test { @@ -117,18 +137,10 @@ } SkBitmap GenerateBitmap(size_t frame_index) { - CHECK_GE(image_->FrameCount(), frame_index); - auto paint_image = image_->PaintImageForTesting(); - CHECK(paint_image); - SkBitmap bitmap; - SkImageInfo info = SkImageInfo::MakeN32Premul(image_->Size().Width(), - image_->Size().Height()); - bitmap.allocPixels(info, image_->Size().Width() * 4); - bitmap.eraseColor(SK_AlphaTRANSPARENT); - FrameSettingImageProvider image_provider(frame_index); - cc::SkiaPaintCanvas canvas(bitmap, &image_provider); - canvas.drawImage(paint_image, 0u, 0u, nullptr); + GenerateBitmapForPaintImage(image_->PaintImageForTesting(), frame_index, + cc::PaintImage::kDefaultGeneratorClientId, + &bitmap); return bitmap; } @@ -416,6 +428,37 @@ VerifyBitmap(bitmap, SK_ColorYELLOW); } +TEST_F(BitmapImageTest, GifDecoderMultiThreaded) { + LoadImage("/images/resources/green-red-blue-yellow-animated.gif"); + auto paint_image = image_->PaintImageForTesting(); + ASSERT_EQ(paint_image.FrameCount(), 4u); + + struct Decode { + SkBitmap bitmap; + std::unique_ptr<base::Thread> thread; + cc::PaintImage::GeneratorClientId client_id; + }; + + Decode decodes[4]; + SkColor expected_color[4] = {SkColorSetARGB(255, 0, 128, 0), SK_ColorRED, + SK_ColorBLUE, SK_ColorYELLOW}; + for (int i = 0; i < 4; ++i) { + decodes[i].thread = + std::make_unique<base::Thread>("Decode" + std::to_string(i)); + decodes[i].client_id = cc::PaintImage::GetNextGeneratorClientId(); + + decodes[i].thread->StartAndWaitForTesting(); + decodes[i].thread->task_runner()->PostTask( + FROM_HERE, base::BindOnce(&GenerateBitmapForPaintImage, paint_image, i, + decodes[i].client_id, &decodes[i].bitmap)); + } + + for (int i = 0; i < 4; ++i) { + decodes[i].thread->FlushForTesting(); + VerifyBitmap(decodes[i].bitmap, expected_color[i]); + } +} + TEST_F(BitmapImageTest, APNGDecoder00) { LoadImage("/images/resources/apng00.png"); auto actual_bitmap = GenerateBitmap(0u);
diff --git a/third_party/blink/renderer/platform/graphics/decoding_image_generator.cc b/third_party/blink/renderer/platform/graphics/decoding_image_generator.cc index 3af4ece..a46a8c1 100644 --- a/third_party/blink/renderer/platform/graphics/decoding_image_generator.cc +++ b/third_party/blink/renderer/platform/graphics/decoding_image_generator.cc
@@ -69,7 +69,8 @@ std::move(frame), info, std::move(segment_reader), std::move(frames), PaintImage::GetNextContentId(), true); return std::make_unique<SkiaPaintImageGenerator>( - std::move(generator), PaintImage::kDefaultFrameIndex); + std::move(generator), PaintImage::kDefaultFrameIndex, + PaintImage::kDefaultGeneratorClientId); } // static @@ -115,9 +116,10 @@ void* pixels, size_t row_bytes, size_t frame_index, + PaintImage::GeneratorClientId client_id, uint32_t lazy_pixel_ref) { - TRACE_EVENT1("blink", "DecodingImageGenerator::getPixels", "frame index", - static_cast<int>(frame_index)); + TRACE_EVENT2("blink", "DecodingImageGenerator::getPixels", "frame index", + static_cast<int>(frame_index), "client_id", client_id); // Implementation only supports decoding to a supported size. if (dst_info.dimensions() != GetSupportedDecodeSize(dst_info.dimensions())) { @@ -153,7 +155,7 @@ PlatformInstrumentation::WillDecodeLazyPixelRef(lazy_pixel_ref); const bool decoded = frame_generator_->DecodeAndScale( data_.get(), all_data_received_, frame_index, decode_info, pixels, - row_bytes, alpha_option); + row_bytes, alpha_option, client_id); PlatformInstrumentation::DidDecodeLazyPixelRef(); if (decoded && needs_color_xform) {
diff --git a/third_party/blink/renderer/platform/graphics/decoding_image_generator.h b/third_party/blink/renderer/platform/graphics/decoding_image_generator.h index 3a0b8ee..8e083e0 100644 --- a/third_party/blink/renderer/platform/graphics/decoding_image_generator.h +++ b/third_party/blink/renderer/platform/graphics/decoding_image_generator.h
@@ -72,6 +72,7 @@ void* pixels, size_t row_bytes, size_t frame_index, + PaintImage::GeneratorClientId client_id, uint32_t lazy_pixel_ref) override; bool QueryYUV8(SkYUVSizeInfo*, SkYUVColorSpace*) const override; bool GetYUV8Planes(const SkYUVSizeInfo&,
diff --git a/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc b/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc index d689fdf..4a99e04 100644 --- a/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc +++ b/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test_wo_platform.cc
@@ -18,7 +18,8 @@ sk_sp<SkImage> CreateFrameAtIndex(DeferredImageDecoder* decoder, size_t index) { return SkImage::MakeFromGenerator(std::make_unique<SkiaPaintImageGenerator>( - decoder->CreateGenerator(index), index)); + decoder->CreateGenerator(index), index, + cc::PaintImage::kDefaultGeneratorClientId)); } } // namespace
diff --git a/third_party/blink/renderer/platform/graphics/image.cc b/third_party/blink/renderer/platform/graphics/image.cc index 28935ae..c561c134 100644 --- a/third_party/blink/renderer/platform/graphics/image.cc +++ b/third_party/blink/renderer/platform/graphics/image.cc
@@ -80,7 +80,8 @@ static const size_t kLockedMemoryLimitBytes = 64 * 1024 * 1024; DEFINE_THREAD_SAFE_STATIC_LOCAL(cc::SoftwareImageDecodeCache, image_decode_cache, - (kN32_SkColorType, kLockedMemoryLimitBytes)); + (kN32_SkColorType, kLockedMemoryLimitBytes, + PaintImage::kDefaultGeneratorClientId)); return image_decode_cache; }
diff --git a/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.cc b/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.cc new file mode 100644 index 0000000..17edcb4 --- /dev/null +++ b/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.cc
@@ -0,0 +1,305 @@ +// Copyright 2018 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "third_party/blink/renderer/platform/graphics/image_decoder_wrapper.h" + +#include "third_party/blink/renderer/platform/graphics/image_decoding_store.h" +#include "third_party/blink/renderer/platform/graphics/image_frame_generator.h" + +namespace blink { +namespace { + +void CopyPixels(void* dst_addr, + size_t dst_row_bytes, + const void* src_addr, + size_t src_row_bytes, + const SkImageInfo& info) { + size_t row_bytes = info.bytesPerPixel() * info.width(); + for (int y = 0; y < info.height(); ++y) { + memcpy(dst_addr, src_addr, row_bytes); + src_addr = static_cast<const char*>(src_addr) + src_row_bytes; + dst_addr = static_cast<char*>(dst_addr) + dst_row_bytes; + } +} + +bool CompatibleInfo(const SkImageInfo& src, const SkImageInfo& dst) { + if (src == dst) + return true; + + // It is legal to write kOpaque_SkAlphaType pixels into a kPremul_SkAlphaType + // buffer. This can happen when DeferredImageDecoder allocates an + // kOpaque_SkAlphaType image generator based on cached frame info, while the + // ImageFrame-allocated dest bitmap stays kPremul_SkAlphaType. + if (src.alphaType() == kOpaque_SkAlphaType && + dst.alphaType() == kPremul_SkAlphaType) { + const SkImageInfo& tmp = src.makeAlphaType(kPremul_SkAlphaType); + return tmp == dst; + } + + return false; +} + +// Creates a SkPixelRef such that the memory for pixels is given by an external +// body. This is used to write directly to the memory given by Skia during +// decoding. +class ExternalMemoryAllocator final : public SkBitmap::Allocator { + USING_FAST_MALLOC(ExternalMemoryAllocator); + + public: + ExternalMemoryAllocator(const SkImageInfo& info, + void* pixels, + size_t row_bytes) + : info_(info), pixels_(pixels), row_bytes_(row_bytes) {} + + bool allocPixelRef(SkBitmap* dst) override { + const SkImageInfo& info = dst->info(); + if (kUnknown_SkColorType == info.colorType()) + return false; + + if (!CompatibleInfo(info_, info) || row_bytes_ != dst->rowBytes()) + return false; + + return dst->installPixels(info, pixels_, row_bytes_); + } + + private: + SkImageInfo info_; + void* pixels_; + size_t row_bytes_; + + DISALLOW_COPY_AND_ASSIGN(ExternalMemoryAllocator); +}; + +} // namespace + +ImageDecoderWrapper::ImageDecoderWrapper( + ImageFrameGenerator* generator, + SegmentReader* data, + const SkISize& scaled_size, + ImageDecoder::AlphaOption alpha_option, + ColorBehavior decoder_color_behavior, + ImageDecoder::HighBitDepthDecodingOption decoding_option, + size_t index, + const SkImageInfo& info, + void* pixels, + size_t row_bytes, + bool all_data_received, + cc::PaintImage::GeneratorClientId client_id) + : generator_(generator), + data_(data), + scaled_size_(scaled_size), + alpha_option_(alpha_option), + decoder_color_behavior_(decoder_color_behavior), + decoding_option_(decoding_option), + frame_index_(index), + info_(info), + pixels_(pixels), + row_bytes_(row_bytes), + all_data_received_(all_data_received), + client_id_(client_id) {} + +ImageDecoderWrapper::~ImageDecoderWrapper() = default; + +bool ImageDecoderWrapper::Decode(ImageDecoderFactory* factory, + size_t* frame_count, + bool* has_alpha) { + DCHECK(frame_count); + DCHECK(has_alpha); + + ImageDecoder* decoder = nullptr; + std::unique_ptr<ImageDecoder> new_decoder; + + const bool resume_decoding = ImageDecodingStore::Instance().LockDecoder( + generator_, scaled_size_, alpha_option_, client_id_, &decoder); + DCHECK(!resume_decoding || decoder); + + if (resume_decoding) { + decoder->SetData(data_, all_data_received_); + } else { + new_decoder = CreateDecoderWithData(factory); + if (!new_decoder) + return false; + decoder = new_decoder.get(); + } + + // For multi-frame image decoders, we need to know how many frames are + // in that image in order to release the decoder when all frames are + // decoded. frameCount() is reliable only if all data is received and set in + // decoder, particularly with GIF. + if (all_data_received_) + *frame_count = decoder->FrameCount(); + + const bool decode_to_external_memory = + ShouldDecodeToExternalMemory(*frame_count, resume_decoding); + + ExternalMemoryAllocator external_memory_allocator(info_, pixels_, row_bytes_); + if (decode_to_external_memory) + decoder->SetMemoryAllocator(&external_memory_allocator); + ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(frame_index_); + // SetMemoryAllocator() can try to access decoder's data, so we have to + // clear it before clearing SegmentReader. + if (decode_to_external_memory) + decoder->SetMemoryAllocator(nullptr); + // Verify we have the only ref-count. + DCHECK(external_memory_allocator.unique()); + + decoder->SetData(scoped_refptr<SegmentReader>(nullptr), false); + decoder->ClearCacheExceptFrame(frame_index_); + + const bool has_decoded_frame = + frame && frame->GetStatus() != ImageFrame::kFrameEmpty && + !frame->Bitmap().isNull(); + if (!has_decoded_frame) { + decode_failed_ = decoder->Failed(); + if (resume_decoding) { + ImageDecodingStore::Instance().UnlockDecoder(generator_, client_id_, + decoder); + } + return false; + } + + SkBitmap scaled_size_bitmap = frame->Bitmap(); + DCHECK_EQ(scaled_size_bitmap.width(), scaled_size_.width()); + DCHECK_EQ(scaled_size_bitmap.height(), scaled_size_.height()); + +// If we decoded into external memory, the bitmap should be backed by the +// pixels passed to the allocator. +#if DCHECK_IS_ON() + if (!decoder->IsForTesting() && decode_to_external_memory) { + DCHECK_EQ(scaled_size_bitmap.getPixels(), pixels_); + } +#endif + + *has_alpha = !scaled_size_bitmap.isOpaque(); + if (!decode_to_external_memory) { + CopyPixels(pixels_, row_bytes_, scaled_size_bitmap.getPixels(), + scaled_size_bitmap.rowBytes(), info_); + } + + // Free as much memory as possible. For single-frame images, we can + // just delete the decoder entirely if they use the external allocator. + // For multi-frame images, we keep the decoder around in order to preserve + // decoded information such as the required previous frame indexes, but if + // we've reached the last frame we can at least delete all the cached frames. + // (If we were to do this before reaching the last frame, any subsequent + // requested frames which relied on the current frame would trigger extra + // re-decoding of all frames in the dependency chain). + const bool frame_was_completely_decoded = + frame->GetStatus() == ImageFrame::kFrameComplete || all_data_received_; + PurgeAllFramesIfNecessary(decoder, frame_was_completely_decoded, + *frame_count); + + const bool should_remove_decoder = ShouldRemoveDecoder( + frame_was_completely_decoded, decode_to_external_memory); + if (resume_decoding) { + if (should_remove_decoder) { + ImageDecodingStore::Instance().RemoveDecoder(generator_, client_id_, + decoder); + } else { + ImageDecodingStore::Instance().UnlockDecoder(generator_, client_id_, + decoder); + } + } else if (!should_remove_decoder) { + // If we have a newly created decoder which we don't want to remove, add + // it to the cache. + ImageDecodingStore::Instance().InsertDecoder(generator_, client_id_, + std::move(new_decoder)); + } + + return true; +} + +bool ImageDecoderWrapper::ShouldDecodeToExternalMemory( + size_t frame_count, + bool resume_decoding) const { + // Multi-frame images need their decode cached in the decoder to allow using + // subsequent frames to be decoded by caching dependent frames. + // Also external allocators don't work for multi-frame images right now. + if (generator_->IsMultiFrame()) + return false; + + // On low-end devices, always use the external allocator, to avoid storing + // duplicate copies of the data for partial decodes in the ImageDecoder's + // cache. + if (Platform::Current()->IsLowEndDevice()) { + DCHECK(!resume_decoding); + return true; + } + + // TODO (scroggo): If !is_multi_frame_ && new_decoder && frame_count_, it + // should always be the case that 1u == frame_count_. But it looks like it + // is currently possible for frame_count_ to be another value. + if (1u == frame_count && all_data_received_ && !resume_decoding) { + // Also use external allocator in situations when all of the data has been + // received and there is not already a partial cache in the image decoder. + return true; + } + + return false; +} + +bool ImageDecoderWrapper::ShouldRemoveDecoder( + bool frame_was_completely_decoded, + bool decoded_to_external_memory) const { + // Mult-frame images need the decode cached to allow decoding subsequent + // frames without having to decode the complete dependency chain. For this + // reason, we should never be decoding directly to external memory for these + // images. + if (generator_->IsMultiFrame()) { + DCHECK(!decoded_to_external_memory); + return false; + } + + // If the decode was done directly to external memory, the decoder has no + // data to cache. Remove it. + if (decoded_to_external_memory) + return true; + + // If we were caching a decoder with a partially decoded frame which has + // now been completely decoded, we don't need to cache this decoder anymore. + if (frame_was_completely_decoded) + return true; + + return false; +} + +void ImageDecoderWrapper::PurgeAllFramesIfNecessary( + ImageDecoder* decoder, + bool frame_was_completely_decoded, + size_t frame_count) const { + // We only purge all frames when we have decoded the last frame for a + // multi-frame image. This is because once the last frame is decoded, the + // animation will loop back to the first frame which does not need the last + // frame as a dependency and therefore can be purged. + // For single-frame images, the complete decoder is removed once it has been + // completely decoded. + if (!generator_->IsMultiFrame()) + return; + + // The frame was only partially decoded, we need to retain it to be able to + // resume the decoder. + if (!frame_was_completely_decoded) + return; + + const size_t last_frame_index = frame_count - 1; + if (frame_index_ == last_frame_index) + decoder->ClearCacheExceptFrame(kNotFound); +} + +std::unique_ptr<ImageDecoder> ImageDecoderWrapper::CreateDecoderWithData( + ImageDecoderFactory* factory) const { + if (factory) { + auto decoder = factory->Create(); + if (decoder) + decoder->SetData(data_, all_data_received_); + return decoder; + } + + // The newly created decoder just grabbed the data. No need to reset it. + return ImageDecoder::Create(data_, all_data_received_, alpha_option_, + decoding_option_, decoder_color_behavior_, + scaled_size_); +} + +} // namespace blink
diff --git a/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.h b/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.h new file mode 100644 index 0000000..f9008ff --- /dev/null +++ b/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.h
@@ -0,0 +1,70 @@ +// Copyright 2017 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef THIRD_PARTY_BLINK_RENDERER_PLATFORM_GRAPHICS_IMAGE_DECODER_WRAPPER_H_ +#define THIRD_PARTY_BLINK_RENDERER_PLATFORM_GRAPHICS_IMAGE_DECODER_WRAPPER_H_ + +#include "cc/paint/paint_image.h" +#include "third_party/blink/renderer/platform/image-decoders/image_decoder.h" +#include "third_party/skia/include/core/SkSize.h" + +namespace blink { +class ImageDecoderFactory; +class ImageFrameGenerator; +class SegmentReader; + +class ImageDecoderWrapper { + public: + ImageDecoderWrapper(ImageFrameGenerator* generator, + SegmentReader* data, + const SkISize& scaled_size, + ImageDecoder::AlphaOption alpha_option, + ColorBehavior decoder_color_behavior, + ImageDecoder::HighBitDepthDecodingOption decoding_option, + size_t index, + const SkImageInfo& info, + void* pixels, + size_t row_bytes, + bool all_data_received, + cc::PaintImage::GeneratorClientId client_id); + ~ImageDecoderWrapper(); + + // Returns true if the decode succeeded. + bool Decode(ImageDecoderFactory* factory, + size_t* frame_count, + bool* has_alpha); + + // Indicates that the decode failed due to a corrupt image. + bool decode_failed() const { return decode_failed_; } + + private: + bool ShouldDecodeToExternalMemory(size_t frame_count, + bool has_cached_decoder) const; + bool ShouldRemoveDecoder(bool frame_was_completely_decoded, + bool decoded_to_external_memory) const; + void PurgeAllFramesIfNecessary(ImageDecoder* decoder, + bool frame_was_completely_decoded, + size_t frame_count) const; + std::unique_ptr<ImageDecoder> CreateDecoderWithData( + ImageDecoderFactory* factory) const; + + const ImageFrameGenerator* const generator_; + SegmentReader* data_; + const SkISize scaled_size_; + const ImageDecoder::AlphaOption alpha_option_; + const ColorBehavior decoder_color_behavior_; + const ImageDecoder::HighBitDepthDecodingOption decoding_option_; + const size_t frame_index_; + const SkImageInfo info_; + void* pixels_; + const size_t row_bytes_; + const bool all_data_received_; + const cc::PaintImage::GeneratorClientId client_id_; + + bool decode_failed_ = false; +}; + +} // namespace blink + +#endif // THIRD_PARTY_BLINK_RENDERER_PLATFORM_GRAPHICS_IMAGE_DECODER_WRAPPER_H_
diff --git a/third_party/blink/renderer/platform/graphics/image_decoding_store.cc b/third_party/blink/renderer/platform/graphics/image_decoding_store.cc index 02fff1a6..ce30ef7 100644 --- a/third_party/blink/renderer/platform/graphics/image_decoding_store.cc +++ b/third_party/blink/renderer/platform/graphics/image_decoding_store.cc
@@ -56,15 +56,18 @@ return store; } -bool ImageDecodingStore::LockDecoder(const ImageFrameGenerator* generator, - const SkISize& scaled_size, - ImageDecoder::AlphaOption alpha_option, - ImageDecoder** decoder) { +bool ImageDecodingStore::LockDecoder( + const ImageFrameGenerator* generator, + const SkISize& scaled_size, + ImageDecoder::AlphaOption alpha_option, + cc::PaintImage::GeneratorClientId client_id, + ImageDecoder** decoder) { DCHECK(decoder); MutexLocker lock(mutex_); - DecoderCacheMap::iterator iter = decoder_cache_map_.find( - DecoderCacheEntry::MakeCacheKey(generator, scaled_size, alpha_option)); + DecoderCacheMap::iterator iter = + decoder_cache_map_.find(DecoderCacheEntry::MakeCacheKey( + generator, scaled_size, alpha_option, client_id)); if (iter == decoder_cache_map_.end()) return false; @@ -77,11 +80,13 @@ return true; } -void ImageDecodingStore::UnlockDecoder(const ImageFrameGenerator* generator, - const ImageDecoder* decoder) { +void ImageDecodingStore::UnlockDecoder( + const ImageFrameGenerator* generator, + cc::PaintImage::GeneratorClientId client_id, + const ImageDecoder* decoder) { MutexLocker lock(mutex_); DecoderCacheMap::iterator iter = decoder_cache_map_.find( - DecoderCacheEntry::MakeCacheKey(generator, decoder)); + DecoderCacheEntry::MakeCacheKey(generator, decoder, client_id)); SECURITY_DCHECK(iter != decoder_cache_map_.end()); CacheEntry* cache_entry = iter->value.get(); @@ -92,13 +97,15 @@ ordered_cache_list_.Append(cache_entry); } -void ImageDecodingStore::InsertDecoder(const ImageFrameGenerator* generator, - std::unique_ptr<ImageDecoder> decoder) { +void ImageDecodingStore::InsertDecoder( + const ImageFrameGenerator* generator, + cc::PaintImage::GeneratorClientId client_id, + std::unique_ptr<ImageDecoder> decoder) { // Prune old cache entries to give space for the new one. Prune(); std::unique_ptr<DecoderCacheEntry> new_cache_entry = - DecoderCacheEntry::Create(generator, std::move(decoder)); + DecoderCacheEntry::Create(generator, std::move(decoder), client_id); MutexLocker lock(mutex_); DCHECK(!decoder_cache_map_.Contains(new_cache_entry->CacheKey())); @@ -106,13 +113,15 @@ &decoder_cache_key_map_); } -void ImageDecodingStore::RemoveDecoder(const ImageFrameGenerator* generator, - const ImageDecoder* decoder) { +void ImageDecodingStore::RemoveDecoder( + const ImageFrameGenerator* generator, + cc::PaintImage::GeneratorClientId client_id, + const ImageDecoder* decoder) { Vector<std::unique_ptr<CacheEntry>> cache_entries_to_delete; { MutexLocker lock(mutex_); DecoderCacheMap::iterator iter = decoder_cache_map_.find( - DecoderCacheEntry::MakeCacheKey(generator, decoder)); + DecoderCacheEntry::MakeCacheKey(generator, decoder, client_id)); SECURITY_DCHECK(iter != decoder_cache_map_.end()); CacheEntry* cache_entry = iter->value.get(); @@ -241,6 +250,8 @@ U* cache_map, V* identifier_map, Vector<std::unique_ptr<CacheEntry>>* deletion_list) { + DCHECK_EQ(cache_entry->UseCount(), 0); + const size_t cache_entry_bytes = cache_entry->MemoryUsageInBytes(); DCHECK_GE(heap_memory_usage_in_bytes_, cache_entry_bytes); heap_memory_usage_in_bytes_ -= cache_entry_bytes;
diff --git a/third_party/blink/renderer/platform/graphics/image_decoding_store.h b/third_party/blink/renderer/platform/graphics/image_decoding_store.h index 77cd5bf9..91a6071 100644 --- a/third_party/blink/renderer/platform/graphics/image_decoding_store.h +++ b/third_party/blink/renderer/platform/graphics/image_decoding_store.h
@@ -33,6 +33,7 @@ #include "SkTypes.h" #include "base/macros.h" #include "base/memory/ptr_util.h" +#include "cc/paint/paint_image_generator.h" #include "third_party/blink/renderer/platform/graphics/image_frame_generator.h" #include "third_party/blink/renderer/platform/graphics/skia/sk_size_hash.h" #include "third_party/blink/renderer/platform/image-decoders/image_decoder.h" @@ -52,17 +53,19 @@ const blink::ImageFrameGenerator* gen_; SkISize size_; blink::ImageDecoder::AlphaOption alpha_option_; + cc::PaintImage::GeneratorClientId client_id_; DecoderCacheKey() : gen_(nullptr), size_(SkISize::Make(0, 0)), - alpha_option_(static_cast<blink::ImageDecoder::AlphaOption>(0)) {} + alpha_option_(static_cast<blink::ImageDecoder::AlphaOption>(0)), + client_id_(cc::PaintImage::kDefaultGeneratorClientId) {} }; static inline bool operator==(const DecoderCacheKey& a, const DecoderCacheKey& b) { return a.gen_ == b.gen_ && a.size_ == b.size_ && - a.alpha_option_ == b.alpha_option_; + a.alpha_option_ == b.alpha_option_ && a.client_id_ == b.client_id_; } static inline bool operator!=(const DecoderCacheKey& a, @@ -116,9 +119,10 @@ public: static std::unique_ptr<DecoderCacheEntry> Create( const ImageFrameGenerator* generator, - std::unique_ptr<ImageDecoder> decoder) { + std::unique_ptr<ImageDecoder> decoder, + cc::PaintImage::GeneratorClientId client_id) { return base::WrapUnique( - new DecoderCacheEntry(generator, 0, std::move(decoder))); + new DecoderCacheEntry(generator, 0, std::move(decoder), client_id)); } size_t MemoryUsageInBytes() const override { @@ -126,40 +130,48 @@ } CacheType GetType() const override { return kTypeDecoder; } - static DecoderCacheKey MakeCacheKey(const ImageFrameGenerator* generator, - const SkISize& size, - ImageDecoder::AlphaOption alpha_option) { + static DecoderCacheKey MakeCacheKey( + const ImageFrameGenerator* generator, + const SkISize& size, + ImageDecoder::AlphaOption alpha_option, + cc::PaintImage::GeneratorClientId client_id) { DecoderCacheKey key; key.gen_ = generator; key.size_ = size; key.alpha_option_ = alpha_option; + key.client_id_ = client_id; return key; } - static DecoderCacheKey MakeCacheKey(const ImageFrameGenerator* generator, - const ImageDecoder* decoder) { + static DecoderCacheKey MakeCacheKey( + const ImageFrameGenerator* generator, + const ImageDecoder* decoder, + cc::PaintImage::GeneratorClientId client_id) { return MakeCacheKey(generator, SkISize::Make(decoder->DecodedSize().Width(), decoder->DecodedSize().Height()), - decoder->GetAlphaOption()); + decoder->GetAlphaOption(), client_id); } DecoderCacheKey CacheKey() const { - return MakeCacheKey(generator_, size_, alpha_option_); + return MakeCacheKey(generator_, size_, alpha_option_, client_id_); } ImageDecoder* CachedDecoder() const { return cached_decoder_.get(); } private: DecoderCacheEntry(const ImageFrameGenerator* generator, int count, - std::unique_ptr<ImageDecoder> decoder) + std::unique_ptr<ImageDecoder> decoder, + cc::PaintImage::GeneratorClientId client_id) : CacheEntry(generator, count), cached_decoder_(std::move(decoder)), size_(SkISize::Make(cached_decoder_->DecodedSize().Width(), cached_decoder_->DecodedSize().Height())), - alpha_option_(cached_decoder_->GetAlphaOption()) {} + alpha_option_(cached_decoder_->GetAlphaOption()), + client_id_(client_id) {} std::unique_ptr<ImageDecoder> cached_decoder_; SkISize size_; ImageDecoder::AlphaOption alpha_option_; + cc::PaintImage::GeneratorClientId client_id_; }; } // namespace blink @@ -172,17 +184,19 @@ struct Hash { STATIC_ONLY(Hash); static unsigned GetHash(const blink::DecoderCacheKey& p) { - return HashInts( + auto first = HashInts(DefaultHash<blink::ImageFrameGenerator*>::Hash::GetHash( const_cast<blink::ImageFrameGenerator*>(p.gen_)), - DefaultHash<SkISize>::Hash::GetHash(p.size_)), - DefaultHash<uint8_t>::Hash::GetHash( - static_cast<uint8_t>(p.alpha_option_))); + DefaultHash<SkISize>::Hash::GetHash(p.size_)); + auto second = HashInts(DefaultHash<uint8_t>::Hash::GetHash( + static_cast<uint8_t>(p.alpha_option_)), + p.client_id_); + return HashInts(first, second); } static bool Equal(const blink::DecoderCacheKey& a, const blink::DecoderCacheKey& b) { return a.gen_ == b.gen_ && a.size_ == b.size_ && - a.alpha_option_ == b.alpha_option_; + a.alpha_option_ == b.alpha_option_ && a.client_id_ == b.client_id_; } static const bool safe_to_compare_to_empty_or_deleted = true; }; @@ -196,12 +210,14 @@ static blink::DecoderCacheKey EmptyValue() { return blink::DecoderCacheEntry::MakeCacheKey( nullptr, SkISize::Make(0, 0), - static_cast<blink::ImageDecoder::AlphaOption>(0)); + static_cast<blink::ImageDecoder::AlphaOption>(0), + cc::PaintImage::kDefaultGeneratorClientId); } static void ConstructDeletedValue(blink::DecoderCacheKey& slot, bool) { slot = blink::DecoderCacheEntry::MakeCacheKey( nullptr, SkISize::Make(-1, -1), - static_cast<blink::ImageDecoder::AlphaOption>(0)); + static_cast<blink::ImageDecoder::AlphaOption>(0), + cc::PaintImage::kDefaultGeneratorClientId); } static bool IsDeletedValue(const blink::DecoderCacheKey& value) { return value.size_ == SkISize::Make(-1, -1); @@ -248,10 +264,17 @@ bool LockDecoder(const ImageFrameGenerator*, const SkISize& scaled_size, ImageDecoder::AlphaOption, + cc::PaintImage::GeneratorClientId client_id, ImageDecoder**); - void UnlockDecoder(const ImageFrameGenerator*, const ImageDecoder*); - void InsertDecoder(const ImageFrameGenerator*, std::unique_ptr<ImageDecoder>); - void RemoveDecoder(const ImageFrameGenerator*, const ImageDecoder*); + void UnlockDecoder(const ImageFrameGenerator*, + cc::PaintImage::GeneratorClientId client_id, + const ImageDecoder*); + void InsertDecoder(const ImageFrameGenerator*, + cc::PaintImage::GeneratorClientId client_id, + std::unique_ptr<ImageDecoder>); + void RemoveDecoder(const ImageFrameGenerator*, + cc::PaintImage::GeneratorClientId client_id, + const ImageDecoder*); // Remove all cache entries indexed by ImageFrameGenerator. void RemoveCacheIndexedByGenerator(const ImageFrameGenerator*);
diff --git a/third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc b/third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc index 4050078..ce45677d 100644 --- a/third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc +++ b/third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc
@@ -79,18 +79,21 @@ std::unique_ptr<ImageDecoder> decoder = MockImageDecoder::Create(this); decoder->SetSize(1, 1); const ImageDecoder* ref_decoder = decoder.get(); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder)); EXPECT_EQ(1, ImageDecodingStore::Instance().CacheEntries()); EXPECT_EQ(4u, ImageDecodingStore::Instance().MemoryUsageInBytes()); ImageDecoder* test_decoder; EXPECT_TRUE(ImageDecodingStore::Instance().LockDecoder( generator_.get(), size, ImageDecoder::kAlphaPremultiplied, - &test_decoder)); + cc::PaintImage::kDefaultGeneratorClientId, &test_decoder)); EXPECT_TRUE(test_decoder); EXPECT_EQ(ref_decoder, test_decoder); - ImageDecodingStore::Instance().UnlockDecoder(generator_.get(), test_decoder); + ImageDecodingStore::Instance().UnlockDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + test_decoder); EXPECT_EQ(1, ImageDecodingStore::Instance().CacheEntries()); } @@ -101,12 +104,15 @@ decoder1->SetSize(1, 1); decoder2->SetSize(2, 2); decoder3->SetSize(3, 3); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder1)); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder2)); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder3)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder1)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder2)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder3)); EXPECT_EQ(3, ImageDecodingStore::Instance().CacheEntries()); EXPECT_EQ(56u, ImageDecodingStore::Instance().MemoryUsageInBytes()); @@ -130,18 +136,21 @@ decoder1->SetSize(1, 1); decoder2->SetSize(2, 2); decoder3->SetSize(3, 3); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder1)); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder2)); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder3)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder1)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder2)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder3)); EXPECT_EQ(3, ImageDecodingStore::Instance().CacheEntries()); ImageDecoder* test_decoder; EXPECT_TRUE(ImageDecodingStore::Instance().LockDecoder( generator_.get(), SkISize::Make(2, 2), ImageDecoder::kAlphaPremultiplied, - &test_decoder)); + cc::PaintImage::kDefaultGeneratorClientId, &test_decoder)); EvictOneCache(); EvictOneCache(); @@ -149,7 +158,9 @@ EXPECT_EQ(1, ImageDecodingStore::Instance().CacheEntries()); EXPECT_EQ(16u, ImageDecodingStore::Instance().MemoryUsageInBytes()); - ImageDecodingStore::Instance().UnlockDecoder(generator_.get(), test_decoder); + ImageDecodingStore::Instance().UnlockDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + test_decoder); EvictOneCache(); EXPECT_FALSE(ImageDecodingStore::Instance().CacheEntries()); EXPECT_FALSE(ImageDecodingStore::Instance().MemoryUsageInBytes()); @@ -160,23 +171,66 @@ std::unique_ptr<ImageDecoder> decoder = MockImageDecoder::Create(this); decoder->SetSize(1, 1); const ImageDecoder* ref_decoder = decoder.get(); - ImageDecodingStore::Instance().InsertDecoder(generator_.get(), - std::move(decoder)); + ImageDecodingStore::Instance().InsertDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + std::move(decoder)); EXPECT_EQ(1, ImageDecodingStore::Instance().CacheEntries()); EXPECT_EQ(4u, ImageDecodingStore::Instance().MemoryUsageInBytes()); ImageDecoder* test_decoder; EXPECT_TRUE(ImageDecodingStore::Instance().LockDecoder( generator_.get(), size, ImageDecoder::kAlphaPremultiplied, - &test_decoder)); + cc::PaintImage::kDefaultGeneratorClientId, &test_decoder)); EXPECT_TRUE(test_decoder); EXPECT_EQ(ref_decoder, test_decoder); - ImageDecodingStore::Instance().RemoveDecoder(generator_.get(), test_decoder); + ImageDecodingStore::Instance().RemoveDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + test_decoder); EXPECT_FALSE(ImageDecodingStore::Instance().CacheEntries()); EXPECT_FALSE(ImageDecodingStore::Instance().LockDecoder( generator_.get(), size, ImageDecoder::kAlphaPremultiplied, - &test_decoder)); + cc::PaintImage::kDefaultGeneratorClientId, &test_decoder)); +} + +TEST_F(ImageDecodingStoreTest, MultipleClientsForSameGenerator) { + ImageDecodingStore::Instance().Clear(); + ASSERT_EQ(ImageDecodingStore::Instance().CacheEntries(), 0); + + const SkISize size = SkISize::Make(1, 1); + + std::unique_ptr<ImageDecoder> decoder = MockImageDecoder::Create(this); + ImageDecoder* decoder_1 = decoder.get(); + decoder_1->SetSize(1, 1); + auto client_id_1 = cc::PaintImage::GetNextGeneratorClientId(); + ImageDecodingStore::Instance().InsertDecoder(generator_.get(), client_id_1, + std::move(decoder)); + EXPECT_EQ(ImageDecodingStore::Instance().CacheEntries(), 1); + + decoder = MockImageDecoder::Create(this); + ImageDecoder* decoder_2 = decoder.get(); + decoder_2->SetSize(1, 1); + auto client_id_2 = cc::PaintImage::GetNextGeneratorClientId(); + ImageDecodingStore::Instance().InsertDecoder(generator_.get(), client_id_2, + std::move(decoder)); + EXPECT_EQ(ImageDecodingStore::Instance().CacheEntries(), 2); + + ImageDecoder* cached_decoder = nullptr; + ImageDecodingStore::Instance().LockDecoder(generator_.get(), size, + ImageDecoder::kAlphaPremultiplied, + client_id_1, &cached_decoder); + EXPECT_EQ(decoder_1, cached_decoder); + + ImageDecodingStore::Instance().LockDecoder(generator_.get(), size, + ImageDecoder::kAlphaPremultiplied, + client_id_2, &cached_decoder); + EXPECT_EQ(decoder_2, cached_decoder); + + ImageDecodingStore::Instance().RemoveDecoder(generator_.get(), client_id_1, + decoder_1); + ImageDecodingStore::Instance().RemoveDecoder(generator_.get(), client_id_2, + decoder_2); + EXPECT_EQ(ImageDecodingStore::Instance().CacheEntries(), 0); } } // namespace blink
diff --git a/third_party/blink/renderer/platform/graphics/image_frame_generator.cc b/third_party/blink/renderer/platform/graphics/image_frame_generator.cc index 3b0a7a07..0b3c8d3 100644 --- a/third_party/blink/renderer/platform/graphics/image_frame_generator.cc +++ b/third_party/blink/renderer/platform/graphics/image_frame_generator.cc
@@ -30,6 +30,7 @@ #include "SkData.h" #include "base/macros.h" +#include "third_party/blink/renderer/platform/graphics/image_decoder_wrapper.h" #include "third_party/blink/renderer/platform/graphics/image_decoding_store.h" #include "third_party/blink/renderer/platform/image-decoders/image_decoder.h" #include "third_party/blink/renderer/platform/instrumentation/tracing/trace_event.h" @@ -37,67 +38,6 @@ namespace blink { -static void CopyPixels(void* dst_addr, - size_t dst_row_bytes, - const void* src_addr, - size_t src_row_bytes, - const SkImageInfo& info) { - size_t row_bytes = info.bytesPerPixel() * info.width(); - for (int y = 0; y < info.height(); ++y) { - memcpy(dst_addr, src_addr, row_bytes); - src_addr = static_cast<const char*>(src_addr) + src_row_bytes; - dst_addr = static_cast<char*>(dst_addr) + dst_row_bytes; - } -} - -static bool CompatibleInfo(const SkImageInfo& src, const SkImageInfo& dst) { - if (src == dst) - return true; - - // It is legal to write kOpaque_SkAlphaType pixels into a kPremul_SkAlphaType - // buffer. This can happen when DeferredImageDecoder allocates an - // kOpaque_SkAlphaType image generator based on cached frame info, while the - // ImageFrame-allocated dest bitmap stays kPremul_SkAlphaType. - if (src.alphaType() == kOpaque_SkAlphaType && - dst.alphaType() == kPremul_SkAlphaType) { - const SkImageInfo& tmp = src.makeAlphaType(kPremul_SkAlphaType); - return tmp == dst; - } - - return false; -} - -// Creates a SkPixelRef such that the memory for pixels is given by an external -// body. This is used to write directly to the memory given by Skia during -// decoding. -class ExternalMemoryAllocator final : public SkBitmap::Allocator { - USING_FAST_MALLOC(ExternalMemoryAllocator); - - public: - ExternalMemoryAllocator(const SkImageInfo& info, - void* pixels, - size_t row_bytes) - : info_(info), pixels_(pixels), row_bytes_(row_bytes) {} - - bool allocPixelRef(SkBitmap* dst) override { - const SkImageInfo& info = dst->info(); - if (kUnknown_SkColorType == info.colorType()) - return false; - - if (!CompatibleInfo(info_, info) || row_bytes_ != dst->rowBytes()) - return false; - - return dst->installPixels(info, pixels_, row_bytes_); - } - - private: - SkImageInfo info_; - void* pixels_; - size_t row_bytes_; - - DISALLOW_COPY_AND_ASSIGN(ExternalMemoryAllocator); -}; - static bool UpdateYUVComponentSizes(ImageDecoder* decoder, SkISize component_sizes[3], size_t component_width_bytes[3]) { @@ -120,9 +60,6 @@ : full_size_(full_size), decoder_color_behavior_(color_behavior), is_multi_frame_(is_multi_frame), - decode_failed_(false), - yuv_decoding_failed_(false), - frame_count_(0), supported_sizes_(std::move(supported_sizes)) { #if DCHECK_IS_ON() // Verify that sizes are in an increasing order, since @@ -146,45 +83,63 @@ const SkImageInfo& info, void* pixels, size_t row_bytes, - ImageDecoder::AlphaOption alpha_option) { - if (decode_failed_) - return false; + ImageDecoder::AlphaOption alpha_option, + cc::PaintImage::GeneratorClientId client_id) { + { + MutexLocker lock(generator_mutex_); + if (decode_failed_) + return false; + } - TRACE_EVENT1("blink", "ImageFrameGenerator::decodeAndScale", "frame index", - static_cast<int>(index)); - - // Lock the mutex, so only one thread can use the decoder at once. - MutexLocker lock(decode_mutex_); + TRACE_EVENT1("blink", "ImageFrameGenerator::decodeAndScale", "generator", + this); // This implementation does not support arbitrary scaling so check the // requested size. SkISize scaled_size = SkISize::Make(info.width(), info.height()); CHECK(GetSupportedDecodeSize(scaled_size) == scaled_size); - // It is okay to allocate ref-counted ExternalMemoryAllocator on the stack, - // because 1) it contains references to memory that will be invalid after - // returning (i.e. a pointer to |pixels|) and therefore 2) should not live - // longer than the call to the current method. - ExternalMemoryAllocator external_allocator(info, pixels, row_bytes); ImageDecoder::HighBitDepthDecodingOption high_bit_depth_decoding_option = ImageDecoder::kDefaultBitDepth; if (info.colorType() == kRGBA_F16_SkColorType) { high_bit_depth_decoding_option = ImageDecoder::kHighBitDepthToHalfFloat; } - SkBitmap bitmap = TryToResumeDecode( - data, all_data_received, index, scaled_size, external_allocator, - alpha_option, high_bit_depth_decoding_option); - DCHECK(external_allocator.unique()); // Verify we have the only ref-count. - if (bitmap.isNull()) + size_t frame_count = 0u; + bool has_alpha = true; + + // |decode_failed| indicates a failure due to a corrupt image. + bool decode_failed = false; + // |current_decode_succeeded| indicates a failure to decode the current frame. + // Its possible to have a valid but fail to decode a frame in the case where + // we don't have enough data to decode this particular frame yet. + bool current_decode_succeeded = false; + { + // Lock the mutex, so only one thread can use the decoder at once. + ClientMutexLocker lock(this, client_id); + ImageDecoderWrapper decoder_wrapper( + this, data, scaled_size, alpha_option, decoder_color_behavior_, + high_bit_depth_decoding_option, index, info, pixels, row_bytes, + all_data_received, client_id); + current_decode_succeeded = decoder_wrapper.Decode( + image_decoder_factory_.get(), &frame_count, &has_alpha); + decode_failed = decoder_wrapper.decode_failed(); + } + + MutexLocker lock(generator_mutex_); + decode_failed_ = decode_failed; + if (decode_failed_) { + DCHECK(!current_decode_succeeded); + return false; + } + + if (!current_decode_succeeded) return false; - // Check to see if the decoder has written directly to the pixel memory - // provided. If not, make a copy. - DCHECK_EQ(bitmap.width(), scaled_size.width()); - DCHECK_EQ(bitmap.height(), scaled_size.height()); - if (bitmap.getPixels() != pixels) - CopyPixels(pixels, row_bytes, bitmap.getPixels(), bitmap.rowBytes(), info); + SetHasAlpha(index, has_alpha); + if (frame_count != 0u) + frame_count_ = frame_count; + return true; } @@ -193,6 +148,8 @@ const SkISize component_sizes[3], void* planes[3], const size_t row_bytes[3]) { + MutexLocker lock(generator_mutex_); + // TODO (scroggo): The only interesting thing this uses from the // ImageFrameGenerator is m_decodeFailed. Move this into // DecodingImageGenerator, which is the only class that calls it. @@ -231,88 +188,9 @@ return false; } -SkBitmap ImageFrameGenerator::TryToResumeDecode( - SegmentReader* data, - bool all_data_received, - size_t index, - const SkISize& scaled_size, - SkBitmap::Allocator& allocator, - ImageDecoder::AlphaOption alpha_option, - ImageDecoder::HighBitDepthDecodingOption high_bit_depth_decoding_option) { - decode_mutex_.AssertAcquired(); - - TRACE_EVENT1("blink", "ImageFrameGenerator::tryToResumeDecode", "frame index", - static_cast<int>(index)); - - ImageDecoder* decoder = nullptr; - const bool resume_decoding = ImageDecodingStore::Instance().LockDecoder( - this, scaled_size, alpha_option, &decoder); - DCHECK(!resume_decoding || decoder); - - bool used_external_allocator = false; - ImageFrame* current_frame = Decode( - data, all_data_received, index, &decoder, allocator, alpha_option, - high_bit_depth_decoding_option, scaled_size, used_external_allocator); - - if (!decoder) - return SkBitmap(); - - // If we are not resuming decoding that means the decoder is freshly - // created and we have ownership. If we are resuming decoding then - // the decoder is owned by ImageDecodingStore. - std::unique_ptr<ImageDecoder> decoder_container; - if (!resume_decoding) - decoder_container = base::WrapUnique(decoder); - - if (!current_frame || current_frame->Bitmap().isNull()) { - // If decoding has failed, we can save work in the future by - // ignoring further requests to decode the image. - decode_failed_ = decoder->Failed(); - if (resume_decoding) - ImageDecodingStore::Instance().UnlockDecoder(this, decoder); - return SkBitmap(); - } - - SkBitmap scaled_size_bitmap = current_frame->Bitmap(); - DCHECK_EQ(scaled_size_bitmap.width(), scaled_size.width()); - DCHECK_EQ(scaled_size_bitmap.height(), scaled_size.height()); - SetHasAlpha(index, !scaled_size_bitmap.isOpaque()); - - // Free as much memory as possible. For single-frame images, we can - // just delete the decoder entirely if they use the external allocator. - // For multi-frame images, we keep the decoder around in order to preserve - // decoded information such as the required previous frame indexes, but if - // we've reached the last frame we can at least delete all the cached frames. - // (If we were to do this before reaching the last frame, any subsequent - // requested frames which relied on the current frame would trigger extra - // re-decoding of all frames in the dependency chain. - bool remove_decoder = false; - if (current_frame->GetStatus() == ImageFrame::kFrameComplete || - all_data_received) { - if (!is_multi_frame_) { - remove_decoder = true; - } else if (index == frame_count_ - 1) { - decoder->ClearCacheExceptFrame(kNotFound); - } - } else if (used_external_allocator) { - remove_decoder = true; - } - - if (resume_decoding) { - if (remove_decoder) - ImageDecodingStore::Instance().RemoveDecoder(this, decoder); - else - ImageDecodingStore::Instance().UnlockDecoder(this, decoder); - } else if (!remove_decoder) { - ImageDecodingStore::Instance().InsertDecoder(this, - std::move(decoder_container)); - } - - return scaled_size_bitmap; -} - void ImageFrameGenerator::SetHasAlpha(size_t index, bool has_alpha) { - MutexLocker lock(alpha_mutex_); + generator_mutex_.AssertAcquired(); + if (index >= has_alpha_.size()) { const size_t old_size = has_alpha_.size(); has_alpha_.resize(index + 1); @@ -322,93 +200,9 @@ has_alpha_[index] = has_alpha; } -ImageFrame* ImageFrameGenerator::Decode( - SegmentReader* data, - bool all_data_received, - size_t index, - ImageDecoder** decoder, - SkBitmap::Allocator& allocator, - ImageDecoder::AlphaOption alpha_option, - ImageDecoder::HighBitDepthDecodingOption high_bit_depth_decoding_option, - const SkISize& scaled_size, - bool& used_external_allocator) { - decode_mutex_.AssertAcquired(); - TRACE_EVENT2("blink", "ImageFrameGenerator::decode", "width", - full_size_.width(), "height", full_size_.height()); - - // Try to create an ImageDecoder if we are not given one. - DCHECK(decoder); - bool new_decoder = false; - bool should_call_set_data = true; - if (!*decoder) { - new_decoder = true; - // TODO(vmpstr): The factory is only used for tests. We can convert all - // calls to use a factory so that we don't need to worry about this call. - if (image_decoder_factory_) - *decoder = image_decoder_factory_->Create().release(); - - if (!*decoder) { - *decoder = ImageDecoder::Create(data, all_data_received, alpha_option, - high_bit_depth_decoding_option, - decoder_color_behavior_, scaled_size) - .release(); - // The newly created decoder just grabbed the data. No need to reset it. - should_call_set_data = false; - } - - if (!*decoder) - return nullptr; - } - - if (should_call_set_data) - (*decoder)->SetData(data, all_data_received); - - // For multi-frame image decoders, we need to know how many frames are - // in that image in order to release the decoder when all frames are - // decoded. frameCount() is reliable only if all data is received and set in - // decoder, particularly with GIF. - if (all_data_received) - frame_count_ = (*decoder)->FrameCount(); - - used_external_allocator = false; - // External allocators don't work for multi-frame images right now. - if (!is_multi_frame_) { - if (Platform::Current()->IsLowEndDevice()) { - // On low-end devices, always use the external allocator, to avoid - // storing duplicate copies of the data in the ImageDecoder's cache. - used_external_allocator = true; - DCHECK(new_decoder); - // TODO (scroggo): If !is_multi_frame_ && new_decoder && frame_count_, it - // should always be the case that 1u == frame_count_. But it looks like it - // is currently possible for frame_count_ to be another value. - } else if (1u == frame_count_ && all_data_received && new_decoder) { - // Also use external allocator situations when all of the data has been - // received and there is not already a partial cache in the image decoder. - used_external_allocator = true; - } - } - - if (used_external_allocator) - (*decoder)->SetMemoryAllocator(&allocator); - - ImageFrame* frame = (*decoder)->DecodeFrameBufferAtIndex(index); - - // SetMemoryAllocator() can try to access decoder's data, so - // we have to do it before clearing SegmentReader. - if (used_external_allocator) - (*decoder)->SetMemoryAllocator(nullptr); - (*decoder)->SetData(scoped_refptr<SegmentReader>(nullptr), - false); // Unref SegmentReader from ImageDecoder. - (*decoder)->ClearCacheExceptFrame(index); - - if (!frame || frame->GetStatus() == ImageFrame::kFrameEmpty) - return nullptr; - - return frame; -} - bool ImageFrameGenerator::HasAlpha(size_t index) { - MutexLocker lock(alpha_mutex_); + MutexLocker lock(generator_mutex_); + if (index < has_alpha_.size()) return has_alpha_[index]; return true; @@ -419,6 +213,8 @@ TRACE_EVENT2("blink", "ImageFrameGenerator::getYUVComponentSizes", "width", full_size_.width(), "height", full_size_.height()); + MutexLocker lock(generator_mutex_); + if (yuv_decoding_failed_) return false; @@ -450,4 +246,35 @@ return full_size_; } +ImageFrameGenerator::ClientMutexLocker::ClientMutexLocker( + ImageFrameGenerator* generator, + cc::PaintImage::GeneratorClientId client_id) + : generator_(generator), client_id_(client_id) { + { + MutexLocker lock(generator_->generator_mutex_); + ClientMutex* client_mutex = nullptr; + auto it = generator_->mutex_map_.find(client_id_); + if (it == generator_->mutex_map_.end()) + client_mutex = &generator_->mutex_map_[client_id]; + else + client_mutex = &it->second; + client_mutex->ref_count++; + mutex_ = &client_mutex->mutex; + } + + mutex_->lock(); +} + +ImageFrameGenerator::ClientMutexLocker::~ClientMutexLocker() { + mutex_->unlock(); + + MutexLocker lock(generator_->generator_mutex_); + auto it = generator_->mutex_map_.find(client_id_); + DCHECK(it != generator_->mutex_map_.end()); + it->second.ref_count--; + + if (it->second.ref_count == 0) + generator_->mutex_map_.erase(it); +} + } // namespace blink
diff --git a/third_party/blink/renderer/platform/graphics/image_frame_generator.h b/third_party/blink/renderer/platform/graphics/image_frame_generator.h index 0e972e53..593722c 100644 --- a/third_party/blink/renderer/platform/graphics/image_frame_generator.h +++ b/third_party/blink/renderer/platform/graphics/image_frame_generator.h
@@ -30,6 +30,7 @@ #include "base/macros.h" #include "base/memory/scoped_refptr.h" +#include "cc/paint/paint_image.h" #include "third_party/blink/renderer/platform/image-decoders/image_decoder.h" #include "third_party/blink/renderer/platform/image-decoders/segment_reader.h" #include "third_party/blink/renderer/platform/platform_export.h" @@ -85,7 +86,8 @@ const SkImageInfo&, void* pixels, size_t row_bytes, - ImageDecoder::AlphaOption); + ImageDecoder::AlphaOption, + cc::PaintImage::GeneratorClientId); // Decodes YUV components directly into the provided memory planes. Must not // be called unless getYUVComponentSizes has been called and returned true. @@ -113,6 +115,18 @@ bool GetYUVComponentSizes(SegmentReader*, SkYUVSizeInfo*); private: + class ClientMutexLocker { + public: + ClientMutexLocker(ImageFrameGenerator* generator, + cc::PaintImage::GeneratorClientId client_id); + ~ClientMutexLocker(); + + private: + ImageFrameGenerator* generator_; + cc::PaintImage::GeneratorClientId client_id_; + Mutex* mutex_; + }; + ImageFrameGenerator(const SkISize& full_size, bool is_multi_frame, const ColorBehavior&, @@ -128,47 +142,31 @@ void SetHasAlpha(size_t index, bool has_alpha); - SkBitmap TryToResumeDecode(SegmentReader*, - bool all_data_received, - size_t index, - const SkISize& scaled_size, - SkBitmap::Allocator&, - ImageDecoder::AlphaOption, - ImageDecoder::HighBitDepthDecodingOption); - // This method should only be called while decode_mutex_ is locked. - // Returns a pointer to frame |index|'s ImageFrame, if available. - // Sets |used_external_allocator| to true if the the image was decoded into - // |external_allocator|'s memory. - ImageFrame* Decode(SegmentReader*, - bool all_data_received, - size_t index, - ImageDecoder**, - SkBitmap::Allocator& external_allocator, - ImageDecoder::AlphaOption, - ImageDecoder::HighBitDepthDecodingOption, - const SkISize& scaled_size, - bool& used_external_allocator); - const SkISize full_size_; - // Parameters used to create internal ImageDecoder objects. const ColorBehavior decoder_color_behavior_; - const bool is_multi_frame_; - bool decode_failed_; - bool yuv_decoding_failed_; - size_t frame_count_; + const std::vector<SkISize> supported_sizes_; + + // Prevents concurrent access to all variables below. + Mutex generator_mutex_; + + bool decode_failed_ = false; + bool yuv_decoding_failed_ = false; + size_t frame_count_ = 0u; Vector<bool> has_alpha_; - std::vector<SkISize> supported_sizes_; + + struct ClientMutex { + int ref_count = 0; + Mutex mutex; + }; + // Note that it is necessary to use unordered_map here to ensure that + // references to entries in the map, stored in ClientMutexLocker, remain valid + // across insertions into the map. + std::unordered_map<cc::PaintImage::GeneratorClientId, ClientMutex> mutex_map_; std::unique_ptr<ImageDecoderFactory> image_decoder_factory_; - // Prevents multiple decode operations on the same data. - Mutex decode_mutex_; - - // Protect concurrent access to has_alpha_. - Mutex alpha_mutex_; - DISALLOW_COPY_AND_ASSIGN(ImageFrameGenerator); };
diff --git a/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc b/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc index b9ad8b7..d4e87e911 100644 --- a/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc +++ b/third_party/blink/renderer/platform/graphics/image_frame_generator_test.cc
@@ -164,15 +164,15 @@ char buffer[100 * 100 * 4]; generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(1, decode_request_count_); EXPECT_EQ(0, memory_allocator_set_count_); AddNewData(); generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(2, decode_request_count_); EXPECT_EQ(0, decoders_destroyed_); EXPECT_EQ(0, memory_allocator_set_count_); @@ -191,8 +191,8 @@ char buffer[100 * 100 * 4]; generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(1, decode_request_count_); EXPECT_EQ(1, decoders_destroyed_); // The memory allocator is set to the external one, then cleared after decode. @@ -200,8 +200,8 @@ AddNewData(); generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(2, decode_request_count_); EXPECT_EQ(2, decoders_destroyed_); // The memory allocator is set to the external one, then cleared after decode. @@ -213,8 +213,8 @@ char buffer[100 * 100 * 4]; generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(1, decode_request_count_); EXPECT_EQ(0, decoders_destroyed_); EXPECT_EQ(0, memory_allocator_set_count_); @@ -223,15 +223,15 @@ AddNewData(); generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(2, decode_request_count_); EXPECT_EQ(1, decoders_destroyed_); // Decoder created again. generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(3, decode_request_count_); } @@ -239,7 +239,8 @@ SegmentReader* segment_reader) { char buffer[100 * 100 * 4]; generator->DecodeAndScale(segment_reader, false, 0, ImageInfo(), buffer, - 100 * 4, ImageDecoder::kAlphaPremultiplied); + 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); } TEST_F(ImageFrameGeneratorTest, incompleteDecodeBecomesCompleteMultiThreaded) { @@ -247,8 +248,8 @@ char buffer[100 * 100 * 4]; generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(1, decode_request_count_); EXPECT_EQ(0, decoders_destroyed_); @@ -268,8 +269,8 @@ // Decoder created again. generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(3, decode_request_count_); AddNewData(); @@ -283,24 +284,26 @@ char buffer[100 * 100 * 4]; generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_TRUE(generator_->HasAlpha(0)); EXPECT_EQ(1, decode_request_count_); ImageDecoder* temp_decoder = nullptr; EXPECT_TRUE(ImageDecodingStore::Instance().LockDecoder( generator_.get(), FullSize(), ImageDecoder::kAlphaPremultiplied, - &temp_decoder)); + cc::PaintImage::kDefaultGeneratorClientId, &temp_decoder)); ASSERT_TRUE(temp_decoder); temp_decoder->DecodeFrameBufferAtIndex(0)->SetHasAlpha(false); - ImageDecodingStore::Instance().UnlockDecoder(generator_.get(), temp_decoder); + ImageDecodingStore::Instance().UnlockDecoder( + generator_.get(), cc::PaintImage::kDefaultGeneratorClientId, + temp_decoder); EXPECT_EQ(2, decode_request_count_); SetFrameStatus(ImageFrame::kFrameComplete); generator_->DecodeAndScale(segment_reader_.get(), false, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(3, decode_request_count_); EXPECT_FALSE(generator_->HasAlpha(0)); } @@ -311,8 +314,8 @@ char buffer[100 * 100 * 4]; generator_->DecodeAndScale(segment_reader_.get(), true, 0, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(1, decode_request_count_); EXPECT_EQ(0, decoders_destroyed_); EXPECT_EQ(0U, requested_clear_except_frame_); @@ -320,8 +323,8 @@ SetFrameStatus(ImageFrame::kFrameComplete); generator_->DecodeAndScale(segment_reader_.get(), true, 1, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(2, decode_request_count_); EXPECT_EQ(0, decoders_destroyed_); EXPECT_EQ(1U, requested_clear_except_frame_); @@ -332,8 +335,8 @@ // all the frame data, but not destroying the decoder. See comments in // ImageFrameGenerator::tryToResumeDecode(). generator_->DecodeAndScale(segment_reader_.get(), true, 2, ImageInfo(), - buffer, 100 * 4, - ImageDecoder::kAlphaPremultiplied); + buffer, 100 * 4, ImageDecoder::kAlphaPremultiplied, + cc::PaintImage::kDefaultGeneratorClientId); EXPECT_EQ(3, decode_request_count_); EXPECT_EQ(0, decoders_destroyed_); EXPECT_EQ(kNotFound, requested_clear_except_frame_);
diff --git a/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h b/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h index ee54c46..824f0c7 100644 --- a/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h +++ b/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h
@@ -111,6 +111,8 @@ client_->MemoryAllocatorSet(); } + bool IsForTesting() const override { return true; } + private: void DecodeSize() override {}
diff --git a/third_party/blink/renderer/platform/image-decoders/image_decoder.cc b/third_party/blink/renderer/platform/image-decoders/image_decoder.cc index b4de4a17..c544780 100644 --- a/third_party/blink/renderer/platform/image-decoders/image_decoder.cc +++ b/third_party/blink/renderer/platform/image-decoders/image_decoder.cc
@@ -150,6 +150,8 @@ } ImageFrame* ImageDecoder::DecodeFrameBufferAtIndex(size_t index) { + TRACE_EVENT0("blink", "ImageDecoder::DecodeFrameBufferAtIndex"); + if (index >= FrameCount()) return nullptr; ImageFrame* frame = &frame_buffer_cache_[index];
diff --git a/third_party/blink/renderer/platform/image-decoders/image_decoder.h b/third_party/blink/renderer/platform/image-decoders/image_decoder.h index 1242a2e..280d0f5 100644 --- a/third_party/blink/renderer/platform/image-decoders/image_decoder.h +++ b/third_party/blink/renderer/platform/image-decoders/image_decoder.h
@@ -333,6 +333,8 @@ virtual bool DecodeToYUV() { return false; } virtual void SetImagePlanes(std::unique_ptr<ImagePlanes>) {} + virtual bool IsForTesting() const { return false; } + protected: ImageDecoder(AlphaOption alpha_option, HighBitDepthDecodingOption high_bit_depth_decoding_option,
diff --git a/third_party/blink/tools/apache_config/mime.types b/third_party/blink/tools/apache_config/mime.types index 6934e1b..6379488 100644 --- a/third_party/blink/tools/apache_config/mime.types +++ b/third_party/blink/tools/apache_config/mime.types
@@ -84,7 +84,7 @@ application/sgml application/sgml-open-catalog application/sieve -application/signed-exchange;v=b1 sxg +application/signed-exchange;v=b2 sxg application/slate application/smil smi smil application/srgs gram
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py index d9a889f..92f80d1 100755 --- a/tools/clang/scripts/update.py +++ b/tools/clang/scripts/update.py
@@ -836,8 +836,9 @@ RunCommand(['ninja', 'asan', 'ubsan', 'profile']) # And copy them into the main build tree. + asan_lib_path_format = 'lib/linux/libclang_rt.asan-{0}-android.so', libs_want = [ - 'lib/linux/libclang_rt.asan-{0}-android.so', + asan_lib_path_format, 'lib/linux/libclang_rt.ubsan_standalone-{0}-android.so', 'lib/linux/libclang_rt.profile-{0}-android.a', ] @@ -847,6 +848,11 @@ if os.path.exists(lib_path): shutil.copy(lib_path, rt_lib_dst_dir) + # We also use ASan i686 build for fuzzing. + lib_path = os.path.join(build_dir, asan_lib_path_format.format('i686')) + if os.path.exists(lib_path): + shutil.copy(lib_path, rt_lib_dst_dir) + # Run tests. if args.run_tests or use_head_revision: os.chdir(LLVM_BUILD_DIR)
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl index c05f5f69..bf0b6c6 100644 --- a/tools/mb/mb_config.pyl +++ b/tools/mb/mb_config.pyl
@@ -111,8 +111,8 @@ }, 'chromium.clang': { - 'CFI Linux CF': 'cfi_full_cfi_icall_cfi_diag_recover_release_static', - 'CFI Linux ToT': 'clang_tot_cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on', + 'CFI Linux CF': 'cfi_full_cfi_diag_recover_release_static', + 'CFI Linux ToT': 'clang_tot_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on', 'CrWinAsan': 'asan_clang_fuzzer_static_v8_heap_minimal_symbols_release_tot', 'CrWinAsan(dll)': 'asan_clang_shared_v8_heap_minimal_symbols_release_tot', 'CrWinAsanCov': 'asan_clang_edge_fuzzer_static_v8_heap_minimal_symbols_release_tot', @@ -157,8 +157,8 @@ 'Android Builder (dbg) Goma Canary': 'android_debug_static_bot_vrdata', - 'CFI Linux CF': 'cfi_full_cfi_icall_cfi_diag_recover_release_static', - 'CFI Linux ToT': 'clang_tot_cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on', + 'CFI Linux CF': 'cfi_full_cfi_diag_recover_release_static', + 'CFI Linux ToT': 'clang_tot_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on', 'chromeos-amd64-generic-rel-goma-canary': 'cros_chrome_sdk', 'chromeos-amd64-generic-rel-vm-tests': 'cros_chrome_sdk_headless_ozone_dcheck_always_on', @@ -350,7 +350,7 @@ 'chromium.memory': { 'Android CFI': 'android_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', 'Linux ASan LSan Builder': 'asan_lsan_release_trybot', - 'Linux CFI': 'cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', + 'Linux CFI': 'cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', 'Linux Chromium OS ASan LSan Builder': 'asan_lsan_chromeos_release_trybot', 'Linux ChromiumOS MSan Builder': 'chromeos_msan_release_bot', 'Linux MSan Builder': 'msan_release_bot', @@ -599,7 +599,7 @@ 'linux_arm': 'release_trybot_arm', 'linux_chromium_archive_rel_ng': 'release_bot', 'linux_chromium_asan_rel_ng': 'asan_lsan_release_trybot', - 'linux_chromium_cfi_rel_ng': 'cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', + 'linux_chromium_cfi_rel_ng': 'cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', 'linux_chromium_chromeos_asan_rel_ng': 'asan_lsan_chromeos_release_trybot', 'linux_chromium_chromeos_msan_rel_ng': 'chromeos_msan_release_bot', 'linux_chromium_clobber_deterministic': 'release_trybot', @@ -1025,12 +1025,12 @@ 'cast', 'cast_audio', 'release_trybot', ], - 'cfi_full_cfi_icall_cfi_diag_recover_release_static': [ - 'cfi_full', 'cfi_icall', 'cfi_diag', 'cfi_recover', 'thin_lto', 'release', 'static', + 'cfi_full_cfi_diag_recover_release_static': [ + 'cfi_full', 'cfi_diag', 'cfi_recover', 'thin_lto', 'release', 'static', ], - 'cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on_goma': [ - 'cfi_full', 'cfi_icall', 'cfi_diag', 'thin_lto', 'release', 'static', 'dcheck_always_on', 'goma', + 'cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on_goma': [ + 'cfi_full', 'cfi_diag', 'thin_lto', 'release', 'static', 'dcheck_always_on', 'goma', ], 'chromeos_asan_lsan_edge_fuzzer_v8_heap_release_bot': [ @@ -1061,8 +1061,8 @@ 'clang_tot', 'asan', 'lsan', 'static', 'release', ], - 'clang_tot_cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on': [ - 'clang_tot', 'cfi_full', 'cfi_icall', 'cfi_diag', 'thin_lto', 'release', 'static', 'dcheck_always_on', + 'clang_tot_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on': [ + 'clang_tot', 'cfi_full', 'cfi_diag', 'thin_lto', 'release', 'static', 'dcheck_always_on', ], 'clang_tot_cfi_full_cfi_diag_thin_lto_release_static_dcheck_always_on': [ @@ -1704,10 +1704,6 @@ 'gn_args': 'use_cfi_cast=true', }, - 'cfi_icall': { - 'gn_args': 'use_cfi_icall=true', - }, - 'cfi_diag': { 'gn_args': 'use_cfi_diag=true', },
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml index ef680cf..cebdcab 100644 --- a/tools/metrics/histograms/enums.xml +++ b/tools/metrics/histograms/enums.xml
@@ -19828,6 +19828,8 @@ <int value="2529" label="ReportingObserver"/> <int value="2530" label="DeprecationReport"/> <int value="2531" label="InterventionReport"/> + <int value="2532" label="V8WasmSharedMemory"/> + <int value="2533" label="V8WasmThreadOpcodes"/> </enum> <enum name="FeedbackSource">