Google Git
Sign in
chromium / chromium / src / ca64b0610c7b5119617f836093ea505a276b43c6
commitca64b0610c7b5119617f836093ea505a276b43c6[log] [tgz]
authorAyumi Ono <ayumiohno@google.com>Tue Dec 02 10:28:35 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Dec 02 10:28:35 2025
tree80dff18dc563cb4374701a2b90e2fef0cb288c75
parent9529e2b9dfd0c4a8a891e14f12666ef1ef3bd387 [diff]
PA: Restrict use_sized_deallocation’s assertion to Clang

In https://crrev.com/c/7136445, we added an assertion: !is_win ||
!is_component_build || use_sized_deallocation This assertion is to
prevent symbol mismatches with Abseil .def lists, which are created
expecting sized deallocation.

However, ANGLE MSVC builds (where is_clang is false) have
 use_sized_deallocation as false, triggering an assertion failure.
Since Abseil is not used in these builds, we restrict the assertion to
only run when is_clang is true.

Bug: 410190984
Change-Id: I2c040e6003ed17ee1d6677659ac4b4b37990e552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7214907
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Ayumi Ono <ayumiohno@google.com>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Mikihito Matsuura <mikt@google.com>
Cr-Commit-Position: refs/heads/main@{#1552695}
1 file changed
tree: 80dff18dc563cb4374701a2b90e2fef0cb288c75
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.