Google Git
Sign in
chromium / chromium / src / ca6ce1e43d27c37c95908e785ce7e4070b5bbe90
commitca6ce1e43d27c37c95908e785ce7e4070b5bbe90[log] [tgz]
authorHenrique Ferreiro <hferreiro@igalia.com>Tue Apr 25 16:25:28 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 25 16:25:28 2023
treeea06b37e7901c78a1e3130ecd77d52d2270c6423
parentd7d9590395dbe03de4aba2ee73e6a898a7d21d1d [diff]
Make sure ResourceBundle is always initialized

Many code relies on having access to the resource scale factors, in
particular, code to retrieve the maximum supported resource scale
factor: `ui::GetSupportedResourceScaleFactors().back()`. This CL ensures
that they are always available by adding more CHECKs and initializing
`ui::ResourceBundle` where that was missing.

Also, add `ui::GetMaxSupportedResourceScaleFactor` to replace the
aforementioned pattern making it more explicit and allowing to hit those
CHECKs.

Lastly, optimize `GetSupportedResourceScaleFactor(scale)` to return
early once we find a resource scale factor that isn't closer to
`scale`, since the list is sorted.

Bug: 1434785
Change-Id: I1a2d90d478332fd1f517e5e51680361c97d5d2e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401946
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1135249}
9 files changed
tree: ea06b37e7901c78a1e3130ecd77d52d2270c6423
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.